From 4877c8489b6c25ab5f05891b856c01cc9f8db410 Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 28 Apr 2017 12:51:22 +0000 Subject: [PATCH] Fix format_gcov to not print misleading values (PR gcov-profile/53915) 2017-04-28 Martin Liska PR gcov-profile/53915 * gcov.c (format_gcov): Print 'NAN %' when top > bottom. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@247375 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 5 +++++ gcc/gcov.c | 7 +++++++ 2 files changed, 12 insertions(+) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 63b6276c07d..608e0e96dab 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,10 @@ 2017-04-28 Martin Liska + PR gcov-profile/53915 + * gcov.c (format_gcov): Print 'NAN %' when top > bottom. + +2017-04-28 Martin Liska + PR gcov-profile/79891 * gcov.c (add_line_counts): Assign BBs to lines just if the BB is marked by compiler as living on a line. diff --git a/gcc/gcov.c b/gcc/gcov.c index b25464e730e..924a5a38164 100644 --- a/gcc/gcov.c +++ b/gcc/gcov.c @@ -1946,6 +1946,13 @@ format_gcov (gcov_type top, gcov_type bottom, int dp) { static char buffer[20]; + /* Handle invalid values that would result in a misleading value. */ + if (bottom != 0 && top > bottom && dp >= 0) + { + sprintf (buffer, "NAN %%"); + return buffer; + } + if (dp >= 0) { float ratio = bottom ? (float)top / bottom : 0; -- 2.11.4.GIT