gimplify: prevent some C++ temporary elision
commitd3e5465757c599ea64f611290b7793d3141a6b7c
authorJason Merrill <jason@redhat.com>
Wed, 5 Oct 2022 15:50:59 +0000 (5 11:50 -0400)
committerJason Merrill <jason@redhat.com>
Fri, 7 Oct 2022 13:22:32 +0000 (7 09:22 -0400)
tree42223c603e13701c6d5569b2960677af795ca609
parent89228e3985c5cdf6be58a3b5b1afcad91e9e3422
gimplify: prevent some C++ temporary elision

In this testcase, we were optimizing away the temporary for f(), but
C++17 and above are clear that there is a temporary, and because its
destructor has visible side-effects we can't optimize it away under the
as-if rule.  So disable this optimization for TREE_ADDRESSABLE type.

I moved the declaration of volatile_p after the call to
gimple_fold_indirect_ref_rhs to minimize indentation changes; I don't see
any way the value of that flag could be affected by the call.

gcc/ChangeLog:

* gimplify.cc (gimplify_modify_expr_rhs): Don't optimize
x = *(A*)&<expr> to x = <expr> for a TREE_ADDRESSABLE type.

gcc/testsuite/ChangeLog:

* g++.dg/init/elide9.C: New test.
gcc/gimplify.cc
gcc/testsuite/g++.dg/init/elide9.C [new file with mode: 0644]