c++: Fix ICE when writing nontrivial variable initializers
commita71c3977d24722ac8ee28d8844c4f96a151f75ab
authorNathaniel Shead <nathanieloshead@gmail.com>
Tue, 2 Jan 2024 22:28:43 +0000 (3 09:28 +1100)
committerNathaniel Shead <nathanieloshead@gmail.com>
Sun, 7 Jan 2024 10:07:29 +0000 (7 21:07 +1100)
tree4f1372e33971edda54b2581d05e963b9a4918c84
parent63b531e6f8783e8624502d890dc422379de47a9a
c++: Fix ICE when writing nontrivial variable initializers

The attached testcase Patrick found in PR c++/112899 ICEs because it is
attempting to write a variable initializer that is no longer in the
static_aggregates map.

The issue is that, for non-header modules, the loop in
c_parse_final_cleanups prunes the static_aggregates list, which means
that by the time we get to emitting module information those
initialisers have been lost.

However, we don't actually need to write non-trivial initialisers for
non-header modules, because they've already been emitted as part of the
module TU itself.  Instead let's just only write the initializers from
header modules (which skipped writing them in c_parse_final_cleanups).

gcc/cp/ChangeLog:

* module.cc (trees_out::write_var_def): Only write initializers
in header modules.

gcc/testsuite/ChangeLog:

* g++.dg/modules/init-5_a.C: New test.
* g++.dg/modules/init-5_b.C: New test.

Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>
gcc/cp/module.cc
gcc/testsuite/g++.dg/modules/init-5_a.C [new file with mode: 0644]
gcc/testsuite/g++.dg/modules/init-5_b.C [new file with mode: 0644]