[PATCH] Fix tree-opt/110252: wrong code due to phiopt using flow sensitive info durin...
commit8c79b49cd4fa742f7be739dd21fd2aa040cc1ba3
authorAndrew Pinski <apinski@marvell.com>
Fri, 14 Jul 2023 22:55:34 +0000 (14 15:55 -0700)
committerAndrew Pinski <apinski@marvell.com>
Wed, 19 Jul 2023 16:18:50 +0000 (19 09:18 -0700)
tree2c2109e96426b9b9b7bffeca43a72f806ad22b68
parenta86d5eca6a11c25da4aff436f53589950641675f
[PATCH] Fix tree-opt/110252: wrong code due to phiopt using flow sensitive info during match

Match will query ranger via tree_nonzero_bits/get_nonzero_bits for 2 and 3rd
operand of the COND_EXPR and phiopt tries to do create the COND_EXPR even if we moving
one statement. That one statement could have some flow sensitive information on it
based on the condition that is for the COND_EXPR but that might create wrong code
if the statement was moved out.

This is similar to the previous version of the patch except now we use
flow_sensitive_info_storage instead of manually doing the save/restore
and also handle all defs on a gimple statement rather than just for lhs
of the gimple statement. Oh and a few more testcases were added that
was failing before.

OK? Bootsrapped and tested on x86_64-linux-gnu with no regressions.

PR tree-optimization/110252

gcc/ChangeLog:

* tree-ssa-phiopt.cc (class auto_flow_sensitive): New class.
(auto_flow_sensitive::auto_flow_sensitive): New constructor.
(auto_flow_sensitive::~auto_flow_sensitive): New deconstructor.
(match_simplify_replacement): Temporarily
remove the flow sensitive info on the two statements that might
be moved.

gcc/testsuite/ChangeLog:

* gcc.dg/tree-ssa/phi-opt-25b.c: Updated as
__builtin_parity loses the nonzerobits info.
* gcc.c-torture/execute/pr110252-1.c: New test.
* gcc.c-torture/execute/pr110252-2.c: New test.
* gcc.c-torture/execute/pr110252-3.c: New test.
* gcc.c-torture/execute/pr110252-4.c: New test.
gcc/testsuite/gcc.c-torture/execute/pr110252-1.c [new file with mode: 0644]
gcc/testsuite/gcc.c-torture/execute/pr110252-2.c [new file with mode: 0644]
gcc/testsuite/gcc.c-torture/execute/pr110252-3.c [new file with mode: 0644]
gcc/testsuite/gcc.c-torture/execute/pr110252-4.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/tree-ssa/phi-opt-25b.c
gcc/tree-ssa-phiopt.cc