| commit | 86a15b266a7284f3aa1b12494a475f31416b981d | |
| author | Marek Polacek <polacek@redhat.com> | |
| Wed, 13 Jul 2022 00:18:56 +0000 (12 20:18 -0400) | ||
| committer | Marek Polacek <polacek@redhat.com> | |
| Wed, 13 Jul 2022 18:22:09 +0000 (13 14:22 -0400) | ||
| tree | 8fabb6fd5fb4352fbbe2832d1bd3260f98848ec5 | treesnapshot (tar.gz zip) |
| parent | f70c18524221dcefa6cd26cee7b55503181bd912 | commitdiff |
libcpp: Avoid pessimizing std::move [PR106272]
std::move in a return statement can prevent the NRVO:
<https://developers.redhat.com/blog/2019/04/12/understanding-when-not-to-stdmove-in-c>
PR106272 reports that we have two such cases in class label_text's
member functions. We have -Wpessimizing-move that's supposed to detect
problematic std::move uses, but in this case it didn't trigger. I've filed
PR106276 to track that.
PR preprocessor/106272
libcpp/ChangeLog:
* include/line-map.h (class label_text): Don't std::move in a return
statement.
std::move in a return statement can prevent the NRVO:
<https://developers.redhat.com/blog/2019/04/12/understanding-when-not-to-stdmove-in-c>
PR106272 reports that we have two such cases in class label_text's
member functions. We have -Wpessimizing-move that's supposed to detect
problematic std::move uses, but in this case it didn't trigger. I've filed
PR106276 to track that.
PR preprocessor/106272
libcpp/ChangeLog:
* include/line-map.h (class label_text): Don't std::move in a return
statement.
| libcpp/include/line-map.h | diffblobblamehistory |