| commit | abb2b47c8adfca63ca81f46b038d1a57a8662998 | |
| author | Eric Blake <eblake@redhat.com> | |
| Tue, 13 Aug 2019 01:37:34 +0000 (12 20:37 -0500) | ||
| committer | Eric Blake <eblake@redhat.com> | |
| Tue, 13 Aug 2019 12:53:49 +0000 (13 07:53 -0500) | ||
| tree | 33e8400d8cc0fce76e89552c71b2176c38c62a3b | treesnapshot (tar.gz zip) |
| parent | 95a72f5d913a281f07c1fc83596338d53fd24877 | commitdiff |
plugins: Permit ENOTSUP as synonym for EOPNOTSUPP
POSIX allows but does not require ENOTSUP and EOPNOTSUPP to map to the
same errno value. This patch has no impact on Linux, but does affect
other systems: we want to be permissive in what we accept (either
spelling, since the two are commonly confused), while strict in what
we generate (we documented EOPNOTSUPP as the trigger to fall back to
.write, so stick to that internally where it makes sense). An
upcoming NBD protocol extension is proposing the exposure of an
NBD_ENOTSUP error, and so we'll need to make sure that both errno
values (when they are distinct) feed into that single wire value.
Signed-off-by: Eric Blake <eblake@redhat.com>
POSIX allows but does not require ENOTSUP and EOPNOTSUPP to map to the
same errno value. This patch has no impact on Linux, but does affect
other systems: we want to be permissive in what we accept (either
spelling, since the two are commonly confused), while strict in what
we generate (we documented EOPNOTSUPP as the trigger to fall back to
.write, so stick to that internally where it makes sense). An
upcoming NBD protocol extension is proposing the exposure of an
NBD_ENOTSUP error, and so we'll need to make sure that both errno
values (when they are distinct) feed into that single wire value.
Signed-off-by: Eric Blake <eblake@redhat.com>