From 3ca2b4f7cfd24a3d8d05db16baf90e6051960acc Mon Sep 17 00:00:00 2001 From: Pierre Wieser Date: Mon, 21 Feb 2011 19:44:50 +0100 Subject: [PATCH] NAIDuplicable: are_equal, is valid default to TRUE Rationale: if the implementation has not taken care of implementing the corresponding interfaces, then it is probably because this does not make sense in the given context. There is so no reason to suppose anything other here. --- ChangeLog | 3 +++ src/api/na-iduplicable.h | 3 +++ src/core/na-iduplicable.c | 4 ++-- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index c53370a8..7547c559 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2011-02-21 Pierre Wieser + * src/api/na-iduplicable.h: + * src/api/na-iduplicable.c (v_are_equal, v_is_valid): Default to TRUE. + * src/core/na-icontext.c (is_candidate_for_mimetypes): Fix check. * src/api/na-icontext.h: diff --git a/src/api/na-iduplicable.h b/src/api/na-iduplicable.h index 1204ae9d..fefed110 100644 --- a/src/api/na-iduplicable.h +++ b/src/api/na-iduplicable.h @@ -159,6 +159,9 @@ typedef struct { * care itself of calling each function in the class hierarchy, * from topmost base class to most-derived one. * + * When testing for the modification status of an object, @a stands for + * the original object, while @b stands for the duplicated one. + * * Returns: TRUE if @a and @b are identical, FALSE else. * * Since: 2.30 diff --git a/src/core/na-iduplicable.c b/src/core/na-iduplicable.c index 3e6bb395..ed79e408 100644 --- a/src/core/na-iduplicable.c +++ b/src/core/na-iduplicable.c @@ -553,7 +553,7 @@ v_are_equal( const NAIDuplicable *a, const NAIDuplicable *b ) return( NA_IDUPLICABLE_GET_INTERFACE( a )->are_equal( a, b )); } - return( FALSE ); + return( TRUE ); } static gboolean @@ -563,7 +563,7 @@ v_is_valid( const NAIDuplicable *object ) return( NA_IDUPLICABLE_GET_INTERFACE( object )->is_valid( object )); } - return( FALSE ); + return( TRUE ); } /** -- 2.11.4.GIT