| commit | 75ed112dbb95872dc623bf7190373e91d988a94b | |
| author | Jim Blandy <jimb@mozilla.org> | |
| Thu, 8 Oct 2009 17:29:03 +0000 (8 10:29 -0700) | ||
| committer | Jim Blandy <jimb@mozilla.org> | |
| Thu, 8 Oct 2009 17:29:03 +0000 (8 10:29 -0700) | ||
| tree | 8d5710edc64d8026dbd57ee1dacb7b3a9bb76db9 | treesnapshot (tar.gz zip) |
| parent | 1afc7a2e9d4cc73adb89887a2e3dca1c67163f8b | commitdiff |
Bug 515233: Widen JSTreeContext::flags to 32 bits. r=igor
All the bits in this uint16 field are currently in use. Adding bits
for projects like strict mode entails relocating existing flags, which
is additional work. Furthermore, it seems that this has already
inspired people to put flags in places they don't belong:
TSF_DESTRUCTURING is a JSTokenStream flag, but is only used by the
parser.
This patch widens the field to 32 bits, and adjusts JSFunctionBox and
a few other places to match.
We should really replace these all with bitfields.
All the bits in this uint16 field are currently in use. Adding bits
for projects like strict mode entails relocating existing flags, which
is additional work. Furthermore, it seems that this has already
inspired people to put flags in places they don't belong:
TSF_DESTRUCTURING is a JSTokenStream flag, but is only used by the
parser.
This patch widens the field to 32 bits, and adjusts JSFunctionBox and
a few other places to match.
We should really replace these all with bitfields.
| js/src/jsemit.cpp | diffblobblamehistory | |
| js/src/jsemit.h | diffblobblamehistory | |
| js/src/jsparse.cpp | diffblobblamehistory | |
| js/src/jsparse.h | diffblobblamehistory |