From bcf7c903aec4a27134690974c16724100633f625 Mon Sep 17 00:00:00 2001 From: SergioCrisostomo Date: Wed, 2 Jul 2014 23:18:08 +0200 Subject: [PATCH] Improvements after review sugestions --- Source/Element/Element.js | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/Source/Element/Element.js b/Source/Element/Element.js index 51b557ad..49517fa3 100644 --- a/Source/Element/Element.js +++ b/Source/Element/Element.js @@ -217,18 +217,20 @@ var escapeQuotes = function(html){ Document.implement({ newElement: function(tag, props){ - if (props && props.checked != null) props.defaultChecked = props.checked; - if (tag == 'input' && (props.type == 'checkbox' || props.type == 'radio') && !props.hasOwnProperty('value')) props.value = 'on'; - /**/// Fix for readonly name and type properties in IE < 8 - if (createElementAcceptsHTML && props){ - tag = '<' + tag; - if (props.name) tag += ' name="' + escapeQuotes(props.name) + '"'; - if (props.type) tag += ' type="' + escapeQuotes(props.type) + '"'; - tag += '>'; - delete props.name; - delete props.type; + if (props){ + if (props.checked != null) props.defaultChecked = props.checked; + if ((props.type == 'checkbox' || props.type == 'radio') && props.value == null) props.value = 'on'; + /**/// Fix for readonly name and type properties in IE < 8 + if (createElementAcceptsHTML){ + tag = '<' + tag; + if (props.name) tag += ' name="' + escapeQuotes(props.name) + '"'; + if (props.type) tag += ' type="' + escapeQuotes(props.type) + '"'; + tag += '>'; + delete props.name; + delete props.type; + } + /**/ } - /**/ return this.id(this.createElement(tag)).set(props); } -- 2.11.4.GIT