From b245e9e36e128309ec4b7f6ba8a7310f16e4be30 Mon Sep 17 00:00:00 2001
From: Jun Pataleta <jun@moodle.com>
Date: Mon, 18 Mar 2024 20:26:26 +0800
Subject: [PATCH] MDL-70829 tool_lp: Remove presentation role for decorative
 images

* Behat tests in report_competency added to test the user summary
display in the user competency summary modal.
---
 admin/tool/lp/templates/form-user-selector-suggestion.mustache | 2 +-
 admin/tool/lp/templates/user_summary.mustache                  | 2 +-
 report/competency/tests/behat/breakdown_by_activity.feature    | 7 +++++++
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/admin/tool/lp/templates/form-user-selector-suggestion.mustache b/admin/tool/lp/templates/form-user-selector-suggestion.mustache
index 61557f9ab1f..015cfda9487 100644
--- a/admin/tool/lp/templates/form-user-selector-suggestion.mustache
+++ b/admin/tool/lp/templates/form-user-selector-suggestion.mustache
@@ -49,7 +49,7 @@
     }
 }}
 <span>
-    <img height="12" src="{{profileimageurlsmall}}" alt="" role="presentation">
+    <img height="12" src="{{profileimageurlsmall}}" alt="">
     <span>{{fullname}}</span>
     {{#hasidentity}}
     <span><small>{{identity}}</small></span>
diff --git a/admin/tool/lp/templates/user_summary.mustache b/admin/tool/lp/templates/user_summary.mustache
index dbcf6397eb9..598f23f9530 100644
--- a/admin/tool/lp/templates/user_summary.mustache
+++ b/admin/tool/lp/templates/user_summary.mustache
@@ -50,7 +50,7 @@
 }}
 <span>
     <a href="{{profileurl}}" title="{{#str}}viewprofile{{/str}}">
-    <img height="18" src="{{profileimageurlsmall}}" alt="" role="presentation">
+    <img height="18" src="{{profileimageurlsmall}}" alt="">
     <span>{{fullname}}</span>
     {{#hasidentity}}
     <span><small>{{identity}}</small></span>
diff --git a/report/competency/tests/behat/breakdown_by_activity.feature b/report/competency/tests/behat/breakdown_by_activity.feature
index d61e0749bf6..0ea7be784e1 100644
--- a/report/competency/tests/behat/breakdown_by_activity.feature
+++ b/report/competency/tests/behat/breakdown_by_activity.feature
@@ -65,3 +65,10 @@ Feature: See the competencies for an activity
     And I click on "PageName1" "autocomplete_selection"
     And I should see "Test-Comp1"
     And I should see "Test-Comp2"
+
+  @accessibility
+  Scenario: Evaluate the accessibility of the user competency summary dialogue
+    Given I navigate to "Reports" in current page administration
+    When I click on "Competency breakdown" "link"
+    And I click on "Not rated" "link"
+    And the page should meet accessibility standards
-- 
2.11.4.GIT