From 6cb4f34ebd5fa75d86501f4088fd653d6555e027 Mon Sep 17 00:00:00 2001
From: "Eloy Lafuente (stronk7)" <stronk7@moodle.org>
Date: Tue, 5 Nov 2013 00:32:50 +0100
Subject: [PATCH] MDL-40267 forms: added some tests for the range rule

---
 lib/tests/formslib_test.php | 83 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 83 insertions(+)

diff --git a/lib/tests/formslib_test.php b/lib/tests/formslib_test.php
index 2a819aed644..c081b726d06 100644
--- a/lib/tests/formslib_test.php
+++ b/lib/tests/formslib_test.php
@@ -121,6 +121,89 @@ class formslib_testcase extends advanced_testcase {
         }
     }
 
+    public function test_range_rule() {
+        global $CFG;
+
+        require_once('HTML/QuickForm/Rule/Range.php'); // Requires this pear stuff.
+
+        $strictformsrequired = null;
+        if (isset($CFG->strictformsrequired)) {
+            $strictformsrequired = $CFG->strictformsrequired;
+        }
+
+        $rule = new HTML_QuickForm_Rule_Range();
+
+        // First run the tests with strictformsrequired off.
+        $CFG->strictformsrequired = false;
+        // Passes.
+        $rule->setName('minlength'); // Let's verify some min lengths.
+        $this->assertTrue($rule->validate('12', 2));
+        $this->assertTrue($rule->validate('123', 2));
+        $this->assertTrue($rule->validate('áé', 2));
+        $this->assertTrue($rule->validate('áéí', 2));
+        $rule->setName('maxlength'); // Let's verify some max lengths.
+        $this->assertTrue($rule->validate('1', 2));
+        $this->assertTrue($rule->validate('12', 2));
+        $this->assertTrue($rule->validate('á', 2));
+        $this->assertTrue($rule->validate('áé', 2));
+        $rule->setName('----'); // Let's verify some ranges.
+        $this->assertTrue($rule->validate('', array(0, 2)));
+        $this->assertTrue($rule->validate('1', array(0, 2)));
+        $this->assertTrue($rule->validate('12', array(0, 2)));
+        $this->assertTrue($rule->validate('á', array(0, 2)));
+        $this->assertTrue($rule->validate('áé', array(0, 2)));
+
+        // Fail.
+        $rule->setName('minlength'); // Let's verify some min lengths.
+        $this->assertFalse($rule->validate('', 2));
+        $this->assertFalse($rule->validate('1', 2));
+        $this->assertFalse($rule->validate('á', 2));
+        $rule->setName('maxlength'); // Let's verify some max lengths.
+        $this->assertFalse($rule->validate('123', 2));
+        $this->assertFalse($rule->validate('áéí', 2));
+        $rule->setName('----'); // Let's verify some ranges.
+        $this->assertFalse($rule->validate('', array(1, 2)));
+        $this->assertFalse($rule->validate('123', array(1, 2)));
+        $this->assertFalse($rule->validate('áéí', array(1, 2)));
+
+        // Now run the same tests with it on to make sure things work as expected.
+        $CFG->strictformsrequired = true;
+        // Passes.
+        $rule->setName('minlength'); // Let's verify some min lengths.
+        $this->assertTrue($rule->validate('12', 2));
+        $this->assertTrue($rule->validate('123', 2));
+        $this->assertTrue($rule->validate('áé', 2));
+        $this->assertTrue($rule->validate('áéí', 2));
+        $rule->setName('maxlength'); // Let's verify some min lengths.
+        $this->assertTrue($rule->validate('1', 2));
+        $this->assertTrue($rule->validate('12', 2));
+        $this->assertTrue($rule->validate('á', 2));
+        $this->assertTrue($rule->validate('áé', 2));
+        $rule->setName('----'); // Let's verify some ranges.
+        $this->assertTrue($rule->validate('', array(0, 2)));
+        $this->assertTrue($rule->validate('1', array(0, 2)));
+        $this->assertTrue($rule->validate('12', array(0, 2)));
+        $this->assertTrue($rule->validate('á', array(0, 2)));
+        $this->assertTrue($rule->validate('áé', array(0, 2)));
+
+        // Fail.
+        $rule->setName('minlength'); // Let's verify some min lengths.
+        $this->assertFalse($rule->validate('', 2));
+        $this->assertFalse($rule->validate('1', 2));
+        $this->assertFalse($rule->validate('á', 2));
+        $rule->setName('maxlength'); // Let's verify some min lengths.
+        $this->assertFalse($rule->validate('123', 2));
+        $this->assertFalse($rule->validate('áéí', 2));
+        $rule->setName('----'); // Let's verify some ranges.
+        $this->assertFalse($rule->validate('', array(1, 2)));
+        $this->assertFalse($rule->validate('123', array(1, 2)));
+        $this->assertFalse($rule->validate('áéí', array(1, 2)));
+
+        if (isset($strictformsrequired)) {
+            $CFG->strictformsrequired = $strictformsrequired;
+        }
+    }
+
     public function test_generate_id_select() {
         $el = new MoodleQuickForm_select('choose_one', 'Choose one',
             array(1 => 'One', '2' => 'Two'));
-- 
2.11.4.GIT