From 68626c0c1f474209cfb596a87a484ce78b181d8b Mon Sep 17 00:00:00 2001 From: Brendan Heywood Date: Thu, 18 Aug 2022 13:55:46 +1000 Subject: [PATCH] MDL-73685 admin: Fix regression from MDL-69498 --- admin/roles/classes/admins_existing_selector.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/admin/roles/classes/admins_existing_selector.php b/admin/roles/classes/admins_existing_selector.php index 7c51db6efb9..722dc45bcca 100644 --- a/admin/roles/classes/admins_existing_selector.php +++ b/admin/roles/classes/admins_existing_selector.php @@ -91,8 +91,12 @@ class core_role_admins_existing_selector extends user_selector_base { } else { $groupnameprefix = get_string('extusers', 'core_role'); foreach ($availableusers as $user) { - $domain = substr($user->email, strpos($user->email, '@')); - $groupname = "$groupnameprefix $domain"; + if (isset($user->email)) { + $domain = substr($user->email, strpos($user->email, '@')); + $groupname = "$groupnameprefix $domain"; + } else { + $groupname = $groupnameprefix; + } $result[$groupname][] = $user; } } -- 2.11.4.GIT