From 2ecbeeda93cd7adf93986bd32220cfb3a9e9c5e1 Mon Sep 17 00:00:00 2001
From: "Eloy Lafuente (stronk7)" <stronk7@moodle.org>
Date: Fri, 5 Oct 2012 13:10:36 +0200
Subject: [PATCH] Revert "MDL-34257 quiz 'secure' mode: PAGE initialisation
 order issues."

This reverts commit e65f54f289f8debb5e78d59cd20b949b239351fd.
---
 mod/quiz/attempt.php | 4 ++--
 mod/quiz/review.php  | 3 +--
 mod/quiz/summary.php | 4 ++--
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/mod/quiz/attempt.php b/mod/quiz/attempt.php
index d70cf780650..a8d7a8c070f 100644
--- a/mod/quiz/attempt.php
+++ b/mod/quiz/attempt.php
@@ -75,9 +75,8 @@ if ($attemptobj->is_finished()) {
 
 // Check the access rules.
 $accessmanager = $attemptobj->get_access_manager(time());
-$accessmanager->setup_attempt_page($PAGE);
-$output = $PAGE->get_renderer('mod_quiz');
 $messages = $accessmanager->prevent_access();
+$output = $PAGE->get_renderer('mod_quiz');
 if (!$attemptobj->is_preview_user() && $messages) {
     print_error('attempterror', 'quiz', $attemptobj->view_url(),
             $output->access_messages($messages));
@@ -111,6 +110,7 @@ $title = get_string('attempt', 'quiz', $attemptobj->get_attempt_number());
 $headtags = $attemptobj->get_html_head_contributions($page);
 $PAGE->set_title(format_string($attemptobj->get_quiz_name()));
 $PAGE->set_heading($attemptobj->get_course()->fullname);
+$accessmanager->setup_attempt_page($PAGE);
 
 if ($attemptobj->is_last_page($page)) {
     $nextpage = -1;
diff --git a/mod/quiz/review.php b/mod/quiz/review.php
index 1b6aba9a3f2..64bc0b2f3b4 100644
--- a/mod/quiz/review.php
+++ b/mod/quiz/review.php
@@ -53,8 +53,6 @@ $attemptobj->check_review_capability();
 
 // Create an object to manage all the other (non-roles) access rules.
 $accessmanager = $attemptobj->get_access_manager(time());
-$accessmanager->setup_attempt_page($PAGE);
-
 $options = $attemptobj->get_display_options(true);
 
 // Check permissions.
@@ -106,6 +104,7 @@ if ($attemptobj->is_preview_user() && $attemptobj->is_own_attempt()) {
 $headtags = $attemptobj->get_html_head_contributions($page, $showall);
 $PAGE->set_title(format_string($attemptobj->get_quiz_name()));
 $PAGE->set_heading($attemptobj->get_course()->fullname);
+$accessmanager->setup_attempt_page($PAGE);
 
 // Summary table start ============================================================================
 
diff --git a/mod/quiz/summary.php b/mod/quiz/summary.php
index 4c206d7f5ab..869b4b1d75e 100644
--- a/mod/quiz/summary.php
+++ b/mod/quiz/summary.php
@@ -57,9 +57,8 @@ if ($attemptobj->is_preview_user()) {
 
 // Check access.
 $accessmanager = $attemptobj->get_access_manager(time());
-$accessmanager->setup_attempt_page($PAGE);
-$output = $PAGE->get_renderer('mod_quiz');
 $messages = $accessmanager->prevent_access();
+$output = $PAGE->get_renderer('mod_quiz');
 if (!$attemptobj->is_preview_user() && $messages) {
     print_error('attempterror', 'quiz', $attemptobj->view_url(),
             $output->access_messages($messages));
@@ -87,6 +86,7 @@ $PAGE->blocks->add_fake_block($navbc, $firstregion);
 $PAGE->navbar->add(get_string('summaryofattempt', 'quiz'));
 $PAGE->set_title(format_string($attemptobj->get_quiz_name()));
 $PAGE->set_heading($attemptobj->get_course()->fullname);
+$accessmanager->setup_attempt_page($PAGE);
 
 // Display the page.
 
-- 
2.11.4.GIT