From 2c58871a7477a1604afa014c6add1d3bd201d8a7 Mon Sep 17 00:00:00 2001
From: Jun Pataleta <jun@moodle.com>
Date: Thu, 9 Jun 2022 23:49:51 +0800
Subject: [PATCH] MDL-74802 core: Remove tooltip on the notification close
 button

Reverting the addition of a Boostrap tooltip on the alert notification's
close button. It introduced a bug where the tooltip remains after
dismissing the notification alert. We can manually toggle the state of
the tooltip via JS, but I don't think it's worth the effort. The tooltip
is meant as an added bonus for sighted users to see what the close
button is about.
---
 lib/templates/notification_error.mustache   | 3 +--
 lib/templates/notification_info.mustache    | 3 +--
 lib/templates/notification_success.mustache | 3 +--
 lib/templates/notification_warning.mustache | 3 +--
 4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/lib/templates/notification_error.mustache b/lib/templates/notification_error.mustache
index 87990864088..52e81b38626 100644
--- a/lib/templates/notification_error.mustache
+++ b/lib/templates/notification_error.mustache
@@ -41,8 +41,7 @@
     }}>
     {{{ message }}}
     {{# closebutton }}{{!
-    }}<button type="button" class="close" data-dismiss="alert"{{!
-            }} title="{{#str}}dismissnotification, core{{/str}}" data-toggle="tooltip">
+    }}<button type="button" class="close" data-dismiss="alert">
         <span aria-hidden="true">&times;</span>
         <span class="sr-only">{{#str}}dismissnotification, core{{/str}}</span>
     </button>{{!
diff --git a/lib/templates/notification_info.mustache b/lib/templates/notification_info.mustache
index 46efe5e55c2..a173a74d98c 100644
--- a/lib/templates/notification_info.mustache
+++ b/lib/templates/notification_info.mustache
@@ -41,8 +41,7 @@
     }}>
     {{{ message }}}
     {{# closebutton }}{{!
-    }}<button type="button" class="close" data-dismiss="alert"{{!
-            }} title="{{#str}}dismissnotification, core{{/str}}" data-toggle="tooltip">
+    }}<button type="button" class="close" data-dismiss="alert">
         <span aria-hidden="true">&times;</span>
         <span class="sr-only">{{#str}}dismissnotification, core{{/str}}</span>
     </button>{{!
diff --git a/lib/templates/notification_success.mustache b/lib/templates/notification_success.mustache
index a476779f768..7b2d1a0d56e 100644
--- a/lib/templates/notification_success.mustache
+++ b/lib/templates/notification_success.mustache
@@ -41,8 +41,7 @@
     }}>
     {{{ message }}}
     {{# closebutton }}{{!
-    }}<button type="button" class="close" data-dismiss="alert"{{!
-            }} title="{{#str}}dismissnotification, core{{/str}}" data-toggle="tooltip">
+    }}<button type="button" class="close" data-dismiss="alert">
         <span aria-hidden="true">&times;</span>
         <span class="sr-only">{{#str}}dismissnotification, core{{/str}}</span>
     </button>{{!
diff --git a/lib/templates/notification_warning.mustache b/lib/templates/notification_warning.mustache
index 66ce054a6ec..a02e3eb4665 100644
--- a/lib/templates/notification_warning.mustache
+++ b/lib/templates/notification_warning.mustache
@@ -41,8 +41,7 @@
     }}>
     {{{ message }}}
     {{# closebutton }}{{!
-    }}<button type="button" class="close" data-dismiss="alert"{{!
-            }} title="{{#str}}dismissnotification, core{{/str}}" data-toggle="tooltip">
+    }}<button type="button" class="close" data-dismiss="alert">
         <span aria-hidden="true">&times;</span>
         <span class="sr-only">{{#str}}dismissnotification, core{{/str}}</span>
     </button>{{!
-- 
2.11.4.GIT