From 029923aa9de1bd9f19d5c40b2b0648d614acabe8 Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Wed, 7 Mar 2012 10:58:56 +0100 Subject: [PATCH] MDL-31832 CLI upgrade will return 0 exit status if no upgrade is needed Discussed with David, both points were valid but finally we agreed about to consider the "no upgrade needed" exit a normal/succesful one, mainly because it keeps previous behavior the same (exit non-zero only for real errors). --- admin/cli/upgrade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/admin/cli/upgrade.php b/admin/cli/upgrade.php index 2b9fae766a2..72c20e01234 100644 --- a/admin/cli/upgrade.php +++ b/admin/cli/upgrade.php @@ -94,7 +94,7 @@ $oldversion = "$CFG->release ($CFG->version)"; $newversion = "$release ($version)"; if (!moodle_needs_upgrading()) { - cli_error(get_string('cliupgradenoneed', 'core_admin', $newversion), 63); + cli_error(get_string('cliupgradenoneed', 'core_admin', $newversion), 0); } // test environment first -- 2.11.4.GIT