MDL-60915 core_dml: fix miscellaneous incorrect recordset usage
commitf83d748f7767f1621ed2aebbffe366dacc6eaed5
authorsam marshall <s.marshall@open.ac.uk>
Wed, 11 Oct 2017 11:16:12 +0000 (11 12:16 +0100)
committerEloy Lafuente (stronk7) <stronk7@moodle.org>
Sun, 1 Jul 2018 22:46:26 +0000 (2 00:46 +0200)
treef6a4d3f54fc702557c2ceb64185fbad346f5353f
parent838f07703afc5cc04dbde10b3b6c40b39371ceab
MDL-60915 core_dml: fix miscellaneous incorrect recordset usage

The new recordset support for Postgres requires transactions and
will cause errors if recordsets are not closed correctly. This
commit fixes problems that were identified during unit tests, and
via some basic code analysis, across all core code. Most of these
are incorrect usage of recordset (forgetting to close them).
27 files changed:
admin/cli/fix_deleted_users.php
admin/tool/messageinbound/index.php
admin/tool/spamcleaner/index.php
analytics/classes/manager.php
backup/moodle2/restore_stepslib.php
cohort/lib.php
grade/grading/form/lib.php
grade/report/singleview/classes/local/screen/screen.php
group/lib.php
lib/blocklib.php
lib/classes/message/inbound/manager.php
lib/classes/plugininfo/portfolio.php
lib/db/upgrade.php
lib/filestorage/file_storage.php
lib/navigationlib.php
lib/tablelib.php
lib/testing/classes/util.php
message/tests/externallib_test.php
mod/feedback/classes/responses_table.php
mod/forum/tests/subscriptions_test.php
mod/glossary/lib.php
mod/glossary/print.php
mod/glossary/view.php
mod/quiz/tests/attempts_test.php
mod/wiki/locallib.php
question/classes/bank/view.php
report/security/locallib.php