| commit | e917a595b2b772580d6da79d93ddc6f10b0989ca | |
| author | Eloy Lafuente (stronk7) <stronk7@moodle.org> | |
| Wed, 27 May 2020 15:55:32 +0000 (27 17:55 +0200) | ||
| committer | Eloy Lafuente (stronk7) <stronk7@moodle.org> | |
| Wed, 27 May 2020 16:05:07 +0000 (27 18:05 +0200) | ||
| tree | 7480c49eb62a7fb0272e79c0e99b4d5003320981 | treesnapshot (tar.gz zip) |
| parent | e6d212fc07b5c41c5073c7723f6b1123a9dba355 | commitdiff |
MDL-68846 behat: Avoid asserting AM/PM strings. They are not cross-os
The exists/contains steps of behat are case-sensitive, in the other
side, depending of the OS and locales, time functions are not 100%
consistent. See https://bugs.php.net/bug.php?id=76378 for example.
So only solutions are:
1) Create a specific new step performing the checks case insensitively.
2) Avoid making AM / PM part of the checks.
Here we have opted by the 2nd approach, it's not critical part to check.
The exists/contains steps of behat are case-sensitive, in the other
side, depending of the OS and locales, time functions are not 100%
consistent. See https://bugs.php.net/bug.php?id=76378 for example.
So only solutions are:
1) Create a specific new step performing the checks case insensitively.
2) Avoid making AM / PM part of the checks.
Here we have opted by the 2nd approach, it's not critical part to check.
| mod/forum/report/summary/tests/behat/summary_data_post_dates.feature | diffblobblamehistory |