MDL-69099 tasks: Do not mark the non-enabled plugin's task as disabledcdcb53a114a59024aa6cd3de6fea3459494de857
| commit | cdcb53a114a59024aa6cd3de6fea3459494de857 | |
| author | David Mudrák <david@moodle.com> | |
| Fri, 19 Jun 2020 15:02:08 +0000 (19 17:02 +0200) | ||
| committer | Víctor Déniz Falcón <victor@moodle.com> | |
| Mon, 22 Jun 2020 16:23:10 +0000 (22 17:23 +0100) | ||
| tree | a7de0be3c550faf9034ec8e8e95746f081c7be24 | treesnapshot (tar.gz zip) |
| parent | 680502e4da10d2116cec6764cc2c95b2dea4c351 | commitdiff |
MDL-69099 tasks: Do not mark the non-enabled plugin's task as disabled
The `core\plugininfo\base::is_enabled()` uses three-state logic for its
return value. It can return null as a valid value as per its
documentation. We need to test for the explicit false value in this
case.
To make the attached Behat test able to identify the table, the caption
is added. It seems to be helpful for all users so I leave it displayed
without using the accesshide mechanism.
The `core\plugininfo\base::is_enabled()` uses three-state logic for its
return value. It can return null as a valid value as per its
documentation. We need to test for the explicit false value in this
case.
To make the attached Behat test able to identify the table, the caption
is added. It seems to be helpful for all users so I leave it displayed
without using the accesshide mechanism.
| admin/tool/task/renderer.php | diffblobblamehistory | |
| admin/tool/task/tests/behat/manage_tasks.feature | diffblobblamehistory |