| commit | bd166e618fde47f34a28bb1c1319ea9f0d48893e | |
| author | Alex Leontiev <alozz1991@gmail.com> | |
| Sat, 20 Apr 2013 07:32:27 +0000 (20 15:32 +0800) | ||
| committer | Dan Poltawski <dan@moodle.com> | |
| Mon, 22 Apr 2013 13:13:53 +0000 (22 14:13 +0100) | ||
| tree | a79d8328d8aec3b6e1c6e0af71b92f0f3f057911 | treesnapshot (tar.gz zip) |
| parent | a7458060636b4908ba60c5428a4fb2f1ba790d5f | commitdiff |
MDL-37514 module.js: fix .js for auto quiz submission in preview mode
The issue: when we attempt the quiz as teacher/admin and timer is up,
quiz is not submitted, even though "Open attempts are submitted
automatically" is set. I've changed the javascript for a timer,
responsible for submission, removing the special behaviour in case of
preview mode. Note, that when the admin/teacher is taking a quiz, the
"preview" mode is automatically switched on.
It is a bit strange, since in the javascript there was clearly no
expressed intention to really submit quiz in preview, even when timer
hits. It does not really seem like a accidental bug, rather it looks
like some misunderstanding. Worse still, it may happen that I did not
understand the intentions of previous editor and ruined some
functionality. Because of this, and the fact that this is my first bug,
I would like to ask about the peer review! Please, see my comments in
bug discussion for the testing steps.
Conflicts:
mod/quiz/module.js
The issue: when we attempt the quiz as teacher/admin and timer is up,
quiz is not submitted, even though "Open attempts are submitted
automatically" is set. I've changed the javascript for a timer,
responsible for submission, removing the special behaviour in case of
preview mode. Note, that when the admin/teacher is taking a quiz, the
"preview" mode is automatically switched on.
It is a bit strange, since in the javascript there was clearly no
expressed intention to really submit quiz in preview, even when timer
hits. It does not really seem like a accidental bug, rather it looks
like some misunderstanding. Worse still, it may happen that I did not
understand the intentions of previous editor and ruined some
functionality. Because of this, and the fact that this is my first bug,
I would like to ask about the peer review! Please, see my comments in
bug discussion for the testing steps.
Conflicts:
mod/quiz/module.js
| mod/quiz/module.js | diffblobblamehistory |