| commit | a0e38e4371a1926b30cb995149136bc832362068 | |
| author | Eloy Lafuente (stronk7) <stronk7@moodle.org> | |
| Wed, 27 May 2020 15:55:32 +0000 (27 17:55 +0200) | ||
| committer | Eloy Lafuente (stronk7) <stronk7@moodle.org> | |
| Wed, 27 May 2020 15:55:32 +0000 (27 17:55 +0200) | ||
| tree | b9795e03da6bf45a46a3091b4f3ec02bca6c4647 | treesnapshot (tar.gz zip) |
| parent | 68fd8d8bdfffc23b252c17f017e7cb573fdb3019 | commitdiff |
MDL-68846 behat: Avoid asserting AM/PM strings. They are not cross-os
The exists/contains steps of behat are case-sensitive, in the other
side, depending of the OS and locales, time functions are not 100%
consistent. See https://bugs.php.net/bug.php?id=76378 for example.
So only solutions are:
1) Create a specific new step performing the checks case insensitively.
2) Avoid making AM / PM part of the checks.
Here we have opted by the 2nd approach, it's not critical part to check.
The exists/contains steps of behat are case-sensitive, in the other
side, depending of the OS and locales, time functions are not 100%
consistent. See https://bugs.php.net/bug.php?id=76378 for example.
So only solutions are:
1) Create a specific new step performing the checks case insensitively.
2) Avoid making AM / PM part of the checks.
Here we have opted by the 2nd approach, it's not critical part to check.
| mod/forum/report/summary/tests/behat/course_summary.feature | diffblobblamehistory | |
| mod/forum/report/summary/tests/behat/summary_data_post_dates.feature | diffblobblamehistory |