| commit | 2724eb6041f1d48e720d31684074586b15188ab6 | |
| author | sam marshall <s.marshall@open.ac.uk> | |
| Wed, 3 May 2023 09:47:01 +0000 (3 10:47 +0100) | ||
| committer | sam marshall <s.marshall@open.ac.uk> | |
| Mon, 22 May 2023 09:44:15 +0000 (22 10:44 +0100) | ||
| tree | 9370b606a8780076ed74850dc398b83a3c52732d | treesnapshot (tar.gz zip) |
| parent | 4781b41631664d3c5e7e94cfcc279b2af81e4dd1 | commitdiff |
MDL-78092 Cache: Modinfo locking with Redis store does not work
The feature added in 4.1 to lock the modinfo cache does not work when
using Redis, because:
* The API to acquire a cache lock is confusing, and the code did not
check that it successfully acquired a lock before going on to build
the cache anyway.
* Unlike the other types of cache lock, the Redis store did not retry
the lock for a timeout period before giving up and failing.
This change fixes both points.
The feature added in 4.1 to lock the modinfo cache does not work when
using Redis, because:
* The API to acquire a cache lock is confusing, and the code did not
check that it successfully acquired a lock before going on to build
the cache anyway.
* Unlike the other types of cache lock, the Redis store did not retry
the lock for a timeout period before giving up and failing.
This change fixes both points.
| cache/stores/redis/lib.php | diffblobblamehistory | |
| cache/stores/redis/tests/store_test.php | diffblobblamehistory | |
| lib/modinfolib.php | diffblobblamehistory |