| commit | 04e67878f907d22843c54f0bd17772915f0252eb | |
| author | Andrew Nicols <andrew@nicols.co.uk> | |
| Mon, 18 Nov 2019 00:27:13 +0000 (18 08:27 +0800) | ||
| committer | Andrew Nicols <andrew@nicols.co.uk> | |
| Mon, 18 Nov 2019 23:40:36 +0000 (19 07:40 +0800) | ||
| tree | 27698572b8440f74ba45620dd25a015e24c636e9 | treesnapshot (tar.gz zip) |
| parent | d547735f2f44285e6547b9b4c2111469838c4812 | commitdiff |
MDL-67285 core: YUI dialogues must use focuslock
YUI Dialogues were using an older method for locking focus to modals,
but this way conflicts with the way in which we lock focus for AMD
modules.
As a result, when an AMD dialogue launches a YUI dialogue the focus is
not correctly locked and it is not possible to focus on anything in the
YUI dialogue.
This includes a minor changes to the focuslock AMD module to ensure that
it is possible to loop the focus in both directions. Many of our older
YUI dialogues are themselves focusable. As a result we need to include
the lock region in the calculation when calculating the possible
descendants.
If we do not do so then the reverse looping does not work.
YUI Dialogues were using an older method for locking focus to modals,
but this way conflicts with the way in which we lock focus for AMD
modules.
As a result, when an AMD dialogue launches a YUI dialogue the focus is
not correctly locked and it is not possible to focus on anything in the
YUI dialogue.
This includes a minor changes to the focuslock AMD module to ensure that
it is possible to loop the focus in both directions. Many of our older
YUI dialogues are themselves focusable. As a result we need to include
the lock region in the calculation when calculating the possible
descendants.
If we do not do so then the reverse looping does not work.