| commit | f85a820677b35df1ed56e339f8a5386526561312 | |
| author | Jay Krell <jay.krell@cornell.edu> | |
| Tue, 4 Feb 2020 10:56:00 +0000 (4 02:56 -0800) | ||
| committer | GitHub <noreply@github.com> | |
| Tue, 4 Feb 2020 10:56:00 +0000 (4 05:56 -0500) | ||
| tree | c1a01b9f5537813e7ee79c63fdd7207cf3e6e8ca | treesnapshot (tar.gz zip) |
| parent | 1a81bef2bd6d469c33caabe2c30feec1d3f1c956 | commitdiff |
When the interpreter does recurse, use a different function (#18664)
[interp][wasm]Use per-call recursive functions in interpreter to aid debugging.
When the interpreter does recurse, use a different function
for each call site, so you can tell from a WebAssembly stack
which case it is. i.e. with function names but no line numbers.
With this, we can see that call_varargs contributes to the problem
here: https://github.com/mono/mono/issues/18646
Also, do not inline the interpreter, it probably/hopefully never was.
[interp][wasm]Use per-call recursive functions in interpreter to aid debugging.
When the interpreter does recurse, use a different function
for each call site, so you can tell from a WebAssembly stack
which case it is. i.e. with function names but no line numbers.
With this, we can see that call_varargs contributes to the problem
here: https://github.com/mono/mono/issues/18646
Also, do not inline the interpreter, it probably/hopefully never was.
| mono/mini/interp/interp.c | diffblobblamehistory |