| commit | f7f627b756801c0a05b90be8b73453c8f4f44451 | |
| author | Alexander Köplinger <alex.koeplinger@outlook.com> | |
| Sun, 29 Jun 2014 15:35:28 +0000 (29 17:35 +0200) | ||
| committer | Alexander Köplinger <alex.koeplinger@outlook.com> | |
| Mon, 30 Jun 2014 19:01:30 +0000 (30 21:01 +0200) | ||
| tree | a42bd3b5d26d4c5396c292e6e75cdc068d4eda70 | treesnapshot (tar.gz zip) |
| parent | d151adb4feba0d0a4d070bdca2df9d933532e6be | commitdiff |
[System.Web] Tests: Fix deadlock when ThreadAbortException is thrown
This reverts commit ed11296c511d670391374fbb68e2988a9c1e8789.
When a ThreadAbortException is thrown during request processing in AsyncRun () the _done.Set () call is not executed.
This then results in a deadlock because _done.WaitOne () doesn't get signaled and waits forever.
One solution would be enclosing the _done.Set () in a finally clause, but even then we'd need to relaunch the AsyncRun () loop to be in a usable state.
A simpler solution is to revert the commit that introduced the AsyncRun () in the first place, as it doesn't seem necessary now (the tests pass just fine without it).
The test that was disabled in 429cdf17cf3a4887d9882380beebbf0d119e65ab is reenabled too, as it wasn't the culprit of the problem.
This reverts commit ed11296c511d670391374fbb68e2988a9c1e8789.
When a ThreadAbortException is thrown during request processing in AsyncRun () the _done.Set () call is not executed.
This then results in a deadlock because _done.WaitOne () doesn't get signaled and waits forever.
One solution would be enclosing the _done.Set () in a finally clause, but even then we'd need to relaunch the AsyncRun () loop to be in a usable state.
A simpler solution is to revert the commit that introduced the AsyncRun () in the first place, as it doesn't seem necessary now (the tests pass just fine without it).
The test that was disabled in 429cdf17cf3a4887d9882380beebbf0d119e65ab is reenabled too, as it wasn't the culprit of the problem.
| mcs/class/System.Web/Test/System.Web.Compilation/AppResourcesCompilerTest.cs | diffblobblamehistory | |
| mcs/class/System.Web/Test/mainsoft/NunitWeb/NunitWeb/MyHost.cs | diffblobblamehistory |