Contribute to IDE0044 (make field readonly)
commite19d95b6dece4fbe4fb4aa37e99760858964e084
authorStephen Toub <stoub@microsoft.com>
Fri, 9 Aug 2019 15:32:32 +0000 (9 11:32 -0400)
committerMarek Safar <marek.safar@gmail.com>
Tue, 13 Aug 2019 19:35:04 +0000 (13 21:35 +0200)
tree5a6db673e7568ebecedd7fc205879c875523be2a
parent6c95cbadf94e5f557dc6df2dfbdc58fe15701d51
Contribute to IDE0044 (make field readonly)

I used the auto-fix and then undid changes in areas where the fields were potentially mutated in native, e.g. I undid many of the changes in reflection.  We can revisit those individually later.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
86 files changed:
netcore/System.Private.CoreLib/shared/Internal/Win32/RegistryKey.cs
netcore/System.Private.CoreLib/shared/System/AggregateException.cs
netcore/System.Private.CoreLib/shared/System/ArgumentException.cs
netcore/System.Private.CoreLib/shared/System/ArgumentOutOfRangeException.cs
netcore/System.Private.CoreLib/shared/System/Array.Enumerators.cs
netcore/System.Private.CoreLib/shared/System/AttributeUsageAttribute.cs
netcore/System.Private.CoreLib/shared/System/BadImageFormatException.cs
netcore/System.Private.CoreLib/shared/System/CLSCompliantAttribute.cs
netcore/System.Private.CoreLib/shared/System/Collections/ArrayList.cs
netcore/System.Private.CoreLib/shared/System/Collections/Comparer.cs
netcore/System.Private.CoreLib/shared/System/Collections/Generic/Dictionary.cs
netcore/System.Private.CoreLib/shared/System/Collections/Hashtable.cs
netcore/System.Private.CoreLib/shared/System/Collections/ListDictionaryInternal.cs
netcore/System.Private.CoreLib/shared/System/Collections/ObjectModel/Collection.cs
netcore/System.Private.CoreLib/shared/System/Collections/ObjectModel/ReadOnlyCollection.cs
netcore/System.Private.CoreLib/shared/System/CurrentSystemTimeZone.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Contracts/ContractFailedEventArgs.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Contracts/Contracts.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/StackFrame.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/ActivityTracker.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventDescriptor.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventSource.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/IncrementingPollingCounter.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/PollingCounter.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/StubEnvironment.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/EventPayload.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/SimpleTypeInfos.cs
netcore/System.Private.CoreLib/shared/System/Globalization/CultureNotFoundException.cs
netcore/System.Private.CoreLib/shared/System/Globalization/DateTimeFormatInfo.cs
netcore/System.Private.CoreLib/shared/System/Globalization/DateTimeParse.cs
netcore/System.Private.CoreLib/shared/System/Globalization/HebrewNumber.cs
netcore/System.Private.CoreLib/shared/System/Globalization/IdnMapping.cs
netcore/System.Private.CoreLib/shared/System/Globalization/SortVersion.cs
netcore/System.Private.CoreLib/shared/System/Globalization/TaiwanCalendar.cs
netcore/System.Private.CoreLib/shared/System/Globalization/TimeSpanParse.cs
netcore/System.Private.CoreLib/shared/System/IO/BinaryReader.cs
netcore/System.Private.CoreLib/shared/System/IO/BinaryWriter.cs
netcore/System.Private.CoreLib/shared/System/IO/MemoryStream.cs
netcore/System.Private.CoreLib/shared/System/IO/PinnedBufferMemoryStream.cs
netcore/System.Private.CoreLib/shared/System/IO/Stream.cs
netcore/System.Private.CoreLib/shared/System/IO/StreamReader.cs
netcore/System.Private.CoreLib/shared/System/IO/TextWriter.cs
netcore/System.Private.CoreLib/shared/System/IO/UnmanagedMemoryStreamWrapper.cs
netcore/System.Private.CoreLib/shared/System/Math.cs
netcore/System.Private.CoreLib/shared/System/MathF.cs
netcore/System.Private.CoreLib/shared/System/NotFiniteNumberException.cs
netcore/System.Private.CoreLib/shared/System/Number.NumberToFloatingPointBits.cs
netcore/System.Private.CoreLib/shared/System/ObjectDisposedException.cs
netcore/System.Private.CoreLib/shared/System/ObsoleteAttribute.cs
netcore/System.Private.CoreLib/shared/System/Random.cs
netcore/System.Private.CoreLib/shared/System/Reflection/AssemblyFlagsAttribute.cs
netcore/System.Private.CoreLib/shared/System/Resources/FileBasedResourceGroveler.cs
netcore/System.Private.CoreLib/shared/System/Resources/ManifestBasedResourceGroveler.cs
netcore/System.Private.CoreLib/shared/System/Resources/MissingSatelliteAssemblyException.cs
netcore/System.Private.CoreLib/shared/System/Resources/ResourceFallbackManager.cs
netcore/System.Private.CoreLib/shared/System/Resources/ResourceManager.cs
netcore/System.Private.CoreLib/shared/System/Resources/ResourceReader.cs
netcore/System.Private.CoreLib/shared/System/Runtime/CompilerServices/DateTimeConstantAttribute.cs
netcore/System.Private.CoreLib/shared/System/Runtime/CompilerServices/DecimalConstantAttribute.cs
netcore/System.Private.CoreLib/shared/System/Runtime/InteropServices/ArrayWithOffset.cs
netcore/System.Private.CoreLib/shared/System/Runtime/MemoryFailPoint.cs
netcore/System.Private.CoreLib/shared/System/Runtime/Remoting/ObjectHandle.cs
netcore/System.Private.CoreLib/shared/System/Runtime/Serialization/SerializationInfo.cs
netcore/System.Private.CoreLib/shared/System/Runtime/Versioning/TargetFrameworkAttribute.cs
netcore/System.Private.CoreLib/shared/System/StringComparer.cs
netcore/System.Private.CoreLib/shared/System/Text/DecoderBestFitFallback.cs
netcore/System.Private.CoreLib/shared/System/Text/DecoderExceptionFallback.cs
netcore/System.Private.CoreLib/shared/System/Text/DecoderNLS.cs
netcore/System.Private.CoreLib/shared/System/Text/DecoderReplacementFallback.cs
netcore/System.Private.CoreLib/shared/System/Text/EncoderBestFitFallback.cs
netcore/System.Private.CoreLib/shared/System/Text/EncoderExceptionFallback.cs
netcore/System.Private.CoreLib/shared/System/Text/EncoderNLS.cs
netcore/System.Private.CoreLib/shared/System/Text/EncoderReplacementFallback.cs
netcore/System.Private.CoreLib/shared/System/Text/Encoding.cs
netcore/System.Private.CoreLib/shared/System/Text/EncodingProvider.cs
netcore/System.Private.CoreLib/shared/System/Text/UTF7Encoding.cs
netcore/System.Private.CoreLib/shared/System/Threading/ReaderWriterLockSlim.cs
netcore/System.Private.CoreLib/shared/System/Threading/Tasks/Future.cs
netcore/System.Private.CoreLib/shared/System/Threading/Tasks/FutureFactory.cs
netcore/System.Private.CoreLib/shared/System/Threading/Tasks/Task.cs
netcore/System.Private.CoreLib/shared/System/Threading/Tasks/TaskScheduler.cs
netcore/System.Private.CoreLib/shared/System/Threading/ThreadLocal.cs
netcore/System.Private.CoreLib/shared/System/Threading/ThreadPool.cs
netcore/System.Private.CoreLib/shared/System/Threading/Timer.cs
netcore/System.Private.CoreLib/shared/System/TypeInitializationException.cs
netcore/System.Private.CoreLib/shared/System/UnhandledExceptionEventArgs.cs