| commit | cfbd2c797b1438a4f88310a5669c54760d570424 | |
| author | Marcos Henrich <marcos.henrich@xamarin.com> | |
| Thu, 29 Jan 2015 14:31:26 +0000 (29 14:31 +0000) | ||
| committer | Marcos Henrich <marcos.henrich@xamarin.com> | |
| Thu, 29 Jan 2015 15:27:57 +0000 (29 15:27 +0000) | ||
| tree | 17ed2dab067fc9ab87705454c76fe20a702a71b4 | treesnapshot (tar.gz zip) |
| parent | 4f2b974bfa83bc792a2943fffd944501b8d242bb | commitdiff |
[runtime] MonoIO methods using SafeHandle now prevent handle reuse.
This reverts partially commit 753229c72dd9f2b63beb097700e350164b887c2.
Marshallers are not called for ICalls parameters so the change of ICalls parameters to SafeHandle did not prevents handle reuse.
To prevent handle reuse ICalls are no longer called directly.
Instead we call a method that receives a SafeHandle and wraps the ICall call with safeHandle.DangerousAddRef and safeHandle.DangerousReleaseRef.
This guarantees that the safe handle reference countererence does not reach zero before or while the ICall, thus avoiding the handle beeing released and possibly reused.
This reverts partially commit 753229c72dd9f2b63beb097700e350164b887c2.
Marshallers are not called for ICalls parameters so the change of ICalls parameters to SafeHandle did not prevents handle reuse.
To prevent handle reuse ICalls are no longer called directly.
Instead we call a method that receives a SafeHandle and wraps the ICall call with safeHandle.DangerousAddRef and safeHandle.DangerousReleaseRef.
This guarantees that the safe handle reference countererence does not reach zero before or while the ICall, thus avoiding the handle beeing released and possibly reused.