More Corelib cleanup (dotnet/coreclr#26872)
commitc256e409c99ddb5b3618e99ba27af83ea38bfe90
authorStephen Toub <stoub@microsoft.com>
Wed, 25 Sep 2019 14:05:48 +0000 (25 07:05 -0700)
committerMarek Safar <marek.safar@gmail.com>
Wed, 25 Sep 2019 18:13:47 +0000 (25 20:13 +0200)
treef511225ae5aba09c07a4101e099adb6380cfa437
parent39ff579432fc6261469f9f0ce6304ca29a5ef141
More Corelib cleanup (dotnet/coreclr#26872)

* Remove unnecessary asserts

* Make several classes static

* Use is instead of as+null check

* Use T? instead of Nullable<T>

* more static classes

* Mark locals as const

* Merge declaration and initialization of some variables

* Remove unnecessary casts

* Remove unnecessary "unsafe"s

* Simplify several lambda expressions

* Remove redundant parentheses

* Remove redundant '== true'

* Remove redundant empty lines

* Simplify boolean comparison with '== false'

* Replace if-statement with return statement

* Use while for infinite loop

* Add static to all partial static class declarations

* Use ++/-- operator instead of assignment

* Use string.IsNullOrEmpty

* Use coalesce expression

* Simplify lazy initialization

* Use coalese expression

* Join string expressions

* Use regular string literal instead of verbatim string literal

* Optimize StringBuilder.Append calls

* Remove redundant assignment

* Remove unnecessary unsafe context

* Merge processor directives

* Use String.Equals instead of String.Compare

* Use Debug.Fail instead of Debug.Assert(false

* Remove Attribute suffix

* Use predefined type

* Use compound assignment

* Use while statement to create an infinite loop

* Remove redundant base ctor call

* Avoid using catch (Exception)

* Remove empty regions

* Span comparison to null

* Avoid unnecessary boxing of value type

* Expression is always equal to 'true'

* Remove unused method

* update coalesce assignment

* fix unsafe

* fix redundant parens

* Fix whitespace errors introduced

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
203 files changed:
netcore/System.Private.CoreLib/shared/Interop/Unix/System.Native/Interop.GetCwd.cs
netcore/System.Private.CoreLib/shared/Interop/Unix/System.Native/Interop.ReadLink.cs
netcore/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.Globalization.cs
netcore/System.Private.CoreLib/shared/System/AccessViolationException.cs
netcore/System.Private.CoreLib/shared/System/AggregateException.cs
netcore/System.Private.CoreLib/shared/System/AppDomain.cs
netcore/System.Private.CoreLib/shared/System/Array.Enumerators.cs
netcore/System.Private.CoreLib/shared/System/Array.cs
netcore/System.Private.CoreLib/shared/System/ArraySegment.cs
netcore/System.Private.CoreLib/shared/System/Attribute.cs
netcore/System.Private.CoreLib/shared/System/BadImageFormatException.cs
netcore/System.Private.CoreLib/shared/System/BitConverter.cs
netcore/System.Private.CoreLib/shared/System/Boolean.cs
netcore/System.Private.CoreLib/shared/System/Buffer.cs
netcore/System.Private.CoreLib/shared/System/Buffers/MemoryHandle.cs
netcore/System.Private.CoreLib/shared/System/Buffers/MemoryManager.cs
netcore/System.Private.CoreLib/shared/System/Buffers/Text/FormattingHelpers.CountDigits.cs
netcore/System.Private.CoreLib/shared/System/Buffers/Text/Utf8Formatter/FormattingHelpers.cs
netcore/System.Private.CoreLib/shared/System/Buffers/Text/Utf8Formatter/Utf8Formatter.Date.O.cs
netcore/System.Private.CoreLib/shared/System/Buffers/Text/Utf8Formatter/Utf8Formatter.Decimal.cs
netcore/System.Private.CoreLib/shared/System/Buffers/Text/Utf8Parser/Utf8Parser.Number.cs
netcore/System.Private.CoreLib/shared/System/Buffers/Text/Utf8Parser/Utf8Parser.TimeSpan.cs
netcore/System.Private.CoreLib/shared/System/Buffers/Text/Utf8Parser/Utf8Parser.TimeSpanSplitter.cs
netcore/System.Private.CoreLib/shared/System/ByReference.cs
netcore/System.Private.CoreLib/shared/System/Char.cs
netcore/System.Private.CoreLib/shared/System/Collections/Generic/ArraySortHelper.cs
netcore/System.Private.CoreLib/shared/System/Collections/Generic/Dictionary.cs
netcore/System.Private.CoreLib/shared/System/Collections/Generic/List.cs
netcore/System.Private.CoreLib/shared/System/Collections/HashHelpers.cs
netcore/System.Private.CoreLib/shared/System/Collections/Hashtable.cs
netcore/System.Private.CoreLib/shared/System/Collections/ListDictionaryInternal.cs
netcore/System.Private.CoreLib/shared/System/Collections/ObjectModel/Collection.cs
netcore/System.Private.CoreLib/shared/System/Collections/ObjectModel/ReadOnlyCollection.cs
netcore/System.Private.CoreLib/shared/System/Convert.Base64.cs
netcore/System.Private.CoreLib/shared/System/Convert.cs
netcore/System.Private.CoreLib/shared/System/CurrentSystemTimeZone.cs
netcore/System.Private.CoreLib/shared/System/DateTime.cs
netcore/System.Private.CoreLib/shared/System/DateTimeOffset.cs
netcore/System.Private.CoreLib/shared/System/Decimal.DecCalc.cs
netcore/System.Private.CoreLib/shared/System/Decimal.cs
netcore/System.Private.CoreLib/shared/System/DefaultBinder.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Contracts/Contracts.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/StackFrame.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/StackTrace.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/ActivityTracker.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/CounterGroup.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventCounter.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventProvider.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventSource.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/IncrementingEventCounter.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/IncrementingPollingCounter.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/PollingCounter.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/DataCollector.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/FieldMetadata.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/Statics.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/TraceLoggingEventSource.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/TraceLogging/TraceLoggingEventTypes.cs
netcore/System.Private.CoreLib/shared/System/Double.cs
netcore/System.Private.CoreLib/shared/System/Environment.cs
netcore/System.Private.CoreLib/shared/System/Globalization/Calendar.cs
netcore/System.Private.CoreLib/shared/System/Globalization/CalendarData.Windows.cs
netcore/System.Private.CoreLib/shared/System/Globalization/CalendricalCalculationsHelper.cs
netcore/System.Private.CoreLib/shared/System/Globalization/CharUnicodeInfo.cs
netcore/System.Private.CoreLib/shared/System/Globalization/CharUnicodeInfoData.cs
netcore/System.Private.CoreLib/shared/System/Globalization/CompareInfo.Windows.cs
netcore/System.Private.CoreLib/shared/System/Globalization/CompareInfo.cs
netcore/System.Private.CoreLib/shared/System/Globalization/CultureData.Windows.cs
netcore/System.Private.CoreLib/shared/System/Globalization/CultureData.cs
netcore/System.Private.CoreLib/shared/System/Globalization/CultureInfo.cs
netcore/System.Private.CoreLib/shared/System/Globalization/CultureNotFoundException.cs
netcore/System.Private.CoreLib/shared/System/Globalization/DateTimeFormat.cs
netcore/System.Private.CoreLib/shared/System/Globalization/DateTimeFormatInfo.cs
netcore/System.Private.CoreLib/shared/System/Globalization/DateTimeFormatInfoScanner.cs
netcore/System.Private.CoreLib/shared/System/Globalization/DateTimeParse.cs
netcore/System.Private.CoreLib/shared/System/Globalization/EastAsianLunisolarCalendar.cs
netcore/System.Private.CoreLib/shared/System/Globalization/GregorianCalendar.cs
netcore/System.Private.CoreLib/shared/System/Globalization/GregorianCalendarHelper.cs
netcore/System.Private.CoreLib/shared/System/Globalization/HebrewCalendar.cs
netcore/System.Private.CoreLib/shared/System/Globalization/HebrewNumber.cs
netcore/System.Private.CoreLib/shared/System/Globalization/HijriCalendar.Win32.cs
netcore/System.Private.CoreLib/shared/System/Globalization/HijriCalendar.cs
netcore/System.Private.CoreLib/shared/System/Globalization/IdnMapping.cs
netcore/System.Private.CoreLib/shared/System/Globalization/InternalGlobalizationHelper.cs
netcore/System.Private.CoreLib/shared/System/Globalization/JulianCalendar.cs
netcore/System.Private.CoreLib/shared/System/Globalization/NumberFormatInfo.cs
netcore/System.Private.CoreLib/shared/System/Globalization/StringInfo.cs
netcore/System.Private.CoreLib/shared/System/Globalization/TextInfo.cs
netcore/System.Private.CoreLib/shared/System/Globalization/TimeSpanFormat.cs
netcore/System.Private.CoreLib/shared/System/IO/BinaryReader.cs
netcore/System.Private.CoreLib/shared/System/IO/FileLoadException.cs
netcore/System.Private.CoreLib/shared/System/IO/FileNotFoundException.cs
netcore/System.Private.CoreLib/shared/System/IO/FileStream.Windows.cs
netcore/System.Private.CoreLib/shared/System/IO/FileStream.cs
netcore/System.Private.CoreLib/shared/System/IO/FileStreamCompletionSource.Win32.cs
netcore/System.Private.CoreLib/shared/System/IO/MemoryStream.cs
netcore/System.Private.CoreLib/shared/System/IO/Path.Windows.cs
netcore/System.Private.CoreLib/shared/System/IO/Path.cs
netcore/System.Private.CoreLib/shared/System/IO/PathHelper.Windows.cs
netcore/System.Private.CoreLib/shared/System/IO/PathInternal.Windows.cs
netcore/System.Private.CoreLib/shared/System/IO/PathInternal.cs
netcore/System.Private.CoreLib/shared/System/IO/StreamReader.cs
netcore/System.Private.CoreLib/shared/System/IO/TextReader.cs
netcore/System.Private.CoreLib/shared/System/IO/TextWriter.cs
netcore/System.Private.CoreLib/shared/System/Index.cs
netcore/System.Private.CoreLib/shared/System/Int64.cs
netcore/System.Private.CoreLib/shared/System/IntPtr.cs
netcore/System.Private.CoreLib/shared/System/LocalAppContextSwitches.Common.cs
netcore/System.Private.CoreLib/shared/System/Marvin.OrdinalIgnoreCase.cs
netcore/System.Private.CoreLib/shared/System/Math.cs
netcore/System.Private.CoreLib/shared/System/MemoryExtensions.Fast.cs
netcore/System.Private.CoreLib/shared/System/MemoryExtensions.Trim.cs
netcore/System.Private.CoreLib/shared/System/NotFiniteNumberException.cs
netcore/System.Private.CoreLib/shared/System/Number.BigInteger.cs
netcore/System.Private.CoreLib/shared/System/Number.DiyFp.cs
netcore/System.Private.CoreLib/shared/System/Number.Dragon4.cs
netcore/System.Private.CoreLib/shared/System/Number.Formatting.cs
netcore/System.Private.CoreLib/shared/System/Number.Grisu3.cs
netcore/System.Private.CoreLib/shared/System/Number.NumberBuffer.cs
netcore/System.Private.CoreLib/shared/System/Number.NumberToFloatingPointBits.cs
netcore/System.Private.CoreLib/shared/System/Number.Parsing.cs
netcore/System.Private.CoreLib/shared/System/Numerics/ConstantHelper.cs
netcore/System.Private.CoreLib/shared/System/Numerics/ConstantHelper.tt
netcore/System.Private.CoreLib/shared/System/Numerics/Vector.cs
netcore/System.Private.CoreLib/shared/System/Numerics/Vector.tt
netcore/System.Private.CoreLib/shared/System/Numerics/Vector_Operations.cs
netcore/System.Private.CoreLib/shared/System/ParseNumbers.cs
netcore/System.Private.CoreLib/shared/System/PasteArguments.Windows.cs
netcore/System.Private.CoreLib/shared/System/Random.cs
netcore/System.Private.CoreLib/shared/System/Reflection/AssemblyName.cs
netcore/System.Private.CoreLib/shared/System/Reflection/CustomAttributeTypedArgument.cs
netcore/System.Private.CoreLib/shared/System/Resources/ManifestBasedResourceGroveler.cs
netcore/System.Private.CoreLib/shared/System/Resources/ResourceManager.Uap.cs
netcore/System.Private.CoreLib/shared/System/Resources/ResourceManager.cs
netcore/System.Private.CoreLib/shared/System/Runtime/CompilerServices/AsyncMethodBuilderCore.cs
netcore/System.Private.CoreLib/shared/System/Runtime/CompilerServices/AsyncTaskMethodBuilderT.cs
netcore/System.Private.CoreLib/shared/System/Runtime/CompilerServices/ConditionalWeakTable.cs
netcore/System.Private.CoreLib/shared/System/Runtime/CompilerServices/DecimalConstantAttribute.cs
netcore/System.Private.CoreLib/shared/System/Runtime/CompilerServices/TaskAwaiter.cs
netcore/System.Private.CoreLib/shared/System/Runtime/InteropServices/DefaultParameterValueAttribute.cs
netcore/System.Private.CoreLib/shared/System/Runtime/InteropServices/SEHException.cs
netcore/System.Private.CoreLib/shared/System/Runtime/InteropServices/SafeBuffer.cs
netcore/System.Private.CoreLib/shared/System/Runtime/Intrinsics/X86/Aes.cs
netcore/System.Private.CoreLib/shared/System/Runtime/Intrinsics/X86/Sse.cs
netcore/System.Private.CoreLib/shared/System/Runtime/Loader/AssemblyLoadContext.cs
netcore/System.Private.CoreLib/shared/System/Runtime/Loader/LibraryNameVariation.Windows.cs
netcore/System.Private.CoreLib/shared/System/Runtime/MemoryFailPoint.cs
netcore/System.Private.CoreLib/shared/System/Runtime/Serialization/SerializationInfoEnumerator.cs
netcore/System.Private.CoreLib/shared/System/Runtime/Versioning/TargetFrameworkAttribute.cs
netcore/System.Private.CoreLib/shared/System/RuntimeType.cs
netcore/System.Private.CoreLib/shared/System/Security/SecurityElement.cs
netcore/System.Private.CoreLib/shared/System/Single.cs
netcore/System.Private.CoreLib/shared/System/SpanHelpers.Byte.cs
netcore/System.Private.CoreLib/shared/System/SpanHelpers.Char.cs
netcore/System.Private.CoreLib/shared/System/SpanHelpers.T.cs
netcore/System.Private.CoreLib/shared/System/String.Comparison.cs
netcore/System.Private.CoreLib/shared/System/String.Searching.cs
netcore/System.Private.CoreLib/shared/System/String.cs
netcore/System.Private.CoreLib/shared/System/StringComparer.cs
netcore/System.Private.CoreLib/shared/System/Text/ASCIIUtility.cs
netcore/System.Private.CoreLib/shared/System/Text/Decoder.cs
netcore/System.Private.CoreLib/shared/System/Text/DecoderBestFitFallback.cs
netcore/System.Private.CoreLib/shared/System/Text/DecoderFallback.cs
netcore/System.Private.CoreLib/shared/System/Text/DecoderNLS.cs
netcore/System.Private.CoreLib/shared/System/Text/Encoder.cs
netcore/System.Private.CoreLib/shared/System/Text/EncoderBestFitFallback.cs
netcore/System.Private.CoreLib/shared/System/Text/EncoderNLS.cs
netcore/System.Private.CoreLib/shared/System/Text/Encoding.cs
netcore/System.Private.CoreLib/shared/System/Text/EncodingNLS.cs
netcore/System.Private.CoreLib/shared/System/Text/EncodingTable.cs
netcore/System.Private.CoreLib/shared/System/Text/Latin1Encoding.cs
netcore/System.Private.CoreLib/shared/System/Text/Rune.cs
netcore/System.Private.CoreLib/shared/System/Text/StringBuilder.cs
netcore/System.Private.CoreLib/shared/System/Text/UTF32Encoding.cs
netcore/System.Private.CoreLib/shared/System/Text/UTF7Encoding.cs
netcore/System.Private.CoreLib/shared/System/Text/Unicode/Utf8Utility.Helpers.cs
netcore/System.Private.CoreLib/shared/System/Text/Unicode/Utf8Utility.Transcoding.cs
netcore/System.Private.CoreLib/shared/System/Text/UnicodeEncoding.cs
netcore/System.Private.CoreLib/shared/System/Text/UnicodeUtility.cs
netcore/System.Private.CoreLib/shared/System/Threading/EventWaitHandle.Windows.cs
netcore/System.Private.CoreLib/shared/System/Threading/ManualResetEventSlim.cs
netcore/System.Private.CoreLib/shared/System/Threading/Semaphore.Windows.cs
netcore/System.Private.CoreLib/shared/System/Threading/SemaphoreSlim.cs
netcore/System.Private.CoreLib/shared/System/Threading/SpinLock.cs
netcore/System.Private.CoreLib/shared/System/Threading/Tasks/Future.cs
netcore/System.Private.CoreLib/shared/System/Threading/Tasks/FutureFactory.cs
netcore/System.Private.CoreLib/shared/System/Threading/Tasks/Task.cs
netcore/System.Private.CoreLib/shared/System/Threading/Tasks/TaskContinuation.cs
netcore/System.Private.CoreLib/shared/System/Threading/Tasks/TaskFactory.cs
netcore/System.Private.CoreLib/shared/System/Threading/Thread.cs
netcore/System.Private.CoreLib/shared/System/Threading/ThreadPool.cs
netcore/System.Private.CoreLib/shared/System/Threading/Timer.cs
netcore/System.Private.CoreLib/shared/System/Threading/WaitHandle.cs
netcore/System.Private.CoreLib/shared/System/TimeZone.cs
netcore/System.Private.CoreLib/shared/System/TimeZoneInfo.StringSerializer.cs
netcore/System.Private.CoreLib/shared/System/TimeZoneInfo.Unix.cs
netcore/System.Private.CoreLib/shared/System/TimeZoneInfo.cs
netcore/System.Private.CoreLib/shared/System/Tuple.cs
netcore/System.Private.CoreLib/shared/System/Type.Enum.cs
netcore/System.Private.CoreLib/shared/System/UInt16.cs
netcore/System.Private.CoreLib/shared/System/UInt32.cs
netcore/System.Private.CoreLib/shared/System/UIntPtr.cs
netcore/System.Private.CoreLib/shared/System/Version.cs
netcore/System.Private.CoreLib/shared/System/WeakReference.T.cs