| commit | 9b98db9ca949bbb706a3d647662985347816d9f7 | |
| author | Alexander Köplinger <alex.koeplinger@outlook.com> | |
| Mon, 23 Sep 2019 20:44:59 +0000 (23 22:44 +0200) | ||
| committer | GitHub <noreply@github.com> | |
| Mon, 23 Sep 2019 20:44:59 +0000 (23 22:44 +0200) | ||
| tree | e93a86ac8ffebc07db4c03ce4778265d5cccc130 | treesnapshot (tar.gz zip) |
| parent | bc43f32c9d7eb5db32f580da85d14a98518b1d8b | commitdiff |
Correctly check for HAVE_STAT_BIRTHTIME in configure.ac checks for System.Native (#16999)
The check was done incorrectly, the include files need to be separated by newlines otherwise we would get a false negative result.
config.log contained this:
```
conftest.c:279:23: warning: extra tokens at end of #include directive [-Wextra-tokens]
#include <sys/types.h>, #include <sys/stat.h>
^
//
```
This means that when doing File.GetCreationTime() we'd fall back to returning the last modified time.
It regressed when we switched to System.IO.File to the CoreFX implementation i.e. System.Native in https://github.com/mono/mono/commit/8f5cef936491e8b20888bbf18d426482c890637c.
Fixes https://github.com/mono/mono/issues/16974
The check was done incorrectly, the include files need to be separated by newlines otherwise we would get a false negative result.
config.log contained this:
```
conftest.c:279:23: warning: extra tokens at end of #include directive [-Wextra-tokens]
#include <sys/types.h>, #include <sys/stat.h>
^
//
```
This means that when doing File.GetCreationTime() we'd fall back to returning the last modified time.
It regressed when we switched to System.IO.File to the CoreFX implementation i.e. System.Native in https://github.com/mono/mono/commit/8f5cef936491e8b20888bbf18d426482c890637c.
Fixes https://github.com/mono/mono/issues/16974
| configure.ac | diffblobblamehistory |