| commit | 85296ef1be7bb34c1c92953ca66a026e5dcd0771 | |
| author | Ryan Lucia <rylucia@microsoft.com> | |
| Tue, 6 Aug 2019 10:16:15 +0000 (6 06:16 -0400) | ||
| committer | Alexander Köplinger <alex.koeplinger@outlook.com> | |
| Tue, 6 Aug 2019 10:16:15 +0000 (6 12:16 +0200) | ||
| tree | 01aba924c37ff79ff2f34f8d346f4e5392b2edeb | treesnapshot (tar.gz zip) |
| parent | 474092add6c0c9f41ff3724485d3d05be48b4c5f | commitdiff |
[netcore] Make the load hook ALC-aware (#16012)
The meat of this PR is what the title suggests, and with this commit all the basic ALC functionality should be working properly. Probably worth checking if this makes any new tests pass.
Additionally, this PR includes a second commit that switches over the search hook to use loaded_assemblies from the ALCs. This may break some existing tests due to remaining unimplemented ALC behavior, notably the native loading mechanism needed for Openssl in some of the cryptography tests. My inclination is to include the commit regardless and just disable the failing tests so that any future ALC work can watch for regressions in the loader, but I would appreciate input from steveisok on how important those tests are. I've not disabled anything yet in order to see exactly what new failures are introduced.
The meat of this PR is what the title suggests, and with this commit all the basic ALC functionality should be working properly. Probably worth checking if this makes any new tests pass.
Additionally, this PR includes a second commit that switches over the search hook to use loaded_assemblies from the ALCs. This may break some existing tests due to remaining unimplemented ALC behavior, notably the native loading mechanism needed for Openssl in some of the cryptography tests. My inclination is to include the commit regardless and just disable the failing tests so that any future ALC work can watch for regressions in the loader, but I would appreciate input from steveisok on how important those tests are. I've not disabled anything yet in order to see exactly what new failures are introduced.