| commit | 73128453daff8966f1c8eeacb734579971b02218 | |
| author | Thays Grazia <thaystg@gmail.com> | |
| Mon, 15 Jul 2019 14:58:04 +0000 (15 11:58 -0300) | ||
| committer | GitHub <noreply@github.com> | |
| Mon, 15 Jul 2019 14:58:04 +0000 (15 11:58 -0300) | ||
| tree | 7f1b7ad5e73916152ede7b473e3ffb2692bec46b | treesnapshot (tar.gz zip) |
| parent | d85fe2c391140064957a76e3404dc85c214c0ddf | commitdiff |
[debugger] Don't list finalizer gc thread if it's not executing managed code (#15618)
* The example that reproduces the bug does this:
var thread = vm.GetThreads()[0];
greetingValue = program.InvokeMethod(thread, greeting, new Value[0]) as StringMirror;
But sometimes the Thread[0] was the MainThread of the program and it works, and other times was the GC Finalizer, but when it tries to run something on GC Finalizer thread, the thread is not suspended and throws an exception.
In the fix I removed the Finalizer thread if it's not executing a managed code of the list that is returned when CMD_VM_ALL_THREADS is called.
Fix #13311
* The example that reproduces the bug does this:
var thread = vm.GetThreads()[0];
greetingValue = program.InvokeMethod(thread, greeting, new Value[0]) as StringMirror;
But sometimes the Thread[0] was the MainThread of the program and it works, and other times was the GC Finalizer, but when it tries to run something on GC Finalizer thread, the thread is not suspended and throws an exception.
In the fix I removed the Finalizer thread if it's not executing a managed code of the list that is returned when CMD_VM_ALL_THREADS is called.
Fix #13311
| mono/mini/debugger-agent.c | diffblobblamehistory |