Enable several StyleCopAnalyzers (dotnet/corefx#39921)
commit3385433b606d47cdb623b93a1672e18a7fda7410
authorStephen Toub <stoub@microsoft.com>
Wed, 31 Jul 2019 23:10:59 +0000 (31 19:10 -0400)
committerMarek Safar <marek.safar@gmail.com>
Sat, 3 Aug 2019 18:55:40 +0000 (3 20:55 +0200)
tree093a309f80d3d232525e8c5cc061636945c69909
parent3fde98da3e5c910ec9f72760f595a864636fd142
Enable several StyleCopAnalyzers (dotnet/corefx#39921)

* Fix ordering of keywords in member signatures

* Add StyeCop.Analyzers

Most rules are disabled.  Many of them we'll want to leave disabled, however there are a handful it'll be good to enable over time.

* Use built-in type alias

* Fix straggling stylecop warnings in all configurations

* Replace tabs with spaces

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
35 files changed:
netcore/System.Private.CoreLib/shared/Interop/Windows/Advapi32/Interop.EventSetInformation.cs
netcore/System.Private.CoreLib/shared/Interop/Windows/Advapi32/Interop.EventTraceGuidsEx.cs
netcore/System.Private.CoreLib/shared/Interop/Windows/Advapi32/Interop.EventWriteTransfer.cs
netcore/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.FileTimeToSystemTime.cs
netcore/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.GetProcessInformation.cs
netcore/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.GetSystemTime.cs
netcore/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.GetSystemTimeAsFileTime.cs
netcore/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.GetSystemTimePreciseAsFileTime.cs
netcore/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.SystemTimeToFileTime.cs
netcore/System.Private.CoreLib/shared/Interop/Windows/Kernel32/Interop.TzSpecificLocalTimeToSystemTime.cs
netcore/System.Private.CoreLib/shared/Interop/Windows/NtDll/Interop.NtQuerySystemInformation.cs
netcore/System.Private.CoreLib/shared/Interop/Windows/User32/Interop.LoadString.cs
netcore/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeLibraryHandle.cs
netcore/System.Private.CoreLib/shared/System/Buffers/ArrayPool.cs
netcore/System.Private.CoreLib/shared/System/Buffers/ArrayPoolEventSource.cs
netcore/System.Private.CoreLib/shared/System/Buffers/Text/Utf8Formatter/Utf8Formatter.Decimal.cs
netcore/System.Private.CoreLib/shared/System/Buffers/TlsOverPerCoreLockedStacksArrayPool.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventDescriptor.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventProvider.cs
netcore/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventSource.cs
netcore/System.Private.CoreLib/shared/System/Environment.Win32.cs
netcore/System.Private.CoreLib/shared/System/EnvironmentVariableTarget.cs
netcore/System.Private.CoreLib/shared/System/Globalization/CultureInfo.Windows.cs
netcore/System.Private.CoreLib/shared/System/IO/FileStream.Windows.cs
netcore/System.Private.CoreLib/shared/System/Lazy.cs
netcore/System.Private.CoreLib/shared/System/Reflection/Assembly.cs
netcore/System.Private.CoreLib/shared/System/Runtime/CompilerServices/AsyncMethodBuilder.cs
netcore/System.Private.CoreLib/shared/System/Runtime/CompilerServices/MethodImplAttribute.cs
netcore/System.Private.CoreLib/shared/System/Runtime/CompilerServices/UnsafeValueTypeAttribute.cs
netcore/System.Private.CoreLib/shared/System/Runtime/InteropServices/Marshal.cs
netcore/System.Private.CoreLib/shared/System/SpanHelpers.T.cs
netcore/System.Private.CoreLib/shared/System/Text/Unicode/Utf8Utility.cs
netcore/System.Private.CoreLib/shared/System/Threading/CancellationToken.cs
netcore/System.Private.CoreLib/shared/System/Threading/SemaphoreSlim.cs
netcore/System.Private.CoreLib/shared/System/Threading/Tasks/TaskContinuation.cs