[aot] Do not wrap tool_prefix path when calling strip (#16792)
commit131b3a9a92c43d673bbe46229668062a0d447a9f
authorRadek Doulik <radekdoulik@users.noreply.github.com>
Fri, 13 Sep 2019 13:05:27 +0000 (13 06:05 -0700)
committermonojenkins <jo.shields+jenkins@xamarin.com>
Fri, 13 Sep 2019 13:05:27 +0000 (13 09:05 -0400)
treeb0a1ce736a5019a8922e5e2b30e152e3f522ac26
parent10e72a7ab6237f74d0f4eabbdf6fecda66085e55
[aot] Do not wrap tool_prefix path when calling strip (#16792)

[aot] Do not put quotes around wrapped path

Should fix: https://github.com/xamarin/xamarin-android/issues/3619

As it results in double quoting, which vanishes the effect and breaks
AOT for XA on Windows.

The actual error:

    [aot-compiler stdout] Stripping the binary: ""C:\Program Files (x86)\Microsoft Visual Studio\2019\Stable\MSBuild\Xamarin\Android\ndk\arm-linux-androideabi-"strip" --strip-symbol=\$a --strip-symbol=\$d obj\Release\90\aot\armeabi-v7a\libaot-Xamarin.Android.Arch.Core.Common.dll.so.tmp
    [aot-compiler stderr] '""C:\Program' is not recognized as an internal or external command,
    [aot-compiler stderr] operable program or batch file.
    [aot-compiler stderr] AOT of image C:\Users\peter\source\repos\App9\App9\App9.Android\obj\Release\90\android\assets\Xamarin.Android.Support.CoordinaterLayout.dll failed.
mono/mini/aot-compiler.c