| commit | 0438680b67c83621f2025f51680b20f021d619f6 | |
| author | Atsushi Eno <atsushieno@veritas-vos-liberabit.com> | |
| Fri, 11 Jan 2013 11:43:53 +0000 (11 20:43 +0900) | ||
| committer | Atsushi Eno <atsushieno@veritas-vos-liberabit.com> | |
| Fri, 11 Jan 2013 11:43:53 +0000 (11 20:43 +0900) | ||
| tree | 419bbe052f4a5b82835249cb7679728e9632df83 | treesnapshot (tar.gz zip) |
| parent | b81dfbe1cf904cb56ec29eccd4a8fdebd6a05205 | commitdiff |
[msbuild] Fix import set to expected path when invalid imports are allowed.
It was failing to resolve <Import> to correct path because it allowed
invalid imports too early in Import.ForEachExtensionPathTillFound().
It is due to Project.AddSingleImport() that checks if invalid imports
can be ignored by load setting. But simply removing this check results
in regressions in nunit tests that fails to report required invalid imports.
This bug was one of the blockers to build fsharp-droid from xbuild:
https://github.com/fahadsuhaib/fsharp-droid
It was failing to resolve <Import> to correct path because it allowed
invalid imports too early in Import.ForEachExtensionPathTillFound().
It is due to Project.AddSingleImport() that checks if invalid imports
can be ignored by load setting. But simply removing this check results
in regressions in nunit tests that fails to report required invalid imports.
This bug was one of the blockers to build fsharp-droid from xbuild:
https://github.com/fahadsuhaib/fsharp-droid
| mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/Import.cs | diffblobblamehistory | |
| mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/Project.cs | diffblobblamehistory |