mediawiki.git
8 years agoUpdated version number to MediaWiki 1.23.0rc01.23.0rc0
mglaser [Thu, 24 Apr 2014 19:49:51 +0000 (24 21:49 +0200)]
Updated version number to MediaWiki 1.23.0rc0

This is the first release candidate of MediaWiki 1.23 branch

Change-Id: I4a723d3e454eda36e380da3c7aa9743a4ef88f21

8 years agoSECURITY: escape sortKey in pageInfo
csteipp [Sat, 29 Mar 2014 05:39:57 +0000 (28 22:39 -0700)]
SECURITY: escape sortKey in pageInfo

DEFAULTSORT isn't escaped before being added to the action=info table.

Bug: 63251
Change-Id: I087bfde8cbc69c3507f68ee3cb6e22aba0ffa7db

8 years agoResolve complex arguments to LESS helper functions
Erik Bernhardson [Wed, 23 Apr 2014 02:16:53 +0000 (22 19:16 -0700)]
Resolve complex arguments to LESS helper functions

The icons in Flow and the Compact Personal Bar beta feature are missing,
their generated background-image 7 is empty.

The lessphp implementation passes full data frames into the helper
functions.  Utilize the now-public compileValue method of less
to evaluate the data frame into a string.

Additionally adds a small abstraction to run pairs of less/css files
as unit tests by executing the less file and comparing it to the
equivalent css file.

Change-Id: I1704f84638d86a0e6e6b9c190972ab19180bd484
(cherry picked from commit efabc31da242c7596116e5851a5384737ce3113e)

8 years agoUpdate lessphp to 2cc77e3c7b
Erik Bernhardson [Wed, 23 Apr 2014 02:16:36 +0000 (22 19:16 -0700)]
Update lessphp to 2cc77e3c7b

Source:
* https://github.com/leafo/lessphp/compare/b7cd5c79e8...2cc77e3c7b
* https://github.com/leafo/lessphp/blob/2cc77e3c7b9e84cf30ca64fccf2a45a84fbcf0d3/lessc.inc.php

Updates:
84b1fda0d4 Set visibility of lessc::compileValue to 'public'

Change-Id: I499ddb01a662896fdcfe56d18021de5314e4d5d2
(cherry picked from commit 5ad0cd9b89431c43ba5133602b31ef62b726d012)

8 years agoMerge "Skip loading PHP shims for JSON i18n files" into REL1_23
jenkins-bot [Wed, 23 Apr 2014 08:25:36 +0000 (23 08:25 +0000)]
Merge "Skip loading PHP shims for JSON i18n files" into REL1_23

8 years agoMerge "Update documentation for $wgExtensionMessagesFiles" into REL1_23
jenkins-bot [Wed, 23 Apr 2014 08:25:34 +0000 (23 08:25 +0000)]
Merge "Update documentation for $wgExtensionMessagesFiles" into REL1_23

8 years agoMerge "JSON i18n shim: Only register LocalisationCacheRecache handler once" into...
jenkins-bot [Wed, 23 Apr 2014 08:23:36 +0000 (23 08:23 +0000)]
Merge "JSON i18n shim: Only register LocalisationCacheRecache handler once" into REL1_23

8 years agoUpdate documentation for $wgExtensionMessagesFiles
Kevin Israel [Thu, 17 Apr 2014 20:46:56 +0000 (17 16:46 -0400)]
Update documentation for $wgExtensionMessagesFiles

Follows-up e0043257c02e.

Change-Id: Id8212fca83fde09a89891ead1e0a107ff0d66398
(cherry picked from commit b67db3be8ef5cc9191c2dbdec8809af38596d06d)

8 years agoPostgreSQL: Allow rc_cur_time field to be null.
Jeff [Sun, 20 Apr 2014 22:09:34 +0000 (20 15:09 -0700)]
PostgreSQL: Allow rc_cur_time field to be null.

The column recentchanges.rc_cur_time is no longer populated by SQL,
so PostgreSQL must be changed to allow the NULL value for it.

In MySQL, the empty string is used as a surrogate for NULL, but that
is not allowed in PostgreSQL.

Bug: 61318
Change-Id: I6733ef11152d545382bec087d992515dcf9aec0b
(cherry picked from commit 8e4b41a50866e9503ed1498e6ac70b31c88d66ca)

8 years agoAPI: Don't rollback changes if the exception was a UsageException
Kunal Mehta [Tue, 22 Apr 2014 16:56:40 +0000 (22 09:56 -0700)]
API: Don't rollback changes if the exception was a UsageException

In I1b7396ceb, we were trying to log failures to Special:Log, but
since $this->dieUsage throws an exception, the log entry insertion
was being rolled back.

This is similar to I36cd645d which was for index.php calls.

Change-Id: I136ba66d2f939fcdd0c9326e04d686a30449bf4c
Follows-Up: I8f1da51187b281fe4afc0d5a0c49f5caf3612e92
(cherry picked from commit 487e9dc599298b57e5583f19945987ce0b0f287b)

8 years agoJSON i18n shim: Only register LocalisationCacheRecache handler once
Kevin Israel [Mon, 14 Apr 2014 11:24:32 +0000 (14 07:24 -0400)]
JSON i18n shim: Only register LocalisationCacheRecache handler once

Because LocalisationCache::recache() includes PHP shims each time it is
called (e.g. for a different language), in such cases as automated testing,
the shims could end up registering handlers many times instead of only
once, leading to a rather significant, progressively worse slowdown.

Checking whether the shim has already been loaded, and if so, not
registering the handler again, avoids this performance problem.

I also made the shim compatible with PHP 5.2 (minimum PHP version for
MW 1.17 - 1.19) by avoiding closures and __DIR__, and I added a
--shim-only option to generateJsonI18n.php to allow regenerating
existing shims.

Bug: 63928
Change-Id: I3bb39e7d2bb094873061b3b2adf7066bf26c1b71
(cherry picked from commit e0736bd1cdb3c2971baf344006f474580b8e326c)

8 years agogenerateJsonI18n.php: Use tabs for indentation
Kevin Israel [Mon, 21 Apr 2014 20:54:31 +0000 (21 16:54 -0400)]
generateJsonI18n.php: Use tabs for indentation

Bug: 63444
Change-Id: Iaaf6b1a08c316f29c18fd5c9494decee401a43f1
(cherry picked from commit cdf358807c8370648233c28d3e740a8c9aedb078)

8 years agoRevert "Removed useless JobQueue return values"
Reedy [Wed, 16 Apr 2014 17:41:30 +0000 (16 17:41 +0000)]
Revert "Removed useless JobQueue return values"

This reverts commit bc8c89d2df39d64f15770d29874904ebcff2f131.

Bug: 64007

Change-Id: I4b4dbe4637dc50cd4630ef19d54f01efba10e138
(cherry picked from commit c76d5a95c1dd1c3086461feae8bc1c0b688bde1e)

8 years agoSkip loading PHP shims for JSON i18n files
Kevin Israel [Mon, 14 Apr 2014 15:45:40 +0000 (14 11:45 -0400)]
Skip loading PHP shims for JSON i18n files

For now, non-message data (e.g. special page aliases, magic words) belong
in separate files having their own keys in $wgExtensionMessagesFiles. It
is unnecessary to read any PHP files listed under keys that exist in
$wgMessagesDirs; they are merely compatibility shims.

Bug: 63926
Change-Id: I92013d0a45e83ad0f5ac483a3db867806eb71f8a
(cherry picked from commit e0043257c02e866d176fc9cbb7721fa2defcf091)

8 years agoDeprecate ResourceLoaderGetStartupModules
Ori Livneh [Sun, 20 Apr 2014 21:01:21 +0000 (20 14:01 -0700)]
Deprecate ResourceLoaderGetStartupModules

In bug 63240, Roan calls it a 'misfeature', which I think is exactly right. It
has been used as a lazy workaround for having to think about load-order,
dependency management, and race conditions.

Bug: 63240
Change-Id: Ic48ad39c6d3d166d6bb8f60dfdd5f95aa7ed16a6
(cherry picked from commit e8b46e5e6660c9fbce01c982e98c7662b135a130)

8 years agomediawiki.mixins.less: Correctly embed images in .background-image-svg
Bartosz Dziewoński [Thu, 17 Apr 2014 20:09:28 +0000 (17 22:09 +0200)]
mediawiki.mixins.less: Correctly embed images in .background-image-svg

Using the /* @embed */ annotation twice for the same property
(background-image) confuses the LESS compiler, resulting in one of the
images not being embedded.

Let's use the embeddable() and embed() MediaWiki LESS functions,
like in the .background-image mixin.

And let's extend and clean up the documentation while we're here.

Bug: 61941
Change-Id: I39ea2004b9db34d096eed08b3ffdfcaf8d5fcd7d
(cherry picked from commit 127222af0b77650d752f5ba05165701fe7fd7895)

8 years agovector: Do styles the ResourceLoader way
Bartosz Dziewoński [Fri, 18 Apr 2014 14:15:01 +0000 (18 16:15 +0200)]
vector: Do styles the ResourceLoader way

It used to be done like this a few releases ago, but went
through some perturbation when the LESS rewrite happened
and afterwards during beta-testing the typography refresh.

The current way causes enough issues that I think the gain
from getting rid of it is worth losing some brevity.

Bug: 56592
Change-Id: Ibeff450fad789fbc67d95a1a9befd315f7405421
(cherry picked from commit e4f973bd4c6bb0b9c4d0d210fde18ec73c11aee4)

8 years agoPrevent GC during phpunit shutdown
csteipp [Wed, 2 Apr 2014 00:28:55 +0000 (1 17:28 -0700)]
Prevent GC during phpunit shutdown

To keep phpunit from segfaulting during shutdown, turn off GC for
php 5.3.

Bug: 62623
Change-Id: Ie59780e37cbea027cc204a43df406667c3f432ab
(cherry picked from commit 90b3d6285481e5fab8fdbc0ad3a0415f82555df3)

8 years agoMerge "Don't cache $wgResourceLoaderLESSVars in a static" into REL1_23
jenkins-bot [Sun, 20 Apr 2014 12:57:20 +0000 (20 12:57 +0000)]
Merge "Don't cache $wgResourceLoaderLESSVars in a static" into REL1_23

8 years agoDon't cache $wgResourceLoaderLESSVars in a static
Ori Livneh [Fri, 18 Apr 2014 19:11:42 +0000 (18 12:11 -0700)]
Don't cache $wgResourceLoaderLESSVars in a static

Caching the value of $wgResourceLoaderLESSVars in a static variable that is
enclosed in a closure makes it harder to reset global state for test runs, and
it does so in the name of a performance benefit that is miniscule.

Change-Id: I0958b03818f56ab73c8c9124daa9e54cc59f2428
(cherry picked from commit a2bf2346cdaa4b4dce7b005f20220c3ceb56f6bb)

8 years agojquery.suggestions: Handle CSS ellipsis when calculating suggestions' widths
Bartosz Dziewoński [Fri, 18 Apr 2014 20:07:32 +0000 (18 22:07 +0200)]
jquery.suggestions: Handle CSS ellipsis when calculating suggestions' widths

This is so nasty :(

Bug: 64093
Change-Id: Ia6b1376dddf69a0faa214d5c9a756bdcd9658367
(cherry picked from commit 271be3d09acfd3eb1cea3c0729b813c3d193c7df)

8 years agoWebInstallerOutput: Fix path to jquery.js
Bartosz Dziewoński [Fri, 18 Apr 2014 14:39:37 +0000 (18 16:39 +0200)]
WebInstallerOutput: Fix path to jquery.js

Follow-up to Id5ead145 and I335e4c08.

Bug: 64091
Change-Id: If40f479df7d68071d6ce5d2f3b8251e6bf3eb80e

8 years agoRemove font choices from REL1_23 branch while the implementation is unstable
Federico Leva [Thu, 17 Apr 2014 19:36:08 +0000 (17 21:36 +0200)]
Remove font choices from REL1_23 branch while the implementation is unstable

Especially as they are undocumented, against release policy (bug 63351).
Follows up to Ic5ba836364d04b2c3814777b69b5f47fce25292a etc.

Bug: 63942
Change-Id: I595feec9a525104e382f7730208b1cf32c496e8d

8 years agoFormatJson: Make it possible to change the indent string
Kevin Israel [Thu, 3 Apr 2014 01:51:09 +0000 (2 21:51 -0400)]
FormatJson: Make it possible to change the indent string

This is to allow consistency with MediaWiki PHP and JS files (e.g. when
generating JSON i18n files), not because tabs are "better" than spaces for
indenting code (both have advantages and disadvantages).

Because PHP's json_encode() function hardcodes the indent string, using tabs
has a performance cost (in post-processing the output) and is less suitable
for web output; thus the API and ResourceLoader debug mode will continue to
use four spaces. Adjusting the maintenance scripts and JSON files is left to
separate change sets.

Bug: 63444
Change-Id: Ic915c50b0acd2e236940b70d5dd48ea87954c9d5
(cherry picked from commit 1efdda25ee5cbaea2b7e2dd7afdbaf53063d4b68)

8 years agoAdd @since to Skin::getAllowedSkins
umherirrender [Tue, 15 Apr 2014 18:22:41 +0000 (15 20:22 +0200)]
Add @since to Skin::getAllowedSkins

Follow-Up: I0b0fdfb5615c22aa876882c3ca344ebb1f10c4bd
Change-Id: Ia14edc64c57bd8a9da0f2bda2d061d1a67aa0101

8 years agoResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery'
Ori Livneh [Sun, 9 Mar 2014 10:19:25 +0000 (9 03:19 -0700)]
ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery'

Make the function that wraps ResourceLoader modules bind the first and
second arguments it receives to '$' and 'jQuery'. This patch is a
follow-up to change I0c9edac35, which updated the invocation of
mw.loader#implement so that it passes jQuery as the first and second
argument.

Change-Id: I0f0c3a04c3b0e6a28115a10bf11a2a78aca66c21

8 years agoMerge "document.createElementNS is null or not an object in IE8" into REL1_23
jenkins-bot [Mon, 14 Apr 2014 18:15:41 +0000 (14 18:15 +0000)]
Merge "document.createElementNS is null or not an object in IE8" into REL1_23

8 years agodocument.createElementNS is null or not an object in IE8
umherirrender [Wed, 9 Apr 2014 19:25:00 +0000 (9 21:25 +0200)]
document.createElementNS is null or not an object in IE8

Having $wgDebugToolbar = true and visiting the wiki with IE8 will give
no debug toolbar, using ?debug=true gives a "document.createElementNS is
null or not an object" javascript fatal.

Throw a error. The function 'createSvgElement' will never be called,
because profiling gives a "An ES5 compatible javascript engine
is required for the profile visualization." in IE8.

Change-Id: I763dae7459cb88f892823b9458ed6dd1dbbf3e9d
(cherry picked from commit cd361413d80a6af61991da642ace1c12130d2c0f)

8 years ago.gitreview: Adjust default branch for REL1_23
Bartosz Dziewoński [Mon, 14 Apr 2014 18:01:46 +0000 (14 20:01 +0200)]
.gitreview: Adjust default branch for REL1_23

Change-Id: If52695d2415d03d45b492700aa1ddc074faf83bc

8 years agoFixed some @params documentation
umherirrender [Thu, 10 Apr 2014 18:50:10 +0000 (10 20:50 +0200)]
Fixed some @params documentation

Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.

Change-Id: I64e8cfe478cb0ba438f40b0631d6e9049cdab567

8 years agoMerge "Cache RecentChanges Atom feed in varnish for 15 seconds"
jenkins-bot [Mon, 14 Apr 2014 12:56:51 +0000 (14 12:56 +0000)]
Merge "Cache RecentChanges Atom feed in varnish for 15 seconds"

8 years agoCache RecentChanges Atom feed in varnish for 15 seconds
Brian Wolff [Sat, 29 Mar 2014 05:23:14 +0000 (29 02:23 -0300)]
Cache RecentChanges Atom feed in varnish for 15 seconds

Prior to fc20c30d209, the feed was cached for 10 seconds. That
change accidentally removed varnish caching. Re-add the caching,
and upping to 15 seconds for good measure (15 second delay on the RSS
feed shouldn't matter, people generally read those asynchronously
anyhow. I was thinking of maybe even uping to 30 seconds). Users
can still manually set an smaxage parameter via the url if they
don't like the default cache time.

This assumes nothing private (e.g. per user) is ever on the RSS
feed. Reading through the ChangesList code this appears to be
the case, as everyone is getting the feed from a shared
memcache entry.

Bug: 63249
Change-Id: I268d0a53067738ba96bee74c593358b0b28cc083

8 years agoFix CS double space in TitleValue return
addshore [Mon, 14 Apr 2014 12:43:46 +0000 (14 13:43 +0100)]
Fix CS double space in TitleValue return

Change-Id: Ib7eb2b070eea9f8b2df860b6d16f9c769be78cf7

8 years agoMerge "ChangesListSpecialPage: Implement two new hooks superseding 4 old ones"
jenkins-bot [Mon, 14 Apr 2014 03:13:53 +0000 (14 03:13 +0000)]
Merge "ChangesListSpecialPage: Implement two new hooks superseding 4 old ones"

8 years agoNormalise comments in Setup.php
Alexandre Emsenhuber [Sun, 13 Apr 2014 20:07:50 +0000 (13 22:07 +0200)]
Normalise comments in Setup.php

- Changed "#" to "//" for non-block comments
- Put the inline comment describing the file back
  in the file description

Change-Id: I0aec0f4c10def58b608a8f08455fccb2317e4538

8 years agoMerge "Add columns option to Special:PrefixIndex"
jenkins-bot [Sun, 13 Apr 2014 22:40:58 +0000 (13 22:40 +0000)]
Merge "Add columns option to Special:PrefixIndex"

8 years agoMerge "PrefixSearch: Remove unnecessary wfSuppressWarnings()"
jenkins-bot [Sun, 13 Apr 2014 22:32:04 +0000 (13 22:32 +0000)]
Merge "PrefixSearch: Remove unnecessary wfSuppressWarnings()"

8 years agoAdd columns option to Special:PrefixIndex
Daniel De Marco [Mon, 3 Feb 2014 20:00:53 +0000 (3 15:00 -0500)]
Add columns option to Special:PrefixIndex

Adds support for specifying the number of output columns to use in the
table generated by Special:PrefixIndex. Can be used as follows:

{{Special:PrefixIndex/{{FULLPAGENAME}}/|columns=2}}

Bug: 60759
Change-Id: Ic824351132ec8bf7c35116f6ab19f23386ead33e

8 years agoMerge "Made preloadFileStat/preloadCache actually work for FileBackendMultiWrite"
jenkins-bot [Sun, 13 Apr 2014 22:30:57 +0000 (13 22:30 +0000)]
Merge "Made preloadFileStat/preloadCache actually work for FileBackendMultiWrite"

8 years agoMerge "Wrap djvu large local copy downloads in pool counter"
jenkins-bot [Sun, 13 Apr 2014 22:30:40 +0000 (13 22:30 +0000)]
Merge "Wrap djvu large local copy downloads in pool counter"

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 13 Apr 2014 19:11:19 +0000 (13 19:11 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Id709503721345cc2a62a4283026303526dce52e9

8 years agoAdd 'messages used' comment
umherirrender [Sun, 13 Apr 2014 15:45:07 +0000 (13 17:45 +0200)]
Add 'messages used' comment

Change-Id: I69acea2a1f0a1ef6854d2ebddda446f86086633e

8 years agoFormat archive and filearchive revision delete log entries
umherirrender [Sat, 12 Apr 2014 22:08:58 +0000 (13 00:08 +0200)]
Format archive and filearchive revision delete log entries

DeleteLogFormatter only checks for revision and oldimage, but it is also
possible to delete archived revisions or archived files, so also check
for these types to have better formatted log entries.

Change-Id: I3f8eaa3956e2c7fc216fb4030fe4bab6cb8bbd60

8 years agoMerge "Fix deprecation notice for Skin::getUsableSkins to say 1.23"
jenkins-bot [Sun, 13 Apr 2014 14:06:43 +0000 (13 14:06 +0000)]
Merge "Fix deprecation notice for Skin::getUsableSkins to say 1.23"

8 years agoFix deprecation notice for Skin::getUsableSkins to say 1.23
Kunal Mehta [Sun, 13 Apr 2014 01:48:42 +0000 (12 18:48 -0700)]
Fix deprecation notice for Skin::getUsableSkins to say 1.23

Follows-up: I0b0fdfb5615c22aa876882c3ca344ebb1f10c4bd
Change-Id: Iafd03d562ec68edbef2479f8275f8f7a09fdbc7a

8 years agoMerge "mw.hook: Use hasOwnProperty"
jenkins-bot [Sun, 13 Apr 2014 09:08:26 +0000 (13 09:08 +0000)]
Merge "mw.hook: Use hasOwnProperty"

8 years agoMerge "Fixing bug #63738: Debug msg not showing correctly"
jenkins-bot [Sun, 13 Apr 2014 01:01:32 +0000 (13 01:01 +0000)]
Merge "Fixing bug #63738: Debug msg not showing correctly"

8 years agoMerge "Rename Skin::getUsableSkins() to Skin::getAllowedSkins()"
jenkins-bot [Sun, 13 Apr 2014 00:30:53 +0000 (13 00:30 +0000)]
Merge "Rename Skin::getUsableSkins() to Skin::getAllowedSkins()"

8 years agoMade preloadFileStat/preloadCache actually work for FileBackendMultiWrite
Aaron Schulz [Sat, 12 Apr 2014 22:42:34 +0000 (12 15:42 -0700)]
Made preloadFileStat/preloadCache actually work for FileBackendMultiWrite

* Previously the path substitution did not take place

Change-Id: I58ad3e2aa44a2b08f4c6bad1a783fb92ea79dbf4

8 years agoMerge "Display a warning when the user name looked up is not registered"
jenkins-bot [Sat, 12 Apr 2014 13:14:40 +0000 (12 13:14 +0000)]
Merge "Display a warning when the user name looked up is not registered"

8 years agoFixing bug #63738: Debug msg not showing correctly
Sergio Santoro [Sat, 12 Apr 2014 12:39:13 +0000 (12 14:39 +0200)]
Fixing bug #63738: Debug msg not showing correctly

Change-Id: I49d826f63810d99aefa5b842cd3d6b88989ef086

8 years agoDisplay a warning when the user name looked up is not registered
Aditya Sastry [Thu, 10 Apr 2014 21:24:35 +0000 (11 02:54 +0530)]
Display a warning when the user name looked up is not registered

Changed the SpecialContributions.php and added a warning message to tell the
user that the name he looked up isn't registered.

Bug: 60524
Change-Id: Ie07001e75a9732f727930f8f367bba8feb395b3e

8 years agoMerge "Make .mw-ui-button height the same for all buttons"
jenkins-bot [Sat, 12 Apr 2014 13:01:54 +0000 (12 13:01 +0000)]
Merge "Make .mw-ui-button height the same for all buttons"

8 years agodoc: Fix errored variadic symbol on mediawiki.action.edit addButtons
James D. Forrester [Fri, 11 Apr 2014 22:55:04 +0000 (11 15:55 -0700)]
doc: Fix errored variadic symbol on mediawiki.action.edit addButtons

Change-Id: I03734a117eaad7a0a7ab5860885d3bbfb950821d

8 years agoSupport JSDuck v5.x
James D. Forrester [Fri, 11 Apr 2014 22:41:50 +0000 (11 15:41 -0700)]
Support JSDuck v5.x

Add support to JSDuck v5.x with a new "CustomTags.rb" following the new
format (and with a new name for one of the existing flags). Also works
for JSDuck v4.x as before. The call in maintenance/mwjsduck-gen is now
sync'ed with the call made by Jenkins in the CI environment.

Change-Id: Ie6649a3e39457bde7a0d8bd00da8ea53e76e3085

8 years agoMerge "Update QUnit from v1.11.0 to v1.14.0"
jenkins-bot [Sat, 12 Apr 2014 00:03:47 +0000 (12 00:03 +0000)]
Merge "Update QUnit from v1.11.0 to v1.14.0"

8 years agoMerge "Update OOjs UI to v0.1.0-pre (eca1fc20e7)"
jenkins-bot [Sat, 12 Apr 2014 00:03:45 +0000 (12 00:03 +0000)]
Merge "Update OOjs UI to v0.1.0-pre (eca1fc20e7)"

8 years agoMerge "Fix KSS mediawiki.ui style guide (docs)"
jenkins-bot [Sat, 12 Apr 2014 00:01:03 +0000 (12 00:01 +0000)]
Merge "Fix KSS mediawiki.ui style guide (docs)"

8 years agoMerge "Make DjVu metadata be stored as serialized PHP array."
jenkins-bot [Sat, 12 Apr 2014 00:00:45 +0000 (12 00:00 +0000)]
Merge "Make DjVu metadata be stored as serialized PHP array."

8 years agoUpdate OOjs UI to v0.1.0-pre (eca1fc20e7)
Roan Kattouw [Fri, 11 Apr 2014 23:48:01 +0000 (11 16:48 -0700)]
Update OOjs UI to v0.1.0-pre (eca1fc20e7)

New changes:
729c7bb Removing zh-(cn|hk|tw) i18n files, per TWN policy change
d8cdf4d ButtonedElement: Use tabIndex property and "tabindex" attribute
004e9fe doc: Clean up (remove redundant @method and minor fixes)
f7c3dfb Fix styling of list tool group label when disabled
851fc18 Make OO.ui.Element.onDOMEvent/offDOMEvent static
d7cbc78 Prevent iframe windows from wiping parent document selection
eca1fc2 Fix jsduck errors

Change-Id: Id192cceab0c78ea63f2f6ae232760da8951bafae

8 years agoUpdate QUnit from v1.11.0 to v1.14.0
Timo Tijhof [Fri, 11 Apr 2014 23:15:20 +0000 (11 16:15 -0700)]
Update QUnit from v1.11.0 to v1.14.0

Code:
 http://code.jquery.com/qunit/qunit-1.14.0.js
 http://code.jquery.com/qunit/qunit-1.14.0.css

Release notes:
 https://github.com/jquery/qunit/blob/v1.14.0/History.md

Notable changes for us:
* v1.12.0:
  - Use a local setTimeout reference.
* v1.13.0:
  - assert: Remove Assert.raises (deprecated in 2012)
* v1.14.0:
  - core: Cache window.clearTimeout in case it gets mocked

Change-Id: Ibf4b7ef11553555ef3c3827a6360fd405446b8f1

8 years agoWrap djvu large local copy downloads in pool counter
Aaron Schulz [Fri, 11 Apr 2014 23:05:12 +0000 (11 16:05 -0700)]
Wrap djvu large local copy downloads in pool counter

Change-Id: I3cade9d870f7c344434d7cee27506d53345ebdf9

8 years agoRevert "Work around HHVM bug with stdin/stdout in proc_open()"
Aaron Schulz [Fri, 11 Apr 2014 18:39:10 +0000 (11 11:39 -0700)]
Revert "Work around HHVM bug with stdin/stdout in proc_open()"

This was fixed in HHVM (https://github.com/facebook/hhvm/issues/1247).

This reverts commit 52e546640c5c0c0e817ae1fc5451a934b2c34de9.

bug: 56597
Change-Id: I9c97ba5645d794ff562347979e3f2027eb8b4534

8 years agoMake DjVu metadata be stored as serialized PHP array.
Brian Wolff [Thu, 5 Dec 2013 23:50:17 +0000 (5 19:50 -0400)]
Make DjVu metadata be stored as serialized PHP array.

Previously metadata was stored as a string of XML. Some of the
code in File expects the metadata to be an array serialized using
PHP's serialization format. In particular, this fixes the api
query=imageinfo module, and by extension instantCommons.

This supersedes Icaa16eeb

Bug: 37764
Change-Id: I5c1d2d2434f70b57137837bade797d4133c47b70

8 years agoPrefixSearch: Remove unnecessary wfSuppressWarnings()
Bartosz Dziewoński [Fri, 11 Apr 2014 21:42:45 +0000 (11 23:42 +0200)]
PrefixSearch: Remove unnecessary wfSuppressWarnings()

It was added in 4492854f (r68563), where the code this was suppressing
warnings for was something rather different. It doesn't seem necessary now.

Change-Id: Ia501afd1244b94563fe52294945798963f8db1a9

8 years agoMake .mw-ui-button height the same for all buttons
Juliusz Gonera [Wed, 5 Mar 2014 23:27:51 +0000 (5 15:27 -0800)]
Make .mw-ui-button height the same for all buttons

Regardless of their background color.

Change-Id: I00f905690e2934e972cc4ffc26631ead7c2d7567

8 years agoFix KSS mediawiki.ui style guide (docs)
Juliusz Gonera [Fri, 11 Apr 2014 21:24:42 +0000 (11 14:24 -0700)]
Fix KSS mediawiki.ui style guide (docs)

Broken after a change in directory structure...

Change-Id: Ibe208302c30483ee9476a176efe8dd88b21d30a5

8 years agoChangesListSpecialPage: Implement two new hooks superseding 4 old ones
Bartosz Dziewoński [Wed, 8 Jan 2014 17:17:08 +0000 (8 18:17 +0100)]
ChangesListSpecialPage: Implement two new hooks superseding 4 old ones

Old hooks (called by SpecialWatchlist, SpecialRecentChanges and
SpecialRecentChangesLinked) have been deprecated, but I'm not planning
to remove them anytime soon. (They have lots of usages in extensions
as of this writing.)

The new hooks (and their deprecated friends) are:

* ChangesListSpecialPageFilters:
  * Replaces: SpecialRecentChangesFilters and SpecialWatchlistFilters
  * The signature for this one is exactly the same as signatures for
    the other two. We might want to pass something else than $this
    here…

* ChangesListSpecialPageQuery
  * Replaces: SpecialRecentChangesQuery and SpecialWatchlistQuery
  * These hooks have wildly different signatures. The new one is a
    superset of the old ones, in a more reasonable order, with the
    addition of the name of the special page we're doing right now.

Change-Id: I9cceda5d2dcfc53c852c5682c466b48ad8f31202

8 years agoMerge "qunit: Remove race condition in 'test.mediawiki.qunit.testrunner'"
jenkins-bot [Fri, 11 Apr 2014 20:31:13 +0000 (11 20:31 +0000)]
Merge "qunit: Remove race condition in 'test.mediawiki.qunit.testrunner'"

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 11 Apr 2014 19:45:14 +0000 (11 19:45 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Idaec9e5cc1c68c224d2a6f05834be4eabd88b4ae

8 years agoMerge "IEFixes: Remove relativeforfloats() as it doesn't work"
jenkins-bot [Fri, 11 Apr 2014 19:28:07 +0000 (11 19:28 +0000)]
Merge "IEFixes: Remove relativeforfloats() as it doesn't work"

8 years agoMerge "IEFixes: Clean up duplicate variables"
jenkins-bot [Fri, 11 Apr 2014 19:20:18 +0000 (11 19:20 +0000)]
Merge "IEFixes: Clean up duplicate variables"

8 years agoMerge "Revert font stack to be just sans-serif"
Bartosz Dziewoński [Fri, 11 Apr 2014 18:41:50 +0000 (11 18:41 +0000)]
Merge "Revert font stack to be just sans-serif"

8 years agoqunit: Remove race condition in 'test.mediawiki.qunit.testrunner'
Timo Tijhof [Fri, 11 Apr 2014 18:40:52 +0000 (11 11:40 -0700)]
qunit: Remove race condition in 'test.mediawiki.qunit.testrunner'

Tests should be atomic because when re-running failed tests, they
run out of order (by design).

The thing being asserted here wasn't all that useful as that is
upstream behaviour we ought to be able to rely on.

Change-Id: I2f006e1cf05f5535e8220ca8ffc2da603745d184

8 years agoIEFixes: Remove relativeforfloats() as it doesn't work
Timo Tijhof [Thu, 10 Apr 2014 18:44:59 +0000 (10 11:44 -0700)]
IEFixes: Remove relativeforfloats() as it doesn't work

This is intended for IE6 where there is supposedly a bug with elements
that have inline 'style="float: left/right;"' which would
need position:relative as fix-up.

Aside from that bug being questionable, the way it was implemented
doesn't actually work in IE6 (or any version of IE for that matter).

The CSSOM property for 'float' is 'Node.style.cssFloat', and in
old versions of IE (including IE6) it was 'Node.style.styleFloat',
but it was never 'Node.style.float'.

Confirmed in browserstack with Windows XP/IE6, an element like
<div style="float: left;"></div> has .cssFloat, .float does not
exist and this code does nothing.

When testing I used style['float'] to ensure this isn't just broken
because of reserved words in property names (though it doesn't matter
because .float actually works fine in ES3 engines).

Fun fact: Regardless of the spec, Chrome actually implements
'Node.style.float' as well (only Chrome though; IE and Firefox
don't). So though this is only loaded in IE6 (where it doesn't
work), if this is loaded in Chrome, it actually works.

We could find out what this bug is and provide a working patch
(if needed), but since this is legacy code and we're not actively
in the habit of providing more fixes for IE6, and since this is
and has been broken for years, removing it seems a sensible move.

Follows-up 28cca60.

Change-Id: I7d4b4bcb81b4bdaeab40bcbbb34dff0aa51f2e22

8 years agoIEFixes: Clean up duplicate variables
Timo Tijhof [Thu, 10 Apr 2014 18:40:00 +0000 (10 11:40 -0700)]
IEFixes: Clean up duplicate variables

Declare the global ones as global, and assign them as implicit
globals instead of having both a local variable *and* a window
property. hasClass and expandedURLs are local variable only.

Follows-up 28cca60fcf493409d9dfd.

Change-Id: I81436c218eedf7c1930703c181a58adb2e5f44b0

8 years agoAPI: Make more continuations unique
Brad Jorsch [Tue, 24 Dec 2013 20:26:47 +0000 (24 15:26 -0500)]
API: Make more continuations unique

API queries must be completely ordered for proper behavior; otherwise
you may get into a situation where a query returns the same continuation
value that was provided. Various modules that have been using timestamps
in/as their continuation parameter can easily run into this problem.

Normally we'd have to add additional fields to the relevant indexes to
be able to make this work without having filesorting queries (which
MySQL really doesn't do well, it fetches all matching rows and only
applies the limit after[1]). But InnoDB has a "feature" where it
effectively appends the table's primary key to all other indexes,[2]
which makes these queries be properly indexed in that situation.
Apparently we're ok with this, since Icc43b62f was merged depending on
this feature.

Also, this change fixes some MySQLisms and other oddities done to
ApiQueryRecentChanges in Icc43b62f.

 [1]: https://dev.mysql.com/doc/refman/5.5/en/limit-optimization.html
 [2]: https://dev.mysql.com/doc/refman/5.5/en/innodb-table-and-index.html

Bug: 24782
Change-Id: I4c9f8c0c2bfd831755d4fa20a18f93fef1effd28

8 years agoMerge "Moved "Date format" user preference to "Appearance" tab"
Bartosz Dziewoński [Fri, 11 Apr 2014 13:10:10 +0000 (11 13:10 +0000)]
Merge "Moved "Date format" user preference to "Appearance" tab"

8 years agoMoved "Date format" user preference to "Appearance" tab
Tony Thomas [Thu, 10 Apr 2014 18:41:01 +0000 (11 00:11 +0530)]
Moved "Date format" user preference to "Appearance" tab

This user preference affects the appearance of the site,
so this feels like a natural fit

Bug: 63582
Change-Id: Ib97b1b39723f1835b7f6086ff1418ab5de13a7a1

8 years agoFix typo in comment
Siebrand Mazeland [Thu, 10 Apr 2014 21:27:27 +0000 (10 23:27 +0200)]
Fix typo in comment

Change-Id: I18447c07a783f7d68b89b08cf74eed6149f88670

8 years agoMerge "Clarify the "Watchlist-details" message"
Siebrand [Fri, 11 Apr 2014 06:09:39 +0000 (11 06:09 +0000)]
Merge "Clarify the "Watchlist-details" message"

8 years agoRemoved $wgMaxBacklinksInvalidate
Aaron Schulz [Wed, 9 Apr 2014 00:26:37 +0000 (8 17:26 -0700)]
Removed $wgMaxBacklinksInvalidate

This was a quick hack, introduced in I4fadded0e, that was later made
redundant by $wgJobBackoffThrottling.

Change-Id: Iddc5f6cfd6554ad9b6e54b8ce1b4805af809c7c8

8 years agoClarify the "Watchlist-details" message
Aditya Sastry [Thu, 10 Apr 2014 22:01:59 +0000 (11 03:31 +0530)]
Clarify the "Watchlist-details" message

Bug: 53098
Change-Id: I74afadb81e15e6a495b784f0a9c95630ae09abd2

8 years agojquery.suggestions: Debounce calls to $.suggestions.special
Bartosz Dziewoński [Wed, 9 Apr 2014 12:07:49 +0000 (9 14:07 +0200)]
jquery.suggestions: Debounce calls to $.suggestions.special

The custom calls used there can be comparatively expensive and it
might not be a good idea to redo them on every keystroke.

Bug: 59172
Change-Id: I0cdf53eec798a714825c94d80f100b5cf5841f5d

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 10 Apr 2014 22:01:50 +0000 (10 22:01 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie834afa64574bfbecc97a9e706370b807a9f2f50

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 10 Apr 2014 21:43:43 +0000 (10 21:43 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Iae58b6b9c27350d9fe472304b06ac6eae8d88dea

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 10 Apr 2014 20:25:38 +0000 (10 20:25 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Iab0abcc67f667d807a01d6c5864c1b5c4343ee74

8 years agoMerge "Update tests/frontend devDependencies"
jenkins-bot [Thu, 10 Apr 2014 19:49:53 +0000 (10 19:49 +0000)]
Merge "Update tests/frontend devDependencies"

8 years agoMerge "Remove trailing spaces from some language files"
jenkins-bot [Thu, 10 Apr 2014 19:27:48 +0000 (10 19:27 +0000)]
Merge "Remove trailing spaces from some language files"

8 years agoUpdate tests/frontend devDependencies
Timo Tijhof [Thu, 10 Apr 2014 19:04:56 +0000 (10 12:04 -0700)]
Update tests/frontend devDependencies

* grunt-contrib-jshint: v0.8.0 to v0.9.2
  - https://github.com/gruntjs/grunt-contrib-jshint/blob/v0.9.2/CHANGELOG
  - Minor changes and bug fixes
  - Lastest version is v0.10.0, but that embeds jshint v2.5.0
    which we don't want to use yet.

* grunt-contrib-watch: v0.5.3 to v0.6.1 (latest)
  - https://github.com/gruntjs/grunt-contrib-watch/blob/v0.6.1/CHANGELOG
  - Minor changes and bug fixes

* grunt-jscs-checker: v0.4.0 to v0.4.1 (latest)
  - https://github.com/gustavohenke/grunt-jscs-checker/compare/0.4.0...0.4.1
  - Minor changes

Change-Id: I68e9057f8e353e2c3ac8b889977de07597211c54

8 years agoMerge "mediawiki.api: Use FormData for POST requests when supported"
jenkins-bot [Thu, 10 Apr 2014 19:19:01 +0000 (10 19:19 +0000)]
Merge "mediawiki.api: Use FormData for POST requests when supported"

8 years agoRemove trailing spaces from some language files
umherirrender [Thu, 10 Apr 2014 19:02:25 +0000 (10 21:02 +0200)]
Remove trailing spaces from some language files

Change-Id: I61d015a9a6f1b8487130393f1c104bc39363a3d1

8 years agoMerge "Document new param of Title::countRevisionsBetween"
jenkins-bot [Thu, 10 Apr 2014 18:57:05 +0000 (10 18:57 +0000)]
Merge "Document new param of Title::countRevisionsBetween"

8 years agoExclude external RC entries (e.g. Wikidata) from Special:ActiveUsers
Brian Wolff [Thu, 10 Apr 2014 19:31:55 +0000 (10 16:31 -0300)]
Exclude external RC entries (e.g. Wikidata) from Special:ActiveUsers

People usually want to know who the active users are on the local
wiki, not who edited something on Wikidata.

Note, this changes the query to no longer use a covering index
when joining against the recentchanges table when displaying
the page.

Bug: 63769
Change-Id: I919123f396d0901822108a4675593a2ff5b7307f

8 years agoMerge "Fixes for messages quoting each other and punctuation"
jenkins-bot [Thu, 10 Apr 2014 18:23:48 +0000 (10 18:23 +0000)]
Merge "Fixes for messages quoting each other and punctuation"

8 years agoDocument new param of Title::countRevisionsBetween
umherirrender [Thu, 10 Apr 2014 17:58:34 +0000 (10 19:58 +0200)]
Document new param of Title::countRevisionsBetween

Follow-Up: Ie51a491ff5d22c2d84934e83d4b3f690c9dbd595
Change-Id: I61483f50512027559c4c3b63c49602b8aea755fd

8 years agoMerge "mediawiki.special: Remove HTML backwards-compatibility styles"
jenkins-bot [Thu, 10 Apr 2014 16:53:46 +0000 (10 16:53 +0000)]
Merge "mediawiki.special: Remove HTML backwards-compatibility styles"

8 years agoMerge "Follow-up: If985b16c – Vector external link change release notes"
jenkins-bot [Thu, 10 Apr 2014 15:54:20 +0000 (10 15:54 +0000)]
Merge "Follow-up: If985b16c – Vector external link change release notes"

8 years agoMerge "mediawiki.jqueryMsg: Don't throw parse errors in the user's face"
Bartosz Dziewoński [Thu, 10 Apr 2014 15:54:02 +0000 (10 15:54 +0000)]
Merge "mediawiki.jqueryMsg: Don't throw parse errors in the user's face"

8 years agoFollow-up: If985b16c – Vector external link change release notes
jrobson [Tue, 8 Apr 2014 15:59:32 +0000 (8 08:59 -0700)]
Follow-up: If985b16c – Vector external link change release notes

Also strengthen the CSS selector and remove a FIXME that it fixed.

Bug: 54604
Change-Id: I84765c536ade4087d8d3d9753966a443e49b2c38