From c66260df9089bac6fa88b20707cd7543b1be66fb Mon Sep 17 00:00:00 2001
From: jbevain <jbevain@e3ebcda4-bce8-0310-ba0a-eca2169e7518>
Date: Wed, 19 May 2010 14:41:12 +0000
Subject: [PATCH] 2010-05-19  Jb Evain  <jbevain@novell.com>

	* Enumerable.cs: fix GroupBy to deal with a null key for the last
	group entry. Also fix GroupBy to properly throw ArgumentNullException.



git-svn-id: svn+ssh://mono-cvs.ximian.com/source/trunk/mcs@157558 e3ebcda4-bce8-0310-ba0a-eca2169e7518
---
 class/System.Core/System.Linq/ChangeLog     |  5 +++
 class/System.Core/System.Linq/Enumerable.cs | 62 ++++++++++++++++++++++-------
 2 files changed, 53 insertions(+), 14 deletions(-)

diff --git a/class/System.Core/System.Linq/ChangeLog b/class/System.Core/System.Linq/ChangeLog
index c36b8c425d..8c9d0be82d 100644
--- a/class/System.Core/System.Linq/ChangeLog
+++ b/class/System.Core/System.Linq/ChangeLog
@@ -1,3 +1,8 @@
+2010-05-19  Jb Evain  <jbevain@novell.com>
+
+	* Enumerable.cs: fix GroupBy to deal with a null key for the last
+	group entry. Also fix GroupBy to properly throw ArgumentNullException.
+
 2010-05-05  Jérémie Laval  <jeremie.laval@gmail.com>
 
 	* ParallelEnumerable.cs: Some operators weren't declared
diff --git a/class/System.Core/System.Linq/Enumerable.cs b/class/System.Core/System.Linq/Enumerable.cs
index 56018f49d7..5a1ae605e4 100644
--- a/class/System.Core/System.Linq/Enumerable.cs
+++ b/class/System.Core/System.Linq/Enumerable.cs
@@ -891,8 +891,8 @@ namespace System.Linq
 		static IEnumerable<IGrouping<TKey, TSource>> CreateGroupByIterator<TSource, TKey> (this IEnumerable<TSource> source,
 			Func<TSource, TKey> keySelector, IEqualityComparer<TKey> comparer)
 		{
-			Dictionary<TKey, List<TSource>> groups = new Dictionary<TKey, List<TSource>> ();
-			List<TSource> nullList = new List<TSource> ();
+			var groups = new Dictionary<TKey, List<TSource>> ();
+			var nullList = new List<TSource> ();
 			int counter = 0;
 			int nullCounter = -1;
 
@@ -916,14 +916,18 @@ namespace System.Linq
 			}
 
 			counter = 0;
-			foreach (KeyValuePair<TKey, List<TSource>> group in groups) {
+			foreach (var group in groups) {
 				if (counter == nullCounter) {
-					Grouping<TKey, TSource> nullGroup = new Grouping<TKey, TSource> (default (TKey), nullList);
-					yield return nullGroup;
+					yield return new Grouping<TKey, TSource> (default (TKey), nullList);
 					counter++;
 				}
-				Grouping<TKey, TSource> grouping = new Grouping<TKey, TSource> (group.Key, group.Value);
-				yield return grouping;
+
+				yield return new Grouping<TKey, TSource> (group.Key, group.Value);
+				counter++;
+			}
+
+			if (counter == nullCounter) {
+				yield return new Grouping<TKey, TSource> (default (TKey), nullList);
 				counter++;
 			}
 		}
@@ -939,8 +943,14 @@ namespace System.Linq
 		{
 			Check.SourceAndKeyElementSelectors (source, keySelector, elementSelector);
 
-			Dictionary<TKey, List<TElement>> groups = new Dictionary<TKey, List<TElement>> ();
-			List<TElement> nullList = new List<TElement> ();
+			return CreateGroupByIterator (source, keySelector, elementSelector, comparer);
+		}
+
+		static IEnumerable<IGrouping<TKey, TElement>> CreateGroupByIterator<TSource, TKey, TElement> (this IEnumerable<TSource> source,
+			Func<TSource, TKey> keySelector, Func<TSource, TElement> elementSelector, IEqualityComparer<TKey> comparer)
+		{
+			var groups = new Dictionary<TKey, List<TElement>> ();
+			var nullList = new List<TElement> ();
 			int counter = 0;
 			int nullCounter = -1;
 
@@ -965,14 +975,18 @@ namespace System.Linq
 			}
 
 			counter = 0;
-			foreach (KeyValuePair<TKey, List<TElement>> group in groups) {
+			foreach (var group in groups) {
 				if (counter == nullCounter) {
-					Grouping<TKey, TElement> nullGroup = new Grouping<TKey, TElement> (default (TKey), nullList);
-					yield return nullGroup;
+					yield return new Grouping<TKey, TElement> (default (TKey), nullList);
 					counter++;
 				}
-				Grouping<TKey, TElement> grouping = new Grouping<TKey, TElement> (group.Key, group.Value);
-				yield return grouping;
+
+				yield return new Grouping<TKey, TElement> (group.Key, group.Value);
+				counter++;
+			}
+
+			if (counter == nullCounter) {
+				yield return new Grouping<TKey, TElement> (default (TKey), nullList);
 				counter++;
 			}
 		}
@@ -989,6 +1003,16 @@ namespace System.Linq
 			Func<TKey, IEnumerable<TElement>, TResult> resultSelector,
 			IEqualityComparer<TKey> comparer)
 		{
+			Check.GroupBySelectors (source, keySelector, elementSelector, resultSelector);
+
+			return CreateGroupByIterator (source, keySelector, elementSelector, resultSelector, comparer);
+		}
+
+		static IEnumerable<TResult> CreateGroupByIterator<TSource, TKey, TElement, TResult> (this IEnumerable<TSource> source,
+			Func<TSource, TKey> keySelector, Func<TSource, TElement> elementSelector,
+			Func<TKey, IEnumerable<TElement>, TResult> resultSelector,
+			IEqualityComparer<TKey> comparer)
+		{
 			IEnumerable<IGrouping<TKey, TElement>> groups = GroupBy<TSource, TKey, TElement> (
 				source, keySelector, elementSelector, comparer);
 
@@ -1008,6 +1032,16 @@ namespace System.Linq
 			Func<TKey, IEnumerable<TSource>, TResult> resultSelector,
 			IEqualityComparer<TKey> comparer)
 		{
+			Check.SourceAndKeyResultSelectors (source, keySelector, resultSelector);
+
+			return CreateGroupByIterator (source, keySelector, resultSelector, comparer);
+		}
+
+		static IEnumerable<TResult> CreateGroupByIterator<TSource, TKey, TResult> (this IEnumerable<TSource> source,
+			Func<TSource, TKey> keySelector,
+			Func<TKey, IEnumerable<TSource>, TResult> resultSelector,
+			IEqualityComparer<TKey> comparer)
+		{
 			IEnumerable<IGrouping<TKey,TSource>> groups = GroupBy<TSource, TKey> (source, keySelector, comparer);
 
 			foreach (IGrouping<TKey, TSource> group in groups)
-- 
2.11.4.GIT