1 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
3 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
5 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
7 * typemanager.cs: Add MakeGenericMethod that checks if the method
8 is really the generic method definition.
10 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
11 to inflate generic methods.
13 2009-12-08 Marek Safar <marek.safar@gmail.com>
16 anonymous.cs: Use actual type parameters when checking for generic
19 2009-12-08 Marek Safar <marek.safar@gmail.com>
22 expression.cs (DoNumericPromotion): Fixed typo.
24 2009-12-08 Marek Safar <marek.safar@gmail.com>
26 *.cs: Moving to generics world.
28 cs-parser.jay: Removed current_array_type.
30 2009-12-07 Marek Safar <marek.safar@gmail.com>
32 *.cs: Moving to generics world.
34 2009-12-04 Marek Safar <marek.safar@gmail.com>
36 *.cs: Moving to generics world (day 2).
38 2009-12-03 Marek Safar <marek.safar@gmail.com>
40 *.cs: Moving to generics world.
42 2009-12-02 Marek Safar <marek.safar@gmail.com>
44 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
45 Encode dynamic type attribute for elements where attributes cannot
48 2009-12-01 Marek Safar <marek.safar@gmail.com>
50 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
53 2009-12-01 Marek Safar <marek.safar@gmail.com>
56 * class.cs: Never report a unused warning for generic events to
57 workaround wrong expression type.
59 2009-11-30 Marek Safar <marek.safar@gmail.com>
62 * decl.cs, class.cs: Check partial method definitions using correct
65 2009-11-30 Marek Safar <marek.safar@gmail.com>
67 * argument.cs: Don't cache rarely used dynamic flag.
69 2009-11-27 Marek Safar <marek.safar@gmail.com>
71 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
73 2009-11-27 Marek Safar <marek.safar@gmail.com>
75 * ecore.cs (SimpleName): Removed no longer needed in_transit as
76 Resolve is now non-reentrant (saves ~0.6MB for corlib).
78 2009-11-26 Marek Safar <marek.safar@gmail.com>
81 * decl.cs: Check private nested types of nested types recursively.
83 2009-11-26 Marek Safar <marek.safar@gmail.com>
86 * location.cs: Ignore self referencing #line directive
88 2009-11-26 Marek Safar <marek.safar@gmail.com>
91 * class.cs: Allow single unsafe fixed buffer fields.
93 2009-11-26 Marek Safar <marek.safar@gmail.com>
95 * expression: Optimize few more zero-based operations.
97 2009-11-26 Marek Safar <marek.safar@gmail.com>
99 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
100 avoids boxing of literal values.
102 2009-11-26 Marek Safar <marek.safar@gmail.com>
104 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
105 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
106 codegen.cs: LocatedToken redesing to avoid excessive allocation and
107 boxing (saves ~7MB for corlib). Also fixes presise token location.
109 2009-11-25 Marek Safar <marek.safar@gmail.com>
111 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
114 2009-11-24 Marek Safar <marek.safar@gmail.com>
116 * expression.cs: Lower static array initializer barrier.
118 * support.cs, driver.cs: Share reader buffer.
120 2009-11-23 Marek Safar <marek.safar@gmail.com>
122 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
124 2009-11-23 Marek Safar <marek.safar@gmail.com>
126 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
127 cleanup some obsolete code.
129 2009-11-20 Marek Safar <marek.safar@gmail.com>
131 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
134 2009-11-20 Marek Safar <marek.safar@gmail.com>
136 * *.cs: Resolved expressions are never resolved again, this helps to
137 uncover some not easy to find bugs and improve the performance.
139 2009-11-19 Marek Safar <marek.safar@gmail.com>
141 * *.cs: Made constant expressions fully compatible with any other
144 2009-11-19 Marek Safar <marek.safar@gmail.com>
146 * *.cs: DoResolve is a worker method and has to be protected.
148 2009-11-18 Marek Safar <marek.safar@gmail.com>
150 * *.cs: More context specific handling.
152 2009-11-17 Marek Safar <marek.safar@gmail.com>
154 * *.cs: More context specific handling.
156 2009-11-16 Marek Safar <marek.safar@gmail.com>
158 * dynamic.cs, class.cs: Removed few fixed user types conversions.
160 * symbolwriter.cs: Uses public ILOffset.
162 2009-11-13 Marek Safar <marek.safar@gmail.com>
164 A fix for bug #553650
165 * generic.cs: Another missing TypeToCoreType, still too many to fix.
167 2009-11-13 Marek Safar <marek.safar@gmail.com>
169 A fix for bug #555170
171 * class.cs, delegate.cs, enum.cs: Constants have to be available
172 for parameters resolve.
174 2009-11-12 Marek Safar <marek.safar@gmail.com>
176 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
179 2009-11-12 Marek Safar <marek.safar@gmail.com>
181 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
182 with a statically known candidate set.
184 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
186 * generic.cs: Made type inflation for generic constraint checks
187 recursive. This fixes BGO #553655.
189 2009-11-11 Marek Safar <marek.safar@gmail.com>
191 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
194 2009-11-10 Marek Safar <marek.safar@gmail.com>
196 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
197 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
198 attribute.cs: Add some dynamic error checking.
200 2009-11-07 Marek Safar <marek.safar@gmail.com>
202 A fix for bug #553465
204 * expression.cs: Fixed mixed version of expression tree anonymous
207 2009-11-06 Marek Safar <marek.safar@gmail.com>
209 A fix for bug #553031
211 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
212 expression tree version of anonymous type with members declaration.
214 2009-11-05 Marek Safar <marek.safar@gmail.com>
216 * parameter.cs: Handle nullable parameter default expression.
218 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
219 class.cs, attribute.cs: Check for wrong dynamic arguments.
221 2009-11-05 Marek Safar <marek.safar@gmail.com>
223 * statement.cs: Dynamic statements.
225 2009-11-04 Marek Safar <marek.safar@gmail.com>
227 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
228 Compound assignments over dynamic type.
230 2009-11-03 Marek Safar <marek.safar@gmail.com>
232 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
233 constructor arguments.
235 2009-10-30 Marek Safar <marek.safar@gmail.com>
237 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
238 codegen.cs: Unary mutator on dynamic member access expression.
240 2009-10-29 Marek Safar <marek.safar@gmail.com>
242 A fix for bug #550580
243 * convert.cs: Don't eliminate explicit precission casts.
245 2009-10-28 Marek Safar <marek.safar@gmail.com>
247 A fix for bug #550404
249 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
250 expression.cs, statement.cs, ecore.cs: Quote any nested expression
253 2009-10-27 Marek Safar <marek.safar@gmail.com>
255 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
258 * class.cs: Allow nullable binary user operators.
260 2009-10-26 Marek Safar <marek.safar@gmail.com>
262 * expression.cs: Move binary expression optimization at the end of
265 2009-10-23 Marek Safar <marek.safar@gmail.com>
267 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
268 Separate NullConstant from NullLiteral.
270 2009-10-23 Marek Safar <marek.safar@gmail.com>
272 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
273 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
274 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
275 ModuleContainer. Add common unclosed member check routine.
277 2009-10-22 Marek Safar <marek.safar@gmail.com>
279 * argument.cs: Use literal flag for real literals only.
281 * dynamic.cs: Use correct return type for custom delegates.
283 2009-10-22 Marek Safar <marek.safar@gmail.com>
285 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
288 2009-10-22 Marek Safar <marek.safar@gmail.com>
290 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
292 2009-10-21 Marek Safar <marek.safar@gmail.com>
294 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
297 2009-10-21 Marek Safar <marek.safar@gmail.com>
299 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
302 2009-10-20 Marek Safar <marek.safar@gmail.com>
304 * argument.cs, dynamic.cs, expression.cs: Latest API update.
306 2009-10-19 Marek Safar <marek.safar@gmail.com>
308 * typemanager.cs, expression.cs: Dynamic array initializer.
310 2009-10-16 Marek Safar <marek.safar@gmail.com>
312 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
315 2009-10-16 Marek Safar <marek.safar@gmail.com>
317 A fix for bug #493523, #507067
318 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
319 standard nullable conversion using underlying standard conversion
320 and not full conversion.
322 2009-10-15 Marek Safar <marek.safar@gmail.com>
324 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
325 type in VerifyArgumentsCompat.
327 2009-10-15 Marek Safar <marek.safar@gmail.com>
329 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
330 Reject variable used with type arguments.
332 2009-10-14 Marek Safar <marek.safar@gmail.com>
334 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
335 Implement dynamic expressions assignment.
337 2009-10-14 Marek Safar <marek.safar@gmail.com>
339 * expression.cs: Build underlying expression when resolving unary
342 2009-10-14 Marek Safar <marek.safar@gmail.com>
344 * expression.cs: Emit enum array initializer using binary blob.
346 2009-10-08 Marek Safar <marek.safar@gmail.com>
348 * typemanager.cs, constant.cs: Optimize decimal constants which fit
351 2009-10-07 Marek Safar <marek.safar@gmail.com>
353 * typemanager.cs: Reset object_type.
355 * assign: Made SimpleAssign public.
357 2009-10-06 Marek Safar <marek.safar@gmail.com>
359 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
360 invocation assembly to IsThisOrFriendAssembly.
362 2009-10-05 Marek Safar <marek.safar@gmail.com>
364 * expression.cs: Equality comparison of generic parameter with
367 2009-10-05 Marek Safar <marek.safar@gmail.com>
369 A fix for bug #543570
370 * generic.cs: Import predefined constraints correctly.
372 2009-10-02 Marek Safar <marek.safar@gmail.com>
374 * ecore.cs: Don't crash on overloads with optional paremeters where
375 arguments count overflows.
377 * parameter.cs: Import optional parameter constants using optional
380 2009-10-01 Marek Safar <marek.safar@gmail.com>
382 * Makefile: Default is gmcs compiler.
384 2009-10-01 Marek Safar <marek.safar@gmail.com>
386 * cs-parser.jay: Fixed few NRE.
388 2009-10-01 Marek Safar <marek.safar@gmail.com>
390 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
392 2009-09-30 Marek Safar <marek.safar@gmail.com>
394 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
395 ShimExpression, ImplicitCast.
397 2009-09-30 Marek Safar <marek.safar@gmail.com>
399 A fix for bug #542959
400 * delegate.cs: Emit correct delegate instance variable when there
401 are static and non-static overloads.
403 2009-09-29 Marek Safar <marek.safar@gmail.com>
405 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
406 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
408 2009-09-28 Marek Safar <marek.safar@gmail.com>
410 A fix for bug #542487
411 * ecore.cs: Resolve extension methods hidden by properties.
413 2009-09-25 Marek Safar <marek.safar@gmail.com>
415 * expression.cs, ecore.cs: More dynamic binary expressions.
417 2009-09-22 Marek Safar <marek.safar@gmail.com>
419 * nullable.cs, expression.cs: Fixed null lifted conversion for
420 bitwise enum operations.
422 2009-09-22 Marek Safar <marek.safar@gmail.com>
424 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
425 values in checked context.
427 2009-09-22 Marek Safar <marek.safar@gmail.com>
429 * expression.cs, ecore.cs: Fixed array index constant conversion.
431 2009-09-20 Miguel de Icaza <miguel@novell.com>
433 * expression.cs: Do not crash when MemberLookup returns something
434 that is not a MemberExpr here. Report error 582 instead.
438 2009-09-18 Marek Safar <marek.safar@gmail.com>
440 * decl.cs, class.cs: Check protected property accessors.
442 2009-09-18 Marek Safar <marek.safar@gmail.com>
444 * dynamic.cs, assign.cs: Dynamic compound assignment.
446 2009-09-17 Marek Safar <marek.safar@gmail.com>
448 * expression.cs: Fixed compound assignment explicit conversion.
450 2009-09-17 Marek Safar <marek.safar@gmail.com>
452 * expression.cs, ecore.cs: Cannot infer variables from method group.
454 2009-09-16 Marek Safar <marek.safar@gmail.com>
456 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
457 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
458 codegen.cs: Dynamic binary operations scaffolding.
460 2009-09-15 Marek Safar <marek.safar@gmail.com>
462 * expression.cs: Fixes nullable promotion for enum type variables.
464 2009-09-11 Marek Safar <marek.safar@gmail.com>
466 * driver.cs, dynamic.cs: Reset more static variables.
468 2009-09-11 Marek Safar <marek.safar@gmail.com>
470 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
471 driver.cs: Introduced Expression::MakeExpression.
473 2009-09-11 Marek Safar <marek.safar@gmail.com>
475 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
477 2009-09-09 Marek Safar <marek.safar@gmail.com>
479 * eval.cs, report.cs: Use Console.Out for all eval error or warning
482 2009-09-09 Marek Safar <marek.safar@gmail.com>
484 A fix for bug #518707
485 * expression.cs (Is): Optimize only generic parameter type
486 expression probing value type generic parameter.
488 2009-09-09 Marek Safar <marek.safar@gmail.com>
490 A fix for bug #532571
491 * ecore.cs: Check for simple name type arguments used with
494 2009-09-08 Marek Safar <marek.safar@gmail.com>
496 A fix for bug #497421
497 * generic.cs (CheckConstraint): Don't use buildin types to check for
498 parameterless constructor.
500 2009-09-08 Marek Safar <marek.safar@gmail.com>
502 A fix for bug #537402
503 * generic.cs (CheckConstraint): Correctly inflate generic type
504 arguments when checking generic method.
506 2009-09-08 Marek Safar <marek.safar@gmail.com>
508 A fix for bug #536463
509 * decl.cs (AddToContainer): Don't report collision between explicit
510 and parameterless non-explicit members.
512 2009-09-08 Marek Safar <marek.safar@gmail.com>
514 * eval.cs: Reset more static stuff.
516 2009-09-07 Marek Safar <marek.safar@gmail.com>
518 A fix for bug #324625
519 * expression.cs, ecore.cs: Create nested generic type expression
520 using declaring and not current type.
522 2009-09-07 Marek Safar <marek.safar@gmail.com>
524 * *.cs: Changed Report class to accept various output printers and
525 be an instance class. An expression resolver can now use different
526 message reporter for each call and Report.Error can safely throw
527 an exception. Part of ongoing work to turn mcs into proper library.
529 2009-09-04 Marek Safar <marek.safar@gmail.com>
531 * statement.cs, ecore.cs: Removed error reporting from emit code.
533 2009-09-04 Marek Safar <marek.safar@gmail.com>
535 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
537 2009-09-03 Marek Safar <marek.safar@gmail.com>
539 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
540 parser checks out of constructors.
542 2009-09-02 Marek Safar <marek.safar@gmail.com>
544 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
546 2009-09-02 Marek Safar <marek.safar@gmail.com>
548 A fix for bug #535448
549 * anonymous.cs, class.cs: Copy return label between all contexts.
551 2009-09-02 Marek Safar <marek.safar@gmail.com>
553 A fix for bug #535395
554 * namespace.cs: Resolve context can be null.
556 2009-08-25 Marek Safar <marek.safar@gmail.com>
558 A fix for bug #533912
559 * generic.cs: Use correct context for constraints resolving.
561 2009-08-25 Marek Safar <marek.safar@gmail.com>
563 A fix for bug #532630
564 * driver.cs: Trim conditional symbols.
566 2009-08-25 Marek Safar <marek.safar@gmail.com>
568 * context.cs: New file.
570 * *.exe.sources, *.csproj: Updated.
572 2009-08-25 Marek Safar <marek.safar@gmail.com>
574 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
575 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
576 IMembercontext, some small cleanups.
578 2009-08-24 Marek Safar <marek.safar@gmail.com>
580 * *.cs: Split ResolveContext and EmitContext.
582 2009-08-24 Marek Safar <marek.safar@gmail.com>
584 * *.cs: Only ResolveContext implements IMemberContext.
586 2009-08-21 Marek Safar <marek.safar@gmail.com>
588 * *.cs: Renamed IResolveContext to IMemberContext.
590 2009-08-21 Marek Safar <marek.safar@gmail.com>
592 * *.cs: Detached ResolveContext from EmitContext.
594 2009-08-21 Marek Safar <marek.safar@gmail.com>
596 * codegen.cs: Moved flow-analysis to BlockContext.
598 2009-08-21 Marek Safar <marek.safar@gmail.com>
600 * *.cs: Detached BlockContext from EmitContext.
602 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
604 * statement.cs: avoid nullref when the return value of GetEnumerator()
605 does not contain any MoveNext() method.
607 2009-08-19 Marek Safar <marek.safar@gmail.com>
609 * *.cs: Removed IResolveContext::GenericDeclContainer.
611 2009-08-19 Marek Safar <marek.safar@gmail.com>
613 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
615 2009-08-19 Marek Safar <marek.safar@gmail.com>
617 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
618 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
620 2009-08-18 Marek Safar <marek.safar@gmail.com>
622 * *.cs: Removed boolean fields from EmitContext.
624 2009-08-18 Marek Safar <marek.safar@gmail.com>
626 * *.cs: Add IResolveContext::IsStatic.
628 2009-08-18 Marek Safar <marek.safar@gmail.com>
630 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
632 2009-08-17 Marek Safar <marek.safar@gmail.com>
634 * *.cs: Removed DeclContainer from EmitContext.
636 2009-08-17 Marek Safar <marek.safar@gmail.com>
638 * *.cs: Add IResolveContext::CurrentTypeParameters.
640 2009-08-14 Marek Safar <marek.safar@gmail.com>
642 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
644 2009-08-14 Marek Safar <marek.safar@gmail.com>
646 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
647 codegen.cs: Add IResolveContext::LookupExtensionMethod.
649 2009-08-13 Marek Safar <marek.safar@gmail.com>
651 * decl.cs: Look in PartialContainer for parent type parameters.
653 2009-08-13 Marek Safar <marek.safar@gmail.com>
655 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
656 codegen.cs: Add IResolveContext::LookupTypeParameter.
658 2009-08-13 Marek Safar <marek.safar@gmail.com>
660 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
661 Moved resolved logic from Emit to Resolve.
663 2009-08-13 Marek Safar <marek.safar@gmail.com>
665 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
666 codegen.cs: Reworked atttributes handling of ResolveContext.
668 2009-08-12 Marek Safar <marek.safar@gmail.com>
670 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
671 LookupNamespaceOrType to ResolveContext.
673 2009-08-12 Marek Safar <marek.safar@gmail.com>
675 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
676 class.cs: Removed unused parameters and methods.
678 2009-08-11 Marek Safar <marek.safar@gmail.com>
680 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
681 codegen.cs: Finding the best common type of a set of expressions for
684 2009-08-07 Marek Safar <marek.safar@gmail.com>
686 * dynamic.cs, expression.cs: More dynamic conversions.
688 2009-08-06 Miguel de Icaza <miguel@novell.com>
690 * generic.cs: This loop was incorrect, it was increment ii, but
691 checking for `i'. This was a change introduced to fix #327497,
694 * class.cs: Catch another case for cs0533 error, fixes #324782.
696 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
698 * typemanager.cs (GetGenericArguments): SRE returns null for
699 generic methods on type builder instances if they are not generic
700 themselves. For example, for Foo<int>::Bar() it returns null, but
701 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
703 2009-08-05 Marek Safar <marek.safar@gmail.com>
705 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
706 delegate.cs: Work on dynamic binding.
708 2009-08-04 Marek Safar <marek.safar@gmail.com>
710 A second fix for bug #525342
711 * class.cs: Attach partial method attributes to method
714 2009-08-03 Marek Safar <marek.safar@gmail.com>
716 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
719 * rootcontext.cs: Default to langversion v4.
721 2009-08-03 Marek Safar <marek.safar@gmail.com>
723 * pending.cs: Check return type before member info is set.
725 2009-08-03 Marek Safar <marek.safar@gmail.com>
727 * anonymous.cs: Fully initialize generic hoisted field expression.
729 2009-08-02 Miguel de Icaza <miguel@novell.com>
731 * cs-parser.jay: Flag variables declared on the interactive shell
732 as used to prevent the 168 warning about local variable not being
735 2009-07-31 Marek Safar <marek.safar@gmail.com>
737 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
738 attribute.cs: Emit dynamic export attribute.
740 2009-07-30 Marek Safar <marek.safar@gmail.com>
742 * expression.cs: More verifier work.
744 2009-07-29 Marek Safar <marek.safar@gmail.com>
746 * nullable.cs: Fixed SRE crash during corlib compilation.
748 2009-07-29 Marek Safar <marek.safar@gmail.com>
750 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
751 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
752 More TypeManager.TypeToCoreType needed.
754 2009-07-29 Marek Safar <marek.safar@gmail.com>
756 * anonymous.cs: Update after recent SRE fixes.
758 2009-07-28 Marek Safar <marek.safar@gmail.com>
760 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
761 version of GetFieldHandle for fields of generic types.
763 2009-07-27 Marek Safar <marek.safar@gmail.com>
765 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
766 ecore.cs: Add TypeManager.IsDynamicType,
767 PredefinedAttributes.Dynamic.
769 2009-07-27 Marek Safar <marek.safar@gmail.com>
771 A fix for bug #415375
772 * expression.cs: Fixed object and reference type parameter
775 2009-07-27 Marek Safar <marek.safar@gmail.com>
777 A fix for bug #525342
778 * class.cs: Attach partial method attributes to method
781 2009-07-24 Marek Safar <marek.safar@gmail.com>
783 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
786 2009-07-24 Marek Safar <marek.safar@gmail.com>
788 * anonymous.cs (MutateField): Add imported types handling.
790 2009-07-23 Marek Safar <marek.safar@gmail.com>
792 * expression.cs, delegate.cs: Moved arguments resolve into their
793 counterparts expressions. Removed argument resolve from
794 CollectionElementInitializer.
796 2009-07-23 Marek Safar <marek.safar@gmail.com>
798 A fix for bug #523683
799 * convert.cs, delegate.cs: Use common overload mechanism for method
800 group conversion check.
802 2009-07-22 Marek Safar <marek.safar@gmail.com>
804 A fix for bug #523899
805 * generics.cs: Exact type inference with other bound types.
807 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
809 Don't complain when the same type is implemented by the output
810 assembly as well as multiple referenced assemblies
811 * namespace.cs (RootNamespace.LookupTypeReflection): Add
812 'must_be_unique' flag.
813 (GlobalRootNamespace): Update to changes.
814 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
815 already have a type in hand.
817 2009-07-22 Marek Safar <marek.safar@gmail.com>
819 * expression.cs: More verifier instrumentation.
821 * statement.cs: Do proper throw expression conversion.
823 2009-07-22 Marek Safar <marek.safar@gmail.com>
825 A fix for bug #522789
826 * expression.cs: Mutate invocation return type.
828 2009-07-16 Marek Safar <marek.safar@gmail.com>
830 * anonymous.cs: Split assignable and readonly generated variable
833 2009-07-16 Marek Safar <marek.safar@gmail.com>
835 A fix for bug #521671
836 * statement.cs: Fixed crash when checking missing type.
838 2009-07-16 Marek Safar <marek.safar@gmail.com>
840 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
841 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
842 class.cs, driver.cs: Work on dynamic binding.
844 * dynamic.cs: New file.
846 * *.sources, *.proj: Updated.
848 2009-07-15 Marek Safar <marek.safar@gmail.com>
850 * expression.cs (Conditional): Avoid double Resolve.
852 2009-07-13 Marcus Griep <marcus@griep.us>
854 * ecore.cs: Fix obscure bug with resolving members of interfaces
855 that hide parent interface members. Fixes bug #444388 and corrects
858 2009-07-13 Marek Safar <marek.safar@gmail.com>
860 * expression.cs (LocalVariableReference): Bounce resolve.
862 2009-07-10 Marek Safar <marek.safar@gmail.com>
864 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
865 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
868 * support.cs: New dynamic type wrapper.
870 2009-07-08 Marek Safar <marek.safar@gmail.com>
872 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
873 typed local variable.
875 2009-07-06 Marek Safar <marek.safar@gmail.com>
877 A fix for bug #519005
878 * anonymous.cs: Use null_type as no return type placeholder.
880 2009-07-02 Marek Safar <marek.safar@gmail.com>
882 * generic.cs: Handle type inference of identical type parameters
883 with different bounds.
885 2009-07-01 Marek Safar <marek.safar@gmail.com>
887 * expression.cs, class.cs: Events variance.
889 * cs-parser.jay: Interface events error messages.
891 2009-07-01 Marek Safar <marek.safar@gmail.com>
893 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
895 2009-06-29 Marek Safar <marek.safar@gmail.com>
897 * parameter.cs, convert.cs, expression.cs, class.cs: Default
898 parameter expression can be value-type New.
900 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
902 2009-06-26 Marek Safar <marek.safar@gmail.com>
904 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
905 Implemented C# 4.0 named arguments.
907 2009-06-24 Marek Safar <marek.safar@gmail.com>
909 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
910 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
911 parameter modifier. Also fixes bug #515497.
913 2009-06-24 Marek Safar <marek.safar@gmail.com>
915 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
916 arguments expression to be implemented.
918 *.sources: Add argument.cs
920 2009-06-23 Marek Safar <marek.safar@gmail.com>
922 * parameter.cs: Moved GetParameterIndexByName to base class.
924 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
925 unused AType. Use argument's version of GetExpressionTree.
927 2009-06-22 Marek Safar <marek.safar@gmail.com>
929 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
932 2009-06-17 Marek Safar <marek.safar@gmail.com>
934 A fix for bug #514096
935 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
937 2009-06-17 Marek Safar <marek.safar@gmail.com>
939 * expression.cs: The first multi-dimensional array nested array
940 initializers was not checked.
942 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
944 2009-06-17 Marek Safar <marek.safar@gmail.com>
946 A fix for bug #513400
947 * nullable.cs (EmitEquality): Operands emit could be simplified for
948 built-in types when we now emit user operators differently.
950 2009-06-16 Marek Safar <marek.safar@gmail.com>
952 * ecore.cs: Report inaccessible delegate methods correctly.
954 2009-06-16 Marek Safar <marek.safar@gmail.com>
956 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
957 cs-parser.jay: Implemented C# 4.0 optional parameters.
959 2009-06-16 Marek Safar <marek.safar@gmail.com>
961 * driver.cs: Removed broken DefineManifestResource.
963 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
965 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
966 Use $(BOOTSTRAP_PROFILE) instead.
968 2009-06-12 Jb Evain <jbevain@novell.com>
970 * rootcontext.cs: add a Platform field.
971 * driver.cs: handle /platform.
972 * codegen.cs: pass the proper flags according to
973 the platform when saving the assembly.
975 2009-06-11 Marek Safar <marek.safar@gmail.com>
977 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
978 Add optional parameters grammar.
980 2009-06-10 Marek Safar <marek.safar@gmail.com>
982 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
983 driver.cs: Split lang version and metadata version.
985 2009-06-10 Marek Safar <marek.safar@gmail.com>
987 * decl.cs: Better overload ctor collision error message.
989 2009-06-05 Jb Evain <jbevain@novell.com>
991 * driver.cs (EmbededResource): avoid using an internal method
992 in gmcs to embed manifest resources.
994 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
996 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
997 the compiler from older mono versions (like moon's bots)
999 2009-06-04 Marek Safar <marek.safar@gmail.com>
1001 * namespace.cs (LookupTypeReflection): Ignore collisions between
1004 2009-06-04 Marek Safar <marek.safar@gmail.com>
1006 * codegen.cs: Enabled generic type forwarders.
1008 2009-06-04 Marek Safar <marek.safar@gmail.com>
1010 * dmcs.*: Add another version of SRE compiler.
1012 2009-06-03 Marek Safar <marek.safar@gmail.com>
1014 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1015 generic-mcs.cs: Fixed variant type conversions.
1017 2009-06-02 Marek Safar <marek.safar@gmail.com>
1019 A fix for bug #507863
1020 * codegen.cs: Fixes a crash on invalid string value attribute.
1022 2009-06-01 Marek Safar <marek.safar@gmail.com>
1024 A fix for bug #508334
1025 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1026 cs-parser.jay: Fully import __arglist modifier.
1028 2009-05-29 Marek Safar <marek.safar@gmail.com>
1030 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1031 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1032 actually work with closed generic types.
1034 2009-05-27 Alan McGovern <amcgovern@novell.com>
1036 * class.cs, decl.cs, delegate.cs, parameter.cs:
1037 Fix the build by replacing the use of 'var' with the actual type.
1039 2009-05-27 Marek Safar <marek.safar@gmail.com>
1041 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1042 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1045 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1048 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1049 Marek Safar <marek.safar@gmail.com>
1051 A fix for bug #377509
1052 * parameter.cs: Use predefined and not empty name for implicit
1055 2009-05-21 Marek Safar <marek.safar@gmail.com>
1057 * class.cs: Don't report wrong warnings for event fields.
1059 2009-05-21 Marek Safar <marek.safar@gmail.com>
1061 A fix for bug #504667
1062 * class.cs: Check for static class using parent container instead of
1065 2009-05-08 Marek Safar <marek.safar@gmail.com>
1067 A fix for bug #496922
1068 * expression.cs: Always use temporary variable when using object
1071 2009-04-28 Marek Safar <marek.safar@gmail.com>
1073 A fix for bug #495112
1074 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1077 2009-04-27 Miguel de Icaza <miguel@novell.com>
1079 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1081 2009-04-24 Miguel de Icaza <miguel@novell.com>
1083 * complete.cs: No idea how gonzalo got a null in the list, but
1086 2009-04-24 Miguel de Icaza <miguel@novell.com>
1088 * complete.cs (CompletionElementInitializer): New completion class
1089 to support completing inside a C# 3 element initializer, so this
1090 allows completion for Silverlight situations where it is very
1093 new TextBlock () { Fo<TAB>
1095 (CompletionSimpleName): Expose the prefix that was
1096 passed to the simple name.
1098 * cs-parser.jay (object_or_collection_initializer): Add support
1099 for element_initializers.
1101 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1102 special case completion expressions as this method aggressively
1103 collects data before it operates, and errors were being thrown
1104 earlier than we were able to complete.
1106 2009-04-23 Miguel de Icaza <miguel@novell.com>
1108 * eval.cs: Make getcompletions silent and enable debugging output
1109 if the -v option is passed.
1111 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1112 Consider looking up the namespace that matches the prefix being
1115 This is part of the support for allowing completions like:
1116 `System.Co<TAB>' to complete to System.Console.
1118 * complete.cs (CompletionSimpleName.AppendResults): Make this
1121 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1123 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1124 COMPLETE_COMPLETION as internal.
1126 2009-04-17 Miguel de Icaza <miguel@novell.com>
1128 * complete.cs: Include namespace resolution in simple names as
1129 well as global types and types in the using scope in the
1132 * namespace.cs: Supporting infrastrcture to provide completions
1133 based on the current using scope.
1135 * eval.cs: Introduce an entry point that allows for initialization
1136 to return a list of the files passed on the command line.
1138 2009-04-14 Marek Safar <marek.safar@gmail.com>
1140 A fix for bug #494243
1141 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1143 2009-04-13 Marek Safar <marek.safar@gmail.com>
1145 A fix for bug #493887
1146 * statement.cs: Don't skip string multi-section with default or
1147 null label when populating string hashtable.
1149 2009-04-06 Marek Safar <marek.safar@gmail.com>
1151 A fix for bug #492329
1152 * expression.cs (New): Load variable when assigning type parameter
1155 2009-04-06 Marek Safar <marek.safar@gmail.com>
1157 A fix for bug #488960
1158 * decl.cs: Compare MVAR types using non-null values.
1160 2009-03-27 Marek Safar <marek.safar@gmail.com>
1162 * typemanager.cs, expression.cs: Removed unused nullable checks.
1164 2009-03-27 Marek Safar <marek.safar@gmail.com>
1166 * *.cs: Removed some gmcs conditionals.
1168 2009-03-26 Marek Safar <marek.safar@gmail.com>
1170 * generic.cs, support.cs: Moved generics stuff out of support.cs
1172 2009-03-24 Marek Safar <marek.safar@gmail.com>
1174 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1177 2009-03-23 Marek Safar <marek.safar@gmail.com>
1179 * attribute.cs: Consider all members for error reporting when
1180 checking named arguments.
1182 2009-03-23 Marek Safar <marek.safar@gmail.com>
1184 A fix for bug #487625
1185 * namespace.cs: Use a warning for all predefined type conflicts.
1187 2009-03-23 Marek Safar <marek.safar@gmail.com>
1189 A fix for bug #485706
1190 * statement.cs: Explicitly type catch type argument to pass verifier
1193 2009-03-22 Miguel de Icaza <miguel@novell.com>
1195 Initial support to provide code completion facilities to consumers
1196 of the evaluator API.
1198 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1199 support the completion engine. When we reach the end of the
1200 input stream instead of returning EOF, when this flag is true the
1201 tokenizer instead produces:
1203 One GENERATE_COMPLETION token: this token then must be
1204 handled in the grammar at every point where the user
1205 would likely request a completion.
1207 As many COMPLETE_COMPLETION tokens as necessary. These
1208 tokens are generated to assist the parser in unwinding and
1209 producing a valid parse tree.
1211 The parser rules do not have to be perfect, the parser needs to be
1212 augmented with judicious use of GENERATE_COMPLETION tokens to
1213 improve the areas where we can provide completion and the parser
1214 needs to add support for COMPLETE_COMPLETION tokens in productions
1217 It is common to not have enough support for COMPLETE_COMPLETION
1218 under certain rules and that even if we generated the
1219 GENERATE_COMPLETION token that the resulting tree will be invalid
1220 due to the missing rules that support COMPLETE_COMPLETION.
1222 The final EOF token is produced by having the parser notify the
1223 tokenizer when it reaches the root production that the next token
1226 * support.cs (CompletionResult): New Exception. This exception
1227 is thrown to return the completion results when one of the special
1228 completion expressions is reached.
1230 This exception is thrown by the completing ExpressionStatements
1231 classes that live in complete.cs
1233 * complete.cs (CompletingExpression): a new base class for
1234 completing expressions. This derives from the
1235 ExpressionStatement class and not from Expression as it allows
1236 completion to happen not only where expressions are expected in
1237 the grammar, but also where statements are expected.
1239 (CompletionSimpleName): A new class used to provide completions
1240 for SimpleNames. This currently only resolves to local
1241 variables from the evaluator context (GetVars call).
1243 (CompletionMemberAccess): Implements support for completing member
1246 * cs-parser.jay: Add support for completion in a few places.
1248 * eval.cs (GetCompletions): New public API for the evaluator that
1249 returns a list of possible completions given the input. The
1250 return value is an array of completions
1252 * anonymous.cs (Compatible): If the exception thrown from the
1253 resolved expression is a CompletionResult exception let that one
1254 through instead of printing a diagnostic error in the try/catch.
1256 2009-03-22 Miguel de Icaza <miguel@novell.com>
1260 * driver.cs (Main): Use Environment.Exit to quit quickly and
1261 prevent the compiler from doing the usual wait for helper thread
1264 This is to prevent a slowdown that was reported by Gonzalo on
1267 2009-03-19 Marek Safar <marek.safar@gmail.com>
1269 * ecore.cs: Load build-in types directly instead of accessing
1272 2009-03-18 Marek Safar <marek.safar@gmail.com>
1274 * ecore.cs: Always use unbox.any when available.
1276 2009-03-18 Marek Safar <marek.safar@gmail.com>
1278 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1280 2009-03-17 Marek Safar <marek.safar@gmail.com>
1282 * generic.cs: Removed obsolete version of type inference.
1284 2009-03-16 Marek Safar <marek.safar@gmail.com>
1286 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1287 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1288 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1289 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1291 2009-03-11 Marek Safar <marek.safar@gmail.com>
1293 A fix for bug #482996
1294 * anonymous.cs: Make sure we are not infering return type when
1295 checking type compatibility.
1297 2009-03-11 Marek Safar <marek.safar@gmail.com>
1299 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1300 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1301 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1302 attributes in their own structure. Needed when accessing their
1303 properties before they are resolved.
1305 2009-03-09 Marek Safar <marek.safar@gmail.com>
1307 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1308 hashtable (~10x faster).
1310 * driver.cs: Removed wrong Reset.
1312 2009-03-08 Marek Safar <marek.safar@gmail.com>
1314 * class.cs: Use correct common base type for unmanaged delayed
1317 * rootcontext.cs: Wrap unhandled exception.
1319 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1321 Make SeekableStreamReader self-tuning and arbitrarily seekable
1322 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1324 (SeekableStreamReader.Position.set): Use it. Simplify logic
1325 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1326 buffer size when the stream needs to be re-read from the beginning.
1328 2009-03-05 Marek Safar <marek.safar@gmail.com>
1330 A fix for bug #480100
1331 * parameter.cs: A parameter is not hoisted when used directly as ET.
1333 2009-03-04 Marek Safar <marek.safar@gmail.com>
1335 * statement.cs: Fixed an issue when using variable is of interface
1338 2009-03-03 Marek Safar <marek.safar@gmail.com>
1340 A fix for bug #480319
1341 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1343 2009-03-03 Marek Safar <marek.safar@gmail.com>
1345 A fix for bug #480867
1346 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1347 expression to have no valid type.
1349 2009-03-03 Marek Safar <marek.safar@gmail.com>
1351 A fix for bug #481258
1352 * class.cs: Set extension method flag in partial container.
1354 2009-03-03 Marek Safar <marek.safar@gmail.com>
1356 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1358 * attribute.cs: Add sanity check.
1360 2009-02-27 Marek Safar <marek.safar@gmail.com>
1362 * class.cs: Add external constructor error.
1364 2009-02-26 Marek Safar <marek.safar@gmail.com>
1366 A fix for bug #475354
1367 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1368 correctly user defined nullable equality operators.
1370 2009-02-25 Marek Safar <marek.safar@gmail.com>
1372 A fix for bug #479532
1373 * expression.cs: Implement NewInitialize::AddressOf.
1375 2009-02-25 Marek Safar <marek.safar@gmail.com>
1377 A fix for bug #413633
1378 * expression.cs: Iterate all base class-constraint types.
1380 2009-02-24 Marek Safar <marek.safar@gmail.com>
1382 A fix for bug #479209
1383 * literal.cs: Mutate null underlying type.
1385 2009-02-24 Marek Safar <marek.safar@gmail.com>
1387 A fix for bug #476295
1388 * convert.cs: Avoid wrapping implicitly convertible reference type.
1390 2009-02-23 Marek Safar <marek.safar@gmail.com>
1392 * iterators.cs: Create MemberName correctly.
1394 2009-02-23 Marek Safar <marek.safar@gmail.com>
1396 A fix for bug #478655
1397 * literal.cs: Check also underlying null type conversion.
1399 2009-02-21 Marek Safar <marek.safar@gmail.com>
1401 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1403 2009-02-20 Marek Safar <marek.safar@gmail.com>
1405 A fix for bug #477447
1406 * statement.cs: Add reference to correct parent storey when this
1407 is accessible from deep children storey (more than 1 level).
1409 2009-02-19 Marek Safar <marek.safar@gmail.com>
1411 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1412 * class.cs: Define base type members before setting up member cache.
1414 2009-02-18 Marek Safar <marek.safar@gmail.com>
1416 A fix for bug #477378
1417 * nullable.cs, expression.cs, statement.cs: More precise null type
1420 2009-02-18 Marek Safar <marek.safar@gmail.com>
1422 A fix for bug #472805
1423 * typemanager.cs, namespace.cs: Import only visible extension method
1426 2009-02-18 Marek Safar <marek.safar@gmail.com>
1428 A fix for bug #476895
1429 * attribute.cs: Use correct resolve context for attribute type.
1431 2009-02-18 Marek Safar <marek.safar@gmail.com>
1433 A fix for bug #476266
1434 * anonymous.cs: Mutate multi-dimensional arrays.
1436 2009-02-18 Marek Safar <marek.safar@gmail.com>
1438 A fix for bug #476400
1439 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1441 2009-02-18 Marek Safar <marek.safar@gmail.com>
1443 A fix for bug #476811
1444 * generics.cs: Fixed null-literal check.
1446 2009-02-17 Marek Safar <marek.safar@gmail.com>
1448 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1449 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1450 messing with static variables.
1452 2009-02-16 Marek Safar <marek.safar@gmail.com>
1454 A fix for bug #475965
1455 * generics.cs: Check generic parameter type after extracting from
1458 2009-02-16 Marek Safar <marek.safar@gmail.com>
1460 A fix for bug #475823
1461 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1464 2009-02-14 Marek Safar <marek.safar@gmail.com>
1466 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1467 Simplified event field definition using backing field and not
1468 field builder directly.
1470 * expression.cs (EmitLdArg): Optimize fast paths.
1472 2009-02-13 Marek Safar <marek.safar@gmail.com>
1474 A fix for bug #475327
1475 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1477 2009-02-13 Marek Safar <marek.safar@gmail.com>
1479 A fix for bug #475342
1480 * cs-parser.jay: Using 'super' instead of 'base' to call base
1481 constructor crashes compiler.
1483 2009-02-13 Marek Safar <marek.safar@gmail.com>
1485 A fix for bug #475354
1486 * expression.cs (Constantify): Add nullable types.
1488 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1490 2009-02-12 Marek Safar <marek.safar@gmail.com>
1492 A fix for bug #475246
1493 * expression.cs: More broken flowanalysis hacking needed.
1495 2009-02-12 Marek Safar <marek.safar@gmail.com>
1497 * attribute.cs: Compare only ref/out array modifiers.
1499 2009-02-11 Marek Safar <marek.safar@gmail.com>
1501 * statement.cs: Use member cache when looking for foreach members.
1503 2009-02-11 Marek Safar <marek.safar@gmail.com>
1505 * expression.cs: Don't expose internal initializer types.
1507 * statement.cs: Check also explicit conversions for goto case.
1509 2009-02-11 Marek Safar <marek.safar@gmail.com>
1511 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1513 2009-02-10 Marek Safar <marek.safar@gmail.com>
1515 * *.cs: Replace null-type with NullLiteral where appropriate.
1517 2009-02-09 Marek Safar <marek.safar@gmail.com>
1519 * expression.cs: Initializer of reference argument use temporary
1520 variable to be verifiable.
1522 * parameter.cs: Share EmitLdArg.
1524 2009-02-09 Marek Safar <marek.safar@gmail.com>
1526 A fix for bug #473559
1527 * class.cs: Fixed: Not reporting error about nested class with the
1530 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1532 Contributed under the MIT/X11 license.
1534 * generic.cs: Added VerifyVariantTypeParameters which performs new
1535 variance verification logic. The old logic, based on the spec, was
1536 wrong because the spec is full of LIES!
1538 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1540 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1543 * ecore.cs: Added calls to the new variance verification logic.
1546 * delegate.cs: Removed calls to the old variance verification logic.
1548 2009-02-06 Marek Safar <marek.safar@gmail.com>
1550 * delegate.cs: Use cached Invoke method directly.
1552 2009-02-06 Marek Safar <marek.safar@gmail.com>
1554 * expression.cs: Emit expression tree for hoisted variable access.
1556 2009-02-04 Marek Safar <marek.safar@gmail.com>
1558 * namespace.cs: Add better extension class check.
1560 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
1562 * generic.cs: Fixed typeo (TypeParameter.Variacne).
1564 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
1566 This patch adds initial generic variance support to the compiler.
1567 It is contributed under the MIT/X11 license.
1569 * typemanager.cs: Modified ImplementsInterface to check variance.
1570 Added VerifyVariantTypeParameters which checks the specified type to see
1571 if it uses a variant type parameter as a type argument (which is not
1572 allowed). Added IsVariantOf which determins if the first type is a
1573 variant of the second. NOTE: This only supports reference types at
1574 the moment to conform with the current level of VM support. When the
1575 VM supports value types, this will follow step.
1577 * generic.cs: Added the Variance enum. Added a Variance property to
1578 TypeParameter and added variance support to definition phase. Added a
1579 Variance property to TypeParameterName. Also check to make sure that
1580 no variant types appear in generic method parameters.
1582 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
1583 keywords if the langversion supports it.
1585 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
1586 that variant types are only used in legal positions. Also added
1587 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
1590 * decl.cs: Construct TypeParameter with the variance information.
1592 * convert.cs: Checks variance in ImplicitReferenceConversionExists
1593 and ImplicitConversionStandard.
1595 * rootcontext.cs: Added new "Future" language version.
1597 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
1598 type parameters are not used as type arguments in interface inheritance.
1599 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
1600 parameters are not used as method return types. In MemberBase.
1601 ResolveMemberType, ensure that variant type parameters are not used
1602 as type arguments. Also call VerifyNoVariantTypeParameters on every
1603 set of parameters which are resolved.
1605 * delegate.cs: Modified Delegate.Define to ensure that variant
1606 parameters are not used as type arguments and that a contravariant
1607 parameter is not used as the return type. Also call
1608 VerifyNoVariantTypeParameters on the delegate parameters.
1610 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
1611 to specify generic variance.
1613 * driver.cs: Added support for LanguageVersion.Future in the form of
1614 "-langversion:future".
1616 * generic-mcs.cs: Stubbed out new members in generic.cs.
1618 2009-02-03 Marek Safar <marek.safar@gmail.com>
1620 * class.cs, generic.cs: Emit type parameter constraints for nested
1623 2009-02-02 Marek Safar <marek.safar@gmail.com>
1625 A fix for bug #471213
1626 * class.cs: Avoid emitting backing field for abstract event fields.
1628 2009-02-01 Marek Safar <marek.safar@gmail.com>
1630 A fix for bug #359731
1631 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
1634 2009-01-30 Marek Safar <marek.safar@gmail.com>
1636 A fix for bug #470767
1637 * statement.cs: Introduced BlockScopeExpression, needed when
1638 expression tree conversion has to emit scope variables.
1640 2009-01-29 Marek Safar <marek.safar@gmail.com>
1642 * class.cs: Remove duplicate CallingConvention.
1644 2009-01-29 Marek Safar <marek.safar@gmail.com>
1646 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
1647 when I finally found the right naming convention.
1649 2009-01-29 Marek Safar <marek.safar@gmail.com>
1651 * cs-tokenizer.cs: Put back different open parens optimization.
1653 2009-01-28 Marek Safar <marek.safar@gmail.com>
1655 A fix for bug #470227
1656 * cs-tokenizer.cs: Remove too agressive parser optimization.
1658 2009-01-28 Marek Safar <marek.safar@gmail.com>
1660 A fix for bug #324319
1661 * class.cs: Remove too early base type resolve.
1663 2009-01-27 Marek Safar <marek.safar@gmail.com>
1665 A fix for bug #324319
1666 * ecore.cs: Explicitly type null when assigning to type argument to
1667 make pass verifier check.
1669 2009-01-27 Marek Safar <marek.safar@gmail.com>
1671 * anonymous.cs: Fixed recent regression when initializing captured
1674 2009-01-26 Marek Safar <marek.safar@gmail.com>
1676 A fix for bug #469019
1677 * anonymous.cs: Use all parent type parameters when instantiating
1678 nested generic storey.
1680 2009-01-26 Marek Safar <marek.safar@gmail.com>
1682 * expression.cs: Check for null instance methodgroup expression.
1684 2009-01-26 Marek Safar <marek.safar@gmail.com>
1686 A fix for bug #469244
1687 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
1688 instance inside a conditional expression.
1690 2009-01-23 Marek Safar <marek.safar@gmail.com>
1692 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
1693 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
1694 GetElementType and HasElementType. IsValueType clean up.
1696 2009-01-23 Marek Safar <marek.safar@gmail.com>
1698 * nullable.cs: Use common EmitCall.
1700 * expression.cs: Emit constraint. for virtual calls only.
1702 2009-01-23 Marek Safar <marek.safar@gmail.com>
1704 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
1705 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
1706 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
1709 2009-01-22 Jb Evain <jbevain@novell.com>
1711 * anonymous.cs: make anonymous types' ToString implementation
1712 match what csc outputs.
1714 2009-01-21 Marek Safar <marek.safar@gmail.com>
1716 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
1719 2009-01-17 Marek Safar <marek.safar@gmail.com>
1721 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
1724 2009-01-16 Marek Safar <marek.safar@gmail.com>
1726 * nullable.cs (LiftedBinaryOperator): Check for all possible null
1729 2009-01-15 Marek Safar <marek.safar@gmail.com>
1731 A fix for bug #466634
1732 * statement.cs: Add reference for nested storey when only this
1735 2009-01-15 Marek Safar <marek.safar@gmail.com>
1737 A fix for bug #466474
1738 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
1741 2009-01-15 Marek Safar <marek.safar@gmail.com>
1743 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
1744 Fixed nested stories parent referencing process. Also fixes #463985.
1746 2009-01-06 Marek Safar <marek.safar@gmail.com>
1748 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
1749 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
1750 implementation. Also fixes #463108.
1752 2009-01-05 Marek Safar <marek.safar@gmail.com>
1754 A fix for bug #416109
1755 * decl.cs: Issue correct CLSAttribute warning location.
1757 2009-01-05 Marek Safar <marek.safar@gmail.com>
1759 A fix for bug #456775
1760 * attribute.cs: Use attribute owner scope when resolving attribute
1763 2009-01-05 Marek Safar <marek.safar@gmail.com>
1765 A fix for bug #457257
1766 * decl.cs: Fixed incorrect member declaring type comparison.
1768 2009-01-05 Marek Safar <marek.safar@gmail.com>
1770 A fix for bug #460896
1771 * driver.cs: Handle /RES resources as embeddable.
1773 2009-01-05 Marek Safar <marek.safar@gmail.com>
1775 A fix for bug #462515
1776 * ecore.cs: Report inacessible members upwards.
1778 2009-01-05 Marek Safar <marek.safar@gmail.com>
1780 A fix for bug #463190, #463192
1781 * decl.cs, namespace.cs: Also import internal extension classes.
1783 2009-01-04 Marek Safar <marek.safar@gmail.com>
1785 A fix for bug #463415
1786 * generic.cs: Use right index for RemoveDependentTypes.
1788 2009-01-02 Marek Safar <marek.safar@gmail.com>
1790 A fix for bug #463196
1791 * expression.cs: Fixed enum to null comparison.
1793 2009-01-02 Marek Safar <marek.safar@gmail.com>
1795 A fix for bug #463121
1796 * nullable.cs: Fixed nullable user equality operator comparison.
1798 2009-01-02 Marek Safar <marek.safar@gmail.com>
1800 A fix for bug #462950
1801 * class.cs, decl.cs: Use full explicit name when defining automatic
1802 property backing field.
1804 2009-01-02 Marek Safar <marek.safar@gmail.com>
1806 A fix for bug #462592
1807 * pending.cs: Emit type arguments for generic proxy method.
1809 2008-12-30 Marek Safar <marek.safar@gmail.com>
1811 * expression.cs (As): Mutate all type arguments.
1813 2008-12-29 Marek Safar <marek.safar@gmail.com>
1815 A fix for bug #462622
1816 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
1819 2008-12-29 Marek Safar <marek.safar@gmail.com>
1821 A fix for bug #450782
1822 * ecore.cs: Consider more variables of form V.I to be fixed.
1824 2008-12-29 Marek Safar <marek.safar@gmail.com>
1826 A fix for bug #460712
1827 * typemanager.cs: Core types could be imported.
1829 2008-12-28 Marek Safar <marek.safar@gmail.com>
1831 A fix for bugs #460847, #460772, #458049, #457339, #447807
1832 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
1833 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
1834 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
1835 user lambdas used inside query clauses.
1837 2008-12-18 Marek Safar <marek.safar@gmail.com>
1839 A fix for bug #460229
1840 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
1842 2008-12-18 Marek Safar <marek.safar@gmail.com>
1844 A fix for bug #459952
1845 * decl.cs, namespace.cs: Use common CheckAccessLevel.
1847 2008-12-18 Marek Safar <marek.safar@gmail.com>
1849 A fix for bug #459630
1850 * convert.cs: Enum to valuetype conversion is not allowed.
1852 2008-12-18 Marek Safar <marek.safar@gmail.com>
1854 A fix for bug #457087
1855 * generic.cs: Don't crash when constraint comes from type
1858 2008-12-16 Marek Safar <marek.safar@gmail.com>
1860 A fix for bug #459221
1861 * anonymous.cs, statement.cs: Delay only captured this
1864 2008-12-12 Marek Safar <marek.safar@gmail.com>
1866 A fix for bug #457489
1867 * anonymous.cs, statement.cs: Split anonymous storey instantiation
1868 and initialization to capture scope initializers correctly.
1870 2008-12-11 Marek Safar <marek.safar@gmail.com>
1872 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
1873 ParameterReference refactoring.
1875 2008-12-03 Marek Safar <marek.safar@gmail.com>
1877 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
1878 to be imported from any assembly.
1880 2008-12-03 Marek Safar <marek.safar@gmail.com>
1882 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
1883 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
1884 from anonymous method and lambda expression.
1886 2008-12-01 Marek Safar <marek.safar@gmail.com>
1888 A fix for bug #448560
1889 * expression.cs (As): Box any generic type arguments to be
1892 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1894 Add tripwire for implicit conversion bugs
1895 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
1897 (MethodGroupExpr.OverloadResolve): Add sanity check between
1898 IsApplicable and VerifyArgumentsCompat.
1899 (VerifyArgumentsCompat): Report CS1501 where appropriate.
1901 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1903 Fix build break in System.Data_test
1904 * convert.cs (ImplicitConversionExists): Move NullLiteral
1906 (ImplicitStandardConversionExists): ... here.
1908 2008-11-28 Marek Safar <marek.safar@gmail.com>
1910 * literal.cs: Emit correctly explicit null to nullable cast.
1912 2008-11-28 Marek Safar <marek.safar@gmail.com>
1914 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
1917 2008-11-28 Marek Safar <marek.safar@gmail.com>
1919 A fix for bug #449005
1920 * convert.cs, nullable.cs: Use only one implicit nullable
1923 2008-11-27 Marek Safar <marek.safar@gmail.com>
1925 * convert.cs, literal.cs: More Convert cleanup is needed.
1927 2008-11-27 Marek Safar <marek.safar@gmail.com>
1929 * decl.cs, class.cs: Fixed misleading error message.
1931 2008-11-26 Marek Safar <marek.safar@gmail.com>
1933 A fix for bug #449005
1934 * nullable.cs (EmitEquality): Disable optimization for user operator
1937 2008-11-25 Marek Safar <marek.safar@gmail.com>
1939 A fix for bug #447027
1940 * anonymous.cs (HoistedVariable): Cache also outer access to deal
1941 with context variables stored as expression instances.
1943 2008-11-25 Marek Safar <marek.safar@gmail.com>
1945 A fix for bug #447027
1946 * delegate.cs: Fixed delegate VerifyMethod logic.
1948 2008-11-24 Marek Safar <marek.safar@gmail.com>
1950 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
1953 2008-11-21 Marek Safar <marek.safar@gmail.com>
1955 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
1956 member type resolve to follow normal flow, instead of random
1959 2008-11-21 Marek Safar <marek.safar@gmail.com>
1961 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
1964 2008-11-21 Marek Safar <marek.safar@gmail.com>
1966 * const.cs: Emit decimal array constant as literal.
1968 2008-11-20 Marek Safar <marek.safar@gmail.com>
1970 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
1972 2008-11-19 Marek Safar <marek.safar@gmail.com>
1974 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
1975 into real property (saves 8 MB for corlib compilation).
1977 2008-11-19 Marek Safar <marek.safar@gmail.com>
1979 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
1980 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
1981 generic-mcs.cs: Small cleanup of TypeArguments.
1983 2008-11-18 Marek Safar <marek.safar@gmail.com>
1985 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
1986 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
1987 of ConstructedType expression, renamed to GenericTypeExpr.
1989 2008-11-17 Marek Safar <marek.safar@gmail.com>
1991 A fix for bug #445303
1992 * location.cs (IsConditionalDefined): Handle undefined global
1995 2008-11-17 Marek Safar <marek.safar@gmail.com>
1997 A fix for bug #444678
1998 * expression.cs (TryReduceConstant): Always create new constant
2001 2008-11-17 Marek Safar <marek.safar@gmail.com>
2003 A fix for bug #444673
2004 * ecore.cs: Ignore open generic types when used as generic type
2007 2008-11-17 Marek Safar <marek.safar@gmail.com>
2009 A fix for bug #445458
2010 * expression.cs, cs-parser.jay: Don't crash when an expression
2013 2008-11-17 Marek Safar <marek.safar@gmail.com>
2015 A fix for bug #445464
2016 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2017 inside unbound type.
2019 2008-11-14 Jb Evain <jbevain@novell.com>
2021 * driver.cs: ignore empty -nowarn argument such as
2022 the one in -nowarn:12,13,,.
2024 2008-11-13 Marek Safar <marek.safar@gmail.com>
2026 A fix for bug #444271
2027 * anonymous.cs: Rescan parent storeys when best candidate was
2030 2008-11-13 Marek Safar <marek.safar@gmail.com>
2032 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2033 useless UnboundTypeExpression.
2035 * attribute.cs: Do check obsolete attribute on generic types.
2037 2008-11-12 Marek Safar <marek.safar@gmail.com>
2039 A fix for bugs #425680, #400139
2040 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2043 2008-11-11 Marek Safar <marek.safar@gmail.com>
2045 A fix for bug #435747
2046 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2047 compound value types assignment. Few micro optimizations added.
2049 2008-11-10 Marek Safar <marek.safar@gmail.com>
2051 A fix for bug #442610
2052 * anonymous.cs (MutateConstructor): More SRE hacking.
2054 2008-11-10 Marek Safar <marek.safar@gmail.com>
2056 A fix for bug #442579
2057 * ecore.cs: Also initialize expanded form of a method with 1 params
2060 2008-11-06 Marek Safar <marek.safar@gmail.com>
2062 * expression.cs (UnaryMutator): Do early l-side check.
2064 2008-11-05 Miguel de Icaza <miguel@novell.com>
2066 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2067 Init, otherwise we would crash later on when checking for friend
2070 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2071 Otherwise we never get any meaningful information as to what
2074 2008-11-05 Marek Safar <marek.safar@gmail.com>
2076 A fix for bug #436318
2077 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2079 2008-11-05 Miguel de Icaza <miguel@novell.com>
2081 * namespace.cs: Turns out that it was a really bad idea to hide
2082 the errors for namespaces not found here in eval mode.
2084 * eval.cs: When we process using clauses, only enter those into
2085 the list of valid using clauses after they have been validated.
2087 The above change gives the proper semantics: it does not
2088 senselessly report the same errors with broken using statements by
2089 never storing them in the first place when they are invalid.
2091 2008-11-05 Marek Safar <marek.safar@gmail.com>
2093 A fix for bug #421839
2094 * cs-parser.jay: Remove expression from coalesce rule to force lower
2095 priority than the assignment operator.
2097 2008-11-05 Marek Safar <marek.safar@gmail.com>
2099 A fix for bug #437875
2100 * nullable.cs: Compile correctly method group operand used with null
2101 coalescing operator.
2103 2008-11-04 Marek Safar <marek.safar@gmail.com>
2105 A fix for bug #434589
2106 * expression.cs (Binary): Ignore lifted conversions when at least
2107 one operand is of reference type.
2109 2008-11-04 Marek Safar <marek.safar@gmail.com>
2111 * cs-parser.jay: Better syntax error report.
2113 2008-11-03 Marek Safar <marek.safar@gmail.com>
2115 A fix for bug #436792
2116 * cs-parser.jay: Use GetLocation to access location.
2118 2008-11-03 Marek Safar <marek.safar@gmail.com>
2120 A fix for bug #440774
2121 * cs-parser.jay: Also set current_array_type when parsing local
2124 2008-11-03 Marek Safar <marek.safar@gmail.com>
2126 A fix for bug #440785
2127 * expression.cs (As): Don't resolve self modifing expression
2130 2008-11-03 Marek Safar <marek.safar@gmail.com>
2132 A fix for bug #439447
2133 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2135 2008-11-03 Marek Safar <marek.safar@gmail.com>
2137 A fix for bug #437571
2138 * cs-parser.jay: Fixes internal error for invalid expression
2141 2008-10-17 Marek Safar <marek.safar@gmail.com>
2143 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2145 2008-10-17 Marek Safar <marek.safar@gmail.com>
2147 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2149 2008-10-17 Marek Safar <marek.safar@gmail.com>
2151 * cs-tokenizer.cs: More precise cast parsing.
2153 2008-10-16 Martin Baulig <martin@ximian.com>
2155 * anonymous.cs (AnonymousMethodStorey): Put back the
2156 `hoisted_locals' hashtable and use it in EmitType().
2158 2008-10-15 Marek Safar <marek.safar@gmail.com>
2160 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2161 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2164 2008-10-14 Marek Safar <marek.safar@gmail.com>
2166 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2168 2008-10-14 Marek Safar <marek.safar@gmail.com>
2170 * statement.cs: Mutate scope initializers.
2172 2008-10-14 Marek Safar <marek.safar@gmail.com>
2174 * expression.cs: Use typeless value for This constant.
2176 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2178 2008-10-14 Marek Safar <marek.safar@gmail.com>
2180 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2183 2008-10-13 Marek Safar <marek.safar@gmail.com>
2185 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2188 2008-10-13 Marek Safar <marek.safar@gmail.com>
2190 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2191 parser and tokenizer. Fixes many ambiguities including #433258.
2193 2008-10-10 Marek Safar <marek.safar@gmail.com>
2195 * cs-parser.jay: Fixed missing accessor recovery.
2197 2008-10-10 Marek Safar <marek.safar@gmail.com>
2199 A fix for bug #433701
2200 * expression.cs: Better error message.
2202 2008-10-10 Marek Safar <marek.safar@gmail.com>
2204 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2206 * Makefile: Disabled unused debug symbols.
2208 Also fixes: #320556, #321097, #321656, #321876, #351316
2210 2008-10-09 Miguel de Icaza <miguel@novell.com>
2212 * eval.cs: rename "<interactive>" to "{interactive}", to work
2213 around a requirement in the compiler that this be a valid
2214 filename, and in Windows it is not (433886).
2216 2008-10-09 Marek Safar <marek.safar@gmail.com>
2218 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2220 2008-10-08 Marek Safar <marek.safar@gmail.com>
2222 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2223 cs-parser.jay: Generic type declaration and type arguments cleanup.
2225 2008-10-05 Marek Safar <marek.safar@gmail.com>
2227 * cs-parser.jay: Allow parsing weird array creation construct.
2229 2008-10-05 Marek Safar <marek.safar@gmail.com>
2231 * cs-parser.jay: Conflicts reduction.
2233 2008-10-04 Marek Safar <marek.safar@gmail.com>
2235 * cs-parser.jay: Conflicts reduction.
2237 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2240 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2241 property. Add a 'count' hint about the use of the shared vector.
2242 Ensure that we don't leak out dirty bits.
2243 (UsageVector.MergeChild): Throw away information about variables
2245 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2247 2008-10-03 Marek Safar <marek.safar@gmail.com>
2249 A fix for bug #431746
2250 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2251 parameters when iterator is created.
2253 2008-10-03 Marek Safar <marek.safar@gmail.com>
2255 A fix for bug #431827
2256 * expression.cs: Fixed right based pointer arithmetic operations
2259 2008-10-03 Marek Safar <marek.safar@gmail.com>
2261 A fix for bug #353779
2262 * assign.cs, expression.cs: Fixed compound assignment conversions.
2264 2008-10-02 Marek Safar <marek.safar@gmail.com>
2266 A fix for bug #375262
2267 * statement.cs: Refactor ArrayForeach to be usable with string
2268 indexer. Optimized single dimentional arrays foreach.
2270 2008-10-02 Marek Safar <marek.safar@gmail.com>
2272 A fix for bug #431255
2273 * anonymous.cs, expression.cs: Removed broken optimization.
2275 2008-10-01 Marek Safar <marek.safar@gmail.com>
2277 * anonymous.cs: Use full type parameters of parent generic
2278 containers. Removed unnecessary AddParentStoreyReference call.
2280 2008-10-01 Marek Safar <marek.safar@gmail.com>
2282 A fix for bug #324702
2283 * class.cs: Use better shorter names for explicit interface member
2286 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2288 2008-10-01 Marek Safar <marek.safar@gmail.com>
2290 * expression.cs: Use new interface to check fixed expression.
2292 2008-10-01 Marek Safar <marek.safar@gmail.com>
2294 A fix for bug #421101
2295 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2296 interface to check for fixed fixed-buffers.
2298 2008-10-01 Marek Safar <marek.safar@gmail.com>
2300 A fix for bug #429264
2301 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2303 * delegate.cs: Removed unnecessary casts.
2305 2008-09-30 Marek Safar <marek.safar@gmail.com>
2307 A fix for bug #352151
2308 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2309 class.cs: Fixed already defined explicit interface members check.
2311 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2313 cs-tokenizer.cs: Fix typo.
2315 2008-09-28 Miguel de Icaza <miguel@novell.com>
2317 * eval.cs (InteractiveBase): The quit command now just sets a
2318 flag, instead of calling Environment.Exit(), it is milder on
2321 CompiledMethod is now in Mono.CSharp, not nested inside
2322 the Evaluator, it was inconvenient to use.
2324 2008-09-27 Miguel de Icaza <miguel@novell.com>
2326 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2327 code to be invoked without having to reparse.
2329 2008-09-27 Miguel de Icaza <miguel@novell.com>
2331 * ecore.cs: The recent changes to FieldExpr broke this as well.
2332 Fixes LINQ queries in the interactive shell.
2334 * Multiple files: indentation fixing for the Mono coding
2335 guidelines for the switch statement.
2337 * eval.cs: Make the Evaluator API thread safe.
2339 2008-09-26 Marek Safar <marek.safar@gmail.com>
2341 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2342 constructor parsing.
2344 2008-09-26 Marek Safar <marek.safar@gmail.com>
2346 A fix for bug #325326
2347 * statement.cs: Check possible mistaken empty statement using
2348 explicit blocks only.
2350 2008-09-25 Miguel de Icaza <miguel@novell.com>
2352 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2353 RootNamespace.ComputeNamespaces to update the internal list of
2354 namespaces, this is no longer done for us.
2356 (InteractiveBase): Use the Evaluator APIs instead of calling into
2359 2008-09-25 Marek Safar <marek.safar@gmail.com>
2361 A fix for bug #429264
2362 * expression.cs: Missing mutator for access to multidimensional
2365 2008-09-25 Marek Safar <marek.safar@gmail.com>
2367 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2370 * driver.cs: Missing input argument check.
2372 2008-09-25 Marek Safar <marek.safar@gmail.com>
2374 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2375 expression.cs, statement.cs, rootcontext.cs, class.cs,
2376 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2379 2008-09-24 Miguel de Icaza <miguel@novell.com>
2381 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2382 fully constructed FieldExpr, fixes the regression introduced in
2385 * ecore.cs, expression.cs: Plug back the eclass initialization as
2386 otherwise it regresses `csharp'.
2388 2008-09-24 Marek Safar <marek.safar@gmail.com>
2390 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2391 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2392 phase to resolve phase. It resolves problems with expression trees
2393 and fixes bugs #323796, #325156.
2395 2008-09-23 Marek Safar <marek.safar@gmail.com>
2397 * codegen.cs: Report better error when symbol writer is missing.
2399 2008-09-23 Marek Safar <marek.safar@gmail.com>
2401 * codegen.cs: Set .NET symbol writer.
2403 * decl.cs: Guard against null generic arguments.
2405 * report.cs: Don't report exactly same additional details.
2407 2008-09-22 Marek Safar <marek.safar@gmail.com>
2409 A fix for bug #324917
2410 * cs-parser.jay: Add missing multidimensional non-expression type
2413 2008-09-22 Marek Safar <marek.safar@gmail.com>
2415 A fix for bug #428191
2416 * anonymous.cs: Create an outer generic fields also for non-storey
2419 2008-09-22 Marek Safar <marek.safar@gmail.com>
2421 A fix for bug #378294
2422 * class.cs: Make fixed size buffers gmcs feature only.
2424 2008-09-22 Marek Safar <marek.safar@gmail.com>
2426 A fix for bug #355622, #324993
2427 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2430 2008-09-19 Marek Safar <marek.safar@gmail.com>
2432 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2435 2008-09-19 Marek Safar <marek.safar@gmail.com>
2437 A fix for bug #416110
2438 * generic.cs: Struct constraint results in default ctor and
2439 ValueType base type constraint to be set.
2441 2008-09-19 Marek Safar <marek.safar@gmail.com>
2443 A fix for bug #423791
2444 * generic.cs: Fixed params output type type-inference.
2446 2008-09-19 Marek Safar <marek.safar@gmail.com>
2448 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2450 2008-09-19 Marek Safar <marek.safar@gmail.com>
2452 * cs-tokenizer.cs: Don't break on extra partial modifier.
2454 2008-09-19 Marek Safar <marek.safar@gmail.com>
2456 A fix for bug #427592
2457 * generic.cs: Use common parameter resolve method.
2459 2008-09-18 Marek Safar <marek.safar@gmail.com>
2461 A fix for bug #414758
2462 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2465 2008-09-18 Marek Safar <marek.safar@gmail.com>
2467 * driver.cs, namespace.cs: Read types and namespaces after all
2468 requested assemblies are loaded, fixes issues with System.Core
2469 auto-reference, and #419888.
2471 2008-09-18 Marek Safar <marek.safar@gmail.com>
2473 A fix for bug #417705
2474 * cs-parser.jay: Fixed as/is operator expression split.
2476 2008-09-18 Marek Safar <marek.safar@gmail.com>
2478 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2479 Fixed expression tree representation of empty new expression and
2480 new initializer expression.
2482 2008-09-18 Miguel de Icaza <miguel@novell.com>
2484 * eval.cs: Remove warning, keep reference to driver around.
2486 * Hide fields that do not need to be public.
2488 2008-09-17 Marek Safar <marek.safar@gmail.com>
2490 A fix for bug #426385
2491 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2492 conversion for array elements.
2494 2008-09-17 Marek Safar <marek.safar@gmail.com>
2496 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2497 void parsing conflicts.
2499 2008-09-15 Marek Safar <marek.safar@gmail.com>
2501 A fix for bug #425601
2502 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2503 System.Core only when there is no custom ExtensionAttribute
2506 2008-09-15 Miguel de Icaza <miguel@novell.com>
2508 * namespace.cs: Do not report CS0246 (name
2510 2008-09-12 Marek Safar <marek.safar@gmail.com>
2512 A fix for bug #425669
2513 * generic.cs: Don't cache generic static anonymous method
2516 2008-09-12 Marek Safar <marek.safar@gmail.com>
2518 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2519 conflicting constraints.
2521 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2523 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2526 2008-09-12 Marek Safar <marek.safar@gmail.com>
2528 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2529 to null pointer conversion fixes.
2531 2008-09-11 Marek Safar <marek.safar@gmail.com>
2533 * cs-parser.jay, expression.cs: An implicitly typed local variable
2534 declarator cannot use an array initializer.
2536 2008-09-11 Marek Safar <marek.safar@gmail.com>
2538 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2540 2008-09-11 Marek Safar <marek.safar@gmail.com>
2542 * generic.cs (InflatedConstraints): Don't crash when constraints
2545 * cs-parser.jay: const_declarator is a block.
2547 * constant.cs: Check for not allowed NaN conversions.
2549 2008-09-10 Miguel de Icaza <miguel@novell.com>
2551 * driver.cs: Drop --shell argument, the compiler is no longer a
2554 * eval.cs: Move most of the code that deals with evaluation into
2555 this file and document the public API from repl.cs
2557 * repl.cs: Remove from here.
2559 2008-09-10 Marek Safar <marek.safar@gmail.com>
2561 A fix for bug #424684
2562 * generic.cs: Generic class constraints must come first.
2564 2008-09-09 Miguel de Icaza <miguel@novell.com>
2566 * cs-parser.jay: Improve error reporting for syntax errors in
2567 statements and expressions, we now report the expected tokens
2568 instead of reporting the useless "; expected".
2570 Drop the strings from the token declaration, it turns out that
2571 they did not do what I thought they did. Instead they were adding
2572 two sets of tokens to the tables.
2574 2008-09-09 Marek Safar <marek.safar@gmail.com>
2576 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
2577 delegate.cs: Share special type check.
2579 2008-09-09 Marek Safar <marek.safar@gmail.com>
2581 A fix for bug #423981
2582 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
2584 2008-09-09 Marek Safar <marek.safar@gmail.com>
2586 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
2589 2008-09-09 Marek Safar <marek.safar@gmail.com>
2591 A fix for bugs: #324750, #335946
2592 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
2593 lookup rule to determine ?-based tokens.
2595 2008-09-08 Miguel de Icaza <miguel@novell.com>
2597 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
2598 expressions (like event adding or removing) end up here, so we
2599 need to treat those as statements.
2601 Add LoadAssembly method.
2603 2008-09-04 Miguel de Icaza <miguel@novell.com>
2605 * repl.cs: Add Time method.
2607 2008-09-05 Marek Safar <marek.safar@gmail.com>
2609 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
2611 2008-09-05 Miguel de Icaza <miguel@novell.com>
2613 * repl.cs: Add workaround for old compilers.
2615 2008-09-04 Jb Evain <jbevain@novell.com>
2617 * repl.cs (PrettyPrint): pretty print everything that
2618 implements IDictionary, as well as IEnumerables. Also,
2619 add a quit helper property.
2621 2008-09-04 Marek Safar <marek.safar@gmail.com>
2623 * constant.cs: Better error reporting for decimal literals.
2625 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
2628 2008-09-04 Marek Safar <marek.safar@gmail.com>
2629 Miguel de Icaza <miguel@novell.com>
2631 A fix for bug #422951
2632 * assign.cs (Assign.DoResolve): Perform the type conversions
2633 checks before we attempt to initialize `New' initializers.
2635 2008-09-04 Marek Safar <marek.safar@gmail.com>
2637 A fix for bug #422853
2638 * delegate.cs (DelegateCreation): Add special handling for
2639 EmptyExpression.Null instance expression which is just another
2640 hack for undecided member instance exression.
2642 2008-09-04 Marek Safar <marek.safar@gmail.com>
2644 * expression.cs, ecore.cs: Emit full expression tree for reduced
2647 2008-09-04 Marek Safar <marek.safar@gmail.com>
2649 * expression.cs (This): Guard against multi-resolving.
2651 * ecore.cs, statement.cs (Throw): Simplified.
2653 * flowanalysis.cs: Also verify event fields.
2655 2008-09-04 Miguel de Icaza <miguel@novell.com>
2657 * assign.cs (Assign.DoResolve): Perform the type conversions
2658 checks before we attempt to initialize `New' initializers.
2660 * repl.cs (PrettyPrint): Add Hashtable prettyprint
2662 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
2665 * repl.cs: Update help.
2667 2008-09-03 Miguel de Icaza <miguel@novell.com>
2669 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
2670 handling of the default config handling, including the special
2671 treatment of System.Core assembly.
2673 Fixes the REPL processing for LINQ.
2675 2008-09-03 Marek Safar <marek.safar@gmail.com>
2677 A fix for bug #422507
2678 * expression.cs (UnboxCast): Add missing child expression mutator.
2680 2008-09-03 Marek Safar <marek.safar@gmail.com>
2682 * driver.cs: Don't self reference System.Core assembly.
2684 2008-09-03 Marek Safar <marek.safar@gmail.com>
2686 A fix for bug #422507
2687 * expression.cs (StringConcat): Add missing type mutator.
2689 2008-09-03 Marek Safar <marek.safar@gmail.com>
2691 * generic.cs (TypeInferenceContext): Follow equality rule for
2692 constructed type lower bound type inference.
2694 2008-09-02 Miguel de Icaza <miguel@novell.com>
2696 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
2697 <dblank@cs.brynmawr.edu> which updates the cursor position on
2700 2008-09-02 Marek Safar <marek.safar@gmail.com>
2702 A fix for bug #367145
2703 * driver.cs: Fixed import of extension methods when using -noconfig
2706 2008-09-02 Marek Safar <marek.safar@gmail.com>
2708 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
2709 version from non-generic implementation instead.
2711 2008-09-01 Marek Safar <marek.safar@gmail.com>
2713 A fix for bug #418908
2714 * class.cs: Use AddScopeStatement for field initializers.
2716 2008-09-01 Marek Safar <marek.safar@gmail.com>
2718 A fix for bug #415385
2719 * ecore.cs, convert.cs: Do method group conversion for equal group types.
2721 2008-09-01 Marek Safar <marek.safar@gmail.com>
2723 A fix for bug #421736
2724 * iterators.cs: Don't crash on unreachable iterators.
2726 2008-09-01 Marek Safar <marek.safar@gmail.com>
2728 A fix for bug #421628
2729 * parameter.cs, attribute.cs: Clone also parameter attributes.
2731 2008-08-30 Miguel de Icaza <miguel@novell.com>
2733 * namespace.cs (LookupType): In EvalMode, try to replace
2734 the TypeBuilder from our cache with a Type as Reflection.Emit does
2735 not like to mix code from older assemblies emitted and new
2738 This sounds like a serious Mono bug that prevents multiple
2739 assemblies to be generated and consumed at the same time.
2741 * cs-parser.jay (push_current_class): Do not make interactive
2742 classes internal or private, make them public as we currently
2743 generate each new class in a new assembly.
2745 2008-08-29 Miguel de Icaza <miguel@novell.com>
2747 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
2748 remove types that are entered into the global namespace during
2749 parsing so that we can remove them on failure.
2751 * cs-parser.jay: Parsing: we now keep track of types that are
2752 entered into global variables and queue those in case the parsing
2755 This happens in a few situations: during partial-input, we invoke
2756 the parser repeatedly for example with the string "class X", this
2757 would cause X to be registed, and we need to remove this
2758 registration so that another parse attempt later with say "class X {"
2759 would actually work.
2761 Additionally, if there is an error in the resolution phase, for
2762 example: "class X : NonExistant {}" th
2764 * cs-parser.jay: Be more precise with the errors being raised,
2765 instead of flagging all exceptions during parsing to be attributed
2766 to the parsing process, distinguish those from errors happening in
2767 the actions and hint that using -v would produce the actual
2770 * repl.cs: Do not load all compiler references on each reset,
2771 doing the partial reset takes care of this.
2773 2008-08-28 Miguel de Icaza <miguel@novell.com>
2775 * repl.cs: Add support for loading all the files from
2776 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
2779 Introduce a micro-parser that is able to deambiguate on its input
2780 whether we are dealing with a compilation unit (namespace, class,
2781 interface, struct, delegate) declaration or a statement. This
2782 allows both declarations and statements to be entered.
2784 Set history size by default to 300 lines.
2786 Instead of distinguishing based on the parser.InteractiveResult,
2787 have only two cases: statements were parsed, or a compilation unit
2788 was. Always pull the Using statement additions from the
2789 compilation unit parse.
2791 * cs-tokenizer.cs: Rename tokens to better describe their intent
2792 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
2794 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
2795 EvalMode is used to trigger the lookup of global variables while
2796 StatementMode is used turn variable declarations into static
2799 * getline.cs: Allow history size to be set.
2801 2008-08-29 Marek Safar <marek.safar@gmail.com>
2803 A fix for bug #360755
2804 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
2806 2008-08-29 Marek Safar <marek.safar@gmail.com>
2808 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
2810 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
2811 member name, it is too confusing
2813 * decl.cs, class.cs: Don't report unused fields with attached attribute.
2815 * rootcontext.cs: Finally default to warning level 4.
2817 2008-08-28 Marek Safar <marek.safar@gmail.com>
2819 * class.cs (CheckBase): Ignore overloaded operators.
2821 2008-08-28 Marek Safar <marek.safar@gmail.com>
2823 A fix for bug #420830
2824 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
2826 2008-08-28 Marek Safar <marek.safar@gmail.com>
2828 A fix for bug #420832
2829 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
2831 2008-08-28 Marek Safar <marek.safar@gmail.com>
2833 A fix for bug #420386
2834 * nullables.cs: Fixed logic of nullable user comparison operators involving
2837 2008-08-28 Marek Safar <marek.safar@gmail.com>
2839 * attribute (IsClsCompliant): Use FALSE value for pointer types.
2841 2008-08-27 Miguel de Icaza <miguel@novell.com>
2843 * repl.cs: Add support for aborting the running code with C-c.
2845 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
2847 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
2849 2008-08-27 Miguel de Icaza <miguel@novell.com>
2851 * cs-parser.jay (interactive_statement_list): A new set of rules
2852 for hosting statements that uses the "interactive_" prefix.
2854 * repl.cs: Add support for parsing `using' as a statement or as a
2855 directive. Deambiguating before passing this to the parser.
2857 We need to distinguish statement_expressions that occur at the
2858 toplevel vs those that occur embedded into expressions.
2860 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
2861 that fixes the cursor key handling, and a history bug.
2863 2008-08-26 Miguel de Icaza <miguel@novell.com>
2865 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
2866 limitations in Console, instead the 2.0 bootstrap libraries now
2867 include the Console bits.
2869 Also, remove the use of Nullables from getline.cs
2873 Interactive support for the C# compiler. Use gmcs --shell to
2874 enter a read-eval-print loop shell.
2876 Docs: http://www.mono-project.com/CsharpRepl
2878 * sources: include repl.cs here and getline.cs for gmcs.exe,
2879 everything else is getline.cs impaired.
2881 * Makefile: when bootstrapping pass a special flag
2882 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
2883 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
2884 This distinguishes those two cases.
2886 * repl.cs: Support for a read-eval-print loop. Will be soon
2887 refactored into eval support and then REPL on top of it.
2889 * ecore.cs: If a simplename lookup fails, before erroring out,
2890 if we are in EvalMode to resolve the name to a declaration in the
2893 This means that variable declarations that happened in previous
2894 classes (as repl puts every statement in a separate class) are
2895 made visible in this way.
2897 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
2898 triggered an error due to the end of file being reached. This is
2899 used to do multi-line input, and notify the caller that the user
2900 needs to provide more text before a successful parse.
2902 Add new grammar rules after the INTERACTIVE_PARSER token is seen
2903 to drive the evaluation with a custom wrapper.
2905 * driver.cs: Add support for --shell, and refactor some code to be
2908 * namespace.cs: Add support for serializing the contents of the
2909 namespaces and reloading them.
2911 * getline.cs: A managed implementation of ReadLine under
2912 X11/Apache2 license terms. Easy to embed in other applications as
2915 * namespace.cs: Add some functions to save and restore the
2918 * rootcontext.cs: New public field.
2920 * cs-tokenizer.cs: Add support for one of the possible characters
2921 we introduce into the token stream.
2923 This patch does not affect the regular tokenization process, the
2924 only performance hit would happen if there is an invalid character
2925 on the input string.
2927 * support.cs: Move isatty helper routine here.
2929 * codegen.cs: Small cleanup, and add a mechanism to initialize the
2930 code generator for in-memory assemblies.
2932 2008-08-26 Marek Safar <marek.safar@gmail.com>
2934 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
2935 parameter cannot be always used as a type.
2937 2008-08-21 Marek Safar <marek.safar@gmail.com>
2939 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
2941 2008-08-21 Marek Safar <marek.safar@gmail.com>
2943 * convert.cs: Implement explicit array to IList<T> conversion.
2945 2008-08-20 Marek Safar <marek.safar@gmail.com>
2947 A fix for bug #362740
2948 * cs-tokenizer.cs: Handle UTF-16 surrogates.
2950 2008-08-20 Marek Safar <marek.safar@gmail.com>
2952 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
2953 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
2954 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
2955 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
2956 handling to use just one type of infrastructure and deal with generics
2959 2008-07-23 Martin Baulig <martin@ximian.com>
2961 *** Merged this from trunk revision 108527 ***
2964 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
2965 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
2968 2008-08-15 Marek Safar <marek.safar@gmail.com>
2970 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
2973 2008-08-15 Marek Safar <marek.safar@gmail.com>
2975 * delegate.cs: Fixed compiler crash when creating delegate using partial
2978 * typemanager.cs: MulticastDelegate is not a delegate.
2980 2008-08-14 Marek Safar <marek.safar@gmail.com>
2982 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
2985 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
2987 * cs-parser.jay (type): Allow 'var' in mcs too.
2988 (local_variable_type): Likewise.
2990 2008-08-14 Marek Safar <marek.safar@gmail.com>
2992 * driver.cs: Removed broken -noconfig variants.
2994 2008-08-14 Marek Safar <marek.safar@gmail.com>
2996 A fix for bug #417078
2997 * expression.cs: Emit correctly left side pointer operators.
2999 2008-08-13 Marek Safar <marek.safar@gmail.com>
3001 * generic.cs, lambda.cs: Inflate method generic arguments only.
3003 2008-08-12 Marek Safar <marek.safar@gmail.com>
3005 * class.cs: Fixed struct layout check regression.
3007 2008-08-12 Marek Safar <marek.safar@gmail.com>
3009 * cs-parser.jay, enum.cs: Simplified enum parsing.
3011 * decl.cs: Check all type parameters conflicts.
3013 * expression.cs, statement.cs, attribute.cs: More expression checks.
3015 2008-08-11 Marek Safar <marek.safar@gmail.com>
3017 * generic.cs: Add type inference types restriction.
3019 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3020 anonymous.cs, expression.cs: Allocate less accessor parameters.
3022 2008-08-08 Marek Safar <marek.safar@gmail.com>
3024 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3027 2008-08-08 Marek Safar <marek.safar@gmail.com>
3029 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3031 2008-08-07 Marek Safar <marek.safar@gmail.com>
3033 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3034 Also fixes #362146 and #381592.
3036 2008-08-07 Marek Safar <marek.safar@gmail.com>
3038 * ecore.cs: Reduced constant cannot be used as an attribute value.
3040 * cs-parser.jay: Base expression has to be a type.
3042 * expression.cs (Conditional): Uses ReducedExpression.
3044 2008-08-06 Marek Safar <marek.safar@gmail.com>
3046 A fix for bug #376826
3047 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3048 address of hoisted local variable or parameter cannot be taken.
3050 2008-08-05 Marek Safar <marek.safar@gmail.com>
3052 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3053 anonymous method inside checked/unchecked expression.
3055 2008-08-05 Marek Safar <marek.safar@gmail.com>
3057 * typemanager.cs (IsEqual): Guard against null.
3059 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3060 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3061 routine. Fixed few misleading conversion errors.
3063 2008-08-04 Marek Safar <marek.safar@gmail.com>
3065 * class.cs: Consider generics when checking cycles in struct layout.
3067 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3069 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3071 2008-08-04 Marek Safar <marek.safar@gmail.com>
3073 A fix for bug #414165
3074 * anonymous.cs: Use same anonymous implementation method for all anonymous
3077 2008-08-04 Marek Safar <marek.safar@gmail.com>
3079 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3082 2008-08-04 Marek Safar <marek.safar@gmail.com>
3084 * cs-parser.jay: Typeof argument has to be a type expression.
3086 * namespace.cs: Check alias and namespace definitions collisions.
3088 * class.cs, pending.cs: Moved explicit interface accessor implementation
3091 * delegate.cs, expression.cs: Verify special name invocations.
3093 2008-08-01 Marek Safar <marek.safar@gmail.com>
3095 * cs-parser.jay: Don't choke on empty generic type arguments.
3097 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3099 * expression.cs, ecore.cs: Minor expressions bugs.
3101 2008-08-01 Marek Safar <marek.safar@gmail.com>
3103 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3104 and added more error handling.
3106 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3108 * modifiers.cs, enum.cs: Fixed.
3110 2008-07-31 Jb Evain <jbevain@novell.com>
3112 * driver.cs: remove -pkg ability of smcs.
3114 2008-07-30 Marek Safar <marek.safar@gmail.com>
3116 * statement.cs (Switch): Correctly set empty default target for single
3119 2008-07-30 Marek Safar <marek.safar@gmail.com>
3121 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3122 string switch statement implementation to use string dictionary which
3123 significantly (2-8x) improves performance of generated code.
3125 2008-07-29 Marek Safar <marek.safar@gmail.com>
3127 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3128 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3130 2008-07-29 Marek Safar <marek.safar@gmail.com>
3132 A fix for bug #412595
3133 * typemanager.cs, convert.cs, expression.cs: Some types are never
3134 convertible to each other.
3136 2008-07-29 Marek Safar <marek.safar@gmail.com>
3138 * nullable.cs (CreateNullConstant): An error messages update.
3140 2008-07-29 Marek Safar <marek.safar@gmail.com>
3142 A fix for bug #412595
3143 * cfold.cs: Don't cast undefined bool constant.
3145 2008-07-29 Martin Baulig <martin@ximian.com>
3148 (SymbolWriter.Reset): New public static method.
3151 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3153 2008-07-28 Marek Safar <marek.safar@gmail.com>
3155 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3157 * expression.cs (ElementAccess): Exact size allocation.
3159 2008-07-26 Marek Safar <marek.safar@gmail.com>
3161 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3163 2008-07-25 Marek Safar <marek.safar@gmail.com>
3165 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3167 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3170 2008-07-25 Marek Safar <marek.safar@gmail.com>
3172 A fix for bug #412217
3173 * assign.cs: Mutate also assignment type.
3175 2008-07-25 Marek Safar <marek.safar@gmail.com>
3177 A fix for bug #323644
3178 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3181 2008-07-25 Marek Safar <marek.safar@gmail.com>
3183 A fix for bug #412134
3184 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3185 non-enumerable operands when overloading equality or bitwise operators.
3187 2008-07-25 Marek Safar <marek.safar@gmail.com>
3189 * anonymous.cs: Cache closed generic anonymous method delegates.
3191 2008-07-24 Marek Safar <marek.safar@gmail.com>
3193 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3194 anonymous.cs, statement.cs: Always emit anonymous method as static method
3195 when is instance free. Use nesting for nested anynomous methods blocks.
3197 2008-07-23 Marek Safar <marek.safar@gmail.com>
3199 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3202 2008-07-23 Marek Safar <marek.safar@gmail.com>
3204 * expression.cs: Removed MakeSimpleCall.
3206 2008-07-23 Marek Safar <marek.safar@gmail.com>
3208 A fix for bug #323012
3209 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3210 Base method implementing interface has to be public.
3212 2008-07-23 Marek Safar <marek.safar@gmail.com>
3214 * cs-parser.jay: Don't break on missing argument.
3216 2008-07-22 Marek Safar <marek.safar@gmail.com>
3218 A fix for bug #320993
3219 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3220 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3222 2008-07-22 Marek Safar <marek.safar@gmail.com>
3224 A fix for bug #320748
3225 * convert.cs: Implicit user operators cannot convert to interfaces
3227 2008-07-22 Marek Safar <marek.safar@gmail.com>
3229 A fix for bug #312686
3230 * driver.cs: Ignore empty assembly references.
3232 2008-07-22 Marek Safar <marek.safar@gmail.com>
3234 A fix for bug #387040
3235 * ecore.cs: Skip constrains check for an explicit implementation.
3237 2008-07-21 Marek Safar <marek.safar@gmail.com>
3239 A fix for bug #409045
3240 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3241 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3242 identifiers are file specific unless passed as input arguments.
3244 2008-07-21 Marek Safar <marek.safar@gmail.com>
3246 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3247 to emit UnmanagedMarshal data under 2.0 profile.
3249 2008-07-21 Marek Safar <marek.safar@gmail.com>
3251 A fix for bug #410369
3252 * parameter.cs: Clone correctly ParamsParameter.
3254 2008-07-21 Marek Safar <marek.safar@gmail.com>
3256 * expression.cs (Argument): Always report type for type based expressions
3259 2008-07-18 Marek Safar <marek.safar@gmail.com>
3261 A fix for bug #410666
3262 * anonymous.cs: Correctly initialize generic storey reference.
3264 2008-07-18 Marek Safar <marek.safar@gmail.com>
3266 * convert.cs: Don't box same type arguments.
3268 2008-07-18 Marek Safar <marek.safar@gmail.com>
3270 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3271 Finished missing generic type mutators.
3273 2008-07-18 Marek Safar <marek.safar@gmail.com>
3275 * iterators.cs, statement.cs: Finished statements CloneTo.
3277 2008-07-18 Marek Safar <marek.safar@gmail.com>
3279 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3281 * expression.cs: Emit optimized default value expressions in expression tree
3284 2008-07-18 Marek Safar <marek.safar@gmail.com>
3286 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3288 2008-07-17 Marek Safar <marek.safar@gmail.com>
3290 A fix for bug #367536
3291 * cs-parser.jay: Check static constructor of generic types for an access
3294 2008-07-17 Marek Safar <marek.safar@gmail.com>
3296 A fix for bug #353800
3297 * lambda.cs: Emit ret for contextual statements.
3299 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3300 up emitting redundant ret for all anonymous methods with return.
3302 2008-07-17 Marek Safar <marek.safar@gmail.com>
3304 A fix for bug #365188
3305 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3306 create anonymous method storey in unreachable block.
3308 2008-07-17 Marek Safar <marek.safar@gmail.com>
3310 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3311 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3312 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3313 statement.cs: Fixed relevant defects found by Gendarme.
3315 2008-07-17 Marek Safar <marek.safar@gmail.com>
3317 A fix for bug #325291
3318 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3319 statement.cs: Replaced IAnonymousHost with top level block flag.
3321 2008-07-17 Marek Safar <marek.safar@gmail.com>
3323 * cs-parser.jay: Clean up unused open_parens.
3325 2008-07-17 Marek Safar <marek.safar@gmail.com>
3327 * ecore.cs: Custom error message for a range variable assignment.
3329 2008-07-16 Marek Safar <marek.safar@gmail.com>
3331 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3334 2008-07-16 Marek Safar <marek.safar@gmail.com>
3336 * literal.cs: Null literal is of object type.
3338 2008-07-16 Marek Safar <marek.safar@gmail.com>
3340 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3341 expression of nullable equality comparison.
3343 2008-07-15 Marek Safar <marek.safar@gmail.com>
3345 * expression.cs(PointerArithmetic): Removed redundant assignment.
3347 2008-07-15 Marek Safar <marek.safar@gmail.com>
3349 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3351 2008-07-14 Marek Safar <marek.safar@gmail.com>
3353 A fix for bug #408361
3354 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3355 they are replaced by GetMethod.
3357 2008-07-14 Marek Safar <marek.safar@gmail.com>
3359 A fix for bug #408721 by jeremie.laval@gmail.com
3360 * expression.cs (Indirection): Implemented CloneTo.
3362 2008-07-14 Marek Safar <marek.safar@gmail.com>
3364 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3367 2008-07-14 Marek Safar <marek.safar@gmail.com>
3369 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3371 2008-07-11 Marek Safar <marek.safar@gmail.com>
3373 * linq.cs: Reset tranparent parameter counter in probing mode.
3375 2008-07-11 Marek Safar <marek.safar@gmail.com>
3377 * anonymous.cs: Mutate anonymous method type.
3379 2008-07-11 Marek Safar <marek.safar@gmail.com>
3381 * ecore.cs, anonymous.cs: Mutate field expressions.
3383 2008-07-10 Marek Safar <marek.safar@gmail.com>
3385 A fix for bug #369670
3386 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3388 2008-07-10 Marek Safar <marek.safar@gmail.com>
3390 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3392 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3395 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3396 only one '>', and finds a '>>', abort the generic lookahead.
3398 2008-07-10 Marek Safar <marek.safar@gmail.com>
3400 A fix for bug #319902
3401 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3403 2008-07-10 Marek Safar <marek.safar@gmail.com>
3405 A fix for bug #406371
3406 * statement.cs: Moved EmitSymbolInfo to Block.
3408 2008-07-09 Marek Safar <marek.safar@gmail.com>
3410 * ecore.cs: Report better error for extension method overload failures.
3412 2008-07-09 Marek Safar <marek.safar@gmail.com>
3414 * expression.cs (Is): No need to box reference values.
3416 2008-07-09 Marek Safar <marek.safar@gmail.com>
3418 * class.cs: Use event resolve context when initializing CreateEmitContext.
3420 2008-07-09 Marek Safar <marek.safar@gmail.com>
3422 A fix for bug #394436
3423 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3424 method used inside expression trees. Added more LINQ to expression tree
3427 2008-07-08 Marek Safar <marek.safar@gmail.com>
3429 A fix for bug #378189, #370577
3430 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3433 2008-07-08 Marek Safar <marek.safar@gmail.com>
3435 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3438 2008-07-08 Marek Safar <marek.safar@gmail.com>
3440 A fix for bug #406702
3441 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3443 2008-07-07 Marek Safar <marek.safar@gmail.com>
3445 A fix for bug #406648
3446 * cs-parser.jay: Report nullable use in mcs for some cases.
3448 2008-07-07 Marek Safar <marek.safar@gmail.com>
3450 * ecore.cs: Improved argument mismatch error messages.
3452 2008-07-07 Marek Safar <marek.safar@gmail.com>
3454 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3456 2008-07-07 Marek Safar <marek.safar@gmail.com>
3458 * expression.cs (TypeOf): Mutate type argument.
3460 2008-07-04 Marek Safar <marek.safar@gmail.com>
3462 * class.cs: Report missing partial modifier for correct type.
3464 2008-07-04 Marek Safar <marek.safar@gmail.com>
3466 * ecore.cs, expression.cs (VariableReference): Variable property is
3469 2008-07-04 Marek Safar <marek.safar@gmail.com>
3471 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3473 2008-07-04 Marek Safar <marek.safar@gmail.com>
3475 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3478 2008-07-04 Marek Safar <marek.safar@gmail.com>
3480 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3481 anonymous method storey to an instance method when only "this" is hoisted.
3483 2008-07-03 Marek Safar <marek.safar@gmail.com>
3485 A fix for bug #321615
3486 * expression.cs: Pointer comparisons use unsigned operator.
3488 2008-07-03 Marek Safar <marek.safar@gmail.com>
3490 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3492 2008-07-02 Marek Safar <marek.safar@gmail.com>
3494 A fix for bug #404905
3495 * class.cs: Always initialize local unsafe variables.
3497 2008-06-30 Marek Safar <marek.safar@gmail.com>
3499 A fix for bug #396987
3500 * expression.cs (NewInitialize): Clear local temporary variable for next run
3502 2008-06-27 Marek Safar <marek.safar@gmail.com>
3504 A fix for bug #401020
3505 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3507 2008-06-27 Marek Safar <marek.safar@gmail.com>
3509 A fix for bug #398319
3510 * cs-parser.jay: Implemented undocumented base access expression inside
3513 2008-06-26 Marek Safar <marek.safar@gmail.com>
3515 A fix for bug #404227
3516 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3518 2008-06-26 Marek Safar <marek.safar@gmail.com>
3520 A fix for bug #404227
3521 * convert.cs: Fixed explicit array to interface cast.
3523 2008-06-26 Marek Safar <marek.safar@gmail.com>
3525 A fix for bug #403894
3526 * delegate.cs: Mutate DelegateInvocation type.
3528 2008-06-26 Marek Safar <marek.safar@gmail.com>
3530 A fix for bug #379348
3531 * delegate.cs: Box a load of generic parameters.
3533 2008-06-26 Marek Safar <marek.safar@gmail.com>
3535 * expression.cs: Add an array creation arguments mutate.
3537 2008-06-26 Marek Safar <marek.safar@gmail.com>
3539 A fix for bug #386068
3540 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3543 2008-06-25 Marek Safar <marek.safar@gmail.com>
3545 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
3548 2008-06-25 Marek Safar <marek.safar@gmail.com>
3550 A fix for bug #403518
3551 * delegate.cs: Type correctly anonymous method new invocation.
3553 2008-06-24 Marek Safar <marek.safar@gmail.com>
3555 A fix for bug #394826
3556 * anonymous.cs: Fully qualify members when resolving anonymous type internal
3559 2008-06-24 Marek Safar <marek.safar@gmail.com>
3561 A fix for bug #394826
3562 * anonymous.cs, iterators.cs: Construct generic storey only when is really
3565 2008-06-24 Marek Safar <marek.safar@gmail.com>
3567 * class.cs: Clone indexer parameters for localized capturing.
3569 2008-06-24 Marek Safar <marek.safar@gmail.com>
3571 A fix for bug #402379
3572 * expression.cs: Don't crash when an object initializer resolve fails.
3574 2008-06-24 Marek Safar <marek.safar@gmail.com>
3576 A fix for bug #402888
3577 * expression.cs: Mutate conditional expression.
3579 2008-06-24 Marek Safar <marek.safar@gmail.com>
3581 A fix for bug #401012
3582 * class.cs: Keep StructLayout in shared container.
3584 2008-06-24 Marek Safar <marek.safar@gmail.com>
3586 A fix for bug #400438
3587 * decl.cs, class.cs: Only properties can be automatically implemented.
3589 2008-06-24 Marek Safar <marek.safar@gmail.com>
3591 * statement.cs (ChangeToIterator): Copy also labels.
3593 2008-06-23 Marek Safar <marek.safar@gmail.com>
3595 * ecore.cs: Pass type argument details to parent extension method.
3597 2008-06-23 Marek Safar <marek.safar@gmail.com>
3599 A fix for bug #375966
3600 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
3602 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
3604 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
3606 2008-06-22 Marek Safar <marek.safar@gmail.com>
3608 A fix for bug #394347
3609 * anonymous.cs: Cache compatible delegates as compatibility check produces
3610 a new method every time.
3612 2008-06-20 Marek Safar <marek.safar@gmail.com>
3614 * anonymous.cs: Propagate storey reference for single references.
3616 2008-06-20 Marek Safar <marek.safar@gmail.com>
3618 A fix for bug #387615
3619 * assign.cs, expression.cs: Correctly clone compound assignment.
3621 2008-06-19 Marek Safar <marek.safar@gmail.com>
3623 A fix for bug #359611, #359604
3624 * anonymous.cs: Mutate all types of hoisted parameters.
3626 2008-06-19 Marek Safar <marek.safar@gmail.com>
3628 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
3629 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
3630 expression.cs, codegen.cs, statement.cs
3632 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
3633 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
3635 ** Anonymous methods, lambda expressions rewrite **
3637 Anonymous expressions are now resolved when an explicit block is resolved
3638 and they don't require any registration procedure anymore. Further,
3639 anonymous methods are defined when explicit block is emitted which allows
3640 better control of whole process and opens possibilities for more
3641 optimizations as well as alternative to reverse whole process.
3643 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
3644 process consistent and to correctly emit hoisted generic methods when they
3645 have at least 1 hoisted variable.
3647 2008-06-17 Martin Baulig <martin@ximian.com>
3649 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
3651 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
3652 virtual property; check it in Emit().
3653 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
3655 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
3657 (Indexer.Define): Likewise.
3659 2008-06-17 Marek Safar <marek.safar@gmail.com>
3661 * convert.cs: Don't use IsInterface on type arguments.
3663 * delegate.cs: DelegateInvocation uses MethodInfo.
3665 * parameter.cs: Removed IsTypeParameter.
3667 * generic-mcs.cs: More missing stuff.
3669 2008-06-16 Martin Baulig <martin@ximian.com>
3672 (Modifiers.DEBUGGER_HIDDEN): New public const.
3675 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
3678 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
3679 (AbstractPropertyEventMethod): Likewise.
3680 (Constructor.Emit): Likewise.
3681 (SourceMethod.SetCompilerGenerated): Removed.
3683 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
3687 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
3688 if we're an `IteratorHost'.
3689 (AnonymousMethodMethod..ctor): Don't set
3690 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
3693 2008-06-16 Marek Safar <marek.safar@gmail.com>
3695 * statement.cs: Clean-up foreach statements.
3697 2008-06-12 Marek Safar <marek.safar@gmail.com>
3699 * class.cs: Stop using public method which should not exist
3700 (MethodBuilder.SetGenericMethodSignature).
3702 2008-06-11 Martin Baulig <martin@ximian.com>
3705 (Location.LookupFile): Add `CompilationUnit' argument; when given
3706 a relative file name, make it relative to the directory the .cs
3707 file is located in instead of using the current directory.
3709 2008-06-11 Martin Baulig <martin@ximian.com>
3712 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
3713 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
3714 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
3715 (SourceMethod.SetCompilerGenerated): Likewise.
3717 2008-06-11 Marek Safar <marek.safar@gmail.com>
3719 * codegen.cs, driver: Only write symbol file when it's asked for.
3721 2008-06-11 Marek Safar <marek.safar@gmail.com>
3723 * codegen.cs: Don't use assembly writer error handling for symbol writer.
3725 2008-06-10 Martin Baulig <martin@ximian.com>
3727 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
3729 2008-06-09 Marek Safar <marek.safar@gmail.com>
3731 A fix for bug #316290
3732 * expression.cs: Include decimal operators in predefined table.
3734 * parameters.cs: More readonlyness.
3736 2008-06-09 Marek Safar <marek.safar@gmail.com>
3738 A fix for bug #397213
3739 * cs-parser.jay: One more missing current_local_parameters reset.
3741 2008-06-09 Marek Safar <marek.safar@gmail.com>
3743 A fix for bug #396633
3744 * class.cs: Host backing field in partial container.
3746 2008-06-09 Marek Safar <marek.safar@gmail.com>
3748 A fix for bug #397068
3749 * expression.cs: Check both operand types when predefined operator is used.
3751 2008-06-05 Martin Baulig <martin@ximian.com>
3753 Merged the `debugger-kahalo' branch.
3756 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
3757 we're an iterator method.
3758 (SourceMethod): Reflect latest symbol writer changes;
3759 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
3760 now `start_row' and `end_row'.
3761 (Constructor.Emit): Fix the logic whether to emit symbol information.
3763 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
3767 (CompilationUnit): New public class; derives from `SourceFile'.
3768 (SourceFileEntry.DefineSymbolInfo): New public method.
3769 (SourceFileEntry.SetChecksum): New public method.
3770 (Location): Encode hidden line numbers by using `column == 255';
3771 the .ctor now accepts `column == -1' to mark a hidden line number.
3772 (Location.Hidden): New public property.
3773 (Location.CheckPoint): Add `CompilationUnit'.
3774 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
3775 (Location.Push): Add `CompilationUnit compile_unit' argument.
3776 (Location.CompilationUnit): New public property.
3779 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
3781 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
3783 * driver.cs: `SourceFile' -> `CompilationUnit'.
3785 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
3787 * namespace.cs: `SourceFile' -> `CompilationUnit'.
3789 * cs-tokenizer.cs: Add support for `#pragma checksum' and
3793 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
3794 new symbol writer API to also pass the file.
3796 2008-06-05 Marek Safar <marek.safar@gmail.com>
3798 * statement.cs: Emit catch variable assignment using variable expression.
3800 2008-06-05 Marek Safar <marek.safar@gmail.com>
3802 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
3803 with other variable types.
3805 2008-06-04 Marek Safar <marek.safar@gmail.com>
3807 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
3808 GetLength method emit, it breaks resolve rules.
3810 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
3811 Marek Safar <marek.safar@gmail.com>
3813 A fix for bug #395542
3814 * cs-parser.jay: The trailing comma is allowed in anonymous type member
3817 2008-06-02 Marek Safar <marek.safar@gmail.com>
3819 A fix for bug #395287
3820 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
3822 2008-05-31 Marek Safar <marek.safar@gmail.com>
3824 A fix for bug #395845
3825 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
3826 non-nullable parameter type.
3828 2008-05-31 Marek Safar <marek.safar@gmail.com>
3830 * class.cs: Handle contructor initializer as a statement in top-level block.
3832 2008-05-30 Marek Safar <marek.safar@gmail.com>
3834 * attribute.cs: Don't mix old and new corlib types when emitting corlib
3835 security attributes.
3837 2008-05-24 Marek Safar <marek.safar@gmail.com>
3839 * ecore.cs, expression.cs: Small IVariable refactoring.
3841 2008-05-22 Marek Safar <marek.safar@gmail.com>
3843 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
3845 2008-05-21 Marek Safar <marek.safar@gmail.com>
3847 * cs-parser.jay: Removed redundant catch type check.
3849 2008-05-21 Marek Safar <marek.safar@gmail.com>
3851 A fix for bug #390372
3852 * nullable.cs: Set correct return type.
3854 2008-05-21 Marek Safar <marek.safar@gmail.com>
3856 A fix for bug #391062
3857 * typemanager.cs: Fixed crash when comparing null types.
3859 2008-05-21 Marek Safar <marek.safar@gmail.com>
3861 A fix for bug #391871
3862 * cs-parser.jay: Better error handling for invalid catch type.
3864 2008-05-20 Marek Safar <marek.safar@gmail.com>
3866 A fix for bug #392155
3867 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
3869 2008-05-15 Marek Safar <marek.safar@gmail.com>
3871 A fix for bug #390666
3872 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
3875 2008-05-15 Marek Safar <marek.safar@gmail.com>
3877 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
3880 2008-05-13 Marek Safar <marek.safar@gmail.com>
3882 A fix for bug #389625
3883 * delegate.cs, generic.cs: Some progress on method group return type
3886 2008-05-13 Marek Safar <marek.safar@gmail.com>
3888 A fix for bug #378419
3889 * namespace.cs: Inspect also parent namespaces not only namespace entries.
3891 2008-05-12 Marek Safar <marek.safar@gmail.com>
3893 * class.cs (Constructor): Added IsCompilerGenerated.
3895 2008-05-12 Marek Safar <marek.safar@gmail.com>
3897 * expression.cs: Enum binary operators can accept non-enum operand only when
3898 is implicitly convertible to underlying type.
3900 2008-05-12 Marek Safar <marek.safar@gmail.com>
3902 A fix for bug #389272
3903 * support.cs: Workaround System.InvalidOperationException for enums.
3905 2008-05-12 Marek Safar <marek.safar@gmail.com>
3907 A fix for bug #389073
3908 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
3910 2008-05-10 Marek Safar <marek.safar@gmail.com>
3912 * driver.cs: Split Parse.
3914 * location.cs (LookupFile): Uses string.Empty.
3916 2008-05-07 Marek Safar <marek.safar@gmail.com>
3918 * expression.cs, parameter.cs: Small ParameterReference clean up.
3920 2008-05-07 Marek Safar <marek.safar@gmail.com>
3922 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
3923 hack. Fixes #387502.
3925 2008-05-06 Martin Baulig <martin@ximian.com>
3927 * class.cs (Constructor.Emit): Fix the logic whether to emit
3930 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
3933 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
3934 InvalidOperationException when the iterator is before the start or
3937 2008-05-06 Marek Safar <marek.safar@gmail.com>
3939 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
3940 when left is nullable type.
3942 2008-05-06 Marek Safar <marek.safar@gmail.com>
3944 A fix for bug #386628
3945 * expression.cs (LocalVariableReference): Continue in resolving when
3946 variable is not assigned.
3948 2008-05-05 Marek Safar <marek.safar@gmail.com>
3950 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
3951 nullable operations.
3953 2008-05-04 Marek Safar <marek.safar@gmail.com>
3955 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
3956 it saves many redundant temporary variables for nullable operations.
3958 2008-05-03 Marek Safar <marek.safar@gmail.com>
3960 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
3962 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
3965 * nullable.cs: Constant coalescing operator optimizations.
3967 2008-05-03 Marek Safar <marek.safar@gmail.com>
3969 * constant.cs: Use unsigned conversion for values which are unsigned only.
3971 2008-05-03 Marek Safar <marek.safar@gmail.com>
3973 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
3974 coalescing operator as it should be.
3976 2008-05-02 Marek Safar <marek.safar@gmail.com>
3978 A fix for bug #371016
3979 * expression.cs: All predefined delegate operators require implicit method
3982 2008-05-02 Marek Safar <marek.safar@gmail.com>
3984 * constant.cs: Emit long constant as uint when fits the range.
3986 * convert.cs, expression.cs: Fixed few unsafe conversions.
3988 2008-05-02 Marek Safar <marek.safar@gmail.com>
3990 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
3992 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
3995 * convert.cs (ImplicitNumericConversion): Don't modify the type of
3997 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
3999 2008-05-01 Marek Safar <marek.safar@gmail.com>
4001 * constant.cs, literal.cs: IsLiteral property for error reporting.
4003 * ecore.cs, expression.cs: Implemented Property expression.
4005 2008-05-01 Marek Safar <marek.safar@gmail.com>
4007 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4009 * nullable.cs: Implemented nullable coalescing null operator.
4011 * ecore.cs, expression.cs: Expression trees work.
4013 2008-05-01 Marek Safar <marek.safar@gmail.com>
4015 * ecore.cs: CreateExpressionTree is finally abstract.
4017 * expression.cs, linq.cs: Updated.
4019 2008-05-01 Marek Safar <marek.safar@gmail.com>
4021 * expression.cs, ecore.cs: Block base access expression inside expression
4024 2008-05-01 Marek Safar <marek.safar@gmail.com>
4026 A fix for bug #385058
4027 * expression.cs: User-defined operator implementations always take
4028 precedence over predefined operator implementations.
4030 2008-04-30 Marek Safar <marek.safar@gmail.com>
4032 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4033 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4034 expression tree conversions.
4036 2008-04-30 Marek Safar <marek.safar@gmail.com>
4038 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4039 operators method details to Operator class.
4041 2008-04-30 Marek Safar <marek.safar@gmail.com>
4043 * anonymous.cs: Pass unsafe flags to anonymous container.
4045 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4046 inside expression tree.
4048 2008-04-29 Martin Baulig <martin@ximian.com>
4050 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4051 (Tokenizer.PopPosition): Also restore the `line'.
4053 2008-04-29 Marek Safar <marek.safar@gmail.com>
4055 * delegate.cs: Implemented Invoke expression.
4057 2008-04-29 Marek Safar <marek.safar@gmail.com>
4059 * expression.cs: Fixed equality reference comparison regression.
4061 2008-04-29 Marek Safar <marek.safar@gmail.com>
4063 * ecore.cs: Clean up EmptyCast hack.
4065 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4066 using correct conversion rules. Also fixes #383993.
4068 2008-04-28 Martin Baulig <martin@ximian.com>
4070 * class.cs (Constructor.Emit): Don't emit debugging information
4071 for generated default .ctor's.
4073 2008-04-28 Marek Safar <marek.safar@gmail.com>
4075 * convert.cs: Empty-cast ushort to int conversion.
4077 2008-04-28 Marek Safar <marek.safar@gmail.com>
4079 A fix for bug #384191
4080 * ecore.cs, expression.cs: Fixed expression cloning.
4082 2008-04-28 Marek Safar <marek.safar@gmail.com>
4084 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4086 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4088 Fix #381559, test-638.cs, test-639.cs
4089 * assign.cs (CompoundAssign.Helper): New wrapper.
4090 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4092 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4093 Pass unconverted expressions to the params array creation expression.
4094 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4095 (PropertyExpr.EmitAssign): Likewise.
4096 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4097 element if it is of kind CompoundAssign.Helper.
4098 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4099 first before anything else.
4100 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4101 (ArrayAccess.LoadArrayAndArguments): Simplify.
4103 2008-04-27 Marek Safar <marek.safar@gmail.com>
4105 * expression.cs: Fixed cloning of typeof(void).
4107 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4109 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4110 (Assign.Emit): Likewise. Move it to ...
4111 (CompoundAssign.DoResolve): ... here and ...
4112 (CompoundAssign.Emit): ... here.
4113 (EventAddOrRemove): New helper to handle += and -= on events, and
4114 avoid the use of BinaryDelegates.
4115 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4116 (EventExpr.EmitAddOrRemove): Improve.
4117 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4119 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4120 create VarExprs for 'foo.bar.var'.
4121 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4122 is a highly inappropriate name for its functionality.
4124 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4126 Simplify handling of multiple assignments
4127 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4129 (SimpleAssign): New. Class to be used for normal assignments.
4130 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4131 * expression.cs, parameter.cs, statement.cs: Likewise.
4133 2008-04-25 Marek Safar <marek.safar@gmail.com>
4135 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4136 for incompatible underlying types, more to come, uff.
4138 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4141 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4142 Handle 'leave_copy'.
4144 2008-04-25 Marek Safar <marek.safar@gmail.com>
4146 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4148 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4150 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4151 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4152 * statement.cs (While, Do, For): Allow test to have side effects.
4153 (For.DoEmit): Always emit InitStatement.
4156 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4157 Always create SideEffectConstant.
4158 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4159 of type EnumConstant.
4161 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4162 Handle 'right' being SideEffectConstant of type 'bool'.
4164 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4165 Use left.EmitBranchable instead of open coding it, so as to
4166 improve optimization opportunities.
4168 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4170 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4172 (Expression.EmitSideEffect): Document.
4174 2008-04-23 Marek Safar <marek.safar@gmail.com>
4176 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4178 2008-04-23 Marek Safar <marek.safar@gmail.com>
4180 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4182 2008-04-23 Marek Safar <marek.safar@gmail.com>
4184 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4185 conversion to expression tree.
4187 2008-04-23 Marek Safar <marek.safar@gmail.com>
4189 * ecore.cs: Removed unused expression.
4191 2008-04-22 Marek Safar <marek.safar@gmail.com>
4193 * expression.cs: Implemented NegateChecked and New expressions.
4195 2008-04-22 Marek Safar <marek.safar@gmail.com>
4197 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4199 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4202 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4203 needing final 'ret' instruction.
4205 2008-04-22 Marek Safar <marek.safar@gmail.com>
4207 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4209 2008-04-21 Marek Safar <marek.safar@gmail.com>
4211 * expression.cs: Emit ldnull and not null expression as an instance argument
4212 of static method expression calls.
4214 2008-04-21 Marek Safar <marek.safar@gmail.com>
4216 A fix for bug #378200
4217 * expression.cs: Fixed crash when creating parameterless expression tree
4220 2008-04-21 Marek Safar <marek.safar@gmail.com>
4222 A fix for bug #375297
4223 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4226 2008-04-21 Marek Safar <marek.safar@gmail.com>
4228 A fix for bug #377596
4229 * decl.cs, class.cs: Emit delegate type argument attributes.
4231 2008-04-21 Marek Safar <marek.safar@gmail.com>
4233 A fix for bug #365314
4234 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4236 2008-04-21 Marek Safar <marek.safar@gmail.com>
4238 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4241 2008-04-21 Marek Safar <marek.safar@gmail.com>
4243 * generic.cs (TypeParameter): Removed redundant location.
4245 2008-04-19 Marek Safar <marek.safar@gmail.com>
4247 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4248 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4249 FullNamedExpression in all declaration type expression, statements will come
4252 2008-04-18 Marek Safar <marek.safar@gmail.com>
4254 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4255 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4257 2008-04-18 Marek Safar <marek.safar@gmail.com>
4259 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4262 2008-04-17 Marek Safar <marek.safar@gmail.com>
4264 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4267 2008-04-17 Marek Safar <marek.safar@gmail.com>
4269 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4273 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4275 Hook up 'EmitSideEffect'
4276 * constant.cs (Constant.EmitSideEffect): New.
4277 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4278 (SideEffectConstant.EmitSideEffect): New.
4279 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4280 unconditional branch in EmitBranchable.
4281 (FieldExpr.EmitBranchable): New.
4282 * expression.cs (Unary.EmitSideEffect): New.
4283 (Binary.EmitSideEffect): New.
4284 (VariableReference.EmitSideEffect): New. Do nothing.
4286 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4288 Introduce 'EmitSideEffect'
4289 * ecore.cs (Expression.EmitSideEffect): New.
4290 (TypeCast): Rename from EmptyCast.
4292 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4293 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4294 * convert.cs, nullable.cs: Update to changes.
4296 2008-04-16 Marek Safar <marek.safar@gmail.com>
4298 * class.cs, cs-parser.jay: Early check for base types expression.
4300 2008-04-16 Marek Safar <marek.safar@gmail.com>
4302 * decl.cs (MemberName): Declare PrettyName as obsolete.
4304 2008-04-16 Marek Safar <marek.safar@gmail.com>
4306 * namespace.cs: Use MemberName comparison.
4308 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4311 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4313 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4314 (MemberName.FullyQualifiedName): New. Provides the functionality
4315 that users assume FullName would have.
4316 * ecore.cs, namespace.cs: Update to changes.
4318 * statement.cs (Using.assign): Make into ExpressionStatement.
4319 (Using.EmitPreTryBody): Simplify.
4321 2008-04-16 Marek Safar <marek.safar@gmail.com>
4323 * report.cs: ColorFormat is protected.
4325 * rootcontext.cs: Unused fields clean-up.
4327 * namespace.cs: Made UsingEntry name private.
4329 2008-04-16 Marek Safar <marek.safar@gmail.com>
4331 * cs-tokenizer.cs, location.cs: Removed unused field.
4333 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4334 Raja R Harinath <harinath@hurrynot.org>
4337 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4338 (SideEffectConstant.side_effect): Rename from 'right'.
4339 (SideEffectConstant..ctor): Normalize 'side_effect'.
4340 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4341 value of this constant.
4342 * cfold.cs: Update to changes.
4344 2008-04-15 Marek Safar <marek.safar@gmail.com>
4346 * cs-paser.jay: Removed unused variable.
4348 * driver.cs: Made Compile instance method.
4350 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4352 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4354 2008-04-15 Marek Safar <marek.safar@gmail.com>
4356 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4358 2008-04-13 Jb Evain <jbevain@novell.com>
4360 * namespace.cs: update the System.Core fullname for 2.1
4361 * driver.cs: update the list of required assemblies for 2.1.
4362 Merged from the Moonlight 2 branch.
4364 2008-04-11 Marek Safar <marek.safar@gmail.com>
4366 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4367 types and user defined operators. User operators arguments has to be checked
4368 for null value before invocation, which also means no operator is called
4369 when any argument is not convertible to unwrapped nullable type.
4371 2008-04-09 Marek Safar <marek.safar@gmail.com>
4373 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4374 of Unary expressions to follow operator overloading rules precisely.
4375 Also fixes #321794, #323794
4377 2008-04-08 Marek Safar <marek.safar@gmail.com>
4379 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4382 2008-04-08 Marek Safar <marek.safar@gmail.com>
4384 * expression.cs, ecore.cs: Implemented MemberInit expression.
4386 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4388 Fix mono/tests/exception4.cs
4389 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4390 ec.NeedReturnLabel () rather emitting a 'nop'.
4392 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4394 (TryCatch.SomeCodeFollows): Likewise.
4395 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4396 for 'break', 'continue' and 'return' statements inside a try.
4397 We're fairly sure that the generated IL stream will have more
4398 instructions textually following the try.
4399 (FlowBranchingTryCatch): Likewise.
4401 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4402 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4405 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4406 wrapper -- forward everything to CollectionForeach.
4407 (CollectionForeach.NonDisposableWrapper): New.
4408 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4409 instead of a pop + branch to end.
4411 2008-04-07 Marek Safar <marek.safar@gmail.com>
4413 A fix for bug #377485
4414 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4415 Propagate location for extension method groups. Report conversion failure at
4418 2008-04-07 Marek Safar <marek.safar@gmail.com>
4420 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4421 ListInit and Field expressions.
4423 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4425 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4426 Since $PC is always -1 inside the body of MoveNext, the fault
4428 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4429 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4430 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4432 The denouement! Fix #324708
4433 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4434 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4435 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4436 'finally' inside the finally clause.
4438 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4439 inside an iterator. Don't emit the body of the 'finally' inside
4440 the finally clause yet.
4442 Use the ResumableStatement infrastructure for MoveNext ()
4443 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4444 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4445 'old_resume_points'. Move dispatcher upfront.
4446 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4447 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4448 in an enumerator. This encodes the main fix in this patch series
4449 -- we can only jump into the first instruction of a try from the
4450 outside, but we want to emit try/finally regions in iterators and
4451 resume in the middle of them.
4453 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4455 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4456 of NeedReturnLabel here.
4458 Introduce a common point for emitting try/finally to IL
4459 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4460 features of the various subclasses, which are now driven by ...
4461 (ExceptionStatement.EmitPreTryBody): ... this and ...
4462 (ExceptionStatement.EmitTryBody): ... this and the original
4464 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4465 Remove DoEmit and update to follow above protocol.
4467 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4468 of the dispatcher are the same, skip emitting the 'switch'.
4469 * iterator.cs (Iterator.EmitDispose): Update to changes.
4471 Clean up handling of 'using' statement
4472 * statement.cs (UsingTemporary): New. Carved out of ...
4473 (Using): ... this. Simplify drastically. Handle exactly
4475 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4476 or Using as appropriate. If there are multiple variable declared,
4477 create nested Using statements.
4478 (resource_acquisition): Kill.
4480 * statement.cs (ExceptionStatement.EmitForDispose): Use
4481 EmitFinallyBody, not EmitFinally.
4483 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4484 * iterator.cs: Update to changes.
4486 Start using the ResumableStatement infrastructure
4487 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4488 (ResumableStatement.EmitForDispose): New.
4489 (ExceptionStatement): Override them.
4490 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4491 EmitForDispose to create the body of the Dispose method. Don't
4494 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4495 * statement.cs (Toplevel.AddResumePoint): ... here.
4496 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4497 * flowanalysis.cs (FlowBranchingIterator): New.
4498 * codegen.cs (EmitContext): Update to changes.
4500 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4501 (Iterator.old_resume_points): Rename from 'resume_points'.
4502 (Iterator.MoveNextStatement): Remove unused class.
4504 New infrastructure for try/finally in iterators (still unused)
4505 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4506 (FlowBranchingToplevel.AddResumePoint): Hook into
4507 ToplevelBlock.AddResumePoint.
4508 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4509 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4510 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4511 resume points and assign program-counter values.
4512 (ExceptionBlock.AddResumePoint): Collect resume points for
4513 de-muxer at the top of try block.
4514 * iterators.cs (Yield.CheckContext): Simplify.
4515 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4517 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4519 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4520 argument to an ExitStatement.
4521 (FlowBranchingException): Refactor saved origins code.
4522 * statement.cs (ExitStatement): Update to cahges.
4523 * iterator.cs (YieldBreak): Likewise.
4525 * statement.cs (ResumableStatement): New. Common base class for
4526 YieldReturn and ExceptionStatement.
4527 (ExitStatement): New. Common base class for Return and YieldBreak.
4528 (Return): Update to changes.
4529 * iterator.cs (YieldBreak): Likewise.
4530 * lambda.cs (ContextualReturn): Likewise.
4533 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4534 emit a meaningful error message.
4536 Fix #324765, #319508
4537 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4538 (VariableInfo.SetAssigned): Set it.
4539 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4540 determine if CS0219 or CS0168 is appropriate. Don't use
4541 flow-analysis information.
4542 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4543 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4544 (EmitContext.EndFlowBranching): ... this.
4546 2008-04-03 Marek Safar <marek.safar@gmail.com>
4548 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
4550 2008-04-03 Marek Safar <marek.safar@gmail.com>
4552 A fix for bug #376508
4553 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
4554 ImplicitConversionExists.
4556 2008-04-03 Marek Safar <marek.safar@gmail.com>
4558 * expression.cs (Binary): Added remaining binary operators to expression
4561 * nullable.cs: Optimize shift with null argument.
4563 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
4565 Fix minor IL regression
4566 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
4567 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
4568 * cs-parser.jay (try_statement): Update to changes.
4570 * statement.cs (TryFinally.need_exc_block): Delete.
4571 (TryFinally): Update to changes.
4573 Now all ExceptionStatements are unconditional
4574 * statement.cs (CollectionForeach.DisposableWrapper): New.
4575 Extract out the try/finally code into a new wrapper.
4576 (CollectionForeach.Resolve): Use it to simplify the code.
4578 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
4580 Start at simplifying ExceptionStatement semantics a bit
4581 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
4582 * cs-parser.jay (try_statement): Update to changes.
4583 (opt_catch_clauses): Remove.
4584 * flowanalysis.cs: Update to changes.
4585 (FlowBranching.BranchingType.TryCatch): New.
4586 (FlowBranchingTryCatch): New.
4588 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
4589 (FlowBranching.CreateBranching): Update to changes.
4590 (FlowBranchingBlock.AddSibling): Add sanity check.
4591 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
4594 * iterators.cs (Iterator.MarkFinally): Remove.
4595 * statement.cs (ExceptionStatement): Update to changes.
4597 Add support for skipping over finally blocks at runtime. First
4598 in a series to fix #324708
4599 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
4600 (Iterator.EmitMoveNext): Initialize it.
4601 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
4602 branch over the body of the 'finally' clause.
4604 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
4606 Avoid lopsided use of Foo/DoFoo names
4607 * statement.cs (ExpressionStatement.EmitFinallyBody):
4608 Rename from EmitFinally.
4609 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
4610 * iterator.cs: Update to changes.
4612 2008-04-02 Marek Safar <marek.safar@gmail.com>
4614 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
4615 based on UserOperatorCall. More binary nullable operators clean up.
4617 2008-04-02 Martin Baulig <martin@ximian.com>
4619 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
4621 2008-04-02 Marek Safar <marek.safar@gmail.com>
4623 * nullable.cs: Merge user and empty conversions when lifting expression
4626 * expression.cs (StringConcat): Implemented expression tree representation.
4628 2008-04-01 Marek Safar <marek.safar@gmail.com>
4630 * nullable.cs: When lifting null literal and a user operator exists, no call
4633 2008-04-01 Marek Safar <marek.safar@gmail.com>
4635 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
4638 2008-04-01 Marek Safar <marek.safar@gmail.com>
4640 * nullable.cs, expression.cs: Use namespace instead heavily nested
4641 monster abstract class.
4643 2008-04-01 Marek Safar <marek.safar@gmail.com>
4645 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
4646 lifting of null literal and user operators. Clean up of some temporary
4649 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
4651 Fix #368224, test-629.cs
4652 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
4653 if it crossed an unwind-protect boundary.
4654 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
4655 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
4656 inside an unwind-protected region.
4657 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
4658 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
4659 'leave' instead of a 'br' if unwind-protected.
4660 (Iterator.EmitYieldBreak): Likewise.
4662 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
4664 * driver.cs: Only define versioninfo resources if no win32 resource
4667 2008-03-28 Marek Safar <marek.safar@gmail.com>
4669 A fix for bug #372375
4670 * convert.cs: Fixed boxing of nullable types.
4672 2008-03-28 Marek Safar <marek.safar@gmail.com>
4674 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
4677 2008-03-28 Marek Safar <marek.safar@gmail.com>
4679 A fix for bug #374619
4680 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
4682 2008-03-27 Marek Safar <marek.safar@gmail.com>
4684 * lambda.cs: Check return type only for invocation.
4686 2008-03-27 Marek Safar <marek.safar@gmail.com>
4688 A fix for bug #374214
4689 * ecore.cs: Correctly report argument type mismatch.
4691 2008-03-27 Marek Safar <marek.safar@gmail.com>
4693 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
4694 and not rely on broken IsEnum.
4696 2008-03-27 Marek Safar <marek.safar@gmail.com>
4698 * nullable.cs: New file, extracted from generic.cs.
4700 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
4702 2008-03-27 Marek Safar <marek.safar@gmail.com>
4704 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
4705 predefined comparison operators and null literals.
4707 * report.cs: New warning ID.
4709 2008-03-25 Marek Safar <marek.safar@gmail.com>
4711 A fix for bug #370577
4712 * lambda.cs: Check return type too.
4714 2008-03-25 Marek Safar <marek.safar@gmail.com>
4716 A fix for bug #372846
4717 * class.cs: Automatic properties can be declared as unsafe.
4719 2008-03-20 Marek Safar <marek.safar@gmail.com>
4721 * location.cs: Use string based concatenation.
4723 * expression.cs: LiftedBinaryOperator is gmcs only.
4725 2008-03-20 Marek Safar <marek.safar@gmail.com>
4727 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
4728 conversions rules and expression trees.
4730 2008-03-19 Marek Safar <marek.safar@gmail.com>
4732 * delegate.cs: Use extension method source as delegate target.
4734 2008-03-19 Marek Safar <marek.safar@gmail.com>
4736 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
4737 binary operations to be purely based on binary operations and optimized
4738 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
4739 and other ET refactoring.
4741 * typemanager.cs: Fixed warning.
4743 2008-03-17 Marek Safar <marek.safar@gmail.com>
4745 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
4747 * symbolwriter.cs: Fixed.
4749 2008-03-17 Marek Safar <marek.safar@gmail.com>
4751 * anonymous.cs, driver.cs: Reset anonymous types counters.
4753 2008-03-17 Marek Safar <marek.safar@gmail.com>
4755 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
4757 * class.cs: Use fullname for all type member definitions.
4759 2008-02-19 Martin Baulig <martin@ximian.com>
4762 (IMethodData.EmitExtraSymbolInfo): New interface method.
4763 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
4764 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
4765 interface method here as an empty public virtual method.
4768 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
4769 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
4770 CodeGen.SymbolWriter.SetRealMethodName().
4772 2008-02-18 Martin Baulig <martin@ximian.com>
4775 (ScopeInfo.EmitType): Override this and emit debugging
4776 information for captured variables.
4777 (RootScopeInfo.EmitType): Override this and emit symbol
4778 information for a captured `this'.
4780 2008-02-15 Martin Baulig <martin@ximian.com>
4782 * iterators.cs: Emit debugging info.
4785 (EmitContext.Flags): Add `OmitDebuggingInfo'.
4786 (EmitContext.OmitDebuggingInfo): New public property.
4789 (While): Override Emit() and don't emit symbol info there; do it
4790 inside DoEmit() instead.
4791 (Block.Emit): Omit symbol information while emitting the scope
4792 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
4794 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
4795 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
4796 .ctor to make `IsIterator' work.
4798 2008-03-14 Martin Baulig <martin@ximian.com>
4800 * symbolwriter.cs: Added the new symbol writer function from the
4801 debugger's `terrania' branch; temporarily enclose them inside
4802 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
4805 2008-03-14 Martin Baulig <martin@ximian.com>
4808 (SymbolWriter): Make this a public static class.
4811 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
4812 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
4814 2008-03-14 Marek Safar <marek.safar@gmail.com>
4816 A fix for bug #370577
4817 * statement.cs, lambda.cs: Added extra limitations when dealing with void
4820 2008-03-14 Marek Safar <marek.safar@gmail.com>
4822 * typemanager.cs (CSharpName): Made 250 times faster.
4824 2008-03-13 Marek Safar <marek.safar@gmail.com>
4826 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
4828 2008-03-12 Marek Safar <marek.safar@gmail.com>
4830 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
4831 crash when predefined field does not exist.
4833 2008-03-12 Marek Safar <marek.safar@gmail.com>
4835 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
4837 2008-03-12 Marek Safar <marek.safar@gmail.com>
4839 * class.cs (FixedField): Don't crash when contructors are missing.
4841 2008-03-11 Marek Safar <marek.safar@gmail.com>
4843 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
4844 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
4845 check internal types accessibility for internal and external types.
4846 Replaced EnumToUnderlying by GetEnumUnderlyingType.
4848 2008-03-11 Marek Safar <marek.safar@gmail.com>
4850 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
4851 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
4852 attribute.cs, statement: Use corect instance of predefined types (work
4853 related to #364674).
4855 2008-03-07 Marek Safar <marek.safar@gmail.com>
4857 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
4859 2008-03-07 Marek Safar <marek.safar@gmail.com>
4861 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
4862 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
4863 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
4864 predefined types clean up, delayed predefined types members initialization
4865 (work related to #364674).
4867 2008-03-05 Marek Safar <marek.safar@gmail.com>
4869 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
4871 2008-03-05 Marek Safar <marek.safar@gmail.com>
4873 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
4874 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
4875 predefined types clean up (work related to #364674).
4877 2008-03-04 Marek Safar <marek.safar@gmail.com>
4879 * ecore.cs: Print an error message instead of throwing exception.
4881 2008-03-04 Marek Safar <marek.safar@gmail.com>
4883 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
4884 expression.cs, statement.cs: Unififed null literal representation.
4886 2008-03-03 Marek Safar <marek.safar@gmail.com>
4888 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
4889 expression.cs: Refactored binary operators resolve phase and improved speed.
4890 The nullable code is still missing and won't work correctly, more fixes
4893 It also fixes #323726, #324312, #324248, and many other unreported issues.
4895 2008-02-29 Zoltan Varga <vargaz@gmail.com>
4897 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
4900 2008-02-27 Marek Safar <marek.safar@gmail.com>
4902 * ecore.cs: Clean-up and split BetterConversion.
4904 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
4907 * enum.cs (EnumMember.Value): Only access 'value' if
4908 ResolveValue says it's ok.
4909 (EnumMember.DoResolveValue): Don't set prev_member.value.
4910 (Enum.GetDefinition): Reverse arguments of Equals --
4911 EnumMember.Value can return 'null'.
4913 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
4915 2008-02-22 Marek Safar <marek.safar@gmail.com>
4917 * generic.cs, expression.cs: More ongoing work on expression trees.
4919 2008-02-21 Marek Safar <marek.safar@gmail.com>
4921 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
4922 handle missing matches when mutiple operators exist.
4924 2008-02-20 Marek Safar <marek.safar@gmail.com>
4926 A fix for bug #363218
4927 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
4930 2008-02-20 Marek Safar <marek.safar@gmail.com>
4932 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
4933 update. This time to deal correctly with SideEffectConstant expression used
4934 as an argument for another constant folding.
4936 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
4938 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
4941 2008-02-19 Marek Safar <marek.safar@gmail.com>
4943 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
4945 2008-02-19 Marek Safar <marek.safar@gmail.com>
4947 A fix for bug #328136
4948 * expression.cs: Do not fold immediately LogicalAnd operators when the left
4949 side is a false constant, because we still need to evaluate the right-hand
4952 * statement.cs (If): Emit two types of boolean constants (simple constant,
4953 side-effect constant).
4955 2008-02-19 Marek Safar <marek.safar@gmail.com>
4957 * constant.cs (SideEffectConstant): Don't emit boolean constant.
4959 * expression.cs: Fold immediately LogicalAnd operators when both sides are
4962 2008-02-18 Marek Safar <marek.safar@gmail.com>
4964 A fix for bug #361457
4965 * ecore.cs (IsApplicable): Params methods have lower priority.
4967 * support.cs: Return correct parameter modifier for params types.
4969 2008-02-18 Marek Safar <marek.safar@gmail.com>
4971 * generic.cs (TypeParameter): Cache attribute target name.
4973 * support.cs: Removed unused variable.
4975 * typemanager.cs: Removed debugging leftover.
4977 * ecore.cs: Use local type instead of a property;
4979 * class.cs (VerifyMembers): Consider also parent to test whether type member
4982 * expression.cs (FullMethodDesc): Removed.
4984 * attribute.cs (IsValidArgumentType): Made static.
4986 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
4988 Cleanup to be more readable.
4989 * Makefile (GMCS_PROFILE): Remove.
4990 (COMPILER_NAME): New helper.
4992 2008-02-15 Miguel de Icaza <miguel@novell.com>
4994 * cs-tokenizer.cs: if a conditional expression happens inside a
4995 (...) this also means that we do not need to de-ambiguate between
4996 an parenthesized expression and a cast.
5000 * constant.cs (SideEffectConstant): a constant value that happens
5001 to have a side effect.
5003 Fixes the build regressions introduced by the fix for #359789
5005 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5007 * expression.cs (Conditional.Emit): when emitting the ternary
5008 operator, use local variables to generate code verifiable code.
5010 The verifier cannot infer that the type on stack before the
5011 stloc.0 is executed is of type ParentB. This happens because the
5012 stack merge algorithm uses only parent types when deciding which
5013 is the common type. This is described in Part III 1.8.1.3 of ECMA
5016 This code compiled with mcs is not verifiable under MS. The MS
5017 verifier picks the first common interface of Foo and Bar, which is
5018 wrong, but doesn't use a full join type of the 2 interfaces.
5020 CSC uses a clever hack to compile such code in a verifiable
5021 way. It stores the intermediate values in a local variable with
5026 2008-02-14 Miguel de Icaza <miguel@novell.com>
5028 * expression.cs: Do not fold BitwiseAnd operators when the left
5029 side is a false constant, because we still need to evaluate the
5034 * support.cs: Instead of throwing an InternalErrorException when
5035 the position of the stream is outside the boundary of our buffer,
5036 reset the state of the reader, and restart the reading from the
5037 beginning of the file.
5039 2008-02-14 Marek Safar <marek.safar@gmail.com>
5041 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5043 2008-02-14 Marek Safar <marek.safar@gmail.com>
5045 A fix for bug #361686
5046 * decl.cs: A protected types used inside a private class which parents
5047 derives from the protected class are accessible.
5049 2008-02-13 Marek Safar <marek.safar@gmail.com>
5051 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5052 the parameterless constructor.
5054 2008-02-13 Marek Safar <marek.safar@gmail.com>
5056 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5057 lookup methods to use standard member cache when doing member lookup.
5059 2008-02-12 Marek Safar <marek.safar@gmail.com>
5061 * driver.cs: Don't report full path for referenced module as assembly error.
5063 2008-02-12 Marek Safar <marek.safar@gmail.com>
5065 * Makefile: Fixed `qh' target to work on all machines.
5067 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5068 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5069 and HasElementType with TypeManager implementation.
5071 2008-02-08 Marek Safar <marek.safar@gmail.com>
5073 A fix for bugs #325134, #359749
5074 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5075 first binds point to non-method member expression.
5077 2008-02-08 Marek Safar <marek.safar@gmail.com>
5079 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5081 2008-02-08 Marek Safar <marek.safar@gmail.com>
5083 A fix for bugs #321394, #323028
5084 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5085 Reworked naive IsAccessibleAs implementation to handle nested types.
5087 2008-02-05 Jb Evain <jbevain@novell.com>
5089 * class.cs: use generic type comparison for parameters
5092 2008-02-05 Marek Safar <marek.safar@gmail.com>
5094 A fix for bug #325372
5095 * class.cs: Use generic type comparison when testing method signatures.
5097 2008-02-05 Marek Safar <marek.safar@gmail.com>
5099 A fix for bug #357047
5100 * ecore.cs: Applied C# 3.0 changes to better conversion.
5102 2008-02-05 Marek Safar <marek.safar@gmail.com>
5104 A fix for bug #358374
5105 * cs-parser.jay: Correctly set modifiers for all constructor types.
5107 2008-02-04 Marek Safar <marek.safar@gmail.com>
5109 A fix for bug #355251
5110 * generic.cs: Added base class constraint based type inference.
5112 2008-02-01 Marek Safar <marek.safar@gmail.com>
5114 A fix for bug #357255
5115 * decl.cs: One more missing visibility check.
5117 2008-02-01 Marek Safar <marek.safar@gmail.com>
5119 * support.cs: Fixed broken return.
5121 2008-01-25 Marek Safar <marek.safar@gmail.com>
5123 * report.cs: Correctly reset warnings count after probing.
5125 2008-01-25 Martin Baulig <martin@ximian.com>
5128 (NamespaceEntry.SymbolFileID): Make this work again after
5129 MemberName.ToString() is gone.
5131 2008-01-25 Marek Safar <marek.safar@gmail.com>
5133 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5136 2008-01-25 Marek Safar <marek.safar@gmail.com>
5138 * generic.cs: Use full implicit conversion for type inference fixing.
5140 2008-01-24 Marek Safar <marek.safar@gmail.com>
5142 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5143 Fixed user operator conversions.
5145 2008-01-24 Marek Safar <marek.safar@gmail.com>
5147 * generic.cs: Do nullable type to null comparison optimization during
5150 2008-01-24 Marek Safar <marek.safar@gmail.com>
5152 A fix for bug #355163
5153 * generic.cs: Enabled l-value resolve on nullable expressions.
5155 2008-01-24 Marek Safar <marek.safar@gmail.com>
5157 A fix for bug #353986
5158 * class.cs: Ingore static ctors with parameters for any further checks.
5160 2008-01-24 Marek Safar <marek.safar@gmail.com>
5162 A fix for bug #354310
5163 * namespace.cs: Removed redundant check.
5165 2008-01-24 Marek Safar <marek.safar@gmail.com>
5167 A fix for bug #354928
5168 * expression.cs: ElementInitializers can be resolved only once.
5170 2008-01-24 Marek Safar <marek.safar@gmail.com>
5172 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5173 Condition expressions.
5175 2008-01-23 Marek Safar <marek.safar@gmail.com>
5177 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5179 2008-01-22 Marek Safar <marek.safar@gmail.com>
5181 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5184 * generic.cs: Implemented coalesce expression.
5186 2008-01-22 Marek Safar <marek.safar@gmail.com>
5188 A fix for bug #355145
5189 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5190 expression tree type inference.
5192 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5195 * expression.cs (Binary.IsUnsignedType): Fix typo.
5197 2008-01-22 Marek Safar <marek.safar@gmail.com>
5199 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5201 2008-01-22 Marek Safar <marek.safar@gmail.com>
5203 A fix for bug #355161
5204 * ecore.cs, expression.cs: Wider range of extension method supported
5207 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5209 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5210 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5213 2008-01-22 Marek Safar <marek.safar@gmail.com>
5215 A fix for bug #355148
5216 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5218 2008-01-22 Miguel de Icaza <miguel@novell.com>
5220 * expression.cs (CreateExpressionTree): Add support for or and
5221 logical or, and indent following the coding conventions.
5223 * typemanager.cs (LinqExpression): renamed from
5224 ExpressionTreeManager, for a shorter name.
5226 Use TypeManager.CoreLookupType to lookup types from our core
5227 assemblies and turn those into "Type" variables.
5229 Consumers that previously used "Namespace" and "Type" from this
5230 class should instead use the TypeExpression which is a type that
5231 is fully resolved (without involving the regular C# resolution
5234 This typically looks like this:
5236 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5237 new MemberAccess (texpr, name, type_arguments, loc)
5239 This avoids the problem in: #355178
5241 2008-01-21 Marek Safar <marek.safar@gmail.com>
5243 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5244 feature in parser only as we do in other cases.
5246 2008-01-21 Marek Safar <marek.safar@gmail.com>
5248 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5249 typemanager.cs: A refactoring of params arguments to reuse existing
5250 expressions (params -> array initializer) to emit params argument instead
5251 of specialized handling.
5252 It was required by expression tree implementation and it has other benefits
5253 as well, we now apply same optimization for params arguments as we do for
5256 2008-01-18 Marek Safar <marek.safar@gmail.com>
5258 A fix for bug #353526
5259 * generic.cs: A type inference of params arguments may not required any
5260 temporary array creation.
5262 2008-01-18 Marek Safar <marek.safar@gmail.com>
5264 A fix for bug #353534
5265 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5266 supported for delegates only.
5268 2008-01-18 Marek Safar <marek.safar@gmail.com>
5270 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5271 type for more than 1 candidates.
5273 2008-01-18 Marek Safar <marek.safar@gmail.com>
5275 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5278 2008-01-16 Marek Safar <marek.safar@gmail.com>
5280 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5281 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5282 operator) expressions.
5284 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5286 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5287 not accessed from the generated IL.
5289 2008-01-14 Marek Safar <marek.safar@gmail.com>
5291 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5292 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5293 statement.cs: The first expression tree implementation drop, mostly
5294 infrastructure work.
5296 2008-01-14 Marek Safar <marek.safar@gmail.com>
5298 * ecore.cs (IsNestedChild): Refactored.
5300 2008-01-11 Marek Safar <marek.safar@gmail.com>
5302 * lambda.cs: Don't use a cast on unknown expression statement.
5304 2008-01-10 Geoff Norton <gnorton@novell.com>
5306 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5309 2008-01-09 Marek Safar <marek.safar@gmail.com>
5311 * doc.cs: Report better /doc crash details.
5313 2008-01-09 Marek Safar <marek.safar@gmail.com>
5315 A fix for bug #352536
5316 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5318 2008-01-08 Marek Safar <marek.safar@gmail.com>
5320 A fix for bug #352287
5321 * ecore.cs, expression.cs: Do `this' access checking in all member access
5324 2008-01-08 Marek Safar <marek.safar@gmail.com>
5326 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5328 * report.cs: Reset message stacks.
5330 2008-01-08 Marek Safar <marek.safar@gmail.com>
5332 * generic.cs (InferInPhases): Correctly calculate params position.
5334 2008-01-08 Marek Safar <marek.safar@gmail.com>
5336 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5339 2008-01-07 Marek Safar <marek.safar@gmail.com>
5341 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5343 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5345 * driver.cs: Updated --help option.
5347 2008-01-07 Marek Safar <marek.safar@gmail.com>
5349 * generic.cs (InferParamsTypeArguments): Removed.
5350 (InferInPhases): Add params type inference.
5351 (LowerBoundInference): Fixed scoring mechanism.
5353 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5355 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5357 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5358 byte array for unsigned "baked" assemblies.
5360 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5362 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5363 array for assemblies that are not strongnamed.
5365 2008-01-04 Marek Safar <marek.safar@gmail.com>
5367 A fix for bug #351481
5368 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5369 declaring type for nested generic types.
5371 2008-01-04 Marek Safar <marek.safar@gmail.com>
5373 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5374 instead of ToString.
5376 2008-01-03 Marek Safar <marek.safar@gmail.com>
5378 A fix for bug #351047
5379 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5380 null and structs only when equality and inequality operators are defined
5381 either as an user-operators or predefined operators.
5383 2008-01-03 Marek Safar <marek.safar@gmail.com>
5385 A fix for bug #351047
5386 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5388 2008-01-03 Marek Safar <marek.safar@gmail.com>
5390 A fix for bug #351257
5391 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5393 2008-01-03 Marek Safar <marek.safar@gmail.com>
5395 A fix for bug #351157
5396 * class.cs (Using): Fixed yet another broken cloning.
5398 (Block): Put back more sensible default value for statements.
5400 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5402 * codegen.cs: Allow AssemblyVersion with only major version component.
5405 2007-12-29 Marek Safar <marek.safar@gmail.com>
5407 A fix for bug #324654
5408 * class.cs: Use FullName property as member name.
5410 2007-12-28 Marek Safar <marek.safar@gmail.com>
5412 A fix for bug #342117
5413 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5414 constructor constraint.
5416 2007-12-28 Marek Safar <marek.safar@gmail.com>
5418 A fix for bug #338273
5419 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5422 2007-12-28 Marek Safar <marek.safar@gmail.com>
5424 A fix for bug #350839
5425 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5427 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5429 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5432 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5434 * statement.cs: Changed some Hashtables to use HybridDictionaries
5435 instead. It was observed that some HashTables only contained a few
5436 items in the vast majority of cases. Since HybridDictionary is
5437 more efficient on small sets (<10 elements), "known_variables"
5438 from class ExplicitBlock as well as "labels" and "constants " from
5439 class Block were changed to HybridDictionaries.
5441 Atsai results: (56216kb->54987kb)
5443 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5446 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5448 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5451 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5453 * expression.cs: foreach loop to for loop, saved on allocation of
5454 enumerator (59333kb->59141kb)
5456 * statement.cs. Changed foreach loops to for loops, saved on
5457 allocation of enumerator (59141kb->59006kb)
5459 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5460 when constructed with no specified capacity. This was causing a
5461 few ArrayLists to allocate more memory than they would potentially
5462 need in the Block class and MemberCache class. Setting the
5463 ArrayLists to construct with a capacity of 1 saves some
5464 memory. (56216kb->55585kb)
5466 2007-12-27 Marek Safar <marek.safar@gmail.com>
5468 A fix for bug #347189 (2nd issue)
5469 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5472 2007-12-27 Miguel de Icaza <miguel@novell.com>
5474 * report.cs: Do not use colors if stdout and stderr are not a
5477 2007-12-27 Marek Safar <marek.safar@gmail.com>
5479 A fix for bug #346998
5480 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5483 2007-12-27 Marek Safar <marek.safar@gmail.com>
5485 A fix for bug #343465
5486 * class.cs: Explicit method name for nested types uses dots only.
5488 2007-12-27 Marek Safar <marek.safar@gmail.com>
5490 A fix for bug #343707
5491 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5493 2007-12-27 Marek Safar <marek.safar@gmail.com>
5495 * ecore.cs: Report type inference errors only when arguments count matches
5498 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5500 * expression.cs, report.cs: New warning.
5502 * typemanager.cs: Catch anonymous method type too.
5504 2007-12-23 Marek Safar <marek.safar@gmail.com>
5506 A fix for bug #346379
5507 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5509 2007-12-23 Marek Safar <marek.safar@gmail.com>
5511 A fix for bug #347359
5512 * expression.cs (Invocation): Don't resolve already resolved expression.
5514 2007-12-23 Marek Safar <marek.safar@gmail.com>
5516 A fix for bug #347189
5517 * class.cs (FixedField): Use non-dependent code only in the define phase.
5519 2007-12-23 Marek Safar <marek.safar@gmail.com>
5521 A fix for bug #348076
5522 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5524 2007-12-22 Marek Safar <marek.safar@gmail.com>
5526 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5527 discovered extension methods.
5529 2007-12-22 Marek Safar <marek.safar@gmail.com>
5531 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5534 2007-12-21 Miguel de Icaza <miguel@novell.com>
5536 * report.cs (ErrorMessage): Add support for using colors on
5537 terminals that support it.
5539 2007-12-21 Marek Safar <marek.safar@gmail.com>
5541 * ecore.cs: Use information about expanded params for error reporting.
5543 2007-12-21 Marek Safar <marek.safar@gmail.com>
5545 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5546 and logic for params overloads.
5548 2007-12-15 Miguel de Icaza <miguel@novell.com>
5550 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
5551 as this is also created from the parser. Fixes #349034
5553 2007-12-12 Miguel de Icaza <miguel@novell.com>
5555 * statement.cs (Throw.CloneTo): it is valid to have empty
5556 expressions for throw.
5558 2007-12-03 Marek Safar <marek.safar@gmail.com>
5560 * cs-parser.jay: Set delegate constraint parsing region correctly.
5562 2007-12-03 Marek Safar <marek.safar@gmail.com>
5564 A fix for bug #345467
5565 * typemanager.cs (IsEqual): Compare generic parameters position only.
5567 2007-11-28 Marek Safar <marek.safar@gmail.com>
5569 * expression.cs (BaseAccess): Type arguments can be null.
5571 2007-11-27 Raja R Harinath <harinath@gmail.com>
5573 * statement.cs (Block.Resolve): Ensure flow-branching tree is
5574 consistent even when an error has occured.
5575 (Switch.Resolve): Likewise.
5577 2007-11-22 Marek Safar <marek.safar@gmail.com>
5579 A fix for bug #334505
5580 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
5583 2007-11-22 Marek Safar <marek.safar@gmail.com>
5585 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
5586 refactorings required to resolve extension methods correctly when mixing
5587 generics and non-generics members.
5589 2007-11-20 Marek Safar <marek.safar@gmail.com>
5591 A fix for bug #342584
5592 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
5595 2007-11-19 Marek Safar <marek.safar@gmail.com>
5597 A fix for bug #342512
5598 * delegate.cs: Use delegate argument expression when is available. Don't
5599 emit virtual call when class is sealed.
5601 2007-11-16 Marek Safar <marek.safar@gmail.com>
5603 A fix for bug #325423
5604 * assign.cs (FieldInitializer): Use resolved expression for emit.
5606 * class.cs: Print less confusing error message.
5608 2007-11-16 Marek Safar <marek.safar@gmail.com>
5610 * cs-tokenizer.cs: Removed GMCS ifdefs.
5612 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
5615 * cs-parser.jay: Disabled nullable check.
5617 * generic-mcs: Copied more generic stuff.
5619 2007-11-16 Marek Safar <marek.safar@gmail.com>
5621 * gcs-parser.jay: Merged to cs-parser.jay.
5623 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
5624 * *.csproj, *.sources: Updated to use only jay parser file.
5626 2007-11-16 Marek Safar <marek.safar@gmail.com>
5628 * gcs-parser.jay: Added nullable and default expression feature checks.
5630 2007-11-16 Marek Safar <marek.safar@gmail.com>
5632 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
5633 it fixes many TODOs and hidden bugs.
5635 * expression: Removed duplicate error check.
5637 2007-11-15 Marek Safar <marek.safar@gmail.com>
5639 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
5640 implicitly type local variable only when it is used in a declaration.
5642 2007-11-15 Marek Safar <marek.safar@gmail.com>
5644 * attribute.cs: Use CS0612 for empty strings.
5646 2007-11-14 Marek Safar <marek.safar@gmail.com>
5648 * lambda.cs, statement.cs: Contextual return may act as a statement.
5650 2007-11-14 Marek Safar <marek.safar@gmail.com>
5652 A fix for a regression cause by #324222
5653 * class.cs: Don't report unused even when it implements an interface.
5655 2007-11-13 Marek Safar <marek.safar@gmail.com>
5657 A fix for bug #341205
5658 * ecore.cs, expression.cs: Method group expression cannot do static
5659 method access with an instance reference check before overloading takes
5662 2007-11-13 Marek Safar <marek.safar@gmail.com>
5664 A fix for bug #325359
5665 * class.cs: Use predictable name for automatically generated property.
5667 2007-11-12 Marek Safar <marek.safar@gmail.com>
5669 A fix for bug #324996
5670 * expression.cs (Is): Handle case where D is nullable and T is not
5673 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
5675 2007-11-12 Marek Safar <marek.safar@gmail.com>
5677 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
5678 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
5679 Flush small error reporting changes.
5681 2007-11-09 Marek Safar <marek.safar@gmail.com>
5683 A fix for bug #324996
5684 * expression.cs: Rewrote Is expression implementation to work with
5685 generics, nullable types, anonymous method. A const result expression
5686 uses existing infrastructure instead of custom not fully-featured one.
5688 2007-11-08 Marek Safar <marek.safar@gmail.com>
5690 A fix for bug #340202
5691 * class.cs: Consider generics for volatile field.
5693 2007-11-08 Marek Safar <marek.safar@gmail.com>
5695 A fix for bug #335594
5696 * expression.cs: Use conversion rules when handling string addition.
5698 2007-11-07 Marek Safar <marek.safar@gmail.com>
5700 A fix for bug #336651
5701 * expression.cs: Fixed a crash when probing is on.
5703 2007-11-07 Marek Safar <marek.safar@gmail.com>
5705 A fix for bug #324242
5706 * covert.cs: Added a conversion from any nullable-type with an
5707 underlying enum-type to the type System.Enum.
5709 2007-11-07 Marek Safar <marek.safar@gmail.com>
5711 A fix for bug #324222
5712 * class.cs: Report all non-used event fields.
5714 2007-11-07 Marek Safar <marek.safar@gmail.com>
5716 A fix for bug #325161
5717 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
5718 qualifier for generic types.
5720 2007-11-07 Marek Safar <marek.safar@gmail.com>
5722 A fix for bug #322971
5723 * expression.cs, ecore.cs: Added intermediate result value check for
5726 2007-11-07 Marek Safar <marek.safar@gmail.com>
5728 A fix for bug #324754
5729 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
5730 when it was requested.
5732 2007-11-07 Marek Safar <marek.safar@gmail.com>
5734 A fix for bug #325101
5735 * expression.cs: Do type not value comparison for `is' expression.
5737 2007-11-07 Marek Safar <marek.safar@gmail.com>
5739 A fix for bug #320236
5740 * convert.cs: Don't apply user conversion on underlying target type.
5742 2007-11-06 Marek Safar <marek.safar@gmail.com>
5744 * expression.cs: Don't use unresolved expression for error reporting.
5746 2007-11-06 Marek Safar <marek.safar@gmail.com>
5748 A fix for bugs #337712, #324490
5749 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
5750 overloading resolution too.
5752 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
5753 the process consistent and more robust.
5755 * expression.cs, linq.cs, report.cs: Update.
5757 2007-11-02 Marek Safar <marek.safar@gmail.com>
5759 A fix for bug #332909
5760 * attribute.cs: Resolve attributes in correct context using error
5763 * rootcontext.cs: Define Obsolete attribute members as core members.
5765 2007-11-02 Marek Safar <marek.safar@gmail.com>
5767 * statement.cs: Removed unused methods.
5769 2007-10-31 Wade Berrier <wberrier@novell.com>
5771 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
5772 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
5775 2007-10-31 Marek Safar <marek.safar@gmail.com>
5777 A fix for bug #338102
5778 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
5779 methods registered as non-generics.
5781 2007-10-31 Marek Safar <marek.safar@gmail.com>
5783 A fix for bugs #337712, #324490
5784 * delegate.cs: Delegate covariance and contravariance is not allowed for
5787 2007-10-31 Marek Safar <marek.safar@gmail.com>
5789 A fix for bug #337719
5790 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
5793 2007-10-30 Marek Safar <marek.safar@gmail.com>
5795 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
5797 2007-10-29 Marek Safar <marek.safar@gmail.com>
5799 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
5802 2007-10-29 Raja R Harinath <rharinath@novell.com>
5804 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
5806 2007-10-29 Marek Safar <marek.safar@gmail.com>
5808 A fix for bug #334652
5809 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
5810 extension methods when we have not found the best candidate in normal
5813 2007-10-27 Marek Safar <marek.safar@gmail.com>
5815 * AssemblyInfo.cs: Keep up-to-date.
5817 2007-10-27 Marek Safar <marek.safar@gmail.com>
5819 * Makefile: Fixed generics compiler name.
5821 2007-10-27 Marek Safar <marek.safar@gmail.com>
5823 * lambda.test: removed, lambda parsing is done differently.
5825 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
5827 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
5829 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
5831 2007-10-27 Marek Safar <marek.safar@gmail.com>
5833 * Makefile, *.sources : All C# compilers are in mcs folder.
5835 * *.cs: Use existing 2_1 define for smcs.
5837 2007-10-26 Marek Safar <marek.safar@gmail.com>
5839 A fix for bug #335847
5840 * assign.cs, expression.cs: Couple of changes to avoid creating a
5841 temporary variable for each object initializer assignment statement. It
5842 simplifies struct initialization too, otherwise two temporary variables
5844 Implemented optimization of redundant default element initializers.
5846 2007-10-25 Marek Safar <marek.safar@gmail.com>
5848 A fix for bug #336766
5849 * expression.cs (Class.CheckBase): Use generic name when method is
5852 2007-10-25 Marek Safar <marek.safar@gmail.com>
5854 A fix for bug #334737
5855 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
5856 variable and not variable argument for prepared copies.
5858 2007-10-24 Marek Safar <marek.safar@gmail.com>
5860 A fix for bug #325110
5861 * class.cs, expression.cs, attribute.cs: Use open generic method when
5862 checking conditional attribute.
5864 2007-10-24 Marek Safar <marek.safar@gmail.com>
5866 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
5867 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
5868 FeatureIsNotAvailable.
5870 2007-10-24 Marek Safar <marek.safar@gmail.com>
5872 ** C# 3.0 Partial methods
5874 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
5875 methods support. Because of member cache issue with generics only
5876 non-generics partial methods are fully supported.
5878 2007-10-23 Marek Safar <marek.safar@gmail.com>
5880 * class.cs, decl.cs: Rewrote member overloads check to cope with
5881 generics and to use member cache for member checking. It also improves
5882 performance and fixes remaining overloads issues.
5884 2007-10-20 Marek Safar <marek.safar@gmail.com>
5886 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
5887 roottypes.cs, typemanager.cs:
5889 A member cache creation logic changed to add members immediately and
5890 not rely on fallback. The member cache is now only prefered way
5891 how to access and find type declaration members. It saves 5 MB of memory
5892 during MWF compilation and makes code ready for more optimizations and
5893 clean-ups, it's also a pre-requirement for partial methods.
5895 2007-10-18 Raja R Harinath <harinath@gmail.com>
5897 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
5898 handling for generic parameters.
5900 2007-10-15 Marek Safar <marek.safar@gmail.com>
5902 * class.cs (FixedField): Removed redundant volatile check.
5904 2007-10-15 Marek Safar <marek.safar@gmail.com>
5906 * class.cs, decl.cs: Fixed overload members verification to do only one
5907 check per possible collision.
5909 2007-10-13 Marek Safar <marek.safar@gmail.com>
5911 A fix for bug #325478
5912 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
5913 and create only one disposable flags container.
5915 2007-10-12 Marek Safar <marek.safar@gmail.com>
5917 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
5918 * statement.cs (Fixed): Fixed variables cloning.
5920 2007-10-12 Marek Safar <marek.safar@gmail.com>
5922 A fix for bug #333342
5923 * class.cs (EventField): Don't mark value type event as synchronized.
5925 2007-10-12 Marek Safar <marek.safar@gmail.com>
5927 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
5928 inference to identify best candidate method correctly.
5929 (ProperyExpr): A range variable is read only and cannot be modified.
5931 2007-10-11 Marek Safar <marek.safar@gmail.com>
5933 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
5934 logic to identify best candidate method correctly.
5936 2007-10-11 Marek Safar <marek.safar@gmail.com>
5938 * location.cs (Equals, GetHashCode): Removed.
5940 2007-10-11 Marek Safar <marek.safar@gmail.com>
5942 * report.cs: Implemented message recorder. It is used mainly for lambda
5943 expressions to capture otherwise swallowed error messages.
5945 * anonymous.cs, lambda.cs.cs: Do full parameters check.
5947 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
5949 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
5951 * expression.cs (MemberAccess): Always report lookup failure.
5953 * location.cs: Implemented Equals, GetHashCode.
5955 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
5957 2007-10-10 Jb Evain <jbevain@novell.com>
5959 * codegen.cs: re-enable assembly version check.
5961 2007-10-09 Marek Safar <marek.safar@gmail.com>
5963 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
5966 * namespace.cs (UsingAlias): Do correct version check.
5968 2007-10-08 Marek Safar <marek.safar@gmail.com>
5970 * expresison.cs, ecore.cs: Issue extension method error message when
5973 * rootcontext.cs: Added ISO_2 compiler mode option.
5975 2007-10-08 Marek Safar <marek.safar@gmail.com>
5977 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
5980 2007-10-08 Marek Safar <marek.safar@gmail.com>
5982 * attribute.cs (GetString, GetBoolean): Work with both literal and
5985 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
5986 Moved method overload specific methods to MethodGroupExpr.
5988 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
5989 it should be less memory consuming.
5991 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
5993 * codegen.cs: remove the assembly version check until the buildbot is
5996 2007-10-07 Jb Evain <jbevain@novell.com>
5998 * attribute.cs (Attribute.GetString): if the value
5999 expression is a StringConstant, return its string value.
6001 2007-10-07 Jb Evain <jbevain@novell.com>
6003 * typemanager.cs: add `assembly_version_attribute_type`.
6004 * codegen.cs: on attribute emission, check that the
6005 AssemblyVersionAttribute doesn't overflow.
6007 2007-10-05 Marek Safar <marek.safar@gmail.com>
6009 A fix for bug #324677
6010 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6011 parent container of a scope container with currently resolved one.
6013 2007-10-05 Marek Safar <marek.safar@gmail.com>
6015 A fix for bug #325534
6016 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6019 2007-10-05 Marek Safar <marek.safar@gmail.com>
6021 A fix for bug #327504
6022 * class.cs (Operator.Define): Refactored implicit and explicit user
6023 operator conversion rules.
6025 2007-10-05 Marek Safar <marek.safar@gmail.com>
6027 A fix for bug #327520
6028 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6030 2007-10-04 Marek Safar <marek.safar@gmail.com>
6032 A fix for bug #328022
6033 * class.cs (MethodData.Define): Use correct method to check whether
6034 a method implementents an accessor.
6036 2007-10-04 Marek Safar <marek.safar@gmail.com>
6038 A fix for bug #330069
6039 * statement.cs (Fixed.Resolve): Read the first array element only when
6040 an array is instantiated.
6042 2007-10-04 Marek Safar <marek.safar@gmail.com>
6044 * expression.cs, assign.cs, generics.cs: Print correct operator when
6045 compound assignment is used.
6047 2007-10-04 Marek Safar <marek.safar@gmail.com>
6049 A fix for bug #325841
6050 * expression.cs (ArrayAccess): Use full argument cloning only for
6051 string compound concatenation.
6053 2007-10-03 Marek Safar <marek.safar@gmail.com>
6055 A fix for bug #328774
6056 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6058 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6061 2007-10-03 Raja R Harinath <rharinath@novell.com>
6064 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6065 Event accessibility checks here. Remove some bogus code that
6066 accidently made GenericMethods work.
6067 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6069 2007-09-25 Marek Safar <marek.safar@gmail.com>
6071 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6073 * statement.cs (Block): Refactored AddVariable to allow error handling
6076 * generic.cs: New stub.
6078 2007-09-23 Marek Safar <marek.safar@gmail.com>
6080 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6083 2007-09-17 Marek Safar <marek.safar@gmail.com>
6085 * class.cs: Use partial container to record whether any partial part
6086 contains static field initializer and therefore default contructor has
6089 2007-09-14 Marek Safar <marek.safar@gmail.com>
6091 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6092 mono-list when only one of two partial parts has defined accessibility
6095 2007-09-14 Marek Safar <marek.safar@gmail.com>
6097 A fix for bug #82845
6099 * class.cs (TypeContainer): Set correct resolve context for all field
6102 2007-09-13 Marek Safar <marek.safar@gmail.com>
6104 * assign.cs: Fixed a crash when field is resolved twice with an error.
6106 * codegen.cs: Changed InFieldInitializer to be flag.
6108 * anonymous.cs, ecore.cs, expression.cs: Update after
6109 IsInFieldInitializer rename.
6111 * const.cs: Removed unused parameter.
6113 * class.cs: Changed the way how we resolve and emit field initializers.
6114 The field initilizers have to have access to contructor block to emit
6115 compiler generated code.
6117 2007-09-13 Marek Safar <marek.safar@gmail.com>
6119 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6120 generics use TypeContainer instead.
6122 2007-09-12 Marek Safar <marek.safar@gmail.com>
6124 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6126 * lambda.cs (ResolveParameters): Use more powerful
6127 InflateGenericArgument.
6129 * parameters.cs: Better exception message.
6131 2007-09-10 Marek Safar <marek.safar@gmail.com>
6133 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6134 correct expression block type.
6136 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6138 * expression.cs (Invocation): Extracted method group resolve to
6141 2007-09-07 Marek Safar <marek.safar@gmail.com>
6143 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6144 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6146 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6147 generic extension methods.
6149 2007-09-06 Marek Safar <marek.safar@gmail.com>
6151 A fix for bug #82676 (Do I get it right now?)
6152 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6153 object before a standard conversion is applied.
6155 2007-09-06 Marek Safar <marek.safar@gmail.com>
6157 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6160 2007-09-05 Marek Safar <marek.safar@gmail.com>
6162 A fix for bug #82676
6163 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6164 non-generic interface types.
6166 2007-09-05 Marek Safar <marek.safar@gmail.com>
6168 A fix for bug #82690
6169 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6171 2007-09-05 Marek Safar <marek.safar@gmail.com>
6173 A fix for bug #82571
6174 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6175 modifier for container based methods.
6177 2007-09-05 Marek Safar <marek.safar@gmail.com>
6179 A fix for bug #82676
6180 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6181 any interface-type T means to any of interface type T.
6183 2007-09-04 Marek Safar <marek.safar@gmail.com>
6185 * namespace.cs: We have 2 versions of System.Core assembly.
6187 2007-09-04 Marek Safar <marek.safar@gmail.com>
6189 A fix for bug #82652
6190 * class.cs (Class.GetClassBases): Compare types and not expressions.
6192 2007-09-04 Marek Safar <marek.safar@gmail.com>
6194 A fix for bug #82620
6195 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6196 actually never worked before.
6197 (IndexerAccess): Emit prepared arguments before they are modified.
6199 2007-09-04 Marek Safar <marek.safar@gmail.com>
6201 A fix for bug #82563
6202 * assign.cs: Revert wrong fix.
6204 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6206 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6207 Instead of ldelema/stdind we have to use temporary variables to handle
6208 cases like String.Concat (params string[]).
6210 2007-08-31 Marek Safar <marek.safar@gmail.com>
6212 * class.cs: EmitAttributes to Emit rename.
6214 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6216 (MemberCore.HasClsCompliantAttribute): Don't depend on
6217 GetClsCompliantAttributeValue execution.
6219 2007-08-31 Marek Safar <marek.safar@gmail.com>
6221 * anonymous.cs: Use shorter type prefix.
6223 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6226 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6227 variables when probing is on.
6229 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6230 unresolved variables.
6231 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6232 handle transparent identifiers.
6234 2007-08-26 Marek Safar <marek.safar@gmail.com>
6236 * attribute.cs (IsClsCompliant): Add nullable types test.
6238 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6240 * doc.cs : catch other types of exception than XmlException to
6241 report CS1570. Fixed bug #82565.
6243 2007-08-23 Marek Safar <marek.safar@gmail.com>
6245 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6246 The number of delegate parameters has to match.
6247 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6250 2007-08-21 Marek Safar <marek.safar@gmail.com>
6252 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6253 to fix problem with private arguments.
6255 2007-08-20 Marek Safar <marek.safar@gmail.com>
6257 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6259 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6261 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6262 empty. Add cloning suport.
6264 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6266 2007-08-20 Marek Safar <marek.safar@gmail.com>
6268 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6269 to create EmptyCast. It handles EmptyConstantCast specialization for
6272 2007-08-18 Marek Safar <marek.safar@gmail.com>
6274 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6275 (EmitArrayArgument): One routine for array arguments.
6276 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6278 2007-08-17 Marek Safar <marek.safar@gmail.com>
6280 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6282 2007-08-17 Marek Safar <marek.safar@gmail.com>
6284 * anonymous.cs: MemberLookupFinal update.
6286 * class.cs (ConstructorInitializer): Is expression based.
6288 * delegate.cs: MethodGroupExpr update.
6290 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6292 (Error_MemberLookupFailed): Customizable error override.
6293 (MethodGroupExpr): Keep queried type for later usage.
6294 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6297 * expression.cs: Error_MemberLookupFailed refactoring.
6298 (New.DoResolve): Resolve as much as possible.
6299 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6300 customization for invalid member types.
6302 * statement.cs: MethodGroupExpr update.
6304 2007-08-16 Marek Safar <marek.safar@gmail.com>
6306 * modifier.cs (Check): Check all modifiers and not only accessibility
6309 2007-08-16 Marek Safar <marek.safar@gmail.com>
6311 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6312 type and not an expression.
6314 2007-08-16 Marek Safar <marek.safar@gmail.com>
6316 * statement.cs (Catch.Clone): Type and variable can be null.
6318 2007-08-16 Marek Safar <marek.safar@gmail.com>
6320 A fix for bug #81979
6321 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6322 I am really not sure whether this is the best fix.
6324 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6327 2007-08-14 Marek Safar <marek.safar@gmail.com>
6329 ** C# 3.0 Object and collection initializers (major re-write)
6331 * assign.cs (DoResolve): Initializers are not assign related.
6333 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6334 used during collection or object initialization.
6336 * expression.cs (Error_InvalidArguments): Add initializers specific
6337 messages. More will come later because it requires some general
6339 (New.DoResolve): Better error handling for unsafe types.
6340 (EmptyExpressionStatement): New class.
6341 (ElementInitializer): An object initializer expression.
6342 (CollectionElementInitializer): A collection initializer expression.
6343 (CollectionOrObjectInitializers): A block of object or collection
6345 (NewInitialize): New expression with element/object initializers.
6347 * statement.cs: Reverted object/collection initializer hacks.
6349 * typemanager.cs (CSharpName): Filter __arglist type.
6351 2007-08-09 Marek Safar <marek.safar@gmail.com>
6353 ** C# 3.0 Anonymous Types (update to the latest standard)
6355 * expression.cs (Binary.ResolveOperator): Threat all null based types
6357 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6358 (AnonymousTypeParameter): Updated.
6360 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6361 (AnonymousTypeClass): New anonymous type container.
6363 * class.cs (AddField): Return operation result.
6365 * generic.cs: Another empty TypeArguments overload.
6367 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6368 are stored at top of normal hierarchy.
6370 * typemanager.cs (CSharpName): Filter anonymous types.
6372 2007-08-09 Marek Safar <marek.safar@gmail.com>
6374 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6375 as single Concat call. How could we miss that :-(
6377 2007-08-08 Marek Safar <marek.safar@gmail.com>
6379 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6381 2007-08-07 Miguel de Icaza <miguel@novell.com>
6383 * expression.cs: Fix the previous commit, the creation of the
6384 arguments array list needs also to be conditional on the arguments
6387 * class.cs: Add a little bit of help to help narrow down problems.
6389 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6390 not try to copy in that case.
6392 * driver.cs: When building SMCS, include a new different set of
6393 default assemblies here. Do this here so we can control whether
6394 to include the default assemblies with /noconfig.
6396 2007-08-03 Marek Safar <marek.safar@gmail.com>
6398 A fix for bug #81979
6399 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6402 2007-08-03 Marek Safar <marek.safar@gmail.com>
6404 A fix for bug #82300
6406 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6407 we are in probing scope.
6409 2007-08-03 Marek Safar <marek.safar@gmail.com>
6411 A fix for bug #82301
6413 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6414 (Statement.CloneTo): Clone and not map children blocks.
6416 2007-08-03 Marek Safar <marek.safar@gmail.com>
6418 A fix for bug #82299
6420 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6423 * statement.cs (Statement.CloneTo): Clone variables before statements
6424 to allow remaping of local variables.
6426 2007-08-03 Marek Safar <marek.safar@gmail.com>
6428 A fix for bug #82296
6431 * report.cs: Log crash details for future clone problems.
6433 * statement.cs (Return.Clone): Don't clone non-existent expression.
6435 2007-08-03 Raja R Harinath <harinath@gmail.com>
6437 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6438 (Class.AddBasesForPart): Move CS0537 check here from ...
6439 * cs-parser.jay (class_declaration): ... here. Move calling of
6440 'AddBasesForPart' to ...
6441 (class_bases): ... here.
6442 (struct_declaration, interface_declaration): Update to changes.
6444 2007-08-02 Marek Safar <marek.safar@gmail.com>
6446 A fix for bug #81923
6448 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6449 conversion is allowed.
6451 2007-08-02 Marek Safar <marek.safar@gmail.com>
6453 A fix for bug #81564
6455 * ecore.cs (EventExpr): Add IsBase handling.
6457 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6460 2007-08-02 Raja R Harinath <harinath@gmail.com>
6462 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6463 * cs-parser.jay: Some whitespace cleanups.
6464 (current_delegate): New.
6466 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6467 a dummy code block, and use 'type_name' instead of 'member_name'.
6468 (interface_declaration, class_declaration): Likewise.
6469 (delegate_declaration): Likewise. Rearrange slightly and use
6471 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6472 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6474 2007-08-02 Marek Safar <marek.safar@gmail.com>
6476 A fix for bug #82039
6478 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6481 * typemanager.cs (CSharpName): Split to string overload.
6483 2007-08-02 Marek Safar <marek.safar@gmail.com>
6486 * report.cs: Updated warning CS0472.
6488 2007-08-01 Marek Safar <marek.safar@gmail.com>
6490 A fix for bug #82181
6492 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6494 2007-08-01 Marek Safar <marek.safar@gmail.com>
6496 A fix for bug #82277
6497 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6499 2007-08-01 Marek Safar <marek.safar@gmail.com>
6501 ** C# 3.0 Type Inference (major bits are working)
6503 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6504 (.ImplicitStandardConversionExists): Uses compatible.
6505 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6506 (.InferReturnType): New method.
6507 (.Compatible): Refactored.
6508 (.ResolveParameters): Uses factory to create resolved parameters.
6509 (.CompatibleMethod): Add probing mode support.
6510 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6511 clearly distinguish between 2 different operations.
6512 (LambdaMethod): Moved to lambda.cs.
6513 (AnonymousMethod): Removed unused fields and methods.
6514 (AnonymousDelegate): Simplified.
6516 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6518 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6520 * delegate.cs (Delegate): New mehods to reduce code duplication.
6521 (.GetConstructor): New method.
6522 (.GetInvokeMethod): New method.
6523 (DelegateCreation): Updated.
6525 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6527 (OverloadResolve): Made probing little bit faster.
6529 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6532 * generic.cs (TypeInferenceContext): Dummy implementation.
6534 * iterators.cs: Updated after Resolve/Define rename.
6536 * lambda.cs (LambdaExpression)
6537 (.ResolveParameters): Handles both type of arguments and type inference too.
6539 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6540 (InflateTypes): Updated.
6542 * support.cs (InflateTypes): Changed signature and updated.
6544 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6545 (MemberLookup_FindMembers): More MS tricks.
6546 (GetParameterData): Ditto.
6547 (GetDelegateParameters): Uses quick path for dynamic types.
6549 2007-08-01 Marek Safar <marek.safar@gmail.com>
6551 * class.cs (MethodData.Define): EmitContext is required for generic stuff
6554 2007-07-31 Marek Safar <marek.safar@gmail.com>
6556 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
6559 2007-07-26 Jb Evain <jbevain@novell.com>
6561 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
6562 which takes a boolean 'report_errors', similar to the GetMethod.
6563 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
6564 in .net 2.1, do not report errors here.
6566 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
6567 System.Runtime.CompilerServices.RequiredAttributeAttribute and
6568 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
6571 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
6572 of the type InternalsVisibleToAttribute before the first call
6573 to CoreLookupType which is allowed to fail (third boolean parameter
6574 to true). Because, during the resolution for a type that is not
6575 immediately found, we try to check if the type is not defined in
6576 a friend assembly, and to do so, we need the
6577 InternalVisibleToAttribute.
6579 2007-07-23 Miguel de Icaza <miguel@novell.com>
6581 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
6582 feature that allows structs to be compared against null and inline
6583 the result as true or false.
6585 Notice that the same code is not permitted inside a generic block
6586 of code that would do:
6588 class Foo<T> where T : struct {
6595 It is only allowed if the type of T is not bound (no where
6596 clause). In my opinion, this CSC 2 behavior is broken but people
6597 seem to be using it (IronRuby does, a few bug reports on bugzilla
6598 have it and some people have complained about it).
6600 All of the users that depend on this behavior have code that is
6603 * report.cs (Warning, Error): make these take object arguments,
6604 not strings, as that allows us to take advantage of Format.
6606 2007-07-20 William Holmes <billholmes54@gmail.com>
6608 * decl.cs: Changed MemberName.CountTypeArguments to also check the
6609 Left member variable for the Count.
6610 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
6611 MemberName.CountTypeArguments to avoid a NRE.
6613 This code is contributed under the MIT X11 license
6615 2007-07-18 Marek Safar <marek.safar@gmail.com>
6617 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
6619 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6621 * doc.cs : generic method arguments are written as ``x while generic
6622 type arguments are `x. Combined with the previous change, fixed bug
6625 2007-07-18 Raja R Harinath <rharinath@novell.com>
6628 * expression.cs (Binary.ResolveOperator): When converting
6629 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
6631 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6633 * doc.cs : when T: or whatever x: is specified, it does not really
6634 check the doc comment's syntax correctness. Fixed bug #82006.
6636 2007-07-18 Marek Safar <marek.safar@gmail.com>
6638 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
6639 LambdaExpression better.
6641 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
6643 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
6645 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
6646 as it can be generated.
6648 * expression.cs (Invocation.Error_InvalidArguments): Show correct
6651 * lambda.cs (LambdaExpression): Refactored to share same code with
6652 AnonymousMethodExpression.
6654 2007-07-17 Marek Safar <marek.safar@gmail.com>
6656 * anonymous.cs (MakeName): Include host name for easier debugging.
6657 (LambdaMethod): New class for lambda spcecific stuff.
6659 * attribute.cs: Set EmitContext return type.
6661 * class.cs: Set EmitContext return type.
6663 * codegen.cs (EmitContext): Return type cannot be null to stop messing
6664 with null/void meaning.
6666 * iterators.cs (ContainerType): Implemented.
6668 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
6670 * statement.cs (Return): Updated to lambda expressions.
6671 (Block.CloneTo): Parent can be null.
6673 2007-07-13 Marek Safar <marek.safar@gmail.com>
6675 A fix for bug #81917
6676 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
6678 * class.cs (FixedField): Check whether field is in unsafe scope.
6680 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
6681 (FieldExpr.Emit): Fixed buffers cannot be volatile.
6683 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
6686 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
6688 2007-07-13 Marek Safar <marek.safar@gmail.com>
6690 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
6691 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
6694 2007-07-13 Marek Safar <marek.safar@gmail.com>
6696 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
6698 2007-07-13 Marek Safar <marek.safar@gmail.com>
6700 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
6701 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
6703 * codegen.cs(EmitContext): Add ProbingMode flag.
6705 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
6707 * driver.cs: For now set both warning values.
6709 * ecore.cs (SimpleName): Name is readonly.
6710 (MethodGroup.OverloadResolve): One quick path for probing.
6712 * expression.cs (Unary): Set Oper r/o.
6713 (Binary): Set Oper r/o.
6714 (ParameterReference): Set few instance variables as r/o.
6715 (ParameterReference.DoResolveBase): Don't capture aruments when
6717 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
6718 (Arglist): arguments are private.
6719 (SizeOf): type is private and r/o.
6720 (MemberAccess): arguments are private.
6722 * report.cs: Enhanced reporting on/off capabilities.
6724 * lambda.cs: Uses ec.IsInProbingMode.
6725 (ContextualReturn): Derives from return.
6727 * rootcontext.cs: For now set both warning values.
6729 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
6731 (Return.Resolve): Don't die immediately.
6732 (Block.Resolve): Speed-up probing.
6733 (Block.CloneTo): Clone only child blocks.
6735 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
6737 * iterators.cs: reverted Miguel's latest change (r81925) as it
6738 breaks the build in System.
6740 2007-07-13 Miguel de Icaza <miguel@novell.com>
6742 * iterators.cs (Yield.CheckContext): Check for the iterator type
6743 also here as we can call into Yield even in codepaths that are not
6745 (MethodOrOperator is the only path that was checked).
6747 In addition to the standard check, use a more specific check for
6748 constructors to report a more verbose error.
6750 2007-07-12 Miguel de Icaza <miguel@novell.com>
6752 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
6753 report the warning and continue
6755 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
6756 values on the stack on the call to Emit. Use EmitStatement if
6757 possible, or using Emit + Pop if not possible. Fixes #82064
6759 2007-07-12 Raja R Harinath <rharinath@novell.com>
6761 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
6762 avoid try...finally in some cases.
6764 2007-07-10 Marek Safar <marek.safar@gmail.com>
6766 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
6768 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
6769 instead of method. Re-use standard error handling.
6770 (ConstructorInitializer.Emit): Simplified.
6772 * delegate.cs: Updated after Invocation.EmitCall change.
6774 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
6775 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
6776 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
6777 method and don't permanently changing input arguments.
6778 (MethodGroupExpr): Introduced resolved best_candidate, when method group
6779 is resolved it has one of the candidates is the best one which is later
6780 used to emit. Removed a few unused method.
6781 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
6783 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
6784 (Binary.ResolveOperator): Ditto.
6785 (ConditionalLogicalOperator.DoResolve): Ditto.
6786 (Invocation): Uses method group.
6787 (Invocation.DoResolve): Simplified.
6788 (Invocation.EmitCall): Removed useless is_static.
6789 (Invocation.Emit): Delegate to method group.
6790 (Invocation.EmitStatement): Simplified.
6791 (New): Uses method group.
6792 (MemberAccess.DoResolve): Don't destroy original expression.
6794 * statement.cs (ForEach.Resolve): Use null for no method arguments.
6796 2007-07-04 Marek Safar <marek.safar@gmail.com>
6798 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
6801 * lambda.cs: Add custom error message type.
6803 2007-07-03 Marek Safar <marek.safar@gmail.com>
6805 * lambda.cs: Simplified little bit.
6807 * parameter.cs: Introduced ImplicitLambdaParameter.
6808 (Parameters.CreateFullyResolved): New factory instead of ctor.
6812 * delegate.cs: Updated parameter creation.
6814 2007-07-03 Marek Safar <marek.safar@gmail.com>
6816 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
6819 * generic.cs: Synchronized with gmcs.
6821 2007-07-03 Marek Safar <marek.safar@gmail.com>
6823 * class.cs (Indexer): Check return type as soon as possible.
6825 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
6828 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
6830 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
6832 * parameter.cs (Parameter): Use expression type when it is available.
6834 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
6835 method modifier for the first parameter only.
6837 2007-06-24 Marek Safar <marek.safar@gmail.com>
6839 A fix for bug #81938
6840 * typemanager.cs (ChangeType): Fixed couple of char conversions.
6842 * constant.cs: Tide up an exception message.
6844 2007-06-22 Marek Safar <marek.safar@gmail.com>
6846 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
6847 an uninitialized variable is used.
6849 * expression.cs (LocalVariableReference.DoResolve): Ditto.
6851 2007-06-22 Marek Safar <marek.safar@gmail.com>
6853 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
6854 not found error handling.
6856 * expression.cs (ArrayCreation): Removed redundant fields and little bit
6858 (ArrayCreation.ResolveArrayElement): To be ready to customization.
6859 (ArrayCreation.DoResolve): Simplified.
6860 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
6861 its own resolve process.
6862 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
6864 2007-06-20 Marek Safar <marek.safar@gmail.com>
6866 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
6869 2007-06-20 Marek Safar <marek.safar@gmail.com>
6871 * cs-tokenizer.cs: Removed var related stuff.
6873 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
6874 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
6875 a type and a keyword at same time.
6877 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
6880 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
6881 implicitly typed arrays, more changes will follow.
6883 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
6885 2007-06-19 Marek Safar <marek.safar@gmail.com>
6887 * ecore.cs (VarExpr): Removed Handled field.
6889 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
6890 build-in assign functionality.
6891 (ForEach.Resolve): Removed all implicitly typed local variable code and
6893 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
6894 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
6896 2007-06-18 Marek Safar <marek.safar@gmail.com>
6898 * assign.cs: Removed implicitly typed local variable check.
6900 * expression.cs (LocalVariableReference.DoResolve): Add check for self
6901 referencing implicitly typed local variable.
6902 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
6905 * statement.cs (Fixed): Removed unsupported implicitly typed local
6908 2007-06-15 Marek Safar <marek.safar@gmail.com>
6910 * decl.cs (MemberName): Moved all Unbound stuff to parser.
6912 2007-06-14 Marek Safar <marek.safar@gmail.com>
6914 A fix for bugs #81855 and #76274
6915 * attribute.cs (AttachTo): Always set owner for global attributes to
6918 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
6921 * cs-parser.jay: Assembly and module attributes must precede all other
6922 elements except using clauses and extern alias declarations.
6924 2007-06-13 Marek Safar <marek.safar@gmail.com>
6926 A fix for bug #81748
6928 * expression.cs: More checks for non ISO-1 features.
6930 2007-06-12 Marek Safar <marek.safar@gmail.com>
6932 A fix for bug #81807
6933 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
6934 present inside switch statement and it is required by nullable check.
6936 2007-06-12 Marek Safar <marek.safar@gmail.com>
6938 A fix for bug #81840
6939 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
6940 when type matching fails.
6942 * namespace.cs: Tiny error message change.
6944 2007-06-12 Marek Safar <marek.safar@gmail.com>
6946 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
6947 reporting. Added automatic property check.
6949 * class.cs: Updated after CheckAbstractAndExtern relocation.
6950 (AEventPropertyAccessor.GetSignatureForError): Customized.
6952 2007-06-11 Marek Safar <marek.safar@gmail.com>
6954 * class.cs (DefineBaseTypes): Base type can be undefined.
6956 * ecore.cs (TypeLookup): Minor refactoring.
6957 (DoResolveAsTypeStep): Removed redundant check.
6959 * namespace.cs (Lookup): Removed redundant check.
6961 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
6962 ResolveAsTypeTerminal step.
6963 (BootstrapCorlib_*): Simplified.
6964 (PopulateCoreType): Core types can be now external.
6966 2007-06-07 Marek Safar <marek.safar@gmail.com>
6968 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
6970 (InferTypeArguments): Infers anonymous expression type arguments.
6971 (Compatible): Split to Compatible and InferTypeArguments.
6973 * lambda.cs: Updated.
6975 2007-06-08 Marek Safar <marek.safar@gmail.com>
6977 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
6979 2007-06-07 Raja R Harinath <harinath@gmail.com>
6981 Fix #80477, cs0135-2.cs, cs0135-3.cs
6982 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
6983 names to the "known" variables list.
6984 (Block.CheckInvariantMeaningInBlock): Handle the fact the
6985 parameter names are also "known".
6986 (Block.CheckError136): Remove.
6987 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
6990 2007-06-07 Marek Safar <marek.safar@gmail.com>
6992 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
6994 2007-06-06 Marek Safar <marek.safar@gmail.com>
6996 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
6997 internal error not an user error.
6999 * expression.cs (IsApplicable): Refactored to make debugging easier.
7001 * support.cs: More tricks for non-mono runtimes.
7003 * typemanager.cs (CoreLookupType): Made public.
7004 (InitSystemCore): All linq specific stuff moved to linq.cs
7006 2007-06-05 Marek Safar <marek.safar@gmail.com>
7008 * typemanager.cs (CSharpSignature): One more missing build-in types
7010 More tricks for non-mono runtime.
7012 2007-06-05 Raja R Harinath <harinath@gmail.com>
7014 * statement.cs (Block.CheckError136_InParents): Remove.
7015 (Block.AddVariable): Use GetParameterInfo instead.
7016 (ToplevelBlock.ProcessArguments): Likewise.
7018 2007-06-04 Raja R Harinath <rharinath@novell.com>
7020 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7022 (ToplevelBlock.GetParameterInfo): Split out of ...
7023 (ToplevelBlock.GetParameterRefernce): ... this.
7024 (ToplevelBlock.ParameterMap): Remove.
7025 * expression.cs (ParameterReference): Update to use
7026 ToplevelParameterInfo.
7028 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7031 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7032 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7034 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7035 (ToplevelBlock.ProcessParameters) ... here.
7036 (ToplevelBlock..ctor): Invoke it.
7038 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7041 * statement.cs (IKnownVariable): New interface.
7042 (LocalInfo): Implement it.
7043 (ToplevelParameterInfo): New class.
7044 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7045 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7046 GetKnownVariableInfo.
7048 2007-06-03 Raja R Harinath <harinath@gmail.com>
7050 Partly speed up CS0136 error checks.
7051 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7052 'recurse' parameter.
7053 (Block.DoCheckError136): Only check errors in parameters. Move
7054 local variable checks ...
7055 (Block.AddVariable): ... here, and ...
7056 (ToplevelBlock.ResolveMeta): ... here.
7058 2007-06-02 Raja R Harinath <harinath@gmail.com>
7060 * statement.cs (Block.IsChildOf): Remove.
7062 * statement.cs (Statement.Clone): Move special case code ...
7063 (Block.CloneTo): ... here.
7065 2007-05-29 Raja R Harinath <rharinath@novell.com>
7067 * statement.cs (ToplevelBlock.container): Remove field. It's
7068 redundant with 'Parent'.
7069 (ToplevelBlock.ContainerBlock): Remove accessor.
7070 (ToplevelBlock..ctor): Update to changes. Register anonymous
7071 child with parent here, ...
7072 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7074 (start_anonymous): Don't save current_block.
7075 (top_current_block): Remove.
7077 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7078 (Block.Resolve): Update to changes.
7079 (Block..ctor): Move setting of "correct" 'Toplevel'
7080 and 'Explicit' fields to ...
7081 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7083 2007-05-27 Raja R Harinath <harinath@gmail.com>
7086 * statement.cs (Block.Implicit): Remove.
7087 (Block): Update to changes.
7088 * flowanalysis.cs: Likewise.
7090 Mildly speed up CheckInvariantMeaningInBlock
7091 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7092 Recursively call AddKnownVariable to all enclosing blocks.
7093 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7094 Remove recursive calls.
7095 (Block): Update to changes.
7097 New ExplicitBlock invariants
7098 * statement.cs (Block.Explicit): New field. It points to the
7099 immediately enclosing non-implicit block.
7100 (Block..ctor): Maintain the invariant.
7101 * cs-parser.jay: Take advantage of invariant.
7103 Introduce ExplicitBlock
7104 * statement.cs (ExplicitBlock): New.
7105 (ToplevelBlock): Derive from it.
7106 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7108 (Block.Implicit): Update to changes.
7109 * cs-parser.jay: Update to changes.
7112 * codegen.cs (EmitContext.IsLastStatement): Remove.
7113 * statement.cs (Block.DoEmit): Update to changes.
7115 2007-05-25 Raja R Harinath <rharinath@novell.com>
7117 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7118 modifying current_block directly.
7120 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7122 * class.cs: Implemented automatic properties (C# 3.0)
7123 Thanks to Marek for the help.
7125 2007-05-23 Raja R Harinath <rharinath@novell.com>
7127 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7128 variable as assigned, note also that all its components are
7130 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7132 2007-05-19 Marek Safar <marek.safar@gmail.com>
7134 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7135 member is marked as compiler generated.
7137 * decl.cs (MemberCore): Refactored ModFlags into property.
7139 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7140 (Check): Check only accessibility modifiers.
7142 2007-05-18 Raja R Harinath <rharinath@novell.com>
7144 Track all assignable slots in one bit array
7145 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7146 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7147 logic from VariableMap constructor here. Use the same 'offset'
7148 variable that's later used for computing offsets of local
7150 * flowanalysis.cs (UsageVector.parameters): Remove.
7151 (UsageVector): Update to changes.
7152 (VariableMap): Remove.
7154 Avoid creating ParameterMap in every block
7155 * statement.cs (Block.ParameterMap): Move ...
7156 (ToplevelBlock.ParameterMap): ... here.
7157 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7159 * flowanalysis.cs (FlowBranching.param_map): Remove.
7160 (FlowBranching.UsageVector): Update to changes.
7161 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7163 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7165 * expression.cs (ParameterReference): Distinguish between block
7166 where parameter was referenced and declared.
7168 2007-05-18 Marek Safar <marek.safar@gmail.com>
7170 * flowanalysis.cs, statement.cs: Put back improved error handling.
7172 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7176 Imporved object and collection initialization (C# 3.0).
7178 2007-05-15 Marek Safar <marek.safar@gmail.com>
7180 A fix for bug #81380
7181 * expression.cs (Is.DoResolve): Only value types have constant `is'
7184 2007-05-15 Raja R Harinath <rharinath@novell.com>
7186 * statement.cs (ToplevelBlock.child): Remove.
7188 2007-05-15 Raja R Harinath <harinath@gmail.com>
7190 Rationalize ResolveMeta: refactoring
7191 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7192 out constant handling code into ...
7193 (Block.DoResolveConstants): ... this.
7195 Rationalize ResolveMeta: kill local_map
7196 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7197 (Block.AssignableSlots): New.
7198 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7199 for locals -- move code from VariableMap here. Avoid unnecessary
7201 * flowanalysis.cs (FlowBranching.local_map): Remove.
7202 (FlowBranching..ctor): Use Block.AssignableSlots.
7203 (VariableMap): Remove unused constructors.
7205 2007-05-11 Raja R Harinath <rharinath@novell.com>
7207 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7209 2007-05-11 Marek Safar <marek.safar@gmail.com>
7211 * typemanager.cs (IsFriendAssembly): Should not be called for building
7214 2007-05-09 Marek Safar <marek.safar@gmail.com>
7216 * literal.cs (NullConstant): Print null in all cases.
7218 * expression.cs (Binary.ResolveOperator): Implemented delegate
7219 comparison based on C# 2.0 changes.
7221 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7223 This code is contributed under the MIT X11 license
7225 The following enables support for several C# 3.0 language features:
7227 * cs-tokenizer.cs: Added support for the "var" keyword.
7229 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7230 Added VarExpr class to facilitate type inferencing.
7232 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7233 to support anonymous types.
7235 * assign.cs: Added support for type inferencing and initialization.
7237 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7239 * expression.cs: Added implicit array support to ArrayCreation.
7240 Added 5 types and 1 interface:
7242 IInitializable Implementing classes can inject initializing
7243 statements after object instantiation.
7245 Initializer Stores data for object initialization.
7247 AnonymousType An expression for anonymous types.
7249 AnonymousTypeParameter Stores data about an anonymous type's field.
7251 NewInitialize An expression for object initialization.
7253 CollectionInitialize An expression for collection initialization.
7255 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7258 2007-05-06 Marek Safar <marek.safar@gmail.com>
7260 A fix for bug #81500
7261 * cs-tokenizer.cs: Add special handling for coalescing operator.
7263 2007-05-06 Marek Safar <marek.safar@gmail.com>
7265 A fix for bug #81529
7266 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7267 its value from base class until it is redefined.
7269 2007-05-02 Raja R Harinath <rharinath@novell.com>
7271 Fix regression in cs0631-3.cs
7272 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7273 fallback. Make error fallback catch more cases.
7275 2007-05-01 Miguel de Icaza <miguel@novell.com>
7277 * cs-parser.jay: Allow parameters in operator declarations to have
7280 2007-04-27 Miguel de Icaza <miguel@novell.com>
7282 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7285 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7286 inside the ContextualReturn, it does not have to be an
7287 ExpressionStatement.
7289 2007-04-24 Miguel de Icaza <miguel@novell.com>
7291 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7294 2007-04-23 Miguel de Icaza <miguel@novell.com>
7296 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7297 method in two methods: ResolveNoDefine and Resolve.
7299 ResolveNoDefine will stop just after ResolveTopBlock has been
7302 Resolve will then continue by creating a method and issuing the
7303 call to method.Define ().
7305 (AnonymousMethod): Split and implement the new Resolve and
7306 ResolveNoDefine as well.
7308 * lambda.cs (LambdaExpression): Split the anonymous method
7309 resolution code into a separate routine (CoreCompatibilityTest)
7310 from DoCompatibleTest.
7312 (LambdaExpression.TryBuild): New method, this method tries to
7313 build the LambdaExpression with the given set of types to be used
7314 as the types for the various parameters of the lambda expression.
7316 If the compilation succeed with the given types, the infered type
7317 of the Anonymous method is returned, otherwise null is returned.
7319 2007-04-23 Marek Safar <marek.safar@gmail.com>
7321 A fix for bug #81414
7322 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7324 2007-04-22 Miguel de Icaza <miguel@novell.com>
7326 * cs-tokenizer.cs: Change various identifiers here from the
7327 camelCasing to the recommended Linux-like style for instance
7328 variables from the Coding Guidelines.
7330 2007-04-19 Martin Baulig <martin@ximian.com>
7333 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7334 System.Enum to System.ValueType.
7336 2007-04-13 Martin Baulig <martin@ximian.com>
7338 Rewrote implicit reference conversions. We need to distinguish
7339 between implicit reference conversions (13.1.4) and implicit
7340 boxing conversions (13.1.5).
7342 According to the spec, there's an an implicit conversion
7343 "From a one-dimensional array-type S[] to IList<T> and base
7344 interfaces of this interface, provided there is an implicit
7345 reference conversion from S to T." Note that this does not
7346 include boxing conversions.
7349 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7350 (Convert.ImplicitReferenceConversion): Split into
7351 ImplicitReferenceConversionCore() and
7352 ImplicitBoxingConversionExist().
7353 (Convert.ImplicitReferenceConversionExists): Use the new
7354 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7356 2007-04-12 Martin Baulig <martin@ximian.com>
7358 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7359 `TypeManager.null_type' checks up to the top of the method.
7361 2007-04-11 Marek Safar <marek.safar@gmail.com>
7363 A fix for bug #81350
7364 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7367 2007-04-11 Martin Baulig <martin@ximian.com>
7369 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7370 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7371 to make this work for generic classes; fixes #79561.
7373 2007-04-11 Martin Baulig <martin@ximian.com>
7375 * expression.cs (As): Add support for nullable types; fixes #79371.
7377 2007-04-11 Martin Baulig <martin@ximian.com>
7379 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7380 `type.FullName' is null; fixes #80243.
7382 2007-04-11 Martin Baulig <martin@ximian.com>
7384 * expression.cs (Invocation.IsApplicable): Don't modify the method
7385 if type inference succeeded, but the method was not applicable.
7388 2007-04-10 Marek Safar <marek.safar@gmail.com>
7390 A fix for bug #81324
7391 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7392 internal and external namespaces containers.
7394 2007-04-10 Martin Baulig <martin@ximian.com>
7396 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7397 TypeManager.DropGenericMethodArguments() so we also call
7398 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7400 2007-04-10 Martin Baulig <martin@ximian.com>
7402 * iterators.cs (Iterator.CreateIterator): Don't crash if
7403 `method.ReturnType' is null. This happens if something went wrong
7404 while resolving that typ (we already reported an error in this case).
7406 2007-04-10 Martin Baulig <martin@ximian.com>
7408 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7409 generic interfaces; report the CS0144 directly.
7411 2007-04-10 Martin Baulig <martin@ximian.com>
7413 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7414 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7416 2007-04-10 Martin Baulig <martin@ximian.com>
7418 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7420 2007-04-09 Raja R Harinath <rharinath@novell.com>
7423 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7424 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7427 * statement.cs (For.Resolve): If resolution fails, use
7430 2007-04-08 Marek Safar <marek.safar@gmail.com>
7432 * anonymous.cs (MakeName): Make faster and zero-based.
7433 (VerifyExplicitParameterCompatibility): Back to mode where generic
7434 parameter is ignored.
7435 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7437 * class.cs (EmitType): Method can emit another new method.
7439 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7441 * driver.cs: Updated.
7443 * lambda.cs: Reuse predefined empty parameters.
7445 * parameter.cs: Updated
7447 * support.cs: Implemented InflateTypes.
7449 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7450 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7452 2007-04-03 Martin Baulig <martin@ximian.com>
7456 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7457 version of TypeManager.IsOverride() which also works with generic
7460 2007-04-03 Martin Baulig <martin@ximian.com>
7465 (Convert.ExplicitReferenceConversion): We need to cast when
7466 converting from IList<T> to S[].
7468 2007-04-01 Marek Safar <marek.safar@gmail.com>
7470 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7473 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7475 2007-03-31 Marek Safar <marek.safar@gmail.com>
7477 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7478 argument and return type inferring.
7480 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7481 (ReturnType): Turned to property.
7483 * statement.cs (Return): Implemented return type inferring.
7485 * support.cs (ReflectionParameters): Use local types if possible.
7487 2007-03-30 Raja R Harinath <rharinath@novell.com>
7489 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7490 (FlowBranching.UsageVector): Update to changes.
7492 Prepare to kill 'Reachability'
7493 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7494 argument of constructor.
7496 2007-03-29 Raja R Harinath <rharinath@novell.com>
7498 Prepare to kill 'Reachability'
7499 * flowanalysis.cs (UsageVector.is_unreachable): New.
7500 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7501 'reachability', and verify they're consistent.
7504 * expression.cs (New.EmitStatement): Handle type parameters here too.
7506 2007-03-29 Martin Baulig <martin@ximian.com>
7511 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7512 CompilerGeneratedClass.
7513 (ScopeInfo.EmitScopeInstance): Make this protected.
7514 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7515 `ec.CurrentAnonymousMethod.Scope == Scope'.
7517 * statement.cs (Block.ScopeInfo): Make this a property.
7519 2007-03-27 Raja R Harinath <harinath@gmail.com>
7521 Prepare to kill 'Reachability'
7522 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7523 (FlowBranching.UsageVector.Reachability): Remove property.
7524 (FlowBranching.UsageVector.IsUnreachable): New property.
7525 (FlowBranching.UsageVector.ResetBarrier): New.
7526 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7527 * codegen.cs, statement.cs: Update to changes.
7529 2007-03-27 Martin Baulig <martin@ximian.com>
7534 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7537 2007-03-26 Raja R Harinath <rharinath@novell.com>
7539 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7540 instead of TriState. Remove all mention of TriState.
7542 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7543 replaced by a boolean. Add boolean 'is_unreachable' field, check
7544 and maintain invariants.
7546 2007-03-25 Marek Safar <marek.safar@gmail.com>
7548 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
7550 2007-03-25 Marek Safar <marek.safar@gmail.com>
7552 * expression.cs: Stop using obsolete 2.0 opcodes.
7554 2007-03-25 Marek Safar <marek.safar@gmail.com>
7556 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
7557 one of the latests Martin's fixes.
7559 2007-03-23 Miguel de Icaza <miguel@novell.com>
7561 * expression.cs: On BigEndian systems, swap the bytes, temporary
7562 solution until we get a new bitconverter class.
7564 2007-03-23 Martin Baulig <martin@ximian.com>
7568 * decl.cs (MemberCache.AddMembers): Add generic methods both as
7569 "Method" and "Method`1". Normally, a cache lookup is done on the
7570 "Method" form (ie. without the generic arity), but this one makes
7571 lookups on the full form work as well.
7573 2007-03-22 Raja R Harinath <rharinath@novell.com>
7575 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
7578 2007-03-20 Bill Holmes <billholmes54@gmail.com>
7580 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
7581 ordered_member_list, to TypeBuilder to store members to be defined
7582 in the order they were parsed in.
7583 - ordered_explicit_member_list contains all properties indexers
7584 and methods that are defined as explicit implementation of an
7585 interface or base class.
7586 - ordered_member_list contains all properties indexers and methods
7587 that are not defined as explicit implementation of an interface
7590 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
7591 functionality in these removed classes has been replaced with
7592 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
7593 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
7595 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
7596 to CheckForDuplications inside GetMethod and SetMethod Define Method
7597 to handle method property and indexer name conflicts.
7601 All code is contributed under the MIT/X11 license.
7603 2007-03-20 Martin Baulig <martin@ximian.com>
7605 * class.cs (TypeContainer.Interfaces): Removed; they're now
7606 included in `TypeContainer.Types'.
7608 2007-03-20 Martin Baulig <martin@ximian.com>
7610 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
7612 * class.cs (TypeContainer.CreateType): New public method. This is
7613 now called before DefineType() to create the TypeBuilders.
7614 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
7615 has already been created by CreateType().
7616 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
7617 don't resolve our base classes here; this has been moved into
7618 DefineBaseTypes(). We're now called from CreateType().
7619 (TypeContainer.DefineBaseTypes): New private method; resolve our
7620 base classes here. We're now called from DefineType().
7623 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
7624 our types first to create all the TypeBuilders. After that, call
7625 TypeContainer.DefineType() on all the types which'll resolve their
7626 base classes and setup the resolve order.
7628 2007-03-20 Martin Baulig <martin@ximian.com>
7630 * class.cs (TypeContainer.Enums): Removed; they're now included in
7631 `TypeContainer.Types'.
7633 2007-03-20 Martin Baulig <martin@ximian.com>
7636 (TypeContainer.DefineType): Don't call ResolveMembers() here.
7637 (TypeContainer.DoResolveMembers): Call DefineType() on our
7638 `compiler_generated' classes; moved here from DefineNestedTypes().
7641 (RootContext.ResolveTree): Call ResolveMembers() on all
7642 TypeContainer's in the `type_container_resolve_order'.
7644 2007-03-19 Marek Safar <marek.safar@gmail.com>
7646 * class.cs: Use corlib to handle InternalMethodImplAttribute.
7648 2007-03-17 Marek Safar <marek.safar@gmail.com>
7650 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
7651 implementation flags.
7653 2007-03-17 Marek Safar <marek.safar@gmail.com>
7655 * class.cs: More optimizations for type parameters.
7657 2007-03-15 Marek Safar <marek.safar@gmail.com>
7659 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
7661 * ecore.cs, parameter.cs: More common code for both corlibs.
7663 * typemanager.cs (IsGenericMethod): Simplified.
7665 2007-03-15 Raja R Harinath <rharinath@novell.com>
7667 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7669 * statement.cs, iterators.cs, lambda.cs: Update to changes.
7671 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
7672 unconditionally. Simplify explanation.
7673 (Try.Resolve, Using.Resolve): Likewise.
7675 2007-03-15 Martin Baulig <martin@ximian.com>
7679 * decl.cs (DeclSpace): If we're a partial class, use our
7680 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
7682 2007-03-15 Raja R Harinath <rharinath@novell.com>
7684 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7686 (FlowBranching.UsageVector): Update to changes.
7687 (FlowBranching.MergeSiblings): Likewise.
7688 * statement.cs: Likewise.
7690 2007-03-15 Martin Baulig <martin@ximian.com>
7695 (MemberCache): Added a special .ctor for type parameters.
7698 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
7701 2007-03-09 Martin Baulig <martin@ximian.com>
7703 * enum.cs (Enum): Make this a TypeContainer.
7704 (EnumMember): Derive from `Const'.
7707 (Const.DoResolveValue): New protected virtual method; move most of
7708 the functionality of ResolveValue() here so we can override it in
7710 (Const.CreateConstantReference): Make this virtual.
7712 * class.cs (Kind): Add `Kind.Enum'.
7713 (TypeContainer.Emit): Don't emit the enums here; they're already
7714 in the `RootContext.typecontainer_resolve_order'.
7716 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
7717 here; they're already in the `typecontainer_resolve_order'.
7719 * ecore.cs (EnumConstant.ConvertImplicitly): Add
7720 TypeManager.DropGenericTypeArguments().
7723 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
7724 (TypeManager.IsEnumType): Likewise.
7725 (TypeManager.EnumToUnderlying): Likewise.
7726 (TypeManager.IsEqual): Add support for enums.
7728 2007-03-12 Raja R Harinath <rharinath@novell.com>
7730 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
7731 DefaultParameterValueAttribute to be undefined, say if System.dll
7734 2007-03-11 Marek Safar <marek.safar@gmail.com>
7736 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
7739 2007-03-10 Marek Safar <marek.safar@gmail.com>
7741 * class.cs, parameter.cs: Unified parameters verification.
7743 2007-03-08 Martin Baulig <martin@ximian.com>
7745 * cs-parser.jay (constructor_header): Pass the location to the
7746 newly created TopLevelBlock.
7748 2007-03-07 Martin Baulig <martin@ximian.com>
7750 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
7752 2007-03-06 Miguel de Icaza <miguel@novell.com>
7754 * convert.cs (ExplicitReferenceConversionExists): Sync this method
7755 with the changes from David, fixes the build.
7757 2007-03-05 David Mitchell <dmitchell@logos.com>
7759 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
7760 and its base interfaces to a one-dimensional array type S[],
7761 provided there is an implicit or explicit reference conversion
7764 2007-03-03 Marek Safar <marek.safar@gmail.com>
7766 * cs-tokenizer.cs: Implemented basic linq grammar.
7768 * driver.cs: Set linq lang version on demand.
7770 2007-02-26 Marek Safar <marek.safar@gmail.com>
7772 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
7774 2007-02-25 Marek Safar <marek.safar@gmail.com>
7776 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
7779 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
7781 Check property and event extern attributes.
7783 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
7786 2007-02-24 Marek Safar <marek.safar@gmail.com>
7788 A fix for bug #80407
7789 * ecore.cs: Don't report ambiguity error when methods have same parent.
7791 2007-02-23 Marek Safar <marek.safar@gmail.com>
7793 A fix for bug #80878
7794 * class.cs, cs-parser.jay: Event property can host anonymous methods.
7796 2007-02-22 Marek Safar <marek.safar@gmail.com>
7798 * attribute.cs: Enable ExtensionAttribute presence test.
7800 2007-02-22 Marek Safar <marek.safar@gmail.com>
7802 * class.cs: Warn about missing GetHashCode only when Equals is override.
7804 * decl.cs: Check accessibility of type arguments.
7806 * typemanager.cs: Correctly report nullable array.
7808 2007-02-20 Marek Safar <marek.safar@gmail.com>
7810 * class.cs, report.cs: Capture more details when things go wrong.
7812 2007-02-20 Marek Safar <marek.safar@gmail.com>
7814 A fix for bug #80650
7815 * cs-parser.jay: Anonymous container starts at constructor declaration
7816 and not at block beginning because it has to be usable in constructor
7819 * statement.cs: Use context location and not block one for error reporting.
7821 2007-02-18 Marek Safar <marek.safar@gmail.com>
7823 A fix for bug #78712
7824 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
7827 2007-02-18 Marek Safar <marek.safar@gmail.com>
7829 A fix for bug #80493 by Atsushi Enomoto
7830 * cs-parser.jay: Ignore invalid attribute target.
7832 2007-02-18 Marek Safar <marek.safar@gmail.com>
7834 * cs-tokenizer.cs: Ignore '\0' as white space character.
7836 2007-02-17 Miguel de Icaza <miguel@novell.com>
7838 * cs-parser.jay: Add support for lambda expressions to the mcs
7841 * lambda.cs: Only clone when we are probing, not on the final call
7842 (Compatible is the final call).
7844 * statement.cs (CloneContext): Introduce class to provide block
7845 remapping during clone.
7847 All statements Clone themselves now.
7849 (Clone): special handling for blocks, when we clone a block, we
7850 register the block inside this routine, as children of the block
7851 might trigger a lookup.
7853 * expression.cs: Add support for CloneContext in all expressions.
7855 2007-02-17 Marek Safar <marek.safar@gmail.com>
7857 A fix for bug #80493
7858 * statement.cs: Report ambiguous warning when interfaces are not related.
7860 2007-02-15 Marek Safar <marek.safar@gmail.com>
7862 C# 3.0 extension methods.
7864 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
7865 cannot be used directly.
7867 * class.cs (Class.Emit): Emit extension attribute if any class method
7868 is extension method.
7869 (Method.Define): Add basic extension method validation conditions.
7870 (Method.Emit): Emit extension attribute for method.
7872 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
7873 extension method exists. Currently we follow same approach as Microsoft
7874 does, emit even if a method or a class are private but this can change
7877 * cs-parser.jay: Add handling of `this' keyword in method parameters
7880 * decl.cs (DeclSpace.IsStaticClass): New property.
7881 (MemberCache.FindExtensionMethods): Looks for extension methods with
7882 defined name and extension type.
7884 * doc.cs: Updated after OverloadResolve changes.
7886 * driver.cs: Add new soft reference to System.Core.dll.
7888 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
7889 (ExtensionMethodGroupExpr): Represents group of extension methods.
7891 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
7892 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
7893 to MethodGroupExpr and made non-static for easier customization.
7894 (Invocation.DoResolve): Add extension method lookup when no standard
7896 (MemberAccess.DoResolve): Try extension methods if no member exists.
7898 * modifiers.cs: Add METHOD_EXTENSION modifier.
7900 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
7901 as well as candidate extension type.
7902 (ComputeNamespaces): When assembly constains extension methods registers
7904 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
7905 extension method lookup.
7906 (Namespace.LookupExtensionMethod): Looks for extension method in this
7908 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
7909 find a method which matches name and extensionType.
7911 * parameter.cs (Parameter): Add This modifer.
7912 (HasExtensionMethodModifier): New property.
7913 (Resolve): Add extension parameter check.
7914 (ModFlags): turned to property to exclude this modifier as it is not real
7916 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
7918 * support.cs (ParameterData): Add ExtensionMethodType.
7919 (ReflectionParameters): Implemented ExtensionMethodType interface property.
7921 * typemanager.cs: Add type and ctor extension attribute type.
7923 2007-02-15 Miguel de Icaza <miguel@novell.com>
7925 * report.cs (DisableErrors, EnableErrors): used to prevent error
7926 output when we are "trying" to compile various methods with
7929 * ecore.cs (Expression): Add Clone method that calls the virtual
7930 CloneTo method. The current CloneTo method in Expression throws
7931 an exception so we can track down all the places where this must
7932 be implemented (not using abstract, because that would be a lot of
7933 up-front-work before we can start testing the implementation
7936 Important: we only need Clone capabilities for expressions created
7937 by the parser, as the expressions we will be cloning are
7938 expressions in the pre-resolved state. This vastly simplifies
7941 (SimpleName): Add CloneTo that does nothing.
7942 (EmptyCast): Add CloneTo.
7944 * expression.cs (Binary): Implement CloneTo.
7945 (Invocation.IsApplicable): Store the current ec in
7946 EmitContext.TempEc and restore it on return. This is used so we
7947 do not have to sprinkle hundres of methods with an extra
7948 EmitContext, we know that the only user is the lambda expression
7949 ImplicitConversionExists code.
7951 (Argument): Add Cloning capabilities.
7952 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
7953 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
7954 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
7955 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
7956 IndexerAccess): Add Clone capability.
7958 (LocalVariableReference, This): TODO: needs cloned Block mapping.
7960 (Argument): Add cloning capability.
7962 * assign.cs (Assign): Implement CloneTo.
7964 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
7966 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
7967 version by calling Convert with the EmitContext (that we are
7968 currently storing in ec, this is not great, but will do for now,
7969 to avoid passing EmitContext parameters to hundreds of functions
7970 that do not need them now).
7972 (SetExpression): Remove, it is not needed.
7974 (ContextualReturn): Implement CloneTo.
7976 * statement.cs (Statement): Implement cloning infrastructure,
7977 similar to expressions.
7979 (Block): Partial implementation of Clone for statements.
7981 (Return): Implement clone.
7983 * constant.cs (Constant.CloneTo): New method, does nothing.
7985 * codegen.cs (TempEc): Add a static EmitContext as a temporary
7986 solution, until we decide how to exactly do this.
7988 2007-02-14 Marek Safar <marek.safar@gmail.com>
7990 A fix for bug #80493
7991 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
7992 a property is override we need to use second accessor.
7994 2007-02-13 Marek Safar <marek.safar@gmail.com>
7996 A fix for bug #80418
7997 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8000 2007-02-13 Marek Safar <marek.safar@gmail.com>
8002 Another fix for bug #80749
8003 * pending.cs: Abstract class has priority over interfaces.
8005 2007-02-13 Marek Safar <marek.safar@gmail.com>
8007 Another fix for bug #80749
8008 * pending.cs: Abstract class has priority over interfaces.
8010 2007-02-13 Marek Safar <marek.safar@gmail.com>
8012 Another fix for bug #80749
8013 * pending.cs: Abstract class has priority over interfaces.
8015 2007-02-13 Marek Safar <marek.safar@gmail.com>
8017 Another fix for bug #80749
8018 * pending.cs: Abstract class has priority over interfaces.
8020 2007-02-13 Marek Safar <marek.safar@gmail.com>
8022 * class.cs Better error message.
8024 * driver.cs: Add shorter versions of -optimize option.
8026 2007-02-13 Martin Baulig <martin@ximian.com>
8028 * class.cs (Constructor.Emit): Check the return value of
8029 ec.ResolveTopBlock() and return on error.
8031 2007-02-13 Raja R Harinath <rharinath@novell.com>
8033 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8034 message to fix error message regression.
8036 2007-02-12 Marek Safar <marek.safar@gmail.com>
8038 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8040 2007-02-12 Marek Safar <marek.safar@gmail.com>
8042 A fix for bug #80749
8043 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8044 its parent container.
8046 * class.cs (DefineFieldInitializers): Each initializer can has different
8049 * const.cs: Updated.
8051 2007-02-11 Miguel de Icaza <miguel@novell.com>
8053 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8054 now all the heavy lifting to check that embedded statements or
8055 expressions have the right form is done in the ContextualReturn.
8057 (ContextualReturn): New class.
8059 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8060 method that can be invoked to report 201, so we do not replicate
8063 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8065 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8066 treating tabs as spaces.
8068 2007-02-09 Marek Safar <marek.safar@gmail.com>
8070 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8071 * assign.cs: Use full implicit conversion for right side check.
8073 2007-02-09 Marek Safar <marek.safar@gmail.com>
8075 * statement.cs (Switch): Switch over boolean type is not standardized.
8077 2007-02-08 Marek Safar <marek.safar@gmail.com>
8079 A fix for bug #80755
8080 * decl.cs (FindBaseEvent): Don't use method cache for events.
8082 2007-02-07 Marek Safar <marek.safar@gmail.com>
8084 * cs-parser.jay: Better syntax error handling.
8086 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8087 instead of underlying type value.
8089 2007-02-06 Marek Safar <marek.safar@gmail.com>
8091 * driver.cs: Check define identifier before is registered.
8093 * namespace.cs: Use existing error message.
8095 * report.cs: New warning.
8097 2007-02-06 Marek Safar <marek.safar@gmail.com>
8099 A fix for bug #80742
8100 * expression.cs: Delegate Invoke method can be called directly.
8102 2007-02-06 Marek Safar <marek.safar@gmail.com>
8104 A fix for bug #80676
8105 * class.cs (IsEntryPoint): The Main method can have params modifier.
8107 2007-02-04 Miguel de Icaza <miguel@novell.com>
8109 * parameter.cs (Parameter, Parameters): Add Clone method.
8111 * anonymous.cs (Compatible): Turn method into virtual method, so
8112 LambdaExpression can implement a different behavior.
8114 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8115 out the basic checking here, so it can be used by
8118 * lambda.cs: Introduce "Compatible" function that will do the
8121 2007-02-02 Marek Safar <marek.safar@gmail.com>
8123 * attribute.cs: Unified one error message.
8125 * class.cs (Class): Use type attributes and not properties to test static
8127 (IsEntryPoint): Don's pass local variable.
8129 * convert.cs: Removed duplicate check.
8131 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8133 * driver.cs: Don't crash when soft reference does not exist.
8135 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8136 (UsingEntry): Removed redundant allocation.
8138 * parameter.cs: Add fast path for type parameters.
8140 * support.cs: Don't allocate attribute when it's not used.
8142 2007-01-30 Miguel de Icaza <miguel@novell.com>
8145 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8146 this into a virtual method, so we can override it in LambdaExpression.
8148 * driver.cs: Improve diagnostics in case of failure.
8150 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8151 write a function that is slightly more complex and that parses:
8153 type identifier [, type identifier]* )
8155 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8158 (canEmpty ? i >= 0 : i > 0)
8160 2007-01-30 Raja R Harinath <rharinath@novell.com>
8162 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8163 exception on possibly valid code.
8165 2007-01-29 Raja R Harinath <rharinath@novell.com>
8167 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8169 (parse_opt_type_arguments): Remove. It's almost the same as
8171 (parse_namespace_or_typename): Use parse_less_than.
8173 2007-01-28 Miguel de Icaza <miguel@novell.com>
8175 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8176 this bug took a few hours to find, because the state saved and
8177 restored by PushPosition and PopPosition was ignoring the state of
8178 parse_generic_less_than.
8180 I can also now remove the handling of OP_LT and OP_GT, this solves
8183 * cs-tokenizer.cs: store the location for the ARROW token, we use
8186 (PushPosition, PopPosition): save/restore also `current_token',
8187 restore `parse_generic_less_than' (was missing).
8189 (parse_opt_type_arguments): use parse_type, not
8190 parse_namespace_or_typename to parse types.
8192 * lambda.cs: Empty new file, will eventually have the lambda
8193 expression implementation.
8195 * lambda.test: used to test the internal tokenizer.
8197 * report.cs (FeatureIsNotISO1): Rename from
8198 FeatureIsNotStandardized, because it was about the language level
8199 (1 vs 2) it was not about standarization.
8201 (FeatureRequiresLINQ): New.
8203 * support.cs (SeekableStreamReader): Only require that the reader
8204 is a TextReader, not a StreamReader, so we can plug StringReader.
8206 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8207 given position in the input stream the following tokens can be
8208 parsed as a type followed by an identifier.
8210 (is_punct): after a '(' if parse_type_and_parameter returns true,
8211 then return a special token OPEN_PARENS_LAMBDA which is used to
8212 avoid reduce/reduce errors in the grammar for the
8213 lambda_expression rules.
8215 (parse_type): implement a type parser inside the
8216 tokenizer, the parser only returns true or false depending on
8217 whether the input at a given position can be parsed as a type.
8219 (peek_token): new method used during type parsing.
8221 2007-01-28 Raja R Harinath <rharinath@novell.com>
8224 * anonymous.cs (ScopeInfo.InflateParameters): New.
8225 (AnonymousContainer.Resolve): Use it to redirect types of
8226 delegate parameters.
8228 2007-01-27 Raja R Harinath <rharinath@novell.com>
8231 * expression.cs (Error_InvalidArguments): Don't use two different
8232 messages for CS1503. Use ExtraInformation and
8233 SymbolRelatedToPreviousError instead.
8236 * decl.cs (DeclSpace.initialize_type_params): Don't access
8237 'type_params' of a partial class directly.
8239 2007-01-26 Miguel de Icaza <miguel@novell.com>
8241 * constant.cs: Removed a handful of out-of-range checks that were
8244 2007-01-25 Marek Safar <marek.safar@gmail.com>
8246 * expression.cs (CheckUselessComparison): Add additional check for char
8249 * namespace.cs: Fixed typo.
8251 2007-01-23 Miguel de Icaza <miguel@novell.com>
8253 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8254 gone, instead we inline the test, preventing the needless casts to
8255 longs, ulongs and doubles for the parameters, avoiding calls to
8256 methods that overchecked stuff, and instead inlined things
8259 2007-01-20 Marek Safar <marek.safar@gmail.com>
8261 * cs-parser.jay: Better parameter error handling.
8263 2007-01-17 Marek Safar <marek.safar@gmail.com>
8265 A fix for bug #80368, #80522
8266 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8267 whether array initializer contains constants only.
8268 (ArrayCreation.Emit): Use better formula to decide when
8269 are array initializers for static initialization.
8270 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8271 have to emit even constants otherwise they are pre-initialized.
8273 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8274 Raja R Harinath <rharinath@novell.com>
8276 Fix emit order of 'get' vs. 'set'.
8277 * support.cs (Accessors): New.
8278 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8279 Note the order in which accessors are declared in the source.
8280 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8281 Refactored from Property.Define and Indexer.Define.
8282 (PropertyBase.DefineAccessors): New helper that calls the above in
8283 appropriate order as noted by the parser.
8284 (Property.Define, Indexer.Define): Update to changes.
8285 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8287 2007-01-17 Raja R Harinath <rharinath@novell.com>
8289 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8290 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8291 there's an implicit conversion from the current type to the target
8292 type before converting the underlying constant.
8294 2007-01-16 Marek Safar <marek.safar@gmail.com>
8296 * const.cs (ResolveValue): Updated after constant conversion was made more
8299 * constant.cs (GetAttributableValue): constant to object conversion is
8300 used for attributes only.
8301 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8302 constant conversions.
8303 (LongConstant.ConvertImplicitly): Ditto.
8305 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8306 (ImplicitConversionStandard): Handle constant conversion as extra step.
8307 It solves the issue when constant conversion was called indirectly like
8308 inside array initializer and constant folding was skipped.
8310 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8313 * statement.cs(ImplicitConversionStandard): Updated after constant
8314 conversion was made more generic.
8316 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8318 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8319 Constraints, solves the problem where the compiler incorrectly
8320 reported that a type parameter was not constrained to a class (Bug
8323 2007-01-14 Marek Habersack <grendello@gmail.com>
8325 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8327 2007-01-14 Marek Safar <marek.safar@gmail.com>
8329 A fix for bug #80368
8330 * assign.cs (FieldInitializer): New class implements field
8331 initializer statement.
8333 * attribute.cs: Update after FieldMember rename.
8335 * class.cs (PropertyBasedMember): New common class for property based
8337 (InterfaceMemberBase): New base class for all members which can be used as
8338 an interface members.
8339 (MethodCore): Moved really common code to InterfaceMemberBase.
8340 (Method.Define): Equal and GetHasCode detection is relevant for methods
8342 (MethodData.Define): Don't assume that public event implements an
8343 interface automatically.
8344 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8346 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8347 (FieldMember): Merged with FieldBase.
8348 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8349 event extern modifier can be used.
8350 (EventField.EventFieldAccessor): Moved event field specific code here.
8351 (Event.AllowedModifiers): Even event can be extern.
8352 (Event.FindOutBaseMethod): New override specific to events.
8353 (Indexer.parameters): Reintroduce parameters because base class holds
8354 only properties common data.
8355 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8356 need do extra parameters check.
8358 * const.cs: Update after FieldMember rename.
8360 * decl.cs (MemberCache.FindBaseEvent): New method.
8362 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8363 to reflect that indexer is now derived from PropertyBased.
8365 * ecore.cs (GetMemberType): Made public.
8366 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8369 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8371 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8372 (RegisterEvent): Removed.
8373 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8374 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8376 2007-01-11 Raja R Harinath <rharinath@novell.com>
8379 * statement.cs (CollectionForeach.TryType): Prefer generic
8380 GetEnumerator over non-generic variant. Fix code to follow comments.
8382 2007-01-09 Raja R Harinath <rharinath@novell.com>
8385 * support.cs (ReflectionParameter): Don't use an invalid index on
8386 the generic parameter data.
8388 2007-01-08 Miguel de Icaza <miguel@novell.com>
8390 * driver.cs: Just add a tiny bit of infrastructure.
8392 2007-01-02 Marek Safar <marek.safar@gmail.com>
8394 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8395 where field type is struct from current assembly.
8397 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8400 2007-01-02 Marek Safar <marek.safar@gmail.com>
8402 A fix for bug #80381
8403 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8406 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8408 (Namespace.LookupType): Always use core types from corlib when speficied.
8410 * report.cs: A new warning.
8412 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8413 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8414 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8416 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8417 (InitCoreTypes): Set expression type of object_type and value_type
8418 immediately after lookup.
8420 2007-01-01 Miguel de Icaza <miguel@novell.com>
8422 * cs-tokenizer.cs: Accept Pc class characters (Connector
8423 Punctuation) as valid identifiers. Fixes #78259
8425 * expression.cs (Invocation.DoResolve): Moved the check for the
8426 use of `this' for doing method calls to the Invocation resolution
8427 step, after overload resolution has taken place instead of doing
8428 the check at the low-level `This.DoResolve' level.
8430 The `This.DoResolve'(appens before overload resolution, so it has
8431 no way of knowing if the method that will be called will be
8432 instace or static, triggering an erroneous report for cs0188 (Bug
8435 We now do the check for instance method invocations after we know
8436 what method will be called.
8438 (This.CheckThisUsage): Move the actual use of this structure
8439 checking into its own method and expose it.
8441 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8444 Exceptions: Null.ConvertImplicitly,
8445 Constant.ImplicitConversionRequired as there are too many call
8446 sites for passing the ec.
8448 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8449 EmitContext, if the value is null, then we do not try to provide
8450 the extra information from the error (If a userdefined conversion
8451 exists, as UserDefinedConversion requires a non null-EmitContext).
8455 2006-12-30 Raja R Harinath <rharinath@novell.com>
8457 * flowanalysis.cs (MyBitVector): Document some invariants.
8458 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8459 introduced below, and add a couple of others,
8461 2006-12-30 Marek Safar <marek.safar@gmail.com>
8463 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8464 GetPropertyFromAccessor and GetEventFromAccessor.
8466 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8467 overrides non-obsolete one.
8468 (Indexer.Define): Error message has been moved to the parser.
8470 * cs-parser.jay: Better syntax errors handling.
8472 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8473 when an invocation has no arguments.
8475 * ecore.cs: Removed not used caching.
8477 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8480 * report.cs: Add a new warning.
8482 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8484 * typemanager.cs (enumeration_type): Removed.
8485 (CSharpSignature): Reuses IsSpecialMethod.
8486 (IsEqual): Hack for MS BCL.
8487 (GetPropertyFromAccessor): New method.
8488 (GetEventFromAccessor): New method.
8489 (IsSpecialMethod): Fixed to handle more cases.
8491 2006-12-30 Marek Safar <marek.safar@gmail.com>
8493 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8494 Made white spaces array static.
8496 * ecore.cs (RemoveGenericArity): Optimized.
8498 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8500 (MyBitVector.initialize_vector): Simplified.
8502 2006-12-22 Miguel de Icaza <miguel@novell.com>
8504 * ecore.cs: Am not entirely happy with this hack, but it seems to
8505 address the issue in 80257 (a small test case for
8508 I set the MethodGroupExpr.Type to an internal compiler type
8509 (itself in this case) to force the resolution to take place. Why
8510 it does not take place with a null is beyond me.
8512 2006-12-20 Marek Safar <marek.safar@gmail.com>
8514 A fix for bug #80288
8515 * expression.cs (ResolveOperator): Consider user defined conversion for
8516 logical and operator too.
8517 (EmitBranchable): Optimization for logical and when full constant folding
8518 could not be applied but one operand is constant.
8520 2006-12-19 Marek Safar <marek.safar@gmail.com>
8522 * class.cs (GetClassBases): Write 5 times every day, will never use
8523 FullName for error reporting.
8525 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8527 2006-12-19 Martin Baulig <martin@ximian.com>
8529 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8530 the symbol file info here.
8532 2006-12-18 Marek Safar <marek.safar@gmail.com>
8534 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8535 of `elseif' is taking then following sections are not taking.
8536 Fixes an issue reported on mono mailing list.
8538 2006-12-18 Marek Safar <marek.safar@gmail.com>
8540 A fix for bug #80300
8541 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8542 a caller is not taking.
8544 2006-12-18 Raja R Harinath <rharinath@novell.com>
8546 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
8547 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
8548 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
8549 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
8550 * class.cs: Update to changes.
8552 2006-12-17 Marek Safar <marek.safar@gmail.com>
8554 A fix for bug #79934
8555 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
8558 * class.cs (ResolveMembers): Register an iterator in current container and
8561 2006-12-16 Raja R Harinath <rharinath@novell.com>
8564 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
8565 satisfy a params annotated parameter.
8567 2006-12-16 Marek Safar <marek.safar@gmail.com>
8569 A fix for bug #77014
8570 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
8571 paramters correctly and not rely on hacks in Parameters class.
8572 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
8574 (Invocation.VerifyArgumentsCompat): Ditto.
8575 (Invocation.EmitArguments): Changed to correctly emit params arguments at
8578 * parameter.cs (HasParams): Don't assume that params is the last one.
8580 * support.cs (ReflectionParameters.ctor): Look for params attribute
8582 (ReflectionParameters.ParameterType): Removed hack when we returned last
8583 parameter for out of range parameters.
8584 (ParameterName, ParameterModifier): Ditto.
8586 2006-12-14 Marek Safar <marek.safar@gmail.com>
8588 A fix for bug #79987
8589 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
8590 when assembly is not CLS compliant but type is. I have no idea why is this
8593 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
8595 2006-12-13 Miguel de Icaza <miguel@novell.com>
8597 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
8598 in struct constructors, they are basically no-ops.
8600 2006-12-12 Marek Safar <marek.safar@gmail.com>
8602 * cs-tokenizer.cs (Position): Save preprocessor status too.
8604 2006-12-12 Marek Safar <marek.safar@gmail.com>
8606 A fix for bug #77794
8607 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
8609 2006-12-12 Marek Safar <marek.safar@gmail.com>
8611 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
8613 (pp_expr): Report error for an invalid expression.
8614 (handle_preprocessing_directive): Simplified; add more error checking.
8616 2006-12-11 Marek Safar <marek.safar@gmail.com>
8618 A fix for bug #74939
8619 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
8620 directives handling.
8622 2006-12-10 Marek Safar <marek.safar@gmail.com>
8624 A fix for bugs #80093, and #75984
8625 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
8626 logic, it seems to me as it worked before "by coincidence".
8627 (xtoken): Simplified to use reworked handle_preprocessing_directive.
8628 (cleanup): Enabled endif check.
8630 2006-12-09 Marek Safar <marek.safar@gmail.com>
8632 A fix for bug #80162
8633 * statement.cs (CollectionForeach.TryType): Generics and non-generics
8634 enumerators are never ambiguous.
8636 2006-12-08 Raja R Harinath <rharinath@novell.com>
8639 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
8641 2006-12-06 Marek Safar <marek.safar@gmail.com>
8643 A fix for bug #80144
8644 * class.cs (EventProperty.Define): Explicit implementation means
8645 that an even is used.
8647 2006-12-06 Marek Safar <marek.safar@gmail.com>
8649 Fixes the operators implementation (part II)
8651 * cfold.cs (DoConstantNumericPromotions): Renamed to
8652 DoBinaryNumericPromotions and simplified.
8653 (BinaryFold): Couple of conversion fixes; simplified.
8655 * constant.cs, ecore.cs, literal.cs
8656 (ToType): Renamed to ConvertImplicitly.
8657 (Reduce): Renamed to ConvertExplicitly.
8659 * class.cs, convert.cs: Updated.
8661 * expression.cs: TryReduce doesn't throw an exception.
8663 2006-12-01 Marek Safar <marek.safar@gmail.com>
8665 A fix for bug #80108
8666 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
8669 2006-11-30 Marek Safar <marek.safar@gmail.com>
8671 Fixes unary operators implementation (part I)
8674 * cfold.cs (Error_CompileTimeOverflow): Made internal
8676 * const.cs (IConstant): Changed to use reference to constant and
8677 not constant itself.
8678 Updated IConstant implementations.
8680 * constant.cs (CreateConstant): New factory method.
8681 Updated IConstant implementation.
8683 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
8685 * ecore.cs: Updated to use CreateConstantReference.
8687 * enum.cs: Reflects IConstant changes.
8689 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
8691 * literal.cs (NullConstant): Change to be independently usable.
8693 2006-11-29 Martin Baulig <martin@ximian.com>
8695 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
8696 we need to emit the scope initializer before calling the base .ctor.
8698 * anonymous.cs: Merged back from the new anonymous methods branch.
8699 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
8701 * expression.cs (ParameterReference.DoResolveBase): Create a
8702 "normal" ScopeInfo when capturing parameters rather than using the
8703 root scope; this makes things work with anonymous methods having
8707 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
8709 2006-11-22 Marek Safar <marek.safar@gmail.com>
8711 A fix for bug #79987
8712 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
8713 check to a base class.
8714 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
8715 only when assembly has missing attribute.
8716 * report.cs: Update.
8718 2006-11-21 Marek Safar <marek.safar@gmail.com>
8720 * cs-tokenizer.cs: Merged with gmcs version.
8722 2006-11-20 Marek Safar <marek.safar@gmail.com>
8725 * cs-parser.jay: Better error message when partial keyword is misplaced.
8727 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
8729 A fix for bug #79810
8730 report.cs: CS1058 only applies to 2.0 profile (gmcs).
8731 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
8732 a RuntimeWrappedException by default.
8734 2006-11-18 Marek Safar <marek.safar@gmail.com>
8736 A fix for bug #79843
8737 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
8739 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
8741 2006-11-18 Marek Safar <marek.safar@gmail.com>
8743 * driver.cs, namespace.cs: Uses faster IndexOf version.
8745 2006-11-17 Marek Safar <marek.safar@gmail.com>
8747 A fix for bug #79941
8748 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
8750 (Operator.Define): Implicit/Explicit operator of same type is duplicate
8751 even if internal name is different.
8752 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
8753 (UserDefinedConversion): Simplified as the operators cannot be internal.
8754 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
8756 (MethodLookup): Replaced EmitContext with parentType.
8757 * expression.cs: Updated.
8759 2006-11-09 Raja R Harinath <rharinath@novell.com>
8761 * driver.cs (BadAssembly): Handle all the ugliness of
8762 DefineDynamicAssembly.
8764 2006-11-08 Raja R Harinath <rharinath@novell.com>
8766 Address parts of #58244 -- most of what's left is in the runtime
8767 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
8768 CS1509 error checks, and handle them for all assembly loads, not
8769 just the first invocation.
8770 (LoadModule): Likewise. Move handling of 'adder_method' ...
8771 * codegen.cs (AssemblyClass.AddModule): ... here.
8773 2006-11-02 Marek Safar <marek.safar@gmail.com>
8775 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
8776 IEnumerable<T> is ambiguous.
8778 2006-10-31 Marek Safar <marek.safar@gmail.com>
8780 A fix for bug #67689
8781 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
8782 GetEnumerator is ambiguous.
8784 * report.cs: Add new warning.
8786 2006-10-29 Marek Safar <marek.safar@gmail.com>
8788 A fix for bug #78602
8789 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8790 to protected member can be nested type.
8792 2006-10-28 Marek Safar <marek.safar@gmail.com>
8794 A fix for bug #78965
8795 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8796 to protected member must derive from current type.
8798 2006-10-27 Marek Safar <marek.safar@gmail.com>
8800 assign.cs: Reuses error method.
8802 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
8803 instead of type for constants.
8804 (Expression.Error_ValueAssignment): Common error method.
8806 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
8809 2006-10-27 Marek Safar <marek.safar@gmail.com>
8811 A fix for bug #79081
8812 * expression.cs (MemberAccess.DoResolve): Check nested type
8815 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
8817 * doc.cs : nested delegates were not handled. Fixed bug #79754.
8819 2006-10-26 Marek Safar <marek.safar@gmail.com>
8821 A fix for bug #76591
8822 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
8824 2006-10-26 Marek Safar <marek.safar@gmail.com>
8826 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
8827 type forwarder of the same type multiple times.
8829 2006-10-26 Raja R Harinath <rharinath@novell.com>
8832 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
8833 instance as an rvalue, even when we later resolve as an lvalue.
8835 2006-10-25 Martin Baulig <martin@ximian.com>
8837 * anonymous.cs: Fix #79673.
8839 2006-10-24 Marek Safar <marek.safar@seznam.cz>
8841 A fix for bug #79666
8842 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
8843 ignored when is optimized (= default value) as its value is already set.
8845 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8847 A fix for bug #79724
8848 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
8849 TypeContainer for type lookup.
8851 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8853 A fix for bug #79231
8854 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
8855 * expression.cs (OverloadResolve): Always convert type name for
8857 (ResolveNamespaceOrType): Don't confuse a nested type with any
8860 2006-10-18 Martin Baulig <martin@ximian.com>
8862 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
8864 2006-10-17 Miguel de Icaza <miguel@novell.com>
8866 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
8867 an int32, but requesting an int64 from the conversion
8869 2006-10-12 Martin Baulig <martin@ximian.com>
8872 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
8874 2006-10-12 Martin Baulig <martin@ximian.com>
8877 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
8879 2006-10-11 Miguel de Icaza <miguel@novell.com>
8881 * convert.cs: Remove broken code: I was doing the "Existance"
8882 tests for Implicit conversions.
8884 2006-10-10 Miguel de Icaza <miguel@novell.com>
8886 * convert.cs: Added one missing case in
8887 ImplicitStandardConversionExists uint64 to intptr.
8891 * typemanager.cs (uintptr_type): another core known type.
8893 * ecore.cs (OperatorCast): routine used to do cast operations that
8894 depend on op_Explicit. We could change some of the Decimal
8895 conversions to use this.
8897 This one has a probe mechanism that checks both types for an op_
8898 which it coudl be used to eliminate two classes: CastToDecimal
8899 and CastFromDecimal.
8901 * convert.cs: Implement the conversions documented in #59800
8903 2006-10-10 Martin Baulig <martin@ximian.com>
8905 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
8906 before RootScope.ResolveMembers().
8908 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
8909 `CurrentType' if appropriate.
8911 2006-10-09 Marek Safar <marek.safar@seznam.cz>
8913 A fix for bug #78568
8914 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
8915 when contains binary operators.
8916 * cs-parser.jay: Updated.
8918 2006-10-09 Martin Baulig <martin@ximian.com>
8921 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
8922 moved that into Define() and also do the other type parameter
8923 checks there. Fixes #79094. Added gtest-292.cs.
8926 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
8927 since that doesn't include type parameters; don't use `Ldelema'
8928 for type parameters. Fixes #78980. Added gtest-293.cs.
8930 2006-10-08 Marek Safar <marek.safar@seznam.cz>
8933 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
8934 conversion is allowed.
8936 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8938 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
8939 error reporting when no error occurs.
8941 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8943 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
8946 2006-10-06 Raja R Harinath <rharinath@novell.com>
8949 * class.cs (DefineTypeBuilder): Check circular dependencies before
8950 setting the parent of the TypeBuilder.
8951 (CheckRecursiveDefinition): Don't use 'BaseType', since
8952 it may not be valid until after DefineTypeBuilder. Use
8953 'base_type' instead.
8955 2006-10-04 Martin Baulig <martin@ximian.com>
8957 Merged the Anonymous Methods patch.
8959 * anonymous.cs, iterators.cs: The new anonymous methods code.
8961 * statement.cs (Variable): New public abstract class.
8962 (LocalInfo.Variable): New public property.
8963 (LocalInfo.ResolveVariable): New public method.
8964 (Block.Flags): Add `IsIterator'.
8965 (Block.AddVariable): Improved the CS0136 check.
8966 (Block.AnonymousChildren): New public property.
8967 (Block.AddAnonymousChild): New public method.
8968 (ToplevelBlock): Update to use the new anonymous method framework.
8969 (ToplevelBlock.ctor): `container' is now a `Block' and not a
8970 `ToplevelBlock'; this is required to correctly implement the
8972 (Fixed, Using): Use `TemporaryVariable' instead of directly
8973 creating the `LocalBuilder'.
8975 * parameter.cs (Parameter.ResolveVariable): New public method.
8976 (Parameters.ResolveVariable): Likewise.
8978 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
8980 * class.cs (TypeContainer): Replaced the `iterators' list and
8981 corresponding methods with a list of `CompilerGeneratedClass'es.
8982 (TypeContainer.ResolveMembers): New public method.
8983 (Method): `IIteratorContainer' has been replaced by
8986 * expression.cs (VariableReference): New public abstract base
8987 class for `LocalVariableReference', `ParameterReference' and
8990 * codegen.cs (EmitContext): Removed `capture_context',
8991 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
8992 (EmitContext.EmitThis): Removed.
8994 * cs-parser.jay: Replace `iterator_container' with
8997 2006-10-04 Martin Baulig <martin@ximian.com>
8999 * generic.cs (GenericMethod): Don't make this abstract.
9000 (Constraints.Clone): Added dummy implementation.
9002 2006-10-04 Raja R Harinath <harinath@gmail.com>
9005 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9006 'declspaces'. Avoid allocating arrays willy-nilly.
9009 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9010 cases out of the switch.
9012 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9014 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9015 message when non-generic type is used with the type arguments.
9016 * expression.cs: Updated.
9018 2006-09-28 Raja R Harinath <rharinath@novell.com>
9021 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9022 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9023 Change semantics slightly. Don't insist on having only one
9024 temporary EmptyExpression -- just throttle the creation of new ones.
9027 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9028 non-interfaces too. If no methods are found, don't try to create
9031 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9033 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9036 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9037 us produce better error message.
9039 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9041 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9042 of the `|' operator.
9044 * report.cs: A new warning added.
9046 2006-09-27 Martin Baulig <martin@ximian.com>
9048 * generic.cs (GenericMethod): Don't make this abstract.
9050 2006-09-27 Martin Baulig <martin@ximian.com>
9053 (InternalErrorException): Added overloaded ctor taking a params array.
9055 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9057 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9058 Fixed the cases when same error was reported twice.
9060 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9061 now report symbol information.
9063 2006-09-25 Martin Baulig <martin@ximian.com>
9065 * class.cs: Completely unified with the gmcs version.
9067 2006-09-25 Martin Baulig <martin@ximian.com>
9069 * typemanager.cs (TypeManager.IsNullableType): New public function.
9070 (TypeManager.IsNullableTypeOf): Likewise.
9071 (TypeManager.IsNullableValueType): Likewise.
9073 * class.cs (MethodCore): Added the `GenericMethod' argument from
9074 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9076 2006-09-24 Raja R Harinath <harinath@gmail.com>
9078 * convert.cs: Unify with gmcs version.
9080 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9082 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9083 verify them as well.
9085 * report.cs: New warning.
9087 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9089 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9090 for anonymous block with out argument.
9092 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9094 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9095 not used private events only.
9097 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9099 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9101 * const.cs (Const.Define): Check for constant type.
9102 (Const.IsConstantTypeValid): Looks for valid constant types.
9104 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9106 * ecore.cs (EmptyConstantCast): New common class for all constant based
9109 * expression.cs (Is.DoResolve): Handle null constant especially.
9110 (New.DoResolve): Check for new void().
9111 (MemberAccess.DoResolve): Cope with all kind of nulls.
9113 * literal.cs (NullConstant): Uses EmptyConstantCast.
9114 (NullDefault): Based on EmptyConstantCast.
9115 (NullLiteral): Uses EmptyConstantCast.
9117 * statement.cs (Block.ResolveMeta): Check for constant type.
9119 2006-09-22 Martin Baulig <martin@ximian.com>
9121 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9123 2006-09-22 Raja R Harinath <rharinath@novell.com>
9125 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9129 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9130 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9133 2006-09-22 Martin Baulig <martin@ximian.com>
9135 * ecore.cs: Merged with the gmcs version.
9137 * generic.cs (ConstructedType): New dummy class.
9138 (TypeArguments): Don't make this abstract.
9141 (TypeManager.IsGenericTypeDefinition): New method.
9142 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9144 2006-09-22 Raja R Harinath <rharinath@novell.com>
9146 * expression.cs (ComposedCast): Check for arrays of TypedReference
9147 before creating the type, not after.
9149 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9151 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9152 after ToType change.
9154 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9155 when constant must be implicitly convertible.
9157 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9159 * ecore.cs (NullCast): Derives from NullConstant.
9161 * expression.cs (Is.DoResolve): Removed useless variables.
9162 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9163 (New.Constantify): Add enum support.
9164 (MemberAccess.DoResolve): Add warning when accessing null constant or
9167 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9170 * literal.cs (NullConstant): New abstract class with common
9171 functionality for all null specializations.
9172 (NullDefault): Represents default(X) when result can be
9174 (NullLiteral): Updated.
9176 * report.cs: Add new warning.
9178 2006-09-21 Martin Baulig <martin@ximian.com>
9180 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9182 2006-09-21 Martin Baulig <martin@ximian.com>
9184 * generic.cs (GenericConstraints): New dummy class.
9185 (Constraints): Likewise.
9186 (TypeParameter): Likewise.
9187 (TypeParameterName): Likewise.
9188 (GenericMethod): Likewise.
9190 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9192 * decl.cs: Merged with the gmcs version.
9194 2006-09-21 Raja R Harinath <rharinath@novell.com>
9196 * generic.cs (TypeParameter): Implement IMemberContainer.
9197 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9199 * rootcontext.cs: Unify with gmcs version.
9201 * report.cs: Unify with gmcs version.
9202 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9203 from gmcs/generics.cs.
9204 * generics.cs (TypeParameter): New dummy class.
9206 * support.cs: Unify with gmcs version.
9208 2006-09-20 Raja R Harinath <rharinath@novell.com>
9210 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9211 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9213 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9214 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9215 * mcs.exe.sources: Add generic.cs.
9217 * codegen.cs: Unify with gmcs version.
9219 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9220 (EmitContext): Add GenericDeclContainer implementation.
9221 * decl.cs (MemberCore, DeclSpace): Likewise.
9222 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9224 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9225 MCS TypeManager has a corresponding dummy method.
9227 2006-09-19 Martin Baulig <martin@ximian.com>
9229 * expression.cs: Completely merged with the gmcs version.
9231 2006-09-19 Martin Baulig <martin@ximian.com>
9233 * expression.cs (Invocation): Merged with the gmcs version.
9234 (ArrayAccess.GetStoreOpcode): Likewise.
9236 2006-09-19 Martin Baulig <martin@ximian.com>
9239 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9240 (TypeManager.IsGenericMethodDefinition): Likewise.
9242 2006-09-19 Martin Baulig <martin@ximian.com>
9245 (TypeManager.IsEqual): Moved the gmcs implementation here.
9246 (TypeManager.DropGenericTypeArguments): Likewise.
9247 (TypeManager.DropGenericMethodArguments): Likewise.
9248 (TypeManager.GetTypeArguments): Moved here from gmcs.
9249 (TypeManager.HasGenericArguments): Likewise.
9251 2006-09-19 Martin Baulig <martin@ximian.com>
9253 * expression.cs (Binary): Merged with the gmcs version.
9255 2006-09-19 Martin Baulig <martin@ximian.com>
9257 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9259 2006-09-19 Martin Baulig <martin@ximian.com>
9261 * typemanager.cs: Merged with the gmcs version.
9263 2006-09-16 Raja R Harinath <rharinath@novell.com>
9265 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9266 * driver.cs: Likewise.
9268 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9271 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9272 only if parent type is class.
9273 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9276 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9279 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9281 * typemanager.cs(CSharpName): Converts NullType to null.
9283 2006-09-15 Martin Baulig <martin@ximian.com>
9286 (TypeManager.GetMethodName): Added mcs implementation.
9287 (TypeManager.IsEqual): Likewise.
9290 (SimpleName.RemoveGenericArity): Added dummy implementation.
9292 * pending.cs: Merged with the gmcs version.
9294 2006-09-15 Martin Baulig <martin@ximian.com>
9296 * statement.cs: Merge with the gmcs version.
9298 2006-09-15 Martin Baulig <martin@ximian.com>
9300 * statement.cs (Switch): Merge with the gmcs implementation
9301 (without nullables), which is newer.
9303 2006-09-15 Martin Baulig <martin@ximian.com>
9305 * statement.cs (Block.Variables): Make this public.
9306 (ToplevelBlock.Parameters): Make this a property.
9307 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9309 2006-09-15 Martin Baulig <martin@ximian.com>
9311 * namespace.cs: Merge with the gmcs version.
9313 2006-09-15 Martin Baulig <martin@ximian.com>
9315 * decl.cs (MemberName): Minor code cleanups.
9317 2006-09-15 Martin Baulig <martin@ximian.com>
9319 * parameter.cs: Merge with the gmcs version.
9321 2006-09-15 Martin Baulig <martin@ximian.com>
9323 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9324 and an error in mcs.
9326 2006-09-15 Martin Baulig <martin@ximian.com>
9328 * flowanalysis.cs: Merged from GMCS; added the generics code into
9329 a `GMCS_SOURCE' conditional so we can share this file.
9331 2006-09-08 Martin Baulig <martin@ximian.com>
9333 * typemanager.cs (TypeManager.interlocked_type): New public field.
9334 (TypeManager.int_interlocked_compare-exchange): New public field.
9335 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9336 enumerator types here and call InitGenericCoreTypes().
9337 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9338 after calling InitEnumUnderlyingTypes().
9341 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9342 `classes_second_stage'.
9344 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9346 * assign.cs, ecore.cs, expression.cs: Share error message text.
9347 * class.cs (FieldMember.Define): Check for varible of static type.
9348 * driver.cs (LoadAssembly): Uses error output for errors.
9349 * statement.cs: Updated.
9351 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9353 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9356 2006-09-07 Martin Baulig <martin@ximian.com>
9359 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9361 2006-08-29 Miguel de Icaza <miguel@novell.com>
9363 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9365 2006-08-17 Miguel de Icaza <miguel@novell.com>
9367 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9368 #52019 and #79064, the use of the \uXXXX sequence in source code
9369 to represent unicode characters.
9371 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9373 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9375 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9377 2006-08-13 Miguel de Icaza <miguel@novell.com>
9379 * assign.cs: Catch attempts to assign to a method groups in += and
9382 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9385 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9387 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9389 * class.cs (Method.Define): Issue a warning when generic method looks like
9391 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9394 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9396 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9398 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9399 search all base interfaces as a member can be ambiguous.
9400 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9401 Constructor member type filter.
9402 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9403 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9404 reporting for returned memberinfos.
9405 * report.cs: Updated.
9406 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9407 version to work on all runtimes.
9408 (TypeManager.RealMemberLookup): Removed members filtering.
9410 2006-08-08 Raja R Harinath <rharinath@novell.com>
9412 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9413 (PropertyExpr.EmitAssign): Likewise.
9414 * expression.cs (Indirection.EmitAssign): Likewise.
9415 (LocalVariableReference.EmitAssign): Likewise.
9416 (ParameterReference.EmitAssign): Likewise.
9417 (Invocation.EmitArguments): Likewise.
9418 (ArrayAccess.EmitAssign): Likewise.
9419 (IndexerAccess.EmitAssign): Likewise.
9420 (This.EmitAssign): Likewise.
9421 (ConditionalLogicalOperator.Emit): Likewise.
9424 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9425 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9426 leave it in after returning it.
9427 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9429 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9431 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9434 2006-08-03 Raja R Harinath <rharinath@novell.com>
9436 Fix cs0146-3.cs and cs0146-4.cs.
9437 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9438 enclosing types don't depend on the current type.
9440 2006-08-02 Raja R Harinath <rharinath@novell.com>
9443 * class.cs (TypeContainer.DoDefineMembers): Use
9444 FindBaseMemberWithSameName on Parent, since we're interested in
9445 whether we hide inherited members or not.
9446 (FindBaseMemberWithSameName): Make slightly more robust.
9448 Fix the non-generic testcase from #77396
9449 * decl.cs (DeclSpace.DeclContainer): Remove override.
9451 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9452 declspaces for doppelgangers too.
9453 (UsingEntry): Implement IResolveContext.
9454 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9455 'this' as the resolve context.
9456 (LocalAliasEntry): Likewise.
9458 Implement parts of #77403
9459 * roottypes.cs (RootDeclSpace): New. Used to represent the
9460 toplevel declaration space. Each namespace declaration introduces
9461 a "partial" root declaretion space.
9462 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9463 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9464 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9465 from 'current_namespace.SlaveDeclSpace'.
9466 (namespace_declaration): Likewise.
9467 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9468 check. It can't happen now.
9469 * decl.cs (DeclSpace.LookupType): Likewise.
9470 * driver.cs (MainDriver): Sanity check.
9472 2006-08-01 Raja R Harinath <rharinath@novell.com>
9474 * decl.cs (DeclSpace.FindNestedType): Remove.
9475 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9476 LookupTypeContainer to get the container of the nested type.
9477 * class.cs (TypeContainer.FindNestedType): Make non-override.
9479 2006-07-31 Raja R Harinath <rharinath@novell.com>
9481 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9482 * class.cs (TypeContainer.PartialContainer): ... here.
9483 (TypeContainer.AddBasesForPart): New helper.
9484 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9486 * cs-parser.jay (current_class): Convert to DeclSpace.
9487 (struct_declaration, interface_declaration, class_declaration):
9488 Use AddBasesForPart instead of .Bases directly.
9489 * const.cs, iterators.cs: Update to changes.
9491 2006-07-28 Raja R Harinath <rharinath@novell.com>
9493 * class.cs (TypeContainer.AddMemberType): Rename from
9495 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9496 (AddTypeContainer): New. Combine AddClassOrStruct and
9498 (AddPartial): Update. Add 'is_partial' argument.
9499 * roottypes.cs: Update to changes.
9500 * cs-parser.jay (push_current_class): New helper for handling
9501 current_container and current_class.
9502 (struct_declaration, interface_declaration, class_declaration):
9505 2006-07-26 Raja R Harinath <rharinath@novell.com>
9507 * roottypes.cs: Rename from tree.cs.
9509 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9510 * tree.cs (Tree, ITreeDump): Remove types.
9511 * rootcontext.cs (tree, Tree): Remove fields.
9512 (root, ToplevelTypes): New.
9513 * *.cs: Update to rename.
9515 * tree.cs (Tree.RecordDecl): Remove.
9516 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9518 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9520 2006-07-23 Raja R Harinath <harinath@gmail.com>
9522 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9523 DoFlowAnalysis and OmitStructFlowAnalysis here.
9524 (ec.With): Rename from WithUnsafe and generalize.
9525 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9526 (ec.WithFlowAnalyis): New.
9527 * ecore.cs, expression.cs, statement.cs: Update.
9529 2006-07-22 Raja R Harinath <harinath@gmail.com>
9531 * statement.cs (Block.ResolveMeta): Simplify slightly.
9533 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9534 multiple boolean fields. Convert InUnsafe, constant_check_state,
9535 check_state to flags.
9536 (CheckState, ConstantCheckState): Update.
9537 (InUnsafe): New read-only property.
9538 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9540 (WithUnsafe): New helper similar to WithCheckState.
9541 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9542 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9544 2006-07-21 Raja R Harinath <rharinath@novell.com>
9546 Make comparisons use the same IL irrespective of whether they're
9547 in a 'checked' or 'unchecked' context: one of the issues in #78899
9548 * codegen.cs (EmitContext.CheckState): Make read-only property.
9549 (EmitContext.ConstantCheckState): Likewise.
9550 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
9551 helper that implement a save/restore stack for CheckState
9552 values. This is the only way to change check-state.
9553 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
9554 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
9555 (CheckedExpr.EmitBranchable): New forwarding method.
9556 (UnCheckedExpr): Likewise.
9557 * statement.cs (Block.ResolveMeta): Use WithCheckState.
9558 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
9559 (Checked.Resolve, checked.DoEmit): Likewise.
9561 2006-07-20 Miguel de Icaza <miguel@novell.com>
9563 * anonymous.cs: Cache the resolved anonymous delegate, and return
9564 this so that the ResolveTopBlock is only triggered once, not
9567 Currently we trigger ResolvetopBlock twice due to a first pass of
9568 argument check compatibility, and a second pass that does the
9571 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9573 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
9575 * rootcontext.cs (Reset): Add helper_classes.
9577 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9580 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
9583 2006-07-13 Miguel de Icaza <miguel@novell.com>
9585 * statement.cs (Lock): Handle expressions of type
9586 TypeManager.null_type specially. Fixes #78770
9588 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9590 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
9593 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9595 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
9596 for accessors as well.
9597 * ecore.cs (EventExpr): Add AccessorTable.
9599 2006-07-01 Marek Safar <marek.safar@seznam.cz>
9602 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
9603 for CS0122 where appropriate.
9604 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
9606 (Filter): Assembly can be null in the case of top level attributes.
9608 2006-06-25 Marek Safar <marek.safar@seznam.cz>
9612 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
9613 is done at global level.
9615 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9617 A fix for #77002, Implemented TypeForwarder support.
9619 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
9620 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
9621 * typemanager.cs (): Add type_forwarder_attr_type.
9623 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9625 * report.cs: Add CS0469 warning.
9627 2006-06-21 Martin Baulig <martin@ximian.com>
9629 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
9630 the `try'-block, so we also report CS0016 etc. there.
9632 2006-06-21 Martin Baulig <martin@ximian.com>
9635 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
9637 2006-06-21 Martin Baulig <martin@ximian.com>
9639 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
9640 also report CS1686 for parameters.
9642 2006-06-21 Martin Baulig <martin@ximian.com>
9644 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
9645 instead of an error if the value is not implicitly convertible to
9646 the switch types; fixes #77964.
9648 2006-06-21 Raja R Harinath <rharinath@novell.com>
9651 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
9652 FieldBuilder is null.
9655 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
9656 'left' and 'right' before error-checking.
9658 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
9660 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
9662 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
9663 (FieldExpr.DoResolve): likewise.
9664 (PropertyExpr.InstanceResolve): likewise.
9665 (EventExpr.InstanceResolve): likewise.
9667 2006-06-04 Marek Safar <marek.safar@seznam.cz>
9669 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
9670 attribute applicable tests for attribute argument.
9672 2006-06-02 Raja R Harinath <rharinath@novell.com>
9675 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
9676 (Binary.OverloadResolve_PredefinedIntegral): New.
9677 (Binary.OverloadResolve_PredefinedFloating): New.
9678 (Binary.OverloadResolve_PredefinedString): New.
9679 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
9680 Follow the standard more closely, and treat numeric promotions in
9681 terms of overload resolution.
9682 (Binary.CheckShiftArguments): Simplify.
9684 2006-06-01 Raja R Harinath <rharinath@novell.com>
9686 * flowanalysis.cs (MyBitVector): Simplify representation.
9687 (MyBitVector.Clone): Avoid allocating BitArray.
9688 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
9689 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
9690 (*): Update. Change all references to MyBitVector.And and
9691 MyBitVector.Or to &= and |=.
9693 2006-05-29 Raja R Harinath <rharinath@novell.com>
9696 * cs-parser.jay (formal_parameter_list): Extend the pattern below
9697 to param arguments too.
9699 2006-05-26 Miguel de Icaza <miguel@novell.com>
9701 * cs-parser.jay: Catch another parsing form for arglist being
9702 followed by other arguments. Fixes #78313.
9704 2006-05-24 Raja R Harinath <rharinath@novell.com>
9706 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
9707 checking of out parameters to ...
9708 (FlowBranchingToplevel.Merge): ... here.
9709 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
9710 set, propagate the origin upward, and only complain if there was
9712 (FlowBranchingException.AddContinueOrigin): Likewise.
9713 (FlowBranchingException.AddReturnOrigin): Likewise.
9714 (FlowBranchingException.AddGotoOrigin): Likewise.
9716 2006-05-23 Raja R Harinath <rharinath@novell.com>
9718 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
9719 unreachable, skip it.
9720 (FlowBranchingException.Merge): Always propagate jumps, even if
9721 the finally block renders subsequent code unreachable.
9723 2006-05-18 Raja R Harinath <rharinath@novell.com>
9726 * statement.cs (Goto.Resolve): Move responsibility for resolving
9727 'goto' to FlowBranching.AddGotoOrigin.
9728 (Goto.SetResolvedTarget): New. Callback to set the
9729 LabeledStatement that's the target of the goto.
9730 (Goto.DoEmit): Use Leave instead of Br when crossing an
9731 unwind-protect boundary.
9732 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
9733 LookupLabel and adjust to new semantics.
9734 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
9735 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
9736 Goto.SetResolvedTarget to update target.
9737 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
9738 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
9739 AddBreakOrigin & co. Delay propagation until ...
9740 (FlowBranchingException.Merge): ... this.
9742 * statement.cs (Block.Resolve): Always depend on flow-branching to
9743 determine unreachability. Kill workaround that originally emitted
9744 only one statement after an "unreachable" label (see infloop in
9747 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
9748 This is still "wrong", but anything better would probably need a
9749 multi-pass algorithm.
9750 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
9751 usage vector. Force current usage vector to be reachable, to
9752 optimistically signify backward jumps.
9753 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
9755 (FlowBranchingLabeled.Merge): New. If no backward jump was
9756 detected, return the original salted-away usage vector instead,
9757 updated with appropriate changes. Print unreachable warning if
9759 * statement.cs (Block.Resolve): Don't print unreachable warning on
9760 a labeled statement.
9762 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
9764 * driver.cs: Pass filename without path to AssemblyBuilder's
9765 AddResourceFile. Fixes bug #78407.
9767 2006-05-17 Raja R Harinath <rharinath@novell.com>
9769 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
9770 * flowanalysis.cs (FlowBranchingLabeled): ... here.
9771 (FlowBranching.MergeChild): Overwrite
9772 reachability information from Labeled branchings too.
9774 2006-05-16 Raja R Harinath <rharinath@novell.com>
9776 * statement.cs (Goto.Resolve): Merge jump origins here ...
9777 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
9779 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
9780 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
9781 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
9782 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
9784 * statement.cs (Goto.Resolve): ... not here.
9785 (Goto.Emit): Remove CS1632 check.
9787 2006-05-14 Marek Safar <marek.safar@seznam.cz>
9789 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
9792 2006-05-11 Raja R Harinath <rharinath@novell.com>
9794 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
9795 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
9796 (FlowBranchingException.Label): Likewise.
9798 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
9800 (MyBitVector.Or): Use it to avoid losing information (Count).
9801 (FlowBranching.MergeOrigins): Likewise.
9803 * flowanalysis.cs (UsageVector.IsDirty): Remove.
9804 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
9805 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
9806 (UsageVector.ToString): Simplify.
9807 (UsageVector.MergeSiblings): Move here from ...
9808 (FlowBranching.Merge): ... here.
9809 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
9812 2006-05-10 Raja R Harinath <rharinath@novell.com>
9814 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
9815 null bitvector is treated as all-true.
9817 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
9818 (MyBitVector): Rationalize invariants. 'vector != null' implies
9819 that we have our own copy of the bitvector. Otherwise,
9820 'InheritsFrom == null' implies all inherited bits are true.
9822 2006-05-09 Marek Safar <marek.safar@seznam.cz>
9824 * statement.cs (LocalInfo): Add IsConstant.
9825 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
9826 local variable for constants.
9828 2006-05-09 Raja R Harinath <rharinath@novell.com>
9830 * flowanalysis.cs (MyBitVector.Empty): New.
9831 (MyBitVector): Don't allow InheritedFrom to be null.
9832 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
9833 (UsageVector, FlowBranching): Update to changes.
9835 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
9836 recursion. The 'Parent == null' condition isn't sufficient for
9838 (FlowBranching.AddBreakOrigin): Likewise.
9839 (FlowBranching.AddContinueOrigin): Likewise.
9840 (FlowBranching.AddReturnOrigin): Likewise.
9841 (FlowBranching.StealFinallyClauses): Likewise.
9842 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
9843 (FlowBranching.CheckOutParameters): Likewise.
9844 (FlowBranchingToplevel): Terminate all the above recursions here.
9845 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
9846 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
9848 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
9850 (FlowBranchingToplevel): New. Empty for now.
9851 (FlowBranching.MergeTopBlock): Update.
9852 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
9853 branching for the anonymous delegate.
9854 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
9856 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
9857 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
9858 information at the start of the merge. Reorganize.
9860 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9862 * class.cs (MethodData.Define): Method cannot implement interface accessor.
9864 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9866 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
9867 to newly introduced ctor.
9869 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
9870 message to one place.
9871 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
9874 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9876 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
9878 * ecore.cs (Expression.ResolveAsConstant): Updated.
9880 * statement.cs (ResolveMeta): Updated.
9882 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9884 * cs-parser.jay: __arglist cannot be used in initializer.
9886 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9889 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
9892 2006-05-05 Raja R Harinath <rharinath@novell.com>
9894 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
9895 (LabeledStatement): Add 'name' parameter.
9896 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
9897 (Block.AddLabel): Update to changes.
9898 * cs-parser.jay (labeled_statement): Likewise.
9900 * flowanalysis.cs (BranchingType.Labeled): New.
9901 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
9902 (FlowBranchingLabeled): New. Does nothing for now, but will
9903 eventually handle 'goto' flows.
9904 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
9905 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
9906 that's terminated ...
9907 (Block.Resolve): ... here.
9909 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
9910 (UsageVector.MergeFinallyOrigins): Likewise.
9911 (FlowBranching.InTryOrCatch): Likewise.
9912 (FlowBranching.AddFinallyVector): Likewise.
9913 (FlowBranchingException): Update to changes.
9916 * statement.cs (Return.Resolve): Move error checking to ...
9917 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
9918 (FlowBranchingException): Handle return origins like break and
9920 (FlowBranching.UsageVector.CheckOutParameters): Remove.
9922 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9925 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
9928 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9931 * class.cs (MethodData.Define): Do public accessor check only when method
9932 implements an interface.
9934 2006-05-04 Raja R Harinath <rharinath@novell.com>
9936 Remove special handling of 'break'
9937 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
9938 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
9939 (UsageVector.Break): Remove.
9940 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
9942 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
9944 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
9945 UsageVector.Breaks (). Don't set NeedsReturnLabel.
9947 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9950 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
9951 be the interface member.
9953 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9956 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
9957 for emitting small (int) values.
9959 2006-05-03 Raja R Harinath <rharinath@novell.com>
9962 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
9963 control-flow passes through the 'finally' after merging-in all the
9964 control-flows from 'try' and the 'catch' clauses.
9966 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
9967 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
9968 always true at the only non-recursive entry point.
9969 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
9970 FlowBranchingBreakable.
9971 (FlowBranchingLoop): Remove.
9972 * statement.cs (Return.DoResolve): Update to changes.
9975 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
9976 (FlowBranching.CreateBranching): Handle it: create a
9977 FlowBranchingContinuable.
9978 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
9979 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
9980 except that it handles the 'continue' command.
9981 (FlowBranching.UsageVector.MergeOrigins): Rename from
9983 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
9984 except that it overrides AddContinueOrigin.
9985 (FlowBranchingException): Override AddContinueOrigin, similar to
9987 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
9988 Create a new branching around the embedded statement.
9989 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
9990 control flow after the embedded statement.
9991 (Continue.Resolve): Move all error checking to AddContinueOrigin.
9993 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
9994 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
9995 FlowBranchingBreakable.
9996 (FlowBranchingSwitch): Remove.
9999 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10000 error reporting to ...
10001 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10002 Rename from 'AddBreakVector'. Add new location argument. Return
10003 a bool indicating whether the 'break' crosses an unwind-protect.
10004 (FlowBranchingException.AddBreakOrigin): Add.
10005 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10006 flowbranching after updating with the effects of the 'finally'
10008 (FlowBranchingBreakable): New common base class for
10009 FlowBranchingLoop and FlowBranchingSwitch.
10011 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10012 embedded statement.
10013 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10015 2006-05-02 Raja R Harinath <rharinath@novell.com>
10017 * statement.cs (Do.Resolve): If the loop is infinite, set the
10019 (While.Resolve, For.Resolve): Set a barrier after the embedded
10020 statement. There's no direct control flow that goes from the end
10021 of the embedded statement to the end of the loop.
10022 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10023 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10024 above ensure that the reachability is correctly computed.
10026 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10027 (UsageVector.MergeBreakOrigins): If the current path is
10028 unreachable, treat it as if all parameters/locals are initialized.
10029 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10030 infinite loops before merging-in break origins.
10032 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10033 (Reachability.Reachable): Split part into ...
10034 (Reachability.Unreachable): ... this. Simplify.
10035 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10037 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10038 (Reachability.SetThrowsSometimes): Likewise.
10039 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10040 TriState.Always, use corresponding property.
10041 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10042 (Block.Resolve): Likewise. Remove some redundant checks.
10044 2006-05-02 Raja R Harinath <harinath@gmail.com>
10046 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10047 (Reachability.Meet): Don't bother checking AlwaysThrows --
10048 barrier is always set.
10049 (FlowBranchingBlock.Merge): Likewise.
10051 2006-05-01 Raja R Harinath <harinath@gmail.com>
10053 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10054 checks for unreachable.
10056 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10059 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10061 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10062 whether field is really assigned.
10064 2006-04-30 Raja R Harinath <harinath@gmail.com>
10066 * flowanalysis.cs (Reachability): Make 4-argument constructor
10068 (Reachability.Meet): Rename from 'And'. Remove static variant.
10069 (Reachability.Always): Rename from the highly misleading
10070 'Reachability.Never'.
10071 (FlowBranching.Merge): Update to changes. Mark an impossible
10072 situation with a 'throw'.
10073 (*): Update to changes.
10075 2006-04-29 Raja R Harinath <harinath@gmail.com>
10077 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10078 Remove 'Undefined'.
10079 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10080 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10081 (*): Update to changes.
10082 * statement.cs: Update to changes.
10084 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10087 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10089 2006-04-28 Raja R Harinath <harinath@gmail.com>
10091 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10094 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10095 argument to two arguments: an usage-vector and a bool. Move call
10096 to FlowBranching.Merge () ...
10097 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10099 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10100 handling of loop and switch reachability to ...
10101 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10103 2006-04-27 Raja R Harinath <harinath@gmail.com>
10105 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10106 handling to FlowBranchingLoop.InLoop.
10107 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10109 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10112 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10113 anonymous method is allowed from AnonymousContainer here.
10115 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10117 2006-04-24 Raja R Harinath <rharinath@novell.com>
10120 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10122 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10125 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10126 (DoubleConstant.Reduce): Ditto.
10128 2006-04-23 Raja R Harinath <rharinath@novell.com>
10130 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10131 Remove 'lvalue_right_side' argument. Move parts to ...
10132 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10133 (LocalVariable.DoResolveLValue): ... these.
10135 2006-04-21 Raja R Harinath <rharinath@novell.com>
10138 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10139 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10140 (LocalVariableReference.DoResolveBase): Use it to implement new
10142 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10143 (Argument.Resolve): Simplify. Move CS1510 check ...
10144 * ecore.cs (Expression.ResolveLValue): ... here.
10145 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10146 (PropertyExpr.DoResolveLValue): Likewise.
10147 (FieldExpr.Report_AssignToReadonly): Likewise.
10148 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10149 LValueMemberAccess or LValueMemberOutAccess on instance depending
10151 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10152 DoResolve as appropriate.
10154 2006-04-20 Raja R Harinath <rharinath@novell.com>
10157 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10158 implicit conversions on 'out' and 'ref' arguments.
10160 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10161 improve clarity. Remove dead code.
10164 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10165 (Catch.Resolve): Resolve VarBlock if it exists.
10167 2006-04-19 Miguel de Icaza <miguel@novell.com>
10169 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10170 twice, this was some residual code, the enumerator was emitted
10171 properly in the two branche of if later.
10173 2006-04-19 Raja R Harinath <rharinath@novell.com>
10175 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10176 cast is never an lvalue.
10177 (Cast.DoResolve, Cast.ResolveRest): Combine.
10178 (Argument.Emit): Simplify slightly. Move 'Expr is
10179 IMemoryLocation' check ...
10180 (Argument.Resolve): ... here.
10181 (Argument.Error_LValueRequired): Remove. Inline into only user.
10183 Simplifications. Fix cs0191-2.cs
10184 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10185 CS1649 and CS1651 to ...
10186 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10187 the actual selection of the error code and message to a lookup
10188 table. Add a dummy return value to simplify callsites.
10189 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10190 readonly fields of other instances of the same type. Move CS0197
10192 * expression.cs (Argument.Resolve): ... here. Simplify code.
10193 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10194 resolution of an out or ref argument. The code simplification
10195 above uses this invariant.
10197 2006-04-18 Raja R Harinath <rharinath@novell.com>
10199 Possibly fix #77752. Fix cs1690-[4-7].cs.
10200 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10201 CheckMarshallByRefAccess. Drop parameter.
10202 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10204 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10205 InstanceExpression.
10206 * report.cs (AllWarnings): Add CS1690.
10207 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10208 for ref access too.
10209 (LocalVariableReference.DoResolveBase): Update.
10211 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10213 * class.cs (MethodOrOperator): Moved common parts from method class.
10214 detect obsolete attributes.
10215 (Method.Define): Simplified as it reuses code from base.
10216 (Constructor.ValidAttributeTargets): Fixed issue found during
10218 (Destructor.ValidAttributeTargets): Fixed issue found during
10220 (Operator): Finished refactoring set off by #78020. Operator class is now
10221 ordinary method class.
10223 * anonymous.cs: Updated.
10225 * decl.cs (DeclSpace): Add IsGeneric
10227 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10229 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10231 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10233 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10234 detect obsolete attributes.
10235 (Method.CreateEmitContext): Moved to MethodOrOperator.
10237 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10240 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10241 customized exception to make crash detection easier.
10242 (MethodOrOperator): Started to work on new base class for methods and
10244 (Method): Derives from MethodOrOperator.
10245 (Constructor.Emit): Emits its own attributes.
10246 (AbstractPropertyEventMethod.Emit): Ditto.
10247 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10249 (Operator.Emit): It's temporary more tricky than should be.
10251 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10253 * report.cs (InternalErrorException): Add ctor with inner exception.
10255 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10258 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10261 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10264 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10267 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10269 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10270 attribute is present and Guid not.
10271 (Interface.ApplyAttributeBuilder): Ditto.
10273 * attribute.cs: Add error message.
10275 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10279 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10280 sources (it's composite) so hold them in extra array as they are used in
10281 Emit phase only. It worked in the previous versions by mistake.
10282 (Attribute.Emit): Emit attribute for more owners when exist.
10284 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10285 it has now different behaviour.
10287 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10289 * constant.cs (Constant.IsDefaultInitializer): New method.
10291 * class.cs: Updated.
10293 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10294 re-initialize default values. It saves KBs almost for every assembly.
10295 Thanks Zoltan for the idea.
10296 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10297 (ArrayCreation.DoResolve): Resolve only once.
10298 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10299 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10301 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10303 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10306 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10308 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10309 in an embedded statement too.
10311 2006-04-01 Raja R Harinath <rharinath@novell.com>
10314 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10316 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10320 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10323 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10325 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10327 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10330 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10331 LocalTemporary change.
10333 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10335 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10336 initializers optimization.
10337 (ClassOrStruct.TypeAttr): Moved from modifiers.
10338 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10339 (FieldBase.ResolveInitializer): Resolves initializer.
10340 (FieldBase.HasDefaultInitializer): New property.
10342 * cs-parser.jay: Removed message.
10344 * expression.cs (CompilerGeneratedThis): New specialization.
10346 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10348 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10350 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10352 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10354 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10355 be now EnumConstants only.
10357 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10359 * attribute.cs, driver.cs: Reset more caches.
10361 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10363 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10365 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10367 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10368 for easier reuse. Updated all overrides.
10369 (IntegralConstant): New base class for all integral constants.
10370 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10371 of the constant range, report custom error.
10372 (UIntConstant.Reduce): Fixed uint conversion.
10374 * ecore.cs, literal.cs: Reduce updates.
10376 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10380 * class.cs (Constructor.Define): Removed extra if for default ctors.
10381 A patch from Atsushi Enomoto.
10383 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10385 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10386 GetAttributableValue.
10388 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10391 * convert.cs (ImplicitConversionRequired): Error message moved to
10394 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10395 automatic implicit conversion of an output value.
10396 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10398 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10400 (TypeOf.GetAttributableValue): Add extra handling for object type.
10402 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10403 special error message.
10405 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10407 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10409 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10410 compatible with MS runtime.
10412 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10414 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10415 attribute arguments here.
10417 * class.cs (Indexer.Define): The check was moved to attribute class.
10419 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10421 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10422 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10425 2006-03-22 Raja R Harinath <rharinath@novell.com>
10427 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10428 mcs to keep code differences small.
10429 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10430 * typemanager.cs (parameter_default_value_attribute_type): New.
10431 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10434 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10436 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10438 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10440 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10442 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10445 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10447 * doc-bootstrap.cs : fix build.
10449 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10451 * expression.cs (StringConcat.Append): Issue a warning when empty string
10452 is going to append.
10454 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10456 * assign.cs (CompoundAssign.ResolveSource): Removed.
10458 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10461 * class.cs (TypeContainer.FindMethods): Removed.
10462 (TypeContainer.CheckMemberUsage): Made static.
10464 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10466 * constant.cs (CheckRange): Removed unused type argument.
10467 (CheckUnsigned): Removed unused type argument.
10469 * cs-parser.jay: Updated after MemberAccess clean up.
10470 Uses Length for empty string test.
10472 * cs-tokenizer.cs: Uses Length for empty string test.
10473 (IsCastToken): Made static.
10474 (is_hex): Made static.
10475 (real_type_suffix): Made static.
10477 * decl.cs (SetupCache): Made static.
10478 (OnGenerateDocComment): Removed unused ds argument.
10480 * delegate.cs (VerifyDelegate): Removed unused argument.
10482 * doc.cs: Uses Length for empty string test.
10484 * driver.cs: Uses Length for empty string test.
10486 * enum.cs (IsValidEnumType): Made static
10488 * expression.cs (EnumLiftUp): Removed unused argument.
10489 (ResolveMethodGroup): Ditto.
10490 (BetterConversion): Ditto.
10491 (GetVarargsTypes): Ditto.
10492 (UpdateIndices): Ditto.
10493 (ValidateInitializers): Ditto.
10494 (MemberAccess.ctor): Ditto.
10495 (GetIndexersForType): Ditto.
10497 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10499 * iterators.cs: Updated after MemberAccess clean up.
10501 * location.cs: Uses Length for empty string test.
10503 * namespace.cs: Uses Length for empty string test.
10505 * report.cs (CheckWarningCode): Made static.
10507 * statement.cs (LabeledStatement): Removed unused argument.
10509 * typemanager.cs (FilterNone): Removed.
10511 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10513 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10516 * class.cs: Updated.
10518 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10520 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10522 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10526 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10527 reporting, it's more tricky than I thought.
10529 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10533 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10535 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10536 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10537 Add more error reporting; Fixed issue with params.
10539 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10541 * cs-parser.jay: AnonymousMethod requires host container.
10543 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10545 2006-03-18 Raja R Harinath <harinath@gmail.com>
10547 * class.cs: Change 'TypeContainer ds' constructor argument to
10548 'DeclSpace parent'. Some classes were missed below due to
10549 different naming convention.
10551 * class.cs (MemberCore.Parent): Delete. This makes the
10552 ParentContainer changes below enforceable by the compiler.
10554 Treat pointers to enclosing declaration space as 'DeclSpace', not
10556 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
10557 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
10559 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
10561 (Block.AddThisVariable): Likewise.
10562 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
10563 (AbstractPropertyEventMethod.Emit): Likewise.
10564 (AbstractPropertyEventMethod.EmitMethod): Likewise.
10565 (GetMethod.Define, SetMethod.Define): Likewise.
10566 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
10567 (DelegateMethod.EmitMethod): Likewise.
10569 Fix regression test-partial-13.cs.
10570 Rationalize use of PartialContainer. Ensure that the partial
10571 class semantics can be tied to type-correctness, i.e., any
10572 violation will cause a compile error.
10573 * class.cs, const.cs: Access all fields that belong to class
10574 TypeContainer via ParentContainer. Arguments of EmitContexts and
10575 Resolve()-like functions still use 'Parent'.
10577 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
10578 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
10579 (PropertyMethod.CheckModifiers): Remove unused argument.
10580 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
10583 2006-03-17 Raja R Harinath <harinath@gmail.com>
10585 Make semantics of PartialContainer simpler.
10586 * decl.cs (DeclSpace.IsPartial): Remove.
10587 * class.cs (TypeContainer.IsPartial): Likewise.
10588 (TypeContainer..ctor): Set PartialContainer to point to self.
10589 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
10590 (TypeContainer.FindNestedType): Likewise.
10591 (MemberCore.ParentContainer): Simplify. Remove deprecation.
10593 2006-03-17 Marek Safar <marek.safar@seznam.cz>
10595 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
10597 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10599 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
10602 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10604 * class.cs (Operator.Define): An error for base conversion was not
10605 reported correctly.
10607 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
10609 * iterator.cs : yield break is allowed in try statement which has
10610 catch clauses. Fixed bug #77767.
10612 2006-03-13 Marek Safar <marek.safar@seznam.cz>
10614 A fix for #77593, #77574.
10616 * class.cs (MethodCore.CheckBase): Another if for operator.
10618 2006-03-09 Marek Safar <marek.safar@seznam.cz>
10620 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
10623 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
10624 (DelegateCreation.ImplicitStandardConversionExists): New method for just
10627 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
10630 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
10631 Updated after another emitcontext usage was clean up. It should help us to
10632 synchronize with gmcs easier.
10634 2006-03-04 Marek Safar <marek.safar@seznam.cz>
10638 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
10639 (Event.Define): ditto
10640 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
10642 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
10643 Removed redundant code and set NewSlot for Invoke method too.
10645 * parameter.cs (Parameters.ctor): Add custom, type ctor.
10646 (Parameters.MergeGenerated): New method. Use this method when you merge
10647 compiler generated argument with user arguments.
10649 2006-03-03 Marek Safar <marek.safar@seznam.cz>
10651 * attribute.cs (ResolveAsTypeTerminal): Removed.
10653 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
10654 specialization for predefined types; 30% speed up.
10655 Finally placed obsolete check to right place.
10656 (Expression.ResolveType): Removed.
10658 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
10659 Updated after ResolveType was removed.
10661 * expression.cs (Cast.ctor): Check void cast.
10662 (Binary.ResolveAsTypeTerminal): Is never type.
10663 (Conditional.ResolveAsTypeTerminal): Is never type.
10665 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
10667 2006-03-01 Raja R Harinath <rharinath@novell.com>
10670 * expression.cs (ParameterReference.DoResolveBase): Change return
10672 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
10676 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
10679 * typemanager.cs (GetFullNameSignature): Don't nullref on
10680 protected accessors.
10682 2006-02-27 Marek Safar <marek.safar@seznam.cz>
10684 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
10685 these two separated members to simplify the code.
10686 (Attribute.Resolve): Refactored to use new fields and methods.
10687 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
10688 implemented obsolete attribute checking.
10689 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
10690 implemented obsolete checking again. It look line never ending quest ;-)
10691 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
10693 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
10695 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
10697 *class.cs (Property.Define): Add RegisterProperty call.
10699 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
10700 argument groups (only 2).
10702 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
10703 encoding expression to arguments.
10704 (Expression.ExprClassToResolveFlags): Just turned to property.
10706 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
10707 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
10708 optimized as well as implemented support for zero-length attributes.
10710 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
10711 Add caching of PropertyInfo's.
10713 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10715 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
10716 error multiple times.
10718 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10720 New partial class implementation.
10721 A fix for #77027, #77029, #77403
10723 * attribute.cs (Attributable): Made attributes protected.
10725 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
10726 the replacements of ClassPart and PartialContainer.
10727 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
10728 (TypeContainer.AddInterface): Ditto.
10729 (TypeContainer.AddPartial): The main method for partial classes. It checks
10730 for errors and merges ModFlags and attributes. At the end class is added to
10731 partial_parts list.
10732 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
10734 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
10735 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
10736 from the rest of partial classes.
10737 (TypeContainer.GetClassBases): Simplified.
10738 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
10740 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
10741 (TypeContainer.HasExplicitLayout): Uses Flags now.
10742 (PartialContainer): Removed.
10743 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
10744 (StaticClass): Was merged with Class.
10745 (Class.GetClassBases): class and static class bases are verified here.
10746 (Class.TypeAttr): Added static attributes when class is static.
10747 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
10748 (MemberBase): In some cases we need to call parent container for partial
10749 class. It should be eliminated but it's not easy now.
10751 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
10753 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
10754 partial classed to accumulate class comments.
10755 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
10757 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
10759 * driver.cs (MainDriver): Tree.GetDecl was removed.
10761 * modifiers.cs (Modifiers): Add partial modifier.
10763 * tree.cs (Tree.decl): Removed.
10764 (RootTypes): Started to use this class more often for root types
10767 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10771 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
10772 external interface does not have an attribute.
10774 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10776 Another prerequisites for new partial classs implementation.
10778 * attribute.cs (Attribute.Equal): Implemented.
10779 (Attribute.Emit): Changed as attributes can be applied more than twice.
10780 (Attributes.Emit): Check for duplicate attributes here.
10782 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
10783 as a parameter, clean-up.
10785 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10789 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
10790 contains obsolete attribute check which can in some cases look for base
10791 type of current class which is not initialized yet.
10792 (TypeContainer.BaseType): Replacement of ptype.
10794 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
10796 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10798 First of prerequisites for new partial classs implemention.
10800 * attribute.cs (Attributable): Extended by ResolveContext;
10801 Attributes finally have correct context for resolving in all cases.
10802 (AttachTo): Attribute owner is assigned here.
10804 * codegen.cs (IResolveContext): Introduce new interface to hold
10805 all information needed in resolving phase.
10806 (EmitContext): Implements IResolveContext; more clean-up needed here.
10808 * decl.cs (MemberCore): Implemented IResolveContext.
10810 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
10811 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
10812 parameter.cs, statement.cs, tree.cs, typemanager.cs:
10813 Refactored to use new IResolveContext instead of EmitContext; cleanup
10815 2006-02-06 Miguel de Icaza <miguel@novell.com>
10817 * codegen.cs (EmitScopeInitFromBlock): check here the
10818 capture_context, there is no need to make two calls to the
10821 * anonymous.cs: Add some debugging messages that might help me
10822 track other instances of this problem in the future (the
10823 regression of test 467).
10825 * cs-parser.jay: track the variable block, as we need to initalize
10826 any captured variables declared in this block for the "catch"
10827 portion of the "Try" statement.
10829 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
10830 scope initialization for captured variables.
10832 Also, move the emit for the variables after the block location has
10835 2006-02-06 Marek Safar <marek.safar@seznam.cz>
10837 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
10839 2006-02-02 Miguel de Icaza <miguel@novell.com>
10841 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
10842 commit yesterday, the initialization for the roots is necessary.
10843 What is not necessary is the scope activation.
10845 2006-02-02 Raja R Harinath <rharinath@novell.com>
10847 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
10848 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
10850 (Argument.Resolve): Remove CS0206 checks.
10852 2006-02-01 Miguel de Icaza <miguel@novell.com>
10854 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
10855 scopes for all the roots, the scopes will now be emitted when the
10856 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
10858 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
10859 code. This reduces a lot of existing cruft.
10861 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
10862 that the ScopeInfo is generated as we enter the scope, not at the
10863 time of use, which is what we used to do before.
10865 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
10866 every time a Block is about to be emitted if we have a
10869 2006-02-01 Raja R Harinath <rharinath@novell.com>
10871 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
10873 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
10875 * typemanager.cs (cons_param_array_attribute): Make private.
10876 (Reset): Set it to null.
10877 (InitCoreHelpers): Don't initialize it.
10878 (ConsParamArrayAttribute): New. Initialize it as needed.
10879 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
10881 2006-01-31 Miguel de Icaza <miguel@novell.com>
10883 * expression.cs: There might be errors reported during the
10884 selection of applicable methods. If there are errors, do not
10885 continue execution as it will lead the compiler to crash.
10887 2006-01-30 Miguel de Icaza <miguel@novell.com>
10889 * expression.cs: Member access is not allowed on anonymous
10890 methods. Fixes #77402.
10892 2006-01-30 Raja R Harinath <rharinath@novell.com>
10895 * cs-parser.jay (VariableDeclaration): Don't set
10896 current_array_type to null.
10897 (field_declaration, event_declaration, declaration_statement):
10898 Set it to null here.
10900 2006-01-28 Raja R Harinath <harinath@gmail.com>
10902 * typemanager.cs (GenericParameterPosition): New.
10905 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
10907 * doc.cs : To process "include" elements, first we should create
10908 another list than XmlNodeList, because it could result in node
10909 removal, which could result in that the XmlNodeList gives up
10910 yielding next node.
10912 (Also made code identical to gmcs again.)
10914 2006-01-25 Miguel de Icaza <miguel@novell.com>
10916 * ecore.cs: Introduce an error report that we were not catching
10917 before, if not silent, we must report the error. Gonzalo ran into
10920 2006-01-23 Miguel de Icaza <miguel@novell.com>
10922 A fix for bug: #76957
10924 * iterators.cs (MoveNextMethod.CreateMethodHost): call
10925 ComputeMethodHost before creating the method, this is a new
10928 * anonymous.cs (AnonymousContainer): Now we track all the scopes
10929 that this method references (RegisterScope). The actual scope
10930 where the method is hosted is computed with the ComputeMethodHost
10931 before we create the method.
10933 Moved the Deepest routine here.
10935 (AnonymousContainer.ComputeMethodHost): New routine used to
10936 compute the proper ScopeInfo that will host the anonymous method.
10938 (ScopeInfo): Deal with multiple roots. The problem was that we
10939 did not have a unique root where all ScopeInfos could be hanged
10940 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
10943 Remove AdjustMethodScope which is now computed at the end. Remove
10944 LinkScope which did a partial link, instead link all ScopeInfos
10945 before code generation from the new "LinkScopes" routine.
10947 Simplify all the Add* routines as they no longer need to maintain
10948 the tree, they just need to record that they are using variables
10951 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
10952 routines to produce the forest of ScopeInfo trees.
10954 * class.cs (TypeContainer.AppendMethod): This is just like
10955 AddMethod, but ensures that an interface implementation method
10956 (IEnumerable.XXX) is not inserted at the beginning of the queue of
10957 methods, but at the end.
10959 We use this functionality to ensure that the generated MoveNext
10960 method in the iterator class is resolved/emitted before the
10961 enumerator methods created.
10963 This is required because the MoveNext method computes the right
10964 ScopeInfo for the method. And the other methods will eventually
10965 need to resolve and fetch information computed from the anonymous
10968 2006-01-21 Raja R Harinath <harinath@gmail.com>
10969 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10971 Fix rest of #76995.
10972 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
10973 the 'aliases' hash.
10974 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
10975 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
10977 2006-01-18 Raja R Harinath <rharinath@novell.com>
10979 Fix #76656, cs0231-2.cs.
10980 * cs-parser.jay (formal_parameter_list): Make error case catch
10982 (parenthesized_expression_0): Add CS1026 check.
10983 (invocation_expression): Remove unused { $$ = lexer.Location }.
10985 2006-01-17 Raja R Harinath <rharinath@novell.com>
10988 * cs-parser.jay (statement_expression): Don't list out the
10989 individual statement-expressions. Convert syntax error into
10992 2006-01-16 Raja R Harinath <rharinath@novell.com>
10995 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
10996 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
10997 CheckIntermediateModification.
10998 (FieldExpr.DoResolve): Add new two-argument version that
10999 allows us to resolve the InstanceExpression as an lvalue.
11000 The one-argument variant is now just a wrapper.
11001 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11002 Resolve the lhs as an lvalue if the it has a value type.
11003 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11004 from Assign.DoResolve.
11005 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11006 resolved as an lvalue.
11007 (PropertyExpr.DoResolve): Update.
11008 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11009 has a value type. Move CS1612 check here from
11010 CheckIntermediateModification.
11011 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11012 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11013 'right_side' of a ResolveLValue on an 'out' argument.
11014 (EmptyExpression.LValueMemberAccess): New. Used as the
11015 'right_side' of a propagated ResolveLValue on a value type.
11016 (LocalVariableReference.DoResolveBase): Recognize
11017 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11019 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11020 EmptyExpression.Null.
11022 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11024 * typemanager.cs : added IsGenericParameter(). In mcs it always
11026 * doc.cs : for generic parameters, use GenericParameterPosition,
11029 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11031 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11033 2006-01-12 Miguel de Icaza <miguel@novell.com>
11035 This fixes the problem where we used ldfld instead of ldflda to
11036 load the "THIS" pointer on captured parameters, when THIS is a
11037 value type. See bug #77205.
11039 * iterators.cs (CapturedThisReference.Emit): Pass false to
11040 EmitThis (we do not need the address).
11042 * codegen.cs (EmitThis): it needs to know whether we need the
11043 address of `this' or not. This is used by value types.
11045 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11046 every other call passes false.
11048 2006-01-12 Raja R Harinath <rharinath@novell.com>
11051 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11053 * expression.cs (Invocation.OverloadResolve): Update.
11054 (Invocation.DoResolve): Avoid double resolution of invocation.
11056 2006-01-11 Raja R Harinath <rharinath@novell.com>
11059 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11060 unary negation of floating point types as 0-expr; negation cannot
11061 overflow in floating point types.
11064 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11065 on operands of 'void' type.
11068 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11069 and ExclusiveOr for boolean constants too.
11071 2006-01-09 Raja R Harinath <rharinath@novell.com>
11074 * expression.cs (Invocation.OverloadResolve): Replace reflected
11075 override methods with their base virtual methods, rather than
11076 skipping over them.
11077 * typemanager.cs (TypeManager.GetOverride): New.
11079 2006-01-05 Jb Evain <jbevain@gmail.com>
11081 * class.cs (Property.Define, Indexer.Define): do not tag the
11082 properties as SpecialName | RTSpecialName.
11084 2006-01-04 Miguel de Icaza <miguel@novell.com>
11086 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11087 doing a low-level comparission of parameter types. It was lacking
11088 a check for __argslist.
11090 2005-12-30 Miguel de Icaza <miguel@novell.com>
11092 * expression.cs (ParameterReference.DoResolveBase): Allow
11093 reference parameters if they are local to this block.
11095 This allows the ref and out parameters of a delegate to be used in
11096 an anonymous method, for example:
11098 delegate void set (out int x);
11100 set s = delegate (out int x){
11104 This is used by functionality introduced late in the C# language.
11106 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11107 method that take ref and out parameters.
11109 Fixes #77119 which was a late change in the spec.
11111 2005-12-23 Miguel de Icaza <miguel@novell.com>
11113 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11114 parent if its the same scope. Fixes #77060.
11116 2005-12-21 Miguel de Icaza <miguel@novell.com>
11118 * driver.cs: Report the case of no source files and no -out:
11121 2005-12-20 Raja R Harinath <rharinath@novell.com>
11124 * expression.cs (ComposedCast.GetSignatureForError): Define.
11126 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11130 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11131 ListDictionary, to contain the ExternAliasEntry entries (in
11132 addition to the NamespaceEntry.aliases hashtable). This field is
11133 shared between the original entry and its doppelganger (bodyless
11135 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11136 extern_aliases field.
11137 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11138 lookup in extern_aliases.
11140 2005-12-16 Raja R Harinath <rharinath@novell.com>
11143 * class.cs (TypeContainer.Mark_HasEquals): New.
11144 (TypeContainer.Mark_HasGetHashCode): New.
11145 (ClassPart): Override them.
11146 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11149 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11150 'parent' argument to the base constructor.
11152 Remove all mention of TypeContainer from decl.cs.
11153 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11154 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11155 (DeclSpace.DeclSpace): Likewise.
11156 (DeclSpace.DefineMembers): Remove unused argument.
11157 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11158 debugging check -- we don't care if the debug code throws an
11159 InvalidCastException instead of an InternalErrorException.
11160 * class.cs (TypeContainer.DefineMembers): Update to changes.
11161 (TypeContainer.DoDefineMembers): Likewise.
11162 (TypeContainer.GetMethods): Likewise.
11163 (PropertyMember.Define): Likewise.
11164 (MemberBase.Parent): New property that forwards to
11165 MemberCore.Parent, but ensures that we get a TypeContainer.
11166 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11167 (RootContext.PopulateTypes): Likewise. Remove special case code
11168 for !RootContext.StdLib: DefineMembers is idempotent.
11170 2005-12-14 Miguel de Icaza <miguel@novell.com>
11172 * convert.cs (ExplicitConversionCore): Check the return value from
11173 ExplicitConversionCore which can return null on failure. Fixes #76914
11175 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11177 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11179 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11181 * doc.cs : The search for referenced namespace was insufficient to
11182 get global one as it used to do. Fixed bug #76965.
11184 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11186 * doc.cs : check name in cref in the last phase that whether it is
11189 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11191 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11194 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11196 * doc.cs : so it turned out that we cannot skip override check for
11197 interface members. Fixed bug #76954.
11199 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11201 * cs-tokenizer.cs : fixed bug #75984:
11202 - #warning and #error should not be handled when the source line
11204 - #line is not checked strictly when the source line is disabled.
11205 - #define and #undef is on the other hand checked strictly at any
11208 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11210 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11213 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11215 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11217 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11218 event initializers.
11219 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11220 (FieldBase.Initializer): Initializer is now optional.
11221 (EventField.Define): Only event field can have initializer.
11223 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11225 * const.cs (Const): Reuse initializer.
11227 * cs-parser.jay: Updated after FieldBase changes.
11228 Added current_array_type to simplify array initializers.
11230 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11232 * expression.cs, iterators.cs: Updated.
11234 * namespace.cs (NamespaceEntry): Made UsingFound private.
11236 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11238 * parameterCollection.cs: Obsolete, removed.
11239 * parser.cs: Obsolete, removed.
11241 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11244 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11246 * enum.cs (Enum.Define): Set obsolete context here.
11248 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11251 - FindDocumentedMember() now expects 1) paramList as null
11252 when "we don't have to check the number of parameters" and
11253 2) Type.EmptyTypes when "there is no arguments".
11254 - Introduced FoundMember struct to hold the exact type which was
11255 used to find the documented member (the above change broke
11256 test-xml-044; it might be better just to use DeclaringType than
11257 what MS does, like this change does, but it depends on usage.)
11259 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11261 * doc.cs : documented member might be from DeclaringType for nested
11262 types. Fixed bug #76782.
11264 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11266 * anonymous.cs: Have the param code handle leaving copies on the
11267 stack etc. Allows anonymous params to take part in the assignment
11268 code (++, +=, etc). Fixes bug #76550
11270 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11271 it down to the anon code.
11273 * iterators.cs: Use dummy var here
11275 * codegen.cs: Handle new vars
11277 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11280 * class.cs (MethodData.Define): Set proper Obsolete context.
11282 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11284 (FieldExpr.DoResolve): Ditto.
11286 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11289 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11290 parent is not obsolete.
11292 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11294 * doc.cs : (FindDocumentedMember) find parameterless members first
11295 and get CS0419 in the early stage. Fixed first case of bug #76727.
11297 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11300 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11301 no error was reported.
11303 *expression.cs (Binary.DoResolve): left can be null.
11305 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11308 * class.cs (MethodData.Emit): Parameters should be labeled first.
11310 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11313 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11315 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11317 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11319 * class.cs (MethodCore): Parameter clean up.
11320 (IMethodData): Added ParameterInfo.
11321 (MethodData): Parameter clean up.
11322 (Indexer.Define): Parameter clean up.
11334 * typemanager.cs: Parameter clean up.
11336 * delegate.cs (Define): Get rid of duplicated code.
11338 * expression.cs (ParameterReference): Removed useless parameters
11340 (Invocation): Ditto.
11342 * parameter.cs (ParamsParameter): New class, params specialization.
11343 (ArglistParameter): Attemp to separate arglist.
11344 (Parameter): Refactored to be reusable and faster.
11345 (Parameter.Modifier): Made understandable.
11346 (Parameters): Changed to be used as a class for `this' assembly
11347 parameters. Refactored to use new specialized classes.
11349 * support.cs (ParameterData): Added Types property.
11350 (InternalParameters): Deleted.
11352 2005-08-20 Martin Baulig <martin@ximian.com>
11354 Merging this patch from GMCS to fix #75867.
11356 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11357 scope if we don't already have it.
11359 2005-11-17 Martin Baulig <martin@ximian.com>
11362 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11363 inherit the scope from our parent. Fixes #76653.
11365 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11367 * doc.cs : the previous patch does not actually fix the bug.
11368 PropertyInfo override check is now implemented and really fixed it.
11369 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11371 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11373 * doc.cs : apply "override filter" also to properties.
11376 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11378 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11379 no need to check overrides. For classes, omit those results from
11380 interfaces since they must exist in the class. Fixed bug #76726.
11382 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11384 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11385 with different parameters. Fixed the second problem in #76685.
11387 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11389 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11390 get expected 'protected' access in CheckValidFamilyAccess()).
11393 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11395 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11396 Fixed bug #76705. CS1569 was incorrectly commented out.
11398 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11400 * doc.cs : use Invocation.IsOverride() to do real override check.
11401 * expression.cs : made Invocation.IsOverride() internal.
11403 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11405 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11406 TypeBuilder.FindMembers() and filter overriden base members out.
11409 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11411 * doc.cs : ref/out parameters are represented as '@' (instead of
11412 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11414 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11416 * doc.cs : when there was no '.' in cref to methods in doc comment,
11417 then parameters were missing in the output. Fixed bug #76691.
11419 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11421 * driver.cs : don't output docs when there is an error.
11424 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11427 Now it should detect indexers. Fixed primary concern in bug #76685.
11428 Fixed CS0419 message to not show the identical member signature in
11431 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11433 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11434 instead of Type.FindMembers() since it does not handle events.
11437 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11439 * codegen.cs: Fixed typo (speficied -> specified).
11441 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11444 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11446 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11448 * attribute.cs: Changed error message.
11450 * cs-tokenizer.cs: One more check.
11452 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11454 * statement.cs (Block.Resolve): Ignore empty statement.
11456 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11458 * report.cs: Made error/warning methods more strict to avoid
11461 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11462 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11463 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11464 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11466 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11468 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11469 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11471 * class.cs (TypeContainer.IsComImport): New property.
11472 (Constructor.Define): Create proper ctor for ComImport types.
11474 * expression.cs (New.CheckComImport): Fixed.
11476 2005-11-07 Miguel de Icaza <miguel@novell.com>
11478 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11479 that a parameter has been captured does not mean that we do not
11480 have to do the rest of the processing. This fixes the second part
11481 of #76592. If there was another anonymous method capturing
11482 values in the past, the Scope would never be set for the second
11483 method that captured the same parameter.
11485 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11486 properly manipulate the stack. Second part of fix for #76592.
11488 * expression.cs (New): Add support for invoking "new" on
11489 interfaces that have been flagged with the ComImport attribute and
11490 the CoClass. Fixes #76637
11492 * statement.cs (Try.DoEmit): When a variable is captured, do not
11493 try to emit the vi.LocalBuilder variable as it has been captured.
11494 Create a temporary variable and store the results on the
11495 FieldBuilder. Fixes #76642
11497 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11499 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11501 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11503 * expression.cs (Binary.DoResolve): Added && optimalization.
11505 * typemanager.cs (AddUserType): Removed useless argument.
11507 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11509 * statement.cs (Block.variables): Uses ListDictionary.
11511 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11514 * class.cs (PartialContainer.EmitType): Customized to emit
11515 security attributes.
11516 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11517 for partial classes.
11519 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11522 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11523 access has to be fixed.
11525 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11527 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11530 * ecore.cs (NullCast.Reduce): Implemented.
11532 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11535 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11537 (Foreach.Resolve): Catch null properly.
11539 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11541 * cs-tokenizer.cs: Warning text fix.
11543 * driver.cs: AllWarningNumbers exposed on public interface.
11545 * report.cs (): Reviewed warning numbers.
11546 (IsValidWarning): Use binary search.
11548 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11550 * driver.cs: Implemeted resource visibility.
11551 (Resources): New class for code sharing between /res: and
11554 2005-10-28 Marek Safar <marek.safar@seznam.cz>
11557 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
11560 * convert (Convert.ImplicitReferenceConversion): NullCast holds
11563 * ecore.cs (NullCast): Child is contant only.
11565 * literal.cs (NullLiteral.Reduce): null can be converted to any
11568 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
11570 * driver.cs: Use Encoding.Default as default code page instead
11573 2005-10-27 Raja R Harinath <rharinath@novell.com>
11576 * expression.cs (Invocation.Error_InvalidArguments): Handle
11577 __arglist parameters.
11578 (Invocation.VerifyArgumentsCompat): Likewise.
11579 * support.cs (ReflectionParameters.GetSignatureForError): Print
11580 __arglist parameters.
11581 (InternalParamters.GetSignatureForError): Likewise.
11582 * parameter.cs (Parameters.GetSignatureForError): Likewise.
11584 2005-10-26 Marek Safar <marek.safar@seznam.cz>
11586 * attribute.cs (GetPropertyValue): Made public.
11588 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
11590 Add new property WrapNonExceptionThrows to handle 2.0 assembly
11592 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
11595 * driver.cs: Reflect method name change.
11597 * statement.cs (Try.Resolve): Warn when try has both general
11598 exception handlers.
11600 * typemanager.cs: runtime_compatibility_attr_type new predefined
11603 2005-10-26 Raja R Harinath <harinath@gmail.com>
11606 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
11607 treat it as an empty parameter list.
11609 2005-10-26 Raja R Harinath <rharinath@novell.com>
11612 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
11613 ResolveAsTypeStep silent.
11614 * statement.cs (Block.AddConstant): Mark block as used.
11615 (Block.ResolveMeta): Avoid piling on error messages
11616 if a constant initializer resolution fails.
11618 2005-10-25 Raja R Harinath <rharinath@novell.com>
11620 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
11622 (NamespaceEntry.VerifyAllUsing): New.
11623 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
11624 behaviour. Delegates actual resolution of alias to ...
11625 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
11626 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
11628 * driver.cs (Driver.MainDriver): Update.
11630 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
11631 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
11633 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
11635 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
11636 RootNamespace.DefineNamespacesForAll.
11638 2005-10-24 Raja R Harinath <harinath@gmail.com>
11640 * typemanager.cs (assemblies, external_aliases, modules)
11641 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
11642 (ComputeNamespaces, GetRootNamespace): Remove extra staging
11643 overhead. Move resposibility ...
11644 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
11645 * driver.cs, attribute.cs, codegen.cs: Update to changes.
11647 2005-10-23 Raja R Harinath <harinath@gmail.com>
11649 * namespace.cs (RootNamespace.all_namespaces): Renamed from
11650 cached_namespaces. Improve usage.
11651 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
11652 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
11653 Move from GlobalRootNamespace and simplify.
11654 (RootNamespace.Global): Make instance variable.
11655 (RootNamespace.RootNamespace): Add "alias name" parameter.
11656 (GlobalRootNamespace): Simplify drastically.
11657 (Namespace.Lookup): Don't use GetNamespace.
11658 * typemanager.cs (GetRootNamespace): Rename from
11659 ComputeNamespaceForAlias.
11660 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
11662 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11664 * anonymous.cs (AnonymousContainer): Don't crash when container
11667 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11669 * expression.cs (Binary.DoResolve): Warn when comparing same
11672 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11675 * expression.cs (Binary.DoResolve): It looks like there are no
11676 convetsion rules in enum context.
11678 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11680 Add support for extern alias qualifiers.
11681 * typemanager.cs: Move some LookupTypeReflection code
11682 to namespace.cs, to have cleaner code. Added some methods
11683 to help us keep track of the extern aliased references.
11684 * driver.cs: Add suport for extern alias assemblies on command
11685 line and check for their warnings/errors. Also keep track of the
11686 extern aliased assemblies.
11687 * namespace.cs: Move the global functionality of Namespace
11688 to GlobalRootNamespace/RootNamespace. Now the global namespace
11689 is GlobalRootNamespace.Globa. Also the code moved from
11690 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
11691 Finally added LocalAliasEntry (AliasEntry before) and
11692 ExternAliasEntry, to handle alias statements.
11693 * cs-parser.jay: Add support in the grammar for extern alias
11695 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
11696 Update callings to Namespace (now in GlobalRootNamespace).
11698 2005-10-18 Raja R Harinath <rharinath@novell.com>
11701 * class.cs (TypeContainer.DefineType): Move updating of
11702 topological sort earlier in the code.
11703 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
11705 2005-10-18 Marek Safar <marek.safar@seznam.cz>
11708 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
11710 * constant.cs (Constant.TryReduce): Moved from Cast class.
11711 (Reduce): Made little bit more OO and fixed missing conversions.
11713 * ecore.cs (Reduce): Implemented.
11714 (Binary.EnumLiftUp): New method to upgrade values to enum values.
11716 * literal.cs (Reduce): Implemented.
11718 * class.cs: Reverted Miguel's wrong commit.
11720 2005-10-14 Miguel de Icaza <miguel@novell.com>
11722 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
11724 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
11726 * cs-parser.jay, expression.cs : CS0214 was missing error location
11727 for constants. Fixed bug #76404.
11729 2005-10-11 Marek Safar <marek.safar@seznam.cz>
11732 * convert.cs (ExplicitConversionCore): Fixed object->enum
11735 2005-10-10 Raja R Harinath <rharinath@novell.com>
11737 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
11738 InstanceExpression.
11739 (PropertyExpr.EmitCall): Likewise.
11740 * expression.cs (Invocation.EmitArguments): Handle case where
11742 (Invocation.EmitCall): Avoid allocating temporary variable if
11743 there are no arguments.
11745 2005-10-07 Raja R Harinath <rharinath@novell.com>
11748 * convert.cs (ImplicitConversionStandard): Move conversion of
11749 void* to arbitrary pointer types ...
11750 (ExplicitConversionStandard): .. here.
11751 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
11752 error to always print typenames.
11754 2005-10-07 Raja R Harinath <rharinath@novell.com>
11756 * convert.cs (GetConversionOperator): Rename from
11757 GetConversionOperators. Move operator selection code from ...
11758 (UserDefinedConversion): ... here.
11760 2005-10-06 Marek Safar <marek.safar@seznam.cz>
11762 * convert.cs (ExplicitConversionCore): Removed duplicate enum
11765 2005-10-05 Marek Safar <marek.safar@seznam.cz>
11767 * assign.cs (Assign.DoResolve): Error method changed.
11769 * cfold.cs (DoConstantNumericPromotions): Error method changed.
11771 * const.cs (ResolveValue): Reset in_transit immediately.
11773 * constant.cs: Error method changed.
11775 * convert.cs: Removed useless location parameter.
11776 (ExplicitNumericConversion): Don't do double enum check.
11777 (ExplicitConversionCore): Renamed from ExplicitConversion.
11778 (ExplicitUnsafe): Extracted from ExplicitConversion.
11779 (ExplicitConversion): Uses for error reporting.
11781 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
11783 (ResolveBoolean): Uses common error method.
11784 (CastToDecimal): Get rid of ec.
11785 (CastFromDecimal): Optimized.
11786 (ConvCast): Get rid of ec.
11788 * enum.cs (ResolveValue): Reset in_transit immediately.
11789 (Emit): Return after first error.
11791 * expression.cs: Convert changes.
11793 * literal.cs: Error method changed.
11795 * statement.cs: Error method changed.
11797 2005-10-03 Raja R Harinath <rharinath@novell.com>
11799 * support.cs (SeekableStreamReader.Position): Don't error out when
11800 the requested position is just beyond the end of the current
11803 2005-09-28 Raja R Harinath <rharinath@novell.com>
11805 * support.cs (SeekableStreamReader): Simplify drastically. Don't
11806 try to keep in sync with the byte count of the underlying Stream.
11807 However, this limits us to a window size of 2048 characters: i.e.,
11808 the maximum lookahead of our lexer/parser can be 2048 characters.
11810 2005-09-28 Marek Safar <marek.safar@seznam.cz>
11813 * driver.cs: Fix compilation files with full root path.
11815 2005-09-25 Miguel de Icaza <miguel@novell.com>
11817 * report.cs (SymbolRelatedToPreviousError): Format the output so
11818 it does not use an open parenthesis that is never closed.
11820 * driver.cs: Follow coding guidelines
11822 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11825 * const.cs (Const.ResolveValue): Check for assigning non-null
11826 value to reference type.
11828 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11830 * anonymous.cs: Implemented ExprClassName.
11832 * assign.cs (Assign.DoResolve): Don't chrash when type is not
11835 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
11838 * class.cs (StaticClass.DefineContainerMembers): Report protected
11841 * codegen.cs: if(ed) PRODUCTION.
11843 * convert.cs (Error_CannotImplicitConversion): Better error
11846 * cs-parser.jay: More error checks.
11848 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
11850 * driver.cs (CSCParseOption): Enabled wrong option check.
11852 * ecore.cs (Expression.ExprClassName): Turned to property.
11853 (MemberExpr.CheckIntermediateModification): For checking boxed
11854 value types modification.
11856 * statement.cs (Fixed.Resolve): Expression type must be
11857 convertible to fixed type.
11858 (CollectionForeach.GetEnumeratorFilter,TryType):
11859 Small refactoring for easier error checking.
11861 2005-09-26 Marek Safar <marek.safar@seznam.cz>
11863 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
11866 * class.cs (GeneratedBaseInitializer): New class for customization
11867 compiler generated initializers.
11868 (MemberBase.DoDefine): Check Obsolete attribute here.
11869 (FieldMember.DoDefine): Ditto.
11871 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
11874 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
11875 (MemberCore.GetObsoleteAttribute): Removed argument.
11876 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
11877 (MemberCore.CheckObsoleteType): New helper.
11881 * statement.cs: Updates after MemberCore changes.
11883 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
11884 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
11886 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
11887 obsolete attribute for compiler construct.
11888 (As.DoResolve): Cache result.
11890 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
11892 2005-09-26 Raja R Harinath <rharinath@novell.com>
11895 * expression.cs (This.VerifyFixed): In a value type T, the type of
11896 'this' is T&, iow, 'this' is either an out or ref parameter. In a
11897 value type R, 'this' is treated as a value parameter.
11899 2005-09-22 Miguel de Icaza <miguel@novell.com>
11901 * statement.cs (Lock): Use the TemporaryVariable class instead of
11902 manually using local variables as those do not work when variables
11905 * ecore.cs: Moved the TemporaryVariable class from being a nested
11906 class inside Foreach to be a public class that can be employed in
11909 2005-09-19 Marek Safar <marek.safar@seznam.cz>
11911 * cs-parser.jay: interface_accessors replaced by
11912 accessor_declarations.
11914 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
11917 * statement.cs (GotoCase.Resolve): Convert null constant to
11919 (SwitchLabel.ResolveAndReduce): Ditto.
11920 (SwitchLabel.NullStringCase): Custom null stamp.
11921 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
11923 typemanager.cs (CSharpSignature): Don't skip first argument
11926 2005-09-18 Miguel de Icaza <miguel@novell.com>
11928 * driver.cs: Set InEmacs based on the environment variable EMACS.
11930 * location.cs (InEmacs): in this mode, do not report column
11931 location as it confuses Emacs.
11933 2005-09-16 Marek Safar <marek.safar@seznam.cz>
11935 * cfold.cs, constant.cs, convert.cs, ecore.cs,
11936 expression.cs, iterators.cs, literal.cs: Store constants and
11939 * class.cs (MemberBase.ShortName): Pass location.
11941 * cs-parser.jay: Some location fixes.
11943 * ecore.cs (Expression.Location): Made virtual.
11945 2005-09-05 Miguel de Icaza <miguel@novell.com>
11947 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
11948 if the underlying types are the same, otherwise we need to produce
11949 code that will do the proper cast.
11951 This was exposed by Marek's constant rewrite which produced
11952 invalid code for the call site:
11954 enum X : long { a }
11955 void Method (X v) {}
11959 This fixes test-49.cs
11961 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
11963 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
11964 Type/Object should be allowed as well. Fixed bug #75968.
11966 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
11968 * expression.cs : (Binary.DoResolve): when one is enum constant and
11969 another is constant 0, then return enum one *as enum type*.
11972 2005-09-02 Raja R Harinath <rharinath@novell.com>
11974 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
11978 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
11979 flow-branching for LocalVariableReferences in case we were invoked
11980 from a MemberAccess.
11981 * expression.cs (LocalVariableReference.VerifyAssigned): New.
11983 (LocalVariableReference.DoResolveBase): ... this.
11984 (MemberAccess.Resolve): Do the check that was disabled during
11987 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
11990 (PartialContainer.Create): check abstract/sealed/static strictly
11991 but abstract/sealed can exist only at one side. Fixed bug #75883.
11993 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
11996 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
11997 specified, don't default to UnmanagedType.I4.
11999 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12001 * expression.cs : conditional operator should check possibly
12002 incorrect assign expression. Fixed bug #75946.
12004 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12006 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12007 Reverting the change. gmcs is much complex than mcs on this matter.
12009 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12011 * cs-tokenizer.cs : To read another token ahead of the actual
12012 consumption, use new SavedToken and cache token instead of moving
12013 back the stream with SeekableStreamReader (it seemed problematic).
12015 driver.cs : Thus use StreamReader directly.
12016 * support.cs : Thus removed SeekableStreamReader.
12018 2005-08-30 Raja R Harinath <rharinath@novell.com>
12021 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12022 (ScopeInfo.EmitScopeType): Use it to construct field names from
12023 names of captured locals.
12026 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12027 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12028 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12029 (ExplicitConversion): Remove enum cases already handled by
12030 implicit conversion. Move implicit conversion check to the beginning.
12031 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12032 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12033 Don't treat System.Enum as a struct.
12035 2005-08-30 Jb Evain <jbevain@gmail.com>
12037 * attribute.cs: handles as expression in parameters.
12039 2005-08-30 Raja R Harinath <rharinath@novell.com>
12042 * class.cs (TypeContainer.VerifyClsName): Don't use a
12043 PartialContainer when verifying CLS compliance.
12044 (AbstractPropertyEventMethod): Set Parent here, ...
12045 (PropertyMethod): ... not here.
12047 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12049 * attribute.cs : escaped attribute name should not be allowed to be
12050 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12052 2005-08-29 Raja R Harinath <rharinath@novell.com>
12055 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12056 when converting a long constant to unsigned long.
12057 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12058 detect where IsApplicable and VerifyArgumentsCompat disagree.
12060 2005-08-29 Raja R Harinath <rharinath@novell.com>
12061 and Carlos Alberto Cortez <carlos@unixmexico.org>
12064 * class.cs (TypeContainer.CanElideInitializer): New helper.
12065 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12066 can safely emitting the initializer of a field.
12068 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12070 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12071 allowed inside a switch (without loop). Fixed bug #75433.
12073 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12075 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12076 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12078 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12080 * driver.cs : kinda reverting the default encoding changes (not exact
12081 revert since I noticed that "codepage:reset" might not work fine).
12083 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12085 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12086 Location. Now getter and setter store location correctly.
12087 (errors/cs0111-12.cs now reports the expected location.)
12089 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12091 * driver.cs : Use default encoding on the environment.
12092 Removed (now that) extra parameter for SeekableStreamReader.
12093 * support.cs : (SeekableStreamReader) third .ctor() argument for
12094 StreamReader is not required (always true). preamble size could
12095 be acquired in simpler and safe way.
12097 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12099 * cs-parser.jay: report CS0642 at warning level 3
12100 and report CS0642 for an if else statement also
12101 fixes bug #74745. Patch by John Luke (and a bit
12103 Removed extra CS0642 warning check for "while",
12105 * statement.cs: In Block.Resolve(), CS0642 check
12106 is reimplemented to check a sequence of an empty
12107 statement and a block.
12109 Both fix bug #66777.
12111 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12113 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12114 detection until I fix it.
12116 * cs-tokenizer.cs: Changed error message.
12118 * cs-parser.jay: Fixed 2 error locations.
12120 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12121 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12124 * enum.cs (GetSignatureForError): Fixed.
12126 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12130 * typemanager.cs (RegisterProperty): Removed.
12132 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12134 2005-08-24 Raja R Harinath <rharinath@novell.com>
12137 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12138 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12140 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12142 * expression.cs : tiny fix is required for not warning positive ulong.
12145 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12147 * expression.cs : add CS0652 check for constant and integral
12148 expression. Fixed bug #53974.
12150 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12152 * expression.cs : in DoNumericPromotions(), check if there is implicit
12153 conversion overload for string (to check CS0034). Fixed bug #52492.
12155 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12157 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12159 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12161 * ecore.cs : report location when it is *not* Null.
12163 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12169 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12170 correctly. Fixed bug #75721.
12172 2005-08-23 Raja R Harinath <rharinath@novell.com>
12174 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12175 loop that performs 'min (pos, char_count)'.
12178 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12179 converted value in Operator.OnesComplement.
12181 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12183 * anonymous.cs: If the anon method is pulled into a helper class,
12184 it needs to be `internal' not `private'. Fixes runtime behavior on
12187 2005-08-20 Martin Baulig <martin@ximian.com>
12189 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12190 scope if we don't already have it.
12192 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12193 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12196 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12199 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12200 is a partial class.
12202 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12204 The big constants rewrite
12205 Fix #75746, #75685 and more
12206 As a side effect saved 1MB for MWF ;-)
12208 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12209 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12210 enum based for corlib compilation.
12212 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12215 * class.cs (FixedField.Define): Use ResolveAsConstant.
12217 * const.cs (IConstant): Interface constants and enums.
12218 (Const.ResolveValue): New method for constant resolvning.
12219 (ExternalConstant): Constants from imported assemblies.
12221 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12222 conversion; like enums.
12223 (Constant.ToType): Converts this constant to different type.
12224 (Constant.Increment): Adds 1.
12226 * convert.cs (ImplicitConversionRequired): Simplified.
12228 * cs-parser.jay: Create EnumMember directly.
12230 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12232 * doc.cs (GenerateEnumDocComment): Removed.
12234 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12235 (ConvertIntLiteral): Removed.
12236 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12238 * enum.cs (EnumMember): Implement IConstant.
12239 (Enum.IsValidEnumConstant): Removed.
12240 (Enum.GetNextDefaultValue): Removed.
12241 (Enum.FindMembers): Updated.
12242 (Enum.GenerateDocComment): Iterate enum members.
12244 * expression.cs (Cast.TryReduce): Handle enums correctly.
12245 (New.Constantify): Made public.
12246 (MemberAccess.DoResolve): Removed contant specific if(s).
12248 * literal.cs (NullLiteral): Implement new abstract methods.
12250 * statement.cs (GotoCase.Resolve): Use new constant methods.
12251 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12253 * typemanager.cs (LookupEnum): Removed.
12254 (IsEnumType): Fixed to work with corlib.
12255 (RegisterConstant): Removed.
12256 (LookupConstant): Removed.
12257 (GetConstant): Changed to work with IConstant.
12259 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12261 * location.cs : Fixed overflown (>255) column number.
12263 2005-08-03 Raja R Harinath <rharinath@novell.com>
12265 First cut of the qualified-alias-member feature.
12266 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12268 * cs-parser.jay (DOUBLE_COLON): New token.
12269 (namespace_or_type_name): Add rule for recognizing
12270 qualified-alias-members.
12271 (primary_expression): Likewise.
12272 (element_access): Allow QualifiedAliasMember as a possible
12273 type-bearing expression.
12274 (local_variable_type, local_variable_pointer_type): Likewise.
12275 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12276 aliases in the current and enclosing namespace declarations.
12277 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12278 * decl.cs (MemberName.is_double_colon): New.
12279 (MemberName.MemberName): Add new constructor for alias-member.
12280 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12281 * expression.cs (QualifiedAliasMember): New expression type.
12283 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12285 * location.cs : it borked when no argument was specified.
12287 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12289 * location.cs : tiny ToString() format fix.
12291 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12293 * statement.cs : oops, it was missing.
12295 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12297 A set of fixes for precise line/column location.
12300 "token" field now holds a file/line "delta", a line number offset
12301 from the segment, and a column number. See also:
12302 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12303 December/009508.html
12304 Removed static IsNull. Use instance IsNull property instead.
12305 * cs-tokenizer.cs :
12306 For some tokens it stores Location. For Identifier it stores
12307 LocatedToken which is a pair of string name and location.
12308 Column numbers are adjusted only at getChar().
12310 Use Location.ToString() for reporting (it now contains column).
12312 Largely modified to use LocatedToken instead of
12313 string (IDENTIFIER), and to acquire Location from some tokens.
12314 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12315 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12317 Now MemberName holds Location. DeclSpace.ctor() receives Location
12318 as a parameter. Removed extra parameters to all derived classes.
12319 Replaced Location.IsNull() with instance property.
12320 * assign.cs, expression.cs :
12321 Added .ctor() overload that omits Location.
12323 Added "nameEscaped" flag that indicates the identifier was escaped
12324 in the source file. This fixes bug #57047.
12326 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12328 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12329 New method, looking for lo-case imported cls type.
12331 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12334 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12336 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12338 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12339 all_imported_types.
12340 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12342 Optimized to save 3.5 MB for SWF compilation.
12344 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12346 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12347 (PartialContainer.Create): Moved logic AddToContainer.
12348 (PartialContainer.MarkForDuplicationCheck): Shares name.
12350 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12353 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12355 (Namespace.GetSignatureForError): New method.
12357 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12358 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12360 2005-08-01 Raja R Harinath <rharinath@novell.com>
12363 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12364 member lookup rather than qualifier_type, since qualifier_type can
12367 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12369 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12372 2005-07-31 Miguel de Icaza <miguel@novell.com>
12374 * statement.cs: Copy the local exception into the exception
12375 captured local. Fixes 75674
12377 2005-07-31 Raja R Harinath <harinath@gmail.com>
12380 * expression.cs (Invocation.OverloadResolve): Don't report error
12381 CS1501 if error CS1502 has been reported.
12382 (New.DoResolve): Delegate CS1501 reporting to
12383 Invocation.OverloadResolve.
12386 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12387 invariant-meaning-in-block property in an enclosing block if
12390 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12392 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12393 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12394 (Switch.CheckSwitch): Just save 50kb for SWF.
12396 2005-07-27 Martin Baulig <martin@ximian.com>
12398 * anonymous.cs (CaptureContext.AddField): Added
12399 `AnonymousContainer am' argument; compute its toplevel scope if
12400 it's not already computed. Fixes #75649.
12402 2005-07-26 Raja R Harinath <rharinath@novell.com>
12405 * class.cs (Constructor.Emit): Reset block to null if the block
12408 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12410 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12412 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12414 * class.cs (MethodData.Define): Check whether accessor implementing
12415 interface is public.
12417 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12419 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12422 * namespace.cs (LookupType): Moved same type check to...
12424 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12425 with the same name.
12427 2005-07-21 Raja R Harinath <rharinath@novell.com>
12429 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12430 already found a typebuilder.
12431 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12432 MemberNames, not strings.
12434 * const.cs (Error_ExpressionMustBeConst):
12435 Rename from Error_EpressionMustBeConst.
12436 * const.cs, class.cs, statement.cd: Update.
12438 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12442 * const.cs (Const.LookupConstantValue): Report missing contant expression
12444 (Error_EpressionMustBeConstant): Only one error method.
12446 * class.cs, statement.c: Updated.
12448 2005-07-20 Raja R Harinath <rharinath@novell.com>
12450 * statement.cs (Block.Flags): Add back HasVarargs.
12451 (Block.flags): Make protected.
12452 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12454 * typemanager.cs (types, typecontainers, user_types): Remove.
12455 (UserTypes, TypeContainers): Likewise.
12456 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12457 (CleanUp, Reset): Update.
12458 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12459 (GetNestedType): Use Type.GetNestedType.
12460 (CoreLookupType): Take two arguments, the namespace and the
12461 basename of the type. Update to use the Namespace.Lookup
12463 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12464 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12465 string concatenation and substring matches.
12466 * class.cs, enum.cs, delegate.cs: Update to changes.
12468 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12470 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12471 Expression and made virtual.
12473 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12474 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12476 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12478 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12481 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12484 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12487 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12488 AssemblyCultureAttribute is not used on executable.
12491 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12493 2005-07-16 Raja R Harinath <rharinath@novell.com>
12496 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12497 New. Reports CS0252/CS0253.
12498 Mostly taken from preliminary patch by Duncak Mak.
12499 (Binary.DoResolveOperator): Store results of operator lookup.
12500 Use them to detect if we need to warn about unintended reference
12503 2005-07-15 Raja R Harinath <rharinath@novell.com>
12506 * namespace.cs (Namespace.Lookup): Add back location parameter.
12507 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12508 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12510 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12511 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12512 (Namespace.LookupType): ... this.
12513 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12515 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12516 purported to handle pointers.
12517 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12520 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12522 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12525 2005-07-15 Raja R Harinath <rharinath@novell.com>
12527 * namespace.cs (Namespace.Lookup): Drop location parameter.
12528 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12529 (NamespaceEntry.Lookup): ... this.
12530 (NamespaceEntry.Error_AmbiguousTypeReference):
12531 Move here from DeclSpace.
12532 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12534 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12535 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12536 Move to NamespaceEntry.
12537 * delegate.cs, expression.cs: Update to changes.
12539 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12541 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12542 CheckAttributeType and refactored.
12543 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12544 ResolveAsTypeTerminal error handling.
12545 (ResolveAsTypeTerminal): Introduced because of global attributes extra
12547 (GetSignatureForError): Print errors in same way.
12550 * codegen.cs: Reflect attribute GetSignatureForError change.
12553 * expression.cs: Add silent parameter to ResolveAsTypeStep.
12555 * namespace.cs (UsingEntry): Refactored to make fields private.
12558 statement.cs: Error_UnexpectedKind has extra parameter.
12560 2005-07-14 Raja R Harinath <rharinath@novell.com>
12562 * ecore.cs (IAlias): Remove.
12563 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
12564 that implement the interface.
12565 * namespace.cs (Namespace): Likewise.
12566 (Namespace.declspaces): Renamed from 'defined_names'.
12567 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
12568 DeclSpace instead of an IAlias.
12569 * tree.cs (Tree.AddDecl): Update.
12571 2005-07-12 Raja R Harinath <rharinath@novell.com>
12573 * statement.cs (Block.Flags); Remove HasVarargs.
12574 (Block.HasVarargs): Move to ToplevelBlock.
12575 (Block.ThisVariable, Block.AddThisVariable): Likewise.
12576 (Block.Variables): Make protected. Initialize variable hashtable
12578 (Block.AddVariable): Update.
12579 (Block.Resolve): Update to changes.
12580 (ToplevelBlock.HasVarargs): New boolean.
12581 (ToplevelBlock.ThisVariable): Move here from Block.
12582 (ToplevelBlock.AddThisVariable): Likewise.
12583 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
12584 * expression.cs (This.ResolveBase): Update to changes.
12585 (ArglistAccess.DoResolve): Likewise.
12587 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12590 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
12592 * class.cs (TypeContainer.VerifyMembers): Distinguish between
12593 not used and not used & assigned.
12594 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
12596 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12599 * expression.cs (Is.DoResolve): null is never provided type.
12601 2005-07-08 Marek Safar <marek.safar@seznam.cz>
12604 * cs-parser.jay: Less strict event error rule to catch more errors.
12606 2005-07-08 Martin Baulig <martin@ximian.com>
12608 Fix test-iter-10.cs - distinguish whether we `yield' in a property
12609 gettter (allowed) or setter (not allowed).
12611 * class.cs (Accessor): Implement IIteratorContainer.
12612 (Accessor.Yields): New public field.
12613 (PropertyBase.PropertyMethod.Define): Handle iterators on a
12614 per-accessor basis.
12617 (get_accessor_declaration, set_accessor_declaration): Set the
12618 `yields' flag on the accessor, not the property.
12619 (property_declaration): Do the iterators check on a per-accessor
12620 basis and not for the whole property.
12622 2005-07-08 Martin Baulig <martin@ximian.com>
12624 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
12625 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
12627 2005-07-07 Marek Safar <marek.safar@seznam.cz>
12630 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
12631 (ExtractSecurityPermissionSet): Cope with self referencing security
12632 attributes properly.
12634 * driver.cs (SetOutputFile): Made public property OutputFile.
12636 2005-07-07 Raja R Harinath <rharinath@novell.com>
12639 * class.cs (TypeContainer.first_nonstatic_field): Rename from
12640 has_nonstatic_fields. Make into a FieldBase pointer.
12641 (TypeContainer.AddField): Add CS0282 check.
12642 (TypeContainer.EmitType): Update.
12644 2005-07-06 Miguel de Icaza <miguel@novell.com>
12646 * cs-tokenizer.cs (consume_identifier): Do not create strings to
12647 compare if they start with __.
12649 2005-07-06 Raja R Harinath <rharinath@novell.com>
12651 * statement.cs (Switch.SwitchGoverningType): Only look at
12652 UserCasts that don't need implicit standard conversions to one of
12653 the allowed switch types (Fixes test-322.cs).
12654 (LocalInfo.Resolve): Re-enable sanity-test.
12656 2005-07-06 Marek Safar <marek.safar@seznam.cz>
12658 * cs-tokenizer.cs (consume_identifier): Detect double undescores
12660 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
12662 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
12664 2005-07-06 Raja R Harinath <rharinath@novell.com>
12667 * ecore.cs (SimpleName.GetSignatureForError): Add.
12668 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
12669 (MemberAccess.GetSignatureForError): Add.
12671 2005-07-05 Marek Safar <marek.safar@seznam.cz>
12673 The big error and warning messages review.
12703 * typemanager.cs: Updated.
12705 * class.cs: (MethodCore.SetYields): Moved here to share.
12706 (PropertyMethod.Define): Moved iterator setup here.
12708 * iterators.cs: Add orig_method to have full access to parent
12711 2005-07-05 Raja R Harinath <rharinath@novell.com>
12713 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
12714 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
12715 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
12716 variable of struct type.
12717 * expression.cs (Unary.ResolveOperator): Update to change.
12718 (Indirection.VerifyFixed): Likewise.
12719 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
12720 (ParameterReference.VerifyFixed): Value parameters are fixed.
12721 (This.VerifyFixed): Treat 'this' as a value parameter.
12722 * statement.cs (LocalInfo.IsFixed): Remove.
12724 2005-07-01 Martin Baulig <martin@ximian.com>
12726 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
12727 `ec.EmitThis ()' to get the correct scope.
12729 2005-07-01 Martin Baulig <martin@ximian.com>
12731 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
12732 instance is a ParameterReference; fixes #75299.
12734 2005-07-01 Martin Baulig <martin@ximian.com>
12736 Reverted Marek's latest patch (r46725):
12737 - it contains structural changes which are neither mentioned in
12738 the ChangeLog nor explained anywhere; for example the additional
12739 argument of EmitContext's and Iterator's .ctor's and the
12740 TypeContainer.DefineMembers() change.
12741 - structural changes like this should go in in seperate patches
12742 and not be hidden in a huge patch which just seems to affect
12743 warnings and errors.
12744 a big and hard to understand patch.
12745 - it breaks iterators and causes regressions, for instance in
12748 2005-06-30 Raja R Harinath <rharinath@novell.com>
12751 * expression.cs (Indexers.map): Remove.
12752 (Indexers.Append): Filter out inaccessible setters and getters.
12753 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
12756 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
12757 Refactored from ...
12758 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
12759 (FieldExpr.Emit, PropertyExpr.Emit): Update.
12760 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
12761 * expression.cs (Invocation.EmitCall): Add CS0120 check.
12763 2005-06-30 Marek Safar <marek.safar@seznam.cz>
12766 * class.cs (FieldBase.GetInitializerExpression): One more field
12769 2005-06-28 Miguel de Icaza <miguel@novell.com>
12771 * pending.cs: Do not define a proxy if the base method is virtual,
12772 it will be picked up by the runtime (bug 75270).
12774 2005-06-08 Martin Baulig <martin@ximian.com>
12776 The big Iterators rewrite :-)
12778 * iterators.cs: Rewrite this to use the anonymous methods framework.
12780 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
12781 before the TypeContainers; see 2test-21.cs.
12784 (TypeContainer.DefineType): Don't create a new EmitContext if we
12785 already have one (this only happens if we're an Iterator).
12786 (TypeContainer.Define): Also call Define() on all our iterators.
12787 (Method.CreateEmitContext): Added support for iterators.
12790 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
12791 (AnonymousContainer.CreateMethodHost): Moved here from
12792 AnonymousMethod and made abstract.
12793 (AnonymousContainer.CreateScopeType): New abstract method.
12794 (AnonymousContainer.IsIterator): New public property.
12795 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
12796 get the ScopeTypeBuilder rather than manually defining it here.
12797 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
12800 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
12801 before RootContext.DefineTypes().
12803 * codegen.cs (EmitContext.RemapToProxy): Removed.
12804 (EmitContext.CurrentAnonymousMethod): Changed type from
12805 AnonymousMethod -> AnonymousContainer.
12806 (EmitContext.ResolveTopBlock): Protect from being called twice.
12807 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
12808 (EmitContext.EmitThis): Removed the iterators hacks; use the
12809 anonymous methods framework for that.
12812 (ToplevelBlock.Container): Make this a property, not a field.
12813 (ToplevelBlock.ReParent): New public method; move the
12814 ToplevelBlock into a new container.
12815 (Foreach.TemporaryVariable): Simplify.
12817 2005-06-05 Martin Baulig <martin@ximian.com>
12819 * statement.cs (LocalInfo.CompilerGenerated): New flag.
12820 (Block.AddTemporaryVariable): New public method; creates a new
12821 `LocalInfo' for a temporary variable.
12822 (Block.EmitMeta): Create the LocalBuilders for all the temporary
12824 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
12825 non-iterator variables.
12827 2005-06-05 Martin Baulig <martin@ximian.com>
12829 * statement.cs (Foreach.TemporaryVariable): Create the
12830 LocalBuilder in the Emit phase and not in Resolve since in some
12831 situations, we don't have an ILGenerator during Resolve; see
12832 2test-19.cs for an example.
12834 2005-06-04 Martin Baulig <martin@ximian.com>
12836 **** Merged r45395 from GCS ****
12838 The big Foreach rewrite - Part II.
12840 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
12841 with `PropertyInfo ienumerator_getcurrent'.
12843 * codegen.cs (VariableStorage): Removed.
12846 (Foreach): Derive from Statement, not ExceptionStatement.
12847 (Foreach.CollectionForeach): New nested class. Moved all the code
12848 dealing with collection foreach here.
12849 (Foreach.ForeachHelperMethods): Removed.
12850 (Foreach.TemporaryVariable): Implement IMemoryLocation.
12852 2005-05-23 Martin Baulig <martin@ximian.com>
12854 * statement.cs (Try.DoResolve): Don't create a `finally' if we
12855 don't need to. Fix #75014.
12857 2005-05-20 Martin Baulig <martin@ximian.com>
12859 Merged r44808 from GMCS.
12861 * class.cs (TypeContainer.CircularDepException): Removed.
12862 (TypeContainer.DefineType): Removed the `InTransit' stuff.
12863 (TypeContainer.CheckRecursiveDefinition): Check for circular class
12864 (CS0146) and interface (CS0529) dependencies here.
12866 2005-06-21 Raja R Harinath <rharinath@novell.com>
12868 * expression.cs (Invocation.EmitCall): Fix initialization
12869 'this_call' to reflect current behaviour. Fix indentation.
12871 * convert.cs (FindMostEncompassedType): Add two trivial special
12872 cases (number_of_types == 0 || number_of_types == 1).
12873 (FindMostEncompasingType): Likewise.
12875 2005-06-17 Raja R Harinath <rharinath@novell.com>
12877 Some cleanups preparing for the fix of #75283.
12878 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
12880 (EventExpr.InstanceResolve): Likewise.
12881 (EventExpr.DoResolve): Remove redundant checks.
12883 2005-06-10 Duncan Mak <duncan@novell.com>
12885 * cs-tokenizer.cs (process_directives): New flag for controlling
12886 the processing of preprocessor directives.
12887 (x_token): After seeing a '#', return Token.NONE instead of going
12888 to handle_preprocessing_directive() when not processing
12889 directives. This avoids unnecessary processing during the token peek in
12894 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
12895 the existing error reporting methods instead of Report.Error.
12897 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
12898 after Raja's rewrite.
12900 2005-06-08 Miguel de Icaza <miguel@novell.com>
12902 * class.cs: Small fix.
12904 2005-06-08 Raja R Harinath <rharinath@novell.com>
12907 * class.cs (GetPartialBases): Fix return value check of
12908 part.GetClassBases.
12910 2005-06-07 Raja R Harinath <rharinath@novell.com>
12912 Ensure that partial classes are registered in their enclosing
12913 namespace. Initial part of fix of #75160.
12914 * tree.cs (Tree.RecordDecl): Add new namespace argument.
12915 Register declspace with namespace here, not in
12916 DeclSpace.RecordDecl.
12917 * cs-parser.jay: Pass namespace to RecordDecl.
12918 * class.cs (PartialContainer.Create): Likewise.
12919 (ClassPart.DefineType): New sanity-check. Throws an exception if
12921 * decl.cs (Declspace.RecordDecl): Remove.
12922 * namespace.cs (NamespaceEntry.DefineName): Remove.
12924 2005-06-06 Marek Safar <marek.safar@seznam.cz>
12926 * rootcontext.cs: Reset TargetExt as well.
12928 2005-06-03 Raja R Harinath <rharinath@novell.com>
12930 * ecore.cs (Expression.Resolve): Emit CS0654 error when
12931 -langversion:ISO-1.
12933 2005-06-02 Raja R Harinath <rharinath@novell.com>
12935 Fix #75080, cs0119.cs.
12936 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
12938 (Expression.Resolve): ... this. Use it. Remove bogus code
12939 allowing ExprClass.Type and ExprClass.Namespace for
12940 ResolveFlags.VariableOrValue.
12941 (Expression.Resolve) [1-argument variant]: Change default resolve
12942 flags based on language version.
12943 (Expression.Error_UnexpectedKind): Use a simple string array
12944 rather than an ArrayList.
12945 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
12946 not ExprClass.Type.
12947 (TypeOfVoid.DoResolve): Likewise.
12948 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
12949 flags argument -- it always has the same value.
12951 2005-05-31 Raja R Harinath <rharinath@novell.com>
12954 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
12955 Use it in the error message.
12956 * assign.cs, expression.cs, statement.cs: Update.
12958 2005-05-30 Raja R Harinath <rharinath@novell.com>
12961 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
12962 the "almostMatchedMember" case too.
12963 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
12964 that failed the accessibility checks to 'almost_match'.
12966 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
12968 * attribute.cs: Use internal MethodBuilder methods to set
12969 ExactSpelling and SetLastError on PInvoke methods, instead
12970 of passing them via charset. Fixes #75060.
12972 2005-05-27 Raja R Harinath <rharinath@novell.com>
12974 * parameter.cs (Parameter): Remove TODO comment.
12975 (Parameter.DefineParameter): Remove Location parameter.
12976 (Parameters.LabelParameters): Likewise.
12977 * class.cs (Constructor.Emit): Update to change.
12978 (MethodData.Emit): Likewise.
12979 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
12980 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
12982 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
12985 Removed Parameters.Location and added Parameter.Location instead.
12986 Removed Location parameter from Emit() and GetSignature().
12993 Modified all related calls.
12995 2005-05-26 Raja R Harinath <rharinath@novell.com>
12997 Improve user-defined conversion handling.
12998 * convert.cs (GetConversionOperators): Rewrite. Return only the
12999 applicable operators.
13000 (AddConversionOperators): New. Helper for GetConversionOperators.
13001 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13002 there is only one most encompassed/encompassing type.
13003 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13004 "applicable operator" handling.
13005 (UserConversion): Move cache here from GetConversionOperators.
13006 Directly cache the chosen operator, rather than the whole
13008 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13009 case. Allow conversion of decimal to sbyte and byte too.
13010 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13011 New static methods. Used to avoid allocating EmptyExpressions in
13014 2005-05-24 Duncan Mak <duncan@novell.com>
13016 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13017 another class, used in Convert.ExplicitNumericConversion.
13018 (CastToDecimal): New class, similar to above, but casts to
13019 System.Decimal, used in Convert.ImplicitNumericConversion and also
13020 in explicit convesion from double/float to decimal.
13022 * convert.cs (ImplicitNumericConversion): Handle implicit
13023 conversions to System.Decimal.
13024 (ExplicitNumericConversion): handle explicit conversions to
13029 2005-05-20 Miguel de Icaza <miguel@novell.com>
13031 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13032 know the type at this stage, just break through. Fixes #75008
13034 2005-05-19 Martin Baulig <martin@ximian.com>
13037 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13038 to disable error reporting.
13040 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13041 here since we don't want to report an error; see the new test-336.cs.
13043 2005-05-19 Raja R Harinath <rharinath@novell.com>
13045 * statement.cs (ToplevelBlock.GetParameterReference)
13046 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13047 Move here from class Block.
13048 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13049 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13051 2005-05-18 Martin Baulig <martin@ximian.com>
13056 (FlowBranching.Reachability): Add non-static public And() and Or()
13058 (FlowBranchingSwitch): New class; do the `break_origins' thing
13059 like in FlowBranchingLoop.
13060 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13061 reachability, not just locals and parameters.
13062 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13063 switch; MergeBreakOrigins() now takes care of that.
13065 2005-05-18 Martin Baulig <martin@ximian.com>
13067 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13068 a loop and may leave it, reset the barrier; fixes #74974.
13070 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13072 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13075 * cs-parser.jay: Catch more lexical errors.
13077 * report.cs: Add one more Error method.
13080 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13082 2005-05-17 Martin Baulig <martin@ximian.com>
13084 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13087 2005-05-16 Raja R Harinath <rharinath@novell.com>
13089 Fix test-382.cs. Emit values of decimal constants.
13090 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13092 (TypeContainer.AddField): ... this.
13093 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13094 with initializers to include 'Const's.
13095 (ClassPart.RegisterFieldForInitialization): Forward to
13097 * const.cs (Const.Const): Pass initializer to base class.
13098 (Const.Define): In case of decimal constants, register them for
13099 initialization in a static constructor.
13101 2005-05-14 Martin Baulig <martin@ximian.com>
13103 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13104 do not call ResolveUnreachable() on unreachable statements in
13105 here, see the comment in the source code.
13107 2005-05-13 Raja R Harinath <rharinath@novell.com>
13110 * expression.cs (BinaryResolveOperator): If one of the operands of
13111 an equality comparison is 'null' and the other is a pointer type,
13112 convert the null to a NullPointer.
13113 * convert.cs (ImplicitReferenceConversion): If the expression is a
13114 NullLiteral and the target type is a pointer type, return a
13115 NullPointer instead.
13116 (ImplicitConversionStandard): Likewise.
13118 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13120 * cs-parser.jay: Set readonly context based on special constructs.
13122 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13123 readonly variable error handling.
13125 * rootcontext.cs (EmitCode): Don't verify members when error
13128 * statement.cs (LocalInfo): Add reaodnly context information.
13129 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13131 2005-05-13 Raja R Harinath <rharinath@novell.com>
13133 * statement.cs (Block.Resolve): Revert change below. Modify fix
13134 for #74041 to initialize 'resolved' to false only for explicit
13135 blocks. Fixes #74873.
13137 2005-05-12 Raja R Harinath <harinath@gmail.com>
13140 * typemanager.cs (unmanaged_enclosing_types): New.
13141 (IsUnmanagedType): Avoid infloops by using
13142 'unmanaged_enclosing_types' to talk with recursive invocations.
13144 2005-05-13 Martin Baulig <martin@ximian.com>
13146 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13147 instance variable, not a local. Fix #74873.
13148 (Block.ResolveUnreachable): Set it to true here.
13150 2005-05-11 Duncan Mak <duncan@novell.com>
13152 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13153 continuing to process for 'arg'.
13154 (handle_preprocessing_directive): Check the argument of the #endif
13155 directive and report error CS1025 if there are any trailing
13158 According to the C# spec, having even whitespace after the #endif
13159 directive is illegal; however, because we call arg.TrimEnd ()
13160 beforehand, we have the same behavior as csc, allowing whitespace
13161 after the directive.
13165 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13169 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13170 (Constructor.GetObsoleteAttribute): Implemented correctly.
13172 2005-05-10 Martin Baulig <martin@ximian.com>
13174 * support.cs (ReflectionParameters.ParameterModifier): Use
13175 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13176 and `ParameterAttributes.In'. Fixes #74884.
13178 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13180 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13182 * expression.cs (Argument.GetParameterModifier): Turned to property.
13183 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13185 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13188 2005-05-09 Raja R Harinath <rharinath@novell.com>
13191 * decl.cs (MemberCache.AddMethods): Register override methods,
13192 rather than non-override methods.
13193 * typemanager.cs (RegisterOverride): New.
13194 (IsOverride): Update.
13196 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13200 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13201 recursive declaration.
13203 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13205 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13207 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13209 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13211 2005-05-05 Raja R Harinath <rharinath@novell.com>
13214 * decl.cs (DeclSpace.FamilyAccessible):
13215 Use TypeManager.IsNestedFamilyAccessible.
13217 Fix reopened #64812.
13218 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13221 2005-05-04 Raja R Harinath <rharinath@novell.com>
13222 Abin Thomas <projectmonokochi@rediffmail.com>
13223 Anoob V E <projectmonokochi@rediffmail.com>
13224 Harilal P R <projectmonokochi@rediffmail.com>
13227 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13228 allow access to all static members.
13230 2005-05-04 Martin Baulig <martin@ximian.com>
13232 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13234 2005-05-04 Martin Baulig <martin@ximian.com>
13238 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13239 section at the end; make things work if `default' is not the last
13242 2005-05-04 Martin Baulig <martin@ximian.com>
13246 * statement.cs (Switch): Replaced the `got_default' field with a
13247 `default_section' one.
13248 (Switch.CheckSwitch): Set `default_section' here.
13249 (Switch.Resolve): If we're a constant switch and the constant is
13250 not found, use the default section.
13252 2005-05-03 Martin Baulig <martin@ximian.com>
13254 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13256 * statement.cs (Foreach.ArrayForeach): New nested class.
13257 (Foreach.TemporaryVariable): New nested class.
13258 (Foreach.EmitArrayForeach): Removed; this is now in the new
13259 ArrayForeach class.
13261 2005-05-03 Raja R Harinath <rharinath@novell.com>
13263 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13265 (VerifyPendingMethods): Revert change below.
13267 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13268 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13269 that used to trigger warning -28. Remove warning -28.
13270 * expression.cs (Invocation.OverloadResolve): Use
13271 TypeManager.IsOverride to distinguish override methods.
13274 * pending.cs (VerifyPendingMethods): If a base type implements the
13275 requested interface, don't bother checking individual methods of
13276 the base type. As a side-effect, this prevents the creation of
13277 unnecessary proxies.
13279 2005-05-02 Martin Baulig <martin@ximian.com>
13283 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13284 Also `And' the locals if the old vector is null.
13285 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13286 null; in this case we basically reset all the variables.
13288 2005-05-02 Martin Baulig <martin@ximian.com>
13292 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13293 Added `FlowBranching branching' argument; always `and' the
13294 variables instead of `or'ing them unless we're an infinite loop.
13296 * statement.cs (While.Resolve): Create a new sibling unless we're
13299 2005-05-02 Martin Baulig <martin@ximian.com>
13303 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13304 arguments; use it instead of creating a new TopLevelBlock.
13305 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13306 our ConstructorInitializer.
13309 (TopLevelBlock.TopLevelBranching): New public property.
13310 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13311 and create our `TopLevelBranching'.
13313 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13314 anonymous method host, use `block.TopLevelBranching' rather than
13315 creating a new branching.
13317 2005-04-20 Miguel de Icaza <miguel@novell.com>
13319 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13320 a ScopeInfo, if any of the current children is a child of the new
13321 entry, move those children there.
13323 2005-04-30 Martin Baulig <martin@ximian.com>
13325 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13326 at the beginning of a SwitchSection. Fix #73335.
13328 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13331 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13333 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13334 (FieldExpr.DoResolve): Obsolete members are ignored for field
13337 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13339 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13340 of arrays detection.
13342 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13344 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13346 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13349 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13351 * cs-parser.jay: Use the prefered version of -unsafe in error
13354 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13356 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13359 2005-04-20 John Luke <john.luke@gmail.com>
13361 * driver.cs: fix typo in error message, --outout to --output
13363 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13365 * codegen.cs (InRefOutArgumentResolving): New field.
13367 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13368 fields outside contructor.
13370 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13372 2005-04-19 Miguel de Icaza <miguel@novell.com>
13374 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13375 parameter code was not completed ever, so it was not as up-to-date
13376 as local variables. Must finish it.
13378 The bug fix was to compare the Toplevel of the block, not the
13379 current block. Thanks for Ben for pointing this out.
13381 2005-04-19 Raja R Harinath <rharinath@novell.com>
13383 * decl.cs (AddMethods): Use the declaring type of the problem
13384 method to determine if we want to squash a warning.
13386 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13388 * attribute.cs: Removed debug output.
13390 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13392 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13395 2005-04-18 Raja R Harinath <rharinath@novell.com>
13398 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13399 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13400 all null comparisons against reference types.
13402 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13405 * class.cs (TypeContainer.CircularDepException) New nested
13407 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13408 (TypeContainer.DefineType): Removed error, reset InTransit before
13410 (Class.DefineType): Throw exception when is in Transit.
13411 Catch exception and report error.
13412 (Struct.DefineType): Throw exception when is in Transit.
13413 Catch exception and report error.
13414 (Interface.DefineType): Throw exception when is in Transit.
13415 Catch exception and report error.
13417 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13418 handle nested exception handlers.
13420 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13423 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13424 InFinally and InCatch storage.
13426 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13427 (Catch.Resolve): Set and Restore ec.InCatch.
13428 (Try.Resolve): Set and Restore ec.InFinally.
13429 (Try.HasCatch): True when try has catch.
13431 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13433 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13434 for the same event member, so exclude such cases from warning 419.
13437 2005-04-16 Miguel de Icaza <miguel@novell.com>
13439 * expression.cs (Binary.ResolveOperator): Apply patch from John
13440 Luke to fix bug 59864: operators &, | and ^ on enumerations
13441 require that the same enum type on both sides.
13443 * driver.cs: Add warnings to old flag usage, this is to assist
13444 people who produce Makefiles and hope that the Makefiles will be
13447 * class.cs (TypeContainer.EmitType): Moved the definition of the
13448 special $PRIVATE$ field from the resolve phase to the Emit phase.
13449 During resolve we do not know if we are a struct with
13450 HasExplicitLayout, we know this only after the attributes for the
13453 Set the FieldOffset to zero on the dummy field that we create for
13454 the class. Fixes 74590.
13456 2005-04-16 Raja R Harinath <rharinath@novell.com>
13459 * ecore.cs (PropertyExpr.resolved): New.
13460 (DoResolve): Use it to handle a case of double resolution here.
13461 Handle a case of identical-name-and-type-name.
13462 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13463 resolution by storing the results of expression resolution back
13464 into the "probes" array.
13466 2005-04-15 Raja R Harinath <rharinath@novell.com>
13468 Fix cs0208-7.cs and cs0208-8.cs.
13469 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13470 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13471 error reporting to point out the reason a struct is not unmanaged.
13473 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13475 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13476 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13478 2005-04-13 Raja R Harinath <rharinath@novell.com>
13481 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13482 IdenticalNameAndTypeName here.
13483 (EventExpr.InstanceResolve): Likewise.
13485 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13487 C# 2.0 DefaultCharSetAttribute implementation
13489 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13490 which allows us to set GlobalNamespace for every resolve.
13491 (Attribute.ResolveArguments): Cut from Resolve.
13492 (Attribute.GetCharSetValue): Returns CharSet named argument.
13493 (Attribute.DefinePInvokeMethod): Gets default charset from
13495 (GlobalAttribute.ResolveAsTypeStep): Override.
13496 (GlobalAttribute.ResolveArguments): Override.
13498 * class.cs (TypeAttr): Is protected.
13500 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13501 (ModuleClass.DefaultCharSetType): New memeber.
13502 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13504 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13505 charset from module.
13507 * delegate.cs (TypeAttr): Override.
13508 (Delegate.DefineType): Use this TypeAttr.
13510 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13511 at very early stage (before types are defined) to resolve model
13512 module attributes. It will probably not work with corlib but it
13515 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13516 charset from module.
13518 * typemanager.cs (default_charset_type): New type.
13520 2005-04-13 Raja R Harinath <rharinath@novell.com>
13522 * decl.cs (MemberCache.AddMethods): Don't warn if
13523 System.Object.Finalize has buggy MethodAttributes.
13525 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13528 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13530 * doc.cs : detect ambiguous reference to overloaded members.
13531 Fixed bug #71603. MS 1.1 csc does not detect it.
13533 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13535 * doc.cs : delegates must not be referenced with parameters.
13538 2005-04-12 Miguel de Icaza <miguel@novell.com>
13540 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13542 2005-04-10 Miguel de Icaza <miguel@novell.com>
13544 * driver.cs (MainDriver): Stop processing if the CLS stage found
13547 (CompilerCallableEntryPoint.InvokeCompiler): Always
13548 reset after execution; Take a TextWriter argument for the
13551 * report.cs: Use the error stream instead of hardcoding stderr.
13553 2005-04-09 Miguel de Icaza <miguel@novell.com>
13555 * class.cs: Reduce code paths to test, too small of an
13556 optimization to make it worth the extra testing. Always perform
13559 2005-04-08 Raja R Harinath <rharinath@novell.com>
13562 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
13563 operators that had errors reported on them.
13565 2005-04-08 Marek Safar <marek.safar@seznam.cz>
13567 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
13569 (Attribute.Resolve): Add named argument type checking.
13571 * class.cs (FixedField.Define): Use IsPrimitiveType
13573 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
13575 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
13576 unsafe parameter types.
13578 * statement.cs (Using.ResolveExpression): Add better error description.
13580 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
13582 2005-04-08 Raja R Harinath <rharinath@novell.com>
13585 * attribute.cs (Attribute.GetAttributeUsage): Resolve
13586 AttributeUsageAttribute in the emitcontext of the attribute class,
13587 not in the emitcontext of the attributable entity it was attached to.
13588 * cs-parser.jay: Use 'current_class', not 'current_container',
13589 when creating a GlobalAttribute.
13591 2005-04-08 Alp Toker <alp@atoker.com>
13593 * pending.cs: The fix to #58413 failed to compile methods implementing
13594 interfaces with/without params modifiers and vice versa, even though
13595 params modifiers aren't part of the signature. Make the modifier check
13596 less strict as in csc.
13598 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
13599 Anoob V E <projectmonokochi@rediffmail.com>
13600 Harilal P R <projectmonokochi@rediffmail.com>
13603 * pending.cs (TypeAndMethods.mods): New. Store the parameter
13604 modifiers of pending methods.
13605 (PendingImplementation.PendingImplementation): Initialize it.
13606 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
13607 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
13608 with ParameterData. Add check for modifiers.
13609 * class.cs (MethodData.Define): Update to changes.
13611 2005-04-07 Raja R Harinath <rharinath@novell.com>
13613 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
13615 2005-04-07 Marek Safar <marek.safar@seznam.cz>
13617 * class.cs (PropertyMethod.Define): Check private accessor in abstract
13620 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
13623 * typemanager.cs: Registered RequiredAttributeAttribute.
13625 2005-04-06 Marek Safar <marek.safar@seznam.cz>
13627 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
13628 Warning CS0169 is back at level 3.
13629 (IMethodData.SetMemberIsUsed): New method.
13631 * decl.cs (IsUsed): New value; moved from FieldBase.Status
13632 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
13634 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
13636 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
13638 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
13641 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
13644 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
13645 to avoid the problems with nested types.
13647 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
13648 Anoob V.E <projectmonokochi@rediffmail.com>
13649 Harilal P.R <projectmonokochi@rediffmail.com>
13650 Raja R Harinath <rharinath@novell.com>
13653 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
13655 * typemanager (GetConstructor): Make public.
13657 2005-04-05 John Luke <john.luke@gmail.com>
13658 Raja R Harinath <rharinath@novell.com>
13661 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
13662 struct too. Return false quicker in a few cases.
13663 (VerifyUnManaged): Use it.
13665 2005-04-05 Raja R Harinath <rharinath@novell.com>
13668 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
13669 not 'unreachable_seen'.
13671 2005-04-04 Marek Safar <marek.safar@seznam.cz>
13673 * attribute.cs (Attribute.GetValue): Removed unused.
13675 * codegen.cs (CodeGen.TrimExt): Removed unused.
13677 * cs-parser.jay (output): Removed unused.
13679 * cs-tokenizer.cs (hex_digits): Removed unused.
13681 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
13683 * expression.cs (Indirection.LoadExprValue): Removed unused.
13684 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
13686 * iterators.cs (Iterator.param_types): Removed unused.
13688 * statement.cs (Goto.block): Removed unused.
13689 (ToplevelBlock.did): Removed unused.
13690 (Switch.ResolveConstantSwitch): Removed unused.
13692 2005-04-01 Ben Maurer <bmaurer@ximian.com>
13694 * rootcontext.cs: Allow mcs to bootstrap with the compilation
13697 2005-04-01 Raja R Harinath <rharinath@novell.com>
13699 Fix #74232 and cs0208-3.cs.
13700 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
13701 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
13702 unmanaged type. Don't use FieldBuilders when 't' is a
13703 TypeBuilder. Use ModFlags and MemberType fields.
13704 * class.cs (MemberBase.member_type): Rename from MemberType.
13705 (MemberBase.MemberType): New property. Determines member_type on
13707 (MemberBase.DoDefine): Don't initialize MemberType here.
13708 (FieldMember.Define): Likewise.
13710 2005-04-01 Marek Safar <marek.safar@seznam.cz>
13713 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
13714 Attributes are emitted there.
13716 2005-04-01 Raja R Harinath <rharinath@novell.com>
13718 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
13719 keyword in 'partial enum' too.
13720 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
13722 Report from Kamil Skalski <nazgul@omega.pl>.
13725 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
13726 have partial containers too.
13728 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
13729 in block' checks to Block.CheckInvariantMeaningInBlock.
13730 * statement.cs (Block.GetKnownVariableInfo): Make private.
13731 (Block.IsVariableUsedInChildBlock): Remove.
13732 (Block.IsVariableUsedInBlock): Likewise.
13733 (Block.CheckInvariantMeaningInBlock): New. Show location of
13734 conflicting declaration.
13735 (Block.AddVariable): Make error messages less long-winded and more
13736 specific. Show location of conflicting declaration.
13737 * parameter.cs (Parameters.Location): New readonly property.
13739 2005-03-31 Raja R Harinath <rharinath@novell.com>
13741 Clean up semantics of invoking ResolveMemberAccess.
13742 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
13743 can have an instance, ensure that we pass in a non-TypeExpression
13744 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
13745 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
13746 argument. Update to changes and simplify.
13747 (FieldExpr.Emitinstance): Remove CS0120 check.
13748 (PropertyExpr.EmitInstance): Likewise.
13749 * expression.cs (Argument.Resolve): Likewise.
13750 (Invocation.DoResolve): Update to changes in semantics of
13751 InstanceExpression.
13753 2005-03-31 Marek Safar <marek.safar@seznam.cz>
13756 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
13759 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
13761 2005-03-31 Raja R Harinath <rharinath@novell.com>
13763 Fix difference in behaviour with commandline invocation.
13764 * driver.cs (Driver.Reset): New.
13765 (CompilerCallableEntryPoint): Call it.
13767 * statement.cs (If.Resolve): Avoid spurious "uninitialized
13768 variable" warnings if the boolean expression failed to resolve.
13770 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
13772 * attribute.cs: Fix the union of several permissions when some of them
13773 are unrestricted (so the result isn't an unrestricted permission set).
13776 2005-03-30 Raja R Harinath <rharinath@novell.com>
13778 * ecore.cs (MemberExpr): New class. Convert from interface
13780 (MemberExpr.ResolveMemberAccess): Refactor and move here from
13781 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
13783 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
13784 (MethodGroupExpr.IsExplicitImpl): Remove.
13785 (Expression.GetFieldFromEvent): Remove.
13786 (SimpleName.MemberStaticCheck): Remove.
13787 (SimpleName.DoSimpleNameResolve): Update to changes.
13788 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
13789 (MemberAccess.IdenticalNameAndTypeName): Remove.
13790 (MemberAccess.error176): Move to MemberExpr.
13791 (MemberAccess.DoResolve): Update to changes.
13792 (BaseAccess.DoResolve): Likewise.
13794 2005-03-30 Marek Safar <marek.safar@seznam.cz>
13796 C# 2.0 Conditional attribute class implementation
13798 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
13799 Analyzes class whether it has attribute which has ConditionalAttribute
13800 and its condition is not defined.
13802 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
13803 (Class.IsExcluded): New method. Search for at least one defined
13804 condition in ConditionalAttribute of attribute class.
13806 2005-03-30 Raja R Harinath <rharinath@novell.com>
13808 * ecore.cs (PropertyExpr): Derive from Expression, not
13809 ExpressionStatement.
13810 (PropertyExpr.EmitStatement): Remove.
13812 2005-03-29 Raja R Harinath <rharinath@novell.com>
13815 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
13816 internal field "value__" of an enum be private. The examples for
13817 "value__" that I found on MSDN all used FieldAttributes.Private.
13819 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
13820 Don't mention IL method attribute names.
13822 Fix #47991. Remove a TODO.
13823 * statement.cs (Block.Toplevel): Make into a field.
13824 (Block.Parameters): Move into ToplevelBlock.
13825 (Block.known_variables): Rename from child_variable_names.
13826 (Block.Block): Remove variants that take Parameters. Initialize
13827 'Toplevel' with the immediately surrounding toplevel block.
13828 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
13829 LocalInfo parameter.
13830 (Block.GetKnownVariableInfo): New.
13831 (Block.IsVariableNameUsedInChildBlock): Update.
13832 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
13833 the block, even though it may not be in scope.
13834 (Block.AddVariable): Remove Parameters parameter. Use
13835 Toplevel.Parameters instead.
13836 (Block.AddConstant): Remove Parameters parameter.
13837 (Block.GetParameterReference): Update to use Toplevel.Parameters.
13838 (Block.IsParamaterReference): Likewise.
13839 (Block.IsLocalParameter): Likewise. Simplify a lot.
13840 (ToplevelBlock.Parameters): New. Moved from Block.
13841 (ToplevelBlock.ToplevelBlock): Update to changes. Always
13842 initialize Parameters to a non-null value.
13843 * cs-parser.jay: Update to changes.
13844 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
13845 simple names that mean different things in the same block. Use
13846 Block.IsVariableNameUsedInBlock.
13848 2005-03-28 Raja R Harinath <rharinath@novell.com>
13850 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
13851 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
13852 GetTypeHandle. It is possible for a reflected type to derive from
13853 a TypeBuilder (e.g., int[] derives from the TypeBuilder
13854 System.Array during mscorlib compilation).
13855 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
13856 contain a method_hash, don't create one either. Don't create a
13857 deep copy of the base cache's method_hash.
13858 (MemberCache.SetupCache): Rename back from DeepCopy.
13859 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
13860 already initialized. If we see an override function, add its
13861 underlying base virtual function to the member_hash too.
13863 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
13865 2005-03-26 Raja R Harinath <harinath@acm.org>
13868 * assign.cs (Assign.DoResolve): When the RHS of an assignment
13869 fails to resolve, ensure that the LHS is still resolved as an
13872 2005-03-25 Raja R Harinath <harinath@acm.org>
13874 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
13876 (Enum.current_ec): Remove.
13877 (Enum.LookupEnumValue): Remove EmitContext argument.
13878 Just uses the one created during DefineType.
13879 (Enum.FindMembers): Update.
13880 * expression.cs (MemberAccess.DoResolve): Update.
13882 2005-03-22 Marek Safar <marek.safar@seznam.cz>
13884 * assign.cs (Assign.DoResolve): Check for CS1717 when
13885 source and target are same (uses Equals).
13887 * expression.cs (LocalVariableReference, ParameterReference,
13888 This): Implemented Equals, GetHashCode.
13890 * statement.cs (Block.GetParameterReference): Removed useless
13893 2005-03-22 Raja R Harinath <rharinath@novell.com>
13896 * statement.cs (Block.AddVariable): Ensure that we skip implicit
13897 blocks before deciding whether the error is cs0136 or cs0128.
13899 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
13900 (using_alias_directive, using_namespace_directive): Pass
13901 MemberName, not an expression to Namespace.UsingAlias and
13903 (MakeName): Use the MemberName of the namespace.
13904 * namespace.cs (Namespace.MemberName): New.
13905 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
13906 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
13908 * decl.cs (MemberName.Name): Make readonly.
13909 (MemberName.FromDotted): New "constructor".
13910 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
13911 (MemberCore.Name): Compute from MemberName on demand.
13912 (MemberCore.SetMemberName): Provide a way to change the
13914 (MemberCore.AddToContainer): Don't take a fullname parameter.
13915 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
13916 fully qualified name of the container to the member name.
13917 (TypeContainer.AddToTypeContainer): Use a fully qualified name
13918 only if the type is a member of the root container.
13919 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
13920 MemberName.Left rather than searching for an embedded ".".
13921 (PartialContainer.CreatePart): Update to changes in RootContext.
13922 (MemberBase.ShortName): Turn into a property. Use
13923 MemberCore.SetMemberName.
13924 (MemberBase.ExplicitInterfaceName): Remove.
13925 (MemberBase.UpdateMemberName): Remove.
13926 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
13927 (PropertyBase.SetMemberName): New override.
13928 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
13929 (Tree.GetDecl): New.
13930 (Tree.AllDecls): Rename from Decls.
13931 * attribute.cs, enum.cs, report.cs: Update to changes.
13932 * driver.cs (MainDriver): Use MemberName.FromDotted on
13933 RootContext.MainClass.
13935 2005-03-21 Marek Safar <marek.safar@seznam.cz>
13937 * class.cs (FixedField.Define): Check for CS1664 and more sanity
13940 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
13942 2005-03-18 Marek Safar <marek.safar@seznam.cz>
13944 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
13945 property accessor modifiers.
13947 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
13948 fixed buffer attribute (CS1716).
13949 (PropertyMethod.HasCustomAccessModifier): When property accessor
13950 has custom modifier.
13952 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
13954 (PropertyExpr.DoResolveLValue): Add CS0272.
13956 2005-03-17 Miguel de Icaza <miguel@novell.com>
13958 * convert.cs: When converting to a pointer, use the proper Conv.U
13959 or Conv.I depending on the source data type.
13961 * cs-tokenizer.cs: Make the size for large decimal constants,
13964 2005-03-17 Martin Baulig <martin@ximian.com>
13966 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
13967 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
13969 2005-03-17 Martin Baulig <martin@ximian.com>
13971 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
13972 to bool so we can return an error condition.
13973 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
13976 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
13978 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
13981 2005-03-16 Raja R Harinath <rharinath@novell.com>
13983 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
13984 Refactor to avoid traversing the list of assemblies, and to avoid
13985 string concatenation.
13986 * typemanager.cs (guid_attr_type): Remove.
13987 (negative_hits, pointers, references): Remove hashes.
13989 (GetConstructedType): New. Uses type_hash to handle constructed
13990 types (arrays, references, pointers).
13991 (GetReferenceType, GetPointerType): Use it.
13992 (GetNestedType): New. Uses type_hash to handle nested types of
13994 (LookupType, LookupTypeDirect): Remove.
13995 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
13996 'types' hash and LookupTypeReflection directly.
13997 (params_string, params_object): Use GetConstructedType.
13998 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14000 (Namespace.Lookup): Use cached_types.
14001 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14002 provided by old TypeManager.LookupType.
14003 * rootcontext.cs (MakeFQN): Remove.
14004 * decl.cs (DeclSpace.MakeFQN): Likewise.
14005 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14006 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14007 TypeManager.GetConstructedType.
14008 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14010 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14012 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14015 * cs-parser.jay: Reports CS1527 for any namespace element.
14017 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14020 * expression.cs (ParameterReference.IsAssigned): Changed error to
14022 (Error_WrongNumArguments): Moved CS0245 detection here.
14024 * statement.cs (Return.Resolve): Add CS1622 report.
14026 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14028 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14030 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14032 * attribute.cs expression.cs: Get rid of some allocations.
14034 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14036 * doc.cs : just eliminate the latest change.
14038 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14040 * doc.cs : commented out the latest change. It breaks xml-030.cs
14042 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14044 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14045 fail. So invoke CreateType() in FindDocumentedType().
14047 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14049 * cs-tokenizer.cs : added IsKeyword().
14050 * doc.cs : Detect keyword incorrectly used as identifier.
14051 Allow identifiers prefixed by @.
14053 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14055 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14056 It caused exception in namespace resolving (again!).
14058 * class.cs (Class.ctor): Removed exit.
14059 (PropertyMethod.ctor): ditto.
14061 * codegen.cs (Codegen.Reset): Reset static data.
14062 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14064 * cs-tokenizer.cs (Cleanup): Removed.
14066 * driver.cs (GetSystemDir): Rewrote to one line command.
14067 It caused problem with unloaded dynamic modules.
14068 (UnixParseOption): Removed Exit.
14069 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14070 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14071 Now can be mcs used as library.
14073 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14076 * location.cs (Reset): Reset static data.
14078 * namespace.cs (Reset): Reset static data.
14080 * report.cs (Report.Reset): Reset static data.
14082 * rootcontext.cs (RootContext.Reset): Reset static data.
14084 * tree.cs (RootTypes.ctor): Use Location.Null
14086 * typemanager.cs (TypeManager.Reset): Reset static data.
14087 (CoreLookupType): Removed Exit.
14088 (TypeHandle.Reset): Reset static data.
14090 2005-03-10 Raja R Harinath <rharinath@novell.com>
14093 * typemanager.cs (ComputeNamespaces): Import namespaces from
14094 referenced modules too.
14096 2005-03-09 Raja R Harinath <rharinath@novell.com>
14098 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14101 2005-03-09 Raja R Harinath <rharinath@novell.com>
14103 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14104 enclosing DeclSpace. This ensures that a name-lookup populates
14105 more caches and there are fewer 'TypeExpression's. Carve out
14106 nested type lookup into ...
14107 (LookupNestedTypeInHierarchy): ... this.
14109 2005-03-09 Raja R Harinath <rharinath@novell.com>
14111 Clean up a few partial-class semantics.
14112 Fixes test-357.cs and cs1618-2.cs.
14113 * cs-parser.jay (struct_declaration): Use 'current_class' as
14114 parent of newly-created struct. Remove call to Register ().
14115 Use 'pop_current_class' to complete handing the current struct.
14116 (interface_declaration): Likewise.
14117 (class_declaration): Likewise.
14118 (enum_declaration): Use 'current_class' as parent of newly created
14120 (delegate_declaration): Likewise.
14121 (pop_current_class): New function. This is used to handle closing
14122 up the 'current_class' and 'current_container', and pointing them
14123 to the enclosing class/container.
14124 (CSharpParser): Initialize 'current_class' too.
14125 * decl.cs (MemberCore): Add check for invariant: a partial
14126 container is not a parsed entity, and thus does not enclose any
14128 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14129 (DeclSpace.BaseTypeExpr): Use it.
14130 (DeclSpace.LookupType): Add check for invariant.
14131 * class.cs (TypeContainer): Add check for invariant: a nested
14132 class should have the same NamespaceEntry as its enclosing class.
14133 (TypeContainer.EmitFieldInitializers): Make virtual.
14134 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14136 (TypeContainer.Register): Remove.
14137 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14138 null. Use TypeResolveEmitContext for resolving base types and
14139 interfaces. Move initialization of Parts.TypeBuilder here from
14141 (TypeContainer.DefineNestedTypes): ... here.
14142 (PartialContainer): Take a Namespace not a NamespaceEntry.
14143 (PartialContainer.Create): Don't use Register. Call the
14144 appropriate Add... function directly.
14145 (ClassPart): Take both the PartialContainer and the enclosing
14146 class as constructor arguments.
14147 (ClassPart.EmitFieldInitializers): Override.
14148 (ClassPart.PartFindNestedTypes): Remove.
14149 (FieldBase.GetInitializerExpression): Resolve the initializer
14150 expression in the emit context of the enclosing class.
14151 * tree.cs (RootTypes): Remove Register ().
14153 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14155 * cs-parser.jay: Removed CS0134.
14157 * driver.cs: Removed CS1901.
14159 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14160 for predefined types.
14162 2005-03-07 Duncan Mak <duncan@novell.com>
14164 * codegen.cs (Save): Catch UnauthorizedAccessException as
14165 well. Fixes bug #73454.
14167 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14169 * cs-tokenizer.cs (xtoken): Add CS1035.
14171 * class.cs (MethodData.Define): Add CS0683.
14172 (FieldMember.ctor): Add CS0681.
14174 2005-03-07 Raja R Harinath <rharinath@novell.com>
14176 * ecore.cs (SimpleName.DoResolve): Rename from
14177 SimpleName.DoResolveAllowStatic.
14178 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14179 Pass 'intermediate' flag to MemberStaticCheck.
14180 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14181 of "intermediate" lookups via MemberAccess.
14182 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14183 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14185 2005-03-07 Raja R Harinath <rharinath@novell.com>
14188 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14189 slipped in because of variable names that are identical to a
14190 builtin type's BCL equivalent ('string String;', 'int Int32;').
14191 (PropertyExpr.EmitInstance): Likewise.
14193 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14195 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14197 * report.cs (warning_ignore_table): Made public.
14199 2005-03-04 Raja R Harinath <rharinath@novell.com>
14202 * class.cs (MethodData.Emit): Pass 'container' to
14203 container.GetObsoleteAttribute instead of 'container.Parent'.
14205 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14207 * cs-parser.jay: Add 1534 error test.
14209 * iterators.cs (Yield.CheckContext): Add error 1629.
14210 (Iterator.ctor): Save unsafe modifier.
14211 (MoveNextMethod.DoEmit): Restore unsafe context.
14213 * namespace.cs (UsingAlias): Better error message.
14215 2005-03-03 Dan Winship <danw@novell.com>
14217 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14218 the warning message [#73219]
14220 2005-03-03 Raja R Harinath <rharinath@novell.com>
14222 Fix compile with MCS 1.0.0.0.
14223 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14224 w_restore to not depend on string constant folding.
14226 2005-03-03 Raja R Harinath <rharinath@novell.com>
14228 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14229 CS0246 check to users who passed 'silent = false'.
14230 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14232 (SimpleName.SimpleNameResolve): Update.
14233 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14234 (MemberAccess.IdenticalNameAndTypeName): Update.
14235 * doc.cs (FindDocumentedTypeNonArray): Update.
14237 2005-03-03 Raja R Harinath <rharinath@novell.com>
14239 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14240 * parameters.cs (ComputeAndDefineParameters): Remove.
14241 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14242 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14243 Use GetParameterInfo.
14245 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14247 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14249 2005-03-02 Raja R Harinath <rharinath@novell.com>
14251 Unify DeclSpace.LookupType and DeclSpace.FindType.
14252 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14253 is in charge of defining nested types on demand.
14254 (DeclSpace.LookupType): Use it when the current_type is a
14255 TypeBuilder. Use LookupTypeDirect for reflected types.
14256 (DeclSpace.FindType): Remove.
14257 (DeclSpace.LookupInterfaceOrClass): Likewise.
14258 (DeclSpace.DefineTypeAndParents): Likewise.
14259 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14260 DeclSpace.LookupType.
14261 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14262 * typemanager.cs (LookupType): Simplify.
14263 (AddUserType): Remove type from negative_hits.
14264 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14265 * class.cs (TypeContainer.FindMembers): Move handling of nested
14267 (TypeContainer.FindMembers_NestedTypes): ... here.
14268 (TypeContainer.FindNestedType): Implement override.
14269 (ClassPart.FindNestedType): Delegate to PartialContainer.
14270 (ClassPart.PartFindNestedType): Looks up the nested types of the
14273 2005-03-02 Martin Baulig <martin@ximian.com>
14275 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14276 static constructor in static classes.
14278 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14280 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14281 sizeParamIndex is not specified.
14283 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14286 * report.cs (WarningMessage.IsEnabled): Missing null check.
14288 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14290 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14291 in the fields and not in the properties.
14293 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14295 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14298 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14300 * attribute.cs: Small refactoring (improved robustness).
14301 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14302 (ValidateGuid): Removed.
14303 (Resolve): Removed referenced to above mentioned.
14304 (GetAttributeUsage): Made private and changed to work without
14306 (GetIndexerAttributeValue): Don't crash.
14307 (GetConditionalAttributeValue): Ditto.
14308 (GetClsCompliantAttributeValue): Ditto.
14309 (ExtractSecurityPermissionSet): All attributes exceptions are
14311 (GetPropertyValue): New helper.
14312 (GetMethodImplOptions): New method.
14313 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14314 some missing properties.
14316 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14317 (Method.ApplyAttributeBuilder): Updated.
14319 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14322 2005-02-28 Raja R Harinath <rharinath@novell.com>
14325 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14326 non-simple types (array, pointer, reference).
14328 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14330 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14332 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14334 (Method.CheckBase): Catch wrong destructor here.
14335 (MethodData.Define): Add errors 550, 668.
14337 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14339 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14341 * pending.cs (VerifyPendingMethods): Add error 551.
14343 * typemanager.cs (CSharpName): Next error report helper.
14345 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14347 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14348 attributes. Removed useless attribute double check.
14349 It saves almost 2MBs for corlib.
14351 2005-02-25 Raja R Harinath <rharinath@novell.com>
14354 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14355 called twice in case of error.
14357 2005-02-23 Chris Toshok <toshok@ximian.com>
14359 Fix compiler portions of #72827.
14360 * statement.cs (Block.Emit): call Begin/EndScope on the
14361 EmitContext instead of the ILGenerator.
14363 * codegen.cs (EmitContext.BeginScope): new method, call
14364 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14366 (EmitContext.BeginScope): same, but EndScope and CloseScope
14368 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14369 offset and call the superclass's OpenScope(int) with it.
14370 (SymbolWriter.CloseScope): get the current il
14371 offset and call superclass's CloseScope(int) with it.
14373 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14375 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14376 CS1677 for out and ref as well.
14378 * class.cs (Method.Define): Add error CS1599 detection.
14380 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14382 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14384 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14386 * support.cs.cs (ModifierDesc): New helper method.
14388 2005-02-23 Raja R Harinath <rharinath@novell.com>
14389 Abin Thomas <projectmonokochi@rediffmail.com>
14390 Anoob V E <projectmonokochi@rediffmail.com>
14391 Harilal P R <projectmonokochi@rediffmail.com>
14393 Fix #57851, #72718.
14394 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14395 MemberLookup (used for error reporting) actually returns a result.
14396 Fix error report number (122, not 112).
14398 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14399 Anoob V E <projectmonokochi@rediffmail.com>
14400 Harilal P R <projectmonokochi@rediffmail.com>
14403 * pending.cs (PendingImplementation.GetAbstractMethods):
14404 Find NonPublic members too.
14406 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14408 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14411 * class.cs (MethodCore.CheckMethodAgainstBase):
14412 Add error 239 report.
14414 2005-02-21 Raja R Harinath <rharinath@novell.com>
14417 * expression.cs (Invocation.IsApplicable): Make public.
14418 (Invocation.IsParamsMethodApplicable): Likewise.
14419 * delegate.cs (Delegate.VerifyApplicability): Don't use
14420 Invocation.VerifyArgumentCompat for parameter applicability
14421 testing. Use Invocation.IsApplicable and
14422 Invocation.IsParamsMethodApplicable.
14424 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14426 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14428 * class.cs (Operator.Define): Add error 217 report.
14430 2005-02-21 Raja R Harinath <rharinath@novell.com>
14432 * namespace.cs (UsingEntry.Resolve): Undo change below.
14434 2005-02-21 Raja R Harinath <rharinath@novell.com>
14437 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14438 disable the error message when the extended MemberLookup also
14440 (Expression.MemberLookupFinal): Update.
14441 (SimpleName.DoSimpleNameResolve): Update.
14442 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14443 Don't use MemberLookupFinal.
14444 (New.DoResolve): Update.
14445 (BaseAccess.CommonResolve): Update.
14447 2005-02-21 Raja R Harinath <rharinath@novell.com>
14450 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14451 occured previously, don't resolve again.
14453 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14456 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14457 argument. Call ResolveAttributeUsage for unresolved.
14458 when types doesn't match ctor arguments.
14460 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14461 for nested attribute classes.
14462 (Class.attribute_usage): Removed.
14463 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14464 for attribute class.
14466 * ecore.cs (IsAttribute): Removed.
14468 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14470 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14472 (attribute_types): Removed.
14473 (EmitCode): Global attributes are emited as the latest.
14475 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14477 * class.cs (EmitFieldInitializers): Don't emit field initializer
14478 for default values when optimilization is on.
14480 * constant.cs (Constant.IsDefaultValue): New property.
14482 * driver.cs: Add /optimize handling.
14486 * literal.cs: Implement new IsDefaultValue property.
14488 * rootcontext.cs (Optimize): New field, holds /optimize option.
14490 2005-02-18 Raja R Harinath <rharinath@novell.com>
14492 Fix crasher in re-opened #72347.
14493 * namespace.cs (Namespace.Lookup): Return null if
14494 DeclSpace.DefineType returns null.
14497 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14499 2005-02-18 Raja R Harinath <rharinath@novell.com>
14501 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14502 now returns null if it cannot resolve to an lvalue.
14503 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14504 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14505 returned null. Remove check for SimpleName.
14506 (EventExpr.DoResolveLValue): New.
14507 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14508 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14510 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14511 avoid CS0131 error.
14512 (Unary.ResolveOperator): Move CS0211 check ...
14513 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14515 (Unary.DoResolveLValue): Simplify.
14516 (AddressOf.DoResolveLValue): New.
14517 (ArrayAccess.DoResolveLValue): New.
14519 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14521 * attribute.cs (Attribute.Resolve): Add arguments casting for
14522 when types doesn't match ctor arguments.
14524 2005-02-16 Raja R Harinath <rharinath@novell.com>
14526 Fix parts of #63202.
14527 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14528 lookup of operator in base type. Ensure that all checks happen
14529 when the operator resolves to an "op_..." method.
14531 2005-02-15 Raja R Harinath <rharinath@novell.com>
14534 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14535 'ignore_cs0104' parameter. Pass it to ...
14536 (NamespaceEntry.Lookup): ... this.
14537 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14538 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14539 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14540 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14541 Update. Request that cs0104 errors be ignored.
14542 (ComposedCast.ResolveAsTypeStep): Update.
14544 2005-02-14 Raja R Harinath <rharinath@novell.com>
14547 * expression.cs (Invocation.BetterFunction): Remove support for
14548 comparing virtual functions and their overrides.
14549 (Invocation.IsOverride): New.
14550 (Invocation.OverloadResolve): Don't consider 'override' functions
14551 during candidate selection. Store them in a lookaside list.
14552 If the selected method is a 'virtual' function, use the list to
14553 find any overrides that are closer to the LHS type.
14555 2005-02-14 Marek Safar <marek.safar@seznam.cz>
14557 * expression.cs (New.DoResolve): Add complex core type reduction.
14558 (New.Constantify): Converts complex core type syntax like 'new int ()'
14559 to simple constant.
14561 2005-02-14 Raja R Harinath <rharinath@novell.com>
14563 * decl.cs (EntryType.EntryType): New constructor to create an
14564 updated copy of a cache entry.
14565 (MemberCache.AddMethods): Use it.
14566 (MemberCache.ClearDeclaredOnly): Remove.
14567 (MemberCache.MemberCache): Update.
14569 2005-02-11 Miguel de Icaza <miguel@novell.com>
14571 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
14572 variable. This one is represents the actual low-level declaration
14573 of the method, as opposed to the semantic level `IsStatic'.
14575 An anonymous method which is hosted into a static method might be
14576 actually an instance method. IsStatic would reflect the
14577 container, while MethodIsStatic represents the actual code
14580 * expression.cs (ParameterReference): Use the new MethodIsStatic
14581 instead of IsStatic.
14583 * anonymous.cs (AnonymousMethod.Compatible): Pass the
14584 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
14585 set on the current EmitContext.
14587 * expression.cs (Cast): Overload DoResolveLValue so we can pass
14588 resolve our casted expression as an LValue. This triggers the
14589 proper LValue processing that is later required by Assign.
14593 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
14595 2005-02-11 Marek Safar <marek.safar@seznam.cz>
14597 C# 2.0 Fixed buffer implementation
14599 * anonymous.cs: Update after RegisterHelperClass renaming.
14601 * attribute.cs (AttributeTester.fixed_buffer_cache):
14602 Cache of external fixed buffers.
14603 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
14604 implementation if field is fixed buffer else null.
14607 (TypeContainer.AddField): Accept FieldMember instead of Field.
14608 (FieldBase.IsFieldClsCompliant): Extracted code from
14609 VerifyClsCompliance descendant customization.
14610 (FixedField): New class handles fixed buffer fields.
14611 (FixedFieldExternal): Keeps information about imported fixed
14613 (IFixedField): Make access to internal or external fixed buffer
14616 * cs-parser.jay: Add fixed buffer parsing.
14618 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
14621 * expression.cs (Indirection): Extended implementation to accept
14622 fixed buffer field.
14623 (PointerArithmetic.Emit): Get element from fixed buffer as well.
14624 (ElementAccess.MakePointerAccess): Get type as parameter.
14625 (DoResolve): Add fixed buffer field expression conversion.
14626 (DoResolveLValue): Ditto.
14627 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
14628 (ArrayPtr): Derives from FixedBufferPtr.
14629 (ArrayPtr.Emit): Add extra emit for array elements.
14631 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
14633 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
14634 for compiler generated types.
14635 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
14637 * statement.cs (Fixed): Refactored to be easier add fixed buffer
14638 and consume less memory.
14639 (Fixed.Resolve): Add fixed buffer case.
14641 * typemanager.cs (compiler_generated_attr_ctor,
14642 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
14643 (HasElementType): Add our own implementation to work on every
14646 2005-02-11 Miguel de Icaza <miguel@novell.com>
14648 * anonymous.cs (CaptureContext): Track whether `this' has been
14651 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
14652 only captured `this' if it was implicitly done (instance
14653 methods/variables were used).
14655 * codegen.cs (EmitContext.CaptureThis): New method to flag that
14656 `this' must be captured.
14658 2005-01-30 Miguel de Icaza <miguel@novell.com>
14660 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
14661 is null it means that there has been no need to capture anything,
14662 so we just create a sibling.
14664 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
14666 Just a partial fix. The other half is fairly elusive.
14668 2005-02-10 Raja R Harinath <rharinath@novell.com>
14670 Fix #52586, cs0121-4.cs.
14671 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
14672 and return a hashtable.
14673 (MemberCache.ClearDeclaredOnly): New.
14674 (MemberCache.MemberCache): Update to change. Make a deep copy of
14675 the method_hash of a base type too.
14676 (MemberCache.AddMethods): Adapt to having a deep copy of the base
14677 type methods. Overwrite entries with the same MethodHandle so
14678 that the ReflectedType is correct. The process leaves in base
14679 virtual functions and their overrides as distinct entries.
14680 (CacheEntry): Now a class instead of a struct. It shouldn't alter
14681 matters since it was boxed in a ArrayList before.
14682 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
14684 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
14685 case of a virtual function and its override (choose the overload
14687 (Invocation.OverloadResolve): Avoid 'override' members during
14688 'applicable_type' calculation.
14690 2005-02-09 Raja R Harinath <rharinath@novell.com>
14692 Combine two near-redundant caches.
14693 * typemanager.cs (method_params): Rename from method_internal_params.
14694 (TypeManager.GetParameterData): New. Replace
14695 Invocation.GetParameterData.
14696 (TypeManager.LookupParametersByBuilder): Remove.
14697 * expression.cs (Invocation.method_parameter_cache): Remove.
14698 (Invocation.GetParameterData): Remove.
14700 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
14703 2005-02-08 Raja R Harinath <rharinath@novell.com>
14706 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
14707 TypeManager.multicast_delegate_type is null, resolve it by looking
14708 up "System.MulticastDelegate".
14709 * rootcontext.cs (RootContext.ResolveCore): Simplify.
14711 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
14712 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
14713 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
14716 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
14717 (LabeledStatement.AddReference): New. Set 'referenced'.
14718 (Goto.Resolve): Use it.
14720 2005-02-05 John Luke <john.luke@gmail.com>
14722 * driver.cs: remove duplicate -doc line in Usage ()
14724 2005-02-04 Raja R Harinath <rharinath@novell.com>
14726 * location.cs (Location.AddFile): Fix CS2002 error report.
14728 2005-02-02 Martin Baulig <martin@ximian.com>
14730 * delegate.cs (Delegate.DefineType): Report an internal error if
14731 TypeManager.multicast_delegate_type is null. See bug #72015 for
14734 2005-02-02 Raja R Harinath <rharinath@novell.com>
14736 Fix a crasher in a variant of #31984.
14737 * const.cs (Constant.CheckBase): New override that defers the
14738 new-or-override check in case the base type hasn't been populated
14740 (Constant.Define): Ensure the new-or-override check is performed.
14742 2005-02-01 Duncan Mak <duncan@ximian.com>
14744 * const.cs (LookupConstantValue): Check that `ce' is not null
14745 before calling GetValue ().
14747 2005-02-01 Raja R Harinath <rharinath@novell.com>
14749 Fix test-334.cs (#69519).
14750 * cs-parser.jay (using_alias_directive): Pass in an expression to
14751 NamespaceEntry.UsingAlias.
14752 (using_namespace_directive): Pass in an expression to
14753 NamespaceEntry.Using.
14754 (namespace_name): Don't flatten to a string.
14755 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
14756 (NamespaceEntry.AliasEntry.Resolve): Lookup using
14758 (NamespaceEntry.UsingEntry): Likewise.
14759 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
14761 (NamespaceEntry.LookupForUsing): Remove.
14762 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
14764 (NamespaceEntry.Lookup): Remove support for dotted names.
14766 2005-02-01 Raja R Harinath <rharinath@novell.com>
14768 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
14770 (NamespaceEntry.ImplicitParent): Compute on demand.
14771 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
14772 parallels the current.
14773 (NamespaceEntry.LookupForUsing): Use it.
14774 (NamespaceEntry.Lookup): If the current namespace-entry is
14775 implicit, don't search aliases and using tables.
14777 2005-02-01 Raja R Harinath <rharinath@novell.com>
14780 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
14782 (TypeContainer.BaseCache): Compute on demand.
14783 (TypeContainer.FindMembers): Define constants and types if they're
14784 not already created.
14785 (FieldMember.Define): Move resetting of ec.InUnsafe before error
14787 * const.cs (Constant.Define): Make idempotent.
14789 2005-01-29 Miguel de Icaza <miguel@novell.com>
14791 * pending.cs: Produce better code (no nops produced by using Ldarg
14794 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
14795 i - 1' it should be arg + 1.
14799 2005-01-28 Raja R Harinath <rharinath@novell.com>
14801 * attribute.cs (Attribute.CheckAttributeType): Make private
14803 (Attribute.ResolveType): Make virtual.
14804 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
14805 handling of RootContext.Tree.Types.
14807 2005-01-27 Raja R Harinath <rharinath@novell.com>
14809 Update attribute-handling to use the SimpleName/MemberAccess
14811 * cs-parser.jay (attribute): Pass in an expression to the
14812 constructors of Attribute and GlobalAttribute.
14813 * attribute.cs (Attribute): Take an expression for the name.
14814 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
14815 passed in attribute name expression.
14816 (Attribute.CheckAttributeType): Use it.
14817 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
14818 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
14819 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
14820 argument to prevent error messages if the lookup fails.
14822 2005-01-27 Marek Safar <marek.safar@seznam.cz>
14824 * expression.cs (Indirection): Implemented IVariable interface
14825 to support indirection in AddressOf operator.
14826 (PointerArithmetic.Emit): Add optimalization for case where
14827 result can be precomputed.
14829 2005-01-26 Martin Baulig <martin@ximian.com>
14831 * class.cs (TypeContainer.AttributeTargets): Return the correct
14832 AttributeTargets depending on our `Kind' instead of throwing an
14833 exception; fixes #71632.
14835 2005-01-26 Marek Safar <marek.safar@seznam.cz>
14838 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
14841 2005-01-25 Raja R Harinath <rharinath@novell.com>
14844 * expression.cs (MemberAccess.DoResolve): Don't complain with
14845 cs0572 when the LHS of a member access has identical name and type
14848 2005-01-25 Marek Safar <marek.safar@seznam.cz>
14851 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
14853 Create custom PermissionSet only for PermissionSetAttribute.
14855 2005-01-24 Marek Safar <marek.safar@seznam.cz>
14858 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
14859 delegates in static class.
14861 2005-01-24 Martin Baulig <martin@ximian.com>
14863 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14864 merging an implicit block, just use its reachability.
14866 * statement.cs (Block.Resolve): Make the unreachable code check
14867 work wrt. implicit blocks; see test-337 from #63842.
14869 2005-01-21 Alp Toker <alp@atoker.com>
14871 * cs-parser.jay: destructor_declaration's container is PartialContainer
14872 not Class when partial types are used, so use Kind prop instead of
14875 2005-01-22 Miguel de Icaza <miguel@ximian.com>
14877 * cs-parser.jay: Improve error reporting when an interface
14878 declares new types.
14880 2005-01-20 Dick Porter <dick@ximian.com>
14882 * support.cs: SeekableStreamReader fix from Sandor Dobos
14883 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
14884 chars are read. Fixes bug 70369.
14886 2005-01-20 Raja R Harinath <rharinath@novell.com>
14888 * cs-parser.jay (catch_clause): Simplify current_block handling
14891 2005-01-17 Miguel de Icaza <miguel@ximian.com>
14893 * convert.cs (ImplicitStandardConversionExists): Synchronize the
14894 code with ImplicitStandardConversion to handle the implicit
14895 conversion of method groups into valid delegate invocations.
14897 The problem is that in parameter handling we were using this code
14898 path. Fixes bug #64698
14900 2005-01-19 Raja R Harinath <rharinath@novell.com>
14902 * cs-parser.jay: Fix several infelicities.
14903 - Avoid assigning to the parser value stack. Code like
14904 '$3 = null' is unclean. Synthesize a value for the code block
14906 - Avoid using oob_stack for storing location information. Use ...
14907 (_mark_): ... this. New (empty) rule. Saves the current location
14909 (foreach_statement): Avoid using oob_stack for current_block
14910 handling. Use technique used in for_statement and
14911 using_statement. Synthesize a value for the code block to store
14912 additional intermediate information.
14914 2005-01-13 Miguel de Icaza <miguel@ximian.com>
14916 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
14917 of a different type is only allowed to private fields of a
14918 containing type, not on fields of a base class.
14920 See test-174.cs and error cs0122-9.cs
14922 2005-01-13 Raja R Harinath <rharinath@novell.com>
14924 Fix test-335.cs (bug #58126).
14925 * cs-parser.jay (argument): Split out non-expression parts of the
14926 rule into 'non_simple_argument'.
14927 (invocation_expression): Support parenthesized invocations with
14928 multiple arguments, and with single non-simple arguments.
14930 2005-01-13 Raja R Harinath <rharinath@novell.com>
14932 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
14935 2005-01-12 Raja R Harinath <rharinath@novell.com>
14937 Fix cs0038-1.cs, cs1640-6.cs.
14938 * ecore.cs (Expression.Resolve): Remove special-case for
14939 SimpleName in error-handling.
14940 (Expression.almostMatchedMembers): Relax access permission to
14942 (Expression.MemberLookupFailed): Handle duplicates in
14943 almostMatchedMembers list.
14944 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
14945 * expression.cs (New.DoResolve): Report CS1540 for more cases.
14946 * typemanager.cs (GetFullNameSignature): Use the MethodBase
14947 overload if the passed in MemberInfo is a MethodBase.
14949 2005-01-12 Marek Safar <marek.safar@seznam.cz>
14952 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
14953 for non-CAS & merge permission sets properly.
14955 2005-01-11 Raja R Harinath <rharinath@novell.com>
14957 Improve standard-compliance of simple name and member access
14958 resolution. Fixes bugs #52697, #57200, #67520, #69519.
14959 * ecore.cs (FullNamedExpression): New abstract base class
14960 for Namespaces and TypeExpressions.
14961 (ResolveFlags.SimpleName): Remove.
14962 (SimpleName): Remove support for dotted names.
14963 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
14964 DeclSpace.FindType and DeclSpace.LookupType.
14965 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
14966 (Expression.ExprClassName): Make member function.
14967 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
14968 a namespace. Remove creation of dotted "SimpleName"s.
14969 (MemberAccess.DoResolve): Likewise.
14970 * decl.cs (DeclSpace.Cache): Make private.
14971 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
14972 (DeclSpace.FindType): Update.
14973 (DeclSpace.LookupType): Move here from RootContext. Return a
14974 FullNamedExpression.
14975 * namespace.cs (Namespace): Derive from FullNamedExpression
14976 so that it can be part of expression resolution.
14977 (Namespace.Lookup): Return an FullNamedExpression.
14978 (NamespaceEntry.LookupAlias): Lookup aliases only in current
14980 * rootcontext.cs (NamespaceLookup): Remove.
14981 (LookupType): Move to DeclSpace.
14982 * attribute.cs (CheckAttributeType): Update.
14983 * doc.cs (FindDocumentedType): Remove allowAlias argument.
14984 (FindDocumentedTypeNonArray): Likewise.
14986 2005-01-11 Raja R Harinath <rharinath@novell.com>
14988 Fix cs0509.cs, cs1632.cs.
14989 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
14990 is the same as IsInterface.
14991 (TypeContainer.GetClassBases): Likewise.
14992 * statement.cs (LabeledStatement.ig): New field.
14993 (LabeledStatement.LabelTarget): Save ILGenerator which created the
14995 (LabeledStatement.DoEmit): Check that the label was created with
14996 the same ILGenerator.
14998 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15001 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15002 accessors to its properties.
15004 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15005 from accessors to property.
15007 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15010 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15011 only for overrides.
15013 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15015 * attribute.cs: Check for null and empty strings.
15017 I have lost another battle to Paolo.
15019 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15022 * class.cs (PropertyMethod): Set Parent field in ctors.
15023 (SetMethod.InternalParameters): Add unsafe switch hack.
15024 Override MarkForDuplicationCheck where it is appropriate.
15026 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15027 It says whether container allows members with the same name.
15028 Base default is no.
15029 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15030 Removed is_method parameter.
15032 2005-01-06 Duncan Mak <duncan@ximian.com>
15034 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15035 because the previous change led to incorrect reporting of CS1032
15036 ("Cannot define/undefine preprocessor symbols after first token in
15037 file"). Instead of using `tokens_seen' as the only flag that
15038 triggers CS1040, introduce `comments_seen'. This new flag is used
15039 to signify having seen comments on the current line, so it is
15040 unset after a newline.
15042 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15044 * doc.cs : When searching for a type, find nested type too.
15045 This fixes bug #71040.
15047 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15050 - Warn missing member comment on those classes which also does not
15051 have doc comments. Fixed bug #71041.
15052 - Don't warn missing doc comment on default constructor.
15055 2005-01-06 Duncan Mak <duncan@ximian.com>
15057 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15058 comments, set `tokens_seen' to true. This allows us to detect
15059 misplaced preprocessor directives (i.e. not at the beginning of
15060 the a line, nor after whitespaces). In that case, report error
15061 CS1040. This fixes bug #56460.
15063 * cs-parser.jay (interface_member_declaration): Add checks for
15064 IsExplicitImpl, and report CS0541 error if an interface member is
15065 defined as an explicit interface declaration.
15067 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15070 * class.cs (PropertyMethod): Set Parent field in ctors.
15071 (SetMethod.InternalParameters): Add unsafe switch hack.
15073 * decl.cs (MemberCore.Parent): Cannot be readonly.
15075 2005-01-06 Raja R Harinath <rharinath@novell.com>
15077 * decl.cs (DeclSpace.ResolveType): Remove.
15078 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15079 Merge in code from ...
15080 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15081 * class.cs, enum.cs: Update to changes.
15083 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15085 * anonymous.cs: Ensure that we init the scope of our parent if it
15086 has not been initialized yet.
15088 2004-12-30 Duncan Mak <duncan@ximian.com>
15090 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15091 if field.FieldBuilder is null. Fixes #70758.
15093 * convert.cs: Fixed some typos and updated some of the comments.
15094 (ImplicitStandardConversionExists):
15095 (TryImplicitIntConversion): If `target_type' is an interface and
15096 the type of `ic' implements this interface, return true or a new
15097 BoxedCast instead of null. This fixes #70468.
15099 2004-12-29 Duncan Mak <duncan@ximian.com>
15101 * expression.cs (Argument.Emit): Check that Expr is
15102 IMemoryLocation before casting to it, and report CS1510 otherwise.
15106 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15108 * statement.cs (Block.ThisVariable): remove the recursion here, to
15109 make the --profile more sane.
15111 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15113 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15114 assembly, by JB Evain.
15116 2004-12-17 Raja R Harinath <rharinath@novell.com>
15118 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15119 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15120 "parent" refers to enclosing type/class. "base" refers to superclass.
15122 2004-12-17 Raja R Harinath <rharinath@novell.com>
15124 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15125 Ensure that we only have GlobalAttributes.
15126 * attribute.cs (Attribute.Emit): Make non-virtual.
15127 (GlobalAttribute.Emit): Remove.
15128 (Attribute.Resolve): Make virtual.
15129 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15130 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15131 the argument. Don't create one.
15132 (Attribute.GetObsoleteAttribute): Likewise.
15133 (Attribute.GetClsCompliantAttributeValue): Likewise.
15134 * class.cs, decl.cs: Update to changes.
15136 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15138 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15140 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15142 * statement.cs (Foreach.Resolve): Add error 186 report.
15144 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15146 * expression.cs (Conditional.DoResolve): Add warning 429.
15148 * statement.cs (If.Resolve): Add warning 665.
15150 2004-12-16 Raja R Harinath <rharinath@novell.com>
15152 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15153 except when in the parser, and in GlobalAttribute.
15154 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15155 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15156 RootContext.Tree.Types.NamespaceEntry once work is done.
15157 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15158 and resets RootContext.Tree.Types.NamespaceEntry.
15160 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15162 * cs-parser.jay: Don't create a block for every variable.
15164 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15166 * location.cs: Provide extra information.
15168 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15169 variables from the captured environment, it is the ldarg_0.
15171 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15173 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15176 * class.cs: Changed warning level for 169 to avoid developer
15177 displeasure from warning flooding. It will be changed back when they
15178 fix most of current BCL warnings.
15180 * RootContext.cs: Pushed default WarningLevel to 3.
15182 * statement.cs: Removed unused variable.
15184 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15186 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15187 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15188 Add error 502 report.
15189 (StaticClass.DefineType): Add error 441 report.
15190 (Class.AllowedModifiersProp): New virtual property as temporary
15191 extension to AllowedModifiers.
15192 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15193 to share implementation with StaticClass and don't call virtual
15196 * driver.cs (MainDriver): Add error 1558 test.
15198 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15199 report. Moved error 36 test here.
15201 * statement.cs (Throw.Resolve): Add error 724 report.
15203 * typemanager.cs: Add out_attribute_type core type.
15205 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15207 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15209 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15211 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15214 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15216 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15217 Add error 3023 report.
15218 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15220 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15223 2004-12-12 John Luke <john.luke@gmail.com>
15225 * driver.cs (AddArgs): take -- into account when
15226 adding arguments, fixes bug 65710
15228 2004-12-12 Martin Baulig <martin@ximian.com>
15230 * expression.cs (Unary.TryReduceNegative): Added support for
15231 SByteConstant and ByteConstant.
15232 (Unary.Reduce): Check error values from TryReduceNegative().
15234 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15236 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15237 and report exception as error 182.
15239 2004-12-10 Raja R Harinath <rharinath@novell.com>
15241 * driver.cs (Main): Fix message when there are warnings.
15243 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15245 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15247 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15249 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15250 Reduced number of warnings.
15252 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15254 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15256 * driver.cs: Removed message.
15258 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15260 2004-12-08 <vargaz@freemail.hu>
15262 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15264 2004-12-08 Martin Baulig <martin@ximian.com>
15266 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15267 instead of a CS3002 for properties and indexer.
15269 2004-12-08 Martin Baulig <martin@ximian.com>
15271 * decl.cs (MemberName.ToString): Make this work again.
15273 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15275 * attribute.cs (Resolve): Add error 591 detection.
15277 * class.cs (FieldMember.Define): Add error 1547 detection.
15278 (Indexer.Define): Add error 620 detection.
15279 (Operator.Define): Add error 590 detection.
15281 * ecore.cs: Missing argument for error 79.
15283 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15286 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15289 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15292 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15294 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15295 Some operator comments were suppressed.
15296 * doc.cs : Implicit/explicit operator name in doc comments are like
15297 "op_Explicit(type)~returnType", so added suffix handling.
15299 2004-12-07 Martin Baulig <martin@ximian.com>
15302 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15303 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15304 (DeclSpace.ec): New protected field; store the EmitContext here.
15305 (DeclSpace.EmitContext): New public property; moved here from
15307 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15310 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15311 (Enum.Emit): Don't create a new EmitContext.
15313 * delegate.cs (Delegate.DefineType): Always create the
15316 * iterators.cs (Iterators.DefineIterator): Create a new
15317 EmitContext and store it in `ec'.
15319 2004-08-24 Martin Baulig <martin@ximian.com>
15322 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15323 this for accessibility checks.
15324 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15325 IsNestedFamilyAccessible.
15326 (TypeManager.IsSubclassOf): New method, do what the name actually
15329 2004-12-06 Raja R Harinath <rharinath@novell.com>
15331 Fix crash on cs0657-17.cs.
15332 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15333 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15334 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15335 the case where the NamespaceEntry gets overwritten.
15337 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15339 Fixed #69195, #56821
15340 * ecore.cs (ResolveBoolean): Tiny refactoring.
15342 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15343 of right expression resolving when left is false constant and
15344 operator is LogicalAnd OR true constant and operator is LogicalOr.
15346 * statement.cs (ResolveUnreachable): Always reports warning.
15348 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15350 * class.cs: Distinguish between 1721 and 1722 (just a little help
15351 for the programmer).
15353 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15355 * delegate.cs: Only allow this on new versions of the language.
15357 2004-12-02 Duncan Mak <duncan@ximian.com>
15359 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15361 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15362 here as a static method. Take an additional bool out parameter
15363 `must_do_cs1540_check' for signaling to InstanceResolve.
15364 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15365 member field from PropertyExpr class and made it an argument of
15366 the method instead.
15367 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15368 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15369 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15370 and `remove_accessor' as well as InstanceResolve: report CS0122
15375 2004-12-03 Raja R Harinath <rharinath@novell.com>
15377 Fix test-327.cs, test-328.cs, and put in early infrastructure
15378 for eventually fixing #52697.
15379 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15380 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15381 from other methods.
15382 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15383 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15384 (VerifyUsing, error246): Update.
15385 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15386 'NamespaceEntry.LookupNamespaceOrType'.
15388 2004-12-03 Martin Baulig <martin@ximian.com>
15390 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15391 method as our child, call AnonymousMethod.Compatible() on it.
15393 2004-12-03 Raja R Harinath <rharinath@novell.com>
15395 Disable XML documentation support in 'basic' profile.
15396 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15397 Redirect XmlElement to System.Object.
15398 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15399 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15400 * mcs.exe.sources: Add doc-bootstrap.cs.
15401 * doc-bootstrap.cs: New file. Contains empty stub implementation
15404 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15406 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15407 comments are allowed.
15409 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15411 * delegate.cs: Add checks for subtypes in paramaters and return values
15412 in VerifyMethod () to add support for Covariance/Contravariance
15415 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15417 * report.cs: Remove extra closing parenthesis.
15419 * convert.cs (Error_CannotImplicitConversion): If the name of the
15420 types are the same, provide some extra information.
15422 * class.cs (FieldBase): Use an unused bit field from the field to
15423 encode the `has_offset' property from the FieldMember. This saves
15424 a couple of Ks on bootstrap compilation.
15426 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15427 method as our child, return the AnonymousMethod resolved
15430 * expression.cs (New.DoResolve): Allow return values from
15431 NewDelegate to also include AnonymousMethods.
15435 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15438 * attribute.cs (Resolve): Improved implementation of params
15439 attribute arguments.
15441 * support.cs (ParameterData): Add HasParams to be faster.
15443 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15445 all things are for /doc support:
15447 * doc.cs: new file that supports XML documentation generation.
15448 * mcs.exe.sources: added doc.cs.
15450 Handle /doc command line option.
15451 Report error 2006 instead of 5 for missing file name for /doc.
15452 Generate XML documentation when required, after type resolution.
15454 Added support for picking up documentation (/// and /** ... */),
15455 including a new XmlCommentState enumeration.
15457 Added lines to fill Documentation element for field, constant,
15458 property, indexer, method, constructor, destructor, operator, event
15459 and class, struct, interface, delegate, enum.
15460 Added lines to warn incorrect comment.
15462 Added Documentation field (passed only when /doc was specified).
15464 Added DocComment, DocCommentHeader, GenerateDocComment() and
15465 OnGenerateDocComment() and some supporting private members for
15466 /doc feature to MemberCore.
15468 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15470 Added overriden DocCommentHeader.
15472 Added overriden DocCommentHeader and GenerateDocComment().
15474 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15476 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15477 unwrapping the enumeration values, chain to
15478 DoConstantNumericPromotions again, so we can promote things to the
15479 fundamental types (takes care of enums that are bytes, sbytes).
15483 2004-12-01 Raja R Harinath <rharinath@novell.com>
15485 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15486 Fix long-standing bug in type-lookup. Use FindType instead of
15487 LookupType when ec.ResolvingTypeTree.
15488 (Attribute.ResolveType, Attribute.Resolve)
15489 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15491 (Attributes.Search): Remove internal version. Update.
15492 (Attributes.SearchMulti): Update.
15493 (Attributes.GetClsCompliantAttribute): Remove.
15494 (Attributes.GetIndexerNameAttribute): Remove.
15495 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15496 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15497 * class.cs (Indexer.Define): Likewise.
15499 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15502 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15503 MarshallByReference members access.
15505 * expression.cs: Use CheckMarshallByRefAccess;
15506 Better error CS0197 message.
15508 * report.cs: Print whole related error message.
15510 2004-11-30 Raja R Harinath <rharinath@novell.com>
15512 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15513 the current directory to help debugging.
15515 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15517 * class (GetClassBases): Better error 60 report.
15518 (EventProperty): Disabled warning 67 detection.
15520 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15523 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15525 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15528 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15531 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15533 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15535 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15537 * attribute.cs (Attribute.Resolve): Refine error reporting and
15538 report a cs0117 if the identifier does not exist, to distinguish
15539 from 0617 which is a miss-use of the actual identifier.
15541 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15542 between cs0070 and cs0079.
15544 * class.cs (MemberBase.DoDefine): When reporting a wrong
15545 accessibility level, we use MethodCore to compare instead of
15546 Method (this was a regression in some refactoring effort).
15548 So now we correctly report cs0056 again.
15550 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
15551 testing the target_type (which was known to be object_type) and
15552 not the source type (which is anonymous_method).
15554 Fixed reporting of error cs1660.
15556 * expression.cs (UserCast.Source): Expose the underlying cast.
15558 * statement.cs (Switch.SwitchGoverningType): Sort the list of
15559 allowed types to find a match to int32 first (most common).
15561 In addition, it ignores any ImplicitUserConversions that did an
15562 internal implicit conversion (as the switch statement allows only
15563 one integral conversion to exist).
15565 * class.cs (PartialContainer.Create): rename `name' to
15566 `member_name' for clarity. Then replace the string calls with a
15567 call to MemberName.GetPartialName, as now using
15568 MemberName.ToString is an error (this is due to the side effects
15569 it had, that were fixed in the past).
15571 This will restore the error reporting on a number of partial class
15572 errors that were missusing this (and getting an exception as a
15573 results, which is now just a plain textual warning, because
15574 yyparse debug output would crash otherwise).
15576 2004-11-26 Raja R Harinath <rharinath@novell.com>
15578 * Makefile (PROGRAM_INSTALL_DIR): Remove.
15580 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15582 * rootcontext.cs (LookupType): Make sure to cache lookups that
15583 don't give us a negative result. This saves about 5% of corlib
15586 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15588 * report.cs (AbstractMessage.Print): messages are sent to stderr
15590 * class.cs (TypeContainer.GetClassBases): It is an error to have a
15591 non-interface in the list of interfaces (at this point, either
15592 parent was properly set, or a base class is being listed in the
15593 interfaces section).
15595 This flags error 1722, and resolves the crash from bug 69259.
15597 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15599 * statement.cs (Using.EmitExpressionFinally): make this work right
15600 for valuetypes. Fixes 69926.
15602 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15604 * const.cs (Const.ChangeType): Cope with the "0 literal can be
15605 converted to an enum" here, before we try to change the underlying
15606 type. This code exists, but it is a different code path than the
15607 one used while encoding constants.
15609 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
15610 old bug: when converting from the null literal to a pointer,
15611 return an EmptyCast, not the NullLiteral.
15613 This fixes #69921, the recent null_type changes probably made this
15614 bug more prominent.
15616 (ImplicitReferenceConversionExists): In addition, resynchronized
15617 the code here, so it matches the same code in
15618 ImplicitReferenceConversionExists for the `from any class-type S
15619 to any interface-type T'.
15622 2004-11-25 Marek Safar <marek.safar@seznam.cz>
15624 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
15626 2004-11-24 Miguel de Icaza <miguel@ximian.com>
15628 * cs-parser.jay: Use verbosity accordingly.
15630 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15632 * expression.cs (Unary.ResolveOperator): Do not report warning;
15633 AddressOf reads from variable.
15635 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
15637 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15641 * attribute.cs (Attributable): Removed CheckTargets.
15642 (Attributes.Emit): Explicit attribute targets are tested here.
15644 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
15645 not enabled for interfaces.
15647 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
15648 (GetAssemblyName): Ouch next bug there.
15650 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15652 * expression.cs: Error 275 added.
15654 2004-11-23 Marek Safar <marek.safar@seznam.cz>
15656 Fix bug #69177 (Implemented decimal constant support)
15658 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
15659 (BinaryFold): Add DecimalConstant.
15661 * const.cs (Define): Decimal constant
15663 (ChangeType): Add decimal type handling.
15664 (LookupConstantValue): Don't set value for decimal type but
15665 emit DecimalConstantAttribute. Needed for constant optimization.
15667 * constant.cs (ToDecimal): New method.
15668 (ConvertToDecimal): New method.
15669 (IntConstant): Implemented ConvertToDecimal.
15670 (DecimalConstant.Emit): Emit optimized version for decimals in
15673 * expression.cs (ResolveOperator): Changed order of constant
15674 reduction to work correctly with native types which have
15675 overloaded operators.
15676 (ResolveMemberAccess): Extract constant value from attribute
15679 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
15681 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
15682 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
15683 (ChangeType): Decimal is special.
15684 (TypeToCoreType): Add decimal type.
15686 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15688 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
15691 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15693 * class.cs (EventField.ApplyAttributeBuilder): Fix error
15696 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15698 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
15700 * pending.cs (PendingImplementation): Grab only interfaces.
15702 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15704 * statement.cs (ForeachHelperMethods): Add location member and
15705 error 202 detection.
15707 2004-11-19 Raja R Harinath <rharinath@novell.com>
15709 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
15710 automatically handled by executable.make.
15711 (PROGRAM): Make profile-specific.
15713 2004-11-18 Marek Safar <marek.safar@seznam.cz>
15715 * expression.cs (DoResolveBase): Fixed wrong warning for out
15718 2004-11-18 Martin Baulig <martin@ximian.com>
15720 Merged latest changes into gmcs. Please keep this comment in
15721 here, it makes it easier for me to see what changed in MCS since
15722 the last time I merged.
15724 2004-11-17 Raja R Harinath <rharinath@novell.com>
15726 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
15727 (TypeHandle.GetMemberCache): New.
15728 (TypeHandle.TypeHandle): Update.
15729 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
15730 (TypeManager.LookupParentInterfacesCache):
15731 Rename from LookupInterfaceCache. Optimize slightly.
15732 (TypeManager.MemberLookup_FindMembers): Update.
15733 * decl.cs (MemberCache.MemberCache): Set Container to null in the
15734 multi-type variant.
15735 (AddCacheContents): Rename from AddHashtable.
15736 * class.cs (TypeContainer.parent_container): Remove.
15737 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
15738 (TypeContainer.DoDefineMembers): Don't initialize it.
15739 Update to name changes.
15741 2004-11-17 Miguel de Icaza <miguel@ximian.com>
15743 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
15744 that factors the code to check access modifiers on override.
15746 (PropertyBase): Use the code here.
15748 Patch from Lluis S'anchez, fixes bug #69361.
15750 2004-11-15 Miguel de Icaza <miguel@ximian.com>
15752 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
15753 routine that is used to report the use of a captured variable
15754 whose address has been taken.
15756 There are two checks: one when variables are being captured and
15757 the other check is when the address of a variable is taken.
15759 (because an anonymous methods might be resolved before *or* after
15760 the address has been taken) and
15762 * expression.cs (Conditional.DoResolve): Remove the special
15763 casing that Martin added to trueExpr and falseExpr being both
15764 NullLiteral. We get the right behavior now just by introducing
15765 the null_type into the compiler.
15767 * convert.cs (ExplicitConversion): Change the code to use
15768 null_type instead of testing `expr is NullLiteral'.
15769 (ImplicitConversionStandard): use null_type too.
15770 (ImplicitReferenceConversionExists): use null_type too.
15771 (ImplicitReferenceConversion): use null_type too.
15773 * literal.cs: The type of `NullLiteral' is now null_type instead
15775 (Resolve): Set the type here.
15777 * typemanager.cs: Introduce null_type.
15779 2004-11-17 Martin Baulig <martin@ximian.com>
15781 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
15782 direction, like FindMembers() does. Fixes #69546, testcase is in
15785 2004-11-16 Martin Baulig <martin@ximian.com>
15787 This is based on a patch from Marek Safar, see bug #69082.
15788 Fixes bugs #63705 and #67130.
15790 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
15791 method; create a MemberCache for an interface type and cache the
15794 * decl.cs (IMemberContainer.ParentContainer): Removed.
15795 (IMemberContainer.ParentCache): New property.
15796 (MemberCache.SetupCacheForInterface): Removed.
15797 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
15798 to create a cache for an interface's "parent".
15800 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
15803 2004-11-16 Martin Baulig <martin@ximian.com>
15805 Merged back from gmcs; these changes already went into gmcs a
15806 couple of weeks ago.
15809 (TypeManager.AddUserType): Removed the `ifaces' argument.
15810 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
15812 (TypeManager.AddUserInterface): Removed.
15813 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
15815 (TypeManager.GetInterfaces): Likewise.
15816 (TypeManager.GetExplicitInterfaces): Likewise.
15818 * ecore.cs (TypeExpr.GetInterfaces): Removed.
15820 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
15821 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
15823 2004-11-14 Ben Maurer <bmaurer@ximian.com>
15825 * statement.cs: Avoid adding bools to a hashtable.
15827 2004-11-07 Miguel de Icaza <miguel@ximian.com>
15829 * expression.cs (Invocation.OverloadResolve): Flag error if we are
15830 calling an unsafe method from a safe location.
15832 2004-11-06 Marek Safar <marek.safar@seznam.cz>
15835 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
15837 2004-11-06 Miguel de Icaza <miguel@ximian.com>
15839 * namespace.cs (VerifyUsing): use GetPartialName instead of
15842 2004-11-05 Miguel de Icaza <miguel@ximian.com>
15844 * statement.cs (Return.Resolve): Fix regression in typo: if
15845 `in_exc', we have to request a NeedReturnLabel, this was a typo
15846 introduced in the anonymous method check-in. Fixes #69131.
15848 * Indexers were using the ShortName when defining themselves,
15849 causing a regression in the compiler bootstrap when applying the
15850 patch from 2004-11-02 (first part), now they use their full name
15851 and the bug is gone.
15853 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
15855 * driver.cs: Strip the path from the names of embedded resources. Fixes
15858 2004-11-04 Raja R Harinath <rharinath@novell.com>
15860 Fix error message regression: cs0104-2.cs.
15861 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
15862 (AliasEntry.Resolve): Update.
15863 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
15865 (RootContext.LookupType): Update.
15867 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
15869 * cs-parser.jay: Add support for handling accessor modifiers
15870 * class: Add support port accessor modifiers and error checking,
15871 define PropertyMethod.Define as virtual (not abstract anymore)
15872 * ecore.cs: Add checking for proeprties access with access modifiers
15873 * iterators.cs: Modify Accessor constructor call based in the modified
15875 2004-11-02 Ben Maurer <bmaurer@ximian.com>
15877 * expression.cs (StringConcat): Handle being called twice,
15878 as when we have a concat in a field init with more than two
15881 2004-11-02 Miguel de Icaza <miguel@ximian.com>
15883 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
15884 special case explicit implementations, we should always produce
15885 the .property or .event declaration.
15887 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
15888 since it will not return correct data if people use this
15889 unresolved in the presence of using statements (see test-313).
15891 * class.cs (MethodData.Define): If we are an explicit interface
15892 implementation, set the method name to the full name of the
15893 interface plus the name of the method.
15895 Notice that using the method.MethodName.GetFullName() does not
15896 work, as it will only contain the name as declared on the source
15897 file (it can be a shorthand in the presence of using statements)
15898 and not the fully qualifed type name, for example:
15902 class D : ICloneable {
15903 object ICloneable.Clone () {
15907 Would produce a method called `ICloneable.Clone' instead of
15908 `System.ICloneable.Clone'.
15910 * namespace.cs (Alias.Resolve): Use GetPartialName.
15912 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15914 * cs-parser.jay: Add error 1055 report.
15916 2004-11-01 Miguel de Icaza <miguel@ximian.com>
15918 * assign.cs (Assign.DoResolve): Only do the transform of
15919 assignment into a New if the types are compatible, if not, fall
15920 through and let the implicit code deal with the errors and with
15921 the necessary conversions.
15923 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15925 * cs-parser.jay: Add error 1031 report.
15927 * cs-tokenizer.cs: Add location for error 1038.
15929 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15931 * cs-parser.jay: Add error 1016 report.
15933 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15935 * cs-parser.jay: Add errors 1575,1611 report.
15937 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15939 * cs-parser.jay: Add error 1001 report.
15941 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15944 * attribute.cs (GetMarshal): Add method argument for
15945 caller identification.
15947 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
15948 agument for GetMarshal and RuntimeMissingSupport.
15950 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15952 * attribute.cs (ExtractSecurityPermissionSet): Removed
15953 TypeManager.code_access_permission_type.
15955 * typemanager.cs: Removed TypeManager.code_access_permission_type.
15957 2004-10-27 Miguel de Icaza <miguel@ximian.com>
15959 * expression.cs (LocalVariableReference.DoResolveLValue): Check
15960 for obsolete use of a variable here. Fixes regression on errors
15961 cs0619-25 and cs0619-26.
15963 2004-10-27 Marek Safar <marek.safar@seznam.cz>
15965 Fix #62358, implemented security attribute encoding.
15967 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
15968 Tests permitted SecurityAction for assembly or other types.
15969 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
15970 data from SecurityPermissionAttribute to PermisionSet class.
15972 * class.cs (ApplyAttributeBuilder): Added special handling
15973 for System.Security.Permissions.SecurityAttribute based types.
15975 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
15976 special handling for System.Security.Permissions.SecurityAttribute
15979 * enum.cs (ApplyAttributeBuilder): Added special handling
15980 for System.Security.Permissions.SecurityAttribute based types.
15982 * parameter.cs (ApplyAttributeBuilder): Added special handling
15983 for System.Security.Permissions.SecurityAttribute based types.
15985 * rootcontext.cs: Next 2 core types.
15987 * typemanager.cs (TypeManager.security_permission_attr_type):
15988 Built in type for the SecurityPermission Attribute.
15989 (code_access_permission_type): Build in type.
15991 2004-10-17 Miguel de Icaza <miguel@ximian.com>
15993 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
15994 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
15995 all of this information into
15996 EmitContext.EmitCapturedVariableInstance.
15998 * codegen.cs (EmitCapturedVariableInstance): move here the
15999 funcionality of emitting an ldarg.0 in the presence of a
16000 remapping. This centralizes the instance emit code.
16002 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16003 then emit a load of this: it means that we have reached the
16004 topmost ScopeInfo: the one that contains the pointer to the
16005 instance of the class hosting the anonymous method.
16007 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16008 captures to the topmost CaptureContext.
16010 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16012 * expression.cs (LocalVariableReference): Move the knowledge about
16013 the iterators into codegen's EmitCapturedVariableInstance.
16015 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16017 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16018 all code paths return a value from an anonymous method (it is the
16019 same as the 161 error, but for anonymous methods).
16021 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16023 The introduction of anonymous methods in the compiler changed
16024 various ways of doing things in the compiler. The most
16025 significant one is the hard split between the resolution phase
16026 and the emission phases of the compiler.
16028 For instance, routines that referenced local variables no
16029 longer can safely create temporary variables during the
16030 resolution phase: they must do so from the emission phase,
16031 since the variable might have been "captured", hence access to
16032 it can not be done with the local-variable operations from the runtime.
16036 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16037 is a toplevel block.
16039 (ToplevelBlock): A new kind of Block, these are the blocks that
16040 are created by the parser for all toplevel method bodies. These
16041 include methods, accessors and anonymous methods.
16043 These contain some extra information not found in regular blocks:
16044 A pointer to an optional CaptureContext (for tracking captured
16045 local variables and parameters). A pointer to the parent
16048 (Return.Resolve): Catch missmatches when returning a value from an
16049 anonymous method (error 1662).
16050 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16053 (Break.Resolve): ditto.
16055 (SwitchLabel): instead of defining the labels during the
16056 resolution phase, we now turned the public ILLabel and ILLabelCode
16057 labels into methods called GetILLabelCode() and GetILLabel() that
16058 only define the label during the Emit phase.
16060 (GotoCase): Track the SwitchLabel instead of the computed label
16061 (its contained therein). Emit the code by using
16062 SwitchLabel.GetILLabelCode ().
16064 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16065 whether the Local has been captured or not.
16067 (LocalInfo.IsCaptured): New property, used to tell whether the
16068 local has been captured.
16070 * anonymous.cs: Vastly updated to contain the anonymous method
16073 The main classes here are: CaptureContext which tracks any
16074 captured information for a toplevel block and ScopeInfo used to
16075 track the activation frames for various local variables.
16077 Each toplevel block has an optional capture context associated
16078 with it. When a method contains an anonymous method both the
16079 toplevel method and the anonymous method will create a capture
16080 context. When variables or parameters are captured, they are
16081 recorded on the CaptureContext that owns them, for example:
16085 MyDelegate d = delegate {
16090 Here `a' will be recorded as captured on the toplevel
16091 CapturedContext, the inner captured context will not have anything
16092 (it will only have data if local variables or parameters from it
16093 are captured in a nested anonymous method.
16095 The ScopeInfo is used to track the activation frames for local
16096 variables, for example:
16098 for (int i = 0; i < 10; i++)
16099 for (int j = 0; j < 10; j++){
16100 MyDelegate d = delegate {
16105 At runtime this captures a single captured variable `i', but it
16106 captures 10 different versions of the variable `j'. The variable
16107 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16108 recorded on a child.
16110 The toplevel ScopeInfo will also track information like the `this'
16111 pointer if instance variables were referenced (this is necessary
16112 as the anonymous method lives inside a nested class in the host
16113 type of the method).
16115 (AnonymousMethod): Expanded to track the Toplevel, implement
16116 `AnonymousMethod.Compatible' to tell whether an anonymous method
16117 can be converted to a target delegate type.
16119 The routine now also produces the anonymous method content
16121 (AnonymousDelegate): A helper class that derives from
16122 DelegateCreation, this is used to generate the code necessary to
16123 produce the delegate for the anonymous method that was created.
16125 * assign.cs: API adjustments for new changes in
16126 Convert.ImplicitStandardConversionExists.
16128 * class.cs: Adjustments to cope with the fact that now toplevel
16129 blocks are of type `ToplevelBlock'.
16131 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16132 insteda of standard blocks.
16134 Flag errors if params arguments are passed to anonymous methods.
16136 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16137 `CurrentAnonymousMethod' which points to the current Anonymous
16138 Method. The variable points to the AnonymousMethod class that
16139 holds the code being compiled. It is set in the new EmitContext
16140 created for the anonymous method.
16142 (EmitContext.Phase): Introduce a variable and an enumeration to
16143 assist in enforcing some rules about when and where we are allowed
16144 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16145 only one that enfonces this right now).
16147 (EmitContext.HaveCaptureInfo): new helper method that returns
16148 whether we have a CapturedContext initialized.
16150 (EmitContext.CaptureVariable): New method used to register that a
16151 LocalInfo must be flagged for capturing.
16153 (EmitContext.CapturedParameter): New method used to register that a
16154 parameters must be flagged for capturing.
16156 (EmitContext.CapturedField): New method used to register that a
16157 field must be flagged for capturing.
16159 (EmitContext.HaveCapturedVariables,
16160 EmitContext.HaveCapturedFields): Return whether there are captured
16161 variables or fields.
16163 (EmitContext.EmitMethodHostInstance): This is used to emit the
16164 instance for the anonymous method. The instance might be null
16165 (static methods), this (for anonymous methods that capture nothing
16166 and happen to live side-by-side with the current method body) or a
16167 more complicated expression if the method has a CaptureContext.
16169 (EmitContext.EmitTopBlock): Routine that drives the emission of
16170 code: it will first resolve the top block, then emit any metadata
16171 and then emit the code. The split is done so that we can extract
16172 any anonymous methods and flag any captured variables/parameters.
16174 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16175 during this phase, the ILGenerator should not be used as labels
16176 and local variables declared here might not be accessible to any
16177 code that is part of an anonymous method.
16179 Exceptions to this include the temporary variables that are
16180 created by some statements internally for holding temporary
16183 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16186 (EmitContext.TemporaryReturn): This method is typically called
16187 from the Emit phase, and its the only place where we allow the
16188 ReturnLabel to be defined other than the EmitMeta. The reason is
16189 that otherwise we would have to duplicate a lot of logic in the
16190 Resolve phases of various methods that today is on the Emit
16193 (EmitContext.NeedReturnLabel): This no longer creates the label,
16194 as the ILGenerator is not valid during the resolve phase.
16196 (EmitContext.EmitThis): Extended the knowledge in this class to
16197 work in anonymous methods in addition to iterators.
16199 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16200 code is necessary on the stack to access the instance to a local
16201 variable (the variable will be accessed as a field).
16203 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16204 EmitContext.EmitAddressOfParameter): Routines to support
16205 parameters (not completed at this point).
16207 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16208 will also remove the parameters.
16210 * convert.cs (Convert): Define a `ConstantEC' which points to a
16211 null. This is just to prefity some code that uses
16212 ImplicitStandardConversion code and do not have an EmitContext
16215 The idea is to flag explicitly that at that point in time, it is
16216 known that the conversion will not trigger the delegate checking
16217 code in implicit conversions (which requires a valid
16220 Everywhere: pass new EmitContext parameter since
16221 ImplicitStandardConversionExists now requires it to check for
16222 anonymous method conversions.
16224 (Convert.ImplicitStandardConversionExists): If the type of an
16225 expression is the anonymous_method_type, and the type is a
16226 delegate, we invoke the AnonymousMethod.Compatible method to check
16227 whether an implicit conversion is possible.
16229 (Convert.ImplicitConversionStandard): Only do implicit method
16230 group conversions if the language level is not ISO_1.
16232 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16233 MethodInfo for the Invoke method. used by Delegate and
16236 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16237 method conversions if the target type is a delegate.
16239 Removed extra debugging nops.
16241 (LocalVariableReference): Turn the `local_info' into a public
16244 Add `prepared' field, the same hack used for FieldExprs to cope
16245 with composed assignments, as Local variables do not necessarily
16246 operate purely on the stack as they used to: they can be captured
16249 Add `temp' for a temporary result, like fields.
16251 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16253 It now copes with Local variables that are captured and emits the
16254 proper instance variable to load it from a field in the captured
16257 (ParameterReference.DoResolveBase): During the resolve phase,
16258 capture parameters if we are in an anonymous method.
16260 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16261 anonymous method, use the EmitContext helper routines to emit the
16262 parameter reference.
16264 * iterators.cs: Set RemapToProxy to true/false during the
16267 * parameters.cs (GetParameterByName): New helper method.
16269 * typemanager.cs (anonymous_method_type) a new type that
16270 represents an anonyous method. This is always an internal type,
16271 used as a fencepost to test against the anonymous-methodness of an
16274 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16276 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16278 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16280 2004-10-18 Martin Baulig <martin@ximian.com>
16282 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16283 `Type' directly, but call ResolveType() on it.
16284 (Catch.Resolve): Likewise.
16285 (Foreach.Resolve): Likewise.
16287 2004-10-18 Martin Baulig <martin@ximian.com>
16289 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16290 `Type' directly, but call ResolveType() on it.
16291 (Probe.DoResolve): Likewise.
16292 (ArrayCreation.LookupType): Likewise.
16293 (TypeOf.DoResolve): Likewise.
16294 (SizeOf.DoResolve): Likewise.
16296 2004-10-18 Martin Baulig <martin@ximian.com>
16298 * expression.cs (Invocation.BetterFunction): Put back
16299 TypeManager.TypeToCoreType().
16301 2004-10-18 Raja R Harinath <rharinath@novell.com>
16303 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16306 2004-10-18 Martin Baulig <martin@ximian.com>
16308 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16309 `Type' directly, but call ResolveType() on it.
16311 2004-10-18 Martin Baulig <martin@ximian.com>
16313 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16314 `Type' directly, but call ResolveType() on it.
16315 (MemberBase.DoDefine): Likewise.
16317 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16318 `Type' directly, but call ResolveType() on it.
16319 (ComposedCast.DoResolveAsTypeStep): Likewise.
16321 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16322 `Type' directly, but call ResolveType() on it.
16324 2004-10-17 John Luke <john.luke@gmail.com>
16326 * class.cs (Operator.GetSignatureForError): use CSharpName
16328 * parameter.cs (Parameter.GetSignatureForError): Returns
16329 correct name even if was not defined.
16331 2004-10-13 Raja R Harinath <rharinath@novell.com>
16334 * class.cs (TypeContainer.EmitContext): New property.
16335 (DefineNestedTypes): Create an emitcontext for each part.
16336 (MethodCore.DoDefineParameters): Use container's emitcontext.
16337 Pass type array to InternalParameters.
16338 (MemberBase.DoDefine): Use container's emitcontext.
16339 (FieldMember.Define): Likewise.
16340 (Event.Define): Likewise.
16341 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16342 Pass type array to InternalParameters.
16343 (SetIndexerMethod.GetParameterInfo): Likewise.
16344 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16345 * delegate.cs (Define): Pass emitcontext to
16346 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16347 array to InternalParameters.
16348 * expression.cs (ParameterReference.DoResolveBase): Pass
16349 emitcontext to GetParameterInfo.
16350 (ComposedCast.DoResolveAsTypeStep): Remove check on
16351 ec.ResolvingTypeTree.
16352 * parameter.cs (Parameter.Resolve): Change argument to
16353 EmitContext. Use ResolveAsTypeTerminal.
16354 (Parameter.GetSignature): Change argument to EmitContext.
16355 (Parameters.ComputeSignature): Likewise.
16356 (Parameters.ComputeParameterTypes): Likewise.
16357 (Parameters.GetParameterInfo): Likewise.
16358 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16359 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16360 * support.cs (InternalParameters..ctor): Remove variant that takes
16362 * typemanager.cs (system_intptr_expr): New.
16363 (InitExpressionTypes): Initialize it.
16365 2004-10-12 Chris Toshok <toshok@ximian.com>
16367 * cs-parser.jay: fix location for try_statement and catch_clause.
16369 2004-10-11 Martin Baulig <martin@ximian.com>
16371 * report.cs: Don't make --fatal abort on warnings, we have
16372 -warnaserror for that.
16374 2004-10-07 Raja R Harinath <rharinath@novell.com>
16376 More DeclSpace.ResolveType avoidance.
16377 * decl.cs (MemberCore.InUnsafe): New property.
16378 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16379 with newly created EmitContext.
16380 (FieldMember.Define): Likewise.
16381 * delegate.cs (Delegate.Define): Likewise.
16382 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16383 only if normal name-lookup fails.
16384 (TypeExpr.DoResolve): Enable error-checking.
16385 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16386 (SizeOf.DoResolve): Likewise.
16387 (ComposedCast.DoResolveAsTypeStep): Likewise.
16388 (StackAlloc.DoResolve): Likewise.
16389 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16390 (Block.Unsafe): New property.
16391 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16392 (Unsafe): Set 'unsafe' flag of contained block.
16393 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16394 (Fixed.Resolve): Likewise.
16395 (Catch.Resolve): Likewise.
16396 (Using.ResolveLocalVariableDecls): Likewise.
16397 (Foreach.Resolve): Likewise.
16399 2004-10-05 John Luke <john.luke@gmail.com>
16401 * cs-parser.jay: add location to error CS0175
16403 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16405 * ecore.cs (Expression.Constantity): Add support for turning null
16408 * const.cs (Const.Define): Allow constants to be reference types
16409 as long as the value is Null.
16411 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16413 * namespace.cs (NamespaceEntry.Using): No matter which warning
16414 level is set, check if this namespace name has already been added.
16416 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16418 * expression.cs: reftype [!=]= null should always use br[true,false].
16421 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16424 * attribute.cs: Enum conversion moved to
16425 GetAttributeArgumentExpression to be applied to the all
16428 2004-10-01 Raja R Harinath <rharinath@novell.com>
16430 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16431 * class.c (TypeContainer.DefineType): Flag error if
16432 base types aren't accessible due to access permissions.
16433 * decl.cs (DeclSpace.ResolveType): Move logic to
16434 Expression.ResolveAsTypeTerminal.
16435 (DeclSpace.ResolveTypeExpr): Thin layer over
16436 Expression.ResolveAsTypeTerminal.
16437 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16438 Refactor code into NestedAccess. Use it.
16439 (DeclSpace.NestedAccess): New.
16440 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16441 argument to silence errors. Check access permissions.
16442 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16443 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16444 (Cast.DoResolve): Likewise.
16445 (New.DoResolve): Likewise.
16446 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16447 (TypeOf.DoResolve): Likewise.
16449 * expression.cs (Invocation.BetterConversion): Return the Type of
16450 the better conversion. Implement section 14.4.2.3 more faithfully.
16451 (Invocation.BetterFunction): Make boolean. Make correspondence to
16452 section 14.4.2.2 explicit.
16453 (Invocation.OverloadResolve): Update.
16454 (Invocation): Remove is_base field.
16455 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16456 (Invocation.Emit): Likewise.
16458 2004-09-27 Raja R Harinath <rharinath@novell.com>
16460 * README: Update to changes.
16462 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16464 * cs-parser.jay: Reverted 642 warning fix.
16466 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16469 * decl.cs (FindMemberWithSameName): Indexer can have more than
16472 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16474 * expression.cs (LocalVariableReference.DoResolveLValue):
16475 Do not report warning 219 for out values.
16476 (EmptyExpression.Null): New member to avoid extra allocations.
16478 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16480 * cs-parser.jay: Fix wrong warning 642 report.
16482 * cs-tokenizer.cs (CheckNextToken): New helper;
16483 Inspect next character if is same as expected.
16485 2004-09-23 Martin Baulig <martin@ximian.com>
16487 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16488 (Convert.ImplicitReferenceConversionExists): Likewise.
16490 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16492 * class.cs (Operator.Define): Add error 448 and 559 report.
16494 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16496 * class.cs (MemberBase.IsTypePermitted): New protected
16497 method for checking error CS0610.
16499 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16501 * class.cs (TypeContainer.HasExplicitLayout): New property
16502 Returns whether container has StructLayout attribute set Explicit.
16503 (FieldMember): New abstract class for consts and fields.
16504 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16505 (Field): Reuse FieldMember.
16507 * const.cs (Const): Reuse FieldMember.
16509 * rootcontext.cs: EmitConstants call moved to class.
16511 2004-09-22 Martin Baulig <martin@ximian.com>
16513 Thanks to Peter Sestoft for this bug report.
16515 * expression.cs (Conditional): If both the `trueExpr' and the
16516 `falseExpr' is a NullLiteral, return a NullLiteral.
16518 2004-09-22 Martin Baulig <martin@ximian.com>
16520 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16521 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16522 for the "get_Current" call.
16524 2004-09-22 Martin Baulig <martin@ximian.com>
16526 Marek and me just fixed one of our oldest bugs: #28562 :-)
16528 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16530 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16531 we're an EnumConstant, just return that.
16532 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16533 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16534 to get the value which'll actually be written into the attribute.
16535 However, we have to use GetValue() to access the attribute's value
16538 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16540 * constant.cs (Constant.IsNegative): New abstract property
16543 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16544 (StackAlloc.DoResolve): Reused IsNegative.
16546 2004-09-21 Martin Baulig <martin@ximian.com>
16548 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
16549 if we're used in an iterator, we may be called from different
16552 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
16553 we actually have an exception block.
16555 2004-09-20 John Luke <jluke@cfl.rr.com>
16557 * class.cs, cs-parser.jay: Improve the error report for 1520:
16558 report the actual line where the error happens, not where the
16559 class was declared.
16561 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
16562 Pass location information that was available elsewhere.
16564 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
16566 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
16567 runtime to delay sign assemblies.
16569 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16571 * cs-parser.jay: Do not report the stack trace, this is barely
16574 2004-08-22 John Luke <john.luke@gmail.com>
16576 * driver.cs : check that a resource id is not already used
16577 before adding it, report CS1508 if it is, bug #63637
16579 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16581 * ecore.cs: Removed dead code.
16583 2004-09-18 Marek Safar <marek.safar@seznam.cz>
16585 * class.cs: Do not report warning CS0067 on the interfaces.
16587 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16589 * cs-parser.jay: Add error 504 report.
16591 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16593 * rootcontext.cs: WarningLevel is 4 by default now.
16595 * statement.cs (Fixed.Resolve): Do not null
16598 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16601 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
16602 deep search when property is not virtual.
16603 (PropertyExpr.ResolveAccessors): Make one call for both
16606 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16609 * statement.cs: Error 152 report constains also location.
16611 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16614 * const.cs: Explicitly set constant as static.
16616 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16619 * cs-parser.jay: Add error 1017 report.
16621 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16623 Fixed bug #59980, #64224
16624 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
16626 * typemanager.cs (IsSpecialMethod): Simplified
16628 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16630 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
16631 condition with better params.
16633 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16636 * attribute.cs (Resolve): Property has to have both
16639 2004-09-14 Martin Baulig <martin@ximian.com>
16641 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
16643 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16646 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
16647 called and is obsolete then this member suppress message
16648 when call is inside next [Obsolete] method or type.
16650 * expression.cs: Use TestObsoleteMethodUsage member.
16652 2004-09-14 Martin Baulig <martin@ximian.com>
16654 * cs-parser.jay: Sync a bit with the GMCS version.
16656 2004-09-14 Martin Baulig <martin@ximian.com>
16658 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
16659 (CSharpParser.yacc_verbose_flag): New public field.
16661 * genericparser.cs: Removed.
16663 2004-09-14 Raja R Harinath <rharinath@novell.com>
16665 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
16667 2004-09-13 Marek Safar <marek.safar@seznam.cz>
16669 * class.cs (MethodCore.CheckBase): Fix bug #65757.
16671 2004-09-10 Martin Baulig <martin@ximian.com>
16673 Backported my MemberName changes from GMCS into MCS.
16675 - we are now using a special `MemberName' class instead of using
16676 strings; in GMCS, the `MemberName' also contains the type
16679 - changed the grammar rules a bit:
16680 * the old `member_name' is now a `namespace_or_type_name':
16681 The rule is that we use `namespace_or_type_name' everywhere
16682 where we expect either a "member name" (GetEnumerator) or a
16683 "member name" with an explicit interface name
16684 (IEnumerable.GetEnumerator).
16685 In GMCS, the explicit interface name may include type arguments
16686 (IEnumerable<T>.GetEnumerator).
16687 * we use `member_name' instead of just `IDENTIFIER' for
16689 The rule is that we use `member_name' wherever a member may
16690 have type parameters in GMCS.
16692 * decl.cs (MemberName): New public class.
16693 (MemberCore.MemberName): New public readonly field.
16694 (MemberCore.ctor): Take a `MemberName' argument, not a string.
16695 (DeclSpace): Likewise.
16697 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
16698 * enum.cs (Enum.ctor): Likewise.
16700 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
16702 (AliasEntry.ctor): Take a MemberName, not an Expression.
16703 (AliasEntry.UsingAlias): Likewise.
16705 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
16706 (IMethodData.MemberName): Changed type from string to MemberName.
16707 (MemberBase.ExplicitInterfaceName): Likewise.
16708 (AbstractPropertyEventMethod.SetupName): Make this private.
16709 (AbstractPropertyEventMethod.ctor): Added `string prefix'
16710 argument; compute the member name here.
16711 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
16712 on the `member.MemberName' and the `prefix'.
16714 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
16716 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
16717 thus, we get a `MemberName' instead of a `string'. These
16718 declarations may have type parameters in GMCS.
16719 (interface_method_declaration, delegate_declaration): Likewise.
16720 (class_declaration, interface_declaration): Likewise.
16721 (method_header): Use `namespace_or_type_name' instead of
16722 `member_name'. We may be an explicit interface implementation.
16723 (property_declaration, event_declaration): Likewise.
16724 (member_name): This is now just an `IDENTIFIER', not a
16725 `namespace_or_type_name'.
16726 (type_name, interface_type): Removed.
16727 (namespace_or_type_name): Return a MemberName, not an Expression.
16728 (primary_expression): Use `member_name' instead of `IDENTIFIER';
16729 call GetTypeExpression() on the MemberName to get an expression.
16730 (IndexerDeclaration.interface_type): Changed type from string to
16732 (MakeName): Operate on MemberName's instead of string's.
16734 2004-09-13 Raja R Harinath <rharinath@novell.com>
16737 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
16738 (NamespaceEntry.Lookup): Add new argument to flag if we want the
16739 lookup to avoid symbols introduced by 'using'.
16740 * rootcontext.cs (NamespaceLookup): Update.
16742 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16744 * class.cs (TypeContainer.DoDefineMembers): Do not call
16745 DefineDefaultConstructor for static classes.
16747 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16749 * attribute.cs (Attribute.Resolve): Add error 653 report.
16751 * class.cs (Class.ApplyAttributeBuilder): Add error 641
16753 (Method.ApplyAttributeBuilder): Add error 685 report.
16754 (Operator.Define): Add error 564 report.
16756 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
16758 * expression.cs (Invocation.DoResolve): Add error
16759 245 and 250 report.
16761 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
16764 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16766 * class.cs (ConstructorInitializer.Resolve):
16767 Wrong error number (515->516).
16769 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16771 * class.cs (Indexer.Define): Add error 631 report.
16773 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16775 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
16777 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16779 * expression.cs (Probe.DoResolve): Add error CS0241 report.
16781 2004-09-10 Marek Safar <marek.safar@seznam.cz>
16783 * cs-parser.jay: Added error CS0241 report.
16785 2004-09-10 Raja R Harinath <rharinath@novell.com>
16787 * cs-parser.jay (fixed_statement): Introduce a scope for the
16788 declaration in the 'fixed' statement.
16790 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16792 * cs-parser.jay: Added CS0230 error report.
16794 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16796 * cs-parser.jay: Added errors CS0231 and CS0257 report.
16798 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16800 * expression.cs (Argument.Resolve): Added error CS0192 and
16803 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16805 C# 2.0 #pragma warning feature
16807 * cs-tokenizer.cs (PreProcessPragma): New method;
16808 Handles #pragma directive.
16810 * report.cs (WarningRegions): New class; Support
16811 class for #pragma warning directive. It tests whether
16812 warning is enabled for a given line.
16814 2004-09-08 Miguel de Icaza <miguel@ximian.com>
16816 * const.cs: Add more descriptive error report, tahnks to
16819 2004-09-08 Marek Safar <marek.safar@seznam.cz>
16821 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
16823 2004-09-07 Miguel de Icaza <miguel@ximian.com>
16825 * expression.cs: Apply patch from Ben: Remove dead code from
16826 ArrayCreation, and remove the TurnintoConstant call in const.cs,
16827 as that code just threw an exception anwyays.
16829 * const.cs: Remove the call to the turnintoconstant, for details
16832 * literal.cs: The type of the null-literal is the null type; So
16833 we use a placeholder type (literal.cs:System.Null, defined here)
16836 * expression.cs (Conditional.DoResolve): Remove some old code that
16837 is no longer needed, conversions have been fixed.
16839 (ArrayCreationExpression.DoResolve): Return false if we fail to
16840 resolve the inner expression.
16842 2004-09-07 Raja R Harinath <rharinath@novell.com>
16845 * cs-parser.jay (delegate_declaration): Record a delegate
16846 declaration as a type declaration.
16847 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
16849 2004-09-06 Miguel de Icaza <miguel@ximian.com>
16851 * parameter.cs: Do not crash if the type can not be resolved.
16853 * expression.cs: Report errors with unsafe pointers, fixes #64896
16855 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
16857 * expression.cs: Pointer arith always needs to do a conv.i
16858 if the operand is a long. fix 65320
16860 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16862 Fixed cs0619-37.cs, cs0619-38.cs
16864 * enum.cs (GetObsoleteAttribute): Removed.
16866 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
16867 on Enum member is double staged. The first is tested member
16870 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16872 Fixed #56986, #63631, #65231
16874 * class.cs: (TypeContainer.AddToMemberContainer): New method,
16875 adds member to name container.
16876 (TypeContainer.AddToTypeContainer): New method, adds type to
16878 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
16879 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
16880 AddOperator): Simplified by reusing AddToMemberContainer.
16881 (TypeContainer.UserDefinedStaticConstructor): Changed to property
16883 (Method.CheckForDuplications): Fixed implementation to test all
16885 (MemberBase): Detection whether member is explicit interface
16886 implementation is now in constructor.
16887 (MemberBase.UpdateMemberName): Handles IndexerName.
16888 (Accessor): Changed to keep also location information.
16889 (AbstractPropertyEventMethod): Is derived from MemberCore.
16890 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
16891 will be emited or not.
16892 (PropertyBase.AreAccessorsDuplicateImplementation):
16893 Tests whether accessors are not in collision with some method.
16894 (Operator): Is derived from MethodCore to simplify common
16897 * decl.cs (Flags.TestMethodDuplication): Test for duplication
16899 (DeclSpace.AddToContainer): Adds the member to defined_names
16900 table. It tests for duplications and enclosing name conflicts.
16902 * enum.cs (EnumMember): Clean up to reuse the base structures
16904 2004-09-03 Martin Baulig <martin@ximian.com>
16906 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
16907 into TypeContainer, to make partial classes work again.
16909 2004-09-03 Martin Baulig <martin@ximian.com>
16911 * rootcontext.cs (RootContext.V2): Removed.
16913 2004-03-23 Martin Baulig <martin@ximian.com>
16915 * expression.cs (Invocation.OverloadResolve): Added `bool
16916 may_fail' argument and use it instead of the Location.IsNull() hack.
16918 2004-09-03 Martin Baulig <martin@ximian.com>
16920 Merged latest changes into gmcs. Please keep this comment in
16921 here, it makes it easier for me to see what changed in MCS since
16922 the last time I merged.
16924 2004-09-03 Raja R Harinath <rharinath@novell.com>
16927 * expression.cs (BetterConversion): Don't allow either conversion
16928 to be null. Remove redundant implicit conversion test when 'q ==
16929 null' -- when this function is invoked, we already know that the
16930 implicit conversion exists.
16931 (BetterFunction): Assume that 'best' is non-null. Remove
16932 redundant reimplementation of IsApplicable when 'best' is null.
16933 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
16934 number of arguments.
16935 (IsAncestralType): Extract from OverloadResolve.
16936 (OverloadResolve): Make robust to the MethodGroupExpr being
16937 unsorted. Implement all the logic of Section 14.5.5.1, and
16938 support overloading of methods from multiple applicable types.
16939 Clean up logic somewhat. Don't pass null methods to BetterFunction.
16941 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
16942 (RealError, Warning): Append type of report to related symbol.
16944 2004-09-03 Marek Safar <marek.safar@seznam.cz>
16946 * enum.cs: Fixed CLS-Compliance checks for enum members.
16947 Error tests cs3008-8.cs, cs3014-8.cs
16949 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16951 Fixed bug #62342, #63102
16952 * class.cs: ImplementIndexer uses member.IsExplicitImpl
16953 like ImplementMethod.
16955 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16957 * attribute.cs (Attribute.GetAttributeArgumentExpression):
16960 2004-09-02 Martin Baulig <martin@ximian.com>
16962 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
16963 TypeManager.GetArgumentTypes() rather than calling GetParameters()
16966 2004-09-01 Marek Safar <marek.safar@seznam.cz>
16968 C# 2.0 Static classes implemented
16970 * class.cs (TypeContainer): instance_constructors,
16971 initialized_fields, initialized_static_fields,
16972 default_constructor, base_inteface_types are protected to be
16973 accessible from StaticClass.
16974 (TypeContainer.DefineDefaultConstructor): New virtual method
16975 for custom default constructor generating
16976 (StaticClass): New class to handle "Static classes" feature.
16978 * cs-parser.jay: Handle static keyword on class like instance
16981 * driver.cs: Added "/langversion" command line switch with two
16982 options (iso-1, default).
16984 2004-08-31 Marek Safar <marek.safar@seznam.cz>
16986 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
16988 2004-08-31 Miguel de Icaza <miguel@ximian.com>
16990 * delegate.cs: Style.
16992 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
16994 * delegate.cs: Add seperate instance expr field for miguel.
16996 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
16998 * PointerArithmetic (Resolve): make sure we are not doing
16999 pointer arith on void*. Also, make sure we are resolved
17000 by not setting eclass until resolve.
17002 All callers: Make sure that PointerArithmetic gets resolved.
17004 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17006 * ArrayCreation (LookupType): If the type does not resolve
17007 to an array, give an error.
17009 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17011 * statement.cs (Try.Resolve): Fixed bug #64222
17013 2004-08-27 Martin Baulig <martin@ximian.com>
17016 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17019 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17021 * ecore.cs (Constantify): Get underlying type via
17022 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17023 Windows in special cases.
17025 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17027 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17028 for obtaining also private methods.
17029 (GetRemoveMethod): Used GetRemoveMethod (true)
17030 for obtaining also private methods.
17032 2004-08-24 Martin Baulig <martin@ximian.com>
17034 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17035 MethodAttributes.HideBySig for operators.
17037 2004-08-23 Martin Baulig <martin@ximian.com>
17039 Back to the old error reporting system :-)
17041 * report.cs (Message): Removed.
17042 (Report.MessageData, ErrorData, WarningData): Removed.
17043 (Report.Error, Warning): Back to the old system.
17045 2004-08-23 Martin Baulig <martin@ximian.com>
17047 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17049 * class.cs (TypeContainer.ParentContainer): New public virtual
17050 method; replaces the explicit interface implementation.
17051 (ClassPart.ParentContainer): Override.
17053 2004-08-23 Martin Baulig <martin@ximian.com>
17055 * statement.cs (Switch): Added support for constant switches; see
17056 #59428 or test-285.cs.
17058 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17061 * statement.cs (GetEnumeratorFilter): Removed useless
17062 logic because C# specs is strict. GetEnumerator must be
17065 2004-08-22 Martin Baulig <martin@ximian.com>
17067 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17068 a switch and may break, reset the barrier. Fixes #59867.
17070 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17072 CLS-Compliance speed up (~5% for corlib)
17074 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17075 New method. Tests container for CLS-Compliant names
17077 * class.cs (TypeContainer.VerifyClsName): New method.
17078 Checks whether container name is CLS Compliant.
17079 (Constructor): Implements IMethodData.
17081 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17082 low-case table for CLS Compliance test.
17083 (MemberCache.VerifyClsParameterConflict): New method.
17084 Checks method parameters for CS3006 error.
17086 * enum.cs (EnumMember): Is derived from MemberCore.
17087 (Enum.VerifyClsName): Optimized for better performance.
17089 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17091 * report.cs: Renamed Error_T to Error and changed all
17094 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17096 * class.cs (TypeContainer.IndexerArrayList): New inner class
17097 container for indexers.
17098 (TypeContainer.DefaultIndexerName): New constant for default
17099 indexer name. Replaced all "Item" with this constant.
17100 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17102 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17103 DefaultMemberAttribute constructor.
17105 2004-08-05 Martin Baulig <martin@ximian.com>
17107 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17110 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17112 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17113 multi platforms problem.
17115 * compiler.csproj: Included shared files.
17117 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17119 Fix bug 60333, 55971 in the more general way
17120 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17121 Added arg_type argument for constant conversion.
17122 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17124 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17127 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17128 OperatorArrayList, MethodCoreArrayList for typecontainer
17129 containers. Changed class member types to these new types.
17130 (MethodArrayList.DefineMembers): Added test for CS0659.
17132 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17134 * cfold.cs: Synchronize the folding with the code in expression.cs
17135 Binary.DoNumericPromotions for uint operands.
17137 * attribute.cs: Revert patch from Raja, it introduced a regression
17138 while building Blam-1.2.1 (hard to isolate a test case).
17140 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17144 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17146 (MethodCore.parent_method): New member. The method we're overriding
17147 if this is an override method.
17148 (MethodCore.CheckBase): Moved from Method class and made common.
17149 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17151 (MethodCore.CheckForDuplications): New abstract method. For custom
17152 member duplication search in a container
17153 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17154 method and its return type.
17155 (Event.conflict_symbol): New member. Symbol with same name in the
17159 (MemberCache.FindMemberWithSameName): New method. The method
17160 is looking for conflict with inherited symbols.
17162 2004-08-04 Martin Baulig <martin@ximian.com>
17164 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17166 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17168 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17170 * report.cs (Message): New enum for better error, warning reference in
17172 (MessageData): New inner abstract class. It generally handles printing of
17173 error and warning messages.
17174 Removed unused Error, Warning, Message methods.
17176 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17178 Fix for cs0592-8.cs test
17180 (Attributable.ValidAttributeTargets): Made public.
17181 (Attribute.ExplicitTarget): New member for explicit target value.
17182 (Attribute.CheckTargets): Now we translate explicit attribute
17183 target to Target here.
17185 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17187 * ecore.cs (MethodGroupExpr): new IsBase property.
17189 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17191 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17192 rather than an instance expr.
17194 (DelegateCreation.Emit): Use the method group rather than
17195 the instance expression. Also, if you have base.Foo as the
17196 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17198 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17200 (NewDelegate.DoResolve): Only check for the existance of Invoke
17201 if the method is going to be needed. Use MethodGroupExpr.
17203 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17205 * expression.cs: For pointer arith., make sure to use
17206 the size of the type, not the size of the pointer to
17209 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17212 * class.cs (Class): Added error CS0502 test.
17214 2004-08-03 John Luke <jluke@cfl.rr.com>
17215 Raja R Harinath <rharinath@novell.com>
17218 * attribute.cs (Attribute.complained_before): New flag.
17219 (Attribute.ResolveType, Attribute.Resolve),
17220 (Attribute.DefinePInvokeMethod): Set it.
17221 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17223 2004-08-03 Martin Baulig <martin@ximian.com>
17225 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17226 use a user-defined operator; we still need to do numeric
17227 promotions in case one argument is a builtin type and the other
17228 one has an implicit conversion to that type. Fixes #62322.
17230 2004-08-02 Martin Baulig <martin@ximian.com>
17232 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17233 (LocalInfo.IsThis): New public property.
17234 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17236 2004-08-01 Martin Baulig <martin@ximian.com>
17238 * class.cs (TypeContainer.GetClassBases): Don't set the default
17239 here since we may get called from GetPartialBases().
17240 (TypeContainer.DefineType): If GetClassBases() didn't return a
17241 parent, use the default one.
17243 2004-07-30 Duncan Mak <duncan@ximian.com>
17245 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17247 2004-07-30 Martin Baulig <martin@ximian.com>
17249 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17251 * class.cs (SourceMethod): New public class, derive from the
17252 symbol writer's ISourceMethod.
17253 (Method): Use the new symbol writer API.
17255 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17256 as argument and use the new symbol writer.
17259 (SourceFile): Implement the symbol writer's ISourceFile.
17260 (Location.SymbolDocument): Removed.
17261 (Location.SourceFile): New public property.
17263 * symbolwriter.cs: Use the new symbol writer API.
17265 2004-07-30 Raja R Harinath <rharinath@novell.com>
17267 * Makefile (install-local): Remove. Functionality moved to
17270 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17272 * Makefile: Install mcs.exe.config file together with mcs.exe.
17273 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17274 correct runtime version.
17276 2004-07-25 Martin Baulig <martin@ximian.com>
17279 (TypeContainer.RegisterOrder): Removed, this was unused.
17280 (TypeContainer, interface_order): Removed.
17281 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17282 TypeContainer as argument since we can also be called with a
17283 `PartialContainer' for a partial class/struct/interface.
17284 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17285 of checking whether we're an `Interface' - we could be a
17286 `PartialContainer'.
17287 (PartialContainer.Register): Override; call
17288 AddClass()/AddStruct()/AddInterface() on our parent.
17290 * cs-parser.jay (interface_member_declaration): Add things to the
17291 `current_container', not the `current_class'.
17293 * rootcontext.cs (RegisterOrder): The overloaded version which
17294 takes an `Interface' was unused, removed.
17296 * typemanager.cs (TypeManager.LookupInterface): Return a
17297 `TypeContainer', not an `Interface'.
17298 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17299 contain a `PartialContainer' for an interface, so check it's
17300 `Kind' to figure out what it is.
17302 2004-07-25 Martin Baulig <martin@ximian.com>
17304 * class.cs (Class.DefaultTypeAttributes): New public constant.
17305 (Struct.DefaultTypeAttributes): Likewise.
17306 (Interface.DefaultTypeAttributes): Likewise.
17307 (PartialContainer.TypeAttr): Override this and add the
17308 DefaultTypeAttributes.
17310 2004-07-25 Martin Baulig <martin@ximian.com>
17312 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17313 we can just use the `Parent' field instead.
17315 2004-07-25 Martin Baulig <martin@ximian.com>
17317 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17319 2004-07-25 Martin Baulig <martin@ximian.com>
17321 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17322 our parts before defining any methods.
17323 (TypeContainer.VerifyImplements): Make this virtual.
17324 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17325 on our PartialContainer.
17327 2004-07-25 Martin Baulig <martin@ximian.com>
17329 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17331 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17332 argument, we can just use the `Parent' field instead.
17335 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17336 (MemberBase.DoDefine): Likewise.
17338 2004-07-24 Martin Baulig <martin@ximian.com>
17340 * decl.cs (MemberCore.Parent): New public field.
17341 (DeclSpace.Parent): Moved to MemberCore.
17343 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17344 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17346 (FieldBase, Field, Operator): Likewise.
17347 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17348 (EventField, Event): Likewise.
17350 2004-07-23 Martin Baulig <martin@ximian.com>
17352 * class.cs (PartialContainer): New public class.
17353 (ClassPart): New public class.
17354 (TypeContainer): Added support for partial classes.
17355 (TypeContainer.GetClassBases): Splitted some of the functionality
17356 out into GetNormalBases() and GetPartialBases().
17358 * cs-tokenizer.cs (Token.PARTIAL): New token.
17359 (Tokenizer.consume_identifier): Added some hacks to recognize
17360 `partial', but only if it's immediately followed by `class',
17361 `struct' or `interface'.
17363 * cs-parser.jay: Added support for partial clases.
17365 2004-07-23 Martin Baulig <martin@ximian.com>
17367 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17368 a `DeclSpace' and also made it readonly.
17369 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17370 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17371 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17373 * cs-parser.jay: Pass the `current_class', not the
17374 `current_container' (at the moment, this is still the same thing)
17375 to a new Method, Property, Event, Indexer or Constructor.
17377 2004-07-23 Martin Baulig <martin@ximian.com>
17379 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17380 and removed the `current_interface' one.
17381 (struct_declaration, class_declaration, interface_declaration):
17382 Set `current_class' to the newly created class/struct/interface;
17383 set their `Bases' and call Register() before parsing their body.
17385 2004-07-23 Martin Baulig <martin@ximian.com>
17387 * class.cs (Kind): New public enum.
17388 (TypeContainer): Made this class abstract.
17389 (TypeContainer.Kind): New public readonly field.
17390 (TypeContainer.CheckDef): New public method; moved here from
17392 (TypeContainer.Register): New public abstract method.
17393 (TypeContainer.GetPendingImplementations): New public abstract
17395 (TypeContainer.GetClassBases): Removed the `is_class' and
17396 `is_iface' parameters.
17397 (TypeContainer.DefineNestedTypes): Formerly known as
17399 (ClassOrStruct): Made this class abstract.
17401 * tree.cs (RootTypes): New public type.
17403 2004-07-20 Martin Baulig <martin@ximian.com>
17405 * tree.cs (Tree.RecordNamespace): Removed.
17406 (Tree.Namespaces): Removed.
17408 * rootcontext.cs (RootContext.IsNamespace): Removed.
17410 * cs-parser.jay (namespace_declaration): Just create a new
17411 NamespaceEntry here.
17413 2004-07-20 Martin Baulig <martin@ximian.com>
17415 * statement.cs (ExceptionStatement): New abstract class. This is
17416 now used as a base class for everyone who's using `finally'.
17417 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17418 our local variables before using them.
17420 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17421 virtual method. This is used by Yield.Resolve() to "steal" an
17422 outer block's `finally' clauses.
17423 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17426 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17427 version which takes an ExceptionStatement. This version must be
17428 used to create exception branchings.
17431 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17432 (Iterator.EmitMoveNext): Added exception support; protect the
17433 block with a `fault' clause, properly handle 'finally' clauses.
17434 (Iterator.EmitDispose): Run all the `finally' clauses here.
17436 2004-07-20 Martin Baulig <martin@ximian.com>
17438 * iterator.cs: This is the first of a set of changes in the
17439 iterator code. Match the spec more closely: if we're an
17440 IEnumerable, then GetEnumerator() must be called. The first time
17441 GetEnumerator() is called, it returns the current instance; all
17442 subsequent invocations (if any) must create a copy.
17444 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17446 * expression.cs: Resolve the constant expression before returning
17449 2004-07-19 Martin Baulig <martin@ximian.com>
17451 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17452 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17453 the return type of the new EmitContext.
17455 2004-07-18 Martin Baulig <martin@ximian.com>
17457 * class.cs (Property.Define): Fix iterators.
17459 * iterators.cs (Iterator.Define): Moved the
17460 `container.AddInterator (this)' call here from the .ctor; only do
17461 it if we resolved successfully.
17463 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17465 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17466 `true' for preprocessing directives that we parse. The return
17467 value indicates whether we should return to regular tokenizing or
17468 not, not whether it was parsed successfully.
17470 In the past if we were in: #if false ... #line #endif, we would
17471 resume parsing after `#line'. See bug 61604.
17473 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17474 building: IsEnumType should return true only for enums, not for
17475 enums or System.Enum itself. This fixes #61593.
17477 Likely what happened is that corlib was wrong: mcs depended on
17478 this bug in some places. The bug got fixed, we had to add the
17479 hack, which caused bug 61593.
17481 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17482 that was a workaround for the older conditions.
17484 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17486 * assign.cs: IAssignMethod has a new interface, as documented
17487 inline. All assignment code now uses this new api.
17489 * ecore.cs, expression.cs: All classes which implement
17490 IAssignMethod now use the new interface.
17492 * expression.cs (Invocation): add a hack to EmitCall so that
17493 IndexerAccess can be the target of a compound assignment without
17494 evaluating its arguments twice.
17496 * statement.cs: Handle changes in Invocation api.
17498 2004-07-16 Martin Baulig <martin@ximian.com>
17500 * iterators.cs: Rewrote this. We're now using one single Proxy
17501 class for both the IEnumerable and the IEnumerator interface and
17502 `Iterator' derives from Class so we can use the high-level API.
17504 * class.cs (TypeContainer.AddIterator): New method.
17505 (TypeContainer.DoDefineType): New protected virtual method, which
17506 is called from DefineType().
17507 (TypeContainer.DoDefineMembers): Call DefineType() and
17508 DefineMembers() on all our iterators.
17509 (TypeContainer.Emit): Call Emit() on all our iterators.
17510 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17512 * codegen.cs (EmitContext.CurrentIterator): New public field.
17514 2004-07-15 Martin Baulig <martin@ximian.com>
17517 (TypeManager.not_supported_exception_type): New type.
17519 2004-07-14 Martin Baulig <martin@ximian.com>
17521 * iterators.cs: Use real error numbers.
17523 2004-07-14 Martin Baulig <martin@ximian.com>
17525 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17526 requires this to be a System.Collection.IEnumerable and not a
17527 class implementing that interface.
17528 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17530 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17532 * class.cs: Fixed previous fix, it broke some error tests.
17534 2004-07-12 Martin Baulig <martin@ximian.com>
17536 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17539 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17541 * assign.cs (LocalTemporary): Add new argument: is_address,If
17542 `is_address' is true, then the value that we store is the address
17543 to the real value, and not the value itself.
17545 * ecore.cs (PropertyExpr): use the new local temporary
17546 stuff to allow us to handle X.Y += z (where X is a struct)
17548 2004-07-08 Martin Baulig <martin@ximian.com>
17550 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
17551 not always return, just like we're doing in Using.Resolve().
17553 2004-07-07 Miguel de Icaza <miguel@ximian.com>
17555 * cs-parser.jay (fixed_statement): flag this as Pinned.
17557 2004-07-06 Miguel de Icaza <miguel@ximian.com>
17559 * typemanager.cs (TypeManager): Removed MakePinned method, this
17560 mechanism is replaced with the .NET 2.x compatible mechanism of
17561 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
17563 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
17564 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
17565 `IsFixed' property which has a different meaning.
17567 2004-07-02 Raja R Harinath <rharinath@novell.com>
17569 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
17570 visible from inside a nested class, not just the names of the
17571 immediately enclosing class.
17572 Fix for bug #60730.
17574 2004-06-24 Raja R Harinath <rharinath@novell.com>
17576 * expression.cs (BetterConversion): Remove buggy special-case
17577 handling of "implicit constant expression conversions". At this
17578 point, we already know that the conversion is possible -- we're
17579 only checking to see which is better.
17581 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17583 * cs-parser.jay: Added error CS0210 test.
17585 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17587 * cs-parser.jay: Added error CS0134 test.
17589 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17592 * cs-parser.jay: Added error CS0145 test.
17594 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17596 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
17598 2004-06-23 Ben Maurer <bmaurer@ximian.com>
17600 * expression.cs (StackAlloc.Resolve): The argument may not
17601 be a constant; deal with this case.
17603 2004-06-23 Marek Safar <marek.safar@seznam.cz>
17605 * attribute.cs (IndexerName_GetIndexerName): Renamed to
17606 GetIndexerAttributeValue.
17607 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
17609 * class.cs (Indexer.Define): Added error tests for CS0415,
17612 2004-06-23 Miguel de Icaza <miguel@ximian.com>
17614 * attribute.cs (Attribute.Resolve): Keep field code in sync with
17617 2004-06-23 Martin Baulig <martin@ximian.com>
17619 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
17620 neither return nor throw, reset the barrier as well. Fixes #60457.
17622 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
17624 * class.cs : EventAttributes is now set to None by default.
17625 This fixes bug #60459.
17627 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17630 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17631 Don't throw exception but return null (it's sufficient now).
17633 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17635 * typemanager.cs (GetArgumentTypes): Faster implementation.
17637 2004-06-18 Martin Baulig <martin@ximian.com>
17639 * attribute.cs (Attribute.Resolve): Check whether we're an
17640 EmptyCast which a Constant child. Fixes #60333.
17642 2004-06-17 Ben Maurer <bmaurer@ximian.com>
17644 * statement.cs (EmitCollectionForeach): Account for the fact that
17645 not all valuetypes are in areas which we can take the address of.
17646 For these variables, we store to a temporary variable. Also, make
17647 sure that we dont emit a `callvirt' on a valuetype method.
17649 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17651 * expression.cs (StackAlloc.DoReSolve): Added test for
17652 negative parameter (CS0247).
17654 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17657 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
17659 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17662 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
17665 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17667 Fix bug #58254 & cs1555.cs, cs1556.cs
17668 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
17670 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17672 * cs-parser.jay: Added error CS1669 test for indexers.
17674 2004-06-11 Martin Baulig <martin@ximian.com>
17676 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
17677 call this twice: for params and varargs methods.
17679 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17682 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
17684 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17686 * attribute.cs (Attribute.GetValidTargets): Made public.
17689 (AbstractPropertyEventMethod): New class for better code sharing.
17690 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
17692 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
17694 2004-06-11 Raja R Harinath <rharinath@novell.com>
17697 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
17698 that the call to Resolve is part of a MemberAccess.
17699 (Expression.Resolve): Use it for SimpleName resolution.
17700 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
17701 Add 'intermediate' boolean argument.
17702 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
17703 error message when the SimpleName can be resolved ambiguously
17704 between an expression and a type.
17705 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
17707 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
17708 call on the left-side.
17710 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17713 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
17715 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17717 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
17719 2004-06-11 Martin Baulig <martin@ximian.com>
17721 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
17722 varargs methods if applicable.
17724 2004-06-11 Martin Baulig <martin@ximian.com>
17726 * expression.cs (Invocation.EmitCall): Don't use
17727 `method.CallingConvention == CallingConventions.VarArgs' since the
17728 method could also have `CallingConventions.HasThis'.
17730 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17732 * class.cs (Event.GetSignatureForError): Implemented.
17733 Fixed crash in error test cs3010.cs
17735 2004-06-10 Miguel de Icaza <miguel@ximian.com>
17737 * cs-tokenizer.cs: Change the way we track __arglist to be
17738 consistent with the other keywords.
17740 2004-06-09 Miguel de Icaza <miguel@ximian.com>
17742 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
17745 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
17747 * codegen.cs: Check that all referenced assemblies have a strongname
17748 before strongnaming the compiled assembly. If not report error CS1577.
17749 Fix bug #56563. Patch by Jackson Harper.
17750 * typemanager.cs: Added a method to return all referenced assemblies.
17751 Fix bug #56563. Patch by Jackson Harper.
17753 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17756 (Method.ApplyAttributeBuilder): Moved and added conditional
17757 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
17760 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
17762 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17765 * class.cs: (EventField.attribute_targets): Changed default target.
17767 2004-06-08 Martin Baulig <martin@ximian.com>
17769 * expression.cs (Invocation.EmitCall): Enable varargs methods.
17771 2004-06-08 Martin Baulig <martin@ximian.com>
17773 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
17775 2004-06-07 Martin Baulig <martin@ximian.com>
17777 Added support for varargs methods.
17779 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
17782 * cs-parser.jay: Added support for `__arglist'.
17784 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
17786 * expression.cs (Argument.AType): Added `ArgList'.
17787 (Invocation): Added support for varargs methods.
17788 (ArglistAccess): New public class.
17789 (Arglist): New public class.
17791 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
17793 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
17794 a method's top-level block if the method has varargs.
17796 * support.cs (ReflectionParameters, InternalParameters): Added
17797 support for varargs methods.
17799 2004-06-07 Miguel de Icaza <miguel@ximian.com>
17801 * class.cs: Provide location in indexer error report.
17803 * driver.cs: Use standard names.
17805 * namespace.cs: Catch the use of using after a namespace has been
17806 declared also on using aliases.
17808 2004-06-03 Raja R Harinath <rharinath@novell.com>
17811 * typemanager.cs (closure_private_ok, closure_invocation_type)
17812 (closure_qualifier_type, closure_invocation_assembly)
17813 (FilterWithClosure): Move to ...
17814 (Closure): New internal nested class.
17815 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
17816 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
17817 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
17818 (MemberLookup, MemberLookupFailed): Use it.
17819 * expression.cs (New.DoResolve): Treat the lookup for the
17820 constructor as being qualified by the 'new'ed type.
17821 (Indexers.GetIndexersForTypeOrInterface): Update.
17823 2004-06-03 Marek Safar <marek.safar@seznam.cz>
17826 (GetConditionalAttributeValue): New method. Returns
17827 condition of ConditionalAttribute.
17828 (SearchMulti): New method. Returns all attributes of type 't'.
17829 Use it when attribute is AllowMultiple = true.
17830 (IsConditionalMethodExcluded): New method.
17833 (Method.IsExcluded): Implemented. Returns true if method has conditional
17834 attribute and the conditions is not defined (method is excluded).
17835 (IMethodData): Extended interface for ConditionalAttribute support.
17836 (PropertyMethod.IsExcluded): Implemented.
17839 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
17842 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
17845 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
17847 * expression.cs (ArrayCreationExpression): Make this just an
17848 `expression'. It can't be a statement, so the code here was
17851 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17854 * typemanager.cs (GetFullNameSignature): New method for
17857 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17860 * class.cs (MemberBase.GetSignatureForError): New virtual method.
17861 Use this method when MethodBuilder is null.
17862 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
17863 Added test for error CS0626 (MONO reports error for this situation).
17864 (IMethodData.GetSignatureForError): Extended interface.
17866 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17869 (AttributeTester.GetObsoleteAttribute): Returns instance of
17870 ObsoleteAttribute when type is obsolete.
17873 (TypeContainer.VerifyObsoleteAttribute): Override.
17874 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
17875 (MethodCode.VerifyObsoleteAttribute): Override.
17876 (MemberBase.VerifyObsoleteAttribute): Override.
17879 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
17880 and report proper error.
17883 Delegate.VerifyObsoleteAttribute): Override.
17886 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
17887 and report proper error.
17888 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
17891 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
17895 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
17896 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
17897 Added test for ObsoleteAttribute.
17900 (Catch): Derived from Statement.
17902 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17904 Fixed bug #59071 & cs0160.cs
17906 * statement.cs (Try.Resolve): Check here whether order of catch
17907 clauses matches their dependencies.
17909 2004-05-31 Miguel de Icaza <miguel@ximian.com>
17911 * Reverted patch to namespace.cs (Use lookuptypedirect). This
17912 caused a regression: #59343. Referencing nested classes from an
17913 assembly stopped working.
17915 2004-05-31 Martin Baulig <martin@ximian.com>
17917 MCS is now frozen for beta 2.
17919 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17921 * convert.cs: add a trivial cache for overload operator resolution.
17923 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17925 * decl.cs: If possible, use lookuptypedirect here. We can only do
17926 this if there is no `.' after the namespace. Avoids using
17927 LookupType, which does lots of slow processing.
17928 (FindNestedType) New method, does what it says :-).
17929 * namespace.cs: use LookupTypeDirect.
17930 * rootcontext.cs: use membercache, if possible.
17931 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
17933 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17936 According to the spec,
17938 In a member access of the form E.I, if E is a single identifier,
17939 and if the meaning of E as a simple-name (§7.5.2) is a constant,
17940 field, property, localvariable, or parameter with the same type as
17941 the meaning of E as a type-name (§3.8), then both possible
17942 meanings of E are permitted.
17944 We did not check that E as a simple-name had the same type as E as
17947 This trivial check gives us 5-7% on bootstrap time.
17949 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17951 * expression.cs (Invocation.OverloadResolve): Avoid the
17952 use of hashtables and boxing here by allocating on demand.
17954 2004-05-30 Martin Baulig <martin@ximian.com>
17956 * rootcontext.cs (RootContext.LookupType): Don't cache things if
17957 we're doing a silent lookup. Don't try to lookup nested types in
17958 TypeManager.object_type (thanks to Ben Maurer).
17960 2004-05-30 Martin Baulig <martin@ximian.com>
17962 Committing a patch from Ben Maurer.
17964 * rootcontext.cs (RootContext.LookupType): Cache negative results.
17966 2004-05-29 Martin Baulig <martin@ximian.com>
17968 * class.cs (IMethodData.ShouldIgnore): New method.
17970 * typemanager.cs (TypeManager.MethodFlags): Don't take a
17971 `Location' argument, we don't need it anywhere. Use
17972 `IMethodData.ShouldIgnore ()' instead of
17973 `MethodData.GetMethodFlags ()'.
17974 (TypeManager.AddMethod): Removed.
17975 (TypeManager.AddMethod2): Renamed to AddMethod.
17977 2004-05-29 Martin Baulig <martin@ximian.com>
17979 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
17981 * convert.cs (Convert.ImplicitReferenceConversion): If we're
17982 converting from a class type S to an interface type and we already
17983 have an object on the stack, don't box it again. Fixes #52578.
17985 2004-05-29 Martin Baulig <martin@ximian.com>
17987 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17988 Added support for `params' parameters. Fixes #59267.
17990 2004-05-29 Martin Baulig <martin@ximian.com>
17992 * literal.cs (NullPointer): Provide a private .ctor which sets
17993 `type' to TypeManager.object_type. Fixes #59048.
17995 2004-05-29 Martin Baulig <martin@ximian.com>
17997 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
17998 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18000 * ecore.cs (EventExpr.instance_expr): Make the field private.
18002 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18004 Fixed bug #50080 & cs0214-2.cs
18005 * expression.cs (Cast.DoResolve): Check unsafe context here.
18007 * statement.cs (Resolve.DoResolve): Likewise.
18009 2004-05-26 Martin Baulig <martin@ximian.com>
18011 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18013 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18014 (RootContext.LookupType): Pass down the `silent' flag.
18016 2004-05-25 Martin Baulig <martin@ximian.com>
18019 (MethodGroupExpr.IdenticalTypeName): New public property.
18020 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18021 expression actually refers to a type.
18023 2004-05-25 Martin Baulig <martin@ximian.com>
18025 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18026 for #56176 and made it actually work.
18028 2004-05-25 Martin Baulig <martin@ximian.com>
18030 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18031 (FieldExpr, PropertyExpr): Override and implement
18032 CacheTemporaries. Fixes #52279.
18034 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18036 * location.cs: In the new compiler listing a file twice is a
18037 warning, not an error.
18039 2004-05-24 Martin Baulig <martin@ximian.com>
18041 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18042 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18044 2004-05-24 Martin Baulig <martin@ximian.com>
18046 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18047 walking the `using' list. Fixes #53921.
18049 2004-05-24 Martin Baulig <martin@ximian.com>
18051 * const.cs (Const.LookupConstantValue): Added support for
18052 EmptyCast's; fixes #55251.
18054 2004-05-24 Martin Baulig <martin@ximian.com>
18056 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18057 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18058 which does the CS0135 check. The reason is that we first need to
18059 check whether the variable actually exists.
18061 2004-05-24 Martin Baulig <martin@ximian.com>
18063 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18064 than RootContext.LookupType() to find the explicit interface
18065 type. Fixes #58584.
18067 2004-05-24 Raja R Harinath <rharinath@novell.com>
18069 * Makefile: Simplify. Use executable.make.
18070 * mcs.exe.sources: New file. List of sources of mcs.exe.
18072 2004-05-24 Anders Carlsson <andersca@gnome.org>
18076 Use the invariant culture when doing String.Compare for CLS case
18079 2004-05-23 Martin Baulig <martin@ximian.com>
18081 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18082 don't have any dots. Fixes #52622, added cs0246-8.cs.
18084 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18086 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18088 * class.cs (MemberBase.Define): Reuse MemberType member for
18089 resolved type. Other methods can use it too.
18091 2004-05-23 Martin Baulig <martin@ximian.com>
18093 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18094 the variable also exists in the current block (otherwise, we need
18095 to report a CS0103). Fixes #58670.
18097 2004-05-23 Martin Baulig <martin@ximian.com>
18099 * flowanalysis.cs (Reachability.Reachable): Compute this
18100 on-the-fly rather than storing it as a field.
18102 2004-05-23 Martin Baulig <martin@ximian.com>
18104 * flowanalysis.cs (Reachability.And): Manually compute the
18105 resulting `barrier' from the reachability.
18107 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18110 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18111 instance of ObsoleteAttribute when symbol is obsolete.
18114 (IMethodData): Extended interface for ObsoleteAttribute support.
18116 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18118 * attribute.cs: Fix bug #55970
18120 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18124 (GetObsoleteAttribute): New method. Creates the instance of
18126 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18127 ObsoleteAttribute when member is obsolete.
18128 (AttributeTester.Report_ObsoleteMessage): Common method for
18129 Obsolete error/warning reporting.
18132 (TypeContainer.base_classs_type): New member for storing parent type.
18135 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18136 for this MemberCore.
18138 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18140 * attribute.cs, const.cs: Fix bug #58590
18142 2004-05-21 Martin Baulig <martin@ximian.com>
18144 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18145 out parameters if the end of the method is unreachable. Fixes
18148 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18150 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18151 Hari was right, why extra method.
18153 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18155 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18157 2004-05-20 Martin Baulig <martin@ximian.com>
18159 Merged this back from gmcs to keep the differences to a minumum.
18161 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18162 instead of a Declspace.
18163 (Attribute.ResolveType): Likewise.
18164 (Attributes.Search): Likewise.
18165 (Attributes.Contains): Likewise.
18166 (Attributes.GetClsCompliantAttribute): Likewise.
18168 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18170 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18173 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18175 Fix bug #58688 (MCS does not report error when the same attribute
18178 * attribute.cs (Attribute.Emit): Distinction between null and default.
18180 2004-05-19 Raja R Harinath <rharinath@novell.com>
18182 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18183 of a top-level attribute without an attribute target.
18184 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18186 (Attribute.Conditional_GetConditionName),
18187 (Attribute.Obsolete_GetObsoleteMessage): Update.
18188 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18189 part of ScanForIndexerName.
18190 (Attribute.CanIgnoreInvalidAttribute): New function.
18191 (Attribute.ScanForIndexerName): Move to ...
18192 (Attributes.ScanForIndexerName): ... here.
18193 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18194 (Attributes.Search): New internal variant that can choose not to
18195 complain if types aren't resolved. The original signature now
18197 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18198 complaints suppressed.
18199 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18200 only if it not useful.
18201 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18202 top-level for attributes that are shared between the assembly
18203 and a top-level class.
18204 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18205 * class.cs: Update to reflect changes.
18206 (DefineIndexers): Fuse loops.
18207 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18208 a couple more variants of attribute names.
18210 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18212 Fix bug #52585 (Implemented explicit attribute declaration)
18215 (Attributable.ValidAttributeTargets): New abstract method. It gets
18216 list of valid attribute targets for explicit target declaration.
18217 (Attribute.Target): It holds target itself.
18218 (AttributeSection): Removed.
18219 (Attribute.CheckTargets): New method. It checks whether attribute
18220 target is valid for the current element.
18223 (EventProperty): New class. For events that are declared like
18224 property (with add and remove accessors).
18225 (EventField): New class. For events that are declared like field.
18228 * cs-parser.jay: Implemented explicit attribute target declaration.
18230 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18231 Override ValidAttributeTargets.
18234 (ReturnParameter): Class for applying custom attributes on
18236 (ParameterAtribute): New class. Class for applying custom
18237 attributes on the parameter type.
18239 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18241 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18244 (Method): Allow UNSAFE here.
18246 * modifiers.cs: Support unsafe reporting.
18248 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18250 * decl.cs: Fix bug #58478.
18252 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18254 * statement.cs: When checking for unreachable code on an EmptyStatement,
18255 set the location. Fixes bug #58488.
18257 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18259 * driver.cs: Add -pkg handling.
18261 From Gonzalo: UseShelLExecute=false
18263 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18266 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18268 (Attribute.IsClsCompliaceRequired): Moved to base for better
18270 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18271 when attribute is AttributeUsageAttribute.
18272 (Attribute.GetValidTargets): Simplified.
18273 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18274 attribute for this type.
18275 (Attribute.ApplyAttributes): Method renamed to Emit and make
18277 (GlobalAttributeSection): New class for special handling of global
18278 attributes (assembly, module).
18279 (AttributeSection.Emit): New method.
18281 * class.cs: Implemented Attributable abstract methods.
18282 (MethodCore.LabelParameters): Moved to Parameter class.
18283 (Accessor): Is back simple class.
18284 (PropertyMethod): Implemented Attributable abstract class.
18285 (DelegateMethod): Implemented Attributable abstract class.
18286 (Event): New constructor for disctintion between normal Event
18287 and Event with accessors.
18289 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18291 * codegen.cs, const.cs, decl.cs, delegate.cs:
18292 (CommonAssemblyModulClass): Implemented Attributable abstract class
18295 * enum.cs: Implement IAttributeSupport interface.
18296 (EnumMember): New class for emum members. Implemented Attributable
18300 (ParameterBase): Is abstract.
18301 (ReturnParameter): New class for easier [return:] attribute handling.
18303 * typemanager.cs: Removed builder_to_attr.
18305 2004-05-11 Raja R Harinath <rharinath@novell.com>
18308 * attribute.cs (Attribute.GetPositionalValue): New function.
18309 * class.cs (TypeContainer.VerifyMembers): New function.
18310 (TypeContainer.Emit): Use it.
18311 (ClassOrStruct): New base class for Class and Struct.
18312 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18313 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18315 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18316 then each non-static field should have a FieldOffset attribute.
18317 Otherwise, none of the fields should have a FieldOffset attribute.
18318 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18319 and FieldOffset attributes.
18320 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18321 (TypeManager.field_offset_attribute_type): New core types.
18322 (TypeManager.InitCoreTypes): Initialize them.
18324 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18326 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18327 Return correct type.
18330 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18332 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18333 be implicitly converted to ulong.
18335 * expression.cs: The logic for allowing operator &, | and ^ worked
18336 was wrong, it worked before because we did not report an error in
18337 an else branch. Fixes 57895.
18339 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18340 allow volatile fields to be reference types.
18342 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18344 * driver.cs: Add support for /debug-
18346 2004-05-07 Raja R Harinath <rharinath@novell.com>
18348 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18349 Add a 'complain' parameter to silence errors.
18350 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18351 silently overlooked type-resolutions.
18352 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18353 to reflect changes.
18354 (Attributes.Search): New function.
18355 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18356 (Attributes.GetAttributeFullName): Remove hack.
18357 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18358 Update to reflect changes.
18359 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18360 Use Attributes.Search instead of nested loops.
18362 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18365 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18366 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18367 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18369 * report.cs: (Report.Warning): Renamed to Warning_T because of
18370 parameter collision.
18372 2004-05-05 Raja R Harinath <rharinath@novell.com>
18374 * expression.cs (MemberAccess.ResolveMemberAccess):
18375 Exit with non-zero status after Report.Error.
18376 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18378 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18380 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18382 * support.cs: Don't hang when the file is empty.
18384 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18386 * support.cs: In SeekableStreamReader, compute the preamble size of the
18387 underlying stream. Position changes should take into account that initial
18390 2004-05-03 Todd Berman <tberman@sevenl.net>
18392 * driver.cs: remove unused GetSysVersion function.
18394 2004-05-03 Todd Berman <tberman@sevenl.net>
18396 * driver.cs: Remove the hack from saturday, as well as the hack
18397 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18398 link_paths to get that bit proper.
18400 2004-05-01 Todd Berman <tberman@sevenl.net>
18402 * driver.cs: Try a LoadFrom before a Load, this checks the current
18403 path. This is currently a bug in mono that is be fixed, however, this
18404 provides a workaround for now. This will be removed when the bug
18407 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18409 * CryptoConvert.cs: Updated to latest version. Fix issue with
18410 incomplete key pairs (#57941).
18412 2004-05-01 Todd Berman <tberman@sevenl.net>
18414 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18417 2004-04-30 Jackson Harper <jackson@ximian.com>
18419 * codegen.cs: Open keys readonly.
18421 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18423 * typemanager.cs: don't report cyclic struct layout when a struct
18424 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18425 which has 2 Pango.Rectangle fields.
18427 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18429 * expression.cs: Handle IntPtr comparisons with IL code
18430 rather than a method call.
18432 2004-04-29 Martin Baulig <martin@ximian.com>
18434 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18435 the list of PropertyInfo's in class hierarchy and find the
18436 accessor. Fixes #56013.
18438 2004-04-29 Martin Baulig <martin@ximian.com>
18440 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18442 2004-04-29 Martin Baulig <martin@ximian.com>
18444 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18446 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18448 2004-04-29 Martin Baulig <martin@ximian.com>
18450 * class.cs (ConstructorInitializer.Resolve): Check whether the
18451 parent .ctor is accessible. Fixes #52146.
18453 2004-04-29 Martin Baulig <martin@ximian.com>
18455 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18457 * statement.cs (Using.EmitLocalVariableDecls): Use
18458 TypeManager.idisposable_type, not typeof (IDisposable).
18459 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18461 2004-04-29 Martin Baulig <martin@ximian.com>
18463 * class.cs (Event.Define): Don't emit the field and don't set
18464 RTSpecialName and SpecialName for events on interfaces. Fixes
18467 2004-04-29 Raja R Harinath <rharinath@novell.com>
18469 Refactor Attribute.ApplyAttributes.
18470 * attribute.cs (Attributable): New base class for objects that can
18471 have Attributes applied on them.
18472 (Attribute): Make AttributeUsage fields public.
18473 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18474 (Attribute.IsInternalCall): New property.
18475 (Attribute.UsageAttr): Convert to a public read-only property.
18476 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18477 (Attribute.ResolveType, Attribute.Resolve)
18478 (Attribute.ScanForIndexerName): Update to reflect changes.
18479 (Attribute.CheckAttributeTarget): Re-format.
18480 (Attribute.ApplyAttributes): Refactor, to various
18481 Attributable.ApplyAttributeBuilder methods.
18482 * decl.cs (MemberCore): Make Attributable.
18483 * class.cs (Accessor): Make Attributable.
18484 (MethodData.ApplyAttributes): Use proper attribute types, not
18486 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18487 (TypeContainer.ApplyAttributeBuilder)
18488 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18489 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18490 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18491 (Operator.ApplyAttributeBuilder): New factored-out methods.
18492 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18493 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18494 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18495 * parameter.cs (ParameterBase): New Attributable base class
18496 that can also represent Return types.
18497 (Parameter): Update to the changes.
18499 2004-04-29 Jackson Harper <jackson@ximian.com>
18501 * driver.cs: Prefer the corlib system version when looking for
18502 assemblies in the GAC. This is still a hack, but its a better hack
18505 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18507 * decl.cs, enum.cs: Improved error 3005 reporting.
18509 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18510 (related_symbols): New private member for list of symbols
18511 related to reported error/warning.
18513 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18515 2004-04-29 Martin Baulig <martin@ximian.com>
18517 * ecore.cs (Expression.Constantify): If we're an enum and
18518 TypeManager.TypeToCoreType() doesn't give us another type, use
18519 t.UnderlyingSystemType. Fixes #56178.
18521 2004-04-29 Martin Baulig <martin@ximian.com>
18523 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18524 interfaces and for each interface, only add members directly
18525 declared in that interface. Fixes #53255.
18527 2004-04-28 Martin Baulig <martin@ximian.com>
18529 * expression.cs (ConditionalLogicalOperator): Use a temporary
18530 variable for `left' to avoid that we evaluate it more than once;
18533 2004-04-28 Martin Baulig <martin@ximian.com>
18535 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18538 2004-04-28 Martin Baulig <martin@ximian.com>
18540 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18543 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18544 whether the type is not void (CS1547).
18546 2004-04-28 Martin Baulig <martin@ximian.com>
18548 * expression.cs (Unary.DoResolveLValue): Override this and report
18549 CS0131 for anything but Operator.Indirection.
18551 2004-04-28 Martin Baulig <martin@ximian.com>
18553 Committing a patch from Ben Maurer; see bug #50820.
18555 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18558 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18561 2004-04-28 Martin Baulig <martin@ximian.com>
18563 Committing a patch from Ben Maurer; see bug #50820.
18565 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18568 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18571 2004-04-28 Martin Baulig <martin@ximian.com>
18573 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
18574 (Block.AddLabel): Call DoLookupLabel() to only search in the
18577 2004-04-28 Martin Baulig <martin@ximian.com>
18579 * cfold.cs (ConstantFold.BinaryFold): Added special support for
18580 comparing StringConstants and NullLiterals in Equality and Inequality.
18582 2004-04-28 Jackson Harper <jackson@ximian.com>
18584 * driver.cs: Attempt to load referenced assemblies from the
18585 GAC. This is the quick and dirty version of this method that
18586 doesnt take into account versions and just takes the first
18587 canidate found. Will be good enough for now as we will not have more
18588 then one version installed into the GAC until I update this method.
18590 2004-04-28 Martin Baulig <martin@ximian.com>
18592 * typemanager.cs (TypeManager.CheckStructCycles): New public
18593 static method to check for cycles in the struct layout.
18595 * rootcontext.cs (RootContext.PopulateTypes): Call
18596 TypeManager.CheckStructCycles() for each TypeContainer.
18597 [Note: We only need to visit each type once.]
18599 2004-04-28 Martin Baulig <martin@ximian.com>
18601 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
18603 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
18604 success and added `out object value'. Use a `bool resolved' field
18605 to check whether we've already been called rather than
18606 `ConstantValue != null' since this breaks for NullLiterals.
18608 2004-04-28 Raja R Harinath <rharinath@novell.com>
18610 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
18611 setting of this flag, since the 'set' method may be non-public.
18613 2004-04-28 Raja R Harinath <rharinath@novell.com>
18615 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
18616 check on current_vector.Block.
18618 2004-04-27 Martin Baulig <martin@ximian.com>
18620 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
18621 a field initializer. Fixes #56459.
18623 2004-04-27 Martin Baulig <martin@ximian.com>
18625 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
18626 we're not attempting to use an indexer. Fixes #52154.
18628 2004-04-27 Martin Baulig <martin@ximian.com>
18630 * statement.cs (Return): Don't create a return label if we don't
18631 need it; reverts my change from January 20th. Thanks to Ben
18634 2004-04-27 Martin Baulig <martin@ximian.com>
18636 According to the spec, `goto' can only leave a nested scope, but
18639 * statement.cs (Block.LookupLabel): Only lookup in the current
18640 block, don't recurse into parent or child blocks.
18641 (Block.AddLabel): Check in parent and child blocks, report
18642 CS0140/CS0158 if we find a duplicate.
18643 (Block): Removed this indexer for label lookups.
18644 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
18645 this already does the error reporting for us.
18648 (FlowBranching.UsageVector.Block): New public variable; may be null.
18649 (FlowBranching.CreateSibling): Added `Block' argument.
18650 (FlowBranching.LookupLabel): New public virtual method. Lookup a
18651 label for the target of a `goto' and check whether we're not
18652 leaving a `finally'.
18654 2004-04-27 Martin Baulig <martin@ximian.com>
18656 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
18657 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
18660 2004-04-27 Martin Baulig <martin@ximian.com>
18662 * statement.cs (Block.AddLabel): Also check for implicit blocks
18663 and added a CS0158 check.
18665 2004-04-27 Martin Baulig <martin@ximian.com>
18667 * flowanalysis.cs (FlowBranchingLoop): New class.
18668 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
18669 UsageVector's instead of an ArrayList.
18670 (FlowBranching.Label): Likewise.
18671 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
18672 (FlowBranching.AddBreakVector): New method.
18674 2004-04-27 Miguel de Icaza <miguel@ximian.com>
18676 * attribute.cs: Small regression fix: only convert the type if we
18677 the type is different, fixes System.Drawing build.
18679 2004-04-27 Martin Baulig <martin@ximian.com>
18681 * attribute.cs (Attribute.Resolve): If we have a constant value
18682 for a named field or property, implicity convert it to the correct
18685 2004-04-27 Raja R Harinath <rharinath@novell.com>
18687 * statement.cs (Block.Block): Implicit blocks share
18688 'child_variable_names' fields with parent blocks.
18689 (Block.AddChildVariableNames): Remove.
18690 (Block.AddVariable): Mark variable as "used by a child block" in
18691 every surrounding block.
18692 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
18693 been used in a child block, complain about violation of "Invariant
18694 meaning in blocks" rule.
18695 * cs-parser.jay (declare_local_variables): Don't use
18696 AddChildVariableNames.
18697 (foreach_statement): Don't create an implicit block: 'foreach'
18698 introduces a scope.
18700 2004-04-23 Miguel de Icaza <miguel@ximian.com>
18702 * convert.cs (ImplicitNumericConversion): 0 is also positive when
18703 converting from 0L to ulong. Fixes 57522.
18705 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18707 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
18708 derived class hides via 'new' keyword field from base class (test-242.cs).
18709 TODO: Handle this in the more general way.
18711 * class.cs (CheckBase): Ditto.
18713 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18715 * decl.cs (caching_flags): New member for storing cached values
18717 (MemberCore.Flags): New enum where bit flags for caching_flags
18719 (MemberCore.cls_compliance): Moved to caching_flags.
18720 (DeclSpace.Created): Moved to caching_flags.
18722 * class.cs: Use caching_flags instead of DeclSpace.Created
18724 2004-04-21 Miguel de Icaza <miguel@ximian.com>
18726 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
18727 if we are only a derived class, not a nested class.
18729 * typemanager.cs: Same as above, but do this at the MemberLookup
18730 level (used by field and methods, properties are handled in
18731 PropertyExpr). Allow for the qualified access if we are a nested
18734 2004-04-21 Marek Safar <marek.safar@seznam.cz>
18736 * class.cs: Refactoring.
18737 (IMethodData): New inteface; Holds links to parent members
18738 to avoid member duplication (reduced memory allocation).
18739 (Method): Implemented IMethodData interface.
18740 (PropertyBase): New inner classes for get/set methods.
18741 (PropertyBase.PropertyMethod): Implemented IMethodData interface
18742 (Event): New inner classes for add/remove methods.
18743 (Event.DelegateMethod): Implemented IMethodData interface.
18745 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
18746 EmitContext (related to class.cs refactoring).
18748 2004-04-21 Raja R Harinath <rharinath@novell.com>
18750 * delegate.cs (Delegate.VerifyApplicability): If the number of
18751 arguments are the same as the number of parameters, first try to
18752 verify applicability ignoring any 'params' modifier on the last
18756 2004-04-16 Raja R Harinath <rharinath@novell.com>
18758 * class.cs (TypeContainer.AddIndexer): Use
18759 'ExplicitInterfaceName' to determine if interface name was
18760 explicitly specified. 'InterfaceType' is not initialized at this time.
18761 (TypeContainer.DefineIndexers): Remove use of temporary list. The
18762 Indexers array is already in the required order. Initialize
18763 'IndexerName' only if there are normal indexers.
18764 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
18765 (TypeContainer.Emit): Emit DefaultMember attribute only if
18766 IndexerName is initialized.
18769 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
18771 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
18774 2004-04-15 Raja R Harinath <rharinath@novell.com>
18776 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
18780 * attribute.cs (Attribute.Resolve): Check for duplicate named
18784 2004-04-15 Miguel de Icaza <miguel@ximian.com>
18786 * iterators.cs (MarkYield): track whether we are in an exception,
18787 and generate code accordingly. Use a temporary value to store the
18788 result for our state.
18790 I had ignored a bit the interaction of try/catch with iterators
18791 since their behavior was not entirely obvious, but now it is
18792 possible to verify that our behavior is the same as MS .NET 2.0
18796 2004-04-14 Miguel de Icaza <miguel@ximian.com>
18798 * iterators.cs: Avoid creating temporaries if there is no work to
18801 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
18802 Enumerations, use TypeManager.EnumToUnderlying and call
18805 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
18808 (This.Emit): Use EmitContext.EmitThis to emit our
18811 (This.EmitAssign): Ditto.
18813 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
18814 codepaths, we will move all the functionality into
18817 (FieldExpr.EmitAssign): Ditto.
18819 This fixes several hidden bugs that I uncovered while doing a code
18820 review of this today.
18822 * codegen.cs (EmitThis): reworked so the semantics are more clear
18823 and also support value types "this" instances.
18825 * iterators.cs: Changed so that for iterators in value types, we
18826 do not pass the value type as a parameter.
18828 Initialization of the enumerator helpers is now done in the caller
18829 instead of passing the parameters to the constructors and having
18830 the constructor set the fields.
18832 The fields have now `assembly' visibility instead of private.
18834 2004-04-11 Miguel de Icaza <miguel@ximian.com>
18836 * expression.cs (Argument.Resolve): Check if fields passed as ref
18837 or out are contained in a MarshalByRefObject.
18839 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
18840 another compiler type.
18842 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
18844 * class.cs (Indexer.Define): use the new name checking method.
18845 Also, return false on an error.
18846 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
18847 (is_identifier_[start/part]_character): make static.
18849 2004-04-10 Miguel de Icaza <miguel@ximian.com>
18851 * expression.cs (Binary.ResolveOperator): Do no append strings
18852 twice: since we can be invoked more than once (array evaluation)
18853 on the same concatenation, take care of this here. Based on a fix
18854 from Ben (bug #56454)
18856 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
18858 * codegen.cs: Fix another case where CS1548 must be reported (when
18859 delay-sign isn't specified and no private is available #56564). Fix
18860 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
18861 error when MCS is used on the MS runtime and we need to delay-sign
18862 (which seems unsupported by AssemblyBuilder - see #56621).
18864 2004-04-08 Marek Safar <marek.safar@seznam.cz>
18866 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
18867 (TypeManager.ComputeNamespaces): Faster implementation for
18870 * compiler.csproj: Updated AssemblyName to mcs.
18872 2004-04-07 Miguel de Icaza <miguel@ximian.com>
18874 * rootcontext.cs: Add new types to the boot resolution.
18876 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
18877 MulticastDelegate is not allowed.
18879 * typemanager.cs: Add new types to lookup: System.TypedReference
18882 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
18883 check for TypedReference or ArgIterator, they are not allowed.
18885 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
18886 makes us properly catch 1510 in some conditions (see bug 56016 for
18889 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
18891 * CryptoConvert.cs: update from corlib version
18894 2004-04-05 Miguel de Icaza <miguel@ximian.com>
18896 * class.cs (Indexer.Define): Check indexername declaration
18898 2004-04-05 Marek Safar <marek.safar@seznam.cz>
18900 * attribute.cs (IsClsCompliant): Fixed problem with handling
18901 all three states (compliant, not-compliant, undetected).
18903 2004-03-30 Marek Safar <marek.safar@seznam.cz>
18905 * attribute.cs (Attribute): Location is now public.
18906 (Resolve): Store resolved arguments (pos_values) in attribute class.
18907 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
18908 (GetClsCompliantAttributeValue): New method that gets
18909 CLSCompliantAttribute value.
18910 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
18911 if exists else null.
18912 (AttributeTester): New class for CLS-Compliant verification routines.
18914 * class.cs (Emit): Add CLS-Compliant verification.
18915 (Method.GetSignatureForError): Implemented.
18916 (Constructor.GetSignatureForError): Implemented
18917 (Constructor.HasCompliantArgs): Returns if constructor has
18918 CLS-Compliant arguments.
18919 (Constructor.Emit): Override.
18920 (Construcor.IsIdentifierClsCompliant): New method; For constructors
18921 is needed to test only parameters.
18922 (FieldBase.GetSignatureForError): Implemented.
18923 (TypeContainer): New member for storing base interfaces.
18924 (TypeContainer.FindMembers): Search in base interfaces too.
18926 * codegen.cs (GetClsComplianceAttribute): New method that gets
18927 assembly or module CLSCompliantAttribute value.
18928 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
18930 (ModuleClass.Emit): Add error 3012 test.
18932 * const.cs (Emit): Override and call base for CLS-Compliant tests.
18934 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
18935 state for all decl types.
18936 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
18937 if CLS-Compliant tests are required.
18938 (IsClsCompliaceRequired): New method. Analyze whether code
18939 must be CLS-Compliant.
18940 (IsExposedFromAssembly): New method. Returns true when MemberCore
18941 is exposed from assembly.
18942 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
18943 value or gets cached value.
18944 (HasClsCompliantAttribute): New method. Returns true if MemberCore
18945 is explicitly marked with CLSCompliantAttribute.
18946 (IsIdentifierClsCompliant): New abstract method. This method is
18947 used to testing error 3005.
18948 (IsIdentifierAndParamClsCompliant): New method. Common helper method
18949 for identifier and parameters CLS-Compliant testing.
18950 (VerifyClsCompliance): New method. The main virtual method for
18951 CLS-Compliant verifications.
18952 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
18953 null. I don't know why is null (too many public members !).
18954 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
18955 and get value of first CLSCompliantAttribute that found.
18957 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
18958 (VerifyClsCompliance): Override and add extra tests.
18960 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
18961 clscheck- disable CLS-Compliant verification event if assembly is has
18962 CLSCompliantAttribute(true).
18964 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
18965 ApllyAttribute is now called in emit section as in the other cases.
18966 Possible future Emit integration.
18967 (IsIdentifierClsCompliant): New override.
18968 (VerifyClsCompliance): New override.
18969 (GetEnumeratorName): Returns full enum name.
18971 * parameter.cs (GetSignatureForError): Implemented.
18973 * report.cs (WarningData): New struct for Warning message information.
18974 (LocationOfPreviousError): New method.
18975 (Warning): New method. Reports warning based on the warning table.
18976 (Error_T): New method. Reports error based on the error table.
18978 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
18979 verifications are done here.
18981 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
18983 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
18984 CLSCompliantAttribute.
18985 (all_imported_types): New member holds all imported types from other
18987 (LoadAllImportedTypes): New method fills static table with exported types
18988 from all referenced assemblies.
18989 (Modules): New property returns all assembly modules.
18991 2004-03-30 Miguel de Icaza <miguel@ximian.com>
18993 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
18994 throwing a parser error.
18996 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
18997 which removes the hardcoded get_/set_ prefixes for properties, as
18998 IL allows for the properties to be named something else.
19002 * expression.cs: Do not override operand before we know if it is
19003 non-null. Fix 56207
19005 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19007 * typemanager.cs: support for pinned variables.
19009 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19011 * decl.cs, typemanager.cs: Avoid using an arraylist
19012 as a buffer if there is only one result set.
19014 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19016 * expression.cs: Make sure you cant call a static method
19017 with an instance expression, bug #56174.
19019 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19021 * class.cs (IsDuplicateImplementation): Improve error reporting to
19022 flag 663 (method only differs in parameter modifier).
19024 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19025 in preprocessor directives.
19027 * location.cs (LookupFile): Allow for the empty path.
19029 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19030 better approach for some of that patch, but its failing with the
19031 CharSet enumeration. For now try/catch will do.
19033 * typemanager.cs: Do not crash if a struct does not have fields.
19036 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19038 * expression.cs: cs0213, cant fix a fixed expression.
19041 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19043 * cs-parser.jay: detect invalid embeded statements gracefully.
19046 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19048 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19051 the invocation type may not be a subclass of the tye of the item/
19052 The type of the item must be a subclass of the invocation item.
19057 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19059 * attribute.cs: Added methods to get a string and a bool from an
19060 attribute. Required to information from AssemblyKeyFileAttribute,
19061 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19062 * codegen.cs: Modified AssemblyName creation to include support for
19063 strongnames. Catch additional exceptions to report them as CS1548.
19064 * compiler.csproj: Updated include CryptoConvert.cs.
19065 * compiler.csproj.user: Removed file - user specific configuration.
19066 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19067 Mono.Security assembly. The original class is maintained and tested in
19068 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19069 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19070 like CSC 8.0 (C# v2) supports.
19071 * Makefile: Added CryptoConvert.cs to mcs sources.
19072 * rootcontext.cs: Added new options for strongnames.
19074 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19076 * driver.cs: For --expect-error, report error code `2'
19077 if the program compiled with no errors, error code `1' if
19078 it compiled with an error other than the one expected.
19080 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19082 * compiler.csproj: Updated for Visual Studio .NET 2003.
19083 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19084 * compiler.sln: Updated for Visual Studio .NET 2003.
19086 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19088 * expression.cs: Fix bug #47234. We basically need to apply the
19089 rule that we prefer the conversion of null to a reference type
19090 when faced with a conversion to 'object' (csc behaviour).
19092 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19094 * statement.cs: Shorter form for foreach, eliminates
19095 a local variable. r=Martin.
19097 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19099 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19100 checks if we can use brtrue/brfalse to test for 0.
19101 * expression.cs: use the above in the test for using brtrue/brfalse.
19102 cleanup code a bit.
19104 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19106 * expression.cs: Rewrite string concat stuff. Benefits:
19108 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19109 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19110 rather than a concat chain.
19112 * typemanager.cs: Add lookups for more concat overloads.
19114 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19116 * expression.cs: Emit shorter il code for array init.
19133 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19135 * statement.cs: Before, two switch blocks would be merged if the
19136 total size of the blocks (end_item - begin_item + 1) was less than
19137 two times the combined sizes of the blocks.
19139 Now, it will only merge if after the merge at least half of the
19144 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19146 * class.cs : csc build fix for GetMethods(). See bug #52503.
19148 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19150 * expression.cs: Make sure fp comparisons work with NaN.
19151 This fixes bug #54303. Mig approved this patch a long
19152 time ago, but we were not able to test b/c the runtime
19155 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19157 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19159 2004-03-19 Martin Baulig <martin@ximian.com>
19161 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19162 error here and not in our caller.
19164 2004-03-19 Martin Baulig <martin@ximian.com>
19166 * interface.cs: Completely killed this file.
19167 (Interface): We're now a TypeContainer and live in class.cs.
19169 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19170 argument; we're now also called for interfaces.
19171 (TypeContainer.DefineMembers): Allow this method being called
19173 (TypeContainer.GetMethods): New public method; formerly known as
19174 Interface.GetMethod(). This is used by PendingImplementation.
19175 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19176 it's now private and non-static.
19177 (Interface): Moved this here; it's now implemented similar to
19179 (Method, Property, Event, Indexer): Added `bool is_interface'
19180 argument to their .ctor's.
19181 (MemberBase.IsInterface): New public field.
19183 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19184 instances instead of InterfaceMethod, InterfaceProperty, etc.
19185 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19186 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19188 2004-03-19 Martin Baulig <martin@ximian.com>
19190 * class.cs (MethodCore.IsDuplicateImplementation): New private
19191 method which does the CS0111 checking.
19192 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19193 Use IsDuplicateImplementation().
19195 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19197 * decl.cs (FindMemberToOverride): New method to find the correct
19198 method or property to override in the base class.
19200 - Make Method/Property use the above method to find the
19201 version in the base class.
19202 - Remove the InheritableMemberSignatureCompare as it is now
19205 This patch makes large code bases much faster to compile, as it is
19206 O(n) rather than O(n^2) to do this validation.
19208 Also, it fixes bug 52458 which is that nested classes are not
19209 taken into account when finding the base class member.
19211 Reviewed/Approved by Martin.
19213 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19215 * interface.cs: In all interface classes removed redundant
19216 member initialization.
19218 2004-03-16 Martin Baulig <martin@ximian.com>
19220 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19222 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19224 * decl.cs (DefineTypeAndParents): New helper method to define a
19225 type's containers before the type itself is defined; This is a
19226 bug exposed by the recent changes to Windows.Forms when an
19227 implemented interface was defined inside a class that had not been
19230 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19232 (Check): Loop correctly to report errors modifiers
19233 (UNSAFE was not in the loop, since it was the same as TOP).
19235 * interface.cs: Every interface member now takes a ModFlags,
19236 instead of a "is_new" bool, which we set on the base MemberCore.
19238 Every place where we called "UnsafeOk" in the interface, now we
19239 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19240 the unsafe settings from the member declaration instead of the
19241 container interface.
19243 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19245 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19246 `set_indexer_name' to the pending bits (one per type).
19248 We fixed a bug today that was picking the wrong method to
19249 override, since for properties the existing InterfaceMethod code
19250 basically ignored the method name. Now we make sure that the
19251 method name is one of the valid indexer names.
19253 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19255 * support.cs (SeekableStreamReader): Keep track of stream byte
19256 positions and don't mix them with character offsets to the buffer.
19258 Patch from Gustavo Giráldez
19260 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19262 * interface.cs (InterfaceSetGetBase): Removed double member
19263 initialization, base class does it as well.
19265 2004-03-13 Martin Baulig <martin@ximian.com>
19267 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19268 when compiling corlib.
19270 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19272 * convert.cs (ExplicitConversion): We were reporting an error on
19273 certain conversions (object_type source to a value type, when the
19274 expression was `null') before we had a chance to pass it through
19275 the user defined conversions.
19277 * driver.cs: Replace / and \ in resource specifications to dots.
19280 * class.cs: Add check for duplicate operators. Fixes 52477
19282 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19284 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19285 that are in the middle of the statements, not only at the end.
19288 * class.cs (TypeContainer.AddField): No longer set the
19289 `HaveStaticConstructor' flag, now we call it
19290 `UserDefineStaticConstructor' to diferentiate the slightly
19291 semantic difference.
19293 The situation is that we were not adding BeforeFieldInit (from
19294 Modifiers.TypeAttr) to classes that could have it.
19295 BeforeFieldInit should be set to classes that have no static
19300 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19302 And most importantly Zoltan's comment:
19304 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19306 "I think beforefieldinit means 'it's ok to initialize the type sometime
19307 before its static fields are used', i.e. initialization does not need
19308 to be triggered by the first access to the type. Setting this flag
19309 helps the JIT to compile better code, since it can run the static
19310 constructor at JIT time, and does not need to generate code to call it
19311 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19312 this flag for lots of classes like String.
19314 csc sets this flag if the type does not have an explicit static
19315 constructor. The reasoning seems to be that if there are only static
19316 initalizers for a type, and no static constructor, then the programmer
19317 does not care when this initialization happens, so beforefieldinit
19320 This bug prevents the AOT compiler from being usable, since it
19321 generates so many calls to mono_runtime_class_init that the AOT code
19322 is much slower than the JITted code. The JITted code is faster,
19323 because it does not generate these calls if the vtable is type is
19324 already initialized, which is true in the majority of cases. But the
19325 AOT compiler can't do this."
19327 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19329 * class.cs (MethodData.Emit): Refactor the code so symbolic
19330 information is generated for destructors; For some reasons we
19331 were taking a code path that did not generate symbolic information
19334 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19336 * class.cs: Create a Constructor.CheckBase method that
19337 takes care of all validation type code. The method
19338 contains some code that was moved from Define.
19340 It also includes new code that checks for duplicate ctors.
19341 This fixes bug #55148.
19343 2004-03-09 Joshua Tauberer <tauberer@for.net>
19345 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19346 a { ... }-style array creation invokes EmitStaticInitializers
19347 which is not good for reference-type arrays. String, decimal
19348 and now null constants (NullCast) are not counted toward
19349 static initializers.
19351 2004-03-05 Martin Baulig <martin@ximian.com>
19353 * location.cs (SourceFile.HasLineDirective): New public field;
19354 specifies whether the file contains or is referenced by a "#line"
19356 (Location.DefineSymbolDocuments): Ignore source files which
19357 either contain or are referenced by a "#line" directive.
19359 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19361 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19362 direct access to our parent, so check the method inline there.
19364 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19366 * expression.cs (Invocation.EmitCall): Miguel's last commit
19367 caused a regression. If you had:
19372 In Foo the implict this would be null.
19374 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19376 * expression.cs (Invocation.EmitCall): If the method is not
19377 virtual, do not emit a CallVirt to it, use Call.
19379 * typemanager.cs (GetFullNameSignature): Improve the method to
19380 cope with ".ctor" and replace it with the type name.
19382 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19383 as an argument the ConstructorBuilder where it is being defined,
19384 to catch the recursive constructor invocations.
19386 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19388 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19389 routines to check if a type is an enumerable/enumerator allow
19390 classes that implement the IEnumerable or IEnumerator interfaces.
19392 * class.cs (Property, Operator): Implement IIteratorContainer, and
19393 implement SetYields.
19395 (Property.Define): Do the block swapping for get_methods in the
19396 context of iterators. We need to check if Properties also
19397 include indexers or not.
19399 (Operator): Assign the Block before invoking the
19400 OperatorMethod.Define, so we can trigger the Iterator code
19403 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19404 Property and Operator classes are not created when we parse the
19405 declarator but until we have the block completed, so we use a
19406 singleton SimpleIteratorContainer.Simple to flag whether the
19407 SetYields has been invoked.
19409 We propagate this setting then to the Property or the Operator to
19410 allow the `yield' to function.
19412 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19414 * codegen.cs: Implemented attribute support for modules.
19415 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19416 Assembly/Module functionality.
19418 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19419 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19420 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19422 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19424 * interface.cs (FindMembers): The operation is performed on all base
19425 interfaces and not only on the first. It is required for future CLS Compliance patch.
19427 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19429 * statement.cs, codegen.cs:
19430 This patch deals with patterns such as:
19432 public class List : IEnumerable {
19434 public MyEnumerator GetEnumerator () {
19435 return new MyEnumerator(this);
19438 IEnumerator IEnumerable.GetEnumerator () {
19442 public struct MyEnumerator : IEnumerator {
19447 Before, there were a few things we did wrong:
19448 1) we would emit callvirt on a struct, which is illegal
19449 2) we emited ldarg when we needed to emit ldarga
19450 3) we would mistakenly call the interface methods on an enumerator
19451 type that derived from IEnumerator and was in another assembly. For example:
19453 public class MyEnumerator : IEnumerator
19455 Would have the interface methods called, even if there were public impls of the
19456 method. In a struct, this lead to invalid IL code.
19458 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19460 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19463 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19465 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19467 * cs-parser.jay: Fix small regression: we were not testing V2
19468 compiler features correctly.
19470 * interface.cs: If the emit context is null, then create one
19472 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19474 * decl.cs (GetSignatureForError): New virtual method to get full name
19475 for error messages.
19477 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19478 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19480 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19481 Duplicated members and code in these classes has been removed.
19482 Better encapsulation in these classes.
19484 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19486 * assign.cs (Assign.DoResolve): When dealing with compound
19487 assignments, there is a new rule in ECMA C# 2.4 (might have been
19488 there before, but it is documented here) that states that in:
19492 If b is of type int, and the `op' is a shift-operator, then the
19493 above is evaluated as:
19497 * expression.cs (Binary.ResolveOperator): Instead of testing for
19498 int/uint/long/ulong, try to implicitly convert to any of those
19499 types and use that in pointer arithmetic.
19501 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19502 method to print information for from the type, not from the
19503 null-method we were given.
19505 2004-02-01 Duncan Mak <duncan@ximian.com>
19507 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19508 parsing for cmd, fixes bug #53694.
19510 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19512 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19513 in the member name duplication tests. Property and operator name duplication
19514 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19516 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19518 * interface.cs (PopulateMethod): Fixed crash when interface method
19519 returns not existing type (error test cs0246-3.cs).
19521 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19523 * cs-parser.jay (interface_accessors): Re-write actions to also
19524 store attributes attached to get and set methods. Fix spelling
19527 (inteface_property_declaration): Modify accordingly.
19529 (InterfaceAccessorInfo): New helper class to store information to pass
19530 around between rules that use interface_accessors.
19532 * interface.cs (Emit): Apply attributes on the get and set
19533 accessors of properties and indexers too.
19535 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19536 right MethodBuilder when applying attributes to the get and set accessors.
19538 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19540 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19542 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19544 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19546 2004-01-25 Miguel de Icaza <miguel@ximian.com>
19548 * cs-parser.jay: Remove YIELD token, instead use the new grammar
19549 changes that treat `yield' specially when present before `break'
19550 or `return' tokens.
19552 * cs-tokenizer.cs: yield is no longer a keyword.
19554 2004-01-23 Marek Safar <marek.safar@seznam.cz>
19556 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
19557 setting for default constructors.
19558 For default constructors are almost every time set wrong Modifier. The
19559 generated IL code has been alright. But inside mcs this values was
19560 wrong and this was reason why several of my CLS Compliance tests
19563 2004-01-22 Martin Baulig <martin@ximian.com>
19565 * cs-parser.jay (namespace_or_type_name): Return an Expression,
19566 not a QualifiedIdentifier. This is what `type_name_expression'
19567 was previously doing.
19568 (type_name_expression): Removed; the code is now in
19569 `namespace_or_type_name'.
19570 (qualified_identifier): Removed, use `namespace_or_type_name'
19572 (QualifiedIdentifier): Removed this class.
19574 2004-01-22 Martin Baulig <martin@ximian.com>
19576 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
19577 not a string as alias name.
19579 2004-01-21 Miguel de Icaza <miguel@ximian.com>
19581 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
19582 #52730 bug, and instead compute correctly the need to use a
19583 temporary variable when requesting an address based on the
19584 static/instace modified of the field and the constructor.
19586 2004-01-21 Martin Baulig <martin@ximian.com>
19588 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
19589 class and namespace before looking up aliases. Fixes #52517.
19591 2004-01-21 Martin Baulig <martin@ximian.com>
19593 * flowanalysis.cs (UsageVector.Merge): Allow variables being
19594 assinged in a 'try'; fixes exception4.cs.
19596 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19597 * class.cs : Implemented parameter-less constructor for TypeContainer
19599 * decl.cs: Attributes are now stored here. New property OptAttributes
19601 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
19603 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
19605 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19607 * typemanager.cs (CSharpSignature): Now reports also inner class name.
19608 (CSharpSignature): New method for indexer and property signature.
19610 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19612 * pending.cs (IsVirtualFilter): Faster implementation.
19614 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19616 * typemanager.cs: Avoid inclusion of same assembly more than once.
19618 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19620 * cs-parser.jay: Fixed problem where the last assembly attribute
19621 has been applied also to following declaration (class, struct, etc.)
19623 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19625 * class.cs: Added error CS0538, CS0539 reporting.
19626 Fixed crash on Microsoft runtime when field type is void.
19628 * cs-parser.jay: Added error CS0537 reporting.
19630 * pending.cs: Added error CS0535 reporting.
19631 Improved error report for errors CS0536, CS0534.
19633 2004-01-20 Miguel de Icaza <miguel@ximian.com>
19635 Merge a few bits from the Anonymous Method MCS tree.
19637 * statement.cs (ToplevelBlock): New class for toplevel methods,
19638 will hold anonymous methods, lifted variables.
19640 * cs-parser.jay: Create toplevel blocks for delegates and for
19641 regular blocks of code.
19643 2004-01-20 Martin Baulig <martin@ximian.com>
19645 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
19646 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
19647 and `NeedExplicitReturn'; added `IsLastStatement'.
19648 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
19649 have a `ReturnLabel' or we're not unreachable.
19651 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
19652 child's reachability; don't just override ours with it. Fixes
19653 #58058 (lluis's example).
19654 (FlowBranching): Added public InTryOrCatch(), InCatch(),
19655 InFinally(), InLoop(), InSwitch() and
19656 BreakCrossesTryCatchBoundary() methods.
19658 * statement.cs (Return): Do all error checking in Resolve().
19659 Unless we are the last statement in a top-level block, always
19660 create a return label and jump to it.
19661 (Break, Continue): Do all error checking in Resolve(); also make
19662 sure we aren't leaving a `finally'.
19663 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
19664 statement in a top-level block.
19665 (Block.Flags): Added `IsDestructor'.
19666 (Block.IsDestructor): New public property.
19668 2004-01-20 Martin Baulig <martin@ximian.com>
19670 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
19672 2004-01-20 Martin Baulig <martin@ximian.com>
19674 * statement.cs (Statement.ResolveUnreachable): New public method.
19675 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
19676 (Block.Resolve): Resolve unreachable statements.
19678 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19680 * expression.cs: We need to fix the case where we do
19681 not have a temp variable here.
19683 * assign.cs: Only expression compound assignments need
19684 temporary variables.
19686 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19688 * flowanalysis.cs: Reduce memory allocation in a few ways:
19689 - A block with no variables should not allocate a bit
19691 - A method with no out parameters does not need any tracking
19692 for assignment of the parameters, so we need not allocate
19695 public readonly Type[] VariableTypes;
19696 public readonly string[] VariableNames;
19697 Are redundant. The data is already stored in the variable
19698 map, so we need not allocate another array for it.
19699 - We need to add alot of checks for if (params | locals) == null
19700 due to the first two changes.
19702 2004-01-18 Miguel de Icaza <miguel@ximian.com>
19704 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
19705 implement IMemoryLocation, we store a copy on a local variable and
19706 take the address of it. Patch from Benjamin Jemlich
19708 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
19709 to use a special "type_name_expression" rule which reduces the
19710 number of "QualifiedIdentifier" classes created, and instead
19711 directly creates MemberAccess expressions.
19713 2004-01-17 Miguel de Icaza <miguel@ximian.com>
19715 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
19716 that fixes #52853. Null literal assignment to ValueType
19718 * class.cs (MethodData.Emit): Instead of checking the name of the
19719 method to determine if its a destructor, create a new derived
19720 class from Method called Destructor, and test for that.
19722 * cs-parser.jay: Create a Destructor object instead of a Method.
19724 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
19728 2004-01-16 Miguel de Icaza <miguel@ximian.com>
19730 * expression.cs (Binary.ResolveOperator): Perform an implicit
19731 conversion from MethodGroups to their delegate types on the
19732 Addition operation.
19734 * delegate.cs: Introduce a new class DelegateCreation that is the
19735 base class for `NewDelegate' and `ImplicitDelegateCreation',
19736 factor some code in here.
19738 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
19739 conversion from MethodGroups to compatible delegate types.
19741 * ecore.cs (Expression.Resolve): Do not flag error 654
19742 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
19743 we allow conversions from MethodGroups to delegate types now.
19745 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
19746 assignments in v2 either.
19748 2004-01-10 Miguel de Icaza <miguel@ximian.com>
19750 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
19751 static read-only fields in ctors.
19753 Applied patch from Benjamin Jemlich
19755 * expression.cs (UnaryMutator): Avoid leaking local variables.
19757 2004-01-09 Miguel de Icaza <miguel@ximian.com>
19759 * cs-tokenizer.cs (IsCastToken): Allow the various native types
19760 here to return true, as they can be used like this:
19762 (XXX) int.MEMBER ()
19764 Fixed 49836 and all the other dups
19766 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
19768 * driver.cs: Implement /win32res and /win32icon.
19770 2004-01-08 Miguel de Icaza <miguel@ximian.com>
19772 * cs-parser.jay: Add a rule to improve error handling for the
19773 common mistake of placing modifiers after the type.
19775 2004-01-07 Miguel de Icaza <miguel@ximian.com>
19777 * cs-parser.jay (interface_event_declaration): Catch
19778 initialization of events on interfaces, and report cs0068
19780 * cs-parser.jay (interface_event_declaration): Catch
19781 initialization of events.
19783 * ecore.cs: Better report missing constructors.
19785 * expression.cs (Binary.ResolveOperator): My previous bug fix had
19786 the error reporting done in the wrong place. Fix.
19788 * expression.cs (Binary.ResolveOperator): Catch the
19789 operator + (E x, E y) error earlier, and later allow for implicit
19790 conversions in operator +/- (E e, U x) from U to the underlying
19793 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
19794 52596, if the container class is abstract, the default constructor
19795 is protected otherwise its public (before, we were always public).
19797 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
19800 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
19801 Jemlich that fixes bug #52597, MCS was generating invalid code for
19802 idisposable structs. Thanks to Ben for following up with this
19805 2004-01-06 Miguel de Icaza <miguel@ximian.com>
19807 * driver.cs: Allow assemblies without code to be generated, fixes
19810 2004-01-07 Nick Drochak <ndrochak@gol.com>
19812 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
19814 2004-01-05 Miguel de Icaza <miguel@ximian.com>
19816 * cs-parser.jay: Add rules to improve error reporting if fields or
19817 methods are declared at the namespace level (error 116)
19819 * Add rules to catch event add/remove
19821 2004-01-04 David Sheldon <dave-mono@earth.li>
19823 * expression.cs: Added matching ")" to error message for
19826 2004-01-03 Todd Berman <tberman@gentoo.org>
19828 * ecore.cs, attribute.cs:
19829 Applying fix from #52429.
19831 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19833 * ecore.cs, expression.cs, statement.cs:
19834 Total rewrite of how we handle branching. We
19835 now handle complex boolean expressions with fewer
19836 jumps. As well if (x == 0) no longer emits a ceq.
19838 if (x is Foo) is much faster now, because we generate
19841 Overall, we get a pretty big improvement on our benchmark
19842 tests. The code we generate is smaller and more readable.
19844 I did a full two-stage bootstrap. The patch was reviewed
19845 by Martin and Miguel.
19847 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19849 * cs-parser.jay: Make primary_expression not take a QI.
19850 we dont need this because the member_access rule covers
19851 us here. So we replace the rule with just IDENTIFIER.
19853 This has two good effects. First, we remove a s/r conflict.
19854 Second, we allocate many fewer QualifiedIdentifier objects.
19856 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19858 * attribute.cs: Handle MarshalAs attributes as pseudo, and
19859 set the correct information via SRE. This prevents
19860 hanging on the MS runtime. Fixes #29374.
19862 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19864 * convert.cs: correctly handle conversions to value types
19865 from Enum and ValueType as unboxing conversions.
19867 Fixes bug #52569. Patch by Benjamin Jemlich.
19869 2004-01-02 Ravi Pratap <ravi@ximian.com>
19871 * expression.cs (BetterConversion): Prefer int -> uint
19872 over int -> ulong (csc's behaviour). This fixed bug #52046.
19874 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
19876 * decl.cs (MemberCache.FindMembers): now returns a
19879 * typemanager.cs: In general, go with with ^^.
19880 (CopyNewMethods): take an IList.
19881 (RealMemberLookup): Only allocate an arraylist
19882 if we copy from two sets of methods.
19884 This change basically does two things:
19885 1) Fewer array lists allocated due to CopyNewMethods.
19886 2) the explicit cast in MemberList costed ALOT.
19888 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
19890 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
19891 a hashtable to avoid needless string allocations when an identifier is
19892 used more than once (the common case).
19894 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19896 * pending.cs: MS's TypeBuilder.GetInterfaces ()
19897 is broken, it will not return anything. So, we
19898 have to use the information we have in mcs to
19901 * typemanager.cs: Add a cache for GetInterfaces,
19902 since this will now be used more often (due to ^^)
19904 (GetExplicitInterfaces) New method that gets the
19905 declared, not effective, interfaces on a type
19906 builder (eg, if you have interface IFoo, interface
19907 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
19910 This patch makes MCS able to bootstrap itself on
19913 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19915 * expression.cs: Remove the Nop's that Miguel put
19918 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19920 * report.cs, codegen.cs: Give the real stack trace to
19921 the error when an exception is thrown.
19923 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19925 * decl.cs: only allocate hashtables for ifaces if
19928 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19930 * expression.cs: fix the error from cs0121-2.cs
19931 (a parent interface has two child interfaces that
19932 have a function with the same name and 0 params
19933 and the function is called through the parent).
19935 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
19937 * class.cs, rootcontext.cs, typmanager.cs: do not
19940 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
19942 * codegen.cs: remove stack for the ec flow branching.
19943 It is already a linked list, so no need.
19945 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
19947 * Makefile: Allow custom profiler here.
19949 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19951 * typemanager.cs (LookupType):
19952 - Use a static char [], because split takes
19953 a param array for args, so it was allocating
19955 - Do not store true in a hashtable, it boxes.
19957 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19959 * flowanalysis.cs: bytify common enums.
19961 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19963 * modifiers.cs: Add a new set of flags for the
19964 flags allowed on explicit interface impls.
19965 * cs-parser.jay: catch the use of modifiers in
19966 interfaces correctly.
19967 * class.cs: catch private void IFoo.Blah ().
19969 All related to bug #50572.
19971 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19973 * decl.cs: Rewrite the consistant accessability checking.
19974 Accessability is not linear, it must be implemented in
19975 a tableish way. Fixes #49704.
19977 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19979 * expression.cs: Handle negation in a checked context.
19980 We must use subtraction from zero. Fixes #38674.
19982 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
19984 * class.cs: Ignore static void main in DLLs.
19985 * rootcontext.cs: Handle the target type here,
19986 since we are have to access it from class.cs
19987 * driver.cs: account for the above.
19989 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
19991 * report.cs: Give line numbers and files if available.
19993 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
19995 * driver.cs: Implement /addmodule.
19997 * typemanager.cs: Change 'modules' field so it now contains Modules not
20000 2003-12-20 Martin Baulig <martin@ximian.com>
20002 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20003 (FieldBase.IsAssigned): Removed this field.
20004 (FieldBase.SetAssigned): New public method.
20005 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20007 2003-12-20 Martin Baulig <martin@ximian.com>
20009 * expression.cs (LocalVariableReference.DoResolve): Don't set
20010 `vi.Used' if we're called from DoResolveLValue().
20012 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20013 returns the usage vector it just merged into the current one -
20014 pass this one to UsageWarning().
20015 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20016 of the `EmitContext', don't call this recursively on our children.
20018 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20020 * driver.cs: Implement /target:module.
20022 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20024 * support.cs (CharArrayHashtable): New helper class.
20026 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20027 char arrays, not strings, so we can avoid creating a string in
20028 consume_identifier if the identifier is a keyword.
20030 2003-12-16 Martin Baulig <martin@ximian.com>
20032 * statement.cs (LocalInfo.Assigned): Removed this property.
20033 (LocalInfo.Flags): Removed `Assigned'.
20034 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20035 and uses flow analysis.
20036 (Block.UsageWarning): Made this method private.
20037 (Block.Resolve): Call UsageWarning() if appropriate.
20039 * expression.cs (LocalVariableReference.DoResolve): Always set
20040 LocalInfo.Used here.
20042 2003-12-13 Martin Baulig <martin@ximian.com>
20044 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20045 any value here; we're now using flow analysis to figure out
20046 whether a statement/block returns a value.
20048 2003-12-13 Martin Baulig <martin@ximian.com>
20050 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20052 (FlowBranching.MergeFinally): Don't call
20053 `branching.CheckOutParameters()' here, this is called in
20055 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20056 when adding the `finally' vector.
20058 2003-12-13 Martin Baulig <martin@ximian.com>
20061 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20062 actually work and also fix #48962.
20064 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20066 * decl.cs: Do not check System.Object for nested types,
20067 since we know it does not have any. Big bang for buck:
20070 Run 1: 8.35 seconds
20071 Run 2: 8.32 seconds
20072 corlib: 17.99 seconds
20074 Run 1: 8.17 seconds
20075 Run 2: 8.17 seconds
20076 corlib: 17.39 seconds
20078 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20080 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20081 time we are returning 0 members, so we save alot here.
20083 2003-12-11 Martin Baulig <martin@ximian.com>
20085 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20086 `MergeChild()', also just take the `FlowBranching' as argument;
20087 call Merge() on it and return the result.
20088 (FlowBranching.Merge): We don't need to do anything if we just
20091 2003-12-11 Martin Baulig <martin@ximian.com>
20093 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20094 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20095 Maurer for this idea.
20097 2003-12-11 Martin Baulig <martin@ximian.com>
20099 * flowanalysis.cs (MergeResult): This class is now gone; we now
20100 use the `UsageVector' for this. The reason for this is that if a
20101 branching just has one sibling, we don't need to "merge" them at
20102 all - that's the next step to do.
20103 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20106 2003-12-11 Martin Baulig <martin@ximian.com>
20108 Reworked flow analyis and made it more precise and bug-free. The
20109 most important change is that we're now using a special `Reachability'
20110 class instead of having "magic" meanings of `FlowReturns'. I'll
20111 do some more cleanups and optimizations and also add some more
20112 documentation this week.
20114 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20115 largely reworked this class.
20116 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20117 the new `Reachability' class instead of having "magic" values here.
20118 (FlowBranching): We're now using an instance of `Reachability'
20119 instead of having separate `Returns', `Breaks' etc. fields.
20121 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20122 based on flow analysis; ignore the return value of block.Emit ().
20124 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20126 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20127 if they are private.
20129 2003-12-09 Martin Baulig <martin@ximian.com>
20131 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20132 call them directly on the UsageVector.
20134 2003-12-09 Martin Baulig <martin@ximian.com>
20136 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20137 Changed return type from `FlowReturns' to `Reachability'.
20139 2003-12-09 Martin Baulig <martin@ximian.com>
20141 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20142 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20143 `Reachable' fields with a single `Reachability' one.
20145 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20147 * class.cs (FindMembers): Remove foreach's.
20152 Run 1: 8.74 seconds
20153 Run 2: 8.71 seconds
20156 Run 1: 8.64 seconds
20157 Run 2: 8.58 seconds
20160 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20165 This patch does a few things:
20166 1. EmptyStatement is now a singleton, so it is never reallocated.
20167 2. All blah is EmptyStatement constructs have been changed to
20168 blah == EmptyStatement.Value, which is much faster and valid
20169 now that EmptyStatement is a singleton.
20170 3. When resolving a block, rather than allocating a new array for
20171 the non-empty statements, empty statements are replaced with
20172 EmptyStatement.Value
20173 4. Some recursive functions have been made non-recursive.
20174 Mainly the performance impact is from (3), however (1) and (2) are needed for
20175 this to work. (4) does not make a big difference in normal situations, however
20176 it makes the profile look saner.
20181 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20182 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20183 Total memory allocated: 56397 KB
20186 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20187 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20188 Total memory allocated: 55666 KB
20190 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20192 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20193 than the hashtable in a hashtable version
20195 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20196 we always end up concating a string. This results in a huge perf
20197 loss, because many strings have to be tracked by the GC. In this
20198 patch, we first use a hashtable that works with two keys, so that
20199 the strings do not need to be concat'ed.
20203 Run 1: 8.74 seconds
20204 Run 2: 8.71 seconds
20207 Run 1: 8.65 seconds
20208 Run 2: 8.56 seconds
20210 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20212 * Makefile: Add a new target `do-time' that does a quick and simple
20213 profile, leaving easy to parse output.
20215 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20217 * codegen.cs (Init): Create the dynamic assembly with
20218 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20220 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20222 * support.cs: Make the PtrHashtable use only one
20223 instance of its comparer.
20225 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20227 * typemanager.cs: Fix lookup of GetNamespaces.
20229 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20231 * expression.cs: Removed redundant line.
20233 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20234 ArrayLists, use for loops with bounds.
20236 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20239 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20240 arraylists, use for loop with bounds.
20242 The above three changes give us a 0.071 second performance
20243 improvement out of 3.294 seconds down to 3.223. On my machine
20244 the above changes reduced the memory usage by 1,387 KB during
20245 compiler bootstrap.
20247 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20248 QualifiedIdentifiers. Before we created a new string through
20249 concatenation, and mostly later on, the result would be
20250 manipulated by DecomposeQI through string manipulation.
20252 This reduced the compiler memory usage for bootstrapping from
20253 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20254 compile times in 0.05 seconds.
20256 2003-11-28 Dick Porter <dick@ximian.com>
20258 * support.cs: Do string compares with the Invariant culture.
20266 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20267 the comparison is done with the Invariant culture.
20269 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20271 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20272 GetEnumerator method.
20274 (ProbeCollectionType): Iterate starting at the most specific type
20275 upwards looking for a GetEnumerator
20277 * expression.cs: Shift count can be up to 31 for int/uint and 63
20280 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20282 * statement.cs (Block.LookupLabel): Also look for the label on the
20283 children blocks. Use a hash table to keep track of visited
20286 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20287 we actually did transform the other operand, otherwise fall back
20288 to the common codepath that casts to long.
20290 * cs-tokenizer.cs: Use the same code pattern as the int case.
20291 Maybe I should do the parsing myself, and avoid depending on the
20292 Parse routines to get this done.
20294 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20296 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20297 which fixes bug 51347. This time test it.
20299 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20300 attributes for example can not tell the difference between these.
20301 The difference was only a syntax feature of the language.
20303 * attribute.cs: Apply attributes to delegates.
20305 * delegate.cs: Call the apply attributes method.
20307 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20309 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20310 comparing 0 vs Byte.MinValue, not the value
20312 (ImplicitConversionRequired): When reporting a conversion error,
20313 use error 31 to print out the constant error instead of the
20316 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20317 which fixes bug 51347.
20319 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20321 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20322 which fixes the -warnaserror command line option.
20324 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20326 * cfold.cs (DoNumericPromotions): During constant folding of
20327 additions on UIntConstant, special case intconstants with
20328 IntConstants like we do on the expression binary operator.
20330 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20332 * convert.cs (ImplicitReferenceConversion): We were missing a case
20333 (System.Enum are not value types or class types, so we need to
20334 classify them separatedly).
20336 * driver.cs: We do not support error 2007.
20338 2003-11-12 Jackson Harper <jackson@ximian.com>
20340 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20341 system directory. Also use the full file name so users can
20342 libraries names mscorlib-o-tron.dll in a non system dir.
20344 2003-11-10 Martin Baulig <martin@ximian.com>
20346 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20347 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20348 calling `ResolveType()' on them, directly assign their `Type'.
20350 2003-11-08 Martin Baulig <martin@ximian.com>
20352 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20353 return value and the `out parent' parameter.
20354 (TypeContainer.DefineType): Moved the CS0644 check into
20355 GetClassBases(). Don't pass the interface types to the
20356 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20357 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20359 * ecore.cs (TypeExpr.IsAttribute): New property.
20360 (TypeExpr.GetInterfaces): New method.
20362 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20363 TypeExpr instead of a Type.
20364 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20365 (Interface.DefineType): Don't pass the interface types to the
20366 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20367 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20369 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20370 instead of a `Type[]'.
20371 (TypeManager.RegisterBuilder): Likewise.
20372 (TypeManager.AddUserInterface): Likewise.
20373 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20374 `Type[]' and also return a `TypeExpr[]'.
20375 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20377 2003-11-08 Martin Baulig <martin@ximian.com>
20379 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20382 2003-11-08 Martin Baulig <martin@ximian.com>
20384 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20385 TypeManager.ResolveExpressionTypes().
20387 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20388 instead of an Expression.
20389 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20390 (TypeExpression): New public class; formerly known as `TypeExpr'.
20392 * expression.cs (ComposedCast): Derive from TypeExpr.
20394 * typemanager.cs (TypeManager.system_*_expr): These are now
20395 TypExpr's instead of Expression's.
20396 (TypeManager.ResolveExpressionTypes): New public static function;
20397 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20400 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20402 * expression.cs (New.DoResolve): Do not dereference value that
20403 might be a null return.
20405 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20406 sure that the constant value has the right type. Fixes an
20407 unreported bug, similar to 50425.
20409 * const.cs (Const.LookupConstantValue): Call
20410 ImplicitStandardConversionExists before doing a conversion to
20411 avoid havng the TypeManager.ChangeType do conversions.
20413 Reduced the number of casts used
20415 (Const.ChangeType): New routine to enable reuse of the constant
20416 type changing code from statement.
20418 * typemanager.cs (ChangeType): Move common initialization to
20419 static global variables.
20423 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20424 every value type to go through, even if it was void. Fix that.
20426 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20427 character of the define, and the is_identifier_part_character for
20428 the rest of the string.
20430 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20432 * expression.cs (UnaryMutator.EmitCode): When I updated
20433 LocalVariableReference.DoResolve, I overdid it, and dropped an
20434 optimization done on local variable references.
20436 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20438 * ecore.cs: Convert the return from Ldlen into an int.
20440 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20442 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20443 the accessibility, this is a special case for toplevel non-public
20444 classes (internal for instance).
20446 2003-10-20 Nick Drochak <ndrochak@gol.com>
20448 * ecore.cs: Fix typo and build. Needed another right paren.
20450 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20452 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20453 `internal' case regular and protected, but not allowing protected
20454 to be evaluated later. Bug 49840
20456 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20458 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20459 to kb.Nlast, and not the kb.nFirst to isolate the switch
20462 Extract the underlying type, so enumerations of long/ulong are
20463 treated like long/ulong.
20465 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20467 * expression.cs (New): Overload the meaning of RequestedType to
20468 track the possible creation of the NewDelegate type, since
20469 DoResolve is invoked more than once for new constructors on field
20472 See bugs: #48800 and #37014
20474 * cs-parser.jay (declare_local_constants): Take an arraylist
20475 instead of a single constant.
20477 (local_constant_declaration): It should take a
20478 constant_declarators, not a constant_declarator. Fixes 49487
20480 * convert.cs: Fix error report.
20482 2003-10-13 Jackson Harper <jackson@ximian.com>
20484 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20487 2003-10-09 Martin Baulig <martin@ximian.com>
20489 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20491 (MethodCore.DoDefineParameters): Removed the TypeContainer
20492 argument; use the DeclSpace which was passed to the .ctor instead.
20493 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20494 TypeContainer; we only need a DeclSpace here.
20496 2003-10-09 Martin Baulig <martin@ximian.com>
20498 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20500 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20501 EmitContext's .ctor.
20503 2003-10-09 Martin Baulig <martin@ximian.com>
20505 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20506 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20507 AsAccessible(), moved them as well.
20509 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20511 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20513 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20515 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20517 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20518 generation for >=, as spotted by Paolo, bug 48679.
20519 Patch from David Waite.
20521 * cs-tokenizer.cs: Add handling for #pragma.
20523 * cs-parser.jay: Allow for both yield and yield return in the
20524 syntax. The anti-cobolization of C# fight will go on!
20526 * class.cs (TypeBuilder.DefineType): Catch error condition here
20527 (Parent.DefineType erroring out and returning null).
20529 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20530 coping with enumerations variables, we were mistakenly processing
20531 them as a regular value type instead of built-in types. Fixes the
20534 * typemanager.cs (IsBuiltinOrEnum): New method.
20536 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20538 * cs-parser.jay: Upgrade: yield now needs the return clause.
20540 2003-09-19 Martin Baulig <martin@ximian.com>
20542 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20543 `MemberCache parent' argument. Normally, an interface doesn't
20544 have a parent type except System.Object, but we use this in gmcs
20545 for generic type parameters.
20547 2003-09-18 Martin Baulig <martin@ximian.com>
20549 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
20550 on `type.IsInterface'; don't check whether the type has a parent
20551 to determine whether it's an interface.
20553 2003-09-15 Martin Baulig <martin@ximian.com>
20555 * class.cs (TypeContainer.DefineType): Added an error flag to
20556 avoid reporting duplicate CS0146's ("class definition is
20559 * driver.cs (Driver.MainDriver): Abort if
20560 RootContext.ResolveTree() reported any errors.
20562 2003-09-07 Martin Baulig <martin@ximian.com>
20564 * report.cs (Error, Warning): Added overloaded versions which take
20565 a `params object[] args' and call String.Format().
20567 2003-09-07 Martin Baulig <martin@ximian.com>
20569 * decl.cs (DeclSpace..ctor): Don't call
20570 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
20571 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
20572 (DeclSpace.RecordDecl): New method.
20574 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
20576 2003-09-02 Ravi Pratap <ravi@ximian.com>
20578 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
20579 value attributes to be applied to ParameterBuilders.
20581 * class.cs (MethodCore.LabelParameters): Make static and more
20582 generic so that it can be used from other places - like interface
20583 methods, for instance.
20585 * interface.cs (Interface.Emit): Call LabelParameters before
20586 emitting attributes on the InterfaceMethod.
20588 2003-08-26 Martin Baulig <martin@ximian.com>
20590 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
20591 resolving aliases; fixes #47927.
20593 2003-08-26 Martin Baulig <martin@ximian.com>
20595 * statement.cs (Using.DoResolve): This is internally emitting a
20596 try/finally clause, so we need to set ec.NeedExplicitReturn if we
20597 do not always return. Fixes #47681.
20599 2003-08-26 Martin Baulig <martin@ximian.com>
20601 * decl.cs (MemberCore): Moved WarningNotHiding(),
20602 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
20604 (AdditionResult): Make this nested in DeclSpace.
20605 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
20606 argument; call NamespaceEntry.Define() unless we're nested in a
20609 * namespace.cs (Namespace.DefineName): New public function. This
20610 is called from DeclSpace's .ctor to add
20611 (Namespace.Lookup): Include DeclSpaces in the lookup.
20613 * class.cs (Operator): Derive from MemberBase, not MemberCore.
20615 * const.cs (Const): Derive from MemberBase, not MemberCore.
20617 2003-08-25 Martin Baulig <martin@ximian.com>
20619 * convert.cs (Convert.ExplicitReferenceConversion): When
20620 converting from an interface type to a class, unbox if the target
20621 type is a struct type. Fixes #47822.
20623 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20625 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
20628 2003-08-22 Martin Baulig <martin@ximian.com>
20630 * class.cs (TypeManager.DefineType): When defining a nested type,
20631 call DefineType() on our parent; fixes #47801.
20633 2003-08-22 Martin Baulig <martin@ximian.com>
20635 * class.cs (MethodData.Define): While checking if a method is an
20636 interface implementation, improve the test a bit more to fix #47654.
20638 2003-08-22 Martin Baulig <martin@ximian.com>
20640 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
20641 correctly; fixes #47722.
20643 2003-08-22 Martin Baulig <martin@ximian.com>
20645 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
20646 LocalVariableReference, ensure it's not read-only. Fixes #47536.
20648 * statement.cs (Fixed.DoResolve): Make all variables read-only.
20650 2003-08-22 Martin Baulig <martin@ximian.com>
20652 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
20653 can only be assigned in static constructors. Fixes #47161.
20655 2003-08-22 Martin Baulig <martin@ximian.com>
20657 Rewrote and improved the flow analysis code.
20659 * flowbranching.cs (FlowBranching): Make this class abstract.
20660 (FlowBranching.CreateBranching): New static function to create a
20661 new flow branching.
20662 (FlowBranchingBlock, FlowBranchingException): New classes.
20663 (FlowBranching.UsageVector.Type): New public readonly field.
20664 (FlowBranching.UsageVector.Breaks): Removed the setter.
20665 (FlowBranching.UsageVector.Returns): Removed the setter.
20666 (FlowBranching.UsageVector): Added Break(), Return(),
20667 NeverReachable() and Throw() methods to modify the reachability.
20668 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
20669 done by FlowBranching.Merge().
20670 (FlowBranching.UsageVector.MergeChild): New method; merges the
20671 merge result into the current vector.
20672 (FlowBranching.Merge): New abstract method to merge a branching.
20674 2003-08-12 Martin Baulig <martin@ximian.com>
20676 * expression.cs (Indirection.CacheTemporaries): Create the
20677 LocalTemporary with the pointer type, not its element type.
20679 2003-08-10 Miguel de Icaza <miguel@ximian.com>
20681 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
20682 token was a keyword or not.
20684 Add `error' options where an IDENTIFIER was expected; Provide
20685 CheckToken and CheckIdentifierToken convenience error reporting
20688 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
20690 * decl.cs: Rename `NamespaceEntry Namespace' public field into
20691 NameSpaceEntry NameSpaceEntry.
20693 (LookupInterfaceOrClass): Avoid creating a full qualified name
20694 from namespace and name: avoid doing lookups when we know the
20695 namespace is non-existant. Use new Tree.LookupByNamespace which
20696 looks up DeclSpaces based on their namespace, name pair.
20698 * driver.cs: Provide a new `parser verbose' to display the
20699 exception thrown during parsing. This is turned off by default
20700 now, so the output of a failure from mcs is more graceful.
20702 * namespace.cs: Track all the namespaces defined in a hashtable
20705 (IsNamespace): New method
20707 2003-08-09 Miguel de Icaza <miguel@ximian.com>
20709 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
20710 we know that we need to concatenate (full typename can never be
20715 * statement.cs: Use a bitfield; Do not initialize to null things
20716 which are done by the constructor by default.
20718 * cs-parser.jay: bug fix, parameter was 4, not 3.
20720 * expression.cs: Just use the property;
20722 * statement.cs: No need for GetVariableInfo method.
20724 2003-08-08 Martin Baulig <martin@ximian.com>
20726 * flowanalysis.cs (FlowReturns): This is now nested in the
20727 `FlowBranching' class.
20728 (MyBitVector): Moved this here from statement.cs.
20729 (FlowBranching.SiblingType): New enum type.
20730 (FlowBranching.CreateSibling): Added `SiblingType' argument.
20732 2003-08-07 Martin Baulig <martin@ximian.com>
20734 * flowanalysis.cs (FlowBranchingType): This is now nested in the
20735 `FlowBranching' class and called `BranchingType'.
20737 2003-08-07 Martin Baulig <martin@ximian.com>
20739 * flowanalysis.cs: Moved all the control flow analysis code into
20742 2003-08-07 Martin Baulig <martin@ximian.com>
20744 * assign.cs (Assign.DoResolve): `target' must either be an
20745 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
20748 2003-08-07 Miguel de Icaza <miguel@ximian.com>
20750 * expression.cs (BinaryMethod): This kind of expression is created by the
20751 Binary class if it determines that the operator has to be handled
20754 (BinaryDelegate): This kind of expression is created if we are
20755 dealing with a + or - operator on delegates.
20757 (Binary): remove method, argumetns, and DelegateOperator: when
20758 dealing with methods,
20760 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
20762 * statement.cs (Block): use bitfields for the three extra booleans
20763 we had in use. Remove unused topblock parameter.
20765 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
20767 * assign.cs: Drop extra unneeded tests.
20769 2003-08-06 Miguel de Icaza <miguel@ximian.com>
20771 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
20773 * statement.cs (Foreach): Use VariableStorage instead of
20776 * codegen.cs (VariableStorage): New class used by clients that
20777 require a variable stored: locals or fields for variables that
20778 need to live across yield.
20780 Maybe provide a convenience api for EmitThis+EmitLoad?
20782 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
20785 2003-08-05 Miguel de Icaza <miguel@ximian.com>
20787 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
20788 RemapParameterLValue): New methods that are used to turn a
20789 precomputed FieldInfo into an expression like this:
20793 The idea is to use this instead of making LocalVariableReference
20794 have more than one meaning.
20796 * cs-parser.jay: Add error production to BASE.
20798 * ecore.cs: Deal with TypeManager.GetField returning null, which
20799 is now a valid return value.
20801 (FieldExprNoAddress): New expression for Fields whose address can
20804 * expression.cs (LocalVariableReference): During the resolve
20805 phases, create new expressions if we are in a remapping context.
20806 Remove code that dealt with remapping here.
20808 (ParameterReference): same.
20810 (ProxyInstance): New expression, like the `This' expression, but
20811 it is born fully resolved. We know what we are doing, so remove
20812 the errors that are targeted to user-provided uses of `this'.
20814 * statement.cs (Foreach): our variable is now stored as an
20815 Expression; During resolution, follow the protocol, dont just
20816 assume it will return this.
20818 2003-08-06 Martin Baulig <martin@ximian.com>
20820 * support.cs (SeekableStreamReader.cs): New public class.
20822 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
20823 SeekableStreamReader instead of the normal StreamReader.
20825 2003-08-04 Martin Baulig <martin@ximian.com>
20827 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
20828 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
20829 deambiguate casts and delegate invocations.
20830 (parenthesized_expression): Use the new tokens to ensure this is
20831 not a cast of method invocation.
20833 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
20834 when reading a `)' and Deambiguate_CloseParens () was previously
20837 * expression.cs (ParenthesizedExpression): New class. This is
20838 just used for the CS0075 test.
20839 (Binary.DoResolve): Check for CS0075.
20841 2003-07-29 Ravi Pratap <ravi@ximian.com>
20843 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
20844 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
20845 reference comparison.
20847 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
20848 examine the ReturnType for equality - this is necessary in the
20849 cases of implicit and explicit operators whose signature also
20850 includes the return type.
20852 2003-07-26 Miguel de Icaza <miguel@ximian.com>
20854 * namespace.cs: Cache the result of the namespace computation,
20855 instead of computing it every time.
20857 2003-07-24 Miguel de Icaza <miguel@ximian.com>
20859 * decl.cs: Use a global arraylist that we reuse over invocations
20860 to avoid excesive memory consumption. Reduces memory usage on an
20861 mcs compile by one meg (45 average).
20863 * typemanager.cs (LookupTypeReflection): In .NET pointers are
20864 private, work around that.
20866 2003-07-23 Miguel de Icaza <miguel@ximian.com>
20868 * literal.cs (IntLiteral): Define Zero and One static literals.
20870 * cs-parser.jay (integer_literal): use static literals to reduce
20871 memory usage for the most used literals (0, 1 and -1). 211kb
20872 reduced in memory usage.
20874 Replace all calls to `new ArrayList' with `new
20875 ArrayList(4)' which is a good average number for most allocations,
20876 and also requires only 16 bytes of memory for its buffer by
20879 This reduced MCS memory usage in seven megabytes for the RSS after
20882 2003-07-28 Ravi Pratap <ravi@ximian.com>
20884 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
20885 handle params methods the correct way by forming only one
20886 applicable set with params and normal methods in them. Earlier we
20887 were looking at params methods only if we found no normal methods
20888 which was not the correct thing to do.
20890 (Invocation.BetterFunction): Take separate arguments indicating
20891 when candidate and the best method are params methods in their
20894 This fixes bugs #43367 and #46199.
20896 * attribute.cs: Documentation updates.
20898 (CheckAttribute): Rename to CheckAttributeTarget.
20899 (GetValidPlaces): Rename to GetValidTargets.
20901 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
20902 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
20906 2003-07-28 Martin Baulig <martin@ximian.com>
20908 * class.cs (TypeContainer.DefineMembers): Use the base type's full
20909 name when looking up the base class of a nested class. Fixes #46977.
20911 2003-07-26 Martin Baulig <martin@ximian.com>
20913 * expression.cs (Indexers.Indexer): New nested struct; contains
20914 getter, setter and the indexer's type.
20915 (Indexers.Properties): This is now an ArrayList of
20916 Indexers.Indexer's.
20917 (IndexerAccess.DoResolveLValue): Correctly set the type if the
20918 indexer doesn't have any getters.
20920 * assign.cs (Assign.DoResolve): Also do the implicit conversions
20921 for embedded property and indexer assignments.
20923 2003-07-26 Martin Baulig <martin@ximian.com>
20925 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
20926 preprocessor directive is not the first non-whitespace character
20929 2003-07-26 Martin Baulig <martin@ximian.com>
20931 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
20932 namespace parsing, follow the spec more closely.
20934 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
20935 NamespaceEntry.Lookup().
20937 2003-07-25 Martin Baulig <martin@ximian.com>
20939 * MethodCore.cs (OverridesSomething): New public field; it's set
20940 from TypeContainer.DefineMembers if this method overrides
20941 something (which doesn't need to be a method). Fix #39462.
20943 2003-07-25 Ravi Pratap <ravi@ximian.com>
20945 * typemanager.cs (GetMembers): Ensure that the list of members is
20946 reversed. This keeps things in sync.
20948 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
20949 find an AttributeUsage attribute.
20951 * expression.cs (Invocation.OverloadResolve): Perform the check
20952 which disallows Invoke to be directly called on a Delegate.
20954 (Error_InvokeOnDelegate): Report error cs1533.
20956 2003-07-25 Martin Baulig <martin@ximian.com>
20958 * expression.cs (Indexers.GetIndexersForType): Only look in the
20959 interface hierarchy if the requested type is already an
20960 interface. Fixes #46788 while keeping #46502 fixed.
20962 2003-07-25 Martin Baulig <martin@ximian.com>
20964 * class.cs (TypeContainer.DefineMembers): Check whether all
20965 readonly fields have been assigned and report warning CS0649 if
20968 * statement.cs (LocalInfo.IsFixed): Always return true if this is
20971 2003-07-24 Ravi Pratap <ravi@ximian.com>
20973 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
20974 returned from GetMethods to make things consistent with the
20975 assumptions MCS makes about ordering of methods.
20977 This should comprehensively fix bug #45127 and it does :-)
20979 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
20980 ordering is actually reverse.
20982 * Clean up some debug messages I left lying around.
20984 * interface.cs (Populate*): Get rid of code which emits attributes
20985 since the stage in which we emit attributes is the 'Emit' stage,
20986 not the define stage.
20988 (Emit): Move attribute emission for interface members here.
20990 2003-07-22 Ravi Pratap <ravi@ximian.com>
20992 * expression.cs (Invocation.OverloadResolve): Follow the spec more
20993 closely: we eliminate methods in base types when we have an
20994 applicable method in a top-level type.
20996 Please see section 14.5.5.1 for an exact description of what goes
20999 This fixes bug #45127 and a host of other related to corlib compilation.
21001 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21002 array is the method corresponding to the top-level type (this is
21003 because of the changes made to icall.c) so we change this
21006 (MethodGroupExpr.Name): This too.
21008 * typemanager.cs (GetElementType): New method which does the right
21009 thing when compiling corlib.
21011 * everywhere: Make use of the above in the relevant places.
21013 2003-07-22 Martin Baulig <martin@ximian.com>
21015 * cs-parser.jay (invocation_expression): Moved
21016 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21017 `cast_expression', but create a InvocationOrCast which later
21018 resolves to either an Invocation or a Cast.
21020 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21021 method; call this before EmitStatement() to make sure that this
21022 expression can be used as a statement.
21024 * expression.cs (InvocationOrCast): New class; resolves to either
21025 an Invocation or a Cast.
21027 * statement.cs (StatementExpression): Call ResolveStatement() on
21028 the ExpressionStatement before emitting it.
21030 2003-07-21 Martin Baulig <martin@ximian.com>
21032 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21033 `ref' and `out' attributes match; fixes #46220.
21034 (MemberAccess.ResolveMemberAccess): You can't reference a type
21035 through an expression; fixes #33180.
21036 (Indexers.GetIndexersForType): Don't return the indexers from
21037 interfaces the class implements; fixes #46502.
21039 2003-07-21 Martin Baulig <martin@ximian.com>
21041 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21042 CS0661 checks; fixes bug #30442.
21044 2003-07-21 Martin Baulig <martin@ximian.com>
21046 * decl.cs (AdditionResult): Added `Error'.
21048 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21050 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21051 makes cs0031.cs actually work.
21053 2003-07-20 Martin Baulig <martin@ximian.com>
21055 * namespace.cs: Fixed that bug which caused a crash when compiling
21056 the debugger's GUI.
21058 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21060 * typemanager.cs (LookupTypeReflection): Never expose types which
21061 are NotPublic, NestedPrivate, NestedAssembly, or
21062 NestedFamANDAssem. We used to return these, and later do a check
21063 that would report a meaningful error, but the problem is that we
21064 would not get the real match, if there was a name override.
21066 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21068 * namespace.cs (Namespace, Name): Do not compute the namespace
21069 name dynamically, compute it in the constructor. This reduced
21070 memory usage by 1697 KB.
21072 * driver.cs: Use --pause to pause at the end.
21074 2003-07-17 Peter Williams <peter@newton.cx>
21076 * Makefile: Change the name of the test target so that it doesn't
21077 conflict with the recursive test target.
21079 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21081 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21082 AddressOf): Do not use EmitThis, that was wrong, use the actual
21085 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21087 * class.cs (MethodData.Define): While checking if a method is an
21088 interface implementation, improve the test: If we are not public
21089 (use new test here: use the computed MethodAttributes directly,
21090 instead of the parsed modifier flags) check if the `implementing'
21091 method comes from an interface or not.
21093 * pending.cs (VerifyPendingMethods): Slightly better error
21096 * makefile: add test target that does the mcs bootstrap.
21098 2003-07-16 Ravi Pratap <ravi@ximian.com>
21100 * interface.cs (Define): Do nothing here since there are no
21101 members to populate etc. Move the attribute emission out of here
21102 since this was just totally the wrong place to put it. Attribute
21103 application happens during the 'Emit' phase, not in the 'Define'
21106 (Emit): Add this method and move the attribute emission here
21108 * rootcontext.cs (EmitCode): Call the Emit method on interface
21111 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21113 * expression.cs (OverloadResolve): Report error only if Location
21114 is not 'Null' which means that there was a probe going on.
21116 2003-07-14 Martin Baulig <martin@ximian.com>
21118 * expression.cs (ConditionalLogicalOperator): New public class to
21119 implement user defined conditional logical operators.
21120 This is section 14.11.2 in the spec and bug #40505.
21122 2003-07-14 Martin Baulig <martin@ximian.com>
21124 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21126 2003-07-14 Martin Baulig <martin@ximian.com>
21128 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21130 * ecore.cs (IVariable.VerifyFixed): New interface method.
21132 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21133 operator, check whether the variable is actually fixed. Fixes bug
21134 #36055. Set a variable definitely assigned when taking its
21135 address as required by the spec.
21137 * statement.cs (LocalInfo.IsFixed): New field.
21138 (LocalInfo.MakePinned): Set `IsFixed' to true.
21140 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21142 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21143 for .ctors, ensure that we only ask for members declared in the
21144 attribute type (BindingFlags.DeclaredOnly).
21148 * expression.cs (Error_WrongNumArguments): Report error 1501
21149 correctly the way CSC does.
21151 2003-07-13 Martin Baulig <martin@ximian.com>
21153 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21154 lookup on the fully qualified name, to make things like "X.X" work
21155 where "X.X" is a fully qualified type name, but we also have a
21156 namespace "X" in the using list. Fixes #41975.
21158 2003-07-13 Martin Baulig <martin@ximian.com>
21160 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21161 function. If we're a CompoundAssign, we need to create an embedded
21162 CompoundAssign, not an embedded Assign.
21163 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21166 2003-07-13 Martin Baulig <martin@ximian.com>
21168 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21169 work to fix bug #46088.
21171 2003-07-13 Ravi Pratap <ravi@ximian.com>
21173 * class.cs (Operator.Emit): Do not emit attributes here - it is
21174 taken care of by the Method class that we delegate too. This takes
21175 care of bug #45876.
21177 2003-07-10 Martin Baulig <martin@ximian.com>
21179 * expression.cs (TypeOfVoid): New class.
21180 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21182 2003-07-10 Martin Baulig <martin@ximian.com>
21184 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21187 2003-07-10 Martin Baulig <martin@ximian.com>
21189 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21190 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21192 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21194 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21196 2003-07-10 Martin Baulig <martin@ximian.com>
21198 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21199 of decimal. Fixes #42850.
21201 NOTE: I also fixed the created byte blob, but this doesn't work on
21202 the MS runtime and csc never produces any byte blobs for decimal
21205 2003-07-10 Martin Baulig <martin@ximian.com>
21207 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21208 structs; fixes #32068.
21209 (Block.AddChildVariableNames): Fixed #44302.
21211 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21213 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21215 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21217 * attribute.cs: And this test is onger needed.
21219 2003-07-08 Martin Baulig <martin@ximian.com>
21221 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21222 inaccessible types. Fixes #36313.
21224 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21226 * namespace.cs (NamespaceEntry): Create implicit entries for all
21227 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21228 implicit entries for N1.N2 and N1.
21230 2003-07-08 Martin Baulig <martin@ximian.com>
21232 Rewrote the handling of namespaces to fix a lot of the issues
21233 wrt. `using' aliases etc.
21235 * namespace.cs (Namespace): Splitted this class into a
21236 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21238 * typemanager.cs (TypeManager.IsNamespace): Removed.
21239 (TypeManager.ComputeNamespaces): Only compute namespaces from
21240 loaded assemblies here, not the namespaces from the assembly we're
21241 currently compiling.
21243 2003-07-08 Martin Baulig <martin@ximian.com>
21245 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21247 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21249 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21252 I thought about the memory savings here, but LookupTypeReflection
21253 is used under already very constrained scenarios. Compiling
21254 corlib or mcs only exposes one hit, so it would not really reduce
21255 any memory consumption.
21257 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21259 * typemanager.cs: fixes bug #45889 by only adding public types from
21260 other assemblies to the list of known types.
21262 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21264 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21265 on the type we resolved.
21267 2003-07-05 Martin Baulig <martin@ximian.com>
21269 * pending.cs (PendingImplementation.ParentImplements): Don't
21270 create the proxy if the parent is abstract.
21272 * class.cs (TypeContainer.DefineIndexers): Process explicit
21273 interface implementations first. Fixes #37714.
21275 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21277 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21278 defined recursively; but since we modify the input parameters
21279 (left is set to `this' temporarily), we reset this value if the
21280 left_is_explicit is false, which gives the original semantics to
21283 * literal.cs (NullPointer): new class used to represent a null
21284 literal in a pointer context.
21286 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21287 type is a pointer, use a NullPointer object instead of a
21288 NullLiteral. Closes 43687
21290 (ExplicitConversion): Convert pointer values using
21291 the conv opcode to the proper type.
21293 * ecore.cs (New): change ValueTypeVariable property into a method,
21294 that returns whether the valuetype is suitable for being used.
21296 * expression.cs (Binary.DoNumericPromotions): Only return if we
21297 the int constant was a valid uint, and we can return both left and
21298 right as uints. If not, we continue processing, to trigger the
21299 type conversion. This fixes 39018.
21301 * statement.cs (Block.EmitMeta): During constant resolution, set
21302 the CurrentBlock property on the emitcontext, so that we resolve
21303 constants propertly.
21305 2003-07-02 Martin Baulig <martin@ximian.com>
21307 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21308 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21310 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21311 than emitting it here.
21313 * statement.cs: Fixed some more flow analysis bugs.
21315 2003-07-02 Martin Baulig <martin@ximian.com>
21317 * class.cs (MethodData.Define): When implementing interface
21318 methods, set Final unless we're Virtual.
21320 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21321 check work for interface methods.
21323 2003-07-01 Martin Baulig <martin@ximian.com>
21325 * ecore.cs (EmitContext.This): Replaced this property with a
21326 GetThis() method which takes a Location argument. This ensures
21327 that we get the correct error location for a CS0188.
21329 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21331 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21332 ImplicitStandardConversion.
21334 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21336 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21338 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21341 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21343 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21346 (MethodData.Define): Turn off initlocals for unsafe methods.
21348 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21350 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21351 complete; Fixes #37521.
21353 * delegate.cs: Use Modifiers.TypeAttr to compute the
21354 TypeAttributes, instead of rolling our own. This makes the flags
21355 correct for the delegates.
21357 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21359 * class.cs (Constructor.Define): Set the private flag for static
21360 constructors as well.
21362 * cs-parser.jay (statement_expression): Set the return value to
21363 null, to avoid a crash when we catch an error.
21365 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21367 * cs-parser.jay: Applied patch from Jackson that adds support for
21368 extern and unsafe modifiers to destructor declarations.
21370 * expression.cs: Report error 21 if the user is trying to index a
21373 * driver.cs: Add an error message, suggested by the bug report.
21375 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21376 if we do not have a ": this ()" constructor initializer. Fixes 45149
21378 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21380 * namespace.cs: Add some information to reduce FAQs.
21382 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21384 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21385 underlying enumeration types. Fixes #43915.
21387 * expression.cs: Treat ushort/short as legal values to be used in
21388 bitwise operations.
21390 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21392 * delegate.cs: transfer custom attributes for paramenters from
21393 the delegate declaration to Invoke and BeginInvoke.
21395 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21397 * attribute.cs: handle custom marshalers and emit marshal info
21400 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21402 * makefile.gnu: Added anonymous.cs to the compiler sources.
21404 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21406 * iterators.cs: Change the name of the proxy class to include two
21409 * cs-parser.jay: Update grammar to include anonymous methods.
21411 * anonymous.cs: new file.
21413 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21415 * class.cs (Field.Define): Add missing test for pointers and
21418 2003-05-27 Ravi Pratap <ravi@ximian.com>
21420 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21421 we use the stobj opcode.
21423 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21424 since it wasn't the correct fix.
21426 It still is puzzling that we are required to use stobj for IntPtr
21427 which seems to be a ValueType.
21429 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21431 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21432 during regular simple name resolution. Now, the trick is that
21433 instead of returning for processing the simplename, we do a
21434 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21435 contextual lookup type). If a match is found, return that, if
21436 not, return for further composition.
21438 This fixes long-standing 30485.
21440 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21441 using the address to initialize an object, do an Stobj instead of
21442 using the regular Stelem.
21444 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21445 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21446 Because if we are a BaseIndexerAccess that value will be true.
21449 * statement.cs (GotoCase.Resolve): Return after reporting an
21450 error, do not attempt to continue.
21452 * expression.cs (PointerArithmetic.Emit): If our operand is a
21453 long, convert our constants to match the operand before
21454 multiplying. Convert to I type before adding. Fixes 43670.
21456 2003-05-14 Ravi Pratap <ravi@ximian.com>
21458 * enum.cs (ImplicitConversionExists) : Rename to
21459 ImplicitEnumConversionExists to remove ambiguity.
21461 * ecore.cs (NullCast): New type of cast expression class which
21462 basically is very similar to EmptyCast with the difference being
21463 it still is a constant since it is used only to cast a null to
21465 (eg. (string) null)
21467 * convert.cs (ImplicitReferenceConversion): When casting a null
21468 literal, we return a NullCast.
21470 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21471 should be around anymore.
21473 The renaming (reported was slightly wrong). Corrections:
21475 ConvertImplicitStandard -> ImplicitConversionStandard
21476 ConvertExplicitStandard -> ExplicitConversionStandard
21478 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21479 before passing them in !
21481 * convert.cs (ImplicitConversionStandard): When comparing for
21482 equal expr and target types, ensure that expr is not a
21485 In general, we must not be checking (expr_type ==
21486 target_type) in the top level conversion methods
21487 (ImplicitConversion, ExplicitConversion etc). This checking is
21488 done in the methods that they delegate to.
21490 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21492 * convert.cs: Move Error_CannotConvertType,
21493 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21494 ImplicitNumericConversion, ImplicitConversionExists,
21495 ImplicitUserConversionExists, StandardConversionExists,
21496 FindMostEncompassedType, FindMostSpecificSource,
21497 FindMostSpecificTarget, ImplicitUserConversion,
21498 ExplicitUserConversion, GetConversionOperators,
21499 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21500 TryImplicitIntConversion, Error_CannotConvertImplicit,
21501 ConvertImplicitRequired, ConvertNumericExplicit,
21502 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21503 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21506 Perform the following renames:
21508 StandardConversionExists -> ImplicitStandardConversionExists
21509 ConvertImplicit -> ImplicitConversion
21510 ConvertImplicitStandard -> ImplicitStandardConversion
21511 TryImplicitIntConversion -> ImplicitIntConversion
21512 ConvertImplicitRequired -> ImplicitConversionRequired
21513 ConvertNumericExplicit -> ExplicitNumericConversion
21514 ConvertReferenceExplicit -> ExplicitReferenceConversion
21515 ConvertExplicit -> ExplicitConversion
21516 ConvertExplicitStandard -> ExplicitStandardConversion
21518 2003-05-19 Martin Baulig <martin@ximian.com>
21520 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21521 (TypeInfo): Added support for structs having structs as fields.
21523 * ecore.cs (FieldExpr): Implement IVariable.
21524 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21525 VariableInfo for the field.
21527 2003-05-18 Martin Baulig <martin@ximian.com>
21529 * expression.cs (This.DoResolve): Report a CS0027 if we're
21530 emitting a field initializer.
21532 2003-05-18 Martin Baulig <martin@ximian.com>
21534 * expression.cs (This.ResolveBase): New public function.
21535 (This.DoResolve): Check for CS0188.
21537 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21540 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21541 `instance_expression' to null if we don't have any non-static
21544 2003-05-18 Martin Baulig <martin@ximian.com>
21546 Reworked the way how local variables and parameters are handled by
21547 the flow analysis code.
21549 * statement.cs (TypeInfo, VariableMap): New public classes.
21550 (VariableInfo): New public class. This is now responsible for
21551 checking whether a variable has been assigned. It is used for
21552 parameters and local variables.
21553 (Block.EmitMeta): Take the InternalParameters as argument; compute
21554 the layout of the flow vectors here.
21555 (Block.LocalMap, Block.ParameterMap): New public properties.
21556 (FlowBranching): The .ctor doesn't get the InternalParameters
21557 anymore since Block.EmitMeta() now computes the layout of the flow
21559 (MyStructInfo): This class is now known as `StructInfo' and nested
21560 in `TypeInfo'; we don't access this directly anymore.
21562 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
21563 property and removed IsAssigned(), IsFieldAssigned(),
21564 SetAssigned() and SetFieldAssigned(); we now call them on the
21565 VariableInfo so we don't need to duplicate this code everywhere.
21567 * expression.cs (ParameterReference): Added `Block block' argument
21569 (LocalVariableReference, ParameterReference, This): The new
21570 VariableInfo class is now responsible for all the definite
21573 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
21574 IsParameterAssigned, SetParameterAssigned): Removed.
21576 2003-05-18 Martin Baulig <martin@ximian.com>
21578 * typemanager.cs (InitCoreTypes): Try calling
21579 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
21580 the 3-args-version. Corlib now also needs our `void_type'.
21581 (GetMethod): Added overloaded version which takes an optional
21582 `bool report_errors' to allow lookups of optional methods.
21584 2003-05-12 Martin Baulig <martin@ximian.com>
21586 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
21587 only used for locals and not for parameters.
21589 2003-05-12 Miguel de Icaza <miguel@ximian.com>
21591 * support.cs (InternalParameters.ParameterType): Return the
21592 ExternalType of the parameter.
21594 * parameter.cs (Parameter.ExternalType): drop the two arguments,
21597 2003-05-11 Miguel de Icaza <miguel@ximian.com>
21599 * class.cs (MethodData.Define): Do not set the `newslot' on
21600 interface members, if they are also flagged as "override".
21602 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
21603 better code for ++i and i++. This only works for static fields
21604 and local variables.
21606 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
21607 want to pull the DeclSpace out of the builder_to_declspace instead
21608 of the TypeBuilder (like in TypeContainer.FindMembers).
21610 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
21611 instead of LookupTypeContainer. Fixes the crash on .NET for
21612 looking up interface members.
21614 * const.cs: Create our own emit context during the Definition
21615 stage, so that constants are evaluated in the proper context, when
21616 a recursive definition happens.
21618 2003-05-11 Martin Baulig <martin@ximian.com>
21620 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
21621 new block for a switch section.
21622 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
21623 the adding/lookup in the switch block. Fixes #39828.
21625 2003-05-09 Miguel de Icaza <miguel@ximian.com>
21627 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
21628 functionality: I needed to convert the data after I had performed
21629 the add/sub operation into the operands type size.
21631 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
21632 pass the type for the box operation, otherwise the resulting
21633 object would have been of type object.
21635 (BoxedCast): Add constructor to specify the type to box as.
21637 2003-05-07 Miguel de Icaza <miguel@ximian.com>
21639 * iterators.cs: I was reusing the `count' variable inadvertently,
21640 take steps to not allow this to happen.
21642 2003-05-06 Miguel de Icaza <miguel@ximian.com>
21644 * attribute.cs (Attribute.Resolve): Params attributes are encoded
21645 by creating an array at the point where the params starts and
21646 putting all those arguments there, then adjusting the size of the
21649 2003-05-05 Miguel de Icaza <miguel@ximian.com>
21651 * expression.cs (New.AddressOf): Implement interface
21652 IMemoryLocation. This is used when the `new' operator is used in
21653 the context of an invocation to a method on a value type.
21655 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
21658 * namespace.cs: Also check the using aliases here.
21660 * driver.cs: Move the test for using validity after the types have
21661 been entered, so we do a single pass that also includes the using
21664 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
21665 in the regular case. CreateSiblingForFinally is doing extra
21668 * attribute.cs (GetAttributeArgumentExpression): Store the result
21669 on an out value, and use the return value to indicate failure
21670 instead of using null (which is a valid return for Constant.GetValue).
21672 * statement.cs: Perform the analysis flow for the increment
21673 portion after the statement, because this will be the real flow of
21674 execution. Fixes #42385
21676 * codegen.cs (EmitContext.EmitArgument,
21677 EmitContext.EmitStoreArgument): New helper functions when the
21678 RemapToProxy flag is set.
21680 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
21683 Add support for remapping parameters.
21685 * iterators.cs: Propagate parameter values; Store parameter
21686 values in the proxy classes.
21688 2003-05-04 Miguel de Icaza <miguel@ximian.com>
21690 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
21691 need a proxy reference; I do not know what I was thinking
21693 * cs-parser.jay (constructor_initializer): catch another error,
21694 and display nice message.
21696 (field_declaration): catch void field declaration
21697 to flag a better error.
21699 * class.cs (MemberBase.CheckBase): Report an error instead of a
21700 warning if a new protected member is declared in a struct.
21701 (Field.Define): catch the error of readonly/volatile.
21703 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
21705 (FieldExpr.AddressOf): ditto. Catch error where the address of a
21706 volatile variable is taken
21708 2003-05-02 Miguel de Icaza <miguel@ximian.com>
21710 * statement.cs (Fixed.Resolve): Report an error if we are not in
21713 2003-05-01 Miguel de Icaza <miguel@ximian.com>
21715 * typemanager.cs: reuse the code that handles type clashes for
21716 delegates and enumerations.
21718 * class.cs (Report28): Always report.
21720 * expression.cs (EncodeAsAttribute): Allow nulls here.
21722 2003-04-28 Miguel de Icaza <miguel@ximian.com>
21724 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
21725 the functionality for testing whether an expression is valid for
21726 an attribute here. Also handle the case of arrays of elements
21729 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
21730 encoding a linear array into an array of objects that are suitable
21731 to be passed to an CustomAttributeBuilder.
21733 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
21735 * ecore.cs: (FieldExpr): Handle field remapping here.
21737 * iteratators.cs: Pass the instance variable (if the method is an
21738 instance method) to the constructors, so we can access the field
21739 variables on the class.
21741 TODO: Test this with structs. I think the THIS variable on
21742 structs might have to be a pointer, and not a refenrece
21744 2003-04-27 Miguel de Icaza <miguel@ximian.com>
21746 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
21747 local variables to fields in a proxy class.
21749 * iterators.cs (PopulateProxy): Rename our internal fields to
21751 Create a <THIS> field if we are an instance method, so we can
21752 reference our parent container variables.
21753 (MapVariable): Called back from the EmitContext code to enter a
21754 new variable to field mapping into the proxy class (we just create
21758 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
21759 for using the remapped locals to fields.
21761 I placed the code here, because that gives the same semantics to
21762 local variables, and only changes the Emit code.
21764 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
21765 statements inside iterators.
21766 (VariableInfo): Add a FieldBuilder for the cases when we are
21767 remapping local variables to fields in a proxy class
21769 * ecore.cs (SimpleNameResolve): Avoid testing two times for
21770 current_block != null.
21772 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
21773 not cope with strings, as it has been moved to the
21774 TableSwitchEmit. Fixed bug in switch generation.
21776 * expression.cs (New.DoResolve): Provide more context for the user
21777 when reporting an error.
21779 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
21782 * expression.cs (MemberAccess.DoResolve): When we get a type back,
21783 check the permissions for it. Note than in a type-resolution
21784 context the check was already present in DeclSpace.ResolveType,
21785 but was missing from the MemberAccess.
21787 (ArrayCreation.CheckIndices): warn if the user has
21788 more nested levels of expressions, but there are no more
21789 dimensions specified. Avoids crash on bug 41906.
21791 2003-04-26 Miguel de Icaza <miguel@ximian.com>
21793 * statement.cs (Block): replace Implicit bool, for a generic
21795 New flag: `Unchecked'. This is used during the EmitMeta phase
21796 (which is out-of-line with the regular Resolve/Emit process for a
21797 statement, as this is done ahead of time, but still gets a chance
21798 to call constant resolve).
21800 (Block.Flags): new enum for adding a new flag.
21802 (Block.EmitMeta): track the state of unchecked.
21804 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
21805 to enable constant resolution to work there as well.
21807 2003-04-22 Miguel de Icaza <miguel@ximian.com>
21809 * typemanager.cs (ienumerable_type): Also look up
21810 System.Collections.IEnumerable.
21812 2003-04-21 Miguel de Icaza <miguel@ximian.com>
21814 TODO: Test more than one conditional per method.
21816 * class.cs (Indexer.Define): Report the location where the user is
21817 referencing the unsupported feature.
21819 (MethodData): Overload the use of `conditionals' to
21820 minimize the creation of needless ArrayLists. This saves roughly
21821 212kb on my machine.
21823 (Method): Implement the new IIteratorContainer interface.
21824 (Method.SetYields): Implement the method by setting the ModFlags
21825 to contain METHOD_YIELDS.
21827 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
21828 which just got set to null.
21830 * iterators.cs: New file.
21832 (Yield, YieldBreak): New statements.
21834 * statement.cs (Return.Resolve): Flag an error if we are used in
21835 an iterator method.
21837 * codegen.cs (InIterator): New flag set if the code is being
21838 compiled in an iterator method.
21840 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
21841 internal modifier, and we just use it to avoid adding extra
21842 fields, as this is seldom used.
21844 * cs-parser.jay: Add yield_statement (yield and yield break).
21846 * driver.cs: New flag -v2 to turn on version 2 features.
21848 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
21849 hashtable when v2 is enabled.
21851 2003-04-20 Miguel de Icaza <miguel@ximian.com>
21853 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
21854 there is already a namespace defined with this name.
21856 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
21857 people upgraded their corlibs.
21859 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
21860 always use fully qualified types, no need to use the compiler
21863 (TypeManager.IsNamespace): Use binarysearch.
21865 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
21866 AddDelegate): I did not quite use the new IsValid API properly: I
21867 have to pass the short-name and the fullname. I was passing only
21868 the basename instead of the fullname sometimes.
21870 (TypeContainer.DefineType): call NamespaceClash.
21872 * interface.cs (Interface.DefineType): use NamespaceClash before
21875 * delegate.cs (Delegate.DefineType): use NamespaceClash before
21878 * enum.cs: (Enum.DefineType): use NamespaceClash before
21881 * typemanager.cs (: 3-line patch that gives us some tasty 11%
21882 speed increase. First, use the negative_hits cache when we get a
21883 negative. Second, add the type with its full original name
21884 instead of the new . and + encoded name (reflection uses + to
21885 separate type from a nested type). Use LookupTypeReflection
21886 directly which bypasses the type->name hashtable (that we already
21887 know does not contain the type.
21889 * decl.cs (DeclSpace.ResolveTypeExpr): track the
21890 location/container type.
21892 * driver.cs: When passing utf8, use directly the UTF8Encoding.
21894 2003-04-19 Miguel de Icaza <miguel@ximian.com>
21896 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
21898 * delegate.cs (NewDelegate.Resolve): Test whether an instance
21899 method is being referenced in the method group from a static
21900 context, and report error 120 if so.
21902 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
21905 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
21906 is created, we create the A namespace).
21908 * cs-parser.jay: A namespace also introduces a DeclarationFound.
21911 2003-04-18 Miguel de Icaza <miguel@ximian.com>
21913 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
21914 invocation to ModuleBuilder.GetType with the same values will
21915 return a new type instance, so we need to cache its return
21918 * expression.cs (Binary.ResolveOperator): Only allow the compare
21919 operators on enums if they are of the same type.
21921 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
21922 types of ValueType on their own case. Before we were giving them
21923 the same treatment as objects.
21925 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
21926 fullname. Short name is used to compare against container name.
21927 Fullname is used to check against defined namespace names.
21929 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
21930 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
21932 (Method.CheckBase): Call parent.
21933 (MemberBase.CheckBase): Check for protected members on sealed
21935 (PropertyBase.CheckBase): Call parent.
21936 (Field.Define): Call parent.
21938 * report.cs: Negative error codes are now mapped to 8000 - code,
21939 so that the display is render more nicely.
21941 * typemanager.cs: Do not use try/catch, instead report a regular
21944 (GetPointerType, GetReferenceType): These methods provide
21945 mechanisms to obtain the T* and T& from a T. We had the code
21946 previously scattered around the code base, and it also used
21947 TypeManager.LookupType that would go through plenty of caches.
21948 This one goes directly to the type source.
21950 In some places we did the Type.GetType followed by
21951 ModuleBuilder.GetType, but not in others, so this unifies the
21952 processing as well.
21954 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
21955 statements now that we have namespace information.
21957 * typemanager.cs (IsNamespace): New method, returns whether the
21958 string presented is a namespace or not.
21960 (ComputeNamespaces): New public entry point, computes the list of
21961 available namespaces, using the GetNamespaces API call in Mono, or
21962 the slower version in MS.NET.
21964 Now before we start the semantic analysis phase, we have a
21965 complete list of namespaces including everything that the user has
21968 Deleted old code to cache namespaces in .nsc files.
21970 2003-04-17 Miguel de Icaza <miguel@ximian.com>
21972 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
21973 class/struct location definition Location for the implicit
21974 constructor location.
21976 (Operator.Define): Use the location of the operator for the
21977 implicit Method definition.
21979 (Constructor.Emit): use the constructor location for the implicit
21980 base initializer constructor.
21982 * ecore.cs: Remove ITypeExpression. This interface is now gone,
21983 and the Expression class now contains two new methods:
21985 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
21986 isolate type lookup from the rest of the resolution process.
21988 Since we use Expressions to hold type definitions due to the way
21989 we parse the input we have historically overloaded Resolve to
21990 perform the Type lookups if a special flag is passed. Now this is
21991 eliminated and two methods take their place.
21993 The differences in the two methods between xStep and xTerminal is
21994 that xStep is involved in our current lookup system that uses
21995 SimpleNames to compose a name, while xTerminal is used just to
21996 catch the case where the simplename lookup failed.
21998 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22000 * expression.cs (ResolveMemberAccess): Remove redundant code.
22001 TypeExpr expressions are always born fully resolved.
22003 * interface.cs (PopulateMethod): Do not lookup the types twice.
22004 We were doing it once during SemanticAnalysis and once during
22007 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22008 in local variable type definitions, were being returned as a
22009 SimpleName (we decomposed everything into a string), that is
22010 because primary_expression was being used instead of a type in the
22011 grammar (reduce/reduce conflicts).
22013 The part that was wrong is that we converted the expression into a
22014 string (an oversimplification in one hand, compounded with primary
22015 expressions doing string concatenation).
22021 Would return "A.B.C[]" as a SimpleName. This stopped things like
22022 using clauses from working on this particular context. And a type
22023 was being matched directly against "A.B.C[]".
22025 We now use the correct approach, and allow for ComposedCast to be
22026 part of the unary expression. So the "A.B.C []" become a composed
22027 cast of "A.B.C" (as a nested group of MemberAccess with a
22028 SimpleName at the end) plus the rank composition "[]".
22032 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22034 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22035 for the access level checking.
22037 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22038 `TypeContainer container', because I kept getting confused when I
22039 was debugging this code.
22041 * expression.cs (Indexers): Instead of tracking getters/setters,
22042 we now track them in parallel. We create one arraylist less, but
22043 most importantly it is possible now for the LValue code to find a
22044 matching get for a set.
22046 (IndexerAccess.DoResolveLValue): Update the code.
22047 GetIndexersForType has been modified already to extract all the
22048 indexers from a type. The code assumed it did not.
22050 Also make the code set the correct return type for the indexer.
22051 This was fixed a long time ago for properties, but was missing for
22052 indexers. It used to be void_type.
22054 (Binary.Emit): Test first for doubles instead of
22055 floats, as they are more common.
22057 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22058 when dealing with floats and the <=, >= operators. This fixes bug
22061 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22062 to load the array value by emitting a load on the foreach variable
22063 type. This was incorrect.
22065 We now emit the code to load an element using the the array
22066 variable type, and then we emit the conversion operator.
22070 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22072 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22074 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22076 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22077 test for protection before we test for signatures.
22079 (MethodSignature.ToString): implement.
22081 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22082 to the case where we reduced into a LongConstant.
22084 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22085 depend on whether the information is acurrate, because the
22086 Microsoft runtime will always claim that the array type is public,
22087 regardless of the real state.
22089 If the type is a pointer, another problem happens: the type is
22090 reported as non-public in Microsoft.
22092 In both cases we have to call CheckAccessLevel recursively with
22093 the underlying type as the argument to be tested.
22095 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22097 * assign.cs (Assign.Emit): If we are dealing with a compound
22098 assignment expression, we should use the code path that stores the
22099 intermediate result in a temporary value. This fixes #40903.
22101 *expression.cs (Indirection.ToString): Provide ToString method for
22104 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22106 * class.cs: Null out fields holding references to Block objects so
22107 they can be garbage collected.
22109 * expression.cs (OverloadResolve): Remove unused local.
22111 2003-04-07 Martin Baulig <martin@ximian.com>
22113 * codegen.cs (EmitContext.CurrentFile): New public field.
22114 (EmitContext.Mark): Use the CurrentFile to check whether the
22115 location is in the correct file.
22116 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22118 2003-04-07 Martin Baulig <martin@ximian.com>
22120 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22122 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22123 location. [FIXME: The location argument which gets passed to this
22124 method is sometimes wrong!]
22126 2003-04-07 Nick Drochak <ndrochak@gol.com>
22128 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22130 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22132 * expression.cs (Indirection.EmitAssign): We were using the
22133 temporary, but returning immediately instead of continuing the
22136 2003-04-06 Martin Baulig <martin@ximian.com>
22138 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22139 if it's a nested child, but also deriving from the outer class.
22142 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22143 nested child, but also deriving from the outer class. See
22145 (FilterWithClosure): We may access private members of the outer
22146 class if we're a nested child and deriving from the outer class.
22147 (RealMemberLookup): Only set `closure_private_ok' if the
22148 `original_bf' contained BindingFlags.NonPublic.
22150 2003-04-05 Martin Baulig <martin@ximian.com>
22152 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22154 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22156 * class.cs (Event.Define): Do not allow abstract events to have
22159 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22161 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22162 block in event declarations.
22164 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22165 value type, get its address.
22167 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22168 leaving a class on the stack instead of a boolean value (int
22169 0/1). Change the code so we compare against null, and then the
22170 result against zero.
22172 * class.cs (TypeContainer.GetClassBases): We were checking for the
22173 parent class being sealed too late.
22175 * expression.cs (Binary.Emit): For <= and >= when dealing with
22176 floating point values, use cgt.un and clt.un instead of cgt and
22179 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22181 * statement.cs: Apply the same optimization as MS: skip the
22182 GetEnumerator returning an IEnumerator, and use the one returning a
22183 CharEnumerator instead. This allows us to avoid the try-finally block
22186 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22188 * cs-parser.jay: Attributes cannot be applied to
22189 namespaces. Fixes #40473
22191 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22194 (Add*): check if the name is valid using the full name for constants,
22195 fields, properties and events.
22197 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22199 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22200 char constants to be part of the enumeration.
22202 * expression.cs (Conditional.DoResolve): Add support for operator
22203 true. Implements the missing functionality from 14.12
22205 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22206 operator true/false as required by the spec.
22208 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22209 implicit conversion to boolean.
22211 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22212 also one where the type implements `operator true'.
22214 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22215 get an expression that will invoke operator true based on an
22218 (GetConversionOperators): Removed the hack that called op_True
22221 (Expression.ResolveBoolean): Move this from Statement.
22223 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22225 * ecore.cs (FieldExpr): do not allow initialization of initonly
22226 fields on derived classes
22228 2003-03-13 Martin Baulig <martin@ximian.com>
22230 * statement.cs (Block.Emit): Call ig.BeginScope() and
22231 ig.EndScope() when compiling with debugging info; call
22232 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22234 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22236 * expression.cs (Indexers): Do not construct immediately, allow
22237 for new members to be appended as we go. Fixes 38143
22239 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22241 * expression.cs: save/restore context when resolving an unchecked
22244 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22246 * cfold.cs: Catch division by zero in modulus operator during
22249 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22251 * interface.cs (Interface.DefineMembers): Avoid defining members
22254 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22256 * driver.cs: handle the +/- options for -noconfig
22258 * statement.cs (Unckeched.Resolve): Also track the state of
22259 unchecked in the Resolve phase.
22261 2003-02-27 Martin Baulig <martin@ximian.com>
22263 * ecore.cs (Expression.MemberLookup): Don't create a
22264 MethodGroupExpr for something which is not a method. Fixes #38291.
22266 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22268 * class.cs (MemberBase.CheckParameters): Also check that the type
22269 is unmanaged if it is a pointer.
22271 * expression.cs (SizeOf.Resolve): Add location information.
22273 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22274 a managed type is declared.
22276 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22277 parameter modifiers as well. Fixes bug 38606
22279 * class.cs: Very sad. Am backing out the speed up changes
22280 introduced by the ArrayList -> Array in the TypeContainer, as they
22281 were not actually that much faster, and introduced a bug (no error
22282 reports on duplicated methods).
22284 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22285 source first, this will guarantee that we have a valid expression
22286 before calling in lower levels functions that will require a
22287 resolved object. Then use this original_source in the
22288 target.ResolveLValue instead of the original source that was
22291 Another change. Use target.Resolve instead of LValueResolve.
22292 Although we are resolving for LValues, we will let the Assign code
22293 take care of that (it will be called again from Resolve). This
22294 basically allows code like this:
22296 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22297 class Y { void A (X x) { x [0] += o; }
22299 The problem was that the indexer was trying to resolve for
22300 set_Item (idx, object o) and never finding one. The real set_Item
22301 was set_Item (idx, X). By delaying the process we get the right
22306 2003-02-23 Martin Baulig <martin@ximian.com>
22308 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22309 while calling DoEmit ().
22311 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22312 source files; if you use the #line directive inside a method, the
22313 compiler stops emitting line numbers for the debugger until it
22314 reaches the end of the method or another #line directive which
22315 restores the original file.
22317 2003-02-23 Martin Baulig <martin@ximian.com>
22319 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22321 2003-02-23 Martin Baulig <martin@ximian.com>
22323 * statement.cs (Block.AddChildVariableNames): We need to call this
22324 recursively, not just for our immediate children.
22326 2003-02-23 Martin Baulig <martin@ximian.com>
22328 * class.cs (Event.Define): Always make the field private, like csc does.
22330 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22331 actually work, fixes bug #37521.
22333 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22335 * delegate.cs: When creating the various temporary "Parameters"
22336 classes, make sure that we call the ComputeAndDefineParameterTypes
22337 on those new parameters (just like we do with the formal ones), to
22338 allow them to be resolved in the context of the DeclSpace.
22340 This fixes the bug that Dick observed in Bugzilla #38530.
22342 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22344 * expression.cs (ResolveMemberAccess): When resolving a constant,
22345 do not attempt to pull a constant if the value was not able to
22346 generate a valid constant.
22348 * const.cs (LookupConstantValue): Do not report more errors than required.
22350 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22352 * expression.cs: fixes bug #38328.
22354 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22356 * class.cs: Changed all the various members that can be part of a
22357 class from being an ArrayList to be an Array of the right type.
22358 During the DefineType type_list, interface_list, delegate_list and
22359 enum_list are turned into types, interfaces, delegates and enums
22362 And during the member population, indexer_list, event_list,
22363 constant_list, field_list, instance_constructor_list, method_list,
22364 operator_list and property_list are turned into their real arrays.
22366 Although we could probably perform this operation earlier, for
22367 good error reporting we need to keep the lists and remove the
22368 lists for longer than required.
22370 This optimization was triggered by Paolo profiling the compiler
22371 speed on the output of `gen-sample-program.pl' perl script.
22373 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22374 not crash in methods like MemberLookupFailed that use this field.
22376 This problem arises when the compiler fails to resolve a type
22377 during interface type definition for example.
22379 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22381 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22382 inherit from System.Object, so we have to stop at null, not only
22383 when reaching System.Object.
22385 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22387 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22388 DeclaredOnly because the parent indexer might have had a different
22389 name, but did not loop until the top of the hierarchy was reached.
22391 The problem this one fixes is 35492: when a class implemented an
22392 indexer from an interface, we were getting the interface method
22393 (which was abstract) and we were flagging an error (can not invoke
22396 This also keeps bug 33089 functioning, and test-148 functioning.
22398 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22399 out if a method is special is to see if it is declared in a
22400 property or event, or whether it is one of the predefined operator
22401 names. This should fix correctly #36804.
22403 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22405 The goal here is to remove the dependency on EmptyCast.Peel ().
22406 Killing it completely.
22408 The problem is that currently in a number of places where
22409 constants are expected, we have to "probe" for an EmptyCast, and
22410 Peel, which is not the correct thing to do, as this will be
22411 repetitive and will likely lead to errors.
22413 The idea is to remove any EmptyCasts that are used in casts that
22414 can be reduced to constants, so we only have to cope with
22417 This bug hunt was triggered by Bug 37363 and the desire to remove
22418 the duplicate pattern where we were "peeling" emptycasts to check
22419 whether they were constants. Now constants will always be
22422 * ecore.cs: Use an enumconstant here instead of wrapping with
22425 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22426 throwing me off. By handling this we can get rid of a few hacks.
22428 * statement.cs (Switch): Removed Peel() code.
22430 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22432 * class.cs: Location information for error 508
22434 * expression.cs (New.DoResolve): Add a guard against double
22435 resolution of an expression.
22437 The New DoResolve might be called twice when initializing field
22438 expressions (see EmitFieldInitializers, the call to
22439 GetInitializerExpression will perform a resolve on the expression,
22440 and later the assign will trigger another resolution
22442 This leads to bugs (#37014)
22444 * delegate.cs: The signature for EndInvoke should contain any ref
22445 or out parameters as well. We were not doing this in the past.
22447 * class.cs (Field.Define): Do not overwrite the type definition
22448 inside the `volatile' group. Turns out that volatile enumerations
22449 were changing the type here to perform a validity test, which
22452 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22454 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22455 and structs, we do not want to load the instance variable
22457 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22458 enum_type has to be handled like an object reference (implicit
22459 conversions exists from this to object), but the regular IsClass
22460 and IsValueType tests will never return true for this one.
22462 Also we use TypeManager.IsValueType instead of type.IsValueType,
22463 just for consistency with the rest of the code (this is only
22464 needed if we ever use the construct exposed by test-180.cs inside
22465 corlib, which we dont today).
22467 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22469 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22472 2003-02-09 Martin Baulig <martin@ximian.com>
22474 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22475 (Namespace.DefineNamespaces): New static public method; this is
22476 called when we're compiling with debugging to add all namespaces
22477 to the symbol file.
22479 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22480 pass it to the Namespace's .ctor.
22482 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22483 and MethodBase arguments; pass the namespace ID to the symwriter;
22484 pass the MethodBase instead of the token to the symwriter.
22485 (SymbolWriter.DefineNamespace): New method to add a namespace to
22488 2003-02-09 Martin Baulig <martin@ximian.com>
22490 * symbolwriter.cs: New file. This is a wrapper around
22491 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22492 methods here in near future.
22494 2003-02-09 Martin Baulig <martin@ximian.com>
22496 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22497 ILGenerator.MarkSequencePoint() which are actually used by the
22500 2003-02-09 Martin Baulig <martin@ximian.com>
22502 * location.cs (SourceFile): New public sealed class. This
22503 contains the name and an index which is used in the location's token.
22504 (Location): Reserve an appropriate number of bits in the token for
22505 the source file instead of walking over that list, this gives us a
22506 really huge performance improvement when compiling with debugging.
22508 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22509 `SourceFile' argument instead of a string.
22510 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22511 but don't parse/tokenize here, we need to generate the list of all
22512 source files before we do that.
22513 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22516 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22517 instead of a string.
22519 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22522 2003-02-09 Martin Baulig <martin@ximian.com>
22524 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22525 filename on `#line default'.
22527 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22529 * statement.cs: don't clear the pinned var when the fixed statement
22530 returns from the method (fixes bug#37752).
22532 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22534 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22537 2003-02-07 Martin Baulig <martin@ximian.com>
22539 * driver.cs: Removed the `--debug-args' command line argument.
22541 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22542 automatically by the AsssemblyBuilder.
22543 (CodeGen.InitializeSymbolWriter): We don't need to call any
22544 initialization function on the symbol writer anymore. This method
22545 doesn't take any arguments.
22547 2003-02-03 Miguel de Icaza <miguel@ximian.com>
22549 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
22550 from referenced assemblies as well.
22552 2003-02-02 Martin Baulig <martin@ximian.com>
22554 * class.cs (MethodData.Emit): Generate debugging info for external methods.
22556 2003-02-02 Martin Baulig <martin@ximian.com>
22558 * class.cs (Constructor.Emit): Open the symbol writer before
22559 emitting the constructor initializer.
22560 (ConstructorInitializer.Emit): Call ec.Mark() to allow
22561 single-stepping through constructor initializers.
22563 2003-01-30 Miguel de Icaza <miguel@ximian.com>
22565 * class.cs: Handle error 549: do not allow virtual methods in
22568 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
22570 * decl.cs: Check access levels when resolving types
22572 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
22574 * statement.cs: Add parameters and locals set in catch blocks that might
22575 return to set vector
22577 2003-01-29 Miguel de Icaza <miguel@ximian.com>
22579 * class.cs (Operator): Set the SpecialName flags for operators.
22581 * expression.cs (Invocation.DoResolve): Only block calls to
22582 accessors and operators on SpecialName methods.
22584 (Cast.TryReduce): Handle conversions from char constants.
22587 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
22589 * statement.cs: small memory and time optimization in FlowBranching.
22591 2003-01-28 Pedro Mart <yoros@wanadoo.es>
22593 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
22594 problem that the last fix but in the other sid (Set).
22596 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
22597 access when there is no indexer in the hierarchy.
22599 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
22601 * class.cs: Combine some if statements.
22603 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22605 * driver.cs: fixed bug #37187.
22607 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
22609 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
22610 any indexer, it's needed to build a list with all the indexers in the
22611 hierarchy (AllGetters), else we have problems. Fixes #35653.
22613 2003-01-23 Miguel de Icaza <miguel@ximian.com>
22615 * class.cs (MethodData.Define): It is wrong for an interface
22616 implementation to be static in both cases: explicit and implicit.
22617 We were only handling this in one case.
22619 Improve the if situation there to not have negations.
22621 * class.cs (Field.Define): Turns out that we do not need to check
22622 the unsafe bit on field definition, only on usage. Remove the test.
22624 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22626 * driver.cs: use assembly.Location instead of Codebase (the latest
22627 patch made mcs fail when using MS assemblies).
22629 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
22631 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
22632 get the path to *corlib.dll.
22634 2003-01-21 Nick Drochak <ndrochak@gol.com>
22638 * typemanager.cs: Remove compiler warnings
22640 2003-01-20 Duncan Mak <duncan@ximian.com>
22642 * AssemblyInfo.cs: Bump the version number to 0.19.
22644 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22646 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
22648 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
22650 * class.cs (Constructor::Emit): Emit debugging info for constructors.
22652 2003-01-17 Miguel de Icaza <miguel@ximian.com>
22654 * cs-parser.jay: Small fix: we were not comparing the constructor
22655 name correctly. Thanks to Zoltan for the initial pointer.
22657 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
22659 * cs-tokenizer.cs: Set file name when specified with #line
22661 2003-01-15 Miguel de Icaza <miguel@ximian.com>
22663 * cs-parser.jay: Only perform the constructor checks here if we
22664 are named like the class; This will help provider a better
22665 error. The constructor path is taken when a type definition is
22666 not found, but most likely the user forgot to add the type, so
22667 report that rather than the constructor error.
22669 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
22671 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
22674 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22676 * cs-parser.jay: Add cleanup call.
22678 2003-01-13 Duncan Mak <duncan@ximian.com>
22680 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
22681 consistent with other methods.
22683 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22685 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
22687 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
22689 * attribute.cs: only set GuidAttr to true when we have a
22692 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22696 * typemanager.cs: fixes to allow mcs compile corlib with the new
22697 Type.IsSubclassOf fix.
22699 2003-01-08 Miguel de Icaza <miguel@ximian.com>
22701 * expression.cs (LocalVariableReference.DoResolve): Classify a
22702 constant as a value, not as a variable. Also, set the type for
22705 * cs-parser.jay (fixed_statement): take a type instead of a
22706 pointer_type, so we can produce a better error message later.
22708 * statement.cs (Fixed.Resolve): Flag types that are not pointers
22711 (For.DoEmit): Make inifinite loops have a
22712 non-conditional branch back.
22714 (Fixed.DoEmit): First populate the pinned variables, then emit the
22715 statement, then clear the variables. Before I was emitting the
22716 code once for each fixed piece.
22719 2003-01-08 Martin Baulig <martin@ximian.com>
22721 * statement.cs (FlowBranching.MergeChild): A break in a
22722 SWITCH_SECTION does not leave a loop. Fixes #36155.
22724 2003-01-08 Martin Baulig <martin@ximian.com>
22726 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
22727 lives in the same number space than `param_map'. Fixes #36154.
22729 2003-01-07 Miguel de Icaza <miguel@ximian.com>
22731 * cs-parser.jay (constructor_declaration): Set the
22732 Constructor.ModFlags before probing for it. This makes the
22733 compiler report 514, 515 and 132 (the code was there, but got
22736 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
22737 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
22738 (GotoCase.Resolve): Set `Returns' to ALWAYS.
22740 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
22742 * enum.cs: create the enum static fields using the enum type.
22744 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
22746 * class.cs: don't try to create the ParamBuilder for the return
22747 type if it's not needed (and handle it breaking for the ms runtime
22750 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
22752 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
22754 2002-12-29 Miguel de Icaza <miguel@ximian.com>
22756 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
22757 the command. This showed up while compiling the JANET source
22758 code, which used \r as its only newline separator.
22760 2002-12-28 Miguel de Icaza <miguel@ximian.com>
22762 * class.cs (Method.Define): If we are an operator (because it
22763 reuses our code), then set the SpecialName and HideBySig. #36128
22765 2002-12-22 Miguel de Icaza <miguel@ximian.com>
22767 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
22768 exception, report error 120 `object reference required'.
22770 * driver.cs: Add --pause option, used during to measure the size
22771 of the process as it goes with --timestamp.
22773 * expression.cs (Invocation.DoResolve): Do not allow methods with
22774 SpecialName to be invoked.
22776 2002-12-21 Miguel de Icaza <miguel@ximian.com>
22778 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
22779 number before adding it.
22781 2002-12-21 Ravi Pratap <ravi@ximian.com>
22783 * ecore.cs (StandardImplicitConversion): When in an unsafe
22784 context, we allow conversion between void * to any other pointer
22785 type. This fixes bug #35973.
22787 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
22789 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
22790 is not thrown when extensionless outputs are used
22792 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22794 * rootcontext.cs: fixed compilation of corlib.
22796 2002-12-19 Miguel de Icaza <miguel@ximian.com>
22798 * attribute.cs (Attributes.Contains): Add new method.
22800 * class.cs (MethodCore.LabelParameters): if the parameter is an
22801 `out' parameter, check that no attribute `[In]' has been passed.
22803 * enum.cs: Handle the `value__' name in an enumeration.
22805 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
22807 * decl.cs: Added special case to allow overrides on "protected
22810 2002-12-18 Ravi Pratap <ravi@ximian.com>
22812 * attribute.cs (Attributes.AddAttributeSection): Rename to this
22813 since it makes much more sense.
22815 (Attributes.ctor): Don't require a Location parameter.
22817 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
22819 * attribute.cs (ApplyAttributes): Remove extra Location parameters
22820 since we already have that information per attribute.
22822 * everywhere : make appropriate changes.
22824 * class.cs (LabelParameters): Write the code which actually
22825 applies attributes to the return type. We can't do this on the MS
22826 .NET runtime so we flag a warning in the case an exception is
22829 2002-12-18 Miguel de Icaza <miguel@ximian.com>
22831 * const.cs: Handle implicit null conversions here too.
22833 2002-12-17 Ravi Pratap <ravi@ximian.com>
22835 * class.cs (MethodCore.LabelParameters): Remove the extra
22836 Type [] parameter since it is completely unnecessary. Instead
22837 pass in the method's attributes so that we can extract
22838 the "return" attribute.
22840 2002-12-17 Miguel de Icaza <miguel@ximian.com>
22842 * cs-parser.jay (parse): Use Report.Error to flag errors instead
22843 of ignoring it and letting the compile continue.
22845 * typemanager.cs (ChangeType): use an extra argument to return an
22846 error condition instead of throwing an exception.
22848 2002-12-15 Miguel de Icaza <miguel@ximian.com>
22850 * expression.cs (Unary.TryReduce): mimic the code for the regular
22851 code path. Perform an implicit cast in the cases where we can
22852 implicitly convert to one of the integral types, and then reduce
22853 based on that constant. This fixes bug #35483.
22855 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22857 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
22859 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22861 * namespace.cs: fixed bug #35489.
22863 2002-12-12 Miguel de Icaza <miguel@ximian.com>
22865 * class.cs: Remove some dead code.
22867 * cs-parser.jay: Estimate the number of methods needed
22868 (RootContext.MethodCount);
22870 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
22871 numbers instead of StringBuilders.
22873 * support.cs (PtrHashtable): Add constructor with initial size;
22874 We can now reduce reallocations of the method table.
22876 2002-12-10 Ravi Pratap <ravi@ximian.com>
22878 * attribute.cs (ApplyAttributes): Keep track of the emitted
22879 attributes on a per-target basis. This fixes bug #35413.
22881 2002-12-10 Miguel de Icaza <miguel@ximian.com>
22883 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
22884 default to the Windows 1252 encoding.
22886 (UnixParseOption): Support version, thanks to Alp for the missing
22889 * AssemblyInfo.cs: Add nice assembly information.
22891 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
22894 * cs-parser.jay: Allow a trailing comma before the close bracked
22895 in the attribute_section production.
22897 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
22898 address of the instance was being taken, I will take this out,
22899 because we take the address of the object immediately here.
22901 2002-12-09 Ravi Pratap <ravi@ximian.com>
22903 * typemanager.cs (AreMultipleAllowed): Take care of the most
22904 obvious case where attribute type is not in the current assembly -
22907 2002-12-08 Miguel de Icaza <miguel@ximian.com>
22909 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
22910 definitions, instead of doing that afterwards.
22912 Also we use a nice little hack, depending on the constructor, we
22913 know if we are a "composed" name or a simple name. Hence, we
22914 avoid the IndexOf test, and we avoid
22916 * codegen.cs: Add code to assist in a bug reporter to track down
22917 the source of a compiler crash.
22919 2002-12-07 Ravi Pratap <ravi@ximian.com>
22921 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
22922 types have been emitted for a given element and flag an error
22923 if something which does not have AllowMultiple set is used more
22926 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
22927 attribute types and their corresponding AllowMultiple properties
22929 (AreMultipleAllowed): Check the property for a given type.
22931 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
22932 property in the case we have a TypeContainer.
22934 (Attributes.AddAttribute): Detect duplicates and just skip on
22935 adding them. This trivial fix catches a pretty gross error in our
22936 attribute emission - global attributes were being emitted twice!
22938 Bugzilla bug #33187 is now fixed.
22940 2002-12-06 Miguel de Icaza <miguel@ximian.com>
22942 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
22943 instead of pp_and).
22945 * expression.cs (Binary.ResolveOperator): I can only use the
22946 Concat (string, string, string) and Concat (string, string,
22947 string, string) if the child is actually a concatenation of
22950 2002-12-04 Miguel de Icaza <miguel@ximian.com>
22952 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
22953 context where we need a 2-character lookahead.
22955 * pending.cs (PendingImplementation): Rework so we can keep track
22956 of interface types all the time, and flag those which were
22957 implemented by parents as optional.
22959 2002-12-03 Miguel de Icaza <miguel@ximian.com>
22961 * expression.cs (Binary.ResolveOperator): Use
22962 String.Concat(string,string,string) or
22963 String.Concat(string,string,string,string) when possible.
22965 * typemanager: More helper methods.
22968 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
22970 * pending.cs: remove the bogus return from GetMissingInterfaces()
22971 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
22973 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22975 * namespace.cs: avoid duplicated 'using xxx' being added to
22976 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
22977 when we get more than one 'using' statement for the same namespace.
22978 Report a CS0105 warning for it.
22980 2002-11-30 Miguel de Icaza <miguel@ximian.com>
22982 * cs-tokenizer.cs (consume_identifier): use read directly, instead
22983 of calling getChar/putback, uses internal knowledge of it.
22985 (xtoken): Reorder tokenizer so most common patterns are checked
22986 first. This reduces the compilation time in another 5% (from 8.11s
22987 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
22989 The parsing time is 22% of the compilation in mcs, and from that
22990 64% is spent on the tokenization process.
22992 I tried using a binary search for keywords, but this is slower
22993 than the hashtable. Another option would be to do a couple of
22996 * Not use a StringBuilder, instead use an array of chars,
22997 with a set value. Notice that this way we could catch
22998 the 645 error without having to do it *afterwards*.
23000 * We could write a hand-parser to avoid the hashtable
23001 compares altogether.
23003 The identifier consumption process takes 37% of the tokenization
23004 time. Another 15% is spent on is_number. 56% of the time spent
23005 on is_number is spent on Int64.Parse:
23007 * We could probably choose based on the string length to
23008 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23011 Another 3% is spend on wrapping `xtoken' in the `token' function.
23013 Handle 0xa0 as whitespace (#34752)
23015 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23017 * typemanager.cs (IsCLRType): New routine to tell whether a type
23018 is one of the builtin types.
23020 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23021 typecode in more places instead of doing pointer comparissions.
23022 We could leverage some knowledge about the way the typecodes are
23025 New code to cache namespaces in assemblies, it is currently not
23026 invoked, to be used soon.
23028 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23030 * expression.cs (Binary.ResolveOperator): specially handle
23031 strings, and do not perform user-defined operator overloading for
23034 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23036 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23037 internalcall as it is a pretty simple operation; Avoid whenever
23038 possible to call Char.IsLetter.
23040 (consume_identifier): Cut by half the number of
23041 hashtable calls by merging the is_keyword and GetKeyword behavior.
23043 Do not short-circuit, because if we do, we
23044 report errors (ie, #if false && true would produce an invalid
23048 2002-11-24 Martin Baulig <martin@ximian.com>
23050 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23051 check constant ranges and report a CS0221. Fixes #33186.
23053 2002-11-24 Martin Baulig <martin@ximian.com>
23055 * cs-parser.jay: Make this work for uninitialized variable
23056 declarations in the `for' initializer. Fixes #32416.
23058 2002-11-24 Martin Baulig <martin@ximian.com>
23060 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23061 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23063 2002-11-24 Martin Baulig <martin@ximian.com>
23065 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23066 argument; if true, we also check for user-defined conversions.
23067 This is only needed if both arguments are of a user-defined type.
23068 Fixes #30443, added test-175.cs.
23069 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23071 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23073 2002-11-24 Martin Baulig <martin@ximian.com>
23075 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23076 function to get the store opcode.
23077 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23078 only emit the Ldelema if the store opcode is Stobj. You must run
23079 both test-34 and test-167 to test this. Fixes #34529.
23081 2002-11-23 Martin Baulig <martin@ximian.com>
23083 * ecore.cs (Expression.MemberLookup): Added additional
23084 `qualifier_type' argument which is used when we're being called
23085 from MemberAccess.DoResolve() and null if we're called from a
23087 (Expression.MemberLookupFailed): New method to report errors; this
23088 does the CS1540 check and reports the correct error message.
23090 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23091 argument for the CS1540 check and redone the way how we're dealing
23092 with private members. See the comment in the source code for details.
23093 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23094 `closure_start_type' to `closure_qualifier_type' and check whether
23095 it's not null. It was not this filter being broken, it was just
23096 being called with the wrong arguments.
23098 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23099 and pass it the correct `qualifier_type'; this also does the error
23102 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23104 * expression.cs (Invocation.EmitParams): If the we are dealing
23105 with a non-built-in value type, load its address as well.
23107 (ArrayCreation): Use a a pretty constant instead
23108 of the hardcoded value 2. Use 6 instead of 2 for the number of
23109 static initializers.
23111 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23112 because they are not really value types, just glorified integers.
23114 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23116 * ecore.cs: Remove redundant code for enumerations, make them use
23117 the same code path as everything else, fixes the casting issue
23118 with enumerations in Windows.Forms.
23120 * attribute.cs: Do only cast to string if it is a string, the
23121 validation happens later.
23123 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23124 people upgrade their corlibs.
23126 * ecore.cs: Oops, enumerations were not following the entire code path
23128 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23130 * typemanager.cs (FilterWithClosure): Commented out the test for
23131 1540 in typemanager.cs, as it has problems when accessing
23132 protected methods from a parent class (see test-174.cs).
23134 * attribute.cs (Attribute.ValidateGuid): new method.
23135 (Attribute.Resolve): Use above.
23137 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23139 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23141 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23142 handling for enumerations, as we only needed the TypeContainer
23143 functionality to begin with (this is required for the fix below to
23144 work for enums that reference constants in a container class for
23147 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23149 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23150 a valid TypeBuilder to perform lookups on.o
23152 * class.cs (InheritableMemberSignatureCompare): Use true in the
23153 call to GetGetMethod and GetSetMethod, because we are comparing
23154 the signature, and we need to get the methods *even* if they are
23157 (PropertyBase.CheckBase): ditto.
23159 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23160 GotoCase.Resolve): Use Peel on EmpytCasts.
23162 * ecore.cs (EmptyCast): drop child, add Peel method.
23164 2002-11-17 Martin Baulig <martin@ximian.com>
23166 * ecore.cs (EmptyCast.Child): New public property.
23168 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23169 label resolved to an EmptyCast. Fixes #34162.
23170 (GotoCase.Resolve): Likewise.
23171 (Block.EmitMeta): Likewise.
23173 2002-11-17 Martin Baulig <martin@ximian.com>
23175 * expression.cs (Invocation.BetterConversion): Prefer int over
23176 uint; short over ushort; long over ulong for integer literals.
23177 Use ImplicitConversionExists instead of StandardConversionExists
23178 since we also need to check for user-defined implicit conversions.
23179 Fixes #34165. Added test-173.cs.
23181 2002-11-16 Martin Baulig <martin@ximian.com>
23183 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23184 with the `true' and `false' literals. Fixes #33151.
23186 2002-11-16 Martin Baulig <martin@ximian.com>
23188 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23189 October 22nd; don't do the cs1540 check for static members.
23191 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23192 now using our own filter here and doing the cs1540 check again.
23194 2002-11-16 Martin Baulig <martin@ximian.com>
23196 * support.cs (InternalParameters): Don't crash if we don't have
23197 any fixed parameters. Fixes #33532.
23199 2002-11-16 Martin Baulig <martin@ximian.com>
23201 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23202 when looking up static methods to make this work on Windows.
23205 2002-11-16 Martin Baulig <martin@ximian.com>
23207 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23208 a setter rather than using PropertyInfo.CanWrite.
23210 2002-11-15 Nick Drochak <ndrochak@gol.com>
23212 * class.cs: Allow acces to block member by subclasses. Fixes build
23215 2002-11-14 Martin Baulig <martin@ximian.com>
23217 * class.cs (Constructor.Emit): Added the extern/block check.
23220 2002-11-14 Martin Baulig <martin@ximian.com>
23222 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23223 iteration while looking for indexers, this is needed because the
23224 indexer may have a different name in our base classes. Fixed the
23225 error reporting (no indexers at all, not get accessor, no
23226 overloaded match). Fixes bug #33089.
23227 (IndexerAccess.DoResolveLValue): Likewise.
23229 2002-11-14 Martin Baulig <martin@ximian.com>
23231 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23232 indexers. Fixes the first part of bug #33089.
23233 (MethodSignature.InheritableMemberSignatureCompare): Added support
23236 2002-11-13 Ravi Pratap <ravi@ximian.com>
23238 * attribute.cs (Attribute.Resolve): Catch the
23239 NullReferenceException and report it since it isn't supposed to
23242 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23244 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23245 LogicalOr and LogicalAnd that can benefit from recursively
23246 handling EmitBranchable. The code now should be nice for Paolo.
23248 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23250 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23251 the Type lookups, as we perform quite a number of lookups on
23252 non-Types. This can be removed once we can deterministically tell
23253 whether we have a type or a namespace in advance.
23255 But this might require special hacks from our corlib.
23259 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23260 and double which avoids a conversion from an integer to a double.
23262 * expression.cs: tiny optimization, avoid calling IsConstant,
23263 because it effectively performs the lookup twice.
23265 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23267 But a bogus return here to keep the semantics of the old code
23268 until the Mono runtime is fixed.
23270 * pending.cs (GetMissingInterfaces): New method used to remove all
23271 the interfaces that are already implemented by our parent
23272 classes from the list of pending methods.
23274 * interface.cs: Add checks for calls after ResolveTypeExpr.
23276 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23278 * class.cs (Class.Emit): Report warning 67: event not used if the
23279 warning level is beyond 3.
23281 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23282 being a NullLiteral.
23284 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23287 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23288 path that might fail if a type can not be resolved.
23290 * expression.cs (Binary.Emit): Emit unsigned versions of the
23293 * driver.cs: use error 5.
23295 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23297 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23299 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23301 * cs-parser.jay (switch_section): A beautiful patch from Martin
23302 Baulig that fixed 33094.
23304 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23306 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23307 Check whether the base is abstract and report an error if so.
23309 * expression.cs (IndexerAccess.DoResolveLValue,
23310 IndexerAccess.DoResolve): ditto.
23312 (Invocation.DoResolve): ditto.
23314 (Invocation.FullMethodDesc): Improve the report string.
23316 * statement.cs (Block): Eliminate IsVariableDefined as it is
23317 basically just a wrapper for GetVariableInfo.
23319 * ecore.cs (SimpleName): Use new
23321 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23322 type, as we return the actual parameter ref/unref state on a
23325 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23327 * support.cs: Return proper flags REF/OUT fixing the previous
23330 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23331 not used to mean `ref' but `ref or out' in ParameterReference
23333 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23334 full type signature instead of calling TypeManger.CSharpName
23337 * support.cs (InternalParameters.ParameterDesc): Do not compare
23338 directly to the modflags, because REF/OUT will actually be bitsets
23341 * delegate.cs (VerifyMethod): Check also the modifiers.
23343 * cs-tokenizer.cs: Fix bug where floating point values with an
23344 exponent where a sign was missing was ignored.
23346 * driver.cs: Allow multiple assemblies to be specified in a single
23349 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23351 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23352 because identifiers after a parenthesis would end up in this kind
23353 of production, and we needed to desamiguate it for having casts
23356 (UserDefinedType *) xxx
23358 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23360 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23361 we should set on the Bindingflags.NonPublic, but not turn on
23362 private_ok. private_ok controls whether a Private member is
23363 returned (this is chekced on the filter routine), while the
23364 BindingFlags.NonPublic just controls whether private/protected
23365 will be allowed. This fixes the problem part of the problem of
23366 private properties being allowed to be used in derived classes.
23368 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23369 so we can call the children DoResolveLValue method (this will
23370 properly signal errors on lvalue assignments to base properties)
23372 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23373 getter are null, and we have a property info, we know that this
23374 happened because the lookup failed, so we report an error 122 for
23375 protection level violation.
23377 We also silently return if setter and getter are null in the
23378 resolve functions, this condition only happens if we have flagged
23379 the error before. This is the other half of the problem.
23381 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23382 not have accessibility information, that is why we were returning
23383 true in the filter function in typemanager.cs.
23385 To properly report 122 (property is inaccessible because of its
23386 protection level) correctly, we report this error in ResolveAccess
23387 by failing if both the setter and the getter are lacking (ie, the
23390 DoResolve and DoLResolve have been modified to check for both
23391 setter/getter being null and returning silently, the reason being
23392 that I did not want to put the knowledge about this error in upper
23395 int old = Report.Errors;
23396 x = new PropertyExpr (...);
23397 if (old != Report.Errors)
23402 So the property expr is returned, but it is invalid, so the error
23403 will be flagged during the resolve process.
23405 * class.cs: Remove InheritablePropertySignatureCompare from the
23406 class, as we no longer depend on the property signature to compute
23407 whether it is possible to implement a method or not.
23409 The reason is that calling PropertyInfo.GetGetMethod will return
23410 null (in .NET, in Mono it works, and we should change this), in
23411 cases where the Get Method does not exist in that particular
23416 class X { public virtual int A { get { return 1; } } }
23418 class Z : Y { public override int A { get { return 2; } } }
23420 Would fail in Z because the parent (Y) would not have the property
23421 defined. So we avoid this completely now (because the alternative
23422 fix was ugly and slow), and we now depend exclusively on the
23425 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23426 reference method, instead of using the property.
23428 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23429 routines are gone now.
23431 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23432 names, they were incorrectly named.
23434 * cs-tokenizer.cs: Return are more gentle token on failure.
23436 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23437 had an out-of-sync index variable, which caused it to remove from
23438 the list of pending methods the wrong method sometimes.
23440 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23442 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23443 CanWrite, because those refer to this particular instance of the
23444 property, and do not take into account the fact that we can
23445 override single members of a property.
23447 Constructor requires an EmitContext. The resolution process does
23448 not happen here, but we need to compute the accessors before,
23449 because the resolution does not always happen for properties.
23451 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23452 subclass, before we did not update this flag, but we did update
23455 (GetAccessors): Drop this routine, as it did not work in the
23456 presence of partially overwritten set/get methods.
23458 Notice that this broke the cs1540 detection, but that will require
23461 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23465 * driver.cs: issue a warning instead of an error if we don't support
23466 debugging for the platform. Also ignore a couple of errors that may
23467 arise when trying to write the symbols. Undo my previous patch.
23469 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23471 * driver.cs: ignore /debug switch except for Unix platforms.
23473 2002-10-23 Nick Drochak <ndrochak@gol.com>
23475 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23477 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23479 * driver.cs: Do not make mcs-debug conditional, so we do not break
23480 builds that use it.
23482 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23483 review this patch. But basically after all the children variables
23484 have been merged, the value of "Breaks" was not being set to
23485 new_breaks for Switch blocks. I think that it should be set after
23486 it has executed. Currently I set this to the value of new_breaks,
23487 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23488 conservative, but I do not understand this code very well.
23490 I did not break anything in the build, so that is good ;-)
23492 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23494 2002-10-20 Mark Crichton <crichton@gimp.org>
23496 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23498 2002-10-20 Nick Drochak <ndrochak@gol.com>
23500 * cfold.cs: Fixed compile blocker.
23502 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23504 * driver.cs: I was chekcing the key, not the file.
23506 2002-10-19 Ravi Pratap <ravi@ximian.com>
23508 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23509 message that we were generating - we just need to silently return
23512 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23514 * class.cs (Event.Define): Change my previous commit, as this
23515 breaks the debugger. This is a temporary hack, as it seems like
23516 the compiler is generating events incorrectly to begin with.
23518 * expression.cs (Binary.ResolveOperator): Added support for
23519 "U operator - (E x, E y)"
23521 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23524 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23525 init-only variables, but this path did not take into account that
23526 there might be also instance readonly variables. Correct this
23529 This fixes bug 32253
23531 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23534 * driver.cs: Change the extension for modules to `netmodule'
23536 * cs-parser.jay: Improved slightly the location tracking for
23537 the debugger symbols.
23539 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23540 modifiers that were specified instead of the hardcoded value
23541 (FamAndAssem). This was basically ignoring the static modifier,
23542 and others. Fixes 32429.
23544 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23545 fixed a bug in the process (32476)
23547 * expression.cs (ArrayAccess.EmitAssign): Patch from
23548 hwang_rob@yahoo.ca that fixes bug 31834.3
23550 2002-10-18 Miguel de Icaza <miguel@ximian.com>
23552 * driver.cs: Make the module extension .netmodule.
23554 2002-10-16 Miguel de Icaza <miguel@ximian.com>
23556 * driver.cs: Report an error if the resource file is not found
23557 instead of crashing.
23559 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
23560 false, like Emit does.
23562 2002-10-16 Nick Drochak <ndrochak@gol.com>
23564 * typemanager.cs: Remove unused private member. Also reported mcs
23565 bug to report this as a warning like csc.
23567 2002-10-15 Martin Baulig <martin@gnome.org>
23569 * statement.cs (Statement.Emit): Made this a virtual method; emits
23570 the line number info and calls DoEmit().
23571 (Statement.DoEmit): New protected abstract method, formerly knows
23572 as Statement.Emit().
23574 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
23576 2002-10-11 Miguel de Icaza <miguel@ximian.com>
23578 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
23579 have fixed a remaining problem: not every AddXXXX was adding a
23580 fully qualified name.
23582 Now everyone registers a fully qualified name in the DeclSpace as
23583 being defined instead of the partial name.
23585 Downsides: we are slower than we need to be due to the excess
23586 copies and the names being registered this way.
23588 The reason for this is that we currently depend (on the corlib
23589 bootstrap for instance) that types are fully qualified, because
23590 we dump all the types in the namespace, and we should really have
23591 types inserted into the proper namespace, so we can only store the
23592 basenames in the defined_names array.
23594 2002-10-10 Martin Baulig <martin@gnome.org>
23596 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
23597 from bug #31834, see the bug report for a testcase which is
23600 2002-10-10 Martin Baulig <martin@gnome.org>
23602 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
23603 flow analysis code for this.
23605 * statement.cs (Do, While, For): Tell the flow analysis code about
23607 (FlowBranching.UsageVector): Added support for infinite loops.
23608 (Block.Resolve): Moved the dead code elimination here and use flow
23611 2002-10-09 Miguel de Icaza <miguel@ximian.com>
23613 * class.cs (Field.Define): Catch cycles on struct type
23616 * typemanager.cs (IsUnmanagedtype): Do not recursively check
23617 fields if the fields are static. We only need to check instance
23620 * expression.cs (As.DoResolve): Test for reference type.
23622 * statement.cs (Using.ResolveExpression): Use
23623 ConvertImplicitRequired, not ConvertImplicit which reports an
23625 (Using.ResolveLocalVariableDecls): ditto.
23627 * expression.cs (Binary.ResolveOperator): Report errors in a few
23628 places where we had to.
23630 * typemanager.cs (IsUnmanagedtype): Finish implementation.
23632 2002-10-08 Miguel de Icaza <miguel@ximian.com>
23634 * expression.cs: Use StoreFromPtr instead of extracting the type
23635 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
23637 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
23638 an enumeration value to a System.Enum, but System.Enum is not a
23639 value type, but an class type, so we need to box.
23641 (Expression.ConvertExplicit): One codepath could return
23642 errors but not flag them. Fix this. Fixes #31853
23644 * parameter.cs (Resolve): Do not allow void as a parameter type.
23646 2002-10-06 Martin Baulig <martin@gnome.org>
23648 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
23649 if it's a class type and not a struct. Fixes #31815.
23651 2002-10-06 Martin Baulig <martin@gnome.org>
23653 * statement.cs: Reworked the flow analysis code a bit to make it
23654 usable for dead code elimination.
23656 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23658 * cs-parser.jay: allow empty source files. Fixes bug #31781.
23660 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23662 * expression.cs (ComposedCast.DoResolveType): A quick workaround
23663 to fix the test 165, will investigate deeper.
23665 2002-10-04 Martin Baulig <martin@gnome.org>
23667 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
23668 finally blocks actually work.
23669 (Try.Resolve): We don't need to create a sibling for `finally' if
23670 there is no finally block.
23672 2002-10-04 Martin Baulig <martin@gnome.org>
23674 * class.cs (Constructor.Define): The default accessibility for a
23675 non-default constructor is private, not public.
23677 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23679 * class.cs (Constructor): Make AllowedModifiers public, add
23682 * cs-parser.jay: Perform the modifiers test here, as the
23683 constructor for the Constructor class usually receives a zero
23684 because of the way we create it (first we create, later we
23685 customize, and we were never checking the modifiers).
23687 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
23688 is a version of LookupTypeReflection that includes the type-name
23689 cache. This can be used as a fast path for functions that know
23690 the fully qualified name and are only calling into *.GetType() to
23691 obtain a composed type.
23693 This is also used by TypeManager.LookupType during its type
23696 (LookupType): We now also track the real type name, as sometimes
23697 we can get a quey for the real type name from things like
23698 ComposedCast. This fixes bug 31422.
23700 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
23701 complete type fullname, it does not have to go through the type
23702 resolution system to obtain the composed version of the type (for
23703 obtaining arrays or pointers).
23705 (Conditional.Emit): Use the EmitBoolExpression to
23706 generate nicer code, as requested by Paolo.
23708 (ArrayCreation.CheckIndices): Use the patch from
23709 hwang_rob@yahoo.ca to validate the array initializers.
23711 2002-10-03 Miguel de Icaza <miguel@ximian.com>
23713 * class.cs (ConstructorInitializer.Emit): simplify code by using
23714 Invocation.EmitCall, and at the same time, fix the bugs in calling
23715 parent constructors that took variable arguments.
23717 * ecore.cs (Expression.ConvertNumericExplicit,
23718 Expression.ImplicitNumericConversion): Remove the code that
23719 manually wrapped decimal (InternalTypeConstructor call is now gone
23722 * expression.cs (Cast.TryReduce): Also handle decimal types when
23723 trying to perform a constant fold on the type.
23725 * typemanager.cs (IsUnmanagedtype): Partially implemented.
23727 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
23728 that only turned off an error report, and did nothing else.
23730 2002-10-02 Miguel de Icaza <miguel@ximian.com>
23732 * driver.cs: Handle and ignore /fullpaths
23734 2002-10-01 Miguel de Icaza <miguel@ximian.com>
23736 * expression.cs (Binary.ResolveOperator): Catch the case where
23737 DoNumericPromotions returns true,
23739 (Binary.DoNumericPromotions): Simplify the code, and the tests.
23741 2002-09-27 Miguel de Icaza <miguel@ximian.com>
23743 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
23746 2002-09-26 Miguel de Icaza <miguel@ximian.com>
23748 * ecore.cs (ConvertNumericExplicit): It is not enough that the
23749 conversion exists, but it is also required that the conversion be
23750 performed. This manifested in "(Type64Enum) 2".
23752 * class.cs (TypeManager.AddMethod): The fix is not to change
23753 AddEnum, because that one was using a fully qualified name (every
23754 DeclSpace derivative does), but to change the AddMethod routine
23755 that was using an un-namespaced name. This now correctly reports
23756 the duplicated name.
23758 Revert patch until I can properly fix it. The issue
23759 is that we have a shared Type space across all namespaces
23760 currently, which is wrong.
23762 Options include making the Namespace a DeclSpace, and merge
23763 current_namespace/current_container in the parser.
23765 2002-09-25 Miguel de Icaza <miguel@ximian.com>
23767 * cs-parser.jay: Improve error reporting when we get a different
23768 kind of expression in local_variable_type and
23769 local_variable_pointer_type.
23771 Propagate this to avoid missleading errors being reported.
23773 * ecore.cs (ImplicitReferenceConversion): treat
23774 TypeManager.value_type as a target just like object_type. As
23779 Is valid, and needs to result in the int 1 being boxed before it
23780 is assigned to the value type v.
23782 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
23783 to validate the enumeration name.
23785 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
23786 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
23787 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
23789 * ecore.cs (TryImplicitIntConversion): When doing an
23790 implicit-enumeration-conversion, check if the type is 64-bits and
23791 perform a conversion before passing to EnumConstant.
23793 2002-09-23 Miguel de Icaza <miguel@ximian.com>
23795 * decl.cs (Error_AmbiguousTypeReference); New routine used to
23796 report ambiguous type references. Unlike the MS version, we
23797 report what the ambiguity is. Innovation at work ;-)
23799 (DeclSpace.FindType): Require a location argument to
23800 display when we display an ambiguous error.
23802 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
23804 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
23806 * expression.cs (EmitDynamicInitializers): Apply patch from
23807 hwang_rob@yahoo.ca that fixes the order in which we emit our
23810 2002-09-21 Martin Baulig <martin@gnome.org>
23812 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
23813 delegate takes no arguments.
23815 2002-09-20 Miguel de Icaza <miguel@ximian.com>
23817 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
23820 * expression.cs: Extract the underlying type.
23822 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
23824 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
23826 2002-09-19 Miguel de Icaza <miguel@ximian.com>
23828 * class.cs (TypeContainer.DefineType): We can not use the nice
23829 PackingSize with the size set to 1 DefineType method, because it
23830 will not allow us to define the interfaces that the struct
23833 This completes the fixing of bug 27287
23835 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
23836 means also structs. This fixes part of the problem.
23837 (Expresion.ImplicitReferenceConversionExists): ditto.
23839 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
23840 error if there were no errors reported during the type lookup
23841 process, to avoid duplicates or redundant errors. Without this
23842 you would get an ambiguous errors plus a type not found. We have
23843 beaten the user enough with the first error.
23845 (DeclSparce.FindType): Emit a warning if we have an ambiguous
23848 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
23849 during the resolution process, stop the lookup, this avoids
23850 repeated error reports (same error twice).
23852 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
23854 * typemanager.cs (LookupType): Redo the type lookup code to match
23855 the needs of System.Reflection.
23857 The issue is that System.Reflection requires references to nested
23858 types to begin with a "+" sign instead of a dot. So toplevel
23859 types look like: "NameSpace.TopLevelClass", and nested ones look
23860 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
23863 2002-09-19 Martin Baulig <martin@gnome.org>
23865 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
23866 says that a method always returns or always throws an exception,
23867 don't report the CS0161.
23869 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
23870 set `Returns = new_returns'.
23872 2002-09-19 Martin Baulig <martin@gnome.org>
23874 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
23875 to an enum constant, check for a CS0176.
23877 2002-09-18 Miguel de Icaza <miguel@ximian.com>
23879 * class.cs (TypeContainer.CheckPairedOperators): Now we check
23880 for operators that must be in pairs and report errors.
23882 * ecore.cs (SimpleName.DoResolveType): During the initial type
23883 resolution process, when we define types recursively, we must
23884 check first for types in our current scope before we perform
23885 lookups in the enclosing scopes.
23887 * expression.cs (MakeByteBlob): Handle Decimal blobs.
23889 (Invocation.VerifyArgumentsCompat): Call
23890 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
23891 I thought we were supposed to always call this, but there are a
23892 few places in the code where we dont do it.
23894 2002-09-17 Miguel de Icaza <miguel@ximian.com>
23896 * driver.cs: Add support in -linkres and -resource to specify the
23897 name of the identifier.
23899 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23901 * ecore.cs (StandardConversionExists): Sync with the conversion
23902 code: allow anything-* to void* conversions.
23904 (FindMostSpecificSource): Use an Expression argument
23905 instead of a Type, because we might be handed over a Literal which
23906 gets a few more implicit conversions that plain types do not. So
23907 this information was being lost.
23909 Also, we drop the temporary type-holder expression when not
23912 2002-09-17 Martin Baulig <martin@gnome.org>
23914 * class.cs (PropertyBase.CheckBase): Don't check the base class if
23915 this is an explicit interface implementation.
23917 2002-09-17 Martin Baulig <martin@gnome.org>
23919 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
23920 different `IndexerName' attributes.
23922 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
23923 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
23924 virtual CommonResolve().
23926 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23928 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
23929 and convert that to the UnderlyingType.
23931 * statement.cs (Foreach.Resolve): Indexers are just like variables
23932 or PropertyAccesses.
23934 * cs-tokenizer.cs (consume_string): Track line numbers and columns
23935 inside quoted strings, we were not doing this before.
23937 2002-09-16 Martin Baulig <martin@gnome.org>
23939 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
23940 resolve it. This is needed for the definite assignment check of the
23941 instance expression, fixes bug #29846.
23942 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
23944 2002-09-16 Nick Drochak <ndrochak@gol.com>
23946 * parameter.cs: Fix compile error. Cannot reference static member
23947 from an instance object. Is this an mcs bug?
23949 2002-09-14 Martin Baulig <martin@gnome.org>
23951 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
23952 multiple times. Fixes bug #30295, added test-166.cs.
23954 2002-09-14 Martin Baulig <martin@gnome.org>
23956 * statement.cs (Block.Emit): Don't emit unreachable code.
23957 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
23958 `break' statements.
23959 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
23961 2002-09-14 Martin Baulig <martin@gnome.org>
23963 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
23966 2002-09-14 Martin Baulig <martin@gnome.org>
23968 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
23969 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
23970 be false on the ms runtime.
23972 2002-09-13 Martin Baulig <martin@gnome.org>
23974 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
23975 the CS0038 error message.
23977 2002-09-12 Miguel de Icaza <miguel@ximian.com>
23979 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
23980 constant inside, return it.
23982 2002-09-12 Martin Baulig <martin@gnome.org>
23984 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
23985 implicit conversion can be done between enum types.
23987 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
23988 check whether an implicit conversion to the current enum's UnderlyingType
23989 exists and report an error if not.
23991 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
23992 without debugging support.
23994 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
23995 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
23997 2002-09-12 Martin Baulig <martin@gnome.org>
23999 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24001 * ecore.cs (IMemberExpr.DeclaringType): New property.
24002 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24003 nonstatic member of an outer type (CS0038).
24005 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24007 * driver.cs: Activate the using-error detector at warning level
24008 4 (at least for MS-compatible APIs).
24010 * namespace.cs (VerifyUsing): Small buglett fix.
24012 * pending.cs (PendingImplementation): pass the container pointer.
24014 * interface.cs (GetMethods): Allow for recursive definition. Long
24015 term, I would like to move every type to support recursive
24016 definitions, not the current ordering mechanism that we have right
24019 The situation is this: Attributes are handled before interfaces,
24020 so we can apply attributes to interfaces. But some attributes
24021 implement interfaces, we will now handle the simple cases
24022 (recursive definitions will just get an error).
24024 * parameter.cs: Only invalidate types at the end if we fail to
24027 2002-09-09 Martin Baulig <martin@gnome.org>
24029 * ecore.cs (PropertyExpr.Emit): Also check for
24030 TypeManager.system_int_array_get_length so this'll also work when
24031 compiling corlib. Fixes #30003.
24033 2002-09-09 Martin Baulig <martin@gnome.org>
24035 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24036 and throw an exception if we can't get the type's size. Fixed #30040,
24039 2002-09-09 Martin Baulig <martin@gnome.org>
24041 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24043 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24044 context. Fixes bug #30027.
24046 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24047 virtual functions. Fixes bug #30043, added test-164.cs.
24049 2002-09-08 Ravi Pratap <ravi@ximian.com>
24051 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24053 2002-09-08 Nick Drochak <ndrochak@gol.com>
24055 * driver.cs: Use an object to get the windows codepage since it's not a
24058 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24060 * statement.cs (For.Emit): for infinite loops (test == null)
24061 return whether there is a break inside, not always "true".
24063 * namespace.cs (UsingEntry): New struct to hold the name of the
24064 using definition, the location where it is defined, and whether it
24065 has been used in a successful type lookup.
24067 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24072 2002-09-06 Ravi Pratap <ravi@ximian.com>
24074 * attribute.cs : Fix incorrect code which relied on catching
24075 a NullReferenceException to detect a null being passed in
24076 where an object was expected.
24078 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24080 * statement.cs (Try): flag the catch variable as assigned
24082 * expression.cs (Cast): Simplified by using ResolveType instead of
24083 manually resolving.
24085 * statement.cs (Catch): Fix bug by using ResolveType.
24087 2002-09-06 Ravi Pratap <ravi@ximian.com>
24089 * expression.cs (BetterConversion): Special case for when we have
24090 a NullLiteral as the argument and we have to choose between string
24091 and object types - we choose string the way csc does.
24093 * attribute.cs (Attribute.Resolve): Catch the
24094 NullReferenceException and report error #182 since the Mono
24095 runtime no more has the bug and having this exception raised means
24096 we tried to select a constructor which takes an object and is
24099 2002-09-05 Ravi Pratap <ravi@ximian.com>
24101 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24102 message (1502, 1503) when we can't locate a method after overload
24103 resolution. This is much more informative and closes the bug
24106 * interface.cs (PopulateMethod): Return if there are no argument
24107 types. Fixes a NullReferenceException bug.
24109 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24110 expressions too. Previously we were checking only in one place for
24111 positional arguments leaving out named arguments.
24113 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24114 type to the enum type is not allowed. Remove code corresponding to
24117 (ConvertNumericExplicit): Allow explicit conversions from
24118 the underlying type to enum type. This precisely follows the spec
24119 and closes a bug filed by Gonzalo.
24121 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24124 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24126 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24128 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24129 it was important that we stored the right value after the
24130 reduction in `converted'.
24132 2002-09-04 Martin Baulig <martin@gnome.org>
24134 * location.cs (Location.SymbolDocument): Use full pathnames for the
24137 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24139 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24140 of the expression resolve mechanism, because that will catch the
24141 SimpleName error failures.
24143 (Conditional): If we can not resolve the
24144 expression, return, do not crash.
24146 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24149 (location): display token name instead of its number.
24151 2002-08-28 Martin Baulig <martin@gnome.org>
24153 * expression.cs (Binary.ResolveOperator): Don't silently return
24154 but return an error if an operator cannot be applied between two
24157 2002-08-28 Martin Baulig <martin@gnome.org>
24159 * class.cs (Constructor.Define): Set the permission attributes
24160 correctly instead of making all constructors public.
24162 2002-08-28 Martin Baulig <martin@gnome.org>
24164 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24165 for private members before reporting a CS0103; if we find anything,
24168 2002-08-28 Martin Baulig <martin@gnome.org>
24170 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24171 to check whether `closure_start_type == closure_invocation_type',
24172 we also need to check whether `m.DeclaringType == closure_invocation_type'
24173 before bypassing the permission checks. We might be accessing
24174 protected/private members from the base class.
24175 (TypeManager.RealMemberLookup): Only set private_ok if private
24176 members were requested via BindingFlags.NonPublic.
24178 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24180 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24181 MethodGroupExpr.IsExplicitImpl if appropriate.
24182 (Invocation.DoResolve): Don't report the CS0120 for explicit
24183 interface implementations.
24185 2002-08-27 Martin Baulig <martin@gnome.org>
24187 * expression.cs (Invocation.DoResolve): If this is a static
24188 method and we don't have an InstanceExpression, we must report
24191 2002-08-25 Martin Baulig <martin@gnome.org>
24193 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24194 `==' between a valuetype and an object.
24196 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24198 * ecore.cs (TypeExpr): Provide a ToString method.
24200 2002-08-24 Martin Baulig <martin@gnome.org>
24202 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24203 now called proggie.dbg and it's a binary file.
24205 2002-08-23 Martin Baulig <martin@gnome.org>
24207 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24209 2002-08-23 Martin Baulig <martin@gnome.org>
24211 * struct.cs (MyStructInfo.ctor): Make this work with empty
24212 structs; it's not allowed to use foreach() on null.
24214 2002-08-23 Martin Baulig <martin@gnome.org>
24216 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24217 writer the full pathname of the generated assembly.
24219 2002-08-23 Martin Baulig <martin@gnome.org>
24221 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24222 A `finally' block never returns or breaks; improved handling of
24225 2002-08-23 Martin Baulig <martin@gnome.org>
24227 * statement.cs (Throw.Resolve): Allow `throw null'.
24229 2002-08-23 Martin Baulig <martin@gnome.org>
24231 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24232 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24233 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24234 MemberLookup would return a wrong event if this is an explicit
24235 interface implementation and the class has an event with the same
24238 2002-08-23 Martin Baulig <martin@gnome.org>
24240 * statement.cs (Block.AddChildVariableNames): New public method.
24241 (Block.AddChildVariableName): Likewise.
24242 (Block.IsVariableNameUsedInChildBlock): Likewise.
24243 (Block.AddVariable): Check whether a variable name has already
24244 been used in a child block.
24246 * cs-parser.jay (declare_local_variables): Mark all variable names
24247 from the current block as being used in a child block in the
24250 2002-08-23 Martin Baulig <martin@gnome.org>
24252 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24253 find the symbol writer.
24255 * driver.cs: csc also allows the arguments to /define being
24256 separated by commas, not only by semicolons.
24258 2002-08-23 Martin Baulig <martin@gnome.org>
24260 * interface.cs (Interface.GetMembers): Added static check for events.
24262 2002-08-15 Martin Baulig <martin@gnome.org>
24264 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24265 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24267 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24268 why the MethodData.EmitDestructor() change was necessary.
24270 2002-08-20 Martin Baulig <martin@gnome.org>
24272 * class.cs (TypeContainer.FindMembers): Added static check for events.
24274 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24276 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24277 use Type.GetEvents(), not Type.FindMembers().
24279 2002-08-20 Martin Baulig <martin@gnome.org>
24281 * decl.cs (MemberCache): Added a special method cache which will
24282 be used for method-only searched. This ensures that a method
24283 search will return a MethodInfo with the correct ReflectedType for
24286 2002-08-20 Martin Baulig <martin@gnome.org>
24288 * decl.cs (DeclSpace.FindMembers): Made this public.
24290 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24292 * delegate.cs: fixed build on windows.
24293 [FIXME: Filed as bug #29150: MCS must report these errors.]
24295 2002-08-19 Ravi Pratap <ravi@ximian.com>
24297 * ecore.cs (StandardConversionExists): Return a false
24298 if we are trying to convert the void type to anything else
24299 since that is not allowed.
24301 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24302 we flag error 70 in the event an event is trying to be accessed
24303 directly from outside the declaring type.
24305 2002-08-20 Martin Baulig <martin@gnome.org>
24307 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24308 MemberCache from typemanager.cs to decl.cs.
24310 2002-08-19 Martin Baulig <martin@gnome.org>
24312 * class.cs (TypeContainer): Implement IMemberContainer.
24313 (TypeContainer.DefineMembers): Create the MemberCache.
24314 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24315 return public members if BindingFlags.Public was given, check
24316 whether members are static.
24318 2002-08-16 Martin Baulig <martin@gnome.org>
24320 * decl.cs (DeclSpace.Define): Splitted this in Define and
24321 DefineMembers. DefineMembers is called first and initializes the
24324 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24325 DefineMembers() on all our DeclSpaces.
24327 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24328 but call DefineMembers() on all nested interfaces. We call their
24329 Define() in our new Define() function.
24331 * interface.cs (Interface): Implement IMemberContainer.
24332 (Interface.Define): Moved all code except the attribute stuf to
24334 (Interface.DefineMembers): Initialize the member cache.
24336 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24337 need this anymore since we can use MemberCache.FindMembers directly.
24339 2002-08-19 Martin Baulig <martin@gnome.org>
24341 * typemanager.cs (MemberCache): When creating the cache for an
24342 interface type, add all inherited members.
24343 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24344 to `out bool used_cache' and documented it.
24345 (TypeManager.MemberLookup): If we already used the cache in the first
24346 iteration, we don't need to do the interfaces check.
24348 2002-08-19 Martin Baulig <martin@gnome.org>
24350 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24351 here from IMemberFinder and don't implement this interface anymore.
24352 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24354 * typemanager.cs (IMemberFinder): This interface is now only used by
24355 classes which actually support the member cache.
24356 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24357 since we only put DeclSpaces into this Hashtable.
24358 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24359 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24361 2002-08-16 Martin Baulig <martin@gnome.org>
24363 * typemanager.cs (ICachingMemberFinder): Removed.
24364 (IMemberFinder.MemberCache): New property.
24365 (TypeManager.FindMembers): Merged this with RealFindMembers().
24366 This function will never be called from TypeManager.MemberLookup()
24367 so we can't use the cache here, just the IMemberFinder.
24368 (TypeManager.MemberLookup_FindMembers): Check whether the
24369 IMemberFinder has a MemberCache and call the cache's FindMembers
24371 (MemberCache): Rewrote larger parts of this yet another time and
24372 cleaned it up a bit.
24374 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24376 * driver.cs (LoadArgs): Support quoting.
24378 (Usage): Show the CSC-like command line arguments.
24380 Improved a few error messages.
24382 2002-08-15 Martin Baulig <martin@gnome.org>
24384 * typemanager.cs (IMemberContainer.Type): New property.
24385 (IMemberContainer.IsInterface): New property.
24387 The following changes are conditional to BROKEN_RUNTIME, which is
24388 defined at the top of the file.
24390 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24391 class'es members, but add all members from TypeHandle.ObjectType
24392 if we're an interface.
24393 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24394 is the current type.
24395 (MemberCache.CacheEntry.Container): Removed this field.
24396 (TypeHandle.GetMembers): Include inherited members.
24398 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24400 * typemanager.cs: fixed compilation and added a comment on a field that
24403 2002-08-15 Martin Baulig <martin@gnome.org>
24405 * class.cs (ConstructorInitializer.Resolve): In the
24406 Expression.MemberLookup call, use the queried_type as
24409 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24410 declared' attribute, it's always true.
24411 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24412 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24413 temporary wrapper for FindMembers which tells MemberLookup whether
24414 members from the base classes are included in the return value.
24415 This will go away soon.
24416 (TypeManager.MemberLookup): Use this temporary hack here; once the
24417 new MemberCache is completed, we don't need to do the DeclaredOnly
24418 looping here anymore since the MemberCache will take care of this.
24419 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24420 (MemberCache): When creating the MemberCache for a class, get
24421 members from the current class and all its base classes.
24422 (MemberCache.CacheEntry.Container): New field. This is a
24423 temporary hack until the Mono runtime is fixed to distinguish
24424 between ReflectedType and DeclaringType. It allows us to use MCS
24425 with both the MS runtime and the unfixed Mono runtime without
24426 problems and without accecting performance.
24427 (MemberCache.SearchMembers): The DeclaredOnly looping from
24428 TypeManager.MemberLookup is now done here.
24430 2002-08-14 Martin Baulig <martin@gnome.org>
24432 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24433 Type.GetFields on dynamic types but get the fields from the
24434 corresponding TypeContainer.
24435 (MyStructInfo.GetStructInfo): Added check for enum types.
24437 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24438 (MemberList.SyncRoot): Implemented.
24439 (TypeManager.FilterWithClosure): No need to check permissions if
24440 closure_start_type == closure_invocation_type, don't crash if
24441 closure_invocation_type is null.
24443 2002-08-13 Martin Baulig <martin@gnome.org>
24445 Rewrote TypeContainer.FindMembers to use a member cache. This
24446 gives us a speed increase of about 35% for the self-hosting MCS
24447 build and of about 15-20% for the class libs (both on GNU/Linux).
24449 * report.cs (Timer): New class to get enhanced profiling. This
24450 whole class is "TIMER" conditional since it remarkably slows down
24453 * class.cs (MemberList): New class. This is an IList wrapper
24454 which we're now using instead of passing MemberInfo[]'s around to
24455 avoid copying this array unnecessarily.
24456 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24457 (ICachingMemberFinder, IMemberContainer): New interface.
24458 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24459 has already been checked, otherwise use it for the name comparision.
24460 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24461 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24462 if possible. Returns a MemberList, not a MemberInfo [].
24463 (TypeHandle): New class, implements IMemberContainer. We create
24464 one instance of this class per type, it contains a MemberCache
24465 which is used to do the member lookups.
24466 (MemberCache): New class. Each instance of this class contains
24467 all members of a type and a name-based hash table.
24468 (MemberCache.FindMembers): This is our new member lookup
24469 function. First, it looks up all members of the requested name in
24470 the hash table. Then, it walks this list and sorts out all
24471 applicable members and returns them.
24473 2002-08-13 Martin Baulig <martin@gnome.org>
24475 In addition to a nice code cleanup, this gives us a performance
24476 increase of about 1.4% on GNU/Linux - not much, but it's already
24477 half a second for the self-hosting MCS compilation.
24479 * typemanager.cs (IMemberFinder): New interface. It is used by
24480 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24481 Enum, Delegate or Interface.
24482 (TypeManager.finder_to_member_finder): New PtrHashtable.
24483 (TypeManager.finder_to_container): Removed.
24484 (TypeManager.finder_to_delegate): Removed.
24485 (TypeManager.finder_to_interface): Removed.
24486 (TypeManager.finder_to_enum): Removed.
24488 * interface.cs (Interface): Implement IMemberFinder.
24490 * delegate.cs (Delegate): Implement IMemberFinder.
24492 * enum.cs (Enum): Implement IMemberFinder.
24494 * class.cs (TypeContainer): Implement IMemberFinder.
24496 2002-08-12 Martin Baulig <martin@gnome.org>
24498 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24500 2002-08-12 Martin Baulig <martin@gnome.org>
24502 * ecore.cs (ITypeExpression): New interface for expressions which
24504 (TypeExpression): Renamed to TypeLookupExpression.
24505 (Expression.DoResolve): If we're doing a types-only lookup, the
24506 expression must implement the ITypeExpression interface and we
24507 call DoResolveType() on it.
24508 (SimpleName): Implement the new ITypeExpression interface.
24509 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24510 hack, the situation that we're only looking up types can't happen
24511 anymore when this method is called. Moved the type lookup code to
24512 DoResolveType() and call it.
24513 (SimpleName.DoResolveType): This ITypeExpression interface method
24514 is now doing the types-only lookup.
24515 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24516 (ResolveFlags): Added MaskExprClass.
24518 * expression.cs (MemberAccess): Implement the ITypeExpression
24520 (MemberAccess.DoResolve): Added support for a types-only lookup
24521 when we're called via ITypeExpression.DoResolveType().
24522 (ComposedCast): Implement the ITypeExpression interface.
24524 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24525 Expression.Resolve() with ResolveFlags.Type instead.
24527 2002-08-12 Martin Baulig <martin@gnome.org>
24529 * interface.cs (Interface.Define): Apply attributes.
24531 * attribute.cs (Attribute.ApplyAttributes): Added support for
24532 interface attributes.
24534 2002-08-11 Martin Baulig <martin@gnome.org>
24536 * statement.cs (Block.Emit): Only check the "this" variable if we
24537 do not always throw an exception.
24539 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24540 whether the property has a set accessor.
24542 2002-08-11 Martin Baulig <martin@gnome.org>
24544 Added control flow analysis support for structs.
24546 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
24547 with control flow analysis turned off.
24548 (IVariable): New interface.
24549 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
24550 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
24551 (FieldExpr.DoResolve): Resolve the instance expression with flow
24552 analysis turned off and do the definite assignment check after the
24553 resolving when we know what the expression will resolve to.
24555 * expression.cs (LocalVariableReference, ParameterReference):
24556 Implement the new IVariable interface, only call the flow analysis
24557 code if ec.DoFlowAnalysis is true.
24558 (This): Added constructor which takes a Block argument. Implement
24559 the new IVariable interface.
24560 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
24561 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
24562 This does the definite assignment checks for struct members.
24564 * class.cs (Constructor.Emit): If this is a non-static `struct'
24565 constructor which doesn't have any initializer, call
24566 Block.AddThisVariable() to tell the flow analysis code that all
24567 struct elements must be initialized before control returns from
24570 * statement.cs (MyStructInfo): New public class.
24571 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
24572 argument to this indexer. If non-zero, check an individual struct
24573 member, not the whole struct.
24574 (FlowBranching.CheckOutParameters): Check struct members.
24575 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
24576 overloaded versions of these methods which take an additional
24577 `int field_idx' argument to check struct members.
24578 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
24579 overloaded versions of these methods which take an additional
24580 `string field_name' argument to check struct member.s
24581 (VariableInfo): Implement the IVariable interface.
24582 (VariableInfo.StructInfo): New public property. Returns the
24583 MyStructInfo instance of the variable if it's a struct or null.
24584 (Block.AddThisVariable): New public method. This is called from
24585 Constructor.Emit() for non-static `struct' constructor which do
24586 not have any initializer. It creates a special variable for the
24587 "this" instance variable which will be checked by the flow
24588 analysis code to ensure that all of the struct's fields are
24589 initialized before control returns from the constructor.
24590 (UsageVector): Added support for struct members. If a
24591 variable/parameter is a struct with N members, we reserve a slot
24592 in the usage vector for each member. A struct is considered fully
24593 initialized if either the struct itself (slot 0) or all its
24594 members are initialized.
24596 2002-08-08 Martin Baulig <martin@gnome.org>
24598 * driver.cs (Driver.MainDriver): Only report an error CS5001
24599 if there were no compilation errors.
24601 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
24602 `UnsafeContext' property to determine whether the parent is in
24603 unsafe context rather than checking the parent's ModFlags:
24604 classes nested in an unsafe class are unsafe as well.
24606 2002-08-08 Martin Baulig <martin@gnome.org>
24608 * statement.cs (UsageVector.MergeChildren): Distinguish between
24609 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
24610 we return. Added test17() and test18() to test-154.cs.
24612 2002-08-08 Martin Baulig <martin@gnome.org>
24614 * typemanager.cs (TypeManager.FilterWithClosure): If we have
24615 Family access, make sure the invoking type isn't a subclass of the
24616 queried type (that'd be a CS1540).
24618 * ecore.cs (Expression.MemberLookup): Added overloaded version of
24619 this method which takes an additional `Type invocation_type'.
24621 * expression.cs (BaseAccess.DoResolve): Use the base type as
24622 invocation and query type.
24623 (MemberAccess.DoResolve): If the lookup failed and we're about to
24624 report a CS0122, try a lookup with the ec.ContainerType - if this
24625 succeeds, we must report a CS1540.
24627 2002-08-08 Martin Baulig <martin@gnome.org>
24629 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
24630 (MethodGroupExpr): Implement the IMemberExpr interface.
24632 * expression (MemberAccess.ResolveMemberAccess): No need to have
24633 any special code for MethodGroupExprs anymore, they're now
24636 2002-08-08 Martin Baulig <martin@gnome.org>
24638 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
24639 Family, FamANDAssem and FamORAssem permissions.
24640 (TypeManager.IsSubclassOrNestedChildOf): New public method.
24642 2002-08-08 Martin Baulig <martin@gnome.org>
24644 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
24645 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
24648 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
24650 * driver.cs: implemented /resource option to embed managed resources.
24652 2002-08-07 Martin Baulig <martin@gnome.org>
24654 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
24655 (FieldBase.HasFieldInitializer): New public property.
24656 (FieldBase.GetInitializerExpression): New public method. Resolves and
24657 returns the field initializer and makes sure it is only resolved once.
24658 (TypeContainer.EmitFieldInitializers): Call
24659 FieldBase.GetInitializerExpression to get the initializer, this ensures
24660 that it isn't resolved multiple times.
24662 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
24663 the resolving process (SimpleName/MemberLookup) that we're currently
24664 emitting a field initializer (which must not access any instance members,
24665 this is an error CS0236).
24667 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
24668 argument, if the `IsFieldInitializer' flag is set, we must report and
24669 error CS0236 and not an error CS0120.
24671 2002-08-07 Martin Baulig <martin@gnome.org>
24673 * ecore.cs (IMemberExpr): New public interface.
24674 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
24675 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
24676 if the expression is an IMemberExpr.
24678 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
24679 to be null, implicitly default to `this' if we're non-static in
24680 this case. Simplified the code a lot by using the new IMemberExpr
24681 interface. Also fixed bug #28176 here.
24683 2002-08-06 Martin Baulig <martin@gnome.org>
24685 * cs-parser.jay (SimpleLookup): Removed. We need to create
24686 ParameterReferences during semantic analysis so that we can do a
24687 type-only search when resolving Cast, TypeOf and SizeOf.
24688 (block): Pass the `current_local_parameters' to the Block's
24691 * class.cs (ConstructorInitializer): Added `Parameters parameters'
24692 argument to the constructor.
24693 (ConstructorInitializer.Resolve): Create a temporary implicit
24694 block with the parameters.
24696 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
24697 references here if we aren't doing a type-only search.
24699 * statement.cs (Block): Added constructor which takes a
24700 `Parameters parameters' argument.
24701 (Block.Parameters): New public property.
24703 * support.cs (InternalParameters.Parameters): Renamed `parameters'
24704 to `Parameters' and made it public readonly.
24706 2002-08-06 Martin Baulig <martin@gnome.org>
24708 * ecore.cs (Expression.Warning): Made this public as well.
24710 * report.cs (Report.Debug): Print the contents of collections.
24712 2002-08-06 Martin Baulig <martin@gnome.org>
24714 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
24715 used to tell Resolve() which kinds of expressions it may return.
24716 (Expression.Resolve): Added overloaded version of this method which
24717 takes a `ResolveFlags flags' argument. This can be used to tell
24718 Resolve() which kinds of expressions it may return. Reports a
24720 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
24721 ResolveFlags.SimpleName.
24722 (Expression.Error118): Added overloaded version of this method which
24723 takes a `ResolveFlags flags' argument. It uses the flags to determine
24724 which kinds of expressions are allowed.
24726 * expression.cs (Argument.ResolveMethodGroup): New public method.
24727 Resolves an argument, but allows a MethodGroup to be returned.
24728 This is used when invoking a delegate.
24730 * TODO: Updated a bit.
24732 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24734 Fixed compilation with csc.
24736 * ecore.cs: Expression.Error made public. Is this correct? Should
24737 Warning be made public too?
24739 * expression.cs: use ea.Location instead of ea.loc.
24740 [FIXME: Filed as bug #28607: MCS must report these errors.]
24742 2002-08-06 Martin Baulig <martin@gnome.org>
24744 * ecore.cs (Expression.loc): Moved the location here instead of
24745 duplicating it in all derived classes.
24746 (Expression.Location): New public property.
24747 (Expression.Error, Expression.Warning): Made them non-static and
24748 removed the location argument.
24749 (Expression.Warning): Added overloaded version which takes an
24750 `int level' argument.
24751 (Expression.Error118): Make this non-static and removed the
24752 expression and location arguments.
24753 (TypeExpr): Added location argument to the constructor.
24755 * expression.cs (StaticCallExpr): Added location argument to
24757 (Indirection, PointerArithmetic): Likewise.
24758 (CheckedExpr, UnCheckedExpr): Likewise.
24759 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
24760 (StringPtr): Likewise.
24763 2002-08-05 Martin Baulig <martin@gnome.org>
24765 * expression.cs (BaseAccess.DoResolve): Actually report errors.
24767 * assign.cs (Assign.DoResolve): Check whether the source
24768 expression is a value or variable.
24770 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
24771 while resolving the corresponding blocks.
24773 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
24774 an error, don't silently return null.
24776 * statement.cs (Block.AddVariable): Do the error reporting here
24777 and distinguish between CS0128 and CS0136.
24778 (Block.DoResolve): Report all unused labels (warning CS0164).
24779 (LabeledStatement): Pass the location to the constructor.
24780 (LabeledStatement.HasBeenReferenced): New property.
24781 (LabeledStatement.Resolve): Set it to true here.
24783 * statement.cs (Return.Emit): Return success even after reporting
24784 a type mismatch error (CS0126 or CS0127), this is what csc does and
24785 it avoids confusing the users with any consecutive errors.
24787 2002-08-05 Martin Baulig <martin@gnome.org>
24789 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
24791 * const.cs (Const.LookupConstantValue): Catch circular definitions.
24793 * expression.cs (MemberAccess.DoResolve): Silently return if an
24794 error has already been reported.
24796 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
24797 error has already been reported.
24799 2002-08-05 Martin Baulig <martin@gnome.org>
24801 * statement.cs (UsageVector): Only initialize the `parameters'
24802 vector if we actually have any "out" parameters.
24804 2002-08-05 Martin Baulig <martin@gnome.org>
24806 * expression.cs (Binary.ResolveOperator): When combining delegates,
24807 they must have the same type.
24809 2002-08-05 Martin Baulig <martin@gnome.org>
24811 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
24812 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
24813 work with the ms runtime and we also don't need it: if we're a
24814 PropertyBuilder and not in the `indexer_arguments' hash, then we
24815 are a property and not an indexer.
24817 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
24818 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
24819 since the latter one doesn't work with the ms runtime.
24821 2002-08-03 Martin Baulig <martin@gnome.org>
24823 Fixed bugs #27998 and #22735.
24825 * class.cs (Method.IsOperator): New public field.
24826 (Method.CheckBase): Report CS0111 if there's already a method
24827 with the same parameters in the current class. Report CS0508 when
24828 attempting to change the return type of an inherited method.
24829 (MethodData.Emit): Report CS0179 if a method doesn't have a body
24830 and it's not marked abstract or extern.
24831 (PropertyBase): New abstract base class for Property and Indexer.
24832 (PropertyBase.CheckBase): Moved here from Property and made it work
24834 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
24835 the same so we can reuse it there.
24836 (Property, Indexer): Derive from PropertyBase.
24837 (MethodSignature.inheritable_property_signature_filter): New delegate
24838 to find properties and indexers.
24840 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
24841 argument and improved error reporting.
24843 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
24844 EmptyReadOnlyParameters and made it a property.
24846 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
24847 version of this method which takes a `PropertyInfo indexer'.
24848 (TypeManager.RegisterIndexer): New method.
24850 * class.cs: Added myself as author of this file :-)
24852 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24854 * class.cs: fixed compilation on windoze.
24856 2002-08-03 Martin Baulig <martin@gnome.org>
24858 * interface.cs (Interface.GetInterfaceBases): Check whether all
24859 base interfaces are at least as accessible than the current one.
24861 * class.cs (TypeContainer.GetClassBases): Check whether base types
24862 are at least as accessible than the current type.
24863 (TypeContainer.AsAccessible): Implemented and made non-static.
24864 (MemberBase.CheckParameters): Report errors if the accessibility
24867 * delegate.cs (Delegate.Delegate): The default visibility is
24868 internal for top-level types and private for nested types.
24869 (Delegate.Define): Report errors if the accessibility checks fail.
24871 * enum.cs (Enum.Enum): The default visibility is internal for
24872 top-level types and private for nested types.
24873 (Enum.DefineType): Compute the correct visibility.
24875 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
24876 function which takes a `bool is_toplevel' instead of a TypeContainer.
24878 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
24881 2002-08-02 Martin Baulig <martin@gnome.org>
24883 * expression.cs (LocalVariableReferenc): Added constructor which
24884 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
24885 (LocalVariableReference.IsReadOnly): New property.
24886 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
24887 variable is readonly, use our own readonly flag to do this; you can
24888 use the new constructor to get a writable reference to a read-only
24891 * cs-parser.jay (foreach_statement, using_statement): Get a writable
24892 reference to the local variable.
24894 2002-08-01 Miguel de Icaza <miguel@ximian.com>
24896 * rootcontext.cs (ResolveCore): Also include System.Exception
24898 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
24899 we reach an EmptyStatement.
24901 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
24904 * expression.cs (Binary.ResolveOperator): Check error result in
24907 use brtrue/brfalse directly and avoid compares to null.
24909 2002-08-02 Martin Baulig <martin@gnome.org>
24911 * class.cs (TypeContainer.Define): Define all nested interfaces here.
24912 Fixes bug #28407, added test-155.cs.
24914 2002-08-01 Martin Baulig <martin@gnome.org>
24916 * class.cs (Event.EmitDefaultMethod): Make this work with static
24917 events. Fixes #28311, added verify-3.cs.
24919 2002-08-01 Martin Baulig <martin@gnome.org>
24921 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
24922 `is_disposable' fields.
24923 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
24924 `hm.is_disposable' if we're using the collection pattern.
24925 (Foreach.EmitCollectionForeach): Use the correct type for the
24926 enumerator's local variable, only emit the try/finally block if
24927 necessary (fixes #27713).
24929 2002-08-01 Martin Baulig <martin@gnome.org>
24931 * ecore.cs (Expression.report118): Renamed to Error118 and made
24934 * statement.cs (Throw.Resolve): Check whether the expression is of
24935 the correct type (CS0118) and whether the type derives from
24936 System.Exception (CS0155).
24937 (Catch.Resolve): New method. Do the type lookup here and check
24938 whether it derives from System.Exception (CS0155).
24939 (Catch.CatchType, Catch.IsGeneral): New public properties.
24941 * typemanager.cs (TypeManager.exception_type): Added.
24943 2002-07-31 Miguel de Icaza <miguel@ximian.com>
24945 * driver.cs: Updated About function.
24947 2002-07-31 Martin Baulig <martin@gnome.org>
24949 Implemented Control Flow Analysis.
24951 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
24952 (EmitContext.CurrentBranching): Added.
24953 (EmitContext.StartFlowBranching): Added.
24954 (EmitContext.EndFlowBranching): Added.
24955 (EmitContext.KillFlowBranching): Added.
24956 (EmitContext.IsVariableAssigned): Added.
24957 (EmitContext.SetVariableAssigned): Added.
24958 (EmitContext.IsParameterAssigned): Added.
24959 (EmitContext.SetParameterAssigned): Added.
24960 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
24961 Added control flow analysis stuff here.
24963 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
24964 resolve the expression as lvalue.
24965 (LocalVariableReference.DoResolve): Check whether the variable has
24966 already been assigned.
24967 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
24968 the parameter as assigned here.
24969 (ParameterReference.DoResolve): Check whether the parameter has already
24971 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
24972 expression as lvalue.
24974 * statement.cs (FlowBranching): New class for the flow analysis code.
24975 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
24976 (LabeledStatement.IsDefined): New public property.
24977 (LabeledStatement.AddUsageVector): New public method to tell flow
24978 analyis that the label may be reached via a forward jump.
24979 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
24981 (VariableInfo.Number): New public field. This is used by flow analysis
24982 to number all locals of a block.
24983 (Block.CountVariables): New public property. This is the number of
24984 local variables in this block (including the locals from all parent
24986 (Block.EmitMeta): Number all the variables.
24988 * statement.cs: Added flow analysis support to all classes.
24990 2002-07-31 Martin Baulig <martin@gnome.org>
24992 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
24993 To get debugging messages, compile mcs with /define:MCS_DEBUG and
24994 then use this argument.
24996 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
24998 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
24999 use this to specify /define options.
25001 2002-07-29 Martin Baulig <martin@gnome.org>
25003 * statement.cs (Fixed): Moved all code that does variable lookups
25004 and resolvings from Emit to Resolve.
25006 * statement.cs (For): Moved all code that does variable lookups
25007 and resolvings from Emit to Resolve.
25009 * statement.cs (Using): Moved all code that does variable lookups
25010 and resolvings from Emit to Resolve.
25012 2002-07-29 Martin Baulig <martin@gnome.org>
25014 * attribute.cs (Attribute.Resolve): Explicitly catch a
25015 System.NullReferenceException when creating the
25016 CustromAttributeBuilder and report a different warning message.
25018 2002-07-29 Martin Baulig <martin@gnome.org>
25020 * support.cs (ParameterData.ParameterName): Added method to
25021 get the name of a parameter.
25023 * typemanager.cs (TypeManager.IsValueType): New public method.
25025 2002-07-29 Martin Baulig <martin@gnome.org>
25027 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25028 is a flag which specifies that it's either ref or out.
25029 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25030 the out parameter to `out Parameter.Modifier mod', also set the
25031 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25033 * support.cs (InternalParameters.ParameterModifier): Distinguish
25034 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25035 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25037 * expression.cs (Argument.GetParameterModifier): Distinguish
25038 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25039 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25041 2002-07-29 Martin Baulig <martin@gnome.org>
25043 * expression.cs (ParameterReference.ParameterReference): Added
25044 `Location loc' argument to the constructor.
25046 * cs-parser.jay: Pass location to ParameterReference.
25048 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25050 * statement.cs (Try): Initialize the location.
25052 * cs-parser.jay: pass location to Try.
25054 * expression.cs (Unary.Reduce): Change the prototype to return
25055 whether a constant fold could be performed or not. The result is
25056 returned in an out parameters. In the case of Indirection and
25057 AddressOf, we want to perform the full tests.
25059 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25061 * statement.cs (Statement.Emit): Flag dead code.
25063 2002-07-27 Andrew Birkett <andy@nobugs.org>
25065 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25067 2002-07-27 Martin Baulig <martin@gnome.org>
25069 * class.cs (MethodData.Define): Put back call to
25070 TypeManager.AddMethod(), accidentally commented this out.
25072 * report.cs (Debug): New public method to print debugging information,
25073 this is `[Conditional ("DEBUG")]'.
25075 2002-07-26 Martin Baulig <martin@gnome.org>
25077 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25078 (switch_statement): Push the current_block to the switch_stack and
25079 pop it again when we're done with the switch.
25080 (switch_section): The new block is a child of the current_block.
25081 Fixes bug #24007, added test-152.cs.
25083 2002-07-27 Martin Baulig <martin@gnome.org>
25085 * expression.cs (Invocation.EmitArguments): When calling a varargs
25086 function with only its fixed arguments, we need to pass an empty
25089 2002-07-27 Martin Baulig <martin@gnome.org>
25091 Mono 0.13 has been released.
25093 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25095 * driver.cs: Rename --resource to --linkres, because that is what
25096 we do currently, we dont support --resource yet.
25098 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25100 2002-07-25 Martin Baulig <martin@gnome.org>
25102 * class.cs (MethodData): New public class. This is a `method builder'
25103 class for a method or one accessor of a Property/Indexer/Event.
25104 (MethodData.GetMethodFlags): Moved here from MemberBase.
25105 (MethodData.ApplyAttributes): Likewise.
25106 (MethodData.ApplyObsoleteAttribute): Likewise.
25107 (MethodData.ApplyConditionalAttribute): Likewise.
25108 (MethodData.ApplyDllImportAttribute): Likewise.
25109 (MethodData.CheckAbstractAndExternal): Likewise.
25110 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25111 (MethodData.Emit): Formerly known as Method.Emit().
25112 (MemberBase): Moved everything which was specific to a single
25113 accessor/method to MethodData.
25114 (Method): Create a new MethodData and call Define() and Emit() on it.
25115 (Property, Indexer, Event): Create a new MethodData objects for each
25116 accessor and call Define() and Emit() on them.
25118 2002-07-25 Martin Baulig <martin@gnome.org>
25120 Made MethodCore derive from MemberBase to reuse the code from there.
25121 MemberBase now also checks for attributes.
25123 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25124 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25126 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25127 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25128 (MemberBase.ApplyAttributes): New virtual method; applies the
25129 attributes to a method or accessor.
25130 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25131 (MemberBase.ApplyConditionalAttribute): Likewise.
25132 (MemberBase.ApplyDllImportAttribute): Likewise.
25133 (MemberBase.CheckAbstractAndExternal): Likewise.
25134 (MethodCore.ParameterTypes): This is now a property instead of a
25135 method, it's initialized from DoDefineParameters().
25136 (MethodCore.ParameterInfo): Removed the set accessor.
25137 (MethodCore.DoDefineParameters): New protected virtual method to
25138 initialize ParameterTypes and ParameterInfo.
25139 (Method.GetReturnType): We can now simply return the MemberType.
25140 (Method.GetMethodFlags): Override the MemberBase version and add
25141 the conditional flags.
25142 (Method.CheckBase): Moved some code from Define() here, call
25143 DoDefineParameters() here.
25144 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25145 here to avoid some larger code duplication.
25146 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25147 ensure that abstract and external accessors don't declare a body.
25149 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25150 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25151 lookup in the attribute's parent classes, so we need to abort as soon
25152 as we found the first match.
25153 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25154 the attribute has no arguments.
25156 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25159 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25161 * cs-parser.jay: reverted previous patch.
25163 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25165 * cs-parser.jay: fixed bug #22119.
25167 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25169 * attribute.cs: fixed compilation. The error was:
25170 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25171 be assigned to before control leaves the current method."
25172 [FIXME: Filed as bug #28186: MCS must report this error.]
25174 2002-07-25 Martin Baulig <martin@gnome.org>
25176 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25177 method to pull the condition name ouf of a Conditional attribute.
25178 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25179 the obsolete message and error flag out of an Obsolete attribute.
25181 * class.cs (Method.GetMethodFlags): New public method to get the
25182 TypeManager.MethodFlags for this method.
25183 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25185 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25186 if we're overriding a virtual function, set the new private variable
25187 `parent_method'; call the new TypeManager.AddMethod().
25189 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25190 the MethodBuilder and the Method in a PtrHashtable.
25191 (TypeManager.builder_to_method): Added for this purpose.
25192 (TypeManager.MethodFlags): Added IsObsoleteError.
25193 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25194 Obsolete and Conditional arguments in MethodBuilders. If we discover
25195 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25196 the message from the attribute.
25198 2002-07-24 Martin Baulig <martin@gnome.org>
25200 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25201 preprocessor directives, ensure that the argument to #define/#undef is
25202 exactly one identifier and that it's actually an identifier.
25204 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25207 2002-07-24 Martin Baulig <martin@gnome.org>
25209 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25210 initialize it to TypeManager.object_type in the constructor.
25211 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25212 of the `hm.get_current' method if we're using the collection pattern.
25213 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25214 for the explicit conversion to make it work when we're using the collection
25215 pattern and the `Current' property has a different return type than `object'.
25218 2002-07-24 Martin Baulig <martin@gnome.org>
25220 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25221 does not match, but don't report any errors. This method is called in
25222 order for all methods in a MethodGroupExpr until a matching method is
25223 found, so we don't want to bail out if the first method doesn't match.
25224 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25225 matches, report the 123. Fixes #28070.
25227 2002-07-24 Martin Baulig <martin@gnome.org>
25229 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25230 TypeManager.TypeToCoreType() to the top of the method so the
25231 following equality checks will work. Fixes #28107.
25233 2002-07-24 Martin Baulig <martin@gnome.org>
25235 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25236 operand is of type uint, and the other operand is of type sbyte,
25237 short or int, the operands are converted to type long." -
25238 Actually do what this comment already told us. Fixes bug #28106,
25241 2002-07-24 Martin Baulig <martin@gnome.org>
25243 * class.cs (MethodBase): New abstract class. This is now a base
25244 class for Property, Indexer and Event to avoid some code duplication
25245 in their Define() and DefineMethods() methods.
25246 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25247 generic methods for Define() and DefineMethods().
25248 (FieldBase): Derive from MemberBase, not MemberCore.
25249 (Property): Derive from MemberBase, not MemberCore.
25250 (Property.DefineMethod): Moved all the code from this method to the
25251 new MethodBase.DefineAccessor(), just call it with appropriate
25253 (Property.Define): Call the new Property.DoDefine(), this does some
25254 sanity checks and we don't need to duplicate the code everywhere.
25255 (Event): Derive from MemberBase, not MemberCore.
25256 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25257 accessors, this will also make them work with interface events.
25258 (Indexer): Derive from MemberBase, not MemberCore.
25259 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25260 (Indexer.Define): Use the new MethodBase functions.
25262 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25263 argument to the constructor.
25264 (Interface.FindMembers): Added support for interface events.
25265 (Interface.PopluateEvent): Implemented.
25267 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25269 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25271 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25272 but this is required to check for a method name being the same as
25273 the containing class.
25277 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25279 * interface.cs: initialize variable.
25281 2002-07-23 Martin Baulig <martin@gnome.org>
25283 Implemented the IndexerName attribute in interfaces.
25285 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25286 name if this is an explicit interface implementation.
25287 (Indexer.InterfaceIndexerName): New public variable. If we're
25288 implementing an interface indexer, this is the IndexerName in that
25289 interface. Otherwise, it's the IndexerName.
25290 (Indexer.DefineMethod): If we're implementing interface indexer,
25291 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25292 and Pending.ImplementIndexer methods.
25293 (Indexer.Define): Also define the PropertyBuilder if we're
25294 implementing an interface indexer and this is neither an explicit
25295 interface implementation nor do the IndexerName match the one in
25298 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25299 If a method is defined here, then we always need to create a proxy
25300 for it. This is used when implementing interface indexers.
25301 (Pending.IsInterfaceIndexer): New public method.
25302 (Pending.ImplementIndexer): New public method.
25303 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25304 This is used when implementing interface indexers to define a proxy
25306 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25307 define a proxy if necessary.
25309 * interface.cs (Interface.IndexerName): New public variable.
25310 (Interface.PopulateIndexer): Set the IndexerName.
25311 (Interface.DefineIndexers): New private method. Populate all the
25312 indexers and make sure their IndexerNames match.
25314 * typemanager.cs (IndexerPropertyName): Added support for interface
25317 2002-07-22 Martin Baulig <martin@gnome.org>
25319 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25320 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25321 ret if HasReturnLabel.
25322 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25325 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25326 and set the ec.LoopBeginTryCatchLevel.
25327 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25328 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25329 the current ec.TryCatchLevel, the branch goes out of an exception
25330 block. In this case, we need to use Leave and not Br.
25332 2002-07-22 Martin Baulig <martin@gnome.org>
25334 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25335 block unless the block does not always return or it is contained in
25336 another try { ... } catch { ... } block. Fixes bug #26506.
25337 Added verify-1.cs to the test suite.
25339 2002-07-22 Martin Baulig <martin@gnome.org>
25341 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25342 then we do not always return. Fixes bug #24985.
25344 2002-07-22 Martin Baulig <martin@gnome.org>
25346 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25347 lookup on a per-class level; ie. walk up the class hierarchy until we
25348 found at least one applicable method, then choose the best among them.
25349 Fixes bug #24463 and test-29.cs.
25351 2002-07-22 Martin Baulig <martin@gnome.org>
25353 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25354 return types of the methods. The return type is not part of the
25355 signature and we must not check it to make the `new' modifier work.
25356 Fixes bug #27999, also added test-147.cs.
25357 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25359 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25360 on the method's return type.
25362 2002-07-21 Martin Baulig <martin@gnome.org>
25364 * assign.cs: Make this work if the rightmost source is a constant and
25365 we need to do an implicit type conversion. Also adding a few more tests
25366 to test-38.cs which should have caught this.
25368 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25369 target in the makefile for this. The makefile.gnu is primarily intended
25370 for end-users who don't want to debug the compiler.
25372 2002-07-21 Martin Baulig <martin@gnome.org>
25374 * assign.cs: Improved the Assign class so it can now handle embedded
25375 assignments (X = Y = Z = something). As a side-effect this'll now also
25376 consume less local variables. test-38.cs now passes with MCS, added
25377 a few new test cases to that test.
25379 2002-07-20 Martin Baulig <martin@gnome.org>
25381 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25382 instructions. Fixes bug #27977, also added test-146.cs.
25384 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25386 * cs-tokenizer.cs: fixed getHex ().
25388 2002-07-19 Martin Baulig <martin@gnome.org>
25390 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25391 not Type.GetType() to lookup the array type. This is needed when
25392 we're constructing an array of a user-defined type.
25393 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25394 single-dimensional arrays, but also for single-dimensial arrays of
25397 2002-07-19 Martin Baulig <martin@gnome.org>
25399 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25400 this function is called, it's not allowed to share LocalBuilders
25401 among ILGenerators.
25403 2002-07-19 Martin Baulig <martin@gnome.org>
25405 * expression.cs (Argument.Resolve): Report an error 118 when trying
25406 to pass a type as argument.
25408 2002-07-18 Martin Baulig <martin@gnome.org>
25410 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25411 Conv_R_Un for the signed `long' type.
25413 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25415 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25416 `expr' for the temporary result, as that will fail if we do
25417 multiple resolves on the same expression.
25419 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25421 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25422 ec.TypeContainer for looking up aliases.
25424 * class.cs (TypeContainer): Remove LookupAlias from here.
25426 * decl.cs (DeclSpace); Move here.
25428 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25430 * class.cs (FindMembers): Only call filter if the constructor
25431 bulider is not null.
25433 Also handle delegates in `NestedTypes' now. Now we will perform
25434 type lookups using the standard resolution process. This also
25437 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25438 This uses Expressions (the limited kind that can be parsed by the
25439 tree) instead of strings.
25441 * expression.cs (ComposedCast.ToString): Implement, used to flag
25442 errors since now we have to render expressions.
25444 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25447 * ecore.cs (SimpleName.ToString): ditto.
25449 * cs-parser.jay: Instead of using strings to assemble types, use
25450 Expressions to assemble the type (using SimpleName, ComposedCast,
25451 MemberAccess). This should fix the type lookups in declarations,
25452 because we were using a different code path for this.
25454 * statement.cs (Block.Resolve): Continue processing statements
25455 even when there is an error.
25457 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25459 * class.cs (Event.Define): Also remove the `remove' method from
25460 the list of pending items.
25462 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25463 generate more compact code.
25465 2002-07-17 Martin Baulig <martin@gnome.org>
25467 * const.cs (Const.LookupConstantValue): Add support for constant
25468 `unchecked' and `checked' expressions.
25469 Also adding test case test-140.cs for this.
25471 2002-07-17 Martin Baulig <martin@gnome.org>
25473 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25474 check whether mi.ReturnType implements the IEnumerator interface; the
25475 `==' and the IsAssignableFrom() will fail in this situation.
25477 2002-07-16 Ravi Pratap <ravi@ximian.com>
25479 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25482 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25484 * expression.cs: fixed bug #27811.
25486 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25488 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25489 Molaro: when we are a ref, the value already contains a pointer
25490 value, do not take the address of it.
25492 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25493 * removed mb-parser.jay and mb-tokenizer.cs
25495 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25497 * expression.cs: check against the building corlib void type.
25499 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25501 * ecore.cs: fix for valuetype static readonly fields: when
25502 initializing them, we need their address, not the address of a copy.
25504 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25506 * typemanager.cs: register also enum_type in corlib.
25508 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25510 * class.cs: allow calling this (but not base) initializers in structs.
25512 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25514 * ecore.cs: make sure we compare against the building base types
25517 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25519 * typemanager.cs: fix TypeToCoreType() to handle void and object
25520 (corlib gets no more typerefs after this change).
25522 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25524 * expression.cs (ArrayCreation.EmitArrayArguments): use
25525 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25527 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25528 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25529 array indexes, the runtime actually forbids them.
25531 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25532 for array arguments here.
25534 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25535 instead of the default for ValueTypes.
25537 (New.DoEmit): Use IsValueType instead of
25538 IsSubclassOf (value_type)
25539 (New.DoResolve): ditto.
25540 (Invocation.EmitCall): ditto.
25542 * assign.cs (Assign): ditto.
25544 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25545 Statements *are* currently doing part of their resolution during
25548 Expressions do always resolve during resolve, but statements are
25549 only required to propagate resolution to their children.
25551 2002-07-11 Miguel de Icaza <miguel@ximian.com>
25553 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
25555 (LoadAssembly): Do not add the dll if it is already specified
25557 (MainDriver): Add the System directory to the link path at the end,
25558 after all the other -L arguments.
25560 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
25561 wrong opcode for loading bytes and bools (ldelem.i1 instead of
25562 ldelem.u1) and using the opposite for sbytes.
25564 This fixes Digger, and we can finally run it.
25566 * driver.cs (UnixParseOption): Move the option parsing here.
25567 (CSCParseOption): Implement CSC-like parsing of options.
25569 We now support both modes of operation, the old Unix way, and the
25570 new CSC-like way. This should help those who wanted to make cross
25571 platform makefiles.
25573 The only thing broken is that /r:, /reference: and /lib: are not
25574 implemented, because I want to make those have the same semantics
25575 as the CSC compiler has, and kill once and for all the confussion
25576 around this. Will be doing this tomorrow.
25578 * statement.cs (Unsafe.Resolve): The state is checked during
25579 resolve, not emit, so we have to set the flags for IsUnsfe here.
25581 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25583 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
25584 not catch the Error_ObjectRefRequired in SimpleName (as it is
25585 possible to have a class/instance variable name that later gets
25586 deambiguated), we have to check this here.
25588 2002-07-10 Ravi Pratap <ravi@ximian.com>
25590 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
25591 make static and put into Expression.
25593 (Event.Define): Register the private field of the event with the
25594 TypeManager so that GetFieldFromEvent can get at it.
25596 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
25597 keep track of the private field associated with an event which
25600 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
25603 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
25605 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25607 * expression.cs (Binary.EmitBranchable): this routine emits the
25608 Binary expression in a branchable context. This basically means:
25609 we need to branch somewhere, not just get the value on the stack.
25611 This works together with Statement.EmitBoolExpression.
25613 * statement.cs (Statement.EmitBoolExpression): Use
25616 2002-07-09 Miguel de Icaza <miguel@ximian.com>
25618 * statement.cs (For): Reduce the number of jumps in loops.
25620 (For): Implement loop inversion for the For statement.
25622 (Break): We can be breaking out of a Try/Catch controlled section
25623 (foreach might have an implicit try/catch clause), so we need to
25624 use Leave instead of Br.
25626 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
25627 now). If the instace expression supports IMemoryLocation, we use
25628 the AddressOf method from the IMemoryLocation to extract the
25629 address instead of emitting the instance.
25631 This showed up with `This', as we were emitting the instance
25632 always (Emit) instead of the Address of This. Particularly
25633 interesting when This is a value type, as we dont want the Emit
25634 effect (which was to load the object).
25636 2002-07-08 Miguel de Icaza <miguel@ximian.com>
25638 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
25640 * statement.cs (Checked): Set the CheckedState during the resolve
25641 process too, as the ConvCast operations track the checked state on
25642 the resolve process, and not emit.
25644 * cs-parser.jay (namespace_member_declaration): Flag that we have
25645 found a declaration when we do. This is used to flag error 1529
25647 * driver.cs: Report ok when we display the help only.
25649 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
25651 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
25653 2002-07-04 Miguel de Icaza <miguel@ximian.com>
25655 * cs-tokenizer.cs (define): We also have to track locally the
25656 defines. AllDefines is just used for the Conditional Attribute,
25657 but we also need the local defines for the current source code.
25659 2002-07-03 Miguel de Icaza <miguel@ximian.com>
25661 * statement.cs (While, For, Do): These loops can exit through a
25662 Break statement, use this information to tell whether the
25663 statement is the last piece of code.
25665 (Break): Flag that we break.
25667 * codegen.cs (EmitContexts): New `Breaks' state variable.
25669 2002-07-03 Martin Baulig <martin@gnome.org>
25671 * class.cs (TypeContainer.MethodModifiersValid): Allow override
25672 modifiers in method declarations in structs. Otherwise, you won't
25673 be able to override things like Object.Equals().
25675 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25677 * class.cs (Method, Property, Indexer): Do not allow the public
25678 modifier to be used in explicit interface implementations.
25680 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
25681 override modifiers in method declarations in structs
25683 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
25685 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
25686 integer or real overflow, report an error
25688 2002-07-02 Martin Baulig <martin@gnome.org>
25690 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
25691 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
25692 to tell the runtime about our newly created System.Object and
25693 System.ValueType types.
25695 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25697 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
25698 struct instead of Ldarg/Starg.
25700 2002-07-02 Martin Baulig <martin@gnome.org>
25702 * expression.cs (Indirection.Indirection): Call
25703 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
25705 2002-07-02 Martin Baulig <martin@gnome.org>
25707 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
25708 ValueType, call TypeManager.TypeToCoreType() on it.
25709 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
25710 the OpCodes.Newarr argument.
25712 2002-07-02 Martin Baulig <martin@gnome.org>
25714 * expression.cs (Invocation.EmitCall): When compiling corlib,
25715 replace all calls to the system's System.Array type to calls to
25716 the newly created one.
25718 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
25719 System.Array methods.
25720 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
25721 from the system's System.Array type which must be replaced.
25723 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
25725 * typemanager.cs: load unverifiable_code_ctor so we can build
25726 corlib using the correct type. Avoid using GetTypeCode() with
25728 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
25729 TypeManager.object_type to allow building corlib.
25731 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
25733 * ecore.cs: handle System.Enum separately in LoadFromPtr().
25735 2002-07-01 Martin Baulig <martin@gnome.org>
25737 * class.cs: Make the last change actually work, we need to check
25738 whether `ifaces != null' to avoid a crash.
25740 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25742 * class.cs: when we build structs without fields that implement
25743 interfaces, we need to add the interfaces separately, since there is
25744 no API to both set the size and add the interfaces at type creation
25747 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25749 * expression.cs: the dimension arguments to the array constructors
25750 need to be converted if they are a long.
25752 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
25754 * class.cs: don't emit ldarg.0 if there is no parent constructor
25755 (fixes showstopper for corlib).
25757 2002-06-29 Martin Baulig <martin@gnome.org>
25759 MCS now compiles corlib on GNU/Linux :-)
25761 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
25762 ie. check for MethodImplOptions.InternalCall.
25764 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
25765 and TypeManager.attribute_type are null, so we must explicitly check
25766 whether parent is not null to find out whether it's an attribute type.
25767 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
25768 and SetBuilder, not only if the property is neither abstract nor external.
25769 This is necessary to set the MethodImplOptions on the accessor methods.
25770 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
25771 SetBuilder, see Property.Emit().
25773 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
25774 populate "System.Object", "System.ValueType" and "System.Attribute" since
25775 they've already been populated from BootCorlib_PopulateCoreTypes().
25777 2002-06-29 Martin Baulig <martin@gnome.org>
25779 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
25780 is the NullLiteral, we also need to make sure that target_type is not
25783 2002-06-29 Martin Baulig <martin@gnome.org>
25785 * rootcontext.cs (RootContext.ResolveCore): We must initialize
25786 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
25787 before calling BootstrapCorlib_ResolveDelegate ().
25789 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25791 * statement.cs: fixed build-breaker. All tests passed ok.
25793 2002-06-27 Martin Baulig <martin@gnome.org>
25795 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
25796 for System.Decimal when compiling corlib.
25798 2002-06-27 Martin Baulig <martin@gnome.org>
25800 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
25801 switch blocks which contain nothing but a default clause.
25803 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
25805 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
25807 2002-06-27 Martin Baulig <martin@gnome.org>
25809 * ecore.cs (PropertyExpr.PropertyExpr): Call
25810 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
25812 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
25813 is already a TypeBuilder.
25815 2002-06-27 Martin Baulig <martin@gnome.org>
25817 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
25818 `target_type == TypeManager.array_type', not IsAssignableFrom() in
25819 the "from an array-type to System.Array" case. This makes it work
25820 when compiling corlib.
25822 2002-06-27 Martin Baulig <martin@gnome.org>
25824 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
25825 non-static PropertyExpr, set its InstanceExpression. This makes
25826 the `ICollection.Count' property work in System/Array.cs.
25828 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
25830 * driver.cs: Made error handling more consistent. Errors now
25831 tracked by Report class, so many methods which used to return int
25832 now return void. Main() now prints success/failure and
25833 errors/warnings message.
25835 Renamed '--probe' compiler argument to '--expect-error'. Removed
25836 the magic number return values (123 and 124). Now, if the
25837 expected error occurs, the compiler exits with success (exit value
25838 0). If the compilation completes without seeing that particular
25839 error, the compiler exits with failure (exit value 1). The
25840 makefile in mcs/errors has been changed to handle the new behaviour.
25842 * report.cs: Made 'expected error' number a property and renamed
25843 it from 'Probe' to 'ExpectedError'.
25845 * genericparser.cs: Removed error handling support, since it is
25846 now all done by Report class.
25848 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
25849 class, so parse() no longer returns an int.
25851 * namespace.cs: Use Report.Error instead of GenericParser.error
25853 2002-06-22 Miguel de Icaza <miguel@ximian.com>
25855 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
25856 TypeContainer.AddOperator): At the front of the list put the
25857 explicit implementations, so they get resolved/defined first.
25859 2002-06-21 Miguel de Icaza <miguel@ximian.com>
25861 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
25862 interface type is implemented by this TypeContainer. Used during
25863 explicit interface implementation.
25865 (Property.Define, Indexer.Define, Method.Define): Validate that
25866 the given interface in the explicit implementation is one of the
25867 base classes for the containing type.
25869 Also if we are explicitly implementing an interface, but there is
25870 no match in the pending implementation table, report an error.
25872 (Property.Define): Only define the property if we are
25873 not explicitly implementing a property from an interface. Use the
25874 correct name also for those properties (the same CSC uses,
25875 although that is really not needed).
25877 (Property.Emit): Do not emit attributes for explicitly implemented
25878 properties, as there is no TypeBuilder.
25880 (Indexer.Emit): ditto.
25882 Hiding then means that we do not really *implement* a pending
25883 implementation, which makes code fail.
25885 2002-06-22 Martin Baulig <martin@gnome.org>
25887 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
25888 the return value of Object.GetType(). [FIXME: we need to do this whenever
25889 we get a type back from the reflection library].
25891 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
25893 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
25895 2002-06-20 Miguel de Icaza <miguel@ximian.com>
25897 * attribute.cs: Return null if we can not look up the type.
25899 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
25900 the interface types found.
25902 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
25903 interface types found.
25905 * typemanager.cs (GetInterfaces): Make this routine returns alll
25906 the interfaces and work around the lame differences between
25907 System.Type and System.Reflection.Emit.TypeBuilder in the results
25908 result for GetInterfaces.
25910 (ExpandInterfaces): Given an array of interface types, expand and
25911 eliminate repeated ocurrences of an interface. This expands in
25912 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
25915 2002-06-21 Martin Baulig <martin@gnome.org>
25917 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
25920 2002-06-21 Martin Baulig <martin@gnome.org>
25922 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
25923 and called with one of the core types, return the corresponding typebuilder for
25926 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
25929 2002-06-21 Martin Baulig <martin@gnome.org>
25931 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
25932 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
25933 (Expression.ConvertReferenceExplicit): Likewise.
25935 * expression.cs (ElementAccess.DoResolve): Likewise.
25936 (ElementAccess.DoResolveLValue): Likewise.
25938 2002-06-10 Martin Baulig <martin@gnome.org>
25940 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
25941 add the "value" parameter to the parameter list.
25943 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
25946 2002-06-19 Miguel de Icaza <miguel@ximian.com>
25948 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
25949 the argument to an int, uint, long or ulong, per the spec. Also
25950 catch negative constants in array creation.
25952 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
25954 * class.cs: do not allow the same interface to appear twice in
25955 the definition list.
25957 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
25959 * ecore.cs: don't use ldlen with System.Array.
25961 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
25963 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
25965 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
25967 * modifiers.cs: produce correct field attributes for protected
25968 internal. Easy fix so miguel can work on ther harder stuff:-)
25970 2002-06-18 Miguel de Icaza <miguel@ximian.com>
25972 * pending.cs: New file. Move the code from class.cs here.
25973 Support clearning the pending flag for all methods (when not doing
25974 explicit interface implementation).
25976 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
25978 * rootcontext.cs: added a couple more types needed to bootstrap.
25980 2002-06-17 Miguel de Icaza <miguel@ximian.com>
25982 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
25983 constructor in the type, instead of any constructor in the type
25984 hierarchy. Thanks to Paolo for finding this bug (it showed up as
25985 a bug in the Mono runtime when applying the params attribute).
25987 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25988 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
25990 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
25992 * expression.cs (Unary.ResolveOperator): Use TypeManager
25993 to resolve the type.
25995 2002-06-13 Ravi Pratap <ravi@ximian.com>
25997 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26000 * enum.cs (AddEnumMember): Add support to store the attributes associated
26001 with each member too.
26003 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26004 field builders too - this takes care of the enum member case.
26006 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26008 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26009 address-of operator on both value types and pointers.
26011 2002-06-10 Martin Baulig <martin@gnome.org>
26013 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26014 PropertyBuilder to the `property_builders' list.
26016 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26017 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26018 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26019 find any indexers which are inherited from an interface.
26021 2002-06-09 Martin Baulig <martin@gnome.org>
26023 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26024 the same type as the constant if necessary. There's also a test-130.cs
26027 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26029 * typemanager.cs (TypeManager.ChangeType): Previously known as
26030 Enum.ChangeEnumType().
26032 2002-06-09 Martin Baulig <martin@gnome.org>
26034 * expression.cs (Cast.TryReduce): Added support for consts.
26036 2002-06-08 Ravi Pratap <ravi@ximian.com>
26038 * class.cs (Accessor): Hold attributes information so we can pass
26041 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26042 Modify to pass in attributes attached to the methods.
26044 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26046 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26047 to handle the Accessor kind :-)
26049 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26051 2002-06-08 Martin Baulig <martin@gnome.org>
26053 * expression.cs (Unary.TryReduceNegative): Added support for
26056 2002-06-08 Martin Baulig <martin@gnome.org>
26058 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26059 name can't be found in the `defined_names' - the caller will do a
26060 MemberLookup in this case and thus find methods in System.Enum
26061 such as Enum.IsDefined().
26063 2002-06-08 Martin Baulig <martin@gnome.org>
26065 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26066 Convert.ChangeType() which works with TypeBuilder created types.
26067 (Enum.LookupEnumValue, Enum.Define): Use it here.
26069 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26070 `TypeBuilder.BaseType != null' check.
26071 (TypeContainer.FindMembers): Only lookup parent members if we
26072 actually have a parent.
26073 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26074 (ConstructorInitializer.Resolve): Likewise.
26076 * interface.cs (Interface.FindMembers): Added
26077 `TypeBuilder.BaseType != null' check.
26079 * rootcontext.cs (RootContext.ResolveCore): Added
26080 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26081 classes_second_stage.
26083 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26084 debug_type and trace_type when compiling with --nostdlib.
26086 2002-06-07 Martin Baulig <martin@gnome.org>
26088 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26089 (AddField): Set it to true when adding a non-static field.
26090 (DefineType): Use `have_nonstatic_fields' to find out whether we
26091 have non-static fields, not `Fields != null'.
26093 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26095 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26096 dereferencing a null on the static-field code path)
26098 2002-05-30 Martin Baulig <martin@gnome.org>
26100 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26101 to take command line arguments. Use reflection to call the new
26102 custom `Initialize' function on the symbol writer and pass it the
26103 command line arguments.
26105 * driver.cs (--debug-args): New command line argument to pass command
26106 line arguments to the symbol writer.
26108 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26110 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26111 the target type for indexers and properties. Thanks to Joe for
26114 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26116 * typemanager.cs (MethodFlags): returns the method flags
26117 (Obsolete/ShouldIgnore) that control warning emission and whether
26118 the invocation should be made, or ignored.
26120 * expression.cs (Invocation.Emit): Remove previous hack, we should
26121 not do this on matching a base type, we should do this based on an attribute
26123 Only emit calls to System.Diagnostics.Debug and
26124 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26125 on the command line.
26127 * rootcontext.cs: Global settings for tracing and debugging.
26129 * cs-tokenizer.cs (define): New utility function to track
26130 defines. Set the global settings for TRACE and DEBUG if found.
26132 2002-05-25 Ravi Pratap <ravi@ximian.com>
26134 * interface.cs (Populate*): Pass in the TypeContainer as well as
26135 the DeclSpace as parameters so that we can create EmitContexts and
26136 then use that to apply attributes etc.
26138 (PopulateMethod, PopulateEvent, PopulateProperty)
26139 (PopulateIndexer): Apply attributes everywhere.
26141 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26144 (ApplyAttributes): Update accordingly.
26146 We now apply interface attributes for all members too.
26148 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26150 * class.cs (Indexer.Define); Correctly check if we are explicit
26151 implementation (instead of checking the Name for a ".", we
26152 directly look up if the InterfaceType was specified).
26154 Delay the creation of the PropertyBuilder.
26156 Only create the PropertyBuilder if we are not an explicit
26157 interface implementation. This means that explicit interface
26158 implementation members do not participate in regular function
26159 lookups, and hence fixes another major ambiguity problem in
26160 overload resolution (that was the visible effect).
26162 (DefineMethod): Return whether we are doing an interface
26165 * typemanager.cs: Temporary hack until we get attributes in
26166 interfaces (Ravi is working on that) and we get IndexerName
26167 support in interfaces.
26169 * interface.cs: Register the indexers as properties.
26171 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26172 warning, I have verified that this is a bug in the .NET runtime
26173 (JavaScript suffers of the same problem).
26175 * typemanager.cs (MemberLookup): When looking up members for
26176 interfaces, the parent of an interface is the implicit
26177 System.Object (so we succeed in searches of Object methods in an
26178 interface method invocation. Example: IEnumerable x; x.ToString
26181 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26183 * class.cs (Event): Events should also register if they do
26184 implement the methods that an interface requires.
26186 * typemanager.cs (MemberLookup); use the new GetInterfaces
26189 (GetInterfaces): The code used to lookup interfaces for a type is
26190 used in more than one place, factor it here.
26192 * driver.cs: Track the errors at the bottom of the file, we kept
26195 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26196 instance if the method we are calling is static!
26198 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26200 * attribute.cs (ApplyAttributes): Make this function filter out
26201 the IndexerName attribute (as that attribute in reality is never
26202 applied) and return the string constant for the IndexerName
26205 * class.cs (TypeContainer.Emit): Validate that all the indexers
26206 have the same IndexerName attribute, and if so, set the
26207 DefaultName attribute on the class.
26209 * typemanager.cs: The return value might contain other stuff (not
26210 only methods). For instance, consider a method with an "Item"
26211 property and an Item method.
26213 * class.cs: If there is a problem with the parameter types,
26216 2002-05-24 Ravi Pratap <ravi@ximian.com>
26218 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26219 looks at user defined conversion after making a call to
26220 StandardConversionExists - we need this for overload resolution.
26222 * expression.cs : Update accordingly the various method calls.
26224 This fixes 2 bugs filed against implicit user defined conversions
26226 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26228 * statement.cs: Track the result of the assignment.
26230 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26232 * expression.cs (MemberAccess): Improved error reporting for
26233 inaccessible members.
26235 2002-05-22 Martin Baulig <martin@gnome.org>
26237 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26238 itself with debugging support.
26240 2002-05-22 Martin Baulig <martin@gnome.org>
26242 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26243 Removed, this isn't needed anymore.
26245 2002-05-20 Martin Baulig <martin@gnome.org>
26247 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26248 be underlying type for an enum.
26250 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26252 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26253 that splits out the loading of just the core types.
26255 * rootcontext.cs (ResolveCore): Split the struct resolution in
26256 two, so we can load the enumeration underlying types before any
26259 * expression.cs (Is): Bandaid until we fix properly Switch (see
26260 bug #24985 for details).
26262 * typemanager.cs (ImplementsInterface): The hashtable will contain
26263 a null if there are no interfaces implemented.
26265 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26267 * cs-parser.jay (indexer_declarator): It is fine to have array
26270 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26272 * typemanager.cs: (RegisterBuilder): New function used to register
26273 TypeBuilders that implement interfaces. Since
26274 TypeBuilder.GetInterfaces (as usual) does not work with lame
26276 (AddUserType): register interfaces.
26278 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26279 dealing with TypeBuilder. Also, arrays are showing up as
26280 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26281 methods can not be invoked on them!
26283 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26284 (ImplicitReferenceConversionExists): Split out from
26285 StandardConversionExists.
26287 * expression.cs (As): We were only implementing one of the three
26288 cases for the as operator. We now implement them all.
26289 (Is): Implement the various other cases for Is as well.
26291 * typemanager.cs (CACHE): New define used to control if we want or
26292 not the FindMembers cache. Seems to have a negative impact on
26293 performance currently
26295 (MemberLookup): Nested types have full acess to
26296 enclosing type members
26298 Remove code that coped with instance/static returns for events, we
26299 now catch this in RealFindMembers.
26301 (RealFindMembers): only perform static lookup if the instance
26302 lookup did not return a type or an event.
26304 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26306 * assign.cs (CompoundAssign): We pass more semantic information
26307 now to Compound Assignments than we did before: now we have all
26308 the information at hand, and now we resolve the target *before* we
26309 do the expression expansion, which allows the "CacheValue" method
26310 to have the effect we intended (before, a [x] += 1 would generate
26311 two differen ArrayAccess expressions from the ElementAccess,
26312 during the resolution process).
26314 (CompoundAssign.DoResolve): Resolve target and original_source here.
26316 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26318 * expression.cs (ArrayAccess): dropped debugging information.
26320 * typemanager.cs: Small bug fix: I was always returning i_members,
26321 instead of one of i_members or s_members (depending on which had
26324 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26325 method is invoked before any code generation takes place, and it
26326 is a mechanism to inform that the expression will be invoked more
26327 than once, and that the method should use temporary values to
26328 avoid having side effects
26330 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26332 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26335 * expression.cs (Indirection, ArrayAccess): Add support for
26336 CacheTemporaries in these two bad boys.
26338 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26339 ldobj or ldind_ref.
26340 (StoreFromPtr): Handle stobj as well.
26342 * expression.cs (UnaryMutator): Share more code.
26344 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26345 down: I was not tracking the Filter function as well, which
26346 was affecting the results of the cache.
26348 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26350 * attribute.cs: Remove the hack to handle the CharSet property on
26353 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26355 * attribute.cs (DoResolve): More uglyness, we now only try to
26356 resolve the attribute partially, to extract the CharSet
26357 information (only if we are a StructLayout attribute). Otherwise
26359 (GetExtraTypeInfo): Add some code to conditionally kill in the
26360 future this. I am more and more convinced that the .NET
26361 framework has special code to handle the attribute setting on
26364 * expression.cs (IsParamsMethodApplicable): Revert my previous
26365 foreach change here, it was wrong.
26367 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26369 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26370 (pp_expr): do not abort on unknown input, just return.
26371 (eval): abort if there are pending chars.
26373 * attribute.cs (Attribute.Resolve): Positional parameters are
26374 optional. Deal with that case.
26376 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26377 the Ansi/Unicode/Auto information for the type.
26379 (TypeContainer.DefineType): instantiate the EmitContext here, as
26380 we will be using it during the type definition (to resolve
26381 attributes) and during the emit phase.
26383 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26384 to pull type information out of the attributes
26386 (Attribute.Resolve): track the constructor builder, and allow for
26387 multiple invocations (structs and classes will use this).
26389 * ecore.cs (MemberLookupFinal): new version with all the
26390 parameters customizable.
26392 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26393 constructors. Return if the result value is null (as the error
26394 would have been flagged already by MemberLookupFinal)
26396 Do not allow instances of abstract classes or interfaces to be
26399 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26400 We have to compare the assembly property here when dealing with
26401 FamANDAssem and Assembly access modifiers, because we might be
26402 creating an assembly from *modules* (that means that we are not
26403 getting TypeBuilders for types defined in other modules that are
26404 part of this assembly).
26406 (Method.Emit): If the method is marked abstract and has a body,
26409 (TypeContainer.DefineMembers): If both the defined member and the
26410 parent name match are methods, then do not emit any warnings: let
26411 the Method.Define routine take care of flagging warnings. But if
26412 there is a mismatch (method overrides something else, or method is
26413 overriwritten by something, then emit warning).
26415 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26416 set to null, this means `do not check for the return type on the
26419 (Method.Define): set the return type for the method signature to
26420 null, so that we get methods with the same name and parameters and
26421 different return types. This is used to flag warning 114 (you are
26422 hiding a method, and you probably want to use the new/override
26425 * typemanager.cs (MemberLookup): Implemented proper access
26426 control, closing a long standing set of bug reports. The problem
26427 was that the Framework only has two bits: Public and NonPublic,
26428 and NonPublic includes private and protected methods, but we need
26429 to enforce the FamANDAssem, FamOrAssem and Family.
26431 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26433 * statement.cs (GotoCase): Return true: Ammounts to giving up
26434 knowledge on whether we return or not, and letting the other case
26435 be responsible for it.
26437 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26439 * driver.cs: Do not load directories for each file processed, only
26440 do it if there is a pattern.
26442 * ecore.cs: Report readonly assigns here as well, as we might have
26443 been resolved only by MemberAccess.
26445 (SimpleName.SimpleNameResolve): Also be useful for LValue
26446 resolution. We need this to propagate assign to local readonly variables
26448 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26449 do not want to reuse potential criteria memory.
26451 * class.cs (MyEventBuilder): Set reflected_type;
26453 * ecore.cs (Constantify): Added support for constifying bools.
26455 (RootContext.LookupType): Added a cache for values looked up in
26456 the declaration space.
26458 * typemanager.cs (FindMembers): Now is a front-end to
26459 RealFindMembers, and provides a two-level hashtable-based cache to
26462 15% performance improvement: from 22.5 to 19.2 seconds.
26464 * expression.cs (IsParamsMethodApplicable): use foreach.
26465 (Invocation.DoResolve): ditto.
26466 (New.DoResolve): ditto.
26467 (ArrayCreation.DoResolve): ditto.
26469 * ecore.cs (FindMostEncompassingType): use foreach.
26471 * delegate.cs (NewDelegate.DoResolve): Use foreach
26473 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26474 (RemoveMethods): use foreach.
26476 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26477 nested foreach statements instead of for, and also break out of
26478 the inner loop once a match is found.
26480 (Invocation.OverloadResolve): Use foreach, simplify the code.
26482 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26484 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26485 we actually unwrap the expression to allow for extra information
26488 * expression.cs: Use Shr_Un on unsigned operations.
26490 2002-05-08 Ravi Pratap <ravi@ximian.com>
26492 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26493 applicable operators was not being considered correctly. This closes
26494 the bug Miguel reported.
26496 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26498 * attribute.cs: check that the type derives from System.Attribute
26499 and report the correct error in that case (moved the duplicate code to
26500 its own method, too).
26502 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26504 * attribute.cs: lookup attribute type name as the spec says: first the
26505 bare attribute name and then name + "Attribute" (nant compiles with
26506 mcs after this fix).
26508 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26510 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26511 Because of the way we parse things, we should try to see if a
26512 UIntConstant can fit in an integer.
26514 2002-05-07 Ravi Pratap <ravi@ximian.com>
26516 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26517 when we are in an explicit context.
26519 (ConvertReferenceExplicit): When converting from Iface type S to Class
26520 T make sure the rules are implemented as an OR.
26522 * parameter.cs (ParameterType): Make it a property for now although the
26523 purpose really isn't anything immediate.
26525 * expression.cs (Is*Applicable): Do better checking on the parameter type
26526 of a ref/out parameter. The ones from the system assemblies are already
26527 marked with the correct type so we don't need to do any correction.
26529 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26530 the object type is standard too so include that.
26532 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26534 * ecore.cs (StandardConversionExists): Augment with missing code:
26535 deal with IntConstant, LongConstants and Enumerations.
26537 * assign.cs: Report the error, instead of failing silently
26539 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26540 typecontainer that they are declared, because the
26541 typecontainer/namespace will have the list of using clauses that
26542 need to be applied.
26544 Assembly Attributes were escaping the normal registration
26547 (EmitCode): Apply attributes within an EmitContext that represents
26548 the container they were declared on.
26550 * cs-parser.jay: Track bases for structs. How did I get this wrong?
26552 2002-05-06 Ravi Pratap <ravi@ximian.com>
26554 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
26555 Revamp completely - make much cleaner as we now operate only
26558 (FindMostSpecificSource, FindMostSpecificTarget): New methods
26559 to implement the logic detailed in the spec more correctly.
26561 (UserDefinedConversion): Update accordingly.
26563 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26565 * statement.cs: Return flow analysis information up.
26567 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
26570 (token): Do not consume an extra character before calling
26573 2002-05-06 Piers Haken <piersh@friskit.com>
26575 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
26577 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26579 * class.cs (Constructor.Emit): Set the IsStatic flag in the
26580 EmitContext during the instance constructor initializer
26581 resolution, to stop access to instance variables.
26583 This is mandated by the spec, last paragraph of the `constructor
26584 initializers' section.
26586 2002-05-05 Miguel de Icaza <miguel@ximian.com>
26588 * cs-parser.jay, class.cs (Accessor): new class used to represent
26589 an accessor (get or set). In the past we used `null' to represent
26590 a missing accessor. But this is ambiguous because there was no
26591 way to tell in abstract indexers/properties if one of them was
26594 Now there is a way of addressing that.
26596 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
26597 instead of FindMembers.
26599 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
26600 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
26602 * attribute.cs: Treat indexers and properties as the same in terms
26603 of applying attributes
26605 * ecore.cs (FindMostEncompassedType): Use statically initialized
26606 EmptyExpressions()s like we do elsewhere to avoid creating useless
26607 objects (and we take this out of the tight loop).
26609 (GetConversionOperators): Move the code to extract the actual
26610 operators to a separate routine to clean things up.
26612 2002-05-04 Miguel de Icaza <miguel@ximian.com>
26614 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
26615 events are always registered FieldBuilders.
26617 * class.cs (FieldBase): New class shared by Fields
26619 * delegate.cs: If we are a toplevel delegate, use our full name.
26620 If we are a nested delegate, then only use our tail name.
26622 2002-05-02 Ravi Pratap <ravi@ximian.com>
26624 * expression.cs (IsApplicable): Ensure that we add the "&" to
26625 ref/out types before comparing it with the type of the argument.
26627 (IsParamsMethodApplicable): Ditto.
26629 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
26632 * delegate.cs : Handle the case when we have more than one applicable
26633 method. Flag an error only when we finish checking all.
26635 2002-05-02 Miguel de Icaza <miguel@ximian.com>
26637 * expression.cs: Add support for boolean static initializers.
26639 2002-05-01 Miguel de Icaza <miguel@ximian.com>
26641 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
26643 * parameter.cs (ComputeParameterTypes,
26644 ComputeAndDefineParameterTypes): Better error handling: now we
26645 clear the `types' cache if we fail during any of the type lookups.
26646 We also return the status code correctly to our caller
26648 * delegate.cs: If we fail to define a delegate, abort the extra
26651 * expression.cs (Binary.ResolveOperator): for
26652 operator==(object,object) and operator !=(object, object) we also
26653 have to verify that there is an implicit conversion from one to
26656 (ArrayAccess.DoResolve): Array Access can operate on
26659 2002-04-30 Miguel de Icaza <miguel@ximian.com>
26661 * assign.cs (CompoundAssign): A new class used as a "flag" that
26662 the assignment actually is happening as part of a compound
26663 assignment operator.
26665 During compound assignment, a few new rules exist to enable things
26672 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
26673 to the type of x) if y is implicitly convertible to the type of x,
26674 and the operator is a builtin operator and the return type of the
26675 operator is explicitly convertible to the type of x.
26677 * rootcontext.cs: Reset warning level to 2. 4 catches various
26678 "interesting" features in mcs, we must clean this up at some
26679 point, but currently am trying to kill other bugs ;-)
26681 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
26682 in container classes as well.
26684 * expression.cs (Binary.ResolveOperator): Handle string case
26685 before anything else (as operator overloading does emit an error
26686 before doing anything else).
26688 This code could go away when we move to a table driven model, but
26689 i could not come up with a good plan last night.
26691 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
26693 * typemanager.cs (CSharpName): reimplementation using regex.
26694 * class.cs: added null check for fields in Emit
26695 * rootcontext.cs: set warninglevel to 4
26697 2002-04-29 Miguel de Icaza <miguel@ximian.com>
26699 * typemanager.cs (CSharpName): reimplemented with Lupus
26702 2002-04-28 Miguel de Icaza <miguel@ximian.com>
26704 * statement.cs (If): correclty implement Resolve, because we were
26705 not catching sem errors in there. The same process is needed
26707 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
26710 (Statement.Warning_DeadCodeFound): Factorize code.
26711 (While): Report dead code here too.
26713 (Statement): Added Resolve virtual method to allow
26714 for resolution split from the emit code.
26716 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26718 * statement.cs (EmitBoolExpression): No longer try to resolve the
26720 (MakeBoolean): New utility function that resolve, implicitly
26721 converts to boolean and tags the expression.
26724 (If, Do): Implement dead code elimination.
26725 (While): Implement loop inversion
26727 (Do, While, For, If): Resolve the expression prior to calling our
26730 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
26733 - added method Report28 (warning: program has more than one entry point)
26734 - added method IsEntryPoint, implements paragraph 10.1 of the spec
26735 - modified method Method.Define, the part at the end of the method
26737 * rootcontext.cs: added static public Location EntryPointLocation;
26739 * ../errors/cs0028.cs : Add test case for the above warning.
26742 - modified method CSharpName to allow arrays of primitive type to
26743 be printed nicely (e.g. instead of System.Int32[][] it now prints
26745 - added method CSharpSignature: returns the signature of a method
26746 in string format to be used in reporting errors, warnings, etc.
26748 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
26751 2002-04-26 Ravi Pratap <ravi@ximian.com>
26753 * delegate.cs (Define): Fix extremely silly bug where I was
26754 setting the type of the 'object' parameter of the BeginInvoke
26755 method to System.IAsyncResult instead of System.Object ;-)
26757 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26759 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
26762 (Constructor.Emit): return if we fail to initialize the
26763 constructor. Another door closed!
26765 * expression.cs (New.DoResolve): Improve error message (from -6 to
26766 1501). Use DeclaredOnly lookup to find the exact constructor.
26768 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
26769 loop. This is useful.
26771 * cs-parser.jay: Adjust the default parameters so that destructors
26772 have the proper signature.
26774 2002-04-26 Martin Baulig <martin@gnome.org>
26776 * driver.cs (LoadAssembly): If `assembly' contains any characters
26777 which are only valid in path names and not in assembly names
26778 (currently slash, backslash and point), use Assembly.LoadFrom ()
26779 instead of Assembly.Load () on the `assembly' (before iteration
26780 over the link_paths).
26782 2002-04-26 Martin Baulig <martin@gnome.org>
26784 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
26786 2002-04-25 Miguel de Icaza <miguel@ximian.com>
26788 * class.cs (Property): use the new typemanager.MemberLookup
26790 (TypeContainer.MemberLookup): Implement using the
26791 TypeManager.MemberLookup now.
26793 * typemanager.cs: Make MemberLookup a function of the TypeManager,
26794 and return MemberInfos, so that these can be used without an
26795 EmitContext (what we had before).
26797 2002-04-24 Miguel de Icaza <miguel@ximian.com>
26799 * expression.cs: Fix the case where the argument to params if the
26800 type of the params. I omitted handling this before. Fixed
26802 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26804 * driver.cs: Call BootCorlib_PopulateCoreType
26806 * class.cs (Property.CheckBase): Check for properties only, not
26809 * interface.cs: Temporary hack: try/catch around the
26810 CustomAttributeBuilder, because I am getting an exception that I
26813 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
26814 types whose definitions are required to be there (attributes are
26815 defined before standard types).
26817 Compute definitions as we boot the various types, as they are used
26818 immediately (value_type class will need object_type, but if we do
26819 not initialize object_type, we will pass a null, which will let
26820 the runtime pick the System.Object from the existing corlib, which
26821 is not what we want).
26823 2002-04-22 Patrik Torstensson <totte@labs2.com>
26825 * cs-tokenizer.cs: fixed a number of trim() issues.
26827 2002-04-22 Ravi Pratap <ravi@ximian.com>
26829 * expression.cs (Argument.Type): Ensure that we return the correct
26830 type when we have out or ref parameters [in which case we
26833 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26835 * class.cs (Property, Indexer): Allow extern modifier in there.
26837 * typemanager.cs (InitBaseTypes): Initializes object_type and
26838 value_type, since those will be used early on during the bootstrap
26839 process to compile corlib.
26841 (InitCoreTypes): Move code from here to InitBaseTypes.
26843 2002-04-21 Miguel de Icaza <miguel@ximian.com>
26845 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
26846 single-dimension arrays as using the ldlen opcode.
26848 Daniel Lewis discovered this optimization.
26850 * typemanager.cs: Add signature for System.Array::get_Length
26852 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26854 * statement.cs: report the error when the foreach does not apply to an
26855 array nor a collection.
26857 2002-04-19 Miguel de Icaza <miguel@ximian.com>
26859 * expression.cs: Add implicit conversions to the operator ~.
26861 * constant.cs (DecimalConstant.Emit): Emit decimal value.
26863 * typemanager.cs: Locate the decimal constructor.
26865 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26867 * attribute.cs: use the new property of TypeOf.
26868 * expression.cs: added 'get' property around typearg.
26870 These changes fix a build breaker reported by NickD. Is this the
26871 correct way to fix? If not, please, revert my changes and make it
26874 2002-04-17 Miguel de Icaza <miguel@ximian.com>
26876 * attribute.cs: Add support for typeof in attribute invocations.
26877 I am not sure that this is right though.
26879 2002-04-14 Duncan Mak <duncan@ximian.com>
26881 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
26882 Binary.Operator.Division case.
26884 2002-04-13 Ravi Pratap <ravi@ximian.com>
26886 * class.cs (DefineType): Ensure that we do a proper check on
26887 attribute types and also register it with the TypeManager.
26889 (TypeContainer.Targets): The default for attribute types is
26890 AttributeTargets.All.
26892 * attribute.cs (ApplyAttributes): Registering the attribute type
26893 is done elsewhere, not when we discover we have a Usage attribute.
26895 2002-04-12 Ravi Pratap <ravi@ximian.com>
26897 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
26898 and get rid of is_delegate parameter.
26900 * everywhere : update.
26902 2002-04-12 Ravi Pratap <ravi@ximian.com>
26904 * cs-parser.jay (compilation_unit): Revamp completely to use
26905 some new ideas that I got from Rhys' grammar to solve the problems
26906 with assembly level attributes.
26908 (outer_declaration): New grammar production.
26910 (attribute_sections): Add.
26912 (opt_attributes): Base on attribute_sections
26914 (namespace_declaration): Allow opt_attributes to tackle the case
26915 when we have assembly level attributes - we are clever in this
26918 * attribute.cs (ApplyAttributes): Do not worry about assembly
26919 attributes in the non-global context.
26921 * rootcontext.cs (AddGlobalAttributes): Go back to using this
26922 instead of SetGlobalAttributes.
26924 * class.cs, rootcontext.cs : Ensure we define and generate
26925 attribute types before anything else.
26927 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
26928 and flag the new error -20 for the case when the attribute type
26929 does not have valid targets specified. csc does not catch this.
26931 * ../errors/errors.txt : update for error # -20
26933 2002-04-11 Ravi Pratap <ravi@ximian.com>
26935 * support.cs (InternalParameters.ParameterModifier): Do some null
26936 checking and return sane values.
26938 * class.cs (Method.Define): If we are a PInvoke method, ensure
26939 that we are static and extern. Report error # 601
26941 * ../errors/cs0601.cs : Add test case for the above error.
26943 2002-04-07 Ravi Pratap <ravi@ximian.com>
26945 * rootcontext.cs (attribute_types): We need to keep type of
26946 all attribute types separately and emit code for them first.
26948 (RegisterAttribute) : Implement.
26950 * class.cs (DefineType): Check if the current Type is a custom
26951 attribute type and register it accordingly.
26953 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
26954 adding the first attribute twice and rename to
26956 (SetGlobalAttributes): this.
26958 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
26961 * attribute.cs (ApplyAttributes): Take an additional argument telling us
26962 if we are processing global arguments. Hmm, I am unsure of this.
26964 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26966 * expression.cs: added static array of strings to avoid calling
26967 Enum.ToString () for Operator in Binary. Significant recover of
26970 2002-04-10 Miguel de Icaza <miguel@ximian.com>
26972 * class.cs (FindMembers): Allow the Builders of the various
26973 members to be null. If they are skip them. This only happens
26974 during the PInvoke declaration.
26976 2002-04-09 Miguel de Icaza <miguel@ximian.com>
26978 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
26979 failure, so we do not keep going afterwards.
26981 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
26982 wanted to pass `false' as the `is_delegate' argument. If this is
26983 the case, why not use delegate_type == null to mean `is_delegate =
26984 false' and anything else as is_delegate = true.
26986 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
26988 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
26989 code for the section, not the beginning of the tests.
26991 2002-04-08 Miguel de Icaza <miguel@ximian.com>
26993 * cfold.cs: Handle operator + (Enum x, Underlying x)
26995 * expression.cs (Binary): same. Warn about errors where we have
26996 Enum/Enum in operator + as well.
26998 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27001 - added support for switch(bool)
27002 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27003 - add TableSwitchEmit() to handle table-based switch statements
27005 2002-04-05 Ravi Pratap <ravi@ximian.com>
27007 * expression.cs (Invocation.OverloadResolve): Factor out code which
27008 does parameter compatibility checking with arguments so that we can
27009 re-use the code even from Delegate.VerifyApplicability
27011 (VerifyArgumentsCompat): Move above code here.
27013 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27014 and instead make a call to the above method.
27016 2002-03-31 Ravi Pratap <ravi@ximian.com>
27018 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27019 We use it to keep track of classes which are attribute types.
27021 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27023 * delegate.cs (Delegate.Define): Correctly define the types in the
27024 presence of fixed and array parameters.
27026 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27029 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27030 include NonPublic after the first iteration.
27032 * class.cs (Indexer.CheckBase): Only check if both parents are
27035 * cs-parser.jay (accessor_body): If empty, set to null.
27037 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27038 same code path here to resolve constants names that we did have in
27039 MemberAccess.DoResolve. There is too much code duplicated here.
27041 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27043 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27045 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27048 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27049 tokens, numbers and strings.
27051 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27054 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27055 asyncronous parameters and the regular parameters.
27057 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27058 specify the target directory.
27060 * expression.cs: (This.DoResolve): Simplify
27061 (As.Emit): Optimize, do not generate IsInst if the expression is
27062 always of the given type.
27064 (Is.DoResolve): Bug fix, we were reporting both always/never for
27067 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27068 creating too many unnecessary arrays.
27070 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27072 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27073 fields instead of rolling our own initializer. Takes care of all
27074 implicit conversions, and drops unnecessary static checks/argument.
27076 2002-03-31 Dick Porter <dick@ximian.com>
27078 * driver.cs: use the GetDirectories() return values properly, and
27079 use "/" as path separator.
27081 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27083 * expression.cs (Unary): Optimize - - expr into expr.
27084 (Binary): Optimize a + (-b) into a -b.
27086 * codegen.cs (CodeGen): Made all methods static.
27088 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27092 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27093 TypeBuilder property.
27095 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27098 * tree.cs: Removed the various RecordXXXX, and replaced with a
27099 single RecordDecl. Removed all the accessor methods, and just
27100 left a single access point Type
27102 * enum.cs: Rename DefineEnum to DefineType.
27104 * decl.cs: New abstract method `DefineType' used to unify the
27105 Defines for Enumerations, Interfaces, TypeContainers and
27108 (FindType): Moved LookupInterfaceOrClass here. Moved the
27109 LookupBaseClasses method that used to live in class.cs and
27110 interface.cs here, and renamed to FindType.
27112 * delegate.cs: Implement DefineType. Take advantage of the
27113 refactored pattern for locating the parent builder without taking
27114 the parent_builder argument (which we know does not work if we are
27115 nested, and triggering a toplevel definition).
27117 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27119 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27120 accessibility of a member has changed during override and report
27123 * class.cs (Method.Define, Property.Define): Only complain on
27124 overrides if the method is private, any other accessibility is
27125 fine (and since we just checked the permission is the same, we are
27128 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27129 and elif are processed always. The other pre-processing
27130 directives are only processed if we are "taking" the path
27132 2002-03-29 Martin Baulig <martin@gnome.org>
27134 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27135 current location is not Null.
27137 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27138 a separate method so we can profile it.
27140 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27141 `span.Seconds' are just seconds, but no minutes or hours.
27142 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27144 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27146 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27147 Remove the gratuitous set of Final:
27149 // If an interface implementation, then we can set Final.
27150 if (((flags & MethodAttributes.Abstract) == 0) &&
27151 implementing.DeclaringType.IsInterface)
27152 flags |= MethodAttributes.Final;
27154 I do not know what I was smoking when I used that.
27157 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27158 step into fixing the name resolution issues for delegates and
27159 unifying the toplevel name resolution.
27161 2002-03-28 Martin Baulig <martin@gnome.org>
27163 * class.cs (Method.Emit): If we have a symbol writer, call its
27164 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27165 tell it about the current method.
27167 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27168 writer that we're going to emit the first byte of IL code for a new
27169 statement (a new source line).
27170 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27171 EmitContext.Mark() before emitting any code.
27173 * location.cs (SymbolDocument): Return null when we're Null.
27175 * statement.cs (Statement): Moved the `Location loc' variable here.
27176 (Statement.EmitBoolExpression): If we have a symbol writer, call
27177 ec.Mark() before emitting any code to tell it that we're at the
27178 beginning of a new statement.
27179 (StatementExpression): Added `Location' argument to the constructor.
27180 (Block): Added public readonly variable `StartLocation' and public
27181 variable `EndLocation'. The latter is to be set using SetEndLocation().
27182 (Block): Added constructor which takes a start and end location.
27183 (Block.SetEndLocation): New method. This sets the end location.
27184 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27185 local variables we create.
27186 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27187 each statement and do also mark the begin and end of the block.
27189 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27190 tell it the current lexer.Location, use Location.Null for the end of the
27192 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27193 current block, set its end location using SetEndLocation().
27194 (statement_expression): StatementExpression constructor now takes the
27195 lexer.Location as additional argument.
27196 (for_statement, declare_local_variables): Likewise.
27197 (declare_local_variables): When creating a new implicit block, use the
27198 new Block constructor and pass it the lexer.Location.
27200 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27202 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27203 members also on the parent interfaces recursively.
27205 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27207 * report.cs: Use new formats, since Gonzalo finished the missing
27210 * expression.cs (Binary.ResolveOperator): added missing operator|
27211 operator& and operator^ for bool/bool.
27213 * cs-parser.jay: CheckDef now takes a Location argument that is
27214 used to report errors more precisly (instead of reporting the end
27215 of a definition, we try to track something which is a lot closer
27216 to the source of the problem).
27218 * cs-tokenizer.cs: Track global token use, so we can properly flag
27219 the use of #define/#undef after the first token has been seen.
27221 Also, rename the reportXXXX to Error_DescriptiveName
27223 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27224 TypeContainer, so that Enum and Interface can use this too.
27226 * class.cs (TypeContainer.LookupInterfaceOrClass,
27227 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27228 `builder' argument. Typically this was used to pass the parent
27229 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27232 The problem is that a nested class could trigger the definition of
27233 a toplevel class, and the builder would be obviously wrong in that
27236 So we drop this argument, and we compute dynamically the
27237 TypeBuilder/ModuleBuilder (the correct information was available
27238 to us anyways from DeclSpace.Parent)
27240 * interface.cs (Interface.DefineInterface): Drop builder
27241 parameter cleanup like class.cs
27243 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27246 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27249 (Try.Emit): Propagate the returns value from the statement.
27251 (Return.Emit): Even if we are leavning
27253 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27255 * modifiers.cs: Fix the computation of MethodAttributes flags.
27257 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27259 * driver.cs: allow compilation of files that start with '/'.
27260 Add a default case when checking the argument of --target.
27262 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27264 * interface.cs: Implement the same search algorithm for types in
27265 the interface code.
27267 * delegate.cs: Do not allow multiple definition.
27269 * Recovered ChangeLog that got accidentally amputated
27271 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27273 * rootcontext.cs: Load manually enum to allow core classes to
27274 contain enumerations.
27276 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27277 Update to new static methods in TypeManager.
27279 * typemanager.cs (GetMethod, GetConstructor): Use our
27280 implementation of FindMembers to find the members, since during
27281 corlib compilation, the types are TypeBuilders and GetMethod and
27282 GetConstructor do not work.
27284 Make all methods in TypeManager static.
27286 (InitCodeHelpers): Split the functionality from
27287 the InitCodeTypes function.
27289 * driver.cs: Call InitCodeHelpers after we have populated the
27292 * cs-parser.jay (delegate_declaration): we did not used to compute
27293 the delegate name correctly for void delegates.
27295 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27297 * rootcontext.cs (RootContext): Init the interface_resolve_order
27298 and type_container_resolve_order always.
27300 (ResolveCore, BootstrapCorlib_ResolveClass,
27301 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27302 compiler when compiling with --nostdlib
27304 * class.cs (TypeContainer.DefineType): Check that our parent is
27305 not null. This test is most important when we are bootstraping
27308 * codegen.cs: Split out the symbol writing code.
27310 2002-03-25 Martin Baulig <martin@gnome.org>
27312 * driver.cs (-g): Made -g an alias for --debug.
27314 2002-03-24 Martin Baulig <martin@gnome.org>
27316 * codegen.cs (SymbolWriter): New public variable. Returns the
27317 current symbol writer.
27318 (CodeGen): Added `bool want_debugging_support' argument to the
27319 constructor. If true, tell the ModuleBuild that we want debugging
27320 support and ask it for the ISymbolWriter.
27321 (Save): If we have a symbol writer, call it's Close() method after
27322 saving the assembly.
27324 * driver.c (--debug): New command line argument to create a
27325 debugger information file.
27327 * location.cs (SymbolDocument): New public property. Returns an
27328 ISymbolDocumentWriter object for the current source file or null
27329 if we don't have a symbol writer.
27331 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27333 * driver.cs (LoadAssembly): Correctly return when all the paths
27334 have been tried and not before.
27336 * statement.cs (Switch.Emit): return the actual coverage for this
27337 statement (returns/not-returns)
27339 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27340 switch of the statement if we are the last switch section. That
27341 kills two problems: try/catch problems (we used to emit an empty
27342 nop at the end) and switch statements where all branches would
27345 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27347 * driver.cs: Add default assemblies (the equivalent to the
27348 Microsoft CSC.RSP file)
27350 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27351 also update tokens_seen and set it to false.
27353 * driver.cs: Implement --recurse for Mike.
27355 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27356 correctly splitting out the paths.
27358 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27360 * interface.cs (Interface.PopulateProperty): Instead of using
27361 `parent' as the declaration space for the set parameters, use
27364 * support.cs (InternalParameters): InternalParameters constructor
27365 takes a DeclSpace instead of a TypeContainer.
27367 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27368 types are being initialized, load the address of it before calling
27371 (New): Provide a mechanism to disable the generation of local
27372 value type temporaries when the caller will be providing us with
27373 an address to store it.
27375 (ArrayCreation.EmitDynamicInitializers): Use it.
27377 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27379 * expression.cs (Invocation.EmitArguments): Only probe for array
27380 property if there is more than one argument. Sorry about that.
27382 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27383 empty param arrays.
27385 * class.cs (Method.LabelParameters): Fix incorrect code path that
27386 prevented the `ParamArrayAttribute' from being applied to the
27389 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27391 * support.cs (ReflectionParameters): Correctly compute whether the
27392 last argument is a params array. Fixes the problem with
27395 * typemanager.cs: Make the assemblies array always be non-null
27396 (empty, but non-null)
27398 * tree.cs (RecordDecl): New function that abstracts the recording
27399 of names. This reports error 101, and provides a pointer to the
27400 previous declaration. Fixes a crash in the compiler.
27402 * cs-parser.jay (constructor_declaration): Update to new grammar,
27403 and provide a constructor_body that can be empty.
27405 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27407 * driver.cs: Add support for --resources.
27409 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27410 Make all types for the various array helper methods be integer.
27412 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27413 CheckState to ConvCast.
27415 (ConvCast): Now it takes a `checked' state argument, to avoid
27416 depending on the emit context for the conversion, and just using
27417 the resolve time setting.
27419 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27420 instead of Invocation.EmitArguments. We do not emit the original
27421 arguments, instead we emit those which have been converted to
27422 unsigned int expressions.
27424 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27426 * codegen.cs: ditto.
27428 * expression.cs (LocalVariableReference): Drop the use of the
27429 Store function that depended on the variable index.
27431 * statement.cs (VariableInfo): Drop the `Idx' property from this
27432 class, as this is not taking into account the indexes for
27433 temporaries tat we generate during the execution, getting the
27436 * class.cs: First emit class initializers, then call the parent
27439 * expression.cs (Binary): Fix opcode emision.
27440 (UnaryMutator.EmitCode): Support checked code generation
27442 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27443 matches for events for both the Static and Instance scans,
27444 pointing to the same element. Fix that.
27446 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27448 * rootcontext.cs (ResolveTree): Always set the
27449 interface_resolve_order, because nested interfaces will be calling
27452 * class.cs (GetInterfaceOrClass): Track the same resolution
27453 process used by TypeManager.LookupType. This fixes the nested
27454 type lookups in class declarations (separate path from
27457 (TypeContainer.DefineType): Also define nested interfaces.
27458 (TypeContainer.RegisterOrder): New public function used to
27459 register the order in which child interfaces need to be closed.
27461 Nested interfaces need to be closed after their parents have been
27464 * interface.cs (InterfaceAttr): Put all the logic for computing
27465 the interface attribute here.
27467 (DefineInterface): Register our interface order with the
27468 RootContext or with the TypeContainer depending on the case.
27470 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27472 * cs-parser.jay: rework foreach statement to work with the new
27473 changes to the policy on SimpleNames.
27475 * report.cs: support Stacktrace on warnings as well.
27477 * makefile: drop --unsafe and /unsafe from the compile.
27479 2002-03-13 Ravi Pratap <ravi@ximian.com>
27481 * ecore.cs (StandardConversionExists): Modify to take an Expression
27482 as the first parameter. Ensure we do null -> reference type conversion
27485 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27486 temporary Expression objects.
27488 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27490 * interface.cs: workaround bug in method overloading resolution
27491 (there is already a bugzilla bug for it).
27493 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27495 We could also solve this problem by having a separate path for
27496 performing type lookups, instead of DoResolve, we could have a
27497 ResolveType entry point, and only participating pieces of the
27498 production (simplename, deref, array) would implement this.
27500 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27501 signal SimpleName to only resolve type names and not attempt to
27502 resolve anything else.
27504 * expression.cs (Cast): Set the flag.
27506 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27508 * class.cs: Only report 108 if there is no `new' modifier.
27510 * cs-parser.jay: rework foreach statement to work with the new
27511 changes to the policy on SimpleNames.
27513 * report.cs: support Stacktrace on warnings as well.
27515 * makefile: drop --unsafe and /unsafe from the compile.
27517 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27519 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27520 lookups here, instead of doing that at parse time. This means
27521 that our grammar will not introduce `LocalVariableReferences' as
27522 expressions at this point. That solves the problem of code like
27526 static void Main ()
27530 This is only half the fix. The full fix requires parameters to
27531 also be handled in this way.
27533 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27534 makes the use more obvious of the DeclSpace. The
27535 ec.TypeContainer.TypeBuilder is now only used to pull the
27536 TypeBuilder for it.
27538 My theory is that I can get rid of the TypeBuilder completely from
27539 the EmitContext, and have typecasts where it is used (from
27540 DeclSpace to where it matters).
27542 The only pending problem is that the code that implements Aliases
27543 is on TypeContainer, and probably should go in DeclSpace.
27545 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27546 lookups here, instead of doing that at parse time. This means
27547 that our grammar will not introduce `LocalVariableReferences' as
27548 expressions at this point. That solves the problem of code like
27552 static void Main ()
27556 This is only half the fix. The full fix requires parameters to
27557 also be handled in this way.
27559 * class.cs (Property.DefineMethod): When implementing an interface
27560 method, set newslot, when implementing an abstract method, do not
27561 set the flag (before we tried never setting it, or always setting
27562 it, which is the difference).
27563 (Indexer.DefineMethod): same.
27564 (Method.DefineMethod): same.
27566 * ecore.cs: Only set the status used flag if we get back a Field.
27568 * attribute.cs: Temporary hack, so Paolo can keep working.
27570 2002-03-08 Ravi Pratap <ravi@ximian.com>
27572 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
27573 the unmanaged type in the case we have a MarshalAs attribute.
27575 (Resolve): Handle the case when we are parsing the special MarshalAs
27576 attribute [we need to store the unmanaged type to use later]
27578 * typemanager.cs (marshal_as_attr_type): Built in type for the
27579 MarshalAs Attribute.
27581 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
27582 on parameters and accordingly set the marshalling info.
27584 2002-03-09 Miguel de Icaza <miguel@ximian.com>
27586 * class.cs: Optimizing slightly by removing redundant code after
27587 we switched to the `NoTypes' return value.
27588 (Property.DefineMethod): use NoTypes here too.
27590 This fixes the bug I introduced in my last batch of changes.
27592 2002-03-05 Ravi Pratap <ravi@ximian.com>
27594 * tree.cs (RecordEnum): Add. We now keep track of enums too.
27596 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
27597 Enums since those are types too.
27599 * cs-parser.jay (enum_declaration): Record enums as we parse them.
27601 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
27602 thanks to a call during the lookup process.
27604 2002-03-07 Miguel de Icaza <miguel@ximian.com>
27606 * statement.cs (Foreach): Lots of work to accomodate a particular
27607 kind of foreach statement that I had not kept in mind. It is
27608 possible to have foreachs on classes that provide a GetEnumerator
27609 method that return objects that implement the "pattern" for using
27610 a foreach, there is no need to support GetEnumerator
27613 This is needed to compile nant.
27615 * decl.cs: Only report 114 if the member is not `Finalize' and if
27616 the warning level is at least 2.
27618 * class.cs: Moved the compare function from Method to
27621 (MethodSignature.InheritableMemberSignatureCompare): Add new
27622 filter function that is used to extract inheritable methods from a
27625 (Method.Define): Use the new `inheritable_method_signature_filter'
27628 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
27631 2002-03-06 Miguel de Icaza <miguel@ximian.com>
27633 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
27635 * cs-parser.jay: Add opt_semicolon to the interface declaration.
27637 * expression.cs: Pass location information to
27638 ConvertImplicitStandard.
27640 * class.cs: Added debugging code to track return values from
27643 2002-03-05 Miguel de Icaza <miguel@ximian.com>
27645 * expression.cs (Is.DoResolve): If either side of the `is' is an
27646 interface, do not flag the warning.
27648 * ecore.cs (ImplicitReferenceConversion): We need a separate test
27651 * report.cs: Allow for --fatal to be used with --probe.
27653 * typemanager.cs (NoTypes): Move the definition for the empty Type
27656 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
27658 (TypeContainer.DefineProxy): New function used to proxy to parent
27659 implementations when implementing interfaces.
27660 (TypeContainer.ParentImplements): used to lookup if our parent
27661 implements a public function that is required by an interface.
27662 (TypeContainer.VerifyPendingMethods): Hook this up.
27664 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
27665 `modules' and `assemblies' arraylists into arrays. We only grow
27666 these are the very early start up of the program, so this improves
27667 the speedof LookupType (nicely measured).
27669 * expression.cs (MakeByteBlob): Replaced unsafe code with
27670 BitConverter, as suggested by Paolo.
27672 * cfold.cs (ConstantFold.Binary): Special case: perform constant
27673 folding of string concatenation, but if either side is a string,
27674 and the other is not, then return null, and let the runtime use
27675 the concatenation on the string plus the object (using
27676 `Object.ToString').
27678 2002-03-04 Miguel de Icaza <miguel@ximian.com>
27680 Constant Folding has been implemented now.
27682 * expression.cs (Unary.Reduce): Do not throw an exception, catch
27683 the error instead on types that are not supported in one's
27686 * constant.cs (Constant and all children): New set of functions to
27687 perform implict and explicit conversions.
27689 * ecore.cs (EnumConstant): Implement the new functions to perform
27690 conversion by proxying to the child expression.
27692 * codegen.cs: (ConstantCheckState): Constant evaluation has its
27693 own separate setting that can not be turned off from the command
27694 line using --unchecked or --checked and is only controlled using
27695 the checked/unchecked statements and expressions. This setting is
27696 used by the constant folder to flag errors.
27698 * expression.cs (CheckedExpr, UncheckedExpr): Set the
27699 ConstantCheckState as well.
27701 During Resolve, they also have to flag the state, because the
27702 constant folder runs completely in the Resolve phase.
27704 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
27707 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27709 * cfold.cs: New file, this file contains the constant folder.
27711 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
27712 argument to track whether we are using the resulting address to
27713 load or store a value and provide better error messages.
27715 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
27716 new AddressOf arguments.
27718 * statement.cs (Foreach.EmitCollectionForeach): Update
27720 * expression.cs (Argument.Emit): Call AddressOf with proper
27721 arguments to track usage.
27723 (New.DoEmit): Call AddressOf with new arguments.
27725 (Unary.Emit): Adjust AddressOf call.
27727 2002-03-01 Ravi Pratap <ravi@ximian.com>
27729 * cs-parser.jay (member_access): Change the case for pre-defined types
27730 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
27733 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
27736 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
27737 essentially like methods and apply attributes like MethodImplOptions to them too.
27739 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
27742 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
27743 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
27746 * Update code everywhere accordingly.
27748 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
27750 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
27752 2002-02-28 Ravi Pratap <ravi@ximian.com>
27754 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
27755 try performing lookups against those instead of jumping straight into using
27756 the 'using' clauses.
27758 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
27760 (LookupType): Perform lookups in implicit parents too.
27762 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
27763 sequence as RootContext.LookupType.
27765 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
27766 the various cases of namespace lookups into this method.
27768 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27770 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
27771 in positional arguments)
27773 * class.cs (Operator): Update the AllowedModifiers to contain
27776 * cs-parser.jay: Update operator declaration to allow for the
27777 operator body to be empty.
27779 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
27782 2002-02-27 Miguel de Icaza <miguel@ximian.com>
27784 * class.cs (Method.Emit): Label parameters.
27786 * driver.cs: Return 1 or 0 as the program exit code.
27788 2002-02-26 Miguel de Icaza <miguel@ximian.com>
27790 * expression.cs: Special case the `null' object when trying to
27791 auto-compute the type, as anything can be explicitly converted to
27794 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
27795 spotting this Paolo.
27797 (Expression.ImplicitNumericConversion): Perform comparissions of
27798 the type using the underlying type in the case of an enumeration
27799 rather than using the enumeration type for the compare.
27801 Cope with the underlying == type case, which is not possible to
27804 (Expression.ConvertNumericExplicit): Perform comparissions of
27805 the type using the underlying type in the case of an enumeration
27806 rather than using the enumeration type for the compare.
27808 * driver.cs: If the user does not supply an extension, assume .exe
27810 * cs-parser.jay (if_statement): Rewrote so that we can track the
27811 location for the if statement.
27813 * expression.cs (Binary.ConstantFold): Only concat strings when
27814 the operation is "+", not everything ;-)
27816 * statement.cs (Statement.EmitBoolExpression): Take a location
27818 (If, While, Do): Track location.
27820 * expression.cs (Binary.ResolveOperator): In the object + string
27821 case, I was missing a call to ConvertImplicit
27823 2002-02-25 Ravi Pratap <ravi@ximian.com>
27825 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
27826 Location arguments. Ensure we use RootContext.LookupType to do our work
27827 and not try to do a direct Type.GetType and ModuleBuilder.GetType
27829 * interface.cs (PopulateMethod): Handle the type of the parameter being
27832 * expression.cs (Invocation.BetterFunction): Handle the case when we
27833 have a params method with no fixed arguments and a call is made with no
27836 2002-02-25 Miguel de Icaza <miguel@ximian.com>
27838 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
27839 the verbatim-string-literal
27841 * support.cs (InternalParameters.ParameterModifier): handle null
27843 (InternalParameters.ParameterType): ditto.
27845 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
27846 duplicating the name of the variable parameter.
27847 (GetParameterByName): Fix bug where we were not looking up array
27848 paramters if they were the only present (thanks Paolo!).
27849 (GetParameterInfo): We only have an empty set of types if both
27850 fixed and array are set to null.
27851 (GetParameterInfo-idx): Handle FixedParameter == null
27853 * cs-parser.jay: Handle the case where there is no catch
27854 statements (missing null test).
27856 2002-02-22 Miguel de Icaza <miguel@ximian.com>
27858 * driver.cs (MainDriver): Be conservative on our command line
27861 Catch DirectoryNotFoundException when calling GetFiles.
27863 (SplitPathAndPattern): Used to split the input specification into
27864 a path and a pattern that we can feed to Directory.GetFiles.
27866 2002-02-21 Miguel de Icaza <miguel@ximian.com>
27868 * statement.cs (Fixed): Implement the last case of the Fixed
27869 statement (string handling).
27871 * expression.cs (StringPtr): New class used to return a char * to
27872 a string; Used by the Fixed statement.
27874 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
27876 * expression.cs (Binary.ResolveOperator): Remove redundant
27877 MemberLookup pn parent type.
27878 Optimize union call, we do not need a union if the types are the same.
27879 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
27882 Specialize the use of MemberLookup everywhere, instead of using
27883 the default settings.
27885 (StackAlloc): Implement stackalloc keyword.
27887 * cs-parser.jay: Add rule to parse stackalloc.
27889 * driver.cs: Handle /h, /help, /?
27891 * expression.cs (MakeByteBlob): Removed the hacks we had in place
27892 before we supported unsafe code.
27894 * makefile: add --unsafe to the self compilation of mcs.
27896 2002-02-20 Miguel de Icaza <miguel@ximian.com>
27898 * expression.cs (PointerArithmetic): New class that is used to
27899 perform pointer arithmetic.
27900 (Binary.Resolve): Handle pointer arithmetic
27901 Handle pointer comparission.
27902 (ArrayPtr): Utility expression class that is used to take the
27903 address of an array.
27905 (ElementAccess): Implement array access for pointers
27907 * statement.cs (Fixed): Implement fixed statement for arrays, we
27908 are missing one more case before we are done.
27910 * expression.cs (Indirection): Implement EmitAssign and set the
27911 ExprClass to Variable. This allows pointer dereferences to be
27912 treated as variables, and to have values assigned to them.
27914 * ecore.cs (Expression.StoreFromPtr): New utility function to
27915 store values dereferencing.
27917 2002-02-20 Ravi Pratap <ravi@ximian.com>
27919 * expression.cs (Binary.ResolveOperator): Ensure that we are
27920 not trying to operate on a void type - this fixes the reported
27923 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
27924 the parent implementation is sealed.
27926 * ../errors/cs0239.cs : Add.
27928 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
27930 * typemanager.cs (unverifiable_code_type): Corresponds to
27931 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
27932 which have unsafe code in them.
27934 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
27937 2002-02-19 Miguel de Icaza <miguel@ximian.com>
27939 * cs-tokenizer.cs: Add support for @"litreal strings"
27941 Make tokenizer accept pre-processor directives
27942 on any column (remove the old C-like limitation).
27944 * rootcontext.cs (EmitCode): Emit any global attributes.
27945 (AddGlobalAttributes): Used to keep track of assembly attributes.
27947 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
27949 * cs-parser.jay: Add support for global attributes.
27951 2002-02-17 Miguel de Icaza <miguel@ximian.com>
27953 * expression.cs (Indirection): New helper class. Unary will
27954 create Indirection classes to be able to implement the
27955 IMemoryLocation interface on it.
27957 2002-02-16 Miguel de Icaza <miguel@ximian.com>
27959 * cs-parser.jay (fixed_statement): reference the right statement.
27961 * statement.cs (Fixed.Emit): Finish implementing the fixed
27962 statement for the &x case.
27964 2002-02-14 Miguel de Icaza <miguel@ximian.com>
27966 * class.cs (Property.Define, Method.Define): Remove newslot when
27969 * modifiers.cs: My use of NewSlot when `Abstract' was set was
27970 wrong. NewSlot should only be used if the `new' keyword is present.
27972 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
27973 locating our system dir. Sorry about this.
27975 2002-02-13 Miguel de Icaza <miguel@ximian.com>
27977 * driver.cs (GetSystemDir): Compute correctly the location of our
27978 system assemblies. I was using the compiler directory instead of
27979 the library directory.
27981 2002-02-13 Ravi Pratap <ravi@ximian.com>
27983 * expression.cs (BetterFunction): Put back in what Miguel commented out
27984 since it is the correct fix. The problem is elsewhere ;-)
27986 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
27987 parameters of the parms method are themselves compatible or not !
27989 (StandardConversionExists): Fix very dangerous bug where we were forgetting
27990 to check that a class implements an interface before saying that an implicit
27991 conversion was allowed. Use ImplementsInterface to do the checking.
27993 2002-02-13 Miguel de Icaza <miguel@ximian.com>
27995 * class.cs (Method.Define): Track whether we are an explicit
27996 implementation or not. And only call DefineMethodOverride if we
27997 are an explicit implementation.
27999 (Property.DefineMethod): Ditto.
28001 2002-02-11 Ravi Pratap <ravi@ximian.com>
28003 * expression.cs (BetterFunction): Catch hideous bug which was
28004 preventing us from detecting ambiguous calls due to implicit casts i.e
28007 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28009 * support.cs (Pair): Remove un-needed method. I figured why I was
28010 getting the error in cs-parser.jay, the variable in a foreach loop
28011 is readonly, and the compiler does not really treat this as a variable.
28013 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28014 instead of EQUALS in grammar.
28016 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28018 * expression.cs (Unary.DoResolve): Check whether the argument is
28021 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28023 * support.cs: Api for Pair to set a value. Despite the fact that
28024 the variables are public the MS C# compiler refuses to compile
28025 code that accesses the field if the variable is part of a foreach
28028 * statement.cs (Fixed): Begin implementation of the fixed
28031 (Block.AddVariable): Return the VariableInfo on success and null
28032 on failure instead of true/false.
28034 * cs-parser.jay (foreach): Catch errors on variables already
28035 defined (we were ignoring this value before) and properly unwind
28036 the block hierarchy
28038 (fixed_statement): grammar for the fixed statement.
28040 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28042 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28043 pointer types to be incretemented.
28045 (SizeOf): Implement.
28047 * cs-parser.jay (pointer_member_access): Implement
28048 expr->IDENTIFIER production.
28050 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28051 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28054 (Unary): Implement indirection.
28056 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28057 use in non-unsafe context).
28059 (SimpleName.DoResolve): Check for pointers in field access on safe
28062 (Expression.LoadFromPtr): Factor the load-indirect code in this
28063 function. This was duplicated in UnboxCast and ParameterReference
28065 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28067 * expression.cs (ComposedCast): report an error if a pointer cast
28068 is used in a safe region.
28070 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28071 pointer type casts in unsafe context.
28073 * codegen.cs (EmitContext): Set up IsUnsafe.
28075 * cs-parser.jay (non_expression_type): Add productions for pointer
28078 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28079 code. We should not use force into static mode if the method is
28080 not virtual. Fixes bug in MIS
28082 * statement.cs (Do.Emit, While.Emit, For.Emit,
28083 Statement.EmitBoolExpression): Add support to Do and While to
28084 propagate infinite loop as `I do return' semantics.
28086 Improve the For case to also test for boolean constants.
28088 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28089 to the list of attributes we can add.
28091 Remove `EmitContext' argument.
28093 * class.cs (Method.Define): Apply parameter attributes.
28094 (Constructor.Define): Apply parameter attributes.
28095 (MethodCore.LabelParameters): Move here the core of labeling
28098 * support.cs (ReflectionParameters.ParameterModifier,
28099 InternalParameters.ParameterModifier): Use IsByRef on the type and
28100 only return the OUT bit for these parameters instead of in/out/ref
28103 This is because I miss-understood things. The ParameterInfo.IsIn
28104 and IsOut represent whether the parameter has the [In] and [Out]
28107 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28109 * ecore.cs (FieldExpr.Emit): Release temporaries.
28111 * assign.cs (LocalTemporary.Release): new function.
28113 * codegen.cs (EmitContext.GetTemporaryStorage,
28114 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28115 temporary storage. Now we can "put back" localbuilders when we
28118 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28120 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28121 need to make a copy of the variable to generate verifiable code.
28123 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28125 * driver.cs: Compute dynamically the system directory.
28127 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28128 Slower, but more generally useful. Used by the abstract
28129 registering implementation.
28131 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28132 the rules for the special rule on Type/instances. First check if
28133 we have the same name, and if so, try that special static path
28134 rather than the instance path.
28136 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28138 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28141 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28142 Enum, ValueType, Delegate or Array for non-corlib compiles.
28144 * cs-tokenizer.cs: Catch long identifiers (645)
28146 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28149 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28150 fix, we were returning too early, so we were not registering
28151 pending methods from abstract classes.
28153 Do not register pending methods if the class is abstract.
28155 * expression.cs (Conditional.DoResolve): Report circular implicit
28156 conversions when we neecd to compute it for conditional
28159 (Is.DoResolve): If the expression is always of the provided type,
28160 flag warning 183. If the expression can not ever be of the
28161 provided type flag warning 184.
28163 * class.cs: Catch 169 as well.
28165 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28168 2002-01-18 Nick Drochak <ndrochak@gol.com>
28170 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28172 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28174 * interface.cs: (PopulateMethod): Check for pointers being defined
28175 only if the unsafe context is active.
28176 (PopulateProperty): ditto.
28177 (PopulateIndexer): ditto.
28179 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28180 specified. If pointers are present, make sure that they are
28181 present in an unsafe context.
28182 (Constructor, Constructor.Define): ditto.
28183 (Field, Field.Define): ditto.
28184 (Property, Property.Define): ditto.
28185 (Event, Event.Define): ditto.
28187 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28188 hashtable if there are classes or structs defined.
28190 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28191 code, as the constant resolution moved.
28193 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28194 the metadata, so we can flag error 133.
28196 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28197 pointer is being declared in an unsafe context.
28199 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28201 * modifiers.cs (Modifiers.Check): Require a Location argument.
28202 Report error 227 for Unsafe use.
28204 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28206 * statement.cs (For.Emit): If the test is null, then report that
28207 we do `return', as we wont reach anything afterwards.
28209 (Switch.SwitchGoverningType): Track the expression that matched
28212 * driver.cs: Allow negative numbers as an error code to flag.
28214 * cs-parser.jay: Handle 1551.
28216 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28218 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28220 * cs-parser.jay: Report 1518 (type declaration can only contain
28221 class, struct, interface, enum or delegate)
28223 (switch_label): Report 1523 (keywords `case' or `default' must
28226 (opt_switch_sections): Report 1522 (empty switch)
28228 * driver.cs: Report 1515 (response file specified multiple times)
28229 Report 1516 (Source file specified multiple times).
28231 * expression.cs (Argument.Resolve): Signal 1510
28233 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28234 access not allowed in static code)
28236 2002-01-11 Ravi Pratap <ravi@ximian.com>
28238 * typemanager.cs (IsPointerType): Utility method which we are going
28241 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28242 the object type, so we take care of that.
28244 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28246 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28247 added to non-params parameters :-)
28249 * typemanager.cs (CSharpName): Include 'void' type too.
28251 (void_ptr_type): Include in the set of core types.
28253 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28256 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28259 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28260 completely forgotten about it.
28262 2002-01-10 Ravi Pratap <ravi@ximian.com>
28264 * cs-parser.jay (pointer_type): Add. This begins our implementation
28265 of parsing rules for unsafe code.
28267 (unsafe_statement): Implement.
28269 (embedded_statement): Modify to include the above.
28271 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28273 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28274 if the current context is an unsafe one.
28276 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28277 are handled differently, we need separate rules for them.
28279 (local_variable_declaration): Update to use local_variable_pointer_type
28280 to allow variable declarations of unmanaged pointer types.
28282 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28283 in unsafe contexts.
28285 * ../errors/cs0214.cs : Add.
28287 2002-01-16 Nick Drochak <ndrochak@gol.com>
28289 * makefile: remove 'response' file when cleaning.
28291 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28293 * cs-parser.jay: Report 1524.
28295 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28297 * typemanager.cs (RegisterMethod): drop checking if we have
28298 registered this from here
28300 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28302 * class.cs (Method.EmitDestructor): Implement calling our base
28305 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28306 value of InFinally.
28308 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28309 this routine and will wrap the call in a try/catch block. Deal
28312 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28314 * ecore.cs (Expression.MemberLookup): instead of taking a
28315 parameter `same_type' that was used to tell whether we could
28316 access private members we compute our containing type from the
28319 (FieldExpr): Added partial support for volatile fields. This does
28320 not work for volatile fields exposed from assemblies, as I can not
28321 figure out how to extract the modreq from it.
28323 Updated all the source files to use this.
28325 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28326 because it is referenced by MemberLookup very often.
28328 2002-01-09 Ravi Pratap <ravi@ximian.com>
28330 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28331 TypeBuilder.GetCustomAttributes to retrieve what we need.
28333 Get rid of redundant default_member_attr_type as this is the same as
28334 default_member_type which already exists.
28336 * interface.cs, attribute.cs : Update accordingly.
28338 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28340 * typemanager.cs: Enable IndexerPropertyName again. It does not
28341 work for TYpeBuilders though. Ravi, can you please fix this?
28343 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28345 * expression.cs (Argument.Emit): Handle the case of ref objects
28346 being passed to ref functions;
28348 (ParameterReference.EmitLoad): Loads the content of the pointer
28349 without dereferencing.
28351 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28353 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28355 2002-01-08 Ravi Pratap <ravi@ximian.com>
28357 * class.cs (Indexer.DefineMethod): Incorporate the interface
28358 type in the name of the method if we are doing explicit interface
28361 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28363 (BetterConversion): Fix extremely trivial bug where we were referring to
28364 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28367 * ../errors/bug16.cs : Add although we have fixed it.
28369 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28371 * expression.cs (BaseIndexer): Begin implementation.
28373 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28375 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28376 production directly to remove a shift/reduce, and implement
28377 explicit interface implementation.
28379 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28380 after a floating point suffix.
28382 * expression.cs (DoNumericPromotions): Improved the conversion for
28383 uint/uint. If we have a constant, we avoid doing a typecast to a
28386 * class.cs (Indexer): Implement explicit interface implementation
28389 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28391 * class.cs: make the default instance constructor public and hidebysig.
28393 2001-01-03 Ravi Pratap <ravi@ximian.com>
28395 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28396 so we can call it from elsewhere.
28398 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28399 we emit it internally if the class has a defined indexer; otherwise the user
28400 emits it by decorating the class definition with the DefaultMemberAttribute.
28402 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28403 attribute is not used on a type which defines an indexer.
28405 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28406 character when we skip whitespace.
28408 * ../errors/cs0646.cs : Add.
28410 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28412 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28415 * makefile: Add practical target `mcs3.exe' which builds the third
28416 generation compiler.
28418 * expression.cs (New): Fix structures constructor calling.
28420 * class.cs (Property, Method, Indexer): Emit Final flag on the
28421 method if we are an interface implementation and we are not
28424 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28425 whether this property is referencing a `base' method.
28427 * expression.cs (Invocation.EmitCall): take an extra argument:
28428 is_base, this is used to determine whether the `call' or
28429 `callvirt' opcode should be used.
28432 * delegate.cs: update EmitCall.
28434 * class.cs (Method.Define): Set NewSlot for the cases where we are
28435 not implementing an interface method.
28437 (Property.Define): ditto.
28439 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28441 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28442 'r'. Allows mcs to parse itself fully.
28444 2002-01-02 Ravi Pratap <ravi@ximian.com>
28446 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28447 of the number of initializers that require the InitializeArray method.
28449 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28450 update the above field where necessary.
28452 (MakeByteBlob): Update accordingly.
28454 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28457 (EmitDynamicInitializers): Update in accordance with the new optimization.
28459 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28460 same OpCode applies.
28462 * cs-parser.jay : Fix some glaring errors I introduced.
28464 2002-01-01 Ravi Pratap <ravi@ximian.com>
28466 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28467 so that we can check for name clashes there too.
28469 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28470 for interface indexers.
28472 * interfaces.cs (Define): Emit the default member attribute.
28474 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28475 variable was being referred to while setting the value ;-)
28477 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28479 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28480 byte-by-byte information when we know the data is zero.
28482 Make the block always a multiple of 4, because
28483 DefineInitializedData has a bug.
28485 * assign.cs: Fix, we should assign from the temporary, not from
28488 * expression.cs (MakeByteBlob): Fix my incorrect code.
28490 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28492 * typemanager.cs (EnumToUnderlying): This function is used to get
28493 the underlying type from an enumeration, because it does not
28496 * constant.cs: Use the I4_S form for values between -128 and 127.
28498 * statement.cs (Block.LookupLabel): Looks up a label.
28499 (Block): Drop support for labeled blocks.
28501 (LabeledStatement): New kind of statement that represents a label
28504 (Goto): Finally implement this bad boy.
28506 * cs-parser.jay: Update to reflect new mechanism to implement
28509 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28511 * codegen.cs (EmitContext.This): a codegen property that keeps the
28512 a single instance of this instead of creating many different this
28515 * delegate.cs (Delegate.DoResolve): Update to use the property;
28517 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28519 * expression.cs (BaseAccess.DoResolve): Ditto.
28521 2001-12-29 Ravi Pratap <ravi@ximian.com>
28523 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28524 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28526 (InitCoreTypes): Update accordingly.
28528 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28529 so we can quickly store the state.
28531 (ApplyAttributes): Set the correct implementation flags
28532 for InternalCall methods.
28534 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28536 * expression.cs (EmitCall): if a method is not virtual, then do
28537 not use callvirt on it.
28539 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28540 user defined stuff) requires the use of stobj, which takes an
28541 address on the stack instead of an array and an index. So emit
28542 the Ldelema operation for it.
28544 (EmitStoreOpcode): Use stobj for valuetypes.
28546 (UnaryMutator.EmitCode): Use the right 1 value depending on
28547 whether we are dealing with int64/uint64, float or doubles.
28549 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
28550 constructors that I implemented last night.
28552 (Constructor.IsDefault): Fix to work properly for static
28555 * cs-parser.jay (CheckDef): report method signature errors.
28556 Update error number 103 to be 132.
28558 * decl.cs: New AdditionResult enumeration value: MethodExists.
28559 Although we do this check for methods later on in the semantic
28560 analysis, catching repeated default constructors is so easy that
28561 we catch these here.
28563 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
28566 (ParameterReference.EmitAssign, Emit): handle
28569 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
28570 (ArrayAccess.EmitStoreOpcode): ditto.
28572 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
28574 * expression.cs (MakeByteBlob): Complete all the missing types
28575 (uint, short, ushort, byte, sbyte)
28577 * class.cs: Only init instance field initializers on instance
28580 Rename `constructors' to instance_constructors.
28582 (TypeContainer.AddConstructor): Only add constructors to the list
28583 if it is not static.
28585 Make sure that we handle default_static_constructor independently
28586 everywhere where we handle instance_constructors
28588 2001-12-28 Miguel de Icaza <miguel@ximian.com>
28590 * class.cs: Do not lookup or create a base initializer for a
28591 static constructor.
28593 (ConstructorInitializer.Resolve): use the proper type to lookup
28596 * cs-parser.jay: Report error 1585 (modifiers between type and name).
28598 * enum.cs, interface.cs: Remove CloseType, this is taken care by
28601 * decl.cs: CloseType is now an virtual method, the default
28602 implementation just closes this type.
28604 2001-12-28 Ravi Pratap <ravi@ximian.com>
28606 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
28607 to PreserveSig by default. Also emit HideBySig on such methods.
28609 Basically, set the defaults to standard values.
28611 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
28612 argument, if candidate is better, it can't be worse than the best !
28614 (Invocation): Re-write bits to differentiate between methods being
28615 applicable in their expanded form and their normal form - for params
28618 Get rid of use_standard everywhere as only standard conversions are allowed
28619 in overload resolution.
28621 More spec conformance.
28623 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28625 * driver.cs: Add --timestamp, to see where the compiler spends
28628 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
28629 `this' in static code.
28631 (SimpleName.DoResolve): Implement in terms of a helper function
28632 that allows static-references to be passed upstream to
28635 (Expression.ResolveWithSimpleName): Resolve specially simple
28636 names when called by MemberAccess to implement the special
28639 (Expression.ImplicitReferenceConversion): Handle conversions from
28640 Null to reference types before others, as Null's type is
28643 * expression.cs (Invocation.EmitCall): Handle the special case of
28644 calling methods declared on a reference type from a ValueType
28645 (Base classes System.Object and System.Enum)
28647 (MemberAccess.Resolve): Only perform lookups on Enumerations if
28648 the left hand side is a TypeExpr, not on every enumeration.
28650 (Binary.Resolve): If types are reference types, then do a cast to
28651 object on operators != and == of both arguments.
28653 * typemanager.cs (FindMembers): Extract instance and static
28654 members if requested.
28656 * interface.cs (PopulateProperty): Use void_type instead of null
28657 as the return type for the setter method.
28659 (PopulateIndexer): ditto.
28661 2001-12-27 Ravi Pratap <ravi@ximian.com>
28663 * support.cs (ReflectionParameters): Fix minor bug where we
28664 were examining the wrong parameter for the ParamArray attribute.
28666 Cope with requests for the type of the parameter at position
28667 greater than the params parameter's. We now return the element
28668 type of the params array as that makes more sense.
28670 * expression.cs (Invocation.IsParamsMethodApplicable): Update
28671 accordingly as we no longer have to extract the element type
28674 (Invocation.OverloadResolve): Update.
28676 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28678 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
28679 against IEnumerator, test whether the return value is a descendant
28680 of the IEnumerator interface.
28682 * class.cs (Indexer.Define): Use an auxiliary method to implement
28683 the other bits of the method definition. Begin support for
28684 explicit interface implementation.
28686 (Property.DefineMethod): Use TypeManager.void_type instead of null
28687 for an empty return value.
28689 2001-12-26 Miguel de Icaza <miguel@ximian.com>
28691 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
28692 dealing with a FieldExpr which is composed of a FieldBuilder, in
28693 the code path we did extract the constant, but we should have
28694 obtained the underlying value to be able to cast it (otherwise we
28695 end up in an infinite loop, this is what Ravi was running into).
28697 (ArrayCreation.UpdateIndices): Arrays might be empty.
28699 (MemberAccess.ResolveMemberAccess): Add support for section
28700 14.5.4.1 that deals with the special case of E.I when E is a type
28701 and something else, that I can be a reference to a static member.
28703 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
28704 handle a particular array type to create byte blobs, it is just
28705 something we dont generate byteblobs for.
28707 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
28710 * location.cs (Push): remove the key from the hashtable that we
28711 are about to add. This happens for empty files.
28713 * driver.cs: Dispose files after we have parsed them.
28715 (tokenize): new function that only runs the tokenizer on its
28716 input, for speed testing.
28718 2001-12-26 Ravi Pratap <ravi@ximian.com>
28720 * class.cs (Event.Define): Define the private field only if there
28721 are no accessors defined.
28723 * expression.cs (ResolveMemberAccess): If there is no associated
28724 field with the event, that means we have an event defined with its
28725 own accessors and we should flag error cs0070 since transforming
28726 ourselves into a field is not valid in that case.
28728 * ecore.cs (SimpleName.DoResolve): Same as above.
28730 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
28731 and charset to sane values.
28733 2001-12-25 Ravi Pratap <ravi@ximian.com>
28735 * assign.cs (DoResolve): Perform check on events only if they
28736 are being accessed outside the declaring type.
28738 * cs-parser.jay (event_declarations): Update rules to correctly
28739 set the type of the implicit parameter etc.
28741 (add_accessor, remove_accessor): Set current local parameters.
28743 * expression.cs (Binary): For delegate addition and subtraction,
28744 cast the return value from the method into the appropriate delegate
28747 2001-12-24 Ravi Pratap <ravi@ximian.com>
28749 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
28750 of these as the workaround is unnecessary.
28752 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
28753 delegate data - none of that is needed at all.
28755 Re-write bits to extract the instance expression and the delegate method
28758 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
28761 * attribute.cs (ApplyAttributes): New method to take care of common tasks
28762 of attaching attributes instead of duplicating code everywhere.
28764 * everywhere : Update code to do attribute emission using the above method.
28766 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28768 * expression.cs (IsParamsMethodApplicable): if there are not
28769 parameters, return immediately.
28771 * ecore.cs: The 0 literal can be implicity converted to an enum
28774 (SimpleName.DoResolve): First lookup the type, then lookup the
28777 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
28778 want to get its address. If the InstanceExpression is not
28779 addressable, store the result in a temporary variable, then get
28782 * codegen.cs: Only display 219 errors on warning level or above.
28784 * expression.cs (ArrayAccess): Make it implement the
28785 IMemoryLocation interface.
28787 (Binary.DoResolve): handle the operator == (object a, object b)
28788 and operator != (object a, object b) without incurring into a
28789 BoxedCast (because 5 != o should never be performed).
28791 Handle binary enumerator operators.
28793 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
28794 value type, otherwise use Ldelem_ref.
28796 Use precomputed names;
28798 (AddressOf): Implement address of
28800 * cs-parser.jay (labeled_statement): Fix recursive block
28801 addition by reworking the production.
28803 * expression.cs (New.DoEmit): New has a special case:
28805 If we are dealing with a ValueType, we have a few
28806 situations to deal with:
28808 * The target of New is a ValueType variable, that is
28809 easy, we just pass this as the variable reference
28811 * The target of New is being passed as an argument,
28812 to a boxing operation or a function that takes a
28815 In this case, we need to create a temporary variable
28816 that is the argument of New.
28819 2001-12-23 Ravi Pratap <ravi@ximian.com>
28821 * rootcontext.cs (LookupType): Check that current_type is not null before
28822 going about looking at nested types.
28824 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
28825 not implement the IAssignMethod interface any more.
28827 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
28828 where we tranform them into FieldExprs if they are being resolved from within
28829 the declaring type.
28831 * ecore.cs (SimpleName.DoResolve): Do the same here.
28833 * assign.cs (DoResolve, Emit): Clean up code considerably.
28835 * ../errors/bug10.cs : Add.
28837 * ../errors/cs0070.cs : Add.
28839 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
28841 * assign.cs : Get rid of EventIsLocal everywhere.
28843 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28845 * ecore.cs (ConvertIntLiteral): finished the implementation.
28847 * statement.cs (SwitchLabel): Convert the value we are using as a
28848 key before looking up the table.
28850 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28852 * codegen.cs (EmitTopBlock): Require a Location argument now.
28854 * cs-parser.jay (constructor_declarator): We need to setup
28855 current_local_parameters before we parse the
28856 opt_constructor_initializer, to allow the variables to be bound
28857 to the constructor arguments.
28859 * rootcontext.cs (LookupType): First lookup nested classes in our
28860 class and our parents before we go looking outside our class.
28862 * expression.cs (ConstantFold): Extract/debox the values at the
28865 * rootcontext.cs (EmitCode): Resolve the constants first before we
28866 resolve the types. This is not really needed, but it helps debugging.
28868 * statement.cs: report location.
28870 * cs-parser.jay: pass location to throw statement.
28872 * driver.cs: Small bug fix.
28874 * report.cs: Updated format to be 4-zero filled digits.
28876 2001-12-22 Ravi Pratap <ravi@ximian.com>
28878 * expression.cs (CheckIndices): Fix minor bug where the wrong
28879 variable was being referred to ;-)
28881 (DoEmit): Do not call EmitStaticInitializers when the
28882 underlying type is System.Object.
28884 2001-12-21 Ravi Pratap <ravi@ximian.com>
28886 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
28887 and do the usual workaround for SRE.
28889 * class.cs (MyEventBuilder.EventType): New member to get at the type
28890 of the event, quickly.
28892 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
28894 * assign.cs (Assign.DoResolve): Handle the case when the target
28895 is an EventExpr and perform the necessary checks.
28897 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
28900 (SimpleName.MemberStaticCheck): Include check for EventExpr.
28902 (EventExpr): Set the type in the constructor itself since we
28903 are meant to be born fully resolved.
28905 (EventExpr.Define): Revert code I wrote earlier.
28907 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
28908 instance expression is null. The instance expression is a This in that case
28909 or a null, depending on whether it is a static method or not.
28911 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
28912 refers to more than one method.
28914 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
28915 and accordingly flag errors.
28917 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28919 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
28921 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28923 * location.cs (ToString): Provide useful rutine.
28925 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28927 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
28928 objects, return the actual integral boxed.
28930 * statement.cs (SwitchLabel): define an ILLabel for each
28933 (Switch.CheckSwitch): If the value is a Literal, extract
28934 the underlying literal.
28936 Also in the unused hashtable we had, add the SwitchLabel so we can
28937 quickly look this value up.
28939 * constant.cs: Implement a bunch of new constants. Rewrite
28940 Literal based on this. Made changes everywhere to adapt to this.
28942 * expression.cs (Expression.MakeByteBlob): Optimize routine by
28943 dereferencing array only once, and also copes with enumrations.
28945 bytes are two bytes wide, not one.
28947 (Cast): Perform constant conversions.
28949 * ecore.cs (TryImplicitIntConversion): Return literals instead of
28950 wrappers to the literals here.
28952 * expression.cs (DoNumericPromotions): long literals can converted
28953 to ulong implicity (this is taken care of elsewhere, but I was
28954 missing this spot).
28956 * ecore.cs (Expression.Literalize): Make the return type Literal,
28957 to improve type checking.
28959 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
28961 2001-12-20 Miguel de Icaza <miguel@ximian.com>
28963 * literal.cs: Revert code from ravi that checked the bounds. The
28964 bounds are sane by the definition of the type itself.
28966 * typemanager.cs: Fix implementation of ImplementsInterface. We
28967 need to actually look up in our parent hierarchy for interfaces
28970 * const.cs: Use the underlying type for enumerations
28972 * delegate.cs: Compute the basename for the delegate creation,
28973 that should fix the delegate test case, and restore the correct
28974 Type Lookup semantics in rootcontext
28976 * rootcontext.cs: Revert Ravi's last patch. The correct way of
28977 referencing a nested type with the Reflection API is using the "+"
28980 * cs-parser.jay: Do not require EOF token at the end.
28982 2001-12-20 Ravi Pratap <ravi@ximian.com>
28984 * rootcontext.cs (LookupType): Concatenate type names with
28985 a '.' instead of a '+' The test suite passes again.
28987 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
28988 field of the enumeration.
28990 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
28991 the case when the member is an EventExpr.
28993 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
28994 static has an associated instance expression.
28996 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
28998 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29000 * class.cs (Event.Define): Register event and perform appropriate checks
29003 We define the Add and Remove methods even if the use provides none because
29004 in that case, we provide default implementations ourselves.
29006 Define a private field of the type of the event. This is done by the CSC compiler
29007 and we should be doing it too ;-)
29009 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29010 More methods we use in code we generate.
29012 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29015 (InitCoreTypes): Update accordingly for the above.
29017 * class.cs (Event.Emit): Generate code for default accessors that we provide
29019 (EmitDefaultMethod): Do the job in the above.
29021 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29024 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29026 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29027 builders even if we were missing one.
29029 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29030 pass the Basename as our class name instead of the Name. The
29031 basename will be correctly composed for us.
29033 * parameter.cs (Paramters): Now takes a Location argument.
29035 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29036 make all the code call directly LookupType in RootContext and take
29037 this chance to pass the Location information everywhere.
29039 * Everywhere: pass Location information.
29041 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29043 * class.cs (Constructor.Define): Updated way of detecting the
29044 length of the parameters.
29046 (TypeContainer.DefineType): Use basename as the type name for
29049 (TypeContainer.Define): Do not recursively define types here, as
29050 definition is taken care in order by the RootContext.
29052 * tree.cs: Keep track of namespaces in a per-file basis.
29054 * parameter.cs (Parameter.ComputeSignature): Update to use
29057 (Parameters.GetSignature): ditto.
29059 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29060 instead of a TypeContainer.
29062 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29063 resolve names. Because we need to be resolve in our context, not
29066 * driver.cs: Implement response files.
29068 * class.cs (TypeContainer.DefineType): If we are defined, do not
29069 redefine ourselves.
29071 (Event.Emit): Emit the code for add/remove handlers.
29072 (Event.Define): Save the MethodBuilders for add/remove.
29074 * typemanager.cs: Use pair here too.
29076 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29077 DictionaryEntry requires the first argument to be non-null.
29079 (enum_declaration): Compute full name for registering the
29082 (delegate_declaration): Instead of using
29083 formal_parameter_list, use opt_formal_parameter_list as the list
29086 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29087 (EventParsing): New property that controls whether `add' and
29088 `remove' are returned as tokens or identifiers (for events);
29090 2001-12-19 Ravi Pratap <ravi@ximian.com>
29092 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29093 use MyEventBuilder only and let it wrap the real builder for us.
29095 (MyEventBuilder): Revamp constructor etc.
29097 Implement all operations that we perform on EventBuilder in precisely the same
29100 (FindMembers): Update to use the EventBuilder member.
29102 (Event.Emit): Update accordingly.
29104 2001-12-18 Ravi Pratap <ravi@ximian.com>
29106 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29107 by calling the appropriate methods.
29109 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29112 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29114 2001-12-17 Ravi Pratap <ravi@ximian.com>
29116 * delegate.cs (Delegate.Populate): Check that the return type
29117 and various parameters types are indeed accessible.
29119 * class.cs (Constructor.Define): Same here.
29121 (Field.Define): Ditto.
29123 (Event.Define): Ditto.
29125 (Operator.Define): Check that the underlying Method defined itself
29126 correctly - so it's MethodBuilder should not be null.
29128 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29129 expression happens to be null.
29131 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29132 members but as of now we don't seem to be able to do anything really useful with it.
29134 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29135 not the EventBuilder.
29137 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29139 * cs-tokenizer.cs: Add support for defines.
29140 Add support for #if, #elif, #else, #endif
29142 (eval_var): evaluates a variable.
29143 (eval): stubbed for evaluating functions.
29145 * cs-parser.jay: Pass the defines information
29147 * driver.cs: Add --define command line option.
29149 * decl.cs: Move MemberCore here.
29151 Make it the base class for DeclSpace. This allows us to catch and
29152 report 108 and 109 for everything now.
29154 * class.cs (TypeContainer.Define): Extract all the members
29155 before populating and emit the warning 108 (new keyword required
29156 to override) instead of having each member implement this.
29158 (MemberCore.Define): New abstract method, we will be using this in
29159 the warning reporting engine in Populate.
29161 (Operator.Define): Adjust to new MemberCore protocol.
29163 * const.cs (Const): This does not derive from Expression, it is a
29164 temporary object we use to create fields, it is a MemberCore.
29166 * class.cs (Method.Define): Allow the entry point to be in a
29169 * driver.cs: Rewrite the argument handler to clean it up a bit.
29171 * rootcontext.cs: Made it just an auxiliary namespace feature by
29172 making everything static.
29174 * driver.cs: Adapt code to use RootContext type name instead of
29177 * delegate.cs: Remove RootContext argument.
29179 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29182 * class.cs (Event.Define): The lookup can fail.
29184 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29186 * expression.cs: Resolve the this instance before invoking the code.
29188 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29190 * cs-parser.jay: Add a production in element_access that allows
29191 the thing to become a "type" reference. This way we can parse
29192 things like "(string [])" as a type.
29194 Note that this still does not handle the more complex rules of
29198 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29200 * ecore.cs: (CopyNewMethods): new utility function used to
29201 assemble the list of methods from running FindMembers.
29203 (MemberLookup): Rework FindMembers so that
29205 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29207 * class.cs (TypeContainer): Remove Delegates who fail to be
29210 * delegate.cs (Populate): Verify that we dont get null return
29211 values. TODO: Check for AsAccessible.
29213 * cs-parser.jay: Use basename to emit error 574 (destructor should
29214 have the same name as container class), not the full name.
29216 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29217 possible representation.
29219 Also implements integer type suffixes U and L.
29221 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29223 * expression.cs (ArrayCreation.DoResolve): We need to do the
29224 argument resolution *always*.
29226 * decl.cs: Make this hold the namespace. Hold the root context as
29228 (LookupType): Move here.
29230 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29232 * location.cs (Row, Name): Fixed the code, it was always returning
29233 references to the first file.
29235 * interface.cs: Register properties defined through interfaces.
29237 * driver.cs: Add support for globbing on the command line
29239 * class.cs (Field): Make it derive from MemberCore as well.
29242 2001-12-15 Ravi Pratap <ravi@ximian.com>
29244 * class.cs (Event::Define): Check that the type of the event is a delegate
29245 type else flag error #66.
29247 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29250 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29251 values of EntryPoint, CharSet etc etc.
29253 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29255 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29256 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29257 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29258 which needs this to do its work.
29260 * ../errors/cs0066.cs : Add.
29262 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29264 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29267 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29268 clears out the parameters field.
29269 (MemberSignatureCompare): Cleanup
29271 (MemberCore): New base class used to share code between MethodCore
29274 (RegisterRequiredImplementations) BindingFlags.Public requires
29275 either BindingFlags.Instace or Static. Use instance here.
29277 (Property): Refactored code to cope better with the full spec.
29279 * parameter.cs (GetParameterInfo): Return an empty array instead
29282 * class.cs (Property): Abstract or extern properties have no bodies.
29284 * parameter.cs (GetParameterInfo): return a zero-sized array.
29286 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29287 method modifier validation to the typecontainer so we can reuse
29288 this on properties.
29290 (MethodCore.ParameterTypes): return an empty sized array of types.
29292 (Property.Define): Test property modifier validity.
29294 Add tests for sealed/override too.
29296 (Method.Emit): abstract or extern methods have no bodies.
29298 2001-12-14 Ravi Pratap <ravi@ximian.com>
29300 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29303 (Method::Define, ::Emit): Modify accordingly.
29305 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29307 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29309 * makefile: Pass in /unsafe.
29311 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29313 * class.cs (MakeKey): Kill routine.
29315 * class.cs (TypeContainer.Define): Correctly define explicit
29316 method implementations (they require the full interface name plus
29319 * typemanager.cs: Deply the PtrHashtable here and stop using the
29320 lame keys. Things work so much better.
29322 This of course broke everyone who depended on `RegisterMethod' to
29323 do the `test for existance' test. This has to be done elsewhere.
29325 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29326 the object stupid Equals method (because, that like fails all over
29327 the place). We still do not use it.
29329 * class.cs (TypeContainer.SetRequiredInterface,
29330 TypeContainer.RequireMethods): Killed these two routines and moved
29331 all the functionality to RegisterRequiredImplementations.
29333 (TypeContainer.RegisterRequiredImplementations): This routine now
29334 registers all the implementations required in an array for the
29335 interfaces and abstract methods. We use an array of structures
29336 which can be computed ahead of time to reduce memory usage and we
29337 also assume that lookups are cheap as most classes will not
29338 implement too many interfaces.
29340 We also avoid creating too many MethodSignatures.
29342 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29343 clear the "pending" bit if we find that there are problems with
29346 (TypeContainer.VerifyPendingMethods): Update to report errors of
29347 methods that look like implementations but are not.
29349 (TypeContainer.Define): Add support for explicit interface method
29352 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29354 * typemanager.cs: Keep track of the parameters here instead of
29355 being a feature of the TypeContainer.
29357 * class.cs: Drop the registration of parameters here, as
29358 InterfaceMethods are also interface declarations.
29360 * delegate.cs: Register methods with the TypeManager not only with
29361 the TypeContainer. This code was buggy.
29363 * interface.cs: Full registation here.
29365 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29367 * expression.cs: Remove reducer for binary expressions, it can not
29370 * const.cs: Put here the code that used to go into constant.cs
29372 * constant.cs: Put here the code for constants, this is a new base
29373 class for Literals.
29375 * literal.cs: Make Literal derive from Constant.
29377 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29379 * statement.cs (Return.Emit): Report error 157 if the user
29380 attempts to return from a finally block.
29382 (Return.Emit): Instead of emitting a return, jump to the end of
29385 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29386 LocalBuilder to store the result of the function. ReturnLabel is
29387 the target where we jump.
29390 2001-12-09 Radek Doulik <rodo@ximian.com>
29392 * cs-parser.jay: remember alias in current namespace
29394 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29397 * class.cs (LookupAlias): lookup alias in my_namespace
29399 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29401 (LookupAlias): lookup alias in this and if needed in parent
29404 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29408 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29409 making things static. I need this to avoid passing the
29410 TypeContainer when calling ParameterType.
29412 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29413 that did string manipulation to compute the type and then call
29414 GetType. Use Parameter.ParameterType instead.
29416 * cs-tokenizer.cs: Consume the suffix for floating values.
29418 * expression.cs (ParameterReference): figure out whether this is a
29419 reference parameter or not. Kill an extra variable by computing
29420 the arg_idx during emission.
29422 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29423 function that returns whether a parameter is an out/ref value or not.
29425 (Parameter.ParameterType): The type of the parameter (base,
29426 without ref/out applied).
29428 (Parameter.Resolve): Perform resolution here.
29429 (Parameter.ExternalType): The full type (with ref/out applied).
29431 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29432 support for expressions on the using statement.
29434 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29436 * statement.cs (Using.EmitLocalVariableDecls): Split the
29437 localvariable handling of the using statement.
29439 (Block.EmitMeta): Keep track of variable count across blocks. We
29440 were reusing slots on separate branches of blocks.
29442 (Try.Emit): Emit the general code block, we were not emitting it.
29444 Check the type of the declaration to be an IDisposable or
29445 something that can be implicity converted to it.
29447 Emit conversions if required.
29449 * ecore.cs (EmptyExpression): New utility class.
29450 (Expression.ImplicitConversionExists): New utility function.
29452 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29454 * statement.cs (Using): Implement.
29456 * expression.cs (LocalVariableReference): Support read only variables.
29458 * statement.cs: Remove the explicit emit for the Leave opcode.
29459 (VariableInfo): Add a readonly field.
29461 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29463 * ecore.cs (ConvCast): new class used to encapsulate the various
29464 explicit integer conversions that works in both checked and
29465 unchecked contexts.
29467 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29468 properly generate the overflow opcodes.
29470 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29472 * statement.cs: The correct type for the EmptyExpression is the
29473 element_type, not the variable type. Ravi pointed this out.
29475 2001-12-04 Ravi Pratap <ravi@ximian.com>
29477 * class.cs (Method::Define): Handle PInvoke methods specially
29478 by using DefinePInvokeMethod instead of the usual one.
29480 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29481 above to do the task of extracting information and defining the method.
29483 2001-12-04 Ravi Pratap <ravi@ximian.com>
29485 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29486 of the condition for string type.
29488 (Emit): Move that here.
29490 (ArrayCreation::CheckIndices): Keep string literals in their expression
29493 (EmitDynamicInitializers): Handle strings appropriately.
29495 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29497 * codegen.cs (EmitContext): Replace multiple variables with a
29498 single pointer to the current Switch statement.
29500 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29503 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29507 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29510 (Foreach.Emit): Foreach on arrays was not setting
29511 up the loop variables (for break/continue).
29513 (GotoCase): Semi-implented.
29515 2001-12-03 Ravi Pratap <ravi@ximian.com>
29517 * attribute.cs (CheckAttribute): Handle system attributes by using
29518 Attribute.GetAttributes to examine information we need.
29520 (GetValidPlaces): Same here.
29522 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29524 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29526 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29528 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29530 (Method::Emit): Handle the case when we are a PInvoke method.
29532 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29534 * expression.cs: Use ResolveWithSimpleName on compound names.
29536 2001-12-02 Ravi Pratap <ravi@ximian.com>
29538 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29539 before trying to reduce it.
29541 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29543 * constant.cs (LookupConstantValue): Implement.
29545 (EmitConstant): Use the above in emitting the constant.
29547 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
29548 that are user-defined by doing a LookupConstantValue on them.
29550 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
29553 2001-11-29 Miguel de Icaza <miguel@ximian.com>
29555 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
29557 (BaseAccess.DoResolve): Implement.
29559 (MemberAccess.DoResolve): Split this routine into a
29560 ResolveMemberAccess routine that can be used independently
29562 2001-11-28 Miguel de Icaza <miguel@ximian.com>
29564 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
29565 As that share bits of the implementation. Is returns a boolean,
29566 while As returns the Type that is being probed.
29568 2001-12-01 Ravi Pratap <ravi@ximian.com>
29570 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
29571 instead of a Literal - much easier.
29573 (EnumInTransit): Remove - utterly useless :-)
29575 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
29577 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
29579 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
29580 chain when we have no associated expression.
29582 2001-11-30 Ravi Pratap <ravi@ximian.com>
29584 * constant.cs (Define): Use Location while reporting the errror.
29586 Also emit a warning when 'new' is used and there is no inherited
29589 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
29592 (LookupEnumValue): Implement to lookup an enum member's value and define it
29595 (Populate): Re-write accordingly to use the above routine.
29597 2001-11-27 Miguel de Icaza <miguel@ximian.com>
29599 * expression.cs (This): Fix prototype for DoResolveLValue to
29600 override the base class DoResolveLValue.
29602 * cs-parser.cs: Report errors cs574 and cs575 (destructor
29605 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
29606 (we need to load the address of the field here). This fixes
29609 (FieldExpr.DoResolveLValue): Call the DoResolve
29610 function to initialize the Instance expression.
29612 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
29613 correctly the GetEnumerator operation on a value type.
29615 * cs-parser.jay: Add more simple parsing error catches.
29617 * statement.cs (Switch): Add support for string switches.
29618 Handle null specially.
29620 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
29622 2001-11-28 Ravi Pratap <ravi@ximian.com>
29624 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
29626 (declare_local_constant): New helper function.
29628 * statement.cs (AddConstant): Keep a separate record of constants
29630 (IsConstant): Implement to determine if a variable is a constant.
29632 (GetConstantExpression): Implement.
29634 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
29636 * statement.cs (IsVariableDefined): Re-write.
29638 2001-11-27 Ravi Pratap <ravi@ximian.com>
29640 * class.cs (TypeContainer::FindMembers): Look for constants
29641 in the case when we are looking for MemberTypes.Field
29643 * expression.cs (MemberAccess::DoResolve): Check that in the
29644 case we are a FieldExpr and a Literal, we are not being accessed
29645 by an instance reference.
29647 * cs-parser.jay (local_constant_declaration): Implement.
29649 (declaration_statement): Implement for constant declarations.
29651 2001-11-26 Miguel de Icaza <miguel@ximian.com>
29653 * statement.cs (Switch): Catch double defaults.
29655 (Switch): More work on the switch() statement
29656 implementation. It works for integral values now, need to finish
29660 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29662 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
29663 integer literals into other integer literals. To be used by
29666 2001-11-24 Ravi Pratap <ravi@ximian.com>
29668 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
29671 (EmitDynamicInitializers): Cope with the above since we extract data
29672 directly from ArrayData now.
29674 (ExpectInitializers): Keep track of whether initializers are mandatory
29677 (Bounds): Make it a hashtable to prevent the same dimension being
29678 recorded for every element in that dimension.
29680 (EmitDynamicInitializers): Fix bug which prevented the Set array method
29683 Also fix bug which was causing the indices to be emitted in the reverse
29686 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29688 * expression.cs (ArrayCreation): Implement the bits that Ravi left
29689 unfinished. They do not work, because the underlying code is
29692 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29694 * cs-parser.jay: Remove bogus fixme.
29696 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
29697 on Switch statement.
29699 2001-11-23 Ravi Pratap <ravi@ximian.com>
29701 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
29704 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
29705 parameter. Apparently, any expression is allowed.
29707 (ValidateInitializers): Update accordingly.
29709 (CheckIndices): Fix some tricky bugs thanks to recursion.
29711 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
29712 I was being completely brain-dead.
29714 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
29715 and re-write acordingly.
29717 (DelegateInvocation): Re-write accordingly.
29719 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
29721 (MakeByteBlob): Handle types more correctly.
29723 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
29724 initialization from expressions but it is incomplete because I am a complete
29727 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29729 * statement.cs (If.Emit): Fix a bug that generated incorrect code
29730 on If. Basically, we have to return `true' (ie, we do return to
29731 our caller) only if both branches of the if return.
29733 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
29734 short-circuit operators, handle them as short circuit operators.
29736 (Cast.DoResolve): Resolve type.
29737 (Cast.Cast): Take an expression as the target type.
29739 * cs-parser.jay (cast_expression): Remove old hack that only
29740 allowed a limited set of types to be handled. Now we take a
29741 unary_expression and we resolve to a type during semantic
29744 Use the grammar productions from Rhys to handle casts (this is
29745 not complete like Rhys syntax yet, we fail to handle that corner
29746 case that C# has regarding (-x), but we will get there.
29748 2001-11-22 Ravi Pratap <ravi@ximian.com>
29750 * class.cs (EmitFieldInitializer): Take care of the case when we have a
29751 field which is an array type.
29753 * cs-parser.jay (declare_local_variables): Support array initialization too.
29755 * typemanager.cs (MakeKey): Implement.
29757 (everywhere): Use the above appropriately.
29759 * cs-parser.jay (for_statement): Update for array initialization while
29760 declaring variables.
29762 * ecore.cs : The error message was correct, it's the variable's names that
29763 were misleading ;-) Make the code more readable.
29765 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
29766 the correct type etc.
29768 (ConvertExplicit): Handle Enum types by examining the underlying type.
29770 2001-11-21 Ravi Pratap <ravi@ximian.com>
29772 * parameter.cs (GetCallingConvention): Always return
29773 CallingConventions.Standard for now.
29775 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29777 * expression.cs (Binary.ResolveOperator): Update the values of `l'
29778 and `r' after calling DoNumericPromotions.
29780 * ecore.cs: Fix error message (the types were in the wrong order).
29782 * statement.cs (Foreach.ProbeCollectionType): Need to pass
29783 BindingFlags.Instance as well
29785 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
29786 implicit int literal conversion in an empty cast so that we
29787 propagate the right type upstream.
29789 (UnboxCast): new class used to unbox value types.
29790 (Expression.ConvertExplicit): Add explicit type conversions done
29793 (Expression.ImplicitNumericConversion): Oops, forgot to test for
29794 the target type before applying the implicit LongLiterals to ULong
29797 2001-11-21 Miguel de Icaza <miguel@ximian.com>
29799 * cs-parser.jay (for_statement): Reworked the way For works: now
29800 we declare manually any variables that are introduced in
29801 for_initializer to solve the problem of having out-of-band code
29802 emition (that is what got for broken).
29804 (declaration_statement): Perform the actual variable declaration
29805 that used to be done in local_variable_declaration here.
29807 (local_variable_declaration): Do not declare anything, just pass
29808 the information on a DictionaryEntry
29810 2001-11-20 Ravi Pratap <ravi@ximian.com>
29812 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
29813 re-write of the logic to now make it recursive.
29815 (UpdateIndices): Re-write accordingly.
29817 Store element data in a separate ArrayData list in the above methods.
29819 (MakeByteBlob): Implement to dump the array data into a byte array.
29821 2001-11-19 Ravi Pratap <ravi@ximian.com>
29823 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
29826 * constant.cs (Define): Implement.
29828 (EmitConstant): Re-write fully.
29830 Pass in location info.
29832 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
29835 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
29836 DictionaryEntry since we need location info too.
29838 (constant_declaration): Update accordingly.
29840 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
29841 code into another method : UpdateIndices.
29843 2001-11-18 Ravi Pratap <ravi@ximian.com>
29845 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
29846 some type checking etc.
29848 2001-11-17 Ravi Pratap <ravi@ximian.com>
29850 * expression.cs (ArrayCreation::ValidateInitializers): Implement
29851 bits to provide dimension info if the user skips doing that.
29853 Update second constructor to store the rank correctly.
29855 2001-11-16 Ravi Pratap <ravi@ximian.com>
29857 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
29858 and try to implement.
29860 * ../errors/cs0150.cs : Add.
29862 * ../errors/cs0178.cs : Add.
29864 2001-11-16 Miguel de Icaza <miguel@ximian.com>
29866 * statement.cs: Implement foreach on multi-dimensional arrays.
29868 * parameter.cs (Parameters.GetParameterByName): Also lookup the
29869 name of the params argument.
29871 * expression.cs: Use EmitStoreOpcode to get the right opcode while
29872 initializing the array.
29874 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
29875 we can use this elsewhere.
29877 * statement.cs: Finish implementation of foreach for single
29880 * cs-parser.jay: Use an out-of-band stack to pass information
29881 around, I wonder why I need this.
29883 foreach_block: Make the new foreach_block the current_block.
29885 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
29886 function used to return a static Parameters structure. Used for
29887 empty parameters, as those are created very frequently.
29889 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
29891 2001-11-15 Ravi Pratap <ravi@ximian.com>
29893 * interface.cs : Default modifier is private, not public. The
29894 make verify test passes again.
29896 2001-11-15 Ravi Pratap <ravi@ximian.com>
29898 * support.cs (ReflectionParameters): Fix logic to determine
29899 whether the last parameter is a params one. Test 9 passes again.
29901 * delegate.cs (Populate): Register the builders we define with
29902 RegisterParameterForBuilder. Test 19 passes again.
29904 * cs-parser.jay (property_declaration): Reference $6 instead
29905 of $$ to get at the location.
29907 (indexer_declaration): Similar stuff.
29909 (attribute): Ditto.
29911 * class.cs (Property): Register parameters for the Get and Set methods
29912 if they exist. Test 23 passes again.
29914 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
29915 call to EmitArguments as we are sure there aren't any params arguments.
29916 Test 32 passes again.
29918 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
29919 IndexOutOfRangeException.
29921 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
29922 Test 33 now passes again.
29924 2001-11-15 Miguel de Icaza <miguel@ximian.com>
29926 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
29927 broke a bunch of things. Will have to come up with a better way
29928 of tracking locations.
29930 * statement.cs: Implemented foreach for single dimension arrays.
29932 2001-11-09 Miguel de Icaza <miguel@ximian.com>
29934 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
29935 an error. This removes the lookup from the critical path.
29937 * cs-parser.jay: Removed use of temporary_loc, which is completely
29940 2001-11-14 Miguel de Icaza <miguel@ximian.com>
29942 * support.cs (ReflectionParameters.ParameterModifier): Report
29943 whether the argument is a PARAMS argument or not.
29945 * class.cs: Set the attribute `ParamArrayAttribute' on the
29946 parameter argument.
29948 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
29949 and cons_param_array_attribute (ConstructorInfo for
29950 ParamArrayAttribute).,
29952 * codegen.cs: Emit the return using the `Return' statement, that
29953 way we can report the error correctly for missing return values.
29955 * class.cs (Method.Emit): Clean up.
29957 * expression.cs (Argument.Resolve): Take another argument: the
29958 location where this argument is used. Notice that this is not
29959 part of the "Argument" class as to reduce the size of the
29960 structure (we know the approximate location anyways).
29962 Test if the argument is a variable-reference, if not, then
29963 complain with a 206.
29965 (Argument.Emit): Emit addresses of variables.
29967 (Argument.FullDesc): Simplify.
29969 (Invocation.DoResolve): Update for Argument.Resolve.
29971 (ElementAccess.DoResolve): ditto.
29973 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
29974 method should be virtual, as this method is always virtual.
29976 (NewDelegate.DoResolve): Update for Argument.Resolve.
29978 * class.cs (ConstructorInitializer.DoResolve): ditto.
29980 * attribute.cs (Attribute.Resolve): ditto.
29982 2001-11-13 Miguel de Icaza <miguel@ximian.com>
29984 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
29986 * expression.cs (ParameterReference): Drop IStackStorage and implement
29987 IAssignMethod instead.
29989 (LocalVariableReference): ditto.
29991 * ecore.cs (FieldExpr): Drop IStackStorage and implement
29992 IAssignMethod instead.
29994 2001-11-13 Miguel de Icaza <miguel@ximian.com>
29996 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
29997 enumerations that are used in heavily used structures derive from
29998 byte in a laughable and pathetic attempt to reduce memory usage.
29999 This is the kind of pre-optimzations that you should not do at
30000 home without adult supervision.
30002 * expression.cs (UnaryMutator): New class, used to handle ++ and
30003 -- separatedly from the other unary operators. Cleans up the
30004 code, and kills the ExpressionStatement dependency in Unary.
30006 (Unary): Removed `method' and `Arguments' from this class, making
30007 it smaller, and moving it all to SimpleCall, so I can reuse this
30008 code in other locations and avoid creating a lot of transient data
30009 strucutres when not required.
30011 * cs-parser.jay: Adjust for new changes.
30013 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30015 * enum.cs (Enum.Populate): If there is a failure during
30018 * cs-parser.jay (opt_enum_base): we used to catch type errors
30019 here, but this is really incorrect. The type error should be
30020 catched during semantic analysis.
30022 2001-12-11 Ravi Pratap <ravi@ximian.com>
30024 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30025 current_local_parameters as expected since I, in my stupidity, had forgotten
30028 * attribute.cs (GetValidPlaces): Fix stupid bug.
30030 * class.cs (Method::Emit): Perform check on applicability of attributes.
30032 (Constructor::Emit): Ditto.
30034 (Field::Emit): Ditto.
30036 (Field.Location): Store location information.
30038 (Property, Event, Indexer, Operator): Ditto.
30040 * cs-parser.jay (field_declaration): Pass in location for each field.
30042 * ../errors/cs0592.cs : Add.
30044 2001-11-12 Ravi Pratap <ravi@ximian.com>
30046 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30048 (InitCoreTypes): Update accordingly.
30050 (RegisterAttrType, LookupAttr): Implement.
30052 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30053 info about the same.
30055 (Resolve): Update to populate the above as necessary.
30057 (Error592): Helper.
30059 (GetValidPlaces): Helper to the above.
30061 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30063 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30065 2001-11-12 Ravi Pratap <ravi@ximian.com>
30067 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30069 * ../errors/cs0617.cs : Add.
30071 2001-11-11 Ravi Pratap <ravi@ximian.com>
30073 * enum.cs (Emit): Rename to Populate to be more consistent with what
30074 we expect it to do and when exactly it is called.
30076 * class.cs, rootcontext.cs : Update accordingly.
30078 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30079 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30081 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30083 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30084 of a fieldinfo using the above, when dealing with a FieldBuilder.
30086 2001-11-10 Ravi Pratap <ravi@ximian.com>
30088 * ../errors/cs0031.cs : Add.
30090 * ../errors/cs1008.cs : Add.
30092 * ../errrors/cs0543.cs : Add.
30094 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30097 (FindMembers): Implement.
30099 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30100 enums and delegates too.
30102 (enum_types): Rename to builder_to_enum.
30104 (delegate_types): Rename to builder_to_delegate.
30106 * delegate.cs (FindMembers): Implement.
30108 2001-11-09 Ravi Pratap <ravi@ximian.com>
30110 * typemanager.cs (IsEnumType): Implement.
30112 * enum.cs (Emit): Re-write parts to account for the underlying type
30113 better and perform checking etc.
30115 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30116 of the underlying type.
30118 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30121 * enum.cs (error31): Helper to report error #31.
30123 * cs-parser.jay (enum_declaration): Store location of each member too.
30125 * enum.cs (member_to_location): New hashtable.
30127 (AddEnumMember): Update location hashtable.
30129 (Emit): Use the location of each member while reporting errors.
30131 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30133 * cs-parser.jay: A for_initializer if is a
30134 local_variable_declaration really ammount to have an implicit
30135 block with the variable declaration and no initializer for for.
30137 * statement.cs (For.Emit): Cope with null initializers.
30139 This fixes the infinite loop on for initializers.
30141 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30143 * enum.cs: More cleanup.
30145 * ecore.cs: Remove dead code.
30147 * class.cs (Property.Emit): More simplification.
30148 (Event.Emit): ditto.
30150 Reworked to have less levels of indentation.
30152 2001-11-08 Ravi Pratap <ravi@ximian.com>
30154 * class.cs (Property): Emit attributes.
30164 * enum.cs (Emit): Ditto.
30166 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30169 * class.cs (Field, Event, etc.): Move attribute generation into the
30170 Emit method everywhere.
30172 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30173 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30174 as we had no way of defining nested enums !
30176 * rootcontext.cs : Adjust code accordingly.
30178 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30180 2001-11-07 Ravi Pratap <ravi@ximian.com>
30182 * expression.cs (EvalConstantExpression): Move into ecore.cs
30184 * enum.cs (Enum): Rename some members and make them public and readonly
30185 according to our convention.
30187 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30190 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30192 (Enum::Emit): Write a simple version for now which doesn't try to compute
30193 expressions. I shall modify this to be more robust in just a while.
30195 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30197 (TypeContainer::CloseType): Create the Enum types too.
30199 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30201 * expression.cs (EvalConstantExpression): Get rid of completely.
30203 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30204 user-defined values and other cases.
30206 (IsValidEnumLiteral): Helper function.
30208 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30209 out there in the case we had a literal FieldExpr.
30211 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30213 (Literalize): Revamp a bit to take two arguments.
30215 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30217 2001-11-06 Ravi Pratap <ravi@ximian.com>
30219 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30221 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30223 (Resolve): Use the above to ensure we have proper initializers.
30225 2001-11-05 Ravi Pratap <ravi@ximian.com>
30227 * expression.cs (Expression::EvalConstantExpression): New method to
30228 evaluate constant expressions.
30230 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30232 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30234 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30237 (Binary.ResolveOperator): Handle operator != (object a, object b)
30238 and operator == (object a, object b);
30240 (Binary.DoNumericPromotions): Indicate whether the numeric
30241 promotion was possible.
30243 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30246 Made the ArrayAccess implement interface IAssignMethod instead of
30247 IStackStore as the order in which arguments are passed reflects
30250 * assign.cs: Instead of using expr.ExprClass to select the way of
30251 assinging, probe for the IStackStore/IAssignMethod interfaces.
30253 * typemanager.cs: Load InitializeArray definition.
30255 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30256 static data that can be used to initialize arrays.
30258 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30260 * expression.cs: Handle operator== and operator!= for booleans.
30262 (Conditioal.Reduce): Implement reducer for the ?: operator.
30264 (Conditional.Resolve): Implement dead code elimination.
30266 (Binary.Resolve): Catch string literals and return a new
30267 concatenated string.
30269 (Unary.Reduce): Implement reduction of unary expressions.
30271 * ecore.cs: Split out the expression core handling here.
30273 (Expression.Reduce): New method used to perform constant folding
30274 and CSE. This is needed to support constant-expressions.
30276 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30277 targets, and optimize for !x.
30279 2001-11-04 Ravi Pratap <ravi@ximian.com>
30281 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30282 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30283 set custom atttributes.
30285 * literal.cs (Literal::GetValue): New abstract method to return the actual
30286 value of the literal, cast as an object.
30288 (*Literal): Implement GetValue method.
30290 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30291 expressions to the arraylist but objects of type Argument.
30293 * class.cs (TypeContainer::Emit): Emit our attributes too.
30295 (Method::Emit, Constructor::Emit): Ditto.
30297 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30298 to be ignoring earlier.
30300 2001-11-03 Ravi Pratap <ravi@ximian.com>
30302 * attribute.cs (AttributeSection::Define): Implement to do the business
30303 of constructing a CustomAttributeBuilder.
30305 (Attribute): New trivial class. Increases readability of code.
30307 * cs-parser.jay : Update accordingly.
30309 (positional_argument_list, named_argument_list, named_argument): New rules
30311 (attribute_arguments): Use the above so that we are more correct.
30313 2001-11-02 Ravi Pratap <ravi@ximian.com>
30315 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30316 to perform all checks for a method with a params parameter.
30318 (Invocation::OverloadResolve): Update to use the above method and therefore
30319 cope correctly with params method invocations.
30321 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30324 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30325 constructors in our parent too because we can't afford to miss out on
30328 * attribute.cs (AttributeSection): New name for the class Attribute
30330 Other trivial changes to improve readability.
30332 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30333 use the new class names.
30335 2001-11-01 Ravi Pratap <ravi@ximian.com>
30337 * class.cs (Method::Define): Complete definition for params types too
30339 (Indexer::Define): Ditto.
30341 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30342 Cope everywhere with a request for info about the array parameter.
30344 2001-11-01 Ravi Pratap <ravi@ximian.com>
30346 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30348 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30349 local_variable_type to extract the string corresponding to the type.
30351 (local_variable_type): Fixup the action to use the new helper method.
30353 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30356 * expression.cs : Clean out code which uses the above.
30358 2001-10-31 Ravi Pratap <ravi@ximian.com>
30360 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30361 and bale out if necessary by returning a false.
30363 (RegisterProperty): Ditto.
30365 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30366 and print out appropriate error messages.
30368 * interface.cs (everywhere): Ditto.
30370 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30371 location to constructor.
30373 * class.cs (Property, Event, Indexer): Update accordingly.
30375 * ../errors/cs111.cs : Added.
30377 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30378 of a method, as laid down by the spec.
30380 (Invocation::OverloadResolve): Use the above method.
30382 2001-10-31 Ravi Pratap <ravi@ximian.com>
30384 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30385 now take a TypeContainer and a Parameters object.
30387 (ParameterData): Modify return type of ParameterModifier method to be
30388 Parameter.Modifier and not a string.
30390 (ReflectionParameters, InternalParameters): Update accordingly.
30392 * expression.cs (Argument::GetParameterModifier): Same here.
30394 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30395 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30396 symbol in it at all so maybe this is only for now.
30398 2001-10-30 Ravi Pratap <ravi@ximian.com>
30400 * support.cs (InternalParameters): Constructor now takes an extra argument
30401 which is the actual Parameters class.
30403 (ParameterDesc): Update to provide info on ref/out modifiers.
30405 * class.cs (everywhere): Update call to InternalParameters to pass in
30406 the second argument too.
30408 * support.cs (ParameterData): Add ParameterModifier, which is a method
30409 to return the modifier info [ref/out etc]
30411 (InternalParameters, ReflectionParameters): Implement the above.
30413 * expression.cs (Argument::ParameterModifier): Similar function to return
30414 info about the argument's modifiers.
30416 (Invocation::OverloadResolve): Update to take into account matching modifiers
30419 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30420 a new SetFormalParameters object which we pass to InternalParameters.
30422 2001-10-30 Ravi Pratap <ravi@ximian.com>
30424 * expression.cs (NewArray): Merge into the ArrayCreation class.
30426 2001-10-29 Ravi Pratap <ravi@ximian.com>
30428 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30429 NewUserdefinedArray into one as there wasn't much of a use in having
30432 * expression.cs (Argument): Change field's name to ArgType from Type.
30434 (Type): New readonly property which returns the proper type, taking into
30435 account ref/out modifiers.
30437 (everywhere): Adjust code accordingly for the above.
30439 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30440 whether we are emitting for a ref or out parameter.
30442 * expression.cs (Argument::Emit): Use the above field to set the state.
30444 (LocalVariableReference::Emit): Update to honour the flag and emit the
30447 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30449 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30451 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30453 (ReflectionParameters, InternalParameters): Implement the above method.
30455 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30458 (Invocation::FullMethodDesc): Ditto.
30460 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30462 * cs-parser.jay: Add extra production for the second form of array
30465 * expression.cs (ArrayCreation): Update to reflect the above
30468 * Small changes to prepare for Array initialization.
30470 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30472 * typemanager.cs (ImplementsInterface): interface might be null;
30473 Deal with this problem;
30475 Also, we do store negative hits on the cache (null values), so use
30476 this instead of calling t.GetInterfaces on the type everytime.
30478 2001-10-28 Ravi Pratap <ravi@ximian.com>
30480 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30482 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30483 split functionality out into different classes.
30485 (New::FormArrayType): Move into NewBuiltinArray.
30487 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30490 (NewBuiltinArray): New class to handle creation of built-in arrays.
30492 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30493 account creation of one-dimensional arrays.
30495 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30497 (NewUserdefinedArray::DoResolve): Implement.
30499 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30501 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30502 we maintain inside the TypeManager. This is necessary to perform lookups on the
30505 (LookupType): Update to perform GetType on the module builders too.
30507 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30509 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30511 2001-10-23 Ravi Pratap <ravi@ximian.com>
30513 * expression.cs (New::DoResolve): Implement guts of array creation.
30515 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30517 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30519 * expression.cs: Fix bug I introduced lsat night that broke
30522 (Expression.Resolve): Report a 246 error (can not resolve name)
30523 if we find a SimpleName in the stream.
30525 (Expression.ResolveLValue): Ditto.
30527 (Expression.ResolveWithSimpleName): This function is a variant of
30528 ResolveName, this one allows SimpleNames to be returned without a
30529 warning. The only consumer of SimpleNames is MemberAccess
30531 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30533 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30534 might arrive here. I have my doubts that this is correct.
30536 * statement.cs (Lock): Implement lock statement.
30538 * cs-parser.jay: Small fixes to support `lock' and `using'
30540 * cs-tokenizer.cs: Remove extra space
30542 * driver.cs: New flag --checked, allows to turn on integer math
30545 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30546 Threading.Monitor.Exit
30548 2001-10-23 Miguel de Icaza <miguel@ximian.com>
30550 * expression.cs (IndexerAccess::DoResolveLValue): Set the
30551 Expression Class to be IndexerAccess.
30553 Notice that Indexer::DoResolve sets the eclass to Value.
30555 2001-10-22 Miguel de Icaza <miguel@ximian.com>
30557 * class.cs (TypeContainer::Emit): Emit code for indexers.
30559 * assign.cs (IAssignMethod): New interface implemented by Indexers
30560 and Properties for handling assignment.
30562 (Assign::Emit): Simplify and reuse code.
30564 * expression.cs (IndexerAccess, PropertyExpr): Implement
30565 IAssignMethod, clean up old code.
30567 2001-10-22 Ravi Pratap <ravi@ximian.com>
30569 * typemanager.cs (ImplementsInterface): New method to determine if a type
30570 implements a given interface. Provides a nice cache too.
30572 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
30575 (ConvertReferenceExplicit): Ditto.
30577 * delegate.cs (Delegate::Populate): Update to define the parameters on the
30578 various methods, with correct names etc.
30580 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
30581 Operator.UnaryNegation.
30583 * cs-parser.jay (operator_declarator): Be a little clever in the case where
30584 we have a unary plus or minus operator.
30586 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
30589 * everywhere : update accordingly.
30591 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
30594 * class.cs (Method::Define): For the case where we are implementing a method
30595 inherited from an interface, we need to set the MethodAttributes.Final flag too.
30596 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
30598 2001-10-21 Ravi Pratap <ravi@ximian.com>
30600 * interface.cs (FindMembers): Implement to work around S.R.E
30603 * typemanager.cs (IsInterfaceType): Implement.
30605 (FindMembers): Update to handle interface types too.
30607 * expression.cs (ImplicitReferenceConversion): Re-write bits which
30608 use IsAssignableFrom as that is not correct - it doesn't work.
30610 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
30611 and accordingly override EmitStatement.
30613 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
30614 using the correct logic :-)
30616 2001-10-19 Ravi Pratap <ravi@ximian.com>
30618 * ../errors/cs-11.cs : Add to demonstrate error -11
30620 2001-10-17 Miguel de Icaza <miguel@ximian.com>
30622 * assign.cs (Assign::Resolve): Resolve right hand side first, and
30623 then pass this as a hint to ResolveLValue.
30625 * expression.cs (FieldExpr): Add Location information
30627 (FieldExpr::LValueResolve): Report assignment to readonly
30630 (Expression::ExprClassFromMemberInfo): Pass location information.
30632 (Expression::ResolveLValue): Add new method that resolves an
30635 (Expression::DoResolveLValue): Default invocation calls
30638 (Indexers): New class used to keep track of indexers in a given
30641 (IStackStore): Renamed from LValue, as it did not really describe
30642 what this did. Also ResolveLValue is gone from this interface and
30643 now is part of Expression.
30645 (ElementAccess): Depending on the element access type
30647 * typemanager.cs: Add `indexer_name_type' as a Core type
30648 (System.Runtime.CompilerServices.IndexerNameAttribute)
30650 * statement.cs (Goto): Take a location.
30652 2001-10-18 Ravi Pratap <ravi@ximian.com>
30654 * delegate.cs (Delegate::VerifyDelegate): New method to verify
30655 if two delegates are compatible.
30657 (NewDelegate::DoResolve): Update to take care of the case when
30658 we instantiate a delegate from another delegate.
30660 * typemanager.cs (FindMembers): Don't even try to look up members
30661 of Delegate types for now.
30663 2001-10-18 Ravi Pratap <ravi@ximian.com>
30665 * delegate.cs (NewDelegate): New class to take care of delegate
30668 * expression.cs (New): Split the delegate related code out into
30669 the NewDelegate class.
30671 * delegate.cs (DelegateInvocation): New class to handle delegate
30674 * expression.cs (Invocation): Split out delegate related code into
30675 the DelegateInvocation class.
30677 2001-10-17 Ravi Pratap <ravi@ximian.com>
30679 * expression.cs (New::DoResolve): Implement delegate creation fully
30680 and according to the spec.
30682 (New::DoEmit): Update to handle delegates differently.
30684 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
30685 because of which we were printing out arguments in reverse order !
30687 * delegate.cs (VerifyMethod): Implement to check if the given method
30688 matches the delegate.
30690 (FullDelegateDesc): Implement.
30692 (VerifyApplicability): Implement.
30694 * expression.cs (Invocation::DoResolve): Update to accordingly handle
30695 delegate invocations too.
30697 (Invocation::Emit): Ditto.
30699 * ../errors/cs1593.cs : Added.
30701 * ../errors/cs1594.cs : Added.
30703 * delegate.cs (InstanceExpression, TargetMethod): New properties.
30705 2001-10-16 Ravi Pratap <ravi@ximian.com>
30707 * typemanager.cs (intptr_type): Core type for System.IntPtr
30709 (InitCoreTypes): Update for the same.
30711 (iasyncresult_type, asynccallback_type): Ditto.
30713 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
30716 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
30719 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
30720 the builders for the 4 members of a delegate type :-)
30722 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
30725 * expression.cs (New::DoResolve): Implement guts for delegate creation.
30727 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
30729 2001-10-15 Miguel de Icaza <miguel@ximian.com>
30731 * statement.cs (Break::Emit): Implement.
30732 (Continue::Emit): Implement.
30734 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
30735 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
30736 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
30737 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
30740 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
30741 properties that track the label for the current loop (begin of the
30742 loop and end of the loop).
30744 2001-10-15 Ravi Pratap <ravi@ximian.com>
30746 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
30747 use of emitting anything at all.
30749 * class.cs, rootcontext.cs : Get rid of calls to the same.
30751 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
30753 (Populate): Define the constructor correctly and set the implementation
30756 * typemanager.cs (delegate_types): New hashtable to hold delegates that
30759 (AddDelegateType): Implement.
30761 (IsDelegateType): Implement helper method.
30763 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
30765 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
30766 and accordingly handle it.
30768 * delegate.cs (Populate): Take TypeContainer argument.
30769 Implement bits to define the Invoke method. However, I still haven't figured out
30770 how to take care of the native int bit :-(
30772 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
30773 Qualify the name of the delegate, not its return type !
30775 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
30778 (StandardConversionExists): Checking for array types turns out to be recursive.
30780 (ConvertReferenceExplicit): Implement array conversion.
30782 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
30784 2001-10-12 Ravi Pratap <ravi@ximian.com>
30786 * cs-parser.jay (delegate_declaration): Store the fully qualified
30787 name as it is a type declaration.
30789 * delegate.cs (ReturnType, Name): Rename members to these. Make them
30792 (DefineDelegate): Renamed from Define. Does the same thing essentially,
30793 as TypeContainer::DefineType.
30795 (Populate): Method in which all the definition of the various methods (Invoke)
30798 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
30801 (CloseDelegate): Finally creates the delegate.
30803 * class.cs (TypeContainer::DefineType): Update to define delegates.
30804 (Populate, Emit and CloseType): Do the same thing here too.
30806 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
30807 delegates in all these operations.
30809 2001-10-14 Miguel de Icaza <miguel@ximian.com>
30811 * expression.cs: LocalTemporary: a new expression used to
30812 reference a temporary that has been created.
30814 * assign.cs: Handle PropertyAccess back here, so that we can
30815 provide the proper semantic access to properties.
30817 * expression.cs (Expression::ConvertReferenceExplicit): Implement
30818 a few more explicit conversions.
30820 * modifiers.cs: `NEW' modifier maps to HideBySig.
30822 * expression.cs (PropertyExpr): Make this into an
30823 ExpressionStatement, and support the EmitStatement code path.
30825 Perform get/set error checking, clean up the interface.
30827 * assign.cs: recognize PropertyExprs as targets, and if so, turn
30828 them into toplevel access objects.
30830 2001-10-12 Miguel de Icaza <miguel@ximian.com>
30832 * expression.cs: PropertyExpr::PropertyExpr: use work around the
30835 * typemanager.cs: Keep track here of our PropertyBuilders again to
30836 work around lameness in SRE.
30838 2001-10-11 Miguel de Icaza <miguel@ximian.com>
30840 * expression.cs (LValue::LValueResolve): New method in the
30841 interface, used to perform a second resolution pass for LValues.
30843 (This::DoResolve): Catch the use of this in static methods.
30845 (This::LValueResolve): Implement.
30847 (This::Store): Remove warning, assigning to `this' in structures
30850 (Invocation::Emit): Deal with invocation of
30851 methods on value types. We need to pass the address to structure
30852 methods rather than the object itself. (The equivalent code to
30853 emit "this" for structures leaves the entire structure on the
30854 stack instead of a pointer to it).
30856 (ParameterReference::DoResolve): Compute the real index for the
30857 argument based on whether the method takes or not a `this' pointer
30858 (ie, the method is static).
30860 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
30861 value types returned from functions when we need to invoke a
30862 method on the sturcture.
30865 2001-10-11 Ravi Pratap <ravi@ximian.com>
30867 * class.cs (TypeContainer::DefineType): Method to actually do the business of
30868 defining the type in the Modulebuilder or Typebuilder. This is to take
30869 care of nested types which need to be defined on the TypeBuilder using
30870 DefineNestedMethod.
30872 (TypeContainer::GetClassBases): Implement. Essentially the code from the
30873 methods in RootContext, only ported to be part of TypeContainer.
30875 (TypeContainer::GetInterfaceOrClass): Ditto.
30877 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
30879 * interface.cs (Interface::DefineInterface): New method. Does exactly
30880 what RootContext.CreateInterface did earlier, only it takes care of nested types
30883 (Interface::GetInterfaces): Move from RootContext here and port.
30885 (Interface::GetInterfaceByName): Same here.
30887 * rootcontext.cs (ResolveTree): Re-write.
30889 (PopulateTypes): Re-write.
30891 * class.cs (TypeContainer::Populate): Populate nested types too.
30892 (TypeContainer::Emit): Emit nested members too.
30894 * typemanager.cs (AddUserType): Do not make use of the FullName property,
30895 instead just use the name argument passed in as it is already fully
30898 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
30899 to TypeContainer mapping to see if a type is user-defined.
30901 * class.cs (TypeContainer::CloseType): Implement.
30903 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
30904 the default constructor.
30906 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
30909 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
30911 * interface.cs (CloseType): Create the type here.
30913 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
30916 Remove all the methods which are now in TypeContainer.
30918 2001-10-10 Ravi Pratap <ravi@ximian.com>
30920 * delegate.cs (Define): Re-write bits to define the delegate
30923 2001-10-10 Miguel de Icaza <miguel@ximian.com>
30925 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
30927 * expression.cs (ImplicitReferenceConversion): handle null as well
30928 as a source to convert to any reference type.
30930 * statement.cs (Return): Perform any implicit conversions to
30931 expected return type.
30933 Validate use of return statement.
30935 * codegen.cs (EmitContext): Pass the expected return type here.
30937 * class.cs (Method, Constructor, Property): Pass expected return
30938 type to EmitContext.
30940 2001-10-09 Miguel de Icaza <miguel@ximian.com>
30942 * expression.cs: Make DoResolve take an EmitContext instead of a
30945 Replaced `l' and `location' for `loc', for consistency.
30947 (Error, Warning): Remove unneeded Tc argument.
30949 * assign.cs, literal.cs, constant.cs: Update to new calling
30952 * codegen.cs: EmitContext now contains a flag indicating whether
30953 code is being generated in a static method or not.
30955 * cs-parser.jay: DecomposeQI, new function that replaces the old
30956 QualifiedIdentifier. Now we always decompose the assembled
30957 strings from qualified_identifier productions into a group of
30960 2001-10-08 Miguel de Icaza <miguel@ximian.com>
30962 * rootcontext.cs: Deal with field-less struct types correctly now
30963 by passing the size option to Define Type.
30965 * class.cs: Removed hack that created one static field.
30967 2001-10-07 Miguel de Icaza <miguel@ximian.com>
30969 * statement.cs: Moved most of the code generation here.
30971 2001-10-09 Ravi Pratap <ravi@ximian.com>
30973 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
30976 (ElementAccess): Remove useless bits for now - keep checks as the spec
30979 2001-10-08 Ravi Pratap <ravi@ximian.com>
30981 * expression.cs (ElementAccess::DoResolve): Remove my crap code
30982 and start performing checks according to the spec.
30984 2001-10-07 Ravi Pratap <ravi@ximian.com>
30986 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
30987 rank_specifiers instead.
30989 (rank_specifiers): Change the order in which the rank specifiers are stored
30991 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
30993 * expression.cs (ElementAccess): Implement the LValue interface too.
30995 2001-10-06 Ravi Pratap <ravi@ximian.com>
30997 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
30998 except that user defined conversions are not included.
31000 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31001 perform the conversion of the return type, if necessary.
31003 (New::DoResolve): Check whether we are creating an array or an object
31004 and accordingly do the needful.
31006 (New::Emit): Same here.
31008 (New::DoResolve): Implement guts of array creation.
31010 (New::FormLookupType): Helper function.
31012 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31014 * codegen.cs: Removed most of the code generation here, and move the
31015 corresponding code generation bits to the statement classes.
31017 Added support for try/catch/finalize and throw.
31019 * cs-parser.jay: Added support for try/catch/finalize.
31021 * class.cs: Catch static methods having the flags override,
31022 virtual or abstract.
31024 * expression.cs (UserCast): This user cast was not really doing
31025 what it was supposed to do. Which is to be born in fully resolved
31026 state. Parts of the resolution were being performed at Emit time!
31030 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31032 * expression.cs: Implicity convert the result from UserCast.
31034 2001-10-05 Ravi Pratap <ravi@ximian.com>
31036 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31037 prevented it from working correctly.
31039 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31040 merely ConvertImplicit.
31042 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31044 * typemanager.cs: Make the LookupTypeContainer function static,
31045 and not per-instance.
31047 * class.cs: Make static FindMembers (the one that takes a Type
31050 * codegen.cs: Add EmitForeach here.
31052 * cs-parser.jay: Make foreach a toplevel object instead of the
31053 inline expansion, as we need to perform semantic analysis on it.
31055 2001-10-05 Ravi Pratap <ravi@ximian.com>
31057 * expression.cs (Expression::ImplicitUserConversion): Rename to
31058 UserDefinedConversion.
31060 (Expression::UserDefinedConversion): Take an extra argument specifying
31061 whether we look for explicit user conversions too.
31063 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31065 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31067 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31068 with the appropriate arguments.
31070 * cs-parser.jay (cast_expression): Record location too.
31072 * expression.cs (Cast): Record location info.
31074 (Expression::ConvertExplicit): Take location argument.
31076 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31077 to determine if we are doing explicit conversions.
31079 (UserCast::Emit): Update accordingly.
31081 (Expression::ConvertExplicit): Report an error if everything fails.
31083 * ../errors/cs0030.cs : Add.
31085 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31087 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31088 virtual and newslot bits.
31090 * class.cs (TypeContainer::RegisterRequiredImplementations):
31091 Record methods we need.
31093 (TypeContainer::MakeKey): Helper function to make keys for
31094 MethodBases, since the Methodbase key is useless.
31096 (TypeContainer::Populate): Call RegisterRequiredImplementations
31097 before defining the methods.
31099 Create a mapping for method_builders_to_methods ahead of time
31100 instead of inside a tight loop.
31102 (::RequireMethods): Accept an object as the data to set into the
31103 hashtable so we can report interface vs abstract method mismatch.
31105 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31107 * report.cs: Make all of it static.
31109 * rootcontext.cs: Drop object_type and value_type computations, as
31110 we have those in the TypeManager anyways.
31112 Drop report instance variable too, now it is a global.
31114 * driver.cs: Use try/catch on command line handling.
31116 Add --probe option to debug the error reporting system with a test
31119 * report.cs: Add support for exiting program when a probe
31120 condition is reached.
31122 2001-10-03 Ravi Pratap <ravi@ximian.com>
31124 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31125 we do a forcible conversion regardless of type, to check if
31126 ForceConversion returns a null.
31128 (Binary::error19): Use location to report error.
31130 (Unary::error23): Use location here too.
31132 * ../errors/cs0019.cs : Check in.
31134 * ../errors/cs0023.cs : Check in.
31136 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31137 case of a non-null MethodInfo object with a length of 0 !
31139 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31140 an applicable member - according to the spec :-)
31141 Also fix logic to find members in base types.
31143 (Unary::ResolveOperator): Same here.
31145 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31146 as I was getting thoroughly confused between this and error19 :-)
31148 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31149 (::FindMostEncompassedType): Implement.
31150 (::FindMostEncompassingType): Implement.
31151 (::StandardConversionExists): Implement.
31153 (UserImplicitCast): Re-vamp. We now need info about most specific
31154 source and target types so that we can do the necessary conversions.
31156 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31157 mathematical union with no duplicates.
31159 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31161 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31162 in order from base classes to child classes, so that we can in
31163 child classes look up in our parent for method names and
31164 attributes (required for handling abstract, virtual, new, override
31165 constructs: we need to instrospect our base class, and if we dont
31166 populate the classes in order, the introspection might be
31167 incorrect. For example, a method could query its parent before
31168 the parent has any methods and would determine that the parent has
31169 no abstract methods (while it could have had them)).
31171 (RootContext::CreateType): Record the order in which we define the
31174 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31176 * class.cs (TypeContainer::Populate): Also method definitions can
31177 fail now, keep track of this.
31179 (TypeContainer::FindMembers): Implement support for
31180 DeclaredOnly/noDeclaredOnly flag.
31182 (Constructor::Emit) Return the ConstructorBuilder.
31184 (Method::Emit) Return the MethodBuilder.
31185 Check for abstract or virtual methods to be public.
31187 * rootcontext.cs (RootContext::CreateType): Register all the
31188 abstract methods required for the class to be complete and the
31189 interface methods that must be implemented.
31191 * cs-parser.jay: Report error 501 (method requires body if it is
31192 not marked abstract or extern).
31194 * expression.cs (TypeOf::Emit): Implement.
31196 * typemanager.cs: runtime_handle_type, new global type.
31198 * class.cs (Property::Emit): Generate code for properties.
31200 2001-10-02 Ravi Pratap <ravi@ximian.com>
31202 * expression.cs (Unary::ResolveOperator): Find operators on base type
31203 too - we now conform exactly to the spec.
31205 (Binary::ResolveOperator): Same here.
31207 * class.cs (Operator::Define): Fix minor quirk in the tests.
31209 * ../errors/cs0215.cs : Added.
31211 * ../errors/cs0556.cs : Added.
31213 * ../errors/cs0555.cs : Added.
31215 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31217 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31218 single integer which is really efficient
31220 2001-10-01 Ravi Pratap <ravi@ximian.com>
31222 * expression.cs (Expression::ImplicitUserConversion): Use location
31223 even in the case when we are examining True operators.
31225 * class.cs (Operator::Define): Perform extensive checks to conform
31226 with the rules for operator overloading in the spec.
31228 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31229 some of the other conversions mentioned in the spec.
31231 * typemanager.cs (array_type): New static member for the System.Array built-in
31234 (cloneable_interface): For System.ICloneable interface.
31236 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31237 we start resolving the tree and populating types.
31239 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31241 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31243 * expression.cs (Expression::ExprClassFromMemberInfo,
31244 Expression::Literalize): Create literal expressions from
31245 FieldInfos which are literals.
31247 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31248 type casts, because they were wrong. The test suite in tests
31251 (ImplicitNumericConversion): ushort to ulong requires a widening
31254 Int32 constant to long requires widening cast as well.
31256 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31257 for integers because the type on the stack is not i4.
31259 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31261 * expression.cs (report118): require location argument.
31263 * parameter.cs: Do not dereference potential null value.
31265 * class.cs: Catch methods that lack the `new' keyword when
31266 overriding a name. Report warnings when `new' is used without
31267 anything being there to override.
31269 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31271 * class.cs: Only add constructor to hashtable if it is non-null
31272 (as now constructors can fail on define).
31274 (TypeManager, Class, Struct): Take location arguments.
31276 Catch field instance initialization in structs as errors.
31278 accepting_filter: a new filter for FindMembers that is static so
31279 that we dont create an instance per invocation.
31281 (Constructor::Define): Catch errors where a struct constructor is
31284 * cs-parser.jay: Pass location information for various new
31287 * delegate.cs (Delegate): take a location argument.
31289 * driver.cs: Do not call EmitCode if there were problesm in the
31290 Definition of the types, as many Builders wont be there.
31292 * decl.cs (Decl::Decl): Require a location argument.
31294 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31295 into integers, and find the most appropiate integer for it.
31297 * literal.cs: Implement ULongLiteral.
31299 * rootcontext.cs: Provide better information about the location of
31300 failure when CreateType fails.
31302 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31304 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31307 * expression.cs (Binary::CheckShiftArguments): Add missing type
31309 (Binary::ResolveOperator): Add type to the logical and and logical
31310 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31313 (Binary::DoNumericPromotions): In the case where either argument
31314 is ulong (and most signed types combined with ulong cause an
31315 error) perform implicit integer constant conversions as well.
31317 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31319 * expression.cs (UserImplicitCast): Method should always be
31321 (Invocation::BetterConversion): Simplified test for IntLiteral.
31323 (Expression::ImplicitNumericConversion): Split this routine out.
31324 Put the code that performs implicit constant integer conversions
31327 (Expression::Resolve): Become a wrapper around DoResolve so we can
31328 check eclass and type being set after resolve.
31330 (Invocation::Badness): Remove this dead function
31332 (Binary::ResolveOperator): Do not compute the expensive argumnets
31333 unless we have a union for it.
31335 (Probe::Emit): Is needs to do an isinst and then
31336 compare against null.
31338 (::CanConvert): Added Location argument. If the Location argument
31339 is null (Location.Null), then we do not report errors. This is
31340 used by the `probe' mechanism of the Explicit conversion. We do
31341 not want to generate an error for something that the user
31342 explicitly requested to be casted. But the pipeline for an
31343 explicit cast first tests for potential implicit casts.
31345 So for now, if the Location is null, it means `Probe only' to
31346 avoid adding another argument. Might have to revise this
31349 (ClassCast): New class used to type cast objects into arbitrary
31350 classes (used in Explicit Reference Conversions).
31352 Implement `as' as well.
31354 Reverted all the patches from Ravi below: they were broken:
31356 * The use of `level' as a mechanism to stop recursive
31357 invocations is wrong. That was there just to catch the
31358 bug with a strack trace but not as a way of addressing
31361 To fix the problem we have to *understand* what is going
31362 on and the interactions and come up with a plan, not
31363 just get things going.
31365 * The use of the type conversion cache that I proposed
31366 last night had an open topic: How does this work across
31367 protection domains. A user defined conversion might not
31368 be public in the location where we are applying the
31369 conversion, a different conversion might be selected
31370 (ie, private A->B (better) but public B->A (worse),
31371 inside A, A->B applies, but outside it, B->A will
31374 * On top of that (ie, even if the above is solved),
31375 conversions in a cache need to be abstract. Ie, `To
31376 convert from an Int to a Short use an OpcodeCast', not
31377 `To convert from an Int to a Short use the OpcodeCast on
31378 the variable 5' (which is what this patch was doing).
31380 2001-09-28 Ravi Pratap <ravi@ximian.com>
31382 * expression.cs (Invocation::ConversionExists): Re-write to use
31383 the conversion cache
31385 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31386 cache all conversions done, not just user-defined ones.
31388 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31389 to determine if a conversion exists instead of acutually trying to
31390 perform the conversion. It's faster too.
31392 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31393 and only then attempt the implicit conversion.
31395 2001-09-28 Ravi Pratap <ravi@ximian.com>
31397 * expression.cs (ConvertImplicit): Use a cache for conversions
31398 already found. Check level of recursion and bail out if necessary.
31400 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31402 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31403 Export standard methods that we expect for string operations.
31405 * statement.cs (Block::UsageWarning): Track usage of variables and
31406 report the errors for not used variables.
31408 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31411 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31413 * codegen.cs: remove unnneded code
31415 * expression.cs: Removed BuiltinTypeAccess class
31417 Fix the order in which implicit conversions are
31420 The previous fixed dropped support for boxed conversions (adding a
31421 test to the test suite now)
31423 (UserImplicitCast::CanConvert): Remove test for source being null,
31424 that code is broken. We should not feed a null to begin with, if
31425 we do, then we should track the bug where the problem originates
31426 and not try to cover it up here.
31428 Return a resolved expression of type UserImplicitCast on success
31429 rather than true/false. Ravi: this is what I was talking about,
31430 the pattern is to use a static method as a "constructor" for
31433 Also, do not create arguments until the very last minute,
31434 otherwise we always create the arguments even for lookups that
31435 will never be performed.
31437 (UserImplicitCast::Resolve): Eliminate, objects of type
31438 UserImplicitCast are born in a fully resolved state.
31440 * typemanager.cs (InitCoreTypes): Init also value_type
31441 (System.ValueType).
31443 * expression.cs (Cast::Resolve): First resolve the child expression.
31445 (LValue): Add new method AddressOf to be used by
31448 Change the argument of Store to take an EmitContext instead of an
31449 ILGenerator, because things like FieldExpr need to be able to call
31450 their children expression to generate the instance code.
31452 (Expression::Error, Expression::Warning): Sugar functions for
31455 (Expression::MemberLookup): Accept a TypeContainer instead of a
31456 Report as the first argument.
31458 (Expression::ResolvePrimary): Killed. I still want to improve
31459 this as currently the code is just not right.
31461 (Expression::ResolveMemberAccess): Simplify, but it is still
31464 (Unary::Resolve): Catch errors in AddressOf operators.
31466 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31467 index to a byte for the short-version, or the compiler will choose
31468 the wrong Emit call, which generates the wrong data.
31470 (ParameterReference::Emit, ::Store): same.
31472 (FieldExpr::AddressOf): Implement.
31474 * typemanager.cs: TypeManager: made public variable instead of
31477 * driver.cs: document --fatal.
31479 * report.cs (ErrorMessage, WarningMessage): new names for the old
31480 Error and Warning classes.
31482 * cs-parser.jay (member_access): Turn built-in access to types
31483 into a normal simplename
31485 2001-09-27 Ravi Pratap <ravi@ximian.com>
31487 * expression.cs (Invocation::BetterConversion): Fix to cope
31488 with q being null, since this was introducing a bug.
31490 * expression.cs (ConvertImplicit): Do built-in conversions first.
31492 2001-09-27 Ravi Pratap <ravi@ximian.com>
31494 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31496 2001-09-27 Ravi Pratap <ravi@ximian.com>
31498 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31499 I had introduced long ago (what's new ?).
31501 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31502 the work of all the checking.
31503 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31504 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31506 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31507 that is the right way.
31509 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31510 overloading resolution. Use everywhere instead of cutting and pasting code.
31512 (Binary::ResolveOperator): Use MakeUnionSet.
31514 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31515 we have to convert to bool types. Not complete yet.
31517 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31519 * typemanager.cs (TypeManager::CSharpName): support ushort.
31521 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31522 to provide an expression that performsn an implicit constant int
31523 conversion (section 6.1.6).
31524 (Expression::ConvertImplicitRequired): Reworked to include
31525 implicit constant expression conversions.
31527 (Expression::ConvertNumericExplicit): Finished.
31529 (Invocation::Emit): If InstanceExpression is null, then it means
31530 that we perform a call on this.
31532 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31534 * expression.cs (Unary::Emit): Remove some dead code.
31535 (Probe): Implement Resolve and Emit for `is'.
31536 (Expression::ConvertImplicitRequired): Attempt to do constant
31537 expression conversions here. Maybe should be moved to
31538 ConvertImplicit, but I am not sure.
31539 (Expression::ImplicitLongConstantConversionPossible,
31540 Expression::ImplicitIntConstantConversionPossible): New functions
31541 that tell whether is it possible to apply an implicit constant
31542 expression conversion.
31544 (ConvertNumericExplicit): Started work on explicit numeric
31547 * cs-parser.jay: Update operator constants.
31549 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
31550 (Parameters::GetSignature): Hook up VerifyArgs here.
31551 (Parameters::VerifyArgs): Verifies that no two arguments have the
31554 * class.cs (Operator): Update the operator names to reflect the
31555 ones that the spec expects (as we are just stringizing the
31558 * expression.cs (Unary::ResolveOperator): Fix bug: Use
31559 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
31560 previous usage did only work for our methods.
31561 (Expression::ConvertImplicit): Handle decimal implicit numeric
31562 conversions as well.
31563 (Expression::InternalTypeConstructor): Used to invoke constructors
31564 on internal types for default promotions.
31566 (Unary::Emit): Implement special handling for the pre/post
31567 increment/decrement for overloaded operators, as they need to have
31568 the same semantics as the other operators.
31570 (Binary::ResolveOperator): ditto.
31571 (Invocation::ConversionExists): ditto.
31572 (UserImplicitCast::Resolve): ditto.
31574 2001-09-26 Ravi Pratap <ravi@ximian.com>
31576 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
31577 operator, return after emitting body. Regression tests pass again !
31579 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
31580 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
31581 (Invocation::OverloadResolve): Ditto.
31582 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
31584 * everywhere : update calls to the above methods accordingly.
31586 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31588 * assign.cs (Assign): Make it inherit from ExpressionStatement.
31590 * expression.cs (ExpressionStatement): New base class used for
31591 expressions that can appear in statements, so that we can provide
31592 an alternate path to generate expression that do not leave a value
31595 (Expression::Emit, and all the derivatives): We no longer return
31596 whether a value is left on the stack or not. Every expression
31597 after being emitted leaves a single value on the stack.
31599 * codegen.cs (EmitContext::EmitStatementExpression): Use the
31600 facilties of ExpressionStatement if possible.
31602 * cs-parser.jay: Update statement_expression.
31604 2001-09-25 Miguel de Icaza <miguel@ximian.com>
31606 * driver.cs: Change the wording of message
31608 2001-09-25 Ravi Pratap <ravi@ximian.com>
31610 * expression.cs (Binary::ResolveOperator): Had forgottten to set
31611 the type of the expression to the return type of the method if
31612 we have an overloaded operator match ! The regression tests pass again !
31613 (Unary::ResolveOperator): Ditto.
31615 * expression.cs (Invocation::ConversionExists): Correct the member lookup
31616 to find "op_Implicit", not "implicit" ;-)
31617 (UserImplicitCast): New class to take care of user-defined implicit conversions.
31618 (ConvertImplicit, ForceConversion): Take TypeContainer argument
31620 * everywhere : Correct calls to the above accordingly.
31622 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
31623 (ConvertImplicit): Do user-defined conversion if it exists.
31625 2001-09-24 Miguel de Icaza <miguel@ximian.com>
31627 * assign.cs: track location.
31628 (Resolve): Use implicit conversions on assignment.
31630 * literal.cs: Oops. Not good, Emit of short access values should
31631 pass (Bytes) or the wrong argument will be selected.
31633 * expression.cs (Unary::Emit): Emit code for -expr.
31635 (Unary::ResolveOperator): Handle `Substract' for non-constants
31636 (substract from zero from the non-constants).
31637 Deal with Doubles as well.
31639 (Expression::ConvertImplicitRequired): New routine that reports an
31640 error if no implicit conversion exists.
31642 (Invocation::OverloadResolve): Store the converted implicit
31643 expressions if we make them
31645 2001-09-24 Ravi Pratap <ravi@ximian.com>
31647 * class.cs (ConstructorInitializer): Take a Location argument.
31648 (ConstructorBaseInitializer): Same here.
31649 (ConstructorThisInitializer): Same here.
31651 * cs-parser.jay : Update all calls accordingly.
31653 * expression.cs (Unary, Binary, New): Take location argument.
31654 Update accordingly everywhere.
31656 * cs-parser.jay : Update all calls to the above to take a location
31659 * class.cs : Ditto.
31661 2001-09-24 Ravi Pratap <ravi@ximian.com>
31663 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
31664 (Invocation::BetterConversion): Same here
31665 (Invocation::ConversionExists): Ditto.
31667 (Invocation::ConversionExists): Implement.
31669 2001-09-22 Ravi Pratap <ravi@ximian.com>
31671 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
31672 Also take an additional TypeContainer argument.
31674 * All over : Pass in TypeContainer as argument to OverloadResolve.
31676 * typemanager.cs (CSharpName): Update to check for the string type and return
31679 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
31682 2001-09-21 Ravi Pratap <ravi@ximian.com>
31684 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
31685 (Invocation::BetterFunction): Implement.
31686 (Invocation::BetterConversion): Implement.
31687 (Invocation::ConversionExists): Skeleton, no implementation yet.
31689 Okay, things work fine !
31691 2001-09-21 Miguel de Icaza <miguel@ximian.com>
31693 * typemanager.cs: declare and load enum_type, delegate_type and
31696 * expression.cs (Expression::Emit): Now emit returns a value that
31697 tells whether a value is left on the stack or not. This strategy
31698 might be reveted tomorrow with a mechanism that would address
31699 multiple assignments.
31700 (Expression::report118): Utility routine to report mismatches on
31703 (Unary::Report23): Report impossible type/operator combination
31706 (Unary::IsIncrementableNumber): Whether the type can be
31707 incremented or decremented with add.
31708 (Unary::ResolveOperator): Also allow enumerations to be bitwise
31710 (Unary::ResolveOperator): Implement ++, !, ~,
31712 (Invocation::Emit): Deal with new Emit convetion.
31714 * All Expression derivatives: Updated their Emit method to return
31715 whether they leave values on the stack or not.
31717 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
31718 stack for expressions that are statements.
31720 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31722 * expression.cs (LValue): New interface. Must be implemented by
31724 (LocalVariableReference, ParameterReference, FieldExpr): Implement
31727 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
31728 interface for generating code, simplifies the code.
31730 2001-09-20 Ravi Pratap <ravi@ximian.com>
31732 * expression.cs (everywhere): Comment out return statements in ::Resolve
31733 methods to avoid the warnings.
31735 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31737 * driver.cs (parse): Report error 2001 if we can not open the
31740 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
31743 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
31746 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
31747 otherwise nested blocks end up with the same index.
31749 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
31751 * expression.cs: Instead of having FIXMEs in the Resolve
31752 functions, throw exceptions so it is obvious that we are facing a
31755 * cs-parser.jay (invocation_expression): Pass Location information.
31757 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
31758 Use a basename for those routines because .NET does not like paths
31761 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
31764 2001-09-19 Miguel de Icaza <miguel@ximian.com>
31766 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
31767 are loading the correct data types (throws an exception if not).
31768 (TypeManager::InitCoreTypes): Use CoreLookupType
31770 * expression.cs (Unary::ResolveOperator): return the child
31771 expression for expressions which are just +expr.
31772 (Unary::ResolveOperator): Return negative literals for -LITERAL
31773 expressions (otherwise they are Unary {Literal}).
31774 (Invocation::Badness): Take into account `Implicit constant
31775 expression conversions'.
31777 * literal.cs (LongLiteral): Implement long literal class.
31778 (IntLiteral): export the `Value' of the intliteral.
31780 2001-09-19 Ravi Pratap <ravi@ximian.com>
31782 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
31784 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
31785 instead of 'Operator'
31787 * expression.cs (Binary::ResolveOperator): Update accordingly.
31788 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
31791 * cs-parser.jay (unary_expression): Update to use the new names.
31793 * gen-treedump.cs (GetUnary): Same here.
31795 * expression.cs (Unary::Resolve): Implement.
31796 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
31797 operators are found instead of making noise ;-)
31798 (Unary::ResolveOperator): New method to do precisely the same thing which
31799 Binary::ResolveOperator does for Binary expressions.
31800 (Unary.method, .Arguments): Add.
31801 (Unary::OperName): Implement.
31802 (Unary::ForceConversion): Copy and Paste !
31804 * class.cs (Operator::Define): Fix a small bug for the case when we have
31807 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
31808 for the inbuilt operators. Only overloading works for now ;-)
31810 2001-09-18 Miguel de Icaza <miguel@ximian.com>
31812 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
31813 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
31815 * expression.cs (This::Emit): Implement.
31816 (This::Resolve): Implement.
31817 (TypeOf:Resolve): Implement.
31818 (Expression::ResolveSimpleName): Add an implicit this to instance
31820 (MemberAccess::Resolve): Deal with Parameters and Fields.
31821 Bind instance variable to Field expressions.
31822 (FieldExpr::Instance): New field used to track the expression that
31823 represents the object instance.
31824 (FieldExpr::Resolve): Track potential errors from MemberLookup not
31826 (FieldExpr::Emit): Implement.
31828 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
31829 the last instruction contains a return opcode to avoid generating
31830 the last `ret' instruction (this generates correct code, and it is
31831 nice to pass the peverify output).
31833 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
31834 initializer for static and instance variables.
31835 (Constructor::Emit): Allow initializer to be null in the case of
31836 static constructors. Only emit initializer for instance
31839 (TypeContainer::FindMembers): Return a null array if there are no
31842 Also fix the code for the MemberTypes.Method branch, as it was not
31843 scanning that for operators (or tried to access null variables before).
31845 * assign.cs (Assign::Emit): Handle instance and static fields.
31849 * driver.cs: Stop compilation if there are parse errors.
31851 * cs-parser.jay (constructor_declaration): Provide default base
31852 initializer for non-static constructors.
31853 (constructor_declarator): Do not provide a default base
31854 initializers if none was specified.
31855 Catch the fact that constructors should not have parameters.
31857 * class.cs: Do not emit parent class initializers for static
31858 constructors, that should be flagged as an error.
31860 2001-09-18 Ravi Pratap <ravi@ximian.com>
31862 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
31863 Move back code into TypeContainer::Populate.
31865 2001-09-18 Ravi Pratap <ravi@ximian.com>
31867 * class.cs (TypeContainer::AddConstructor): Fix the check to
31868 compare against Name, not Basename.
31869 (Operator::OpType): Change Plus and Minus to Add and Subtract.
31871 * cs-parser.jay : Update accordingly.
31873 * class.cs (TypeContainer::FindMembers): For the case where we are searching
31874 for methods, don't forget to look into the operators too.
31875 (RegisterMethodBuilder): Helper method to take care of this for
31876 methods, constructors and operators.
31877 (Operator::Define): Completely revamp.
31878 (Operator.OperatorMethod, MethodName): New fields.
31879 (TypeContainer::Populate): Move the registering of builders into
31880 RegisterMethodBuilder.
31881 (Operator::Emit): Re-write.
31883 * expression.cs (Binary::Emit): Comment out code path to emit method
31884 invocation stuff for the case when we have a user defined operator. I am
31885 just not able to get it right !
31887 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31889 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
31892 (Expression::MemberLookup): Provide a version that allows to
31893 specify the MemberTypes and BindingFlags.
31895 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
31896 so it was not fetching variable information from outer blocks.
31898 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
31899 Beforefieldinit as it was buggy.
31901 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
31902 that Ravi put here.
31904 * class.cs (Constructor::Emit): Only emit if block is not null.
31905 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
31906 deal with this by semantically definining it as if the user had
31909 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
31910 constructors as we now "emit" them at a higher level.
31912 (TypeContainer::DefineDefaultConstructor): Used to define the
31913 default constructors if none was provided.
31915 (ConstructorInitializer): Add methods Resolve and Emit.
31917 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
31919 2001-09-17 Ravi Pratap <ravi@ximian.com>
31921 * class.cs (TypeContainer::EmitDefaultConstructor): Register
31922 the default constructor builder with our hashtable for methodbuilders
31925 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
31926 and argument_count is 0 in which case we have a match.
31927 (Binary::ResolveOperator): More null checking and miscellaneous coding
31930 2001-09-17 Ravi Pratap <ravi@ximian.com>
31932 * rootcontext.cs (IsNameSpace): Compare against null.
31934 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
31936 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
31937 and Unary::Operator.
31939 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
31942 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
31943 we have overloaded operators.
31944 (Binary::ResolveOperator): Implement the part which does the operator overload
31947 * class.cs (Operator::Emit): Implement.
31948 (TypeContainer::Emit): Emit the operators we have too.
31950 * expression.cs (Binary::Emit): Update to emit the appropriate code for
31951 the case when we have a user-defined operator.
31953 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31955 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
31957 2001-09-16 Ravi Pratap <ravi@ximian.com>
31959 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
31960 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
31961 (Constructor::Emit): Implement.
31962 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
31963 if we have no work to do.
31964 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
31967 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
31968 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
31970 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
31973 2001-09-15 Ravi Pratap <ravi@ximian.com>
31975 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
31977 (Tree::RecordNamespace): Method to do what the name says ;-)
31978 (Tree::Namespaces): Property to get at the namespaces hashtable.
31980 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
31983 * rootcontext.cs (IsNamespace): Fixed it :-)
31985 2001-09-14 Miguel de Icaza <miguel@ximian.com>
31987 * class.cs (TypeContainer::FindMembers): Add support for
31989 (MethodCore): New class that encapsulates both the shared aspects
31990 of a Constructor and a Method.
31991 (Method, Constructor): Factored pieces into MethodCore.
31993 * driver.cs: Added --fatal which makes errors throw exceptions.
31994 Load System assembly as well as part of the standard library.
31996 * report.cs: Allow throwing exceptions on errors for debugging.
31998 * modifiers.cs: Do not use `parent', instead use the real type
31999 container to evaluate permission settings.
32001 * class.cs: Put Ravi's patch back in. He is right, and we will
32002 have to cope with the
32004 2001-09-14 Ravi Pratap <ravi@ximian.com>
32006 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32007 FamORAssem, not FamANDAssem.
32009 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32011 * driver.cs: Added --parse option that only parses its input files
32014 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32015 incorrect. IsTopLevel is not used to tell whether an object is
32016 root_types or not (that can be achieved by testing this ==
32017 root_types). But to see if this is a top-level *class* (not
32018 necessarly our "toplevel" container).
32020 2001-09-14 Ravi Pratap <ravi@ximian.com>
32022 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32023 parent instead of a direct call to GetType.
32025 2001-09-14 Ravi Pratap <ravi@ximian.com>
32027 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32028 Modifiers.TypeAttr. This should just be a call to that method.
32030 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32031 object so that we can determine if we are top-level or not.
32033 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32036 * enum.cs (Enum::Define): Ditto.
32038 * modifiers.cs (FieldAttr): Re-write.
32040 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32041 (TypeContainer::HaveStaticConstructor): New property to provide access
32042 to precisely that info.
32044 * modifiers.cs (MethodAttr): Re-write.
32045 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32047 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32048 of top-level types as claimed.
32050 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32052 * expression.cs (MemberLookup): Fruitless attempt to lookup
32053 constructors. Maybe I need to emit default constructors? That
32054 might be it (currently .NET emits this for me automatically).
32055 (Invocation::OverloadResolve): Cope with Arguments == null.
32056 (Invocation::EmitArguments): new function, shared by the new
32057 constructor and us.
32058 (Invocation::Emit): Handle static and instance methods. Emit
32059 proper call instruction for virtual or non-virtual invocations.
32060 (New::Emit): Implement.
32061 (New::Resolve): Implement.
32062 (MemberAccess:Resolve): Implement.
32063 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32064 to track instances.
32065 (FieldExpr::Resolve): Set type.
32067 * support.cs: Handle empty arguments.
32069 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32070 SimpleLookup): Auxiliary routines to help parse a qualifier
32073 Update qualifier_identifier rule.
32075 * codegen.cs: Removed debugging messages.
32077 * class.cs: Make this a global thing, this acts just as a "key" to
32078 objects that we might have around.
32080 (Populate): Only initialize method_builders_to_methods once.
32082 * expression.cs (PropertyExpr): Initialize type from the
32085 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32086 Resolve pattern. Attempt to implicitly convert value to boolean.
32089 * expression.cs: Set the type for the int32/int32 argument case.
32090 (Binary::ResolveOperator): Set the return type to boolean for
32091 comparission operators
32093 * typemanager.cs: Remove debugging print code.
32095 (Invocation::Resolve): resolve type.
32097 * class.cs: Allocate a MemberInfo of the correct size, as the code
32098 elsewhere depends on the test to reflect the correct contents.
32100 (Method::) Keep track of parameters, due to System.Reflection holes
32102 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32105 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32106 of the exact size and return that.
32108 (Class::LookupMethodByBuilder): New function that maps
32109 MethodBuilders to its methods. Required to locate the information
32110 on methods because System.Reflection bit us again.
32112 * support.cs: New file, contains an interface ParameterData and
32113 two implementations: ReflectionParameters and InternalParameters
32114 used to access Parameter information. We will need to grow this
32117 * expression.cs (Invocation::GetParameterData): implement a cache
32118 and a wrapper around the ParameterData creation for methods.
32119 (Invocation::OverloadResolve): Use new code.
32121 2001-09-13 Ravi Pratap <ravi@ximian.com>
32123 * class.cs (TypeContainer::EmitField): Remove and move into
32124 (Field::Define): here and modify accordingly.
32125 (Field.FieldBuilder): New member.
32126 (TypeContainer::Populate): Update accordingly.
32127 (TypeContainer::FindMembers): Implement.
32129 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32131 * statement.cs: (VariableInfo::VariableType): New field to be
32132 initialized with the full type once it is resolved.
32134 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32136 * parameter.cs (GetParameterInfo): Use a type cache to compute
32137 things only once, and to reuse this information
32139 * expression.cs (LocalVariableReference::Emit): Implement.
32140 (OpcodeCast::Emit): fix.
32142 (ParameterReference::Resolve): Implement.
32143 (ParameterReference::Emit): Implement.
32145 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32146 that are expressions need to stay as Expressions.
32148 * typemanager.cs (CSharpName): Returns the C# name of a type if
32151 * expression.cs (Expression::ConvertImplicit): New function that
32152 implements implicit type conversions.
32154 (Expression::ImplicitReferenceConversion): Implements implicit
32155 reference conversions.
32157 (EmptyCast): New type for transparent casts.
32159 (OpcodeCast): New type for casts of types that are performed with
32160 a sequence of bytecodes.
32162 (BoxedCast): New type used for casting value types into reference
32163 types. Emits a box opcode.
32165 (Binary::DoNumericPromotions): Implements numeric promotions of
32166 and computation of the Binary::Type.
32168 (Binary::EmitBranchable): Optimization.
32170 (Binary::Emit): Implement code emission for expressions.
32172 * typemanager.cs (TypeManager): Added two new core types: sbyte
32175 2001-09-12 Ravi Pratap <ravi@ximian.com>
32177 * class.cs (TypeContainer::FindMembers): Method which does exactly
32178 what Type.FindMembers does, only we don't have to use reflection. No
32179 implementation yet.
32181 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32182 typecontainer objects as we need to get at them.
32183 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32185 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32186 typecontainer object.
32188 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32189 of just a Report object.
32191 2001-09-11 Ravi Pratap <ravi@ximian.com>
32193 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32195 (TypeContainer::Populate): Now define the delegates of the type too.
32196 (TypeContainer.Delegates): Property to access the list of delegates defined
32199 * delegates.cs (Delegate::Define): Implement partially.
32201 * modifiers.cs (TypeAttr): Handle more flags.
32203 2001-09-11 Ravi Pratap <ravi@ximian.com>
32205 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32207 (Operator::Define): Re-write logic to get types by using the LookupType method
32208 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32209 (Indexer::Define): Ditto.
32210 (Event::Define): Ditto.
32211 (Property::Define): Ditto.
32213 2001-09-10 Ravi Pratap <ravi@ximian.com>
32215 * class.cs (TypeContainer::Populate): Now define operators too.
32216 (TypeContainer.Operators): New property to access the list of operators
32218 (Operator.OperatorMethodBuilder): New member to hold the method builder
32219 for the operator we are defining.
32220 (Operator::Define): Implement.
32222 2001-09-10 Ravi Pratap <ravi@ximian.com>
32224 * class.cs (Event::Define): Make the prefixes of the accessor methods
32225 addOn_ and removeOn_
32227 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32228 of the location being passed in too. Ideally, this should go later since all
32229 error reporting should be done through the Report object.
32231 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32232 (Populate): Iterate thru the indexers we have and define them too.
32233 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32234 for the get and set accessors.
32235 (Indexer::Define): Implement.
32237 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32239 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32240 my previous implementation, did not work.
32242 * typemanager.cs: Add a couple of missing types (the longs).
32244 * literal.cs: Use TypeManager.bool_type instead of getting it.
32246 * expression.cs (EventExpr): New kind of expressions.
32247 (Expressio::ExprClassFromMemberInfo): finish
32249 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32251 * assign.cs: Emit stores to static fields differently.
32253 2001-09-08 Ravi Pratap <ravi@ximian.com>
32255 * Merge in changes and adjust code to tackle conflicts. Backed out my
32256 code in Assign::Resolve ;-)
32258 2001-09-08 Ravi Pratap <ravi@ximian.com>
32260 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32261 instead Report.Error and also pass in the location.
32262 (CSharpParser::Lexer): New readonly property to return the reference
32263 to the Tokenizer object.
32264 (declare_local_variables): Use Report.Error with location instead of plain
32268 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32269 (Operator.CheckBinaryOperator): Ditto.
32271 * cs-parser.jay (operator_declarator): Update accordingly.
32273 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32274 (CheckBinaryOperator): Same here.
32276 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32277 on the name without any prefixes of namespace names etc. This is because we
32278 already might have something already fully qualified like
32279 'System.Console.WriteLine'
32281 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32283 2001-09-07 Ravi Pratap <ravi@ximian.com>
32285 * cs-tokenizer.cs (location): Return a string which also contains
32288 * expression.cs (ElementAccess): New class for expressions of the
32289 type 'element access.'
32290 (BaseAccess): New class for expressions of the type 'base access.'
32291 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32294 * cs-parser.jay (element_access): Implement action.
32295 (base_access): Implement actions.
32296 (checked_expression, unchecked_expression): Implement.
32298 * cs-parser.jay (local_variable_type): Correct and implement.
32299 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32301 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32303 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32304 name and the specifiers.
32306 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32308 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32309 making them all public ;-)
32311 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32314 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32316 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32318 (FieldExpr, PropertyExprs): New resolved expressions.
32319 (SimpleName::MemberStaticCheck): Perform static checks for access
32320 to non-static fields on static methods. Maybe this should be
32321 generalized for MemberAccesses.
32322 (SimpleName::ResolveSimpleName): More work on simple name
32325 * cs-parser.jay (primary_expression/qualified_identifier): track
32326 the parameter index.
32328 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32329 (EmitContext::EmitBoolExpression): Chain to expression generation
32330 instead of temporary hack.
32331 (::EmitStatementExpression): Put generic expression code generation.
32333 * assign.cs (Assign::Emit): Implement variable assignments to
32334 local variables, parameters and fields.
32336 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32338 * statement.cs (Block::GetVariableInfo): New method, returns the
32339 VariableInfo for a variable name in a block.
32340 (Block::GetVariableType): Implement in terms of GetVariableInfo
32342 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32343 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32345 2001-09-06 Ravi Pratap <ravi@ximian.com>
32347 * cs-parser.jay (operator_declaration): Continue on my quest : update
32348 to take attributes argument.
32349 (event_declaration): Ditto.
32350 (enum_declaration): Ditto.
32351 (indexer_declaration): Ditto.
32353 * class.cs (Operator::Operator): Update constructor accordingly.
32354 (Event::Event): Ditto.
32356 * delegate.cs (Delegate::Delegate): Same here.
32358 * enum.cs (Enum::Enum): Same here.
32360 2001-09-05 Ravi Pratap <ravi@ximian.com>
32362 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32364 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32366 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32367 being passed around as an arraylist.
32368 (Attributes::AddAttribute): Method to add attribute sections.
32370 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32371 (struct_declaration): Update accordingly.
32372 (constant_declaration): Update.
32373 (field_declaration): Update.
32374 (method_header): Update.
32375 (fixed_parameter): Update.
32376 (parameter_array): Ditto.
32377 (property_declaration): Ditto.
32378 (destructor_declaration): Ditto.
32380 * class.cs (Struct::Struct): Update constructors accordingly.
32381 (Class::Class): Ditto.
32382 (Field::Field): Ditto.
32383 (Method::Method): Ditto.
32384 (Property::Property): Ditto.
32385 (TypeContainer::OptAttribute): update property's return type.
32387 * interface.cs (Interface.opt_attributes): New member.
32388 (Interface::Interface): Update to take the extra Attributes argument.
32390 * parameter.cs (Parameter::Parameter): Ditto.
32392 * constant.cs (Constant::Constant): Ditto.
32394 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32395 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32396 the attributes as a parameter.
32397 (InterfaceProperty): Update constructor call.
32398 (InterfaceEvent): Ditto.
32399 (InterfaceMethod): Ditto.
32400 (InterfaceIndexer): Ditto.
32402 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32403 pass the attributes too.
32404 (interface_event_declaration): Ditto.
32405 (interface_property_declaration): Ditto.
32406 (interface_method_declaration): Ditto.
32407 (interface_declaration): Ditto.
32409 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32411 * class.cs (Method::Define): Track the "static Main" definition to
32412 create an entry point.
32414 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32415 EntryPoint if we find it.
32417 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32418 (EmitContext::ig): Make this variable public.
32420 * driver.cs: Make the default output file be the first file name
32421 with the .exe extension.
32423 Detect empty compilations
32425 Handle various kinds of output targets. Handle --target and
32426 rename -t to --dumper.
32428 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32429 methods inherited from Expression return now an Expression. This
32430 will is used during the tree rewriting as we resolve them during
32433 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32434 the spec. Missing entirely is the information about
32435 accessability of elements of it.
32437 (Expression::ExprClassFromMemberInfo): New constructor for
32438 Expressions that creates a fully initialized Expression based on
32439 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32442 (Invocation::Resolve): Begin implementing resolution of invocations.
32444 * literal.cs (StringLiteral): Implement Emit.
32446 2001-09-05 Ravi Pratap <ravi@ximian.com>
32448 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32451 2001-09-04 Ravi Pratap <ravi@ximian.com>
32453 * cs-parser.jay (attribute_arguments): Implement actions.
32454 (attribute): Fix bug in production. Implement action.
32455 (attribute_list): Implement.
32456 (attribute_target): Implement.
32457 (attribute_target_specifier, opt_target_specifier): Implement
32458 (CheckAttributeTarget): New method to check if the attribute target
32460 (attribute_section): Implement.
32461 (opt_attributes): Implement.
32463 * attribute.cs : New file to handle attributes.
32464 (Attribute): Class to hold attribute info.
32466 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32467 (attribute_section): Modify production to use 2 different rules to
32468 achieve the same thing. 1 s/r conflict down !
32469 Clean out commented, useless, non-reducing dimension_separator rules.
32471 * class.cs (TypeContainer.attributes): New member to hold list
32472 of attributes for a type.
32473 (Struct::Struct): Modify to take one more argument, the attribute list.
32474 (Class::Class): Ditto.
32475 (Field::Field): Ditto.
32476 (Method::Method): Ditto.
32477 (Property::Property): Ditto.
32479 * cs-parser.jay (struct_declaration): Update constructor call to
32480 pass in the attributes too.
32481 (class_declaration): Ditto.
32482 (constant_declaration): Ditto.
32483 (field_declaration): Ditto.
32484 (method_header): Ditto.
32485 (fixed_parameter): Ditto.
32486 (parameter_array): Ditto.
32487 (property_declaration): Ditto.
32489 * constant.cs (Constant::Constant): Update constructor similarly.
32490 Use System.Collections.
32492 * parameter.cs (Parameter::Parameter): Update as above.
32494 2001-09-02 Ravi Pratap <ravi@ximian.com>
32496 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32497 (TypeContainer.delegates): New member to hold list of delegates.
32499 * cs-parser.jay (delegate_declaration): Implement the action correctly
32500 this time as I seem to be on crack ;-)
32502 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32504 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32505 tell whether an identifier represents a namespace.
32507 * expression.cs (NamespaceExpr): A namespace expression, used only
32508 temporarly during expression resolution.
32509 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32510 utility functions to resolve names on expressions.
32512 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32514 * codegen.cs: Add hook for StatementExpressions.
32516 * class.cs: Fix inverted test for static flag in methods.
32518 2001-09-02 Ravi Pratap <ravi@ximian.com>
32520 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32521 to make it coincide with MS' number.
32522 (Operator::CheckBinaryOperator): Ditto.
32524 * ../errors/errors.txt : Remove error numbers added earlier.
32526 * ../errors/cs1019.cs : Test case for error # 1019
32528 * ../errros/cs1020.cs : Test case for error # 1020
32530 * cs-parser.jay : Clean out commented cruft.
32531 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32532 used anywhere - non-reducing rule.
32533 (namespace_declarations): Non-reducing rule - comment out.
32535 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32536 with TypeContainer::AddEnum.
32538 * delegate.cs : New file for delegate handling classes.
32539 (Delegate): Class for declaring delegates.
32541 * makefile : Update.
32543 * cs-parser.jay (delegate_declaration): Implement.
32545 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
32547 * class.cs (Event::Define): Implement.
32548 (Event.EventBuilder): New member.
32550 * class.cs (TypeContainer::Populate): Update to define all enums and events
32552 (Events): New property for the events arraylist we hold. Shouldn't we move to using
32553 readonly fields for all these cases ?
32555 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32557 * class.cs (Property): Revamp to use the convention of making fields readonly.
32558 Accordingly modify code elsewhere.
32560 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
32561 the Define method of the Property class.
32563 * class.cs : Clean up applied patch and update references to variables etc. Fix
32565 (TypeContainer::Populate): Update to define all the properties we have. Also
32566 define all enumerations.
32568 * enum.cs (Define): Implement.
32570 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32572 * cs-parser.jay (overloadable_operator): The semantic value is an
32573 enum of the Operator class.
32574 (operator_declarator): Implement actions.
32575 (operator_declaration): Implement.
32577 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
32578 validity of definitions.
32579 (Operator::CheckBinaryOperator): Static method to check for binary operators
32580 (TypeContainer::AddOperator): New method to add an operator to a type.
32582 * cs-parser.jay (indexer_declaration): Added line to actually call the
32583 AddIndexer method so it gets added ;-)
32585 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
32586 already taken care of by the MS compiler ?
32588 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32590 * class.cs (Operator): New class for operator declarations.
32591 (Operator::OpType): Enum for the various operators.
32593 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32595 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
32596 ostensibly handle this in semantic analysis.
32598 * cs-parser.jay (general_catch_clause): Comment out
32599 (specific_catch_clauses, specific_catch_clause): Ditto.
32600 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
32601 (catch_args, opt_catch_args): New productions.
32602 (catch_clause): Rewrite to use the new productions above
32603 (catch_clauses): Modify accordingly.
32604 (opt_catch_clauses): New production to use in try_statement
32605 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
32606 and re-write the code in the actions to extract the specific and
32607 general catch clauses by being a little smart ;-)
32609 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
32610 Hooray, try and catch statements parse fine !
32612 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32614 * statement.cs (Block::GetVariableType): Fix logic to extract the type
32615 string from the hashtable of variables.
32617 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
32618 I end up making that mistake ;-)
32619 (catch_clauses): Fixed gross error which made Key and Value of the
32620 DictionaryEntry the same : $1 !!
32622 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32624 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
32626 * cs-parser.jay (event_declaration): Correct to remove the semicolon
32627 when the add and remove accessors are specified.
32629 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32631 * cs-parser.jay (IndexerDeclaration): New helper class to hold
32632 information about indexer_declarator.
32633 (indexer_declarator): Implement actions.
32634 (parsing_indexer): New local boolean used to keep track of whether
32635 we are parsing indexers or properties. This is necessary because
32636 implicit_parameters come into picture even for the get accessor in the
32637 case of an indexer.
32638 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
32640 * class.cs (Indexer): New class for indexer declarations.
32641 (TypeContainer::AddIndexer): New method to add an indexer to a type.
32642 (TypeContainer::indexers): New member to hold list of indexers for the
32645 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32647 * cs-parser.jay (add_accessor_declaration): Implement action.
32648 (remove_accessor_declaration): Implement action.
32649 (event_accessors_declaration): Implement
32650 (variable_declarators): swap statements for first rule - trivial.
32652 * class.cs (Event): New class to hold information about event
32654 (TypeContainer::AddEvent): New method to add an event to a type
32655 (TypeContainer::events): New member to hold list of events.
32657 * cs-parser.jay (event_declaration): Implement actions.
32659 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32661 * cs-parser.jay (dim_separators): Implement. Make it a string
32662 concatenating all the commas together, just as they appear.
32663 (opt_dim_separators): Modify accordingly
32664 (rank_specifiers): Update accordingly. Basically do the same
32665 thing - instead, collect the brackets here.
32666 (opt_rank_sepcifiers): Modify accordingly.
32667 (array_type): Modify to actually return the complete type string
32668 instead of ignoring the rank_specifiers.
32669 (expression_list): Implement to collect the expressions
32670 (variable_initializer): Implement. We make it a list of expressions
32671 essentially so that we can handle the array_initializer case neatly too.
32672 (variable_initializer_list): Implement.
32673 (array_initializer): Make it a list of variable_initializers
32674 (opt_array_initializer): Modify accordingly.
32676 * expression.cs (New::NType): Add enumeration to help us
32677 keep track of whether we have an object/delegate creation
32678 or an array creation.
32679 (New:NewType, New::Rank, New::Indices, New::Initializers): New
32680 members to hold data about array creation.
32681 (New:New): Modify to update NewType
32682 (New:New): New Overloaded contructor for the array creation
32685 * cs-parser.jay (array_creation_expression): Implement to call
32686 the overloaded New constructor.
32688 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
32690 * class.cs (TypeContainer::Constructors): Return member
32691 constructors instead of returning null.
32693 2001-08-26 Miguel de Icaza <miguel@ximian.com>
32695 * typemanager.cs (InitCoreTypes): Initialize the various core
32696 types after we have populated the type manager with the user
32697 defined types (this distinction will be important later while
32698 compiling corlib.dll)
32700 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
32701 on Expression Classification. Now all expressions have a method
32702 `Resolve' and a method `Emit'.
32704 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
32705 generation from working. Also add some temporary debugging
32708 2001-08-24 Miguel de Icaza <miguel@ximian.com>
32710 * codegen.cs: Lots of code generation pieces. This is only the
32711 beginning, will continue tomorrow with more touches of polish. We
32712 handle the fundamentals of if, while, do, for, return. Others are
32713 trickier and I need to start working on invocations soon.
32715 * gen-treedump.cs: Bug fix, use s.Increment here instead of
32718 * codegen.cs (EmitContext): New struct, used during code
32719 emission to keep a context. Most of the code generation will be
32722 * cs-parser.jay: Add embedded blocks to the list of statements of
32723 this block. So code generation proceeds in a top down fashion.
32725 2001-08-23 Miguel de Icaza <miguel@ximian.com>
32727 * statement.cs: Add support for multiple child blocks.
32729 2001-08-22 Miguel de Icaza <miguel@ximian.com>
32731 * codegen.cs (EmitCode): New function, will emit the code for a
32732 Block of code given a TypeContainer and its ILGenerator.
32734 * statement.cs (Block): Standard public readonly optimization.
32735 (Block::Block constructors): Link children.
32736 (Block::Child): Child Linker.
32737 (Block::EmitVariables): Emits IL variable declarations.
32739 * class.cs: Drop support for MethodGroups here, delay until
32741 (Method::): Applied the same simplification that I did before, and
32742 move from Properties to public readonly fields.
32743 (Method::ParameterTypes): Returns the parameter types for the
32744 function, and implements a cache that will be useful later when I
32745 do error checking and the semantic analysis on the methods is
32747 (Constructor::GetCallingConvention): Renamed from CallingConvetion
32748 and made a method, optional argument tells whether this is a class
32749 or a structure to apply the `has-this' bit.
32750 (Method::GetCallingConvention): Implement, returns the calling
32752 (Method::Define): Defines the type, a second pass is performed
32753 later to populate the methods.
32755 (Constructor::ParameterTypes): implement a cache similar to the
32756 one on Method::ParameterTypes, useful later when we do semantic
32759 (TypeContainer::EmitMethod): New method. Emits methods.
32761 * expression.cs: Removed MethodGroup class from here.
32763 * parameter.cs (Parameters::GetCallingConvention): new method.
32765 2001-08-21 Miguel de Icaza <miguel@ximian.com>
32767 * class.cs (TypeContainer::Populate): Drop RootContext from the
32770 (Constructor::CallingConvention): Returns the calling convention.
32771 (Constructor::ParameterTypes): Returns the constructor parameter
32774 (TypeContainer::AddConstructor): Keep track of default constructor
32775 and the default static constructor.
32777 (Constructor::) Another class that starts using `public readonly'
32778 instead of properties.
32780 (Constructor::IsDefault): Whether this is a default constructor.
32782 (Field::) use readonly public fields instead of properties also.
32784 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
32785 track of static constructors; If none is used, turn on
32786 BeforeFieldInit in the TypeAttributes.
32788 * cs-parser.jay (opt_argument_list): now the return can be null
32789 for the cases where there are no arguments.
32791 (constructor_declarator): If there is no implicit `base' or
32792 `this', then invoke the default parent constructor.
32794 * modifiers.cs (MethodAttr): New static function maps a set of
32795 modifiers flags into a MethodAttributes enum
32796 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
32797 MethodAttr, TypeAttr to represent the various mappings where the
32798 modifiers are used.
32799 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
32801 2001-08-19 Miguel de Icaza <miguel@ximian.com>
32803 * parameter.cs (GetParameterInfo): Fix bug where there would be no
32806 * interface.cs (PopulateIndexer): Implemented the code generator
32807 for interface indexers.
32809 2001-08-17 Miguel de Icaza <miguel@ximian.com>
32811 * interface.cs (InterfaceMemberBase): Now we track the new status
32814 (PopulateProperty): Implement property population. Woohoo! Got
32815 Methods and Properties going today.
32817 Removed all the properties for interfaces, and replaced them with
32818 `public readonly' fields.
32820 2001-08-16 Miguel de Icaza <miguel@ximian.com>
32822 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
32823 initialize their hashtables/arraylists only when they are needed
32824 instead of doing this always.
32826 * parameter.cs: Handle refs and out parameters.
32828 * cs-parser.jay: Use an ArrayList to construct the arguments
32829 instead of the ParameterCollection, and then cast that to a
32832 * parameter.cs: Drop the use of ParameterCollection and use
32833 instead arrays of Parameters.
32835 (GetParameterInfo): Use the Type, not the Name when resolving
32838 2001-08-13 Miguel de Icaza <miguel@ximian.com>
32840 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
32841 and instead use public readonly fields.
32843 * class.cs: Put back walking code for type containers.
32845 2001-08-11 Miguel de Icaza <miguel@ximian.com>
32847 * class.cs (MakeConstant): Code to define constants.
32849 * rootcontext.cs (LookupType): New function. Used to locate types
32852 2001-08-08 Miguel de Icaza <miguel@ximian.com>
32854 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
32855 this System.Reflection code is. Kudos to Microsoft
32857 * typemanager.cs: Implement a type cache and avoid loading all
32858 types at boot time. Wrap in LookupType the internals. This made
32859 the compiler so much faster. Wow. I rule!
32861 * driver.cs: Make sure we always load mscorlib first (for
32862 debugging purposes, nothing really important).
32864 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
32865 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
32867 * rootcontext.cs: Lookup types on their namespace; Lookup types
32868 on namespaces that have been imported using the `using' keyword.
32870 * class.cs (TypeContainer::TypeAttr): Virtualize.
32871 (Class::TypeAttr): Return attributes suitable for this bad boy.
32872 (Struct::TypeAttr): ditto.
32873 Handle nested classes.
32874 (TypeContainer::) Remove all the type visiting code, it is now
32875 replaced with the rootcontext.cs code
32877 * rootcontext.cs (GetClassBases): Added support for structs.
32879 2001-08-06 Miguel de Icaza <miguel@ximian.com>
32881 * interface.cs, statement.cs, class.cs, parameter.cs,
32882 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
32883 Drop use of TypeRefs, and use strings instead.
32885 2001-08-04 Miguel de Icaza <miguel@ximian.com>
32889 * class.cs (Struct::Struct): set the SEALED flags after
32890 checking the modifiers.
32891 (TypeContainer::TypeAttr): new property, returns the
32892 TypeAttributes for a class.
32894 * cs-parser.jay (type_list): Oops, list production was creating a
32895 new list of base types.
32897 * rootcontext.cs (StdLib): New property.
32898 (GetInterfaceTypeByName): returns an interface by type name, and
32899 encapsulates error handling here.
32900 (GetInterfaces): simplified.
32901 (ResolveTree): Encapsulated all the tree resolution here.
32902 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
32905 * driver.cs: Add support for --nostdlib, to avoid loading the
32906 default assemblies.
32907 (Main): Do not put tree resolution here.
32909 * rootcontext.cs: Beginning of the class resolution.
32911 2001-08-03 Miguel de Icaza <miguel@ximian.com>
32913 * rootcontext.cs: Provide better error reporting.
32915 * cs-parser.jay (interface_base): set our $$ to be interfaces.
32917 * rootcontext.cs (CreateInterface): Handle the case where there
32918 are no parent interfaces.
32920 (CloseTypes): Routine to flush types at the end.
32921 (CreateInterface): Track types.
32922 (GetInterfaces): Returns an array of Types from the list of
32923 defined interfaces.
32925 * typemanager.c (AddUserType): Mechanism to track user types (puts
32926 the type on the global type hash, and allows us to close it at the
32929 2001-08-02 Miguel de Icaza <miguel@ximian.com>
32931 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
32932 RecordInterface instead.
32934 * cs-parser.jay: Updated to reflect changes above.
32936 * decl.cs (Definition): Keep track of the TypeBuilder type that
32937 represents this type here. Not sure we will use it in the long
32938 run, but wont hurt for now.
32940 * driver.cs: Smaller changes to accomodate the new code.
32942 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
32945 * rootcontext.cs (CreateInterface): New method, used to create
32946 the System.TypeBuilder type for interfaces.
32947 (ResolveInterfaces): new entry point to resolve the interface
32949 (CodeGen): Property, used to keep track of the code generator.
32951 2001-07-26 Miguel de Icaza <miguel@ximian.com>
32953 * cs-parser.jay: Add a second production for delegate_declaration
32956 (enum_body): Put an opt_comma here instead of putting it on
32957 enum_body or enum_member_declarations so we can handle trailing
32958 commas on enumeration members. Gets rid of a shift/reduce.
32960 (type_list): Need a COMMA in the middle.
32962 (indexer_declaration): Tell tokenizer to recognize get/set
32964 * Remove old targets.
32966 * Re-add the parser target.
32968 2001-07-13 Simon Cozens <simon@simon-cozens.org>
32970 * cs-parser.jay: Add precendence rules for a number of operators
32971 ot reduce the number of shift/reduce conflicts in the grammar.
32973 2001-07-17 Miguel de Icaza <miguel@ximian.com>
32975 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
32978 Get rid of old crufty code.
32980 * rootcontext.cs: Use this to keep track of the parsed
32981 representation and the defined types available to the program.
32983 * gen-treedump.cs: adjust for new convention.
32985 * type.cs: Split out the type manager, and the assembly builder
32988 * typemanager.cs: the type manager will live here now.
32990 * cil-codegen.cs: And the code generator here.
32992 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
32994 * makefile: Fixed up for easy making.
32996 2001-07-13 Simon Cozens <simon@simon-cozens.org>
32998 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33001 (unary_expression): Expand pre_increment_expression and
33002 post_decrement_expression to reduce a shift/reduce.
33004 2001-07-11 Simon Cozens
33006 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33008 Improve allow_keyword_as_indent name.
33010 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33012 * Adjustments for Beta2.
33014 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33016 * decl.cs: Added `Define' abstract method.
33017 (InTransit): new property, used to catch recursive definitions.
33019 * interface.cs: Implement `Define'.
33021 * modifiers.cs: Map Modifiers.constants to
33022 System.Reflection.TypeAttribute flags.
33024 * class.cs: Keep track of types and user-defined types.
33025 (BuilderInit): New method for creating an assembly
33026 (ResolveType): New function to launch the resolution process, only
33027 used by interfaces for now.
33029 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33030 that are inserted into the name space.
33032 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33034 * ARGH. I have screwed up my tree so many times due to the use of
33035 rsync rather than using CVS. Going to fix this at once.
33037 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33040 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33042 * Experiment successful: Use System.Type rather that our own
33045 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33047 * cs-parser.jay: Removed nsAliases from here.
33049 Use new namespaces, handle `using XXX;'
33051 * namespace.cs: Reimplemented namespace handling, use a recursive
33052 definition of the class. Now we can keep track of using clauses
33053 and catch invalid using clauses.
33055 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33057 * gen-treedump.cs: Adapted for all the renaming.
33059 * expression.cs (Expression): this class now has a Type property
33060 which returns an expression Type.
33062 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33063 `Type', as this has a different meaning now in the base
33065 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33067 * interface.cs, class.cs: Removed from all the sources the
33068 references to signature computation, as we can not do method
33069 signature computation during the parsing time, as we are not
33070 trying to solve at that point distinguishing:
33074 void a (NS.Blah x) {}
33077 Which depending on the context might be valid or not, as we do not
33078 know if Blah is the same thing as NS.Blah at that point.
33080 * Redid everything so the code uses TypeRefs now instead of
33081 Types. TypeRefs are just temporary type placeholders, that need
33082 to be resolved. They initially have a pointer to a string and the
33083 current scope in which they are used. This is used later by the
33084 compiler to resolve the reference to an actual Type.
33086 * DeclSpace is no longer a CIR.Type, and neither are
33087 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33088 are all DeclSpaces, but no Types.
33090 * type.cs (TypeRefManager): This implements the TypeRef manager,
33091 which keeps track of all the types that need to be resolved after
33092 the parsing has finished.
33094 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33096 * ARGH. We are going to have to store `foreach' as a class rather
33097 than resolving it, as we need to verify error 1579 after name
33098 resolution. *OR* we could keep a flag that says `This request to
33099 IEnumerator comes from a foreach statement' which we can then use
33100 to generate the error.
33102 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33104 * class.cs (TypeContainer.AddMethod): we now add methods to the
33105 MethodGroup instead of the method hashtable.
33107 * expression.cs: Add MethodGroup abstraction, which gets us one
33108 step closer to the specification in the way we handle method
33111 * cs-parser.jay (primary_expression): qualified_identifier now
33112 tried to match up an identifier to a local variable reference or
33113 to a parameter reference.
33115 current_local_parameters is now a parser global variable that
33116 points to the current parameters for the block, used during name
33119 (property_declaration): Now creates an implicit `value' argument to
33122 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33124 * parameter.cs: Do not use `param' arguments as part of the
33125 signature, per the spec.
33127 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33129 * decl.cs: Base class for classes, structs and interfaces. This
33130 is the "Declaration Space"
33132 * cs-parser.jay: Use CheckDef for checking declaration errors
33133 instead of having one on each function.
33135 * class.cs: Factor out some code for handling error handling in
33136 accordance to the "Declarations" section in the "Basic Concepts"
33137 chapter in the ECMA C# spec.
33139 * interface.cs: Make all interface member classes derive from
33140 InterfaceMemberBase.
33142 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33144 * Many things: all interfaces are parsed and generated in
33145 gen-treedump. Support for member variables, constructors,
33146 destructors, properties, constants is there.
33148 Beginning of the IL backend, but very little done, just there for
33151 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33153 * cs-parser.jay: Fix labeled statement.
33155 * cs-tokenizer.cs (escape): Escape " and ' always.
33156 ref_line, ref_name: keep track of the line/filename as instructed
33157 by #line by the compiler.
33160 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33162 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33163 to match the values in System.CodeDOM.
33165 Divid renamed to Divide.
33167 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33169 (Statements.set): remove.
33171 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33174 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33175 falseStatements always have valid values.
33177 * cs-parser.jay: Use System.CodeDOM now.