From bcf2514e1484bdd824201decb5f25dc5788d0ca7 Mon Sep 17 00:00:00 2001
From: Barry Warsaw <barry@python.org>
Date: Fri, 3 Jun 2016 11:49:23 -0700
Subject: [PATCH] Fixes #237

Nonmember subscriptions are removed when one of the addresses controlled by
a user is subscribed as a member.  Given by Aditya Divekar.  (Closes #237)
---
 src/mailman/app/membership.py            | 12 +++++------
 src/mailman/app/tests/test_membership.py | 37 +++++++++++++++++++++++---------
 src/mailman/docs/NEWS.rst                |  2 ++
 3 files changed, 35 insertions(+), 16 deletions(-)

diff --git a/src/mailman/app/membership.py b/src/mailman/app/membership.py
index 6e6ceb942..8b4d7ff30 100644
--- a/src/mailman/app/membership.py
+++ b/src/mailman/app/membership.py
@@ -90,12 +90,12 @@ def add_member(mlist, record, role=MemberRole.member):
             error.fqdn_listname, record.email, error.role)
     member.preferences.preferred_language = record.language
     member.preferences.delivery_mode = record.delivery_mode
-    # Check and remove nonmember subscriptions of the user to this list
-    # if any.
-    for address in user.addresses:
-        nonmember = mlist.nonmembers.get_member(address.email)
-        if nonmember is not None:
-            nonmember.unsubscribe()
+    # Check for and remove nonmember subscriptions of the user to this list.
+    if role is MemberRole.member:
+        for address in user.addresses:
+            nonmember = mlist.nonmembers.get_member(address.email)
+            if nonmember is not None:
+                nonmember.unsubscribe()
     return member
 
 
diff --git a/src/mailman/app/tests/test_membership.py b/src/mailman/app/tests/test_membership.py
index 369f533ce..e41985df9 100644
--- a/src/mailman/app/tests/test_membership.py
+++ b/src/mailman/app/tests/test_membership.py
@@ -29,6 +29,7 @@ from mailman.interfaces.member import (
 from mailman.interfaces.subscriptions import RequestRecord
 from mailman.interfaces.usermanager import IUserManager
 from mailman.testing.layers import ConfigLayer
+from mailman.utilities.datetime import now
 from zope.component import getUtility
 
 
@@ -221,25 +222,41 @@ class TestAddMember(unittest.TestCase):
                               system_preferences.preferred_language))
         self.assertEqual(cm.exception.email, email.lower())
 
-    def test_delete_nonmember_on_adding_member(self):
-        add_member(
+    def test_delete_nonmembers_on_adding_member(self):
+        # GL: #237 - When a new address is subscribed, any existing nonmember
+        # subscriptions for this address; or any addresses also controlled by
+        # this user, are deleted.
+        anne_nonmember = add_member(
             self._mlist,
             RequestRecord('aperson@example.com', 'Anne Person',
                           DeliveryMode.regular,
                           system_preferences.preferred_language),
             MemberRole.nonmember)
-        add_member(
+        # Add a few other validated addresses to this user, and subscribe them
+        # as nonmembers.
+        for email in ('anne.person@example.com', 'a.person@example.com'):
+            address = anne_nonmember.user.register(email)
+            address.verified_on = now()
+            self._mlist.subscribe(address, MemberRole.nonmember)
+        # There are now three nonmembers.
+        self.assertEqual(
+            {address.email for address in self._mlist.nonmembers.addresses},
+            {'aperson@example.com',
+             'anne.person@example.com',
+             'a.person@example.com',
+             })
+        # Let's now add one of Anne's addresses as a member.  This deletes all
+        # of Anne's nonmember memberships.
+        anne_member = add_member(
             self._mlist,
-            RequestRecord('aperson@example.com', 'Anne Person',
+            RequestRecord('a.person@example.com', 'Anne Person',
                           DeliveryMode.regular,
                           system_preferences.preferred_language),
             MemberRole.member)
-        member_1 = self._mlist.nonmembers.get_member('aperson@example.com')
-        member_2 = self._mlist.members.get_member('aperson@example.com')
-        self.assertIsNone(member_1)
-        self.assertIsNotNone(member_2)
-        self.assertEqual(member_2.role, MemberRole.member)
-        self.assertEqual(member_2.list_id, self._mlist.list_id)
+        self.assertEqual(self._mlist.nonmembers.member_count, 0)
+        members = list(self._mlist.members.members)
+        self.assertEqual(len(members), 1)
+        self.assertEqual(members[0], anne_member)
 
 
 class TestDeleteMember(unittest.TestCase):
diff --git a/src/mailman/docs/NEWS.rst b/src/mailman/docs/NEWS.rst
index 7e3dd98e6..d11c44910 100644
--- a/src/mailman/docs/NEWS.rst
+++ b/src/mailman/docs/NEWS.rst
@@ -83,6 +83,8 @@ Bugs
    (Closes #226)
  * MIME digests now put the individual message/rfc822 messages inside a
    multipart/digest subpart.  (Closes #234)
+ * Nonmember subscriptions are removed when one of the addresses controlled by
+   a user is subscribed as a member.  Given by Aditya Divekar.  (Closes #237)
 
 Configuration
 -------------
-- 
2.11.4.GIT