From 7a8d5537d38fc0815fed9ad89e1a9e987080c020 Mon Sep 17 00:00:00 2001 From: Martin Storsjo Date: Mon, 3 Dec 2018 20:02:11 +0000 Subject: [PATCH] [COFF] Remove an outdated/incorrect comment. NFC. Making the section writable doesn't affect how windows does base relocs in case a DLL can't be loaded at the intended base address. This comment dates back to SVN r79346. Differential Revision: git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@348178 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/MC/MCObjectFileInfo.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/MC/MCObjectFileInfo.cpp b/lib/MC/MCObjectFileInfo.cpp index c73a9eb2c9e..be671af1768 100644 --- a/lib/MC/MCObjectFileInfo.cpp +++ b/lib/MC/MCObjectFileInfo.cpp @@ -510,10 +510,6 @@ void MCObjectFileInfo::initCOFFMCObjectFileInfo(const Triple &T) { ".rdata", COFF::IMAGE_SCN_CNT_INITIALIZED_DATA | COFF::IMAGE_SCN_MEM_READ, SectionKind::getReadOnly()); - // FIXME: We're emitting LSDA info into a readonly section on COFF, even - // though it contains relocatable pointers. In PIC mode, this is probably a - // big runtime hit for C++ apps. Either the contents of the LSDA need to be - // adjusted or this should be a data section. if (T.getArch() == Triple::x86_64) { // On Windows 64 with SEH, the LSDA is emitted into the .xdata section LSDASection = nullptr; -- 2.11.4.GIT