| commit | 6d9c153a0b84392406bc77600aa7d3ea365de041 | |
| author | Florian Fainelli <f.fainelli@gmail.com> | |
| Sat, 2 Sep 2017 15:56:45 +0000 (2 08:56 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Mon, 4 Sep 2017 03:18:25 +0000 (3 20:18 -0700) | ||
| tree | e2fc30d0c51629f96443233b24c1de88b383d27a | treesnapshot (tar.gz zip) |
| parent | 443cb3a32101a2f3201f417d7342017666666116 | commitdiff |
net: dsa: loop: Do not unregister invalid fixed PHY
During error injection it was possible to crash in dsa_loop_exit() because of
an attempt to unregister an invalid PHY. We actually want to the driver probing
in dsa_loop_init() even though fixed_phy_register() may return an error to
exercise how DSA deals with such cases, but we should not be crashing during
driver removal.
Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
During error injection it was possible to crash in dsa_loop_exit() because of
an attempt to unregister an invalid PHY. We actually want to the driver probing
in dsa_loop_init() even though fixed_phy_register() may return an error to
exercise how DSA deals with such cases, but we should not be crashing during
driver removal.
Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/dsa/dsa_loop.c | diffblobblamehistory |