| commit | 4291e45df5cc06ff47a3124cd2857a6513174dd6 | |
| author | Colin Ian King <colin.king@canonical.com> | |
| Sat, 4 May 2019 16:48:29 +0000 (4 17:48 +0100) | ||
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
| Wed, 19 Jun 2019 06:20:57 +0000 (19 08:20 +0200) | ||
| tree | 59fed17a0238dbec1167475ba42e7be7dd1ee1df | treesnapshot (tar.gz zip) |
| parent | a415e2db35b90200b1990cd2c4024c13859ccd14 | commitdiff |
scsi: bnx2fc: fix incorrect cast to u64 on shift operation
[ Upstream commit d0c0d902339249c75da85fd9257a86cbb98dfaa5 ]
Currently an int is being shifted and the result is being cast to a u64
which leads to undefined behaviour if the shift is more than 31 bits. Fix
this by casting the integer value 1 to u64 before the shift operation.
Addresses-Coverity: ("Bad shift operation")
Fixes: 7b594769120b ("[SCSI] bnx2fc: Handle REC_TOV error code from firmware")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
[ Upstream commit d0c0d902339249c75da85fd9257a86cbb98dfaa5 ]
Currently an int is being shifted and the result is being cast to a u64
which leads to undefined behaviour if the shift is more than 31 bits. Fix
this by casting the integer value 1 to u64 before the shift operation.
Addresses-Coverity: ("Bad shift operation")
Fixes: 7b594769120b ("[SCSI] bnx2fc: Handle REC_TOV error code from firmware")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| drivers/scsi/bnx2fc/bnx2fc_hwi.c | diffblobblamehistory |