| commit | 53b0f08042f04813cd1a7473dacd3edfacb28eb3 | |
| author | Eric Dumazet <eric.dumazet@gmail.com> | |
| Sat, 22 May 2010 20:37:44 +0000 (22 20:37 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Mon, 24 May 2010 06:11:07 +0000 (23 23:11 -0700) | ||
| tree | 025244cdb7c4f0872f372564de2b82130fc7e867 | treesnapshot (tar.gz zip) |
| parent | a6c0f8217c17d46da22fa56923f3cbd03615cb7c | commitdiff |
net_sched: Fix qdisc_notify()
Ben Pfaff reported a kernel oops and provided a test program to
reproduce it.
https://kerneltrap.org/mailarchive/linux-netdev/2010/5/21/6277805
tc_fill_qdisc() should not be called for builtin qdisc, or it
dereference a NULL pointer to get device ifindex.
Fix is to always use tc_qdisc_dump_ignore() before calling
tc_fill_qdisc().
Reported-by: Ben Pfaff <blp@nicira.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Ben Pfaff reported a kernel oops and provided a test program to
reproduce it.
https://kerneltrap.org/mailarchive/linux-netdev/2010/5/21/6277805
tc_fill_qdisc() should not be called for builtin qdisc, or it
dereference a NULL pointer to get device ifindex.
Fix is to always use tc_qdisc_dump_ignore() before calling
tc_fill_qdisc().
Reported-by: Ben Pfaff <blp@nicira.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/sched/sch_api.c | diffblobblamehistory |