| commit | b2e0852e1eee7c445b1789bef41204b64f981102 | |
| author | Michael Ellerman <michael@ellerman.id.au> | |
| Thu, 12 May 2005 08:09:45 +0000 (12 18:09 +1000) | ||
| committer | Jeff Garzik <jgarzik@pobox.com> | |
| Sun, 15 May 2005 22:08:06 +0000 (15 18:08 -0400) | ||
| tree | a1c0465f681b7aae24d0ade106f68593e74a8346 | treesnapshot (tar.gz zip) |
| parent | 41664c03f6c96a1f8a91714309b36f1b5ca85610 | commitdiff |
[PATCH] iseries_veth: Cleanup skbs to prevent unregister_netdevice() hanging
Hi Andrew, Jeff,
The iseries_veth driver is badly behaved in that it will keep TX packets
hanging around forever if they're not ACK'ed and the queue never fills up.
This causes the unregister_netdevice code to wait forever when we try to take
the device down, because there's still skbs around with references to our
struct net_device.
There's already code to cleanup any un-ACK'ed packets in veth_stop_connection()
but it's being called after we unregister the net_device, which is too late.
The fix is to rearrange the module exit function so that we cleanup any
outstanding skbs and then unregister the driver.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Hi Andrew, Jeff,
The iseries_veth driver is badly behaved in that it will keep TX packets
hanging around forever if they're not ACK'ed and the queue never fills up.
This causes the unregister_netdevice code to wait forever when we try to take
the device down, because there's still skbs around with references to our
struct net_device.
There's already code to cleanup any un-ACK'ed packets in veth_stop_connection()
but it's being called after we unregister the net_device, which is too late.
The fix is to rearrange the module exit function so that we cleanup any
outstanding skbs and then unregister the driver.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
| drivers/net/iseries_veth.c | diffblobblamehistory |