| commit | 59f91ff11e594913a5b3c03a4707fdf02338c8df | |
| author | Henrique de Moraes Holschuh <hmh@hmh.eng.br> | |
| Sun, 18 Nov 2007 11:18:29 +0000 (18 09:18 -0200) | ||
| committer | Len Brown <len.brown@intel.com> | |
| Mon, 19 Nov 2007 21:10:04 +0000 (19 16:10 -0500) | ||
| tree | 112aedb786b0785972f55853157ebe4752fc6265 | treesnapshot (tar.gz zip) |
| parent | 4273af8d08c823d5898a2b1c2d0f25b4a8b9eaee | commitdiff |
ACPI: thinkpad-acpi: fix oops when a module parameter has no value
set_ibm_param() could OOPS with a NULL pointer derreference if one did not give
any values for a module parameter it handles. This would, of course, cause all
sort of trouble for future modprobing and require a reboot to clean up
properly.
Fix it by returning -EINVAL if no values are given for the parameter, and also
avoid any nastyness from BUG_ON while at it.
How to reproduce: modprobe thinkpad-acpi brightness
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Tested-by: Mike Kershaw <dragorn@kismetwireless.net>
Signed-off-by: Len Brown <len.brown@intel.com>
set_ibm_param() could OOPS with a NULL pointer derreference if one did not give
any values for a module parameter it handles. This would, of course, cause all
sort of trouble for future modprobing and require a reboot to clean up
properly.
Fix it by returning -EINVAL if no values are given for the parameter, and also
avoid any nastyness from BUG_ON while at it.
How to reproduce: modprobe thinkpad-acpi brightness
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Tested-by: Mike Kershaw <dragorn@kismetwireless.net>
Signed-off-by: Len Brown <len.brown@intel.com>
| drivers/misc/thinkpad_acpi.c | diffblobblamehistory |