| commit | 867556fe740d0d29a05fce99d2d960625077ed45 | |
| author | Alex Chiang <achiang@hp.com> | |
| Tue, 31 Mar 2009 15:23:36 +0000 (31 09:23 -0600) | ||
| committer | Jesse Barnes <jbarnes@virtuousgeek.org> | |
| Thu, 11 Jun 2009 19:04:11 +0000 (11 12:04 -0700) | ||
| tree | 7e8887ec31f59ea43c147e31290281640947f35c | treesnapshot (tar.gz zip) |
| parent | 04225fe7e6877493765b9cfa3092524e21e020d7 | commitdiff |
PCI Hotplug: cpqphp: refactor cpqhp_probe
Apply DeMorgan's theorem:
if ((pdev->revision > 2) || (vendor_id == PCI_VENDOR_ID_INTEL))
turns into
if ((pdev->revision <= 2) && (vendor_id != PCI_VENDOR_ID_INTEL))
Now we can bail out early from the function if the controller is not
supported.
This allows us to un-indent the remainder of the function quite a bit and
make it much more readable.
Fix up some extra braces, and un-indent the 'case' labels in the switch
statement as per CodingStyle.
No functional change.
Signed-off-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Apply DeMorgan's theorem:
if ((pdev->revision > 2) || (vendor_id == PCI_VENDOR_ID_INTEL))
turns into
if ((pdev->revision <= 2) && (vendor_id != PCI_VENDOR_ID_INTEL))
Now we can bail out early from the function if the controller is not
supported.
This allows us to un-indent the remainder of the function quite a bit and
make it much more readable.
Fix up some extra braces, and un-indent the 'case' labels in the switch
statement as per CodingStyle.
No functional change.
Signed-off-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
| drivers/pci/hotplug/cpqphp_core.c | diffblobblamehistory |