ide: Fix IDE taskfile with cfq scheduler
commit720fc22a7af79d91ec460c80efa92c65c12d105e
authorMikulas Patocka <mpatocka@redhat.com>
Tue, 6 Apr 2010 23:43:33 +0000 (6 16:43 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 6 Apr 2010 23:43:33 +0000 (6 16:43 -0700)
tree87cf610c59bd1f1916083f067145779f31942274
parent1af185034662b75279f90e1c7cb958271d4121e2
ide: Fix IDE taskfile with cfq scheduler

When ide taskfile access is being used (for example with hdparm --security
commands) and cfq scheduler is selected, the scheduler crashes on BUG in
cfq_put_request.

The reason is that the cfq scheduler is tracking counts of read and write
requests separately; the ide-taskfile subsystem allocates a read request and
then flips the flag to make it a write request. The counters in cfq will
mismatch.

This patch changes ide-taskfile to allocate the READ or WRITE request as
required and don't change the flag later.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ide/ide-taskfile.c