| commit | fc5a9f8841ee87d93376ada5d73117d4d6a373ea | |
| author | Holger Macht <hmacht@suse.de> | |
| Tue, 20 Jan 2009 11:18:24 +0000 (20 12:18 +0100) | ||
| committer | Len Brown <len.brown@intel.com> | |
| Sat, 7 Feb 2009 03:08:15 +0000 (6 22:08 -0500) | ||
| tree | ca1098636b4918c00a49faf34c4e0d6e99852296 | treesnapshot (tar.gz zip) |
| parent | 9e3a9d1ed8cc8db93e5c53e9a5b09065bd95de8b | commitdiff |
ACPI: dock: Don't eval _STA on every show_docked sysfs read
Some devices trigger a DEVICE_CHECK on every evalutation of _STA. This
can also be seen in commit 8b59560a3baf2e7c24e0fb92ea5d09eca92805db
(ACPI: dock: avoid check _STA method). If an undock is processed, the
dock driver sends a uevent and userspace might read the show_docked
property in sysfs. This causes an evaluation of _STA of the particular
device which causes the dock driver to immediately dock again.
In any case, evaluation of _STA (show_docked) does not necessarily mean
that we are docked, so check with the internal device structure.
http://bugzilla.kernel.org/show_bug.cgi?id=12360
Signed-off-by: Holger Macht <hmacht@suse.de>
Signed-off-by: Len Brown <len.brown@intel.com>
Some devices trigger a DEVICE_CHECK on every evalutation of _STA. This
can also be seen in commit 8b59560a3baf2e7c24e0fb92ea5d09eca92805db
(ACPI: dock: avoid check _STA method). If an undock is processed, the
dock driver sends a uevent and userspace might read the show_docked
property in sysfs. This causes an evaluation of _STA of the particular
device which causes the dock driver to immediately dock again.
In any case, evaluation of _STA (show_docked) does not necessarily mean
that we are docked, so check with the internal device structure.
http://bugzilla.kernel.org/show_bug.cgi?id=12360
Signed-off-by: Holger Macht <hmacht@suse.de>
Signed-off-by: Len Brown <len.brown@intel.com>
| drivers/acpi/dock.c | diffblobblamehistory |