| commit | caa9ee771de3195ae85ac6f8cb550f53e9ecdd82 | |
| author | Oleg Nesterov <oleg@tv-sign.ru> | |
| Fri, 24 Mar 2006 11:15:50 +0000 (24 03:15 -0800) | ||
| committer | Linus Torvalds <torvalds@g5.osdl.org> | |
| Fri, 24 Mar 2006 15:33:20 +0000 (24 07:33 -0800) | ||
| tree | 8aa692f337e071718e698baefc631b58b446beff | treesnapshot (tar.gz zip) |
| parent | cba9f33d13a8ca3125b2a30abe2425ce562d8a83 | commitdiff |
[PATCH] rcu_process_callbacks: don't cli() while testing ->nxtlist
__rcu_process_callbacks() disables interrupts to protect itself from
call_rcu() which adds new entries to ->nxtlist.
However we can check "->nxtlist != NULL" with interrupts enabled, we can't
get "false positives" because call_rcu() can only change this condition
from 0 to 1.
Tested with rcutorture.ko.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Dipankar Sarma <dipankar@in.ibm.com>
Cc: "Paul E. McKenney" <paulmck@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
__rcu_process_callbacks() disables interrupts to protect itself from
call_rcu() which adds new entries to ->nxtlist.
However we can check "->nxtlist != NULL" with interrupts enabled, we can't
get "false positives" because call_rcu() can only change this condition
from 0 to 1.
Tested with rcutorture.ko.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Dipankar Sarma <dipankar@in.ibm.com>
Cc: "Paul E. McKenney" <paulmck@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| kernel/rcupdate.c | diffblobblamehistory |