| commit | 61e9916eba35dfb76d38013a5aae9a59cc50877a | |
| author | Johannes Berg <johannes@sipsolutions.net> | |
| Wed, 24 Sep 2008 22:56:25 +0000 (24 22:56 +0000) | ||
| committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | |
| Tue, 30 Sep 2008 03:25:06 +0000 (30 13:25 +1000) | ||
| tree | d1c6cc37aeb4ec570da99fd463702bc8fe853984 | treesnapshot (tar.gz zip) |
| parent | ad611045ce5d059af84a9855b22ca3f7a99d47be | commitdiff |
powerpc: Fix failure to shutdown with CPU hotplug
I tracked down the shutdown regression to CPUs not dying
when being shut down during power-off. This turns out to
be due to the system_state being SYSTEM_POWER_OFF, which
this code doesn't take as a valid state for shutting off
CPUs in.
This has never made sense to me, but when I added hotplug
code to implement hibernate I only "made it work" and did
not question the need to check the system_state. Thomas
Gleixner helped me dig, but the only thing we found is
that it was added with the original commit that added CPU
hotplug support.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Joel Schopp <jschopp@austin.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
I tracked down the shutdown regression to CPUs not dying
when being shut down during power-off. This turns out to
be due to the system_state being SYSTEM_POWER_OFF, which
this code doesn't take as a valid state for shutting off
CPUs in.
This has never made sense to me, but when I added hotplug
code to implement hibernate I only "made it work" and did
not question the need to check the system_state. Thomas
Gleixner helped me dig, but the only thing we found is
that it was added with the original commit that added CPU
hotplug support.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Joel Schopp <jschopp@austin.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
| arch/powerpc/kernel/idle.c | diffblobblamehistory |