| commit | 4965291acf8cc2c31dcb2fc7d292a04ee08da2dd | |
| author | Jarek Poplawski <jarkao2@gmail.com> | |
| Wed, 2 Apr 2008 06:56:17 +0000 (1 23:56 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Wed, 2 Apr 2008 06:56:17 +0000 (1 23:56 -0700) | ||
| tree | f38695b8fcdee173cf714222193c8f12274ba879 | treesnapshot (tar.gz zip) |
| parent | d43c7b37ad787173d08683f05eadeea0398fefdf | commitdiff |
[ROSE/AX25] af_rose: rose_release() fix
rose_release() doesn't release sockets properly, e.g. it skips
sock_orphan(), so OOPSes are triggered in sock_def_write_space(),
which was observed especially while ROSE skbs were kfreed from
ax25_frames_acked(). There is also sock_hold() and lock_sock() added -
similarly to ax25_release(). Thanks to Bernard Pidoux for substantial
help in debugging this problem.
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Reported-and-tested-by: Bernard Pidoux <bpidoux@free.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
rose_release() doesn't release sockets properly, e.g. it skips
sock_orphan(), so OOPSes are triggered in sock_def_write_space(),
which was observed especially while ROSE skbs were kfreed from
ax25_frames_acked(). There is also sock_hold() and lock_sock() added -
similarly to ax25_release(). Thanks to Bernard Pidoux for substantial
help in debugging this problem.
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Reported-and-tested-by: Bernard Pidoux <bpidoux@free.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/rose/af_rose.c | diffblobblamehistory |