| commit | f3fcd7f6351e8a95e6f1c2b9fda79b6dbecfc6ca | |
| author | Stephen Hemminger <shemminger@osdl.org> | |
| Mon, 30 Oct 2006 22:47:35 +0000 (30 14:47 -0800) | ||
| committer | Chris Wright <chrisw@sous-sol.org> | |
| Sat, 4 Nov 2006 01:33:50 +0000 (3 17:33 -0800) | ||
| tree | 6f47670075ce8c21a7fc5fa424682e751d38de32 | treesnapshot (tar.gz zip) |
| parent | a5f1d1d1849ca848c0ab49dd987070415ad2ede5 | commitdiff |
[PATCH] tcp: cubic scaling error
Doug Leith observed a discrepancy between the version of CUBIC described
in the papers and the version in 2.6.18. A math error related to scaling
causes Cubic to grow too slowly.
Patch is from "Sangtae Ha" <sha2@ncsu.edu>. I validated that
it does fix the problems.
See the following to show behavior over 500ms 100 Mbit link.
Sender (2.6.19-rc3) --- Bridge (2.6.18-rt7) ------- Receiver (2.6.19-rc3)
1G [netem] 100M
http://developer.osdl.org/shemminger/tcp/2.6.19-rc3/cubic-orig.png
http://developer.osdl.org/shemminger/tcp/2.6.19-rc3/cubic-fix.png
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Doug Leith observed a discrepancy between the version of CUBIC described
in the papers and the version in 2.6.18. A math error related to scaling
causes Cubic to grow too slowly.
Patch is from "Sangtae Ha" <sha2@ncsu.edu>. I validated that
it does fix the problems.
See the following to show behavior over 500ms 100 Mbit link.
Sender (2.6.19-rc3) --- Bridge (2.6.18-rt7) ------- Receiver (2.6.19-rc3)
1G [netem] 100M
http://developer.osdl.org/shemminger/tcp/2.6.19-rc3/cubic-orig.png
http://developer.osdl.org/shemminger/tcp/2.6.19-rc3/cubic-fix.png
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
| net/ipv4/tcp_cubic.c | diffblobblamehistory |